Hello Sami,
On 3/9/23 12:11, Sami Mujawar wrote:
Hi Pierre,
On Tue, Oct 4, 2022 at 01:22 AM, PierreGondois wrote:
+EFI_STATUS
+EFIAPI
+StringTablePublishStringSet (
+ IN STRING_TABLE *CONST StrTable,
+ IN CHAR8 *CONST
On Fri, Mar 03, 2023 at 12:04:09PM -0600, Andrei Warkentin wrote:
> These are implementations of SerialPortLib using SBI console services.
> - SecPeiRiscVSerialPortLibSbi is appropriate for SEC/PEI (XIP) environments
> - PrePiDxeRiscVSerialPortLibSbi is appropriate for PrePI/DXE environments
>
>
Merged
PR: https://github.com/tianocore/edk2/pull/4129
Commit:
https://github.com/tianocore/edk2/commit/fd1820b7ea09e53e404d6f56bb8bc4b51a5dd83e
Mike
From: devel@edk2.groups.io On Behalf Of Darbin Reyes
Sent: Thursday, March 9, 2023 8:31 PM
To: devel@edk2.groups.io; Reyes, Darbin ; Dong,
On Fri, Mar 03, 2023 at 12:04:10PM -0600, Andrei Warkentin wrote:
> If the SerialPortLib had any initialization needed, this
> would be skipped in the RiscVVirt Sec. Follow the example
> seen elsewhere (ArmVirtPkg PrePi).
>
> Seen with BaseSerialPortLibRiscVSbi not using DBCN in Sec, yet
> using
On Fri, Mar 03, 2023 at 12:04:08PM -0600, Andrei Warkentin wrote:
> Add a few more definitions and make SbiCall and TranslateError
> usable (not static) by library users.
>
> Cc: Daniel Schaefer
> Cc: Sunil V L
> Acked-by: Gerd Hoffmann
> Signed-off-by: Andrei Warkentin
> ---
Reviewed-by:
Hi Liming,
I've checked edk2 and edk2-platforms repo. This code change doesn't impacted
any code.
The MultiprocessorWakeupMailbox structure has not been used yet.
Thanks,
Dun
-Original Message-
From: gaoliming
Sent: Friday, March 10, 2023 10:16 AM
To: Tan, Dun ; devel@edk2.groups.io
On Mon, Mar 06, 2023 at 09:10:58AM -0800, Tuan Phan wrote:
> When the range instruction cache invalidating not supported, the whole
> instruction cache should be invalidated instead.
>
> Signed-off-by: Tuan Phan
> ---
> MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c | 5 -
> 1 file
Merged https://github.com/tianocore/edk2/pull/4128
> -Original Message-
> From: Sheng, W
> Sent: Tuesday, February 28, 2023 10:44 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Yao, Jiewen
> ; Lu, Xiaoyu1 ; Jiang,
> Guomin
> Subject: [PATCH v2] CryptoPkg/OpensslLib: Upgrade OpenSSL
Reviewed-by: Eric Dong
-Original Message-
From: devel@edk2.groups.io On Behalf Of Darbin Reyes
Sent: Wednesday, March 8, 2023 7:04 AM
To: devel@edk2.groups.io
Cc: Reyes, Darbin ; Narey, Jacob
Subject: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix exception
REF:
+ @UefiCpuPkg Maintainers
Requesting an estimated ETA on integration of this 1 character patch.
I understand the patch queue is huge, just looking to provide a realistic
expectation to those who are blocked by this and waiting for me to provide an
update.
Warm Regards,
Darbin
Fix patch has been pushed with commit message typo and format correction:
https://github.com/tianocore/edk2/commit/8820767fb3bad09eeedecc3030d75c9e0cd4cab7
Thanks,
Chasel
> -Original Message-
> From: S, Ashraf Ali
> Sent: Thursday, March 9, 2023 8:06 AM
> To: devel@edk2.groups.io
>
On Fri, Mar 10, 2023 at 10:13:42AM +0800, gaoliming via groups.io wrote:
> Tuan:
>
> Can __FUNCTION__ be used? If yes, please still keep it.
>
Hi Liming,
I had suggested this. There are efforts to move to using __func__.
https://edk2.groups.io/g/devel/message/99904
I think, we better start
Rebecca:
Why new file name is not SdramSpdDdr5.h?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Rebecca Cran
> 发送时间: 2023年2月14日 23:37
> 收件人: Kinney, Michael D ;
> devel@edk2.groups.io; Gao, Liming
> 抄送: 'Liming Gao' ; Liu, Zhiguang
>
> 主题: Re: [edk2-devel] [PATCH 1/1]
Rebecca:
I think these changes are good. Reviewed-by: Liming Gao
Besides, which tool is used to convert function comments to Doxygen
format?
Thanks
Liming
> -邮件原件-
> 发件人: Rebecca Cran
> 发送时间: 2023年2月25日 8:54
> 收件人: devel@edk2.groups.io; Bob Feng ; Liming
> Gao ; Yuwei Chen
> 抄送:
Rebecca:
I add my comments below.
> -邮件原件-
> 发件人: Rebecca Cran
> 发送时间: 2023年2月15日 3:07
> 收件人: devel@edk2.groups.io; Michael D Kinney
> ; Liming Gao ;
> Zhiguang Liu
> 抄送: Rebecca Cran
> 主题: [PATCH 1/1] MdePkg: Add new JedecJep106Lib to fetch JEDEC JEP106
> manufacturer
>
> Add a
Rebecca:
This patch pass code review. It can be merged now. The second change to using
__func__ is only for MdePkg. Do you expect the change in MdePkg is first merged?
Thanks
Liming
> -邮件原件-
> 发件人: Rebecca Cran
> 发送时间: 2023年3月7日 0:39
> 收件人: devel@edk2.groups.io;
Pawel:
The change in MdeModulePkg looks good to me. Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Pawe?
> Po?awski
> 发送时间: 2023年2月17日 21:02
> 收件人: devel@edk2.groups.io
> 主题: [edk2-devel] PATCH v3 0/3 Add xterm resize support to OVMF
>
> This set of
FVMAIN_COMPACT is not reported to DXE. So, it can’t be found in DXE phase.
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Alireza Banejad
发送时间: 2023年3月2日 20:16
收件人: devel@edk2.groups.io; alibanejad1...@gmail.com
主题: Re: [edk2-devel] GetSectionFromAnyFv doesnt find file from FV
So, I
PR https://github.com/tianocore/edk2/pull/4127 is created for this patch.
Thanks
Liming
发件人: devel@edk2.groups.io 代表 gaoliming via groups.io
发送时间: 2023年3月9日 8:55
收件人: devel@edk2.groups.io; ray...@intel.com; 'Tan, Lean Sheng'
抄送: 'Wang, Jian J'
主题: 回复: [edk2-devel] [PATCH 1/3]
Dun:
Is there any code impact with this change?
Thanks
Liming
> -邮件原件-
> 发件人: Dun Tan
> 发送时间: 2023年3月9日 11:40
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu
> 主题: [Patch V3 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in
> MpWakeupStructure
>
>
Tuan:
Can __FUNCTION__ be used? If yes, please still keep it.
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Tuan Phan
发送时间: 2023年3月10日 3:19
收件人: devel@edk2.groups.io
抄送: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn;
zhiguang@intel.com; suni...@ventanamicro.com;
Reviewed-by: Star Zeng with typo defination -> definition
fixed in commit message.
-Original Message-
From: Chaganty, Rangasai V
Sent: Friday, March 10, 2023 8:27 AM
To: S, Ashraf Ali ; devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Zeng, Star
Subject: RE: [PATCH]
Reviewed-by: Sai Chaganty
-Original Message-
From: S, Ashraf Ali
Sent: Thursday, March 09, 2023 8:06 AM
To: devel@edk2.groups.io
Cc: S, Ashraf Ali ; Chiu, Chasel
; Desimone, Nathaniel L
; Chaganty, Rangasai V
; Zeng, Star
Subject: [PATCH] [IntelFsp2Pkg]: Fix GCC Compiler warning
Reviewed-by: Nate DeSimone
-Original Message-
From: S, Ashraf Ali
Sent: Thursday, March 9, 2023 8:06 AM
To: devel@edk2.groups.io
Cc: S, Ashraf Ali ; Chiu, Chasel
; Desimone, Nathaniel L
; Chaganty, Rangasai V
; Zeng, Star
Subject: [PATCH] [IntelFsp2Pkg]: Fix GCC Compiler warning
Hi Tuan,
Could you share a GitHub link to a branch with the patch set? Somehow my email
client is mangling one of your patches where it’s all one giant line of code.
A
From: Tuan Phan
Sent: Thursday, March 9, 2023 1:20 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Gao, Liming
; Liu,
From: Sean Brogan
Create SECURITY.md security policy for tianocore edk2 leveraging CVD and
the Github Private Vulnerability Reporting process.
Co-authored-by: Sean Brogan
Signed-off-by: Kun Qin
---
SECURITY.md | 33
1 file changed, 33 insertions(+)
diff --git
This change added a markdown file as a policy guideline for Tianocore EDK2
community to handle security sensitive reports.
Patch v1 branch: https://github.com/kuqin12/edk2/tree/patch-1
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Miki Demeter
Cc: Sean Brogan
Sean Brogan (1):
Hi All,Any updates on this series? Thanks, From: Tuan PhanSent: Monday, March 6, 2023 9:33 AMTo: devel@edk2.groups.ioCc: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn; zhiguang@intel.com; suni...@ventanamicro.com; g...@danielschaefer.me; andrei.warken...@intel.com; Tuan PhanSubject:
Hi All,Any updates on this patch? Thanks, From: Tuan Phan via groups.ioSent: Monday, March 6, 2023 9:11 AMTo: devel@edk2.groups.ioCc: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn; zhiguang@intel.com; suni...@ventanamicro.com; g...@danielschaefer.me; Tuan PhanSubject: [edk2-devel]
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Chen, Christine
> Sent: Wednesday, March 8, 2023 6:55 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Feng, Bob C
> ; Gao, Liming
>
> Subject: [PATCH] Maintainers: Add 'Yuwei Chen' as BaseTools maintainer.
>
> Add
Thanks for fixing this bug!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: S, Ashraf Ali
> Sent: Thursday, March 9, 2023 8:06 AM
> To: devel@edk2.groups.io
> Cc: S, Ashraf Ali ; Chiu, Chasel
> ;
> Desimone, Nathaniel L ; Chaganty, Rangasai
> V ; Zeng, Star
> Subject:
Function defination should match with declaration.
[-Wlto-type-mismatch]
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Sai Chaganty
Cc: Star Zeng
Signed-off-by: Ashraf Ali S
---
IntelFsp2Pkg/Library/BaseFspPlatformLib/FspPlatformNotify.c | 1 +
1 file changed, 1 insertion(+)
diff --git
Could I get some reviews on this please?
Thanks.
Rebecca Cran
On 2/16/23 8:50 PM, Rebecca Cran wrote:
Currently, the BaseTools Makefiles use BUILD_CC and BUILD_CXX, which
doesn't allow users to override the compiler to use in the expected way
by running e.g. "make CC=clang-17
From: Abner Chang
BMC exposed USB NIC platform Redfish Host Interface
library implementation.
Signed-off-by: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
---
RedfishPkg/RedfishPkg.dec | 10 +
.../PlatformHostInterfaceBmcUsbNicLib.inf | 48 +
From: Abner Chang
Update Redfish DSC for
PlatformHostInterfaceBmcUsbNicLib.
Signed-off-by: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
---
RedfishPkg/RedfishPkg.dsc | 7 +++
1 file changed, 7 insertions(+)
diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc
index
From: Abner Chang
BZ #: 4282
Implement the platform Redfish host interface library that
uses IPMI commands to get the network information of
BMC-exposed USB NIC for building up the SMBIOS type 42
record.
The prerequisites: BZ #4213, 4214 and 4231
Check "Platform with BMC and the BMC-Exposed
From: Pierre Gondois
The topology of a platform is represented in ACPI using the PPTT
table. It is possible to append information to CPUs/processor
containers using their associated AML nodes in a SSDT
table.
A platform might have multiple 'physical packages' (or top-level
nodes) in their PPTT
Hi Abner,
I'm not sure if I understand this module completely.
This module is another IPMI solution? we will utilize either
ManageabilityPkg (using IPMI protocol specified in the EDK2 repo) or
IpmiFeaturePkg (using IpmiTransportProtocol). How do I use
IpmiCommandLib
Thanks Christine.
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Thursday, March 9, 2023 10:55 AM
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Feng, Bob C
; Gao, Liming
Subject: [PATCH] Maintainers: Add 'Yuwei Chen' as BaseTools maintainer.
Add myself as
We are not updating the BMC status in the switch()( *default case* ), which may
lead to installing the IPMI protocol for the failure case too. Could you please
initialize the BMC status in the default case also?
switch ( SelfTestResult->Result ) {
case IPMI_APP_SELFTEST_NO_ERROR:
case
Reviewed-by: Gua Guo
-Original Message-
From: Dhaval Sharma
Sent: Thursday, March 9, 2023 6:37 PM
To: devel@edk2.groups.io
Cc: Dong, Guo ; Ni, Ray ; Sean Rhodes
; Lu, James ; Guo, Gua
Subject: [PATCH v3 2/2] UefiPayloadPkg: Move INT prog outside common flow
8259 is very arch
Hi Pierre,
On Tue, Oct 4, 2022 at 01:22 AM, PierreGondois wrote:
>
>
>>
>>> +EFI_STATUS
>>> +EFIAPI
>>> +StringTablePublishStringSet (
>>> + IN STRING_TABLE *CONST StrTable,
>>> + IN CHAR8 *CONST SmbiosStringAreaStart,
>>> + IN CONST UINTN SmbiosStringAreaSize
>>> + )
>>> +{
>>> + UINT8
Use the new crypto support include files.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/IntelTdx/IntelTdxX64.dsc | 15 +--
OvmfPkg/IntelTdx/IntelTdxX64.fdf | 5 +
2 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/OvmfPkg/IntelTdx/IntelTdxX64.dsc
Use the new crypto support include files.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/OvmfPkgIa32.dsc | 22 +-
OvmfPkg/OvmfPkgIa32.fdf | 6 ++
2 files changed, 15 insertions(+), 13 deletions(-)
diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
index
Use the new crypto support include files.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/AmdSev/AmdSevX64.dsc | 12
OvmfPkg/AmdSev/AmdSevX64.fdf | 6 ++
2 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc
index
Use the new crypto support include files.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/Microvm/MicrovmX64.dsc | 24 +++-
OvmfPkg/Microvm/MicrovmX64.fdf | 7 +++
2 files changed, 18 insertions(+), 13 deletions(-)
diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc
Use the new crypto support include files.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/OvmfPkgX64.dsc | 22 +-
OvmfPkg/OvmfPkgX64.fdf | 6 ++
2 files changed, 15 insertions(+), 13 deletions(-)
diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
index
Create include files for crypto support, so the configuration can be
shared for all OVMF build variants. Also add support for using the
Crypto Driver.
The Crypto Driver is by default for enabled SMM + DXE and disabled for
PEI. This can be changed using the {PEI,SMM,DXE}_USE_CRYPTO_DRIVER
Use the new crypto support include files.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/OvmfPkgIa32X64.dsc | 22 +-
OvmfPkg/OvmfPkgIa32X64.fdf | 6 ++
2 files changed, 15 insertions(+), 13 deletions(-)
diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
Signed-off-by: Gerd Hoffmann
---
BaseTools/Conf/tools_def.template | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools/Conf/tools_def.template
index 471eb67c0c83..7f73ed817cd9 100755
--- a/BaseTools/Conf/tools_def.template
Contains only hash functions needed for measurements.
Signed-off-by: Gerd Hoffmann
---
CryptoPkg/Include/Dsc/CryptoServicePcd.hash_only.dsc.inc | 8
1 file changed, 8 insertions(+)
create mode 100644 CryptoPkg/Include/Dsc/CryptoServicePcd.hash_only.dsc.inc
diff --git
Enable Sha384 + Sha512 + Sm3.
Signed-off-by: Gerd Hoffmann
---
CryptoPkg/Include/Dsc/CryptoServicePcd.min_dxe_smm.dsc.inc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/CryptoPkg/Include/Dsc/CryptoServicePcd.min_dxe_smm.dsc.inc
Makes it easier to reuse the predefined config sets in other places.
Signed-off-by: Gerd Hoffmann
---
.../Include/Dsc/CryptoServicePcd.all.dsc.inc | 29 +++
.../Dsc/CryptoServicePcd.min_dxe_smm.dsc.inc | 35 +
.../Dsc/CryptoServicePcd.min_pei.dsc.inc | 20 +
v3 changes:
- rebase to latest master.
- enable crypto driver only for SMM + DXE.
- CI passes now \o/
v2 changes:
- turn on crypto driver support by default.
- left the config option in for now as fallback option.
When all goes as planned remove it one or two releases
later.
- fix
Hi Girish,
On 08/03/2023, 19:21, "Girish Mahadevan" mailto:gmahade...@nvidia.com>> wrote:
Hi Sami,
Thanks for your response.
I will update my patch series based on v2 of your dispatcher code and
point you to v3. (mid/late next week)
Can you also merge the Smbios String related patch
Hi Girish,
Thank you for your feedback.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 08/03/2023, 17:41, "Girish Mahadevan" mailto:gmahade...@nvidia.com>> wrote:
Hi Sami
Thanks for v2, I will apply these to my tree and test it out.
One small comment before I
8259 is very arch specific programming. It needs to be moved out to
the respective arch flow. Added in both x64 and x32 paths
Test: Able to boot UEFI shell with Coreboot Tianocore payload on
x86 qemu
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by: Dhaval
According to UPL spec BL should initialize FP init meaning UPL
does not need to initialize it. Besides this is arch specific init
and needs to be moved out of UPL common flow. In order to not break
current BL implementations, for now just moving the init to later
point of time but for both x32 and
Looking at adding support for Risc-V for UPL. In the process realised
there are several initialisation sequences which need not be part of
common UPL entry flow. The flow should be agnostic to both BL and Arch
with required hooks provided along the boot path. This patch set
addresses 2 such
On Thu, 9 Mar 2023 at 10:02, Gerd Hoffmann wrote:
>
> In case PcdFirmwareReleaseDateString is not set use a valid date
> as fallback. Using "unknown" makes Windows unhappy.
>
> Fixes: 4cb94f20b002 ("OvmfPkg/SmbiosPlatformDxe: use PcdFirmware*")
> Reported-by: ruifeng@intel.com
>
On Thu, 9 Mar 2023 at 10:16, Gerd Hoffmann wrote:
>
> Ping. Two reviews and the freeze is over. Merge this now?
>
Pong. Thanks for the reminder - I'll go and merge this.
> On Wed, Feb 15, 2023 at 03:37:32PM +0100, Gerd Hoffmann wrote:
> > SetMem arguments 2+3 are in the wrong order, resulting
Ping. Two reviews and the freeze is over. Merge this now?
On Wed, Feb 15, 2023 at 03:37:32PM +0100, Gerd Hoffmann wrote:
> SetMem arguments 2+3 are in the wrong order, resulting in
> the call having no effect because Length is zero.
>
> Fix this by using ZeroMem instead.
>
> Bugzilla:
In case PcdFirmwareReleaseDateString is not set use a valid date
as fallback. Using "unknown" makes Windows unhappy.
Fixes: 4cb94f20b002 ("OvmfPkg/SmbiosPlatformDxe: use PcdFirmware*")
Reported-by: ruifeng@intel.com
Signed-off-by: Gerd Hoffmann
---
63 matches
Mail list logo
