Re: [edk2-devel] [PATCH 1/1] pip-requirements.txt: bump edk2-basetools to 0.1.43

Reviewed-by: Michael D Kinney > -Original Message- > From: Rebecca Cran > Sent: Tuesday, April 4, 2023 8:47 PM > To: devel@edk2.groups.io; Andrew Fish ; Leif Lindholm > ; Kinney, Michael D > ; Sean Brogan ; > Michael Kubacki > Cc: Rebecca Cran > Subject: [PATCH 1/1]

[edk2-devel] [PATCH 1/1] pip-requirements.txt: bump edk2-basetools to 0.1.43

Bump the version of edk2-basetools in pip-requirements.txt to 0.1.43. This version contains the update to generate makefiles with both CFLAGS and BUILD_CFLAGS. Signed-off-by: Rebecca Cran --- pip-requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2-devel] [PATCH v3 1/4] BaseTools/GenFw: Parse IBT/BTI support status from ELF note

Acked-by: Michael Kubacki On 4/4/2023 11:40 AM, Ard Biesheuvel wrote: When performing ELF to PE/COFF conversion, parse any notes sections to decide whether the image supports forward CFI landing pads. This will be used to set the associated DllCharacteristicsEx flag in a subsequent patch.

Re: [edk2-devel] [Patch v2 04/12] UnitTestFrameworkPkg/ReadMe.md: Add gmock documentation

Reviewed-by: Michael Kubacki On 4/4/2023 2:22 PM, Michael D Kinney wrote: From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Cc: Sean Brogan Cc: Michael Kubacki Cc: Michael D Kinney Signed-off-by: Chris Johnson --- UnitTestFrameworkPkg/ReadMe.md | 1013

Re: [edk2-devel] [Patch v2 03/12] UnitTestFrameworkPkg: Add gmock support to GoogleTestLib

Reviewed-by: Michael Kubacki On 4/4/2023 2:22 PM, Michael D Kinney wrote: From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 * Add gmock support to GoogleTestLib * Add FunctionMockLib library class and library instance * Add GoogleTest extension to GoogleTestLib.h

[edk2-devel] [RFC] [edk2-openssl fork] Add openssl fork repo to Tianocore to support OpenSSL11_EOL

Hi This is follow up for the "Openssl1.1 replacement proposal" https://edk2.groups.io/g/devel/topic/96741156. openssl 3.0 POC result is shown at https://github.com/tianocore/edk2-staging/blob/OpenSSL11_EOL/CryptoPkg/Readme-OpenSSL3.0.md The size increase is reduced to ~10%. In order to achieve

[edk2-devel] [PATCH v2 1/1] ShellPkg: UefiShellDebug1CommandsLib: Uefi Config Tables in Dmem.c

Added entries for UEFI Config Tables not present in current Dmem output. v2 for revising CI formatting errors. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Sam Kaynor --- ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf | 9 ++

[edk2-devel] [PATCH v2 0/1] Add all UEFI Config Tables to Dmem output

Currently, several important UEFI defined config tables are not present in the output of Dmem. This patch implements dumping the presence of all UEFI Config Tables defined in UEFI Specification 2.10 v2 to correct CI formatting errors. REF: https://github.com/tianocore/edk2/pull/4239 Cc: Ray Ni

Re: [edk2-devel] PR fails due to OVMF time out

Hi Gerd, Do you want to submit a new email review/PR with this suggested change? Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd Hoffmann > Sent: Monday, April 3, 2023 3:38 AM > To: devel@edk2.groups.io; a...@kernel.org > Cc: Kinney, Michael D ; Laszlo

Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

Thanks, deprecating it for a while makes a lot of sense. We can consider removing it in 6-12 months maybe? -- Rebecca Cran On 4/4/2023 12:29 PM, Kinney, Michael D wrote: Add GCC and leave GCC5 for now and give time for all downstream consumers to accommodate the name change. At a later

Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

Add GCC and leave GCC5 for now and give time for all downstream consumers to accommodate the name change. At a later date, remove GCC5. We have seen significant downstream issues on name changes in the past. Splitting into 2 different patch series allows downstream to merge in the change that

Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

On Tue, 4 Apr 2023 at 20:03, Rebecca Cran wrote: > > > On 4/4/23 11:57 AM, Pedro Falcato wrote: > > On Tue, Apr 4, 2023 at 6:52 PM Kinney, Michael D > > wrote: > >> I see value in adding a new name. > >> > >> I see no value in a non-backwards compatible change to delete/rename a > >> fully

[edk2-devel] [Patch v2 11/12] MdeModulePkg: HOST_APPLICATION IA32/X64 only

Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Michael D Kinney --- .../UnitTest/MockUefiRuntimeServicesTableLib.inf| 2 +- .../RuntimeDxeUnitTest/VariableLockRequestToLockUnitTest.inf| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [Patch v2 08/12] SecurityPkg/Library/SecureBootVariableLib: Fix VS20xx 4122 errors

The unit test code for the SecureBootVariableLib is initializing local variable structures in their declaration from other local variables that are also initialized in their declaration. ANSI C does not allow this and error 4122 is generated on VS20xx compilers. The test cases are updated to

[edk2-devel] [Patch v2 04/12] UnitTestFrameworkPkg/ReadMe.md: Add gmock documentation

From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Cc: Sean Brogan Cc: Michael Kubacki Cc: Michael D Kinney Signed-off-by: Chris Johnson --- UnitTestFrameworkPkg/ReadMe.md | 1013 ++-- 1 file changed, 970 insertions(+), 43 deletions(-)

[edk2-devel] [Patch v2 10/12] MdePkg/Library/BaseLib: HOST_APPLICATION IA32/X64 only

Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Michael D Kinney --- MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf b/MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf index

[edk2-devel] [Patch v2 05/12] MdePkg: Add gmock examples

From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Chris Johnson --- MdePkg/MdePkg.dec | 1 + MdePkg/Test/MdePkgHostTest.dsc| 2 +

[edk2-devel] [Patch v2 12/12] PrmPkg/Library: HOST_APPLICATION IA32/X64 only

Cc: Michael Kubacki Cc: Nate DeSimone Signed-off-by: Michael D Kinney --- .../UnitTest/DxePrmContextBufferLibUnitTestHost.inf | 2 +- .../UnitTest/DxePrmModuleDiscoveryLibUnitTestHost.inf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [Patch v2 09/12] SecurityPkg/Library/SecureBootVariableLib: HOST_APPLICATION IA32/X64 only

Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Michael D Kinney Reviewed-by: Jiewen Yao --- .../UnitTest/MockPlatformPKProtectionLib.inf| 2 +- .../Library/SecureBootVariableLib/UnitTest/MockUefiLib.inf | 2 +- .../UnitTest/MockUefiRuntimeServicesTableLib.inf

[edk2-devel] [Patch v2 07/12] SecurityPkg: Add gmock example

From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Chris Johnson Acked-by: Jiewen Yao --- .../SecureBootVariableLibGoogleTest.cpp | 174 ++ .../SecureBootVariableLibGoogleTest.inf | 32

[edk2-devel] [Patch v2 02/12] .pytool/CISettings.py: Add subhook submodule

From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Add submodule for https://github.com/Zeex/subhook This submodule is required to hook internal functions when using gmock. Cc: Sean Brogan Cc: Michael Kubacki Cc: Michael D Kinney Cc: Liming Gao Signed-off-by:

[edk2-devel] [Patch v2 01/12] UnitTestFrameworkPkg: Add subhook submodule required for gmock

From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Add subhook submodule that is required to hook internal functions when using gmock. https://github.com/Zeex/subhook Add SubhookLib library class and SubhookLib library instance. Include the SUBHOOK_STATIC define

[edk2-devel] [Patch v2 06/12] MdeModulePkg/Library/UefiSortLib: Add GoogleTestLib example

From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Chris Johnson --- .../MockUefiRuntimeServicesTableLib.inf | 4 +- .../GoogleTest/UefiSortLibGoogleTest.cpp | 61 +++

[edk2-devel] [Patch v2 03/12] UnitTestFrameworkPkg: Add gmock support to GoogleTestLib

From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 * Add gmock support to GoogleTestLib * Add FunctionMockLib library class and library instance * Add GoogleTest extension to GoogleTestLib.h for CHAR16 type * Add GoogleTest extension to GoogleTestLib.h for buffer types

[edk2-devel] [Patch v2 00/12] Add gmock support for host-based unit testing

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 PR: https://github.com/tianocore/edk2/pull/4180 Branch: https://github.com/mdkinney/edk2/tree/Bug_4389_UnitTestFrameworkPkg_AddGoogleMockSupport New in v2 == * SecurityPkg: Add unit test descriptions to

Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

On 4/4/23 11:57 AM, Pedro Falcato wrote: On Tue, Apr 4, 2023 at 6:52 PM Kinney, Michael D wrote: I see value in adding a new name. I see no value in a non-backwards compatible change to delete/rename a fully supported one. As Leif said, you reduce all sorts of possible confusion. VS2013

Re: [edk2-devel] [Patch 0/2] Balance CI Execution Times

Merged PR: https://github.com/tianocore/edk2/pull/4233 Mike > -Original Message- > From: Michael Kubacki > Sent: Tuesday, April 4, 2023 6:56 AM > To: devel@edk2.groups.io; Kinney, Michael D > Cc: Sean Brogan ; Gao, Liming > > Subject: Re: [edk2-devel] [Patch 0/2] Balance CI

Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

On Tue, Apr 4, 2023 at 6:52 PM Kinney, Michael D wrote: > > I see value in adding a new name. > > I see no value in a non-backwards compatible change to delete/rename a fully > supported one. As Leif said, you reduce all sorts of possible confusion. VS2013 builds only for Visual Studio 2013

Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

I see value in adding a new name. I see no value in a non-backwards compatible change to delete/rename a fully supported one. Mike > -Original Message- > From: Rebecca Cran > Sent: Tuesday, April 4, 2023 10:49 AM > To: Kinney, Michael D ; devel@edk2.groups.io; > Leif Lindholm ; >

Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

I've already added changes to the patch series to fix EDK2 CI to use the new name. Fortunately there aren't many places that need updated. Downstream scripts should be trivial to change: just do a find/replace for GCC5. -- Rebecca Cran On 4/4/23 11:45 AM, Kinney, Michael D wrote:

Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

Changing the toolchain tag name from GCC5 to GCC will break EDK II CI and likely 100's of downstream developer/CI scripts. Can we keep GCC5 and add GCC that is identical to GCC5? Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rebecca Cran > Sent: Tuesday, April 4,

Re: [edk2-devel] [PATCH v4] IntelFsp2Pkg: LoadMicrocodeDefault() causing unnecessary delay.

Patch merged: https://github.com/tianocore/edk2/commit/7df447930c42addaf2cc0d32916141d95ded677e Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, Chasel > Sent: Monday, April 3, 2023 11:34 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone,

Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

On 4/4/23 10:32 AM, Leif Lindholm wrote: On Tue, Apr 04, 2023 at 16:57:18 +0100, Pedro Falcato wrote: On Tue, Apr 4, 2023 at 4:49 PM Rebecca Cran wrote: Okay. I'll rework the patch series to only delete GCC48 and keep GCC49 and GCC5. Please rename them? There's no point in keeping their

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: TempRamInit API should preserve EBX/RBX register.

What compiler is being used for this IPU? Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, Chasel > Sent: Tuesday, April 4, 2023 9:51 AM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Desimone, Nathaniel L ; Zeng, Star > > Subject: Re: [edk2-devel] [PATCH]

Re: [edk2-devel] [PATCH v3 0/4] Enable BTI support in memory attributes table

On Tue, 4 Apr 2023 at 18:42, Marvin Häuser wrote: > > > > On 4. Apr 2023, at 18:29, Ard Biesheuvel wrote: > > On Tue, 4 Apr 2023 at 18:19, Marvin Häuser wrote: > >> > >> FWIW, Reviewed-by: Marvin Häuser > >> > >> An off-topic remark, but I find it ominous that when adding a hack like > >>

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: TempRamInit API should preserve EBX/RBX register.

Patch merged: https://github.com/tianocore/edk2/commit/af98f1fb0311d8e3cc52ab9fc544a8c8ff8f7546 Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, Chasel > Sent: Friday, March 31, 2023 4:16 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone,

[edk2-devel] [PATCH v6 0/3] RISC-V SBI-backed SerialLib

Hello, Here are three patches that provide a SerialLib backed by SBI console. Both legacy and DBCN mechanisms are supported in various execution environments and have been tested with UART and HTIF consoles. MdePkg reviewers: please review MdePkg.dsc changes. This is also available at

[edk2-devel] [PATCH v6 3/3] OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec

If the SerialPortLib had any initialization needed, this would be skipped in the RiscVVirt Sec. Follow the example seen elsewhere (ArmVirtPkg PrePi). Seen with BaseSerialPortLibRiscVSbiLibRam not using DBCN in Sec, yet using DBCN elsewhere. Cc: Daniel Schaefer Reviewed-by: Sunil V L

[edk2-devel] [PATCH v6 1/3] MdePkg: BaseRiscVSbiLib: make more useful to consumers

Add a few more definitions and make SbiCall and TranslateError usable (not static) by library users. Cc: Daniel Schaefer Acked-by: Gerd Hoffmann Reviewed-by: Sunil V L Signed-off-by: Andrei Warkentin --- MdePkg/Include/Library/BaseRiscVSbiLib.h | 40 ++--

[edk2-devel] [PATCH v6 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V

These are implementations of SerialPortLib using SBI console services. - BaseSerialPortLibRiscVSbiLib is appropriate for SEC/PEI (XIP) environments - BaseSerialPortLibRiscVSbiLibRam is appropriate for PrePI/DXE environments Tested with: - Qemu RiscVVirt (non-DBCN case, backed by UART) - TinyEMU +

Re: [edk2-devel] [PATCH v3 0/4] Enable BTI support in memory attributes table

> On 4. Apr 2023, at 18:29, Ard Biesheuvel wrote: > On Tue, 4 Apr 2023 at 18:19, Marvin Häuser wrote: >> >> FWIW, Reviewed-by: Marvin Häuser >> >> An off-topic remark, but I find it ominous that when adding a hack like the >> DllCharacteristicsEx debug entry, the opportunity is not used

Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

On Tue, Apr 04, 2023 at 16:57:18 +0100, Pedro Falcato wrote: > On Tue, Apr 4, 2023 at 4:49 PM Rebecca Cran wrote: > > > > Okay. I'll rework the patch series to only delete GCC48 and keep GCC49 > > and GCC5. > > Please rename them? There's no point in keeping their current names > anyway. I

Re: [edk2-devel] [PATCH v3 0/4] Enable BTI support in memory attributes table

On Tue, 4 Apr 2023 at 18:19, Marvin Häuser wrote: > > FWIW, Reviewed-by: Marvin Häuser > > An off-topic remark, but I find it ominous that when adding a hack like the > DllCharacteristicsEx debug entry, the opportunity is not used to turn it into > something that can be expanded in the future

Re: [edk2-devel] [PATCH 2/5] MinPlatformPkg: Delete UefiCpuLib usage

Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Liu, Zhiguang > Sent: Tuesday, April 4, 2023 12:56 AM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Oram, Isaac W ; > Gao, Liming ; Dong, Eric > Subject: [PATCH 2/5]

Re: [edk2-devel] [PATCH v3 0/4] Enable BTI support in memory attributes table

FWIW, Reviewed-by: Marvin Häuser An off-topic remark, but I find it ominous that when adding a hack like the DllCharacteristicsEx debug entry, the opportunity is not used to turn it into something that can be expanded in the future without introducing yet another hack like this (I know 31

Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

On Tue, Apr 4, 2023 at 4:49 PM Rebecca Cran wrote: > > Okay. I'll rework the patch series to only delete GCC48 and keep GCC49 > and GCC5. Please rename them? There's no point in keeping their current names anyway. I guarantee you that most people are not really able to guess GCC49 to be the

Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

Okay. I'll rework the patch series to only delete GCC48 and keep GCC49 and GCC5. -- Rebecca Cran On 4/3/23 7:31 PM, gaoliming wrote: Rebecca: There are more discussion on GCC49 tool chain. So, I think it is the safe way to keep GCC49 and GCC5 now. We can make the changes for other tool

[edk2-devel] [PATCH v3 4/4] MdeModulePkg: Enable forward edge CFI in mem attributes table

The memory attributes table has been extended with a flag that indicates whether or not the OS is permitted to map the EFI runtime code regions with strict enforcement for IBT/BTI landing pad instructions. Given that the PE/COFF spec now defines a DllCharacteristicsEx flag that indicates whether

[edk2-devel] [PATCH v3 3/4] MdePkg/PeCoffLib: Capture DLL characteristics fields in image context

When loading a PE/COFF image, capture the DLL characteristics fields of the header into our image context structure so we can refer to them when mapping the image. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm Reviewed-by: Oliver Smith-Denny ---

[edk2-devel] [PATCH v3 2/4] BaseTools/GenFw: Add DllCharacteristicsEx field to debug data

The PE/COFF spec describes an additional DllCharacteristics field implemented as a debug directory entry, which carries flags related to which control flow integrity (CFI) features are supported by the binary. So let's add this entry when doing ELF to PE/COFF conversion - we will add support for

[edk2-devel] [PATCH v3 1/4] BaseTools/GenFw: Parse IBT/BTI support status from ELF note

When performing ELF to PE/COFF conversion, parse any notes sections to decide whether the image supports forward CFI landing pads. This will be used to set the associated DllCharacteristicsEx flag in a subsequent patch. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm Reviewed-by:

[edk2-devel] [PATCH v3 0/4] Enable BTI support in memory attributes table

Implement version 2 of the memory attributes table, which now contains a flag informing the OS whether or not code regions may be mapped with CFI mitigations such as IBT or BTI enabled. This series covers the remaining parts after the AArch64 specific changes were merged: - Update the BaseTools

Re: [edk2-devel] [PATCH v2 17/17] MdeModulePkg: Enable forward edge CFI in mem attributes table

On Tue, 4 Apr 2023 at 17:00, Oliver Smith-Denny wrote: > > On 4/4/2023 3:41 AM, Ard Biesheuvel wrote: > > On Mon, 3 Apr 2023 at 17:48, Oliver Smith-Denny > > wrote: > >> > >> Turns out my old email was getting sent to a lot of folks spam, so > >> resending with hopefully a better email... > >> >

Re: [edk2-devel] PATCH v3 1/3 MdeModulePkg: TerminalDxe: set xterm resolution on mode change

On Fri, 17 Feb 2023 at 14:02, Paweł Poławski wrote: > > From: Laszlo Ersek > > TerminalDxe driver can send xterm control sequences. > Reference: > > This way it can trigger client window resize (xterm, > gnome-terminal etc.) accordingly, to a specified

Re: [edk2-devel] [PATCH 0/5] Delete UefiCpuLib usage

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhiguang Liu > Sent: Tuesday, April 4, 2023 12:56 AM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang > Subject: [edk2-devel] [PATCH 0/5] Delete UefiCpuLib usage > > Delete UefiCpuLib usage

Re: [edk2-devel] Linker scripts use of "-z common-page-size=0x20" etc.

> On 4. Apr 2023, at 16:03, Ard Biesheuvel wrote: > > On Tue, 4 Apr 2023 at 13:10, Rebecca Cran > wrote: >> >> On 4/4/23 1:22 AM, Ard Biesheuvel wrote: >>> On Mon, 3 Apr 2023 at 22:33, Rebecca Cran >> > wrote: As part of my work on the

Re: [edk2-devel] Linker scripts use of "-z common-page-size=0x20" etc.

On Tue, 4 Apr 2023 at 13:10, Rebecca Cran wrote: > > On 4/4/23 1:22 AM, Ard Biesheuvel wrote: > > On Mon, 3 Apr 2023 at 22:33, Rebecca Cran wrote: > >> As part of my work on the toolchain definitions, I've come across a > >> situation where ld.lld fails to align sections correctly, due to it >

回复: [edk2-devel] [PATCH v1] MdeModulePkg: Fix misspelling

Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Nate > DeSimone > 发送时间: 2023年3月1日 12:55 > 收件人: devel@edk2.groups.io > 抄送: Nate DeSimone ; Jian J Wang > ; Liming Gao ; Michael > D Kinney ; Dandan Bi > 主题: [edk2-devel] [PATCH v1] MdeModulePkg: Fix misspelling > > From:

Re: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

Hi Rebecca/ Marvin, Patrick has filed it as a separate patch email here https://edk2.groups.io/g/devel/message/102168 However the email still group them together. It is because he could not reproduce any issue anymore that was seen on 2nd patch (could be that Rebecca already fixed it). Could you

Re: [edk2-devel] [PATCH 1/1] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

Can anyone help to review this? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102481): https://edk2.groups.io/g/devel/message/102481 Mute This Topic: https://groups.io/mt/97947217/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] Linker scripts use of "-z common-page-size=0x20" etc.

On 4/4/23 1:22 AM, Ard Biesheuvel wrote: On Mon, 3 Apr 2023 at 22:33, Rebecca Cran wrote: As part of my work on the toolchain definitions, I've come across a situation where ld.lld fails to align sections correctly, due to it being invoked via clang with the '-n' option, which causes GenFw to

Re: [edk2-devel] [PATCH v2 17/17] MdeModulePkg: Enable forward edge CFI in mem attributes table

On Mon, 3 Apr 2023 at 17:48, Oliver Smith-Denny wrote: > > Turns out my old email was getting sent to a lot of folks spam, so > resending with hopefully a better email... > > On 3/27/2023 4:01 AM, Ard Biesheuvel wrote: > > The memory attributes table has been extended with a flag that indicates >

[edk2-devel] About the way of exception registration

Hi all, I'm going porting LoongArch64 to UefiCpuPkg and OvmfPkg. A problem is blocked me that EFI_CPU_ARCH_PROTOCOL only provides interrupt register method, no exception register method. I found that RISC-V hase the same issue, Andrei modified DebugSupport.h to fix it,

[edk2-devel] [edk2-staging/OpenSSL11_EOL][PATCH 4/4] Readme: update POC result and next step

Signed-off-by: Yi Li --- CryptoPkg/Readme-OpenSSL3.0.md | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/CryptoPkg/Readme-OpenSSL3.0.md b/CryptoPkg/Readme-OpenSSL3.0.md index 1c77628b75..5b660959e7 100644 --- a/CryptoPkg/Readme-OpenSSL3.0.md +++

[edk2-devel] [edk2-staging/OpenSSL11_EOL][PATCH 3/4] Readme: 0330 update

Signed-off-by: Yi Li --- CryptoPkg/Readme-OpenSSL3.0.md | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/CryptoPkg/Readme-OpenSSL3.0.md b/CryptoPkg/Readme-OpenSSL3.0.md index fc5d24d074..1c77628b75 100644 --- a/CryptoPkg/Readme-OpenSSL3.0.md +++

[edk2-devel] [edk2-staging/OpenSSL11_EOL][PATCH 2/4] CryptoPkg: sync latest change in uefiprov to minprov

Signed-off-by: Yi Li --- .../Library/OpensslLib/OpensslStub/minprov.c | 30 +-- 1 file changed, 7 insertions(+), 23 deletions(-) diff --git a/CryptoPkg/Library/OpensslLib/OpensslStub/minprov.c b/CryptoPkg/Library/OpensslLib/OpensslStub/minprov.c index 1ba4b4f669..26fad90408

[edk2-devel] [edk2-staging/OpenSSL11_EOL][PATCH 1/4] CryptoPkg: disabled ssl server

Signed-off-by: Yi Li --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 6 +- .../Library/OpensslLib/OpensslLibFull.inf | 6 +- CryptoPkg/Library/OpensslLib/SslExtServNull.c | 329 ++ .../Library/OpensslLib/SslStatServNull.c | 219 4 files changed, 556

[edk2-devel] [edk2-staging/OpenSSL11_EOL][PATCH 0/4] Openssl 3.0 POC update Apr 4

Updated POC result and next step. Please check the patch series if interested. PR: https://github.com/tianocore/edk2-staging/pull/366 The goal of POC has been reached, next step: 1. Optimize code quality 2. Upstream OpenSsl code change 3. Fully validation Risk: 1. Upstream the

Re: [edk2-devel] [PATCH v4 0/6] UefiCpuPkg, OvmfPkg: Simplify CpuExceptionHandlerLib

Thanks all Ray, any comments on this version? Thanks. Liming, Rebecca, any comments on the BaseTools changes? On Tue, 4 Apr 2023 at 09:57, Marvin Häuser wrote: > > FWIW, Reviewed-by: Marvin Häuser > > > On 3. Apr 2023, at 16:29, Ard Biesheuvel wrote: > > > > We have a special version of

Re: [edk2-devel] [PATCH v4 0/6] UefiCpuPkg, OvmfPkg: Simplify CpuExceptionHandlerLib

FWIW, Reviewed-by: Marvin Häuser > On 3. Apr 2023, at 16:29, Ard Biesheuvel wrote: > > We have a special version of CpuExceptionHandlerLib for XCODE5, whose > linker (LLD) does not permit absolute symbol references in read-only > sections. > > Instead of fixing this up at runtime for all

[edk2-devel] [PATCH 5/5] QuarkSocPkg: Delete UefiCpuLib usage

Delete UefiCpuLib usage because UefiCpuPkg/UefiCpuLib is merged to MdePkg/CpuLib. Cc: Michael D Kinney Cc: Kelly Steele Cc: Nate DeSimone Signed-off-by: Zhiguang Liu --- Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[edk2-devel] [PATCH 1/5] SimicsOpenBoardPkg: Delete UefiCpuLib usage

Delete UefiCpuLib usage because UefiCpuPkg/UefiCpuLib is merged to MdePkg/CpuLib. Cc: Nate DeSimone Signed-off-by: Zhiguang Liu --- Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c | 3 +-- Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf | 3 +-- 2 files changed, 2 insertions(+), 4

[edk2-devel] [PATCH 2/5] MinPlatformPkg: Delete UefiCpuLib usage

Delete UefiCpuLib usage because UefiCpuPkg/UefiCpuLib is merged to MdePkg/CpuLib. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Signed-off-by: Zhiguang Liu --- Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 3 +-- 1 file changed, 1

[edk2-devel] [PATCH 3/5] QuarkPlatformPkg: Delete UefiCpuLib usage

Delete UefiCpuLib usage because UefiCpuPkg/UefiCpuLib is merged to MdePkg/CpuLib. Cc: Michael D Kinney Cc: Kelly Steele Cc: Nate DeSimone Signed-off-by: Zhiguang Liu --- Platform/Intel/QuarkPlatformPkg/Quark.dsc| 3 +-- Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 3 +-- 2 files

[edk2-devel] [PATCH 4/5] Vlv2TbltDevicePkg: Delete UefiCpuLib usage

Delete UefiCpuLib usage because UefiCpuPkg/UefiCpuLib is merged to MdePkg/CpuLib. Cc: Zailiang Sun Cc: Yi Qian Cc: Nate DeSimone Signed-off-by: Zhiguang Liu --- Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 3 +-- Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 3 +-- 2 files

[edk2-devel] [PATCH 0/5] Delete UefiCpuLib usage

Delete UefiCpuLib usage because UefiCpuPkg/UefiCpuLib is merged to MdePkg/CpuLib. Currently, UefiCpuLib is a dummy library to avoid build issue, after this patch set, UefiCpuLib can be completely removed from Edk2. Zhiguang Liu (5): SimicsOpenBoardPkg: Delete UefiCpuLib usage MinPlatformPkg:

Re: [edk2-devel] Linker scripts use of "-z common-page-size=0x20" etc.

On 4. Apr 2023, at 09:23, Ard Biesheuvel wrote:On Mon, 3 Apr 2023 at 22:33, Rebecca Cran wrote:As part of my work on the toolchain definitions, I've come across asituation where ld.lld fails to align sections correctly, due to itbeing invoked via clang with the '-n' option, which causes GenFw

Re: [edk2-devel] Linker scripts use of "-z common-page-size=0x20" etc.

On Mon, 3 Apr 2023 at 22:33, Rebecca Cran wrote: > > As part of my work on the toolchain definitions, I've come across a > situation where ld.lld fails to align sections correctly, due to it > being invoked via clang with the '-n' option, which causes GenFw to fail > with "Section address not