Re: [edk2-devel] [edk2-platforms][PATCH 13/14] ManageabilityPkg: Relocate Manageability.dsc

2023-04-10 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Tinh Nguyen > Sent: Tuesday, April 11, 2023 1:27 AM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) > ; Nickle Wang ; Igor > Kulchytskyy > Subject: Re: [edk2-platforms][PATCH

Re: [edk2-devel] [edk2-platforms][PATCH 03/14] ManageabilityPkg: Fix Uncrustify errors

2023-04-10 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Tinh Nguyen > Sent: Tuesday, April 11, 2023 1:25 AM > To: devel@edk2.groups.io; Chang, Abner > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) > ; Nickle Wang ; Igor > Kulchytskyy > Subject: Re: [edk2-devel]

Re: [edk2-devel] [edk2-platforms][PATCH 01/14] ManageabilityPkg: Add more helper functions

2023-04-10 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Tinh Nguyen > Sent: Tuesday, April 11, 2023 1:24 AM > To: devel@edk2.groups.io; Chang, Abner > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) > ; Nickle Wang ; Igor > Kulchytskyy > Subject: Re: [edk2-devel]

Re: [edk2-devel] Introduce a new repo "edk2-redfish-client" under Tianocore Github

2023-04-10 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi all, Since there is no feedback received, I assume there is no one against to this proposal. @michael.d.kin...@intel.com Hi Mike, I am requesting to create "edk2-redfich-client" repo under Tianocore, below is the maintainer list who are responsible for

Re: [edk2-devel] [PATCH 1/2] SimicsOpenBoardPkg: Fix bug in DSDT

2023-04-10 Thread Ni, Ray
Nate, can you help to give the R-B and push? Thanks, Ray > -Original Message- > From: Ni, Ray > Sent: Saturday, October 8, 2022 3:32 PM > To: devel@edk2.groups.io; Guenzel, Robert > Subject: RE: [PATCH 1/2] SimicsOpenBoardPkg: Fix bug in DSDT > > Thanks for fixing that. > Reviewed-by:

Re: [edk2-devel] [edk2-platforms] Platform/Loongson: Fixed multi-core boot issue

2023-04-10 Thread Chao Li
Reviewed-by: Chao Li Thanks, Chao 在 2023/3/31 10:30, xianglai 写道: Fixed the bug of slave cpu querying MAILBUF register address. Cc: Ard Biesheuvel Cc: Bibo Mao Cc: Chao Li Cc: Leif Lindholm Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: xianglai li ---

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, April 11, 2023 #cal-reminder

2023-04-10 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, April 11, 2023 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH v8 0/9] Adds AmdSmmCpuFeaturesLib and SmmSmramSaveStateLib

2023-04-10 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Mike, I think 5/9 was added for those functions AMD has no implementation as the initial commit, while 6/9 was updated for the functions with AMD implementations. @Attar, AbdulLateef (Abdul Lateef)can confirm this. Thanks Abner > -Original Message-

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, April 10, 2023 #cal-notice

2023-04-10 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, April 10, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1860810 ) *Description:* TianoCore

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, April 10, 2023 #cal-reminder

2023-04-10 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, April 10, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1860810 ) *Description:*

[edk2-devel] [RFC PATCH] Fix ArmReplaceLiveTranslationEntry alignment

2023-04-10 Thread Marvin Häuser
Good day everyone, Sorry, but due to time constraints, I cannot immediately provide a proper patch. Would you mind checking this commit and commenting on whether it looks about right, so I can submit a proper patch for review some time this or next week?

Re: [edk2-devel] [edk2][PATCH v2 1/1] MdeModulePkg: Add EDKII Platform Boot Manager Protocol v2

2023-04-10 Thread Tinh Nguyen via groups.io
Gentle ping, I’m looking for some feedback on this patch. Could someone please help me to review it? On 4/6/2023 3:19 PM, Tinh Nguyen via groups.io wrote: This introduces the EDKII_PLATFORM_BOOT_MANAGER_PROTOCOL_REVISION2, which adds a new UpdateBootOrder() function to support customizing the

Re: [edk2-devel] [edk2-platforms][PATCH 13/14] ManageabilityPkg: Relocate Manageability.dsc

2023-04-10 Thread Tinh Nguyen via groups.io
Hi Abner, As someone mentioned before, you should move this library for arm/arm64 to Manageability.dsc btw, the files that are included in dsc should have the extension dsc.inc. Regards, Tinh On 4/3/2023 10:04 PM, abner.ch...@amd.com wrote: [EXTERNAL EMAIL NOTICE: This email originated

Re: [edk2-devel] [edk2-platforms][PATCH 03/14] ManageabilityPkg: Fix Uncrustify errors

2023-04-10 Thread Tinh Nguyen via groups.io
Hi Abner, I checked and found that some files were not formatted with uncrustify. Please run it for the whole package. You can append this commit to the of the series. On 4/3/2023 10:04 PM, Chang, Abner via groups.io wrote: From: Abner Chang Fix Uncrustify errors of IPMI protocol and KCS

Re: [edk2-devel] [edk2-platforms][PATCH 01/14] ManageabilityPkg: Add more helper functions

2023-04-10 Thread Tinh Nguyen via groups.io
Please find my inline comment below On 4/3/2023 10:04 PM, Chang, Abner via groups.io wrote: From: Abner Chang 1. Add a helper function to output payload binary to debug output device. 2. Add a helper function to split payload into packages according to maximum transfer unit of

[edk2-devel] EDK2 source code debugging with GDB tool on windows

2023-04-10 Thread Jagadeesh Pithani via groups.io
hi team, can you help to share the installation and debugging procedure for EDK2 source on Qemu with help of GDB tool in windows environment. Requirement is on windows platform, could you please help in this.. Regards, Jagadeesh... ::DISCLAIMER:: The contents

Re: [edk2-devel] [PATCH v8 0/9] Adds AmdSmmCpuFeaturesLib and SmmSmramSaveStateLib

2023-04-10 Thread Michael D Kinney
Is there a reason why patches 5 and 6 where not combined? Mike > -Original Message- > From: Abdul Lateef Attar > Sent: Monday, April 10, 2023 4:10 AM > To: devel@edk2.groups.io > Cc: Abdul Lateef Attar ; Paul Grimes ; > Garrett Kirkendall ; > Abner Chang ; Dong, Eric ; Ni, Ray > ;

Re: [edk2-devel] [PATCH 00/18] Replace pre-standard macro __FUNCTION__ with C99 __func__ throughout edk2

2023-04-10 Thread Rebecca Cran
Pushed as f2cc962cd28fe75fb4edf230d69e99c346fe9c8a..61652efd04a7585a779226137d0f9739a75aac69. -- Rebecca Cran On 4/6/23 4:23 PM, Rebecca Cran wrote: Following on from commit b17a3a133b18fb41493fba7d86e9b5804ea6a8cf which updated MdePkg to be more C11 compliant by replacing the pre-standard

Re: [edk2-devel] [PATCH v8 8/9] UefiCpuPkg: Uses SmmSmramSaveStateLib library

2023-04-10 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Abdul > Lateef Attar via groups.io > Sent: Monday, April 10, 2023 7:10 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; > Grimes, Paul ;

[edk2-devel] [PATCH v8 4/9] UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code

2023-04-10 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 moves Intel-specific code to the arch-dependent file. Other processor families might have different implementation of these functions. Hence, moving out of the common file. Cc: Abner Chang Cc: Garrett Kirkendall

[edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library

2023-04-10 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Uses new SmmSmramSaveStateLib library, which fix the CI failure. Cc: Paul Grimes Cc: Garrett Kirkendall Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ard Biesheuvel Cc:

[edk2-devel] [PATCH v8 3/9] UefiCpuPkg: Implements SmmSmramSaveStateLib library class

2023-04-10 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Implements SmmSmramSaveStateLib Library class for AMD cpu family. Cc: Paul Grimes Cc: Garrett Kirkendall Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Abdul

[edk2-devel] [PATCH v8 2/9] UefiCpuPkg: Adds SmmSmramSaveStateLib library class

2023-04-10 Thread Abdul Lateef Attar via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Adds SmmSmramSaveStateLib Library class in UefiCpuPkg.dec. Adds function declaration header file. Cc: Paul Grimes Cc: Garrett Kirkendall Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Abdul

[edk2-devel] [PATCH v8 8/9] UefiCpuPkg: Uses SmmSmramSaveStateLib library

2023-04-10 Thread Abdul Lateef Attar via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Uses new SmmSmramSaveStateLib library. Removes old code. Cc: Paul Grimes Cc: Garrett Kirkendall Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen

[edk2-devel] [PATCH v8 5/9] UefiCpuPkg: Initial implementation of AMD's SmmCpuFeaturesLib

2023-04-10 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Adds initial defination for AMD's SmmCpuFeaturesLib library implementation. All function's body either empty or just returns value. Its initial skeleton of library implementation. Cc: Paul Grimes Cc: Garrett

[edk2-devel] [PATCH v8 6/9] UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family

2023-04-10 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Implements interfaces to read and write save state registers of AMD's processor family. Initializes processor SMMADDR and MASK depends on PcdSmrrEnable flag. Program or corrects the IP once control returns from

[edk2-devel] [PATCH v8 7/9] UefiCpuPkg: Implements SmmSmramSaveStateLib for Intel

2023-04-10 Thread Abdul Lateef Attar via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Implements SmmSmramSaveStateLib library interfaces to read and write save state registers for Intel processor family. Moves Intel and AMD common functionality to common area. Cc: Paul Grimes Cc: Garrett Kirkendall Cc: Abner Chang Cc:

[edk2-devel] [PATCH v8 1/9] MdePkg: Adds AMD SMRAM save state map

2023-04-10 Thread Abdul Lateef Attar via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Adds an SMM SMRAM save-state map for AMD processors. SMRAM save state maps for the AMD processor family are now supported. Save state map structure is added based on AMD64 Architecture Programmer's Manual, Volume 2, Section 10.2. The AMD

[edk2-devel] [PATCH v8 0/9] Adds AmdSmmCpuFeaturesLib and SmmSmramSaveStateLib

2023-04-10 Thread Abdul Lateef Attar via groups.io
PR: https://github.com/tianocore/edk2/pull/4258 V8 delta changes: Addressed review comments from Abner, Fix the whitespace error. Seperate the Ovmf changes to another patch V7 delta changes: Adds SmmSmramSaveStateLib for Intel processor. Integrate SmmSmramSaveStateLib library. V6

[edk2-devel] [PATCH v1 1/1] SpcrFeaturePkg: Updated SPCR table based on PCD values

2023-04-10 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar Update the SPCR table based on PCD values, such as base address, register bit width, access size and address space id etc, along with OEM data. Cc: Abner Chang Cc: Sai Chaganty Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Abdul Lateef Attar ---

[edk2-devel] [PATCH v1 0/1] PCD based ACPI SPCR table

2023-04-10 Thread Abdul Lateef Attar via groups.io
Update the ACPI SPCR tabled based on PCD values. Cc: Abner Chang Cc: Sai Chaganty Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao Cc: Abdul Lateef Attar Abdul Lateef Attar (1): SpcrFeaturePkg: Updated SPCR table based on PCD values .../SpcrAcpiDxe/SpcrAcpiDxe.inf | 13

Re: [edk2-devel] [edk2-platforms] Platform/Loongson: Fixed multi-core boot issue

2023-04-10 Thread xianglai
Ping for reviewing, Any comments is welcome. On 3/31/23 10:30 AM, xianglai wrote: Fixed the bug of slave cpu querying MAILBUF register address. Cc: Ard Biesheuvel Cc: Bibo Mao Cc: Chao Li Cc: Leif Lindholm Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: xianglai li ---