Re: [edk2-devel] [PATCH 0/4] OvmfPkg/RiscVVirt: Separate code and variable storage

2023-06-14 Thread Sunil V L
On Wed, Jun 14, 2023 at 07:11:18PM +0200, Heinrich Schuchardt wrote: > Sunil V L schrieb am Mi., 14. Juni 2023, 19:01: > > > Recent updates to RISC-V qemu virt platform merged today (07/14), > > have enabled both pflash devices for the S-mode payload like EDK2. > > These updates also aligned the

Re: [edk2-devel] [PATCH v2 0/3] Adding Status Code Definitions from PI Spec v1.8

2023-06-14 Thread Michael D Kinney
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kun Qin > Sent: Thursday, June 8, 2023 11:25 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > ; Zhang, Qi1 ; Kumar, Rahul R > ; Kinney, Michael D ; > Gao, Liming ; Liu,

Re: [edk2-devel] [Patch V2] MdePkg: Code optimization to SMM InternalAllocateAlignedPages

2023-06-14 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Tan, Dun > Sent: Wednesday, June 14, 2023 2:41 AM > To: devel@edk2.groups.io; Tan, Dun > Cc: Ni, Ray ; Kinney, Michael D > ; Gao, Liming ; Liu, > Zhiguang > Subject: RE: [edk2-devel] [Patch V2] MdePkg: Code optimization to SMM

[edk2-devel] [PATCH 6/6] AlderlakeOpenBoardPkg: Add Library Instances

2023-06-14 Thread Saloni Kasbekar
Adds the following libraries - BasePlatformHookLib - DxeAcpiGnvsInitLib - PeiBoardConfigLib - PeiGetFvInfoLib - PeiReportFvLib - SmmSpiFlashCommonLib Cc: Sai Chaganty Cc: Nate DeSimone Cc: Isaac Oram Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar ---

[edk2-devel] [PATCH 5/6] AlderlakeOpenBoardPkg: Adds the Policy Module

2023-06-14 Thread Saloni Kasbekar
Adds the following libraries within the Policy module - DxeSiliconPolicyUpdateLib - PeiPolicyBoardConfigLib - PeiPolicyUpdateLib - PeiSiliconPolicyUpdateLib Cc: Sai Chaganty Cc: Nate DeSimone Cc: Isaac Oram Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar --- .../DxeCpuPolicyInit.c

[edk2-devel] [PATCH 2/6] AlderlakeOpenBoardPkg: Add modules

2023-06-14 Thread Saloni Kasbekar
Adds the following modules: -BiosInfo -OpenBoardPlatformInit -SBCVpdStructurePcd -SmmMultiBoardAcpiSupportLib Cc: Sai Chaganty Cc: Nate DeSimone Cc: Isaac Oram Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar --- .../AlderlakeOpenBoardPkg/BiosInfo/BiosInfo.c | 196 +++

[edk2-devel] [PATCH 1/6] AlderlakeOpenBoardPkg: Add package and headers

2023-06-14 Thread Saloni Kasbekar
Create the AlderlakeOpenBoardPkg to provide board support code. The package may support Alderlake boards. The package serves as a board support package in the EDK II Minimum Platform design. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Isaac Oram Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar ---

[edk2-devel] [PATCH 3/6] AlderlakeOpenBoardPkg/AlderlakePRvp: Add library instances

2023-06-14 Thread Saloni Kasbekar
Adds the following library instances: * AlderlakePRvp/Library/BoardAcpiLib * AlderlakePRvp/Library/BoardInitLib Cc: Sai Chaganty Cc: Nate DeSimone Cc: Isaac Oram Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar --- .../Library/BoardAcpiLib/BaseAcpiTableLib.c | 30 ++

Re: [edk2-devel] [edk2-platforms][PATCH] edk2-platform: Add Readme under Platform\AMD

2023-06-14 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: devel@edk2.groups.io On Behalf Of Leif > Lindholm via groups.io > Sent: Thursday, June 15, 2023 12:13 AM > To: devel@edk2.groups.io; Chang, Abner > Cc: Michael D Kinney ; Attar, AbdulLateef > (Abdul Lateef) ; Xing, Eric > ;

[edk2-devel] [PATCH 1/1] Maintainers.txt: Update NetworkPkg maintainers and reviewers

2023-06-14 Thread Saloni Kasbekar
Add Zack, Saloni and remove unused IDs Cc: Michael D Kinney Cc: Andrew Fish Cc: Leif Lindholm Cc: Zachary Clark-willilams Signed-off-by: Saloni Kasbekar --- Maintainers.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index

Re: [edk2-devel] [PATCH 0/4] OvmfPkg/RiscVVirt: Separate code and variable storage

2023-06-14 Thread Heinrich Schuchardt
Sunil V L schrieb am Mi., 14. Juni 2023, 19:01: > Recent updates to RISC-V qemu virt platform merged today (07/14), > have enabled both pflash devices for the S-mode payload like EDK2. > These updates also aligned the design similar to other architectures > where pflash0 is for read-only code

[edk2-devel] [PATCH 3/4] OvmfPkg/RiscVVirt: Add support for separate code and variable store

2023-06-14 Thread Sunil V L
Currently, RiscVVirtQemu supports unified code and variable store mainly because only one pflash devices was available in qemu for EDK2. However, this doesn't allow to map the code part as read-only. With recent qemu enhancements, it is now possible for EDK2 to make use of both pflash devices in

[edk2-devel] [PATCH 4/4] OvmfPkg/RiscVVirt: Add a readme for build and test

2023-06-14 Thread Sunil V L
Add a readme file which provides information regarding how to build and test EDK2 on RISC-V qemu virt platform. Signed-off-by: Sunil V L Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Andrei Warkentin --- OvmfPkg/RiscVVirt/README.md | 41

[edk2-devel] [PATCH 2/4] OvmfPkg/RiscVVirt: Add VirtNorFlashDeviceTreeLib library

2023-06-14 Thread Sunil V L
This library is required to support separate code and variable store images. Signed-off-by: Sunil V L Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Andrei Warkentin --- .../VirtNorFlashDeviceTreeLib.inf | 40 + .../VirtNorFlashDeviceTreeLib.c

[edk2-devel] [PATCH 1/4] OvmfPkg/RiscVVirt: Fix couple of issues in VarStore

2023-06-14 Thread Sunil V L
The size of the FV and the WriteQueueSize is incorrect which causes the flash to be re-written during boot. Fix them and update the new checksum value. Signed-off-by: Sunil V L Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Andrei Warkentin ---

[edk2-devel] [PATCH 0/4] OvmfPkg/RiscVVirt: Separate code and variable storage

2023-06-14 Thread Sunil V L
Recent updates to RISC-V qemu virt platform merged today (07/14), have enabled both pflash devices for the S-mode payload like EDK2. These updates also aligned the design similar to other architectures where pflash0 is for read-only code and pflash1 for variable store. Previously only pflash1 was

Re: [edk2-devel] [edk2-platforms][PATCH] edk2-platform: Add Readme under Platform\AMD

2023-06-14 Thread Leif Lindholm
On 2023-06-14 05:22, Chang, Abner via groups.io wrote: From: Abner Chang For AMD edk2 opensource project and the needs of opensource AMD platform common modules those can be leverage across AMD business units, AMD server, client and S3 (silicon strategic solution) BUs have the consensus to

Re: [edk2-devel] [PATCH v2] MdeModulePkg/Variable: TcgMorLockSmm Key Mismatch changes lock state

2023-06-14 Thread Abhimanyu Singh
Hi Liming and Jian, Could you please review this patch? Michael has taken a look over and given Acked-by. Thanks, Abhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106089): https://edk2.groups.io/g/devel/message/106089 Mute This

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix incorrect code on AddSectionHeader

2023-06-14 Thread Wang, BruceX
-Original Message- From: Wang, BruceX Sent: Wednesday, June 14, 2023 10:00 PM To: devel@edk2.groups.io Cc: Wang, BruceX ; Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Lu, James Subject: [PATCH] UefiPayloadPkg: Fix incorrect code on AddSectionHeader From: BruceX Wang Fix incorrect code

[edk2-devel] [PATCH] UefiPayloadPkg: Fix incorrect code on AddSectionHeader

2023-06-14 Thread brucex . wang
From: BruceX Wang Fix incorrect code on AddSectionHeader32() and AddSectionHeader64() Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Signed-off-by: BruceX Wang --- UefiPayloadPkg/Tools/ElfFv.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[edk2-devel] [PATCH v1 1/1] MdeModulePkg/Bus/Pci/EhciDxe: Fix FORWARD_NULL Coverity issues

2023-06-14 Thread Ranbir Singh
From: Ranbir Singh The function UsbHcGetPciAddressForHostMem has ASSERT ((Block != NULL)); and the UsbHcFreeMem has ASSERT (Block != NULL); statement after for loop, but these are applicable only in DEBUG mode. In RELEASE mode, if for whatever reasons there is no match inside for

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix incorrect code on AddSectionHeader

2023-06-14 Thread Guo, Gua
Reviewed-by: Gua Guo -Original Message- From: Wang, BruceX Sent: Wednesday, June 14, 2023 10:00 PM To: devel@edk2.groups.io Cc: Wang, BruceX ; Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Lu, James Subject: [PATCH] UefiPayloadPkg: Fix incorrect code on AddSectionHeader From: BruceX Wang

Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: Add "-fno-unwind-tables" to GCC5_RISCV64_CC_FLAGS

2023-06-14 Thread Sunil V L
Hi Liming, Could you please help with review and merge of this patch? Do I need to raise a BZ ticket? Thanks! Sunil On Fri, Jun 02, 2023 at 10:32:54PM +0530, Sunil V L wrote: > gcc-13 for RISC-V enables unwind tables by default similar to ARM64. > This generates .eh_frame_hdr section which is

Re: [edk2-devel] [Patch V6 01/14] OvmfPkg:Remove code that apply AddressEncMask to non-leaf entry

2023-06-14 Thread duntan
Hi all, Could you please help to review this patch? Thanks, Dun -Original Message- From: devel@edk2.groups.io On Behalf Of duntan Sent: Friday, June 9, 2023 5:16 PM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Yao, Jiewen ; Justen, Jordan L ; Gerd Hoffmann ; Tom Lendacky ; Ni, Ray

Re: [edk2-devel] [Patch V6 02/14] MdeModulePkg: Remove other attribute protection in UnsetGuardPage

2023-06-14 Thread duntan
Hi all, Could you please help to review this patch? Thanks, Dun -Original Message- From: devel@edk2.groups.io On Behalf Of duntan Sent: Friday, June 9, 2023 5:16 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Ni, Ray ; Wang, Jian J ; Ard Biesheuvel Subject: [edk2-devel] [Patch V6

Re: [edk2-devel] [Patch V2] MdePkg: Code optimization to SMM InternalAllocateAlignedPages

2023-06-14 Thread duntan
Hi Mike and Liming, Could you please help to review this patch? Thanks, Dun -Original Message- From: devel@edk2.groups.io On Behalf Of duntan Sent: Thursday, May 18, 2023 3:31 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang Subject:

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: fix uncrustify check error

2023-06-14 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Tuesday, June 13, 2023 9:32 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH] RedfishClientPkg/.github: fix

[edk2-devel] [PATCH 4/5] OvmfPkg: move QemuFwCfgAcpi into AcpiPlatformLib

2023-06-14 Thread Corvin Köhne
This makes the InstallQemuFwcfgTables function reusable by bhyve. Signed-off-by: Corvin Köhne Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Cc: Leif Lindholm Cc: Peter Grehan Cc: Rebecca Cran Cc: Sami Mujawar --- OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf

[edk2-devel] [PATCH 5/5] OvmfPkg/Bhyve: install Acpi tables provided by FwCfg

2023-06-14 Thread Corvin Köhne
Signed-off-by: Corvin Köhne Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Cc: Leif Lindholm Cc: Peter Grehan Cc: Rebecca Cran Cc: Sami Mujawar --- OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 5 + 1 file changed, 5 insertions(+) diff --git

[edk2-devel] [PATCH 3/5] OvmfPkg: move BootScript into AcpiPlatformLib

2023-06-14 Thread Corvin Köhne
This is required to move InstallQemuFwCfgTables into AcpiPlatformLib. Signed-off-by: Corvin Köhne Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Cc: Leif Lindholm Cc: Peter Grehan Cc: Rebecca Cran Cc: Sami Mujawar --- OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf

[edk2-devel] [PATCH 2/5] OvmfPkg: move PciEncoding into AcpiPlatformLib

2023-06-14 Thread Corvin Köhne
Bhyve supports providing ACPI tables by FwCfg. Therefore, InstallQemuFwCfgTables should be moved to AcpiPlatformLib to reuse the code. As first step, move PciEncoding into AcpiPlatformLib. Signed-off-by: Corvin Köhne Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Cc:

[edk2-devel] [PATCH 1/5] OvmfPkg: avoid including AcpiPlatformLib twice

2023-06-14 Thread Corvin Köhne
Signed-off-by: Corvin Köhne Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Cc: Leif Lindholm Cc: Peter Grehan Cc: Rebecca Cran Cc: Sami Mujawar --- OvmfPkg/Include/Library/AcpiPlatformLib.h | 5 + 1 file changed, 5 insertions(+) diff --git

[edk2-devel] [PATCH 0/5] OvmfPkg/Bhyve: install Acpi tables by FwCfg

2023-06-14 Thread Corvin Köhne
Hi, latest Bhyve exposes it's Acpi tables by FwCfg. This patch series reuses the Acpi Install method of Qemu for Bhyve. CI: https://github.com/tianocore/edk2/pull/4545 Kind regards, Corvin Corvin Köhne (5): OvmfPkg: avoid including AcpiPlatformLib twice OvmfPkg: move PciEncoding into

Re: [edk2-devel] Question about limit size of OvmfPkg NOOPT build

2023-06-14 Thread Yao, Jiewen
I think it is reasonable, due to big size issue in NOOPT. Thank you Yao, Jiewen From: Li, Yi1 Sent: Monday, June 12, 2023 2:53 PM To: devel@edk2.groups.io; Ard Biesheuvel ; Yao, Jiewen ; Justen, Jordan L ; Gerd Hoffmann Subject: [edk2-devel] Question about limit size of OvmfPkg NOOPT build