Remove workaround for the redefinition of the type
RUNTIME_FUNCTION that is generated when building with
VS20xx tool chains and using windows include files.
The correct location for this fix is in the EmulatorPkg
in the WinInclude.h file that addresses all the name
collisions between edk2 types
Remove RUNTIME_FUNCTION redefinition error workaround from
the following commit to the MdePkg that only impacts EmulatorPkg
builds that uses windows include files:
https://github.com/tianocore/edk2/commit/ff52068d9261b9391d75b83a2a4e40e040f3b6eb
The correct location for this fix is in the
Update WinInclude.h to prevent error due to redefinition of
RUNTIME_FUNCTION using same technique that has been used
in the past for structure types such as LIST_ENTRY.
Cc: Gerd Hoffmann
Cc: Rebecca Cran
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Michael D Kinney
---
Hi Sami
Your patches worked. There was just one thing I had to add to get
compile to work. (inline with [GM]), other than that I think you can get
this in.
We've implemented about 18 table generators. (Types 0, 1, 2, 3, 8, 9,
11, 13, 14, 16, 17, 19, 32, 38, 39, 41, 43, 45)
Two more are
On Thu, Jul 20, 2023 at 2:46 PM Ard Biesheuvel wrote:
>
> Instead of relying on raising the TPL to protect the critical sections
> that manipulate the global bitmask that keeps track of bounce buffer
> allocations, use compare-and-exchange to manage the global variable, and
> tweak the logic to
On Fri, 21 Jul 2023 at 17:38, chitralekha ck wrote:
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=4507
> AllocatePool limits to allocate memory of 64 KB at most.
What is the basis for this observation? In DXE, pool allocations are
unbounded afaik.
> if the the image size is higher than
Reviewed by : Jayaprakash N
-Original Message-
From: devel@edk2.groups.io On Behalf Of Jayaprakash, N
Sent: Friday, July 21, 2023 9:22 PM
To: Kinney, Michael D ; devel@edk2.groups.io
Cc: Rebecca Cran ; Kloper, Dimitry
; Kloper, Dimitry
Subject: Re: [edk2-devel] [edk2-libc Patch 1/1]
Hi Mike,
I was trying to explore with Co-authored-by tag as I simplified the patch with
minor edits.
If it doesn't work I shall remove it.
I noticed after sending the patch. So I have sent V2 patch by removing the , in
the names.
I will go ahead and merge this change.
Regards,
JP
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4506
res_init() is called from different places in sockets library.
It depends on global _res variable containing a state.
The problem is that if __BIND_RES_TEXT macro is not defined, _res is not
initialized.
Depending on compiler and build
This patch has fix for un-initialized global variable in the
edk2-libc repos StdLib/BsdSocketLib.
Jayaprakash N (1):
edk2-libc/StdLib: Uninitialized global variable
StdLib/BsdSocketLib/res_init.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
--
2.40.0.windows.1
https://bugzilla.tianocore.org/show_bug.cgi?id=4507
AllocatePool limits to allocate memory of 64 KB at most.
if the the image size is higher than that it will fail to allocate.
change the function debug string to __func__
Cc: Ray Ni
Cc: Zhichao Gao
Cc: Ashraf Ali S
Cc: Chinni B Duggapu
Hi JP,
I have not seen co-authored-by tag used before.
If Dimitry is the author, then please update git commit so
Dimitry is the author and remove that tag.
Also, please make sure that names do not contain ','.
Should be: Dimity Kloper
Thanks,
Mike
> -Original Message-
> From:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4506
res_init() is called from different places in sockets library. It depends
on global _res variable containing a state. The problem is that
if __BIND_RES_TEXT macro is not defined, _res is not initialized.
Depending on compiler and build
This patch has fix for un-initialized global variable in the edk2-libc repos
StdLib/BsdSocketLib.
Jayaprakash N (1):
edk2-libc/StdLib: Uninitialized global variable
StdLib/BsdSocketLib/res_init.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
--
2.40.0.windows.1
Looks good to me. Thanks Ted!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kuo, Ted
> Sent: Thursday, July 20, 2023 3:20 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S, Ashraf
> Ali ; Duggapu, Chinni B ;
> Ng, Ray Han Lim ;
15 matches
Mail list logo
