Re: [edk2-devel] [PATCH] NetworkPkg: Increase HTTP buffer size and enable TCP window scaling

Reviewed-by: Saloni Kasbekar -Original Message- From: Li, Yi1 Sent: Thursday, July 20, 2023 10:18 PM To: devel@edk2.groups.io Cc: Li, Yi1 ; Otcheretianski, Andrei ; Kasbekar, Saloni ; Clark-williams, Zachary Subject: [PATCH] NetworkPkg: Increase HTTP buffer size and enable TCP

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: fix netmask check issue

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Monday, July 24, 2023 8:15 PM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH] RedfishPkg/RedfishDiscoverDxe: fix netmask check issue **CAUTION: The

Re: [edk2-devel] empty USB DVD disk hang Xhci

Sorry, I do not have much resource to review this in detail. But the patch generally looks good to me: Acked-by: Hao A Wu hao.a...@intel.com However, I hope the below question can be answered (or add related information to the commit log message) before mering: Likun,

[edk2-devel] 回复: [PATCH v1 3/4] MdeModulePkg: PeiMain: Introduce implementation of delayed dispatch

Kun: I add my comments below. > -邮件原件- > 发件人: Kun Qin > 发送时间: 2023年7月21日 5:07 > 收件人: devel@edk2.groups.io > 抄送: Jian J Wang ; Dandan Bi > ; Liming Gao ; > Debkumar De ; Catharine West > ; Mike Turner > 主题: [PATCH v1 3/4] MdeModulePkg: PeiMain: Introduce implementation of > delayed

[edk2-devel] 回复: [PATCH v1 2/4] MdePkg: DelayedDispatch: Added WaitOnEvent interface

Kun: This change is introduced in PI spec 1.8. Please update DelayedDispatch.h file header with correct PI version. Thanks Liming > -邮件原件- > 发件人: Kun Qin > 发送时间: 2023年7月21日 5:07 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Mike > Turner > 主题:

回复: [edk2-devel] empty USB DVD disk hang Xhci

Likun: This change is good to me. Reviewed-by: Liming Gao Hao: Have you time to review this fix? Thanks Liming 发件人: devel@edk2.groups.io 代表 苏丽坤 发送时间: 2023年7月18日 9:49 收件人: gaolim...@byosoft.com.cn; miki.deme...@intel.com; devel@edk2.groups.io 主题: [edk2-devel] empty USB DVD disk

[edk2-devel] [PATCH v3 13/14] MdeModulePkg: Update Function Headers in ImagePropertiesRecordLib

Update function headers to clarify the contract of each function and improve readability. Signed-off-by: Taylor Beebe Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi --- MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.c | 220 ++--

[edk2-devel] [PATCH v3 14/14] MdeModulePkg: Update DumpImageRecord() in ImagePropertiesRecordLib

Update DumpImageRecord() to be DumpImageRecords(), and improve the debug output. The function will output at DEBUG_INFO instead, and the function will be run in DXE and SMM MAT logic when the MAT is installed at EndOfDxe on DEBUG builds. Signed-off-by: Taylor Beebe Cc: Jian J Wang Cc: Liming

[edk2-devel] [PATCH v3 12/14] MdeModulePkg: Add Logic to Create/Delete Image Properties Records

Add logic to create and delete image properties records. Where applicable, redirect existing code to use the new library. Signed-off-by: Taylor Beebe Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi --- MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c | 184

[edk2-devel] [PATCH v3 11/14] MdeModulePkg: Transition SMM MAT Logic to Use ImagePropertiesRecordLib

Now that the bugs are fixed in the MAT logic, we can remove the duplicate logic from PiSmmCore/MemoryAttributesTable.c and use ImagePropertiesRecordLib instead. Signed-off-by: Taylor Beebe Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi --- MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c

[edk2-devel] [PATCH v3 09/14] MdeModulePkg: Fix Bugs in MAT Logic

Fix the bugs in the MAT logic before switching the UEFI and SMM MAT logic to use the new library. Signed-off-by: Taylor Beebe Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi --- MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c | 2 +-

[edk2-devel] [PATCH v3 08/14] MdeModulePkg: Add ImagePropertiesRecordLib Host-Based Unit Test

Create a host-based unit test for the ImagePropertiesRecordLib SplitTable() logic. This test has 4 cases which tests different potential image and memory map layouts. 3/4 of these tests fail with the logic in its current state to provide proof of the bugs in the current MAT logic. Signed-off-by:

[edk2-devel] [PATCH v3 10/14] UefiCpuPkg: Use Attribute From SMM MemoryAttributesTable if Nonzero

The function EnforceMemoryMapAttribute() in the SMM MAT logic will ensure that the CODE and DATA memory types have the desired attributes. The consumer of the SMM MAT should only override the Attributes field in the MAT if it is nonzero. This also allows the UEFI and SMM MAT logic to use

[edk2-devel] [PATCH v3 07/14] MdeModulePkg: Move Some DXE MAT Logic to ImagePropertiesRecordLib

Move some DXE MAT logic to ImagePropertiesRecordLib to consolidate code and enable unit testability. Signed-off-by: Taylor Beebe Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi --- MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c | 774 +---

[edk2-devel] [PATCH v3 06/14] MdeModulePkg: Update MemoryAttributesTable.c to Reduce Global Variable Use

This patch updates MemoryAttributesTable.c to reduce reliance on global variables and allow some logic to move to a library. Signed-off-by: Taylor Beebe Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi --- MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c | 102 +++- 1 file

[edk2-devel] [PATCH v3 01/14] MdeModulePkg: Add ImagePropertiesRecordLib

Create a library for manipulating image properties records. The library is currently blank and will be filled in a future patch to help with reviewer readability. Signed-off-by: Taylor Beebe Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi ---

[edk2-devel] [PATCH v3 03/14] EmulatorPkg: Add ImagePropertiesRecordLib Instance

Add an instance of ImagePropertiesRecordLib which will be used by the DXE Core. Signed-off-by: Taylor Beebe Cc: Andrew Fish Cc: Ray Ni --- EmulatorPkg/EmulatorPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc index

[edk2-devel] [PATCH v3 04/14] OvmfPkg: Add ImagePropertiesRecordLib Instance

Add an instance of ImagePropertiesRecordLib which will be used by the DXE Core. Signed-off-by: Taylor Beebe Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann --- OvmfPkg/AmdSev/AmdSevX64.dsc| 1 + OvmfPkg/Bhyve/BhyveX64.dsc | 1 +

[edk2-devel] [PATCH v3 05/14] UefiPayloadPkg: Add ImagePropertiesRecordLib Instance

Add an instance of ImagePropertiesRecordLib which will be used by the DXE Core. Signed-off-by: Taylor Beebe Cc: Guo Dong Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo --- UefiPayloadPkg/UefiPayloadPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc

[edk2-devel] [PATCH v3 02/14] ArmVirtPkg: Add ImagePropertiesRecordLib Instance

Add an instance of ImagePropertiesRecordLib which will be used by the DXE Core. Signed-off-by: Taylor Beebe Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann --- ArmVirtPkg/ArmVirt.dsc.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/ArmVirtPkg/ArmVirt.dsc.inc

[edk2-devel] [PATCH v3 00/14] Add ImagePropertiesRecordLib and Fix MAT Bugs

v3: - Refactor patch series so the transition of logic from the DXE MAT logic to the new library is more clear. - Update function headers to improve clarity and follow EDK2 standards. - Add Create and Delete functions for Image Properties Records and redirect some of the SMM and DXE MAT code

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, July 25, 2023 #cal-reminder

*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, July 25, 2023 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:*

[edk2-devel] [PATCH] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

From: Yang Wang Check EmacGetDmaStatus input parameters IrqStat may be a null pointer. Signed-off-by: Yang Wang --- .../Drivers/DwEmacSnpDxe/DwEmacSnpDxe.c | 7 +-- .../Drivers/DwEmacSnpDxe/EmacDxeUtil.c | 16 .../Drivers/DwEmacSnpDxe/EmacDxeUtil.h

[edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: fix netmask check issue

- Add NTOHL() for coverting IP address from EFI_IPv4_ADDRESS to IP4_ADDR so that IP4_IS_VALID_NETMASK() return correct value. - Add DumpIpv4Address() in RedfishDebugLib and print IP address when invalid IP or subnet mask address is detected. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, July 24, 2023 #cal-notice

*Tools, CI, Code base construction meeting series* *When:* Monday, July 24, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:*

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, July 24, 2023 #cal-reminder

*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, July 24, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

Hi Ard, I did a search for invalid tags in commit messages. Here is what I suggest as a change to PatchCheck.py to catch the cases I observe that includes the fix the to logic you suggested to find email addresses from edk2 groups/io mailing lists. = diff --git

[edk2-devel] [PATCH v1 3/3] ArmPkg: ArmGic: Added functionalities to manipulate pending interrupts

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4466 This change provides additional functionalities to `ArmGicLib` to manipulate pending interrupt related status. The added functions include: - `ArmGicSetPendingInterrupt` - `ArmGicClearPendingInterrupt` - `ArmGicIsInterruptPending` Cc:

[edk2-devel] [PATCH v1 2/3] ArmPkg: ArmGicLib: Added GIC v3 and v4 support to ArmGicSendSgiTo

From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4466 This change extended the existing function `ArmGicSendSgiTo` of ArmGicLib to format the incoming parameters to comply with GICv3 and GICv4 spec, and signal software generated interrupts to non secure group 1 at EL1. Cc:

[edk2-devel] [PATCH v1 0/3] Add support for handling SGI and pending interrupts

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4466 This patch series introduce a few improvements related to interrupt handling for ArmGic driver and library. 1. The current implementation of the `ArmGicSendSgiTo` is based on GIC v2 and does not work on GIC v3 and on. 2. The pending

[edk2-devel] [PATCH v1 1/3] ArmPkg: ArmGic: Added support to send SGI to NS G1 EL1

From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4466 This change extended the functionality of ArmGic to support sending software generated interrupts to non-secure group 1 at EL1. The change made here follows the ARM documentation `ICC_SGI1R_EL1, Interrupt Controller

Re: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Add SMBIOS table dispatcher

Hi Girish, Thank you for taking this effort forward Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 22/07/2023 12:14 am, Girish Mahadevan wrote: Hi Sami Your patches worked. There was just one thing I had to add to get compile to work. (inline with [GM]), other than

Re: [edk2-devel] Detecting Linux boot failure from UEFI shell (BootServices)

On Mon, Jul 24, 2023 at 6:07 PM wrote: > > I am developing a UEFI application which functions as a bootloader. It is > required to handle loading between two Linux kernels dependending on which > one failed last (A/B system). > Is there a way to detect if the kernel failed to load/start

Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy

On Mon, Jul 24, 2023 at 3:21 PM Ard Biesheuvel wrote: > > On Sat, 22 Jul 2023 at 00:55, Pedro Falcato wrote: > > > > On Thu, Jul 20, 2023 at 2:46 PM Ard Biesheuvel wrote: > > > > > > Instead of relying on raising the TPL to protect the critical sections > > > that manipulate the global bitmask

[edk2-devel] Detecting Linux boot failure from UEFI shell (BootServices)

I am developing a UEFI application which functions as a bootloader. It is required to handle loading between two Linux kernels dependending on which one failed last (A/B system). Is there a way to detect if the kernel failed to load/start successfully from the UEFI shell or application? I read

Re: [edk2-devel] [PATCH] SecurityPkg: DxeTcg2PhysicalPresenceLib for Clear Graphics Screen To unblock and Display TPM messages

Can you please review and share your feedback? Thanks & Regards Karunakar Poosapalli Firmware Principal Engineer, Client BIOS Customer BIOS | Dell Core BIOS CPG Software Engineering | Dell Technologies Mobile +91 9951902957 karunakar_poosapa...@dell.com

[edk2-devel] Recall: [PATCH] MinPlatformPkg: Remove IA32 in PeiFspWrapperPlatformLib

Hsueh, DoraX would like to recall the message, "[PATCH] MinPlatformPkg: Remove IA32 in PeiFspWrapperPlatformLib". -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107181): https://edk2.groups.io/g/devel/message/107181 Mute This Topic:

[edk2-devel] [PATCH] MinPlatformPkg: Remove IA32 in PeiFspWrapperPlatformLib

From: DoraX Hsueh REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4508 Remove IA32 only dependency, Because we need to support both IA32 and X64. Apply to a modern platform supporting x64. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Cc: Rosen Chuang

[edk2-devel] [PATCH] SecurityPkg: DxeTcg2PhysicalPresenceLib for Clear Graphics Screen To unblock and Display TPM messages

Patch review for Bugzilla - https://bugzilla.tianocore.org/show_bug.cgi?id=4462 >From c537f9c5c9e02c54e27466b96fe33555afccd358 Mon Sep 17 00:00:00 2001 From: Karunakar Poosapalli karunakar_poosapa...@dell.com Date: Sat, 22 Jul 2023 01:13:44 +0530 Subject:

[edk2-devel] [PATCH] MinPlatformPkg: Remove IA32 in PeiFspWrapperPlatformLib

From: DoraX Hsueh REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4508 Remove IA32 only dependency, Because we need to support both IA32 and X64. Apply to a modern platform supporting x64. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Cc: Rangasai V

Re: [edk2-devel] [PATCH] MinPlatformPkg: Remove IA32 in PeiFspWrapperPlatformLib

Add "Chaganty, Rangasai V" -Original Message- From: Hsueh, DoraX Sent: Monday, July 24, 2023 5:43 PM To: devel@edk2.groups.io Cc: Hsueh, DoraX ; Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming ; Dong, Eric ; Chuang, Rosen ; Kuo, Ted Subject: [PATCH]

Re: [edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add MPAM Parser

Hi Pierre, Thank you for the response. Few comments inline - > -Original Message- > From: Pierre Gondois > Sent: Monday, July 24, 2023 3:40 PM > To: Rohit Mathew ; devel@edk2.groups.io > Cc: Thomas Abraham ; Sami Mujawar > ; James Morse ; Ray Ni > ; Zhichao Gao ; nd > > Subject: Re:

Re: [edk2-devel] [PATCH V3 1/3] MdePkg/IndustryStandard: Add definitions for MPAM ACPI specification

Hi Pierre, > -Original Message- > From: Pierre Gondois > Sent: Monday, July 24, 2023 3:40 PM > To: Rohit Mathew ; devel@edk2.groups.io > Cc: Michael D Kinney ; Liming Gao > ; Thomas Abraham > ; Sami Mujawar ; > James Morse ; nd > Subject: Re: [edk2-devel] [PATCH V3 1/3]

Re: [edk2-devel] [PATCH v2 0/8] ArmCpuInfo improvements

W dniu 23.06.2023 o 13:08, Marcin Juszkiewicz pisze: W dniu 5.06.2023 o 08:37, Marcin Juszkiewicz via groups.io pisze: This changeset was supposed to add SVE/SME information but got some updates to improve output of ArmCpuInfo application a bit too. Probably would need to definition of system

Re: [edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add MPAM Parser

Hello Rohit, Thanks for the answers, I should have also answered your questions, Regards, Pierre On 7/24/23 11:50, Rohit Mathew wrote: Hi Pierre, Thank you for the detailed review. Please find my response inline. On 5/22/23 16:45, Rohit Mathew via groups.io wrote: Add a parser for the MPAM

Re: [edk2-devel] [PATCH V3 1/3] MdePkg/IndustryStandard: Add definitions for MPAM ACPI specification

On 7/24/23 11:50, Rohit Mathew wrote: Hi Pierre, Thank you for the review. Please find my response inline. Hello Rohit, On 5/22/23 16:44, Rohit Mathew via groups.io wrote: From: Rohit Mathew Add definitions, macros and types for elements associated with MPAM ACPI 2.0 specification.

Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy

On Sat, 22 Jul 2023 at 00:55, Pedro Falcato wrote: > > On Thu, Jul 20, 2023 at 2:46 PM Ard Biesheuvel wrote: > > > > Instead of relying on raising the TPL to protect the critical sections > > that manipulate the global bitmask that keeps track of bounce buffer > > allocations, use

[edk2-devel] [PATCH v1 0/1] OvmfPkg/Bhyve: build PlatformInfoHob

CI: https://github.com/tianocore/edk2/pull/4676 Corvin Köhne (1): OvmfPkg/Bhyve: build platform info HOB OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf | 1 + OvmfPkg/Bhyve/PlatformPei/Platform.c | 20 2 files changed, 21 insertions(+) -- 2.41.0

[edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB

Copy the function BuildPlatformInfoHob() from OvmfPkg/PlatformPei. QemuFwCfgLib expect this HOB to be present, or fails to do anything. InternalQemuFwCfgIsAvailable() from QemuFwCfgPeiLib module will not check if the HOB is actually present for example and try to use a NULL pointer. Fixes:

Re: [edk2-devel] [PATCH v2 0/3] OvmfPkg/Bhyve: enable bus enumeration

On Tue, 2023-07-11 at 09:16 +0200, Corvin Köhne wrote: > CI: https://github.com/tianocore/edk2/pull/4543 > > Corvin Köhne (3): >   Revert "OvmfPkg/Bhyve: consume PciHostBridgeLibScan" >   Revert "OvmfPkg/Bhyve: remove IncompatiblePciDeviceSupport DXE > driver" >   OvmfPkg/BhyvePkg: enable bus

Re: [edk2-devel] [PATCH 3/4] OvmfPkg: Remove applicationProcessorEntryPoint

On Mon, Jul 10, 2023 at 11:17:05AM +0800, Zhiguang Liu wrote: > diff --git a/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm > b/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm > index 56749bdbc9..67156d8252 100644 > --- a/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm > +++

Re: [edk2-devel] [PATCH V3 1/3] MdePkg/IndustryStandard: Add definitions for MPAM ACPI specification

Hi Pierre, Thank you for the review. Please find my response inline. > > Hello Rohit, > > On 5/22/23 16:44, Rohit Mathew via groups.io wrote: > > From: Rohit Mathew > > > > Add definitions, macros and types for elements associated with MPAM > > ACPI 2.0 specification. > > > > Signed-off-by:

Re: [edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add MPAM Parser

Hi Pierre, Thank you for the detailed review. Please find my response inline. > On 5/22/23 16:45, Rohit Mathew via groups.io wrote: > > Add a parser for the MPAM (Memory system resource partitioning and > > monitoring) ACPI table. This parser would parse all MPAM related > > structures embedded

Re: [edk2-devel] [PATCH 8/8] AlderlakeSiliconPkg/SystemAgent: Add library and driver modules

Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Thursday, June 15, 2023 10:53 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH 8/8]

Re: [edk2-devel] [PATCH 7/8] AlderlakeSiliconPkg/SystemAgent: Add include headers

Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Thursday, June 15, 2023 10:53 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH 7/8]

Re: [edk2-devel] [PATCH 6/8] AlderlakeSiliconPkg/SystemAgent: Add NVS support

Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Thursday, June 15, 2023 10:53 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH 6/8]

Re: [edk2-devel] [PATCH 4/8] AlderlakeSiliconPkg/Pch: Add libraries

Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Thursday, June 15, 2023 10:53 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH 4/8] AlderlakeSiliconPkg/Pch: Add

Re: [edk2-devel] [PATCH 3/8] AlderlakeSiliconPkg/Pch: Add include headers

Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Thursday, June 15, 2023 10:53 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH 3/8] AlderlakeSiliconPkg/Pch: Add

Re: [edk2-devel] [PATCH] MdeModulePkg: AllocatePages for TranslateBmpToGopBlt

On Mon, 24 Jul 2023 at 06:56, S, Ashraf Ali wrote: > > Hi., > > The observation is based on if the Library consumed in the PEI Phase > (PostMem). > In that case, please fix the comment that refers to EFI_BOOT_SERVICES.AllocatePool/Pages() directly, and instead, update the comment to reflect