Re: [edk2-devel] [PATCH v4 1/1] MdePkg:Implement RISCV CMO

2023-07-26 Thread Dhaval Sharma
Thanks for your feedback. 1. Reg coding style, I will remove _ and resubmit but somehow PR CI seemed to pass for me (https://github.com/tianocore/edk2/pull/4636). 2. For size and ext discovery should I wait until your ext discovery patch is merged? 3. Thanks for catching the issue

Re: [edk2-devel] empty USB DVD disk hang Xhci

2023-07-26 Thread 苏丽坤
Hi, Hao,Liming, this is my reply, function XhcInitializeDeviceSlot64 will init EndpointTransferRing,while fuctionUsbMassReadBlocks return (Invalid Parameter), which result in run function UsbMassReset, this will call XhcDisableSlotCmd64, will clear EndpointTransferRing, like this

Re: [edk2-devel] [PATCH V3 2/3] ShellPkg: acpiview: Add routine to print 16 chars

2023-07-26 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Pierre Gondois > Sent: Thursday, July 20, 2023 11:25 PM > To: devel@edk2.groups.io; rohit.mat...@arm.com > Cc: Thomas Abraham ; Sami Mujawar > ; James Morse ; Ni, > Ray ; Gao, Zhichao > Subject: Re: [edk2-devel]

Re: [edk2-devel] [PATCH v2 1/1] ShellPkg: Acpiview/GTDT: Print timer flags information.

2023-07-26 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of levi.yun > Sent: Monday, July 17, 2023 3:44 PM > To: devel@edk2.groups.io > Cc: yeoreum@arm.com; Gao, Zhichao ; > pedro.falc...@gmail.com; sami.muja...@arm.com; >

Re: [edk2-devel] [PATCH v2 2/2] ShellPkg/Dp: Allow dp command to work without ACPI

2023-07-26 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Jeff > Brasen via groups.io > Sent: Saturday, July 1, 2023 1:30 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Bi, Dandan ; Gao, > Zhichao ; Jeff Brasen >

Re: [edk2-devel] [PATCH] Intel/MinPlatformPkg:Add MmSaveStateLib required by PiSmmCpuDxe

2023-07-26 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, July 27, 2023 10:22 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chiu, Chasel ; > Desimone, Nathaniel L ; Oram, Isaac W > ; Gao, Liming ; Dong, > Eric > Subject: [PATCH] Intel/MinPlatformPkg:Add MmSaveStateLib

Re: [edk2-devel] [PATCH] SimicsOpenBoardPkg: Set PcdDxeIplSwitchToLongMode to FALSE

2023-07-26 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, July 27, 2023 10:23 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Desimone, Nathaniel L > ; Zhiguang Liu > Subject: [PATCH] SimicsOpenBoardPkg: Set PcdDxeIplSwitchToLongMode to > FALSE > > Set

[edk2-devel] [PATCH] SimicsOpenBoardPkg: Set PcdDxeIplSwitchToLongMode to FALSE

2023-07-26 Thread duntan
Set PcdDxeIplSwitchToLongMode to FALSE if the execution mode is not IA32 PEI + X64 DXE. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Nate DeSimone Cc: Zhiguang Liu --- Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc | 4 1 file changed, 4 insertions(+) diff --git

[edk2-devel] [PATCH] Intel/MinPlatformPkg:Add MmSaveStateLib required by PiSmmCpuDxe

2023-07-26 Thread duntan
Add MmSaveStateLib instance required by PiSmmCpuDxe driver to fix QSP platform build failure. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong --- Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc | 1 + 1 file changed,

[edk2-devel] [PATCH 5/5] UefiCpuPkg/PiSmmCpuDxe: use MpService2Ppi to wakeup AP in s3

2023-07-26 Thread duntan
Use MpService2Ppi to wakeup AP in s3 boot flow during initializing CPU. If mSmmS3ResumeState->MpService2Ppi is not 0, then BSP will use MpService2Ppi->StartupAllCPUs to do CPU initialization for both BSP and AP instead of only sending InitSipiSipi for AP. Signed-off-by: Dun Tan Cc: Eric Dong

[edk2-devel] [PATCH 4/5] UefiCpuPkg/PiSmmCpuDxe: code refinement for CpuS3.c

2023-07-26 Thread duntan
This commit is code logic refinement for CpuS3.c. It doesn't change any code functionality. In this commit, abstract the function originally executed by BSP into a new InitializeBsp(). Also prepare the AP StartupVector and send InitSipiSipi in SmmRestoreCpu() when mAcpiCpuData is valid. Or only

[edk2-devel] [PATCH 3/5] UefiCpuPkg/S3Resume2Pei: assert for invalid excution mode combo

2023-07-26 Thread duntan
Add assert for invalid excution mode combination of 64bit PEI + 32bit DXE. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar --- UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[edk2-devel] [PATCH 2/5] UefiCpuPkg/S3Resume2Pei: prepare MpService2Ppi in S3Resume

2023-07-26 Thread duntan
Prepare MpService2Ppi in S3Resume when PEI and SMM env run in the same execution mode. Then smm s3 code can use Mp Service to wakeup AP instead of only sending InitSipiSipi. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar --- UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c

[edk2-devel] [PATCH 1/5] MdeModulePkg: add MpService2Ppi field in SMM_S3_RESUME_STATE

2023-07-26 Thread duntan
Add MpService2Ppi field in SMM_S3_RESUME_STATE of AcpiS3Context.h. It will be used to wakeup AP to do the CPU initialization during smm s3 boot flow in following patches. With this field, we can avoid sending InitSipiSipi to wakeup AP. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Jian J Wang Cc:

[edk2-devel] [PATCH 0/5] Use MpService2Ppi to wakeup CPU in Smm CpuS3

2023-07-26 Thread duntan
This patch set is to prepare MpService2Ppi in S3Resume when PEI and SMM env run in the same execution mode, and use MpService2Ppi to wakeup Cpu to do CPU initialization in Smm CpuS3 boot flow if MpService2Ppi is not 0 in mSmmS3ResumeState. Dun Tan (5): MdeModulePkg: add MpService2Ppi field in

Re: [edk2-devel] [PATCH] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-26 Thread Pedro Falcato
On Wed, Jul 26, 2023 at 4:07 AM wangy wrote: > > Hi Pedro Falcato, > > At 2023-07-25 16:45:01, "Pedro Falcato" wrote: > > >On Tue, Jul 25, 2023 at 2:10 AM wrote: > >> > >> From: Yang Wang > >> > >> Check EmacGetDmaStatus input parameters > >> IrqStat may be a null pointer. > >> > >>

Re: [edk2-devel] [PATCH v1 0/3] Add support for handling SGI and pending interrupts

2023-07-26 Thread Kun Qin
Hi Ard, Our current use case is around AP core suspension and wake-ups. The program can suspend the secondary cores through PSCI interfaces (after powering them on). BSP can then wake up the suspended cores through SGI on demand. The pending interrupt manipulation is to support BSP

Re: [edk2-devel] [PATCH] MinPlatformPkg: Remove IA32 in PeiFspWrapperPlatformLib

2023-07-26 Thread Isaac Oram
Pushed as 9131d63e08..41e8d638fa -Original Message- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Wednesday, July 26, 2023 10:11 AM To: Hsueh, DoraX ; devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric ; Chuang, Rosen ; Kuo, Ted

Re: [edk2-devel] [PATCH] MinPlatformPkg: Remove IA32 in PeiFspWrapperPlatformLib

2023-07-26 Thread Isaac Oram
Reviewed-by: Isaac Oram -Original Message- From: Hsueh, DoraX Sent: Monday, July 24, 2023 3:43 AM To: devel@edk2.groups.io Cc: Hsueh, DoraX ; Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming ; Dong, Eric ; Chuang, Rosen ; Kuo, Ted Subject: [PATCH] MinPlatformPkg:

[edk2-devel] [edk2-libc Patch v2 1/1] edk2-libc/StdLib: Fix uninitialized global variable

2023-07-26 Thread Jayaprakash, N
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4506 res_init() is called from different places in sockets library. It depends on global _res variable containing a state. The problem is that if __BIND_RES_TEXT macro is not defined, _res is not initialized. Depending on compiler and build

[edk2-devel] [edk2-libc Patch v2 0/1] edk2-libc:Fix uninitialized global variable

2023-07-26 Thread Jayaprakash, N
This patch contains a fix for the uninitialized global variable in edk2-libc/StdLib/BsdSocketLib/res_init.c Jayaprakash N (1): edk2-libc/StdLib: Fix uninitialized global variable StdLib/BsdSocketLib/res_init.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.40.0.windows.1

Re: [edk2-devel] [PATCH] MinPlatformPkg: Remove IA32 in PeiFspWrapperPlatformLib

2023-07-26 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Hsueh, DoraX > Sent: Monday, July 24, 2023 2:43 AM > To: devel@edk2.groups.io > Cc: Hsueh, DoraX ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Oram, Isaac W ; > Gao, Liming ; Dong, Eric ; > Chuang, Rosen ; Kuo, Ted

Re: [edk2-devel] [Patch V3] UefiCpuPkg: Decouple the SEV-ES functionality.

2023-07-26 Thread Lendacky, Thomas via groups.io
On 7/26/23 02:51, YuanhaoXie wrote: The purpose is to fix an issue where an exception occurs at the start of the DXE phase by applying the following patch series on INTEL-based systems. UefiCpuPkg: Refactor the logic for placing APs in HltLoop. UefiCpuPkg: Refactor the logic for placing APs in

Re: [edk2-devel] [PATCH edk2-non-osi 1/1] Qemu/Sbsa: Update TF-A binaries for Neoverse-V1 support

2023-07-26 Thread Marcin Juszkiewicz
W dniu 14.07.2023 o 15:03, Marcin Juszkiewicz via groups.io pisze: Update the TF-A binaries to have Neoverse-V1 cpu support. This support was merged into TF-A: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/21813 This allows SBSA Reference Platform to boot Linux on

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc/StdLib: Fix uninitialized global variable

2023-07-26 Thread Michael Brown
On 25/07/2023 17:07, Jayaprakash, N wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4506 res_init() is called from different places in sockets library. It depends on global _res variable containing a state. The problem is that if __BIND_RES_TEXT macro is not defined, _res is not

Re: [edk2-devel] [PATCH V1 1/1] UefiCpuPkg/ResetVector: Cache Disable should not be set by default in CR0

2023-07-26 Thread Ni, Ray
This patch is not right. Intel SDM explicitly says the initial CR0 value is 6000_0010. CD bit is set. So the ResetVector code that still sets CD bit should be good. If you are facing NEM enable failure, can you change your NEM enable logic to explicitly clear CD bit instead of changing here?

Re: [edk2-devel] [PATCH v1 0/3] Add support for handling SGI and pending interrupts

2023-07-26 Thread Ard Biesheuvel
On Mon, 24 Jul 2023 at 22:15, Kun Qin wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4466 > > This patch series introduce a few improvements related to interrupt > handling for ArmGic driver and library. > > 1. The current implementation of the `ArmGicSendSgiTo` is based on GIC v2

Re: [edk2-devel] [Patch V3] UefiCpuPkg: Decouple the SEV-ES functionality.

2023-07-26 Thread Ni, Ray
Reviewed-by: Ray Ni @Tom Lendacky, can you please comment? > -Original Message- > From: Xie, Yuanhao > Sent: Wednesday, July 26, 2023 3:51 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Kumar, Rahul R > ; Tom Lendacky ; Ni, > Ray ; Xie, Yuanhao > Subject: [Patch V3] UefiCpuPkg:

[edk2-devel] [Patch V3] UefiCpuPkg: Decouple the SEV-ES functionality.

2023-07-26 Thread Yuanhao Xie
The purpose is to fix an issue where an exception occurs at the start of the DXE phase by applying the following patch series on INTEL-based systems. UefiCpuPkg: Refactor the logic for placing APs in HltLoop. UefiCpuPkg: Refactor the logic for placing APs in Mwait/Runloop. UefiCpuPkg: Create

[edk2-devel] [Patch V2] UefiCpuPkg: Decouple the SEV-ES functionality.

2023-07-26 Thread Yuanhao Xie
The purpose is to fix an issue where an exception occurs at the start of the DXE phase by applying the following patch series on INTEL-based systems. UefiCpuPkg: Refactor the logic for placing APs in HltLoop. UefiCpuPkg: Refactor the logic for placing APs in Mwait/Runloop. UefiCpuPkg: Create

[edk2-devel] [PATCH] BaseTools: Add FMMT BinPipWrappers

2023-07-26 Thread Yuwei Chen
Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Signed-off-by: Yuwei Chen --- BaseTools/BinPipWrappers/PosixLike/FMMT | 12 BaseTools/BinPipWrappers/WindowsLike/FMMT.bat | 3 +++ 2 files changed, 15 insertions(+) create mode 100755 BaseTools/BinPipWrappers/PosixLike/FMMT

[edk2-devel] [PATCH] UefiCpuPkg: Decouple the SEV-ES functionality.

2023-07-26 Thread Yuanhao Xie
The purpose is to fix an issue where an exception occurs at the start of the DXE phase by applying the following patch series on INTEL-based systems. UefiCpuPkg: Refactor the logic for placing APs in HltLoop. UefiCpuPkg: Refactor the logic for placing APs in Mwait/Runloop. UefiCpuPkg: Create