Re: [edk2-devel] [edk2-libc Patch v2 1/1] edk2-libc/StdLib: Fix uninitialized global variable

2023-07-30 Thread Jayaprakash, N
Reviewed-by: Jayaprakash N Regards, JP -Original Message- From: devel@edk2.groups.io On Behalf Of Jayaprakash, N Sent: Wednesday, July 26, 2023 9:09 PM To: devel@edk2.groups.io Cc: Jayaprakash, N ; Rebecca Cran ; Kinney, Michael D ; Kloper, Dimitry Subject: [edk2-devel] [edk2-libc

Re: [edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowser: Load storage via GetVariable for EfiVarStore

2023-07-30 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Bi, Dandan Sent: Monday, July 31, 2023 8:46 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Dong, Eric Subject: [PATCH v2] MdeModulePkg/SetupBrowser: Load storage via GetVariable for EfiVarStore For EfiVarStore

Re: [edk2-devel] [edk2-platforms][PATCH V1] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-30 Thread wangy
Hi Pedro Falcato, At 2023-07-29 03:40:15, "Pedro Falcato" wrote: >On Fri, Jul 28, 2023 at 5:00 AM wangy wrote: >> >> From: Yang Wang >> >> If IrqStat is NULL, the interrupt status will not be >> read from the device.When the interrupt status is read, >> it will also be cleared. > >Let's

[edk2-devel] [edk2-platforms][PATCH V3] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-30 Thread wangy
From: Yang Wang The EFI spec (see UEFI 2.10, 24.1.12) requires EFI_SIMPLE_NETWORK.GetStatus() to handle NULL InterruptStatus pointers by not reading nor clearing the interrupt status from the device. However, EmacGetDmaStatus (part of the DwEmacSnpDxe GetStatus() implementation) did not

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Use Performance Timer for XHCI Timeouts

2023-07-30 Thread Wu, Hao A
For the 2 occurrences of in XhcWaitOpRegBit & XhcExecTransfer: TimeoutTime = XHC_MICROSECOND_TO_NANOSECOND (Timeout * XHC_1_MILLISECOND); How about changing them to: TimeoutTime = XHC_MICROSECOND_TO_NANOSECOND ((UINT64) Timeout * XHC_1_MILLISECOND); to address possible overflow during

Re: [edk2-devel] [PATCH V5 1/3] MdePkg/Include: Add GUID for CERT_RSA3072 and CERT_RSA4096

2023-07-30 Thread Sheng Wei
Hi Gao, Liming, Could you help to review and merge this patch to MdePkg? This patch is only to add 2 new GUIDs. These 2 GUIDs will be used for adding RSA3072/RSA4096 cert support for secure boot feature. Thank you. BR Sheng Wei > > -Original Message- > > From: devel@edk2.groups.io On

Re: [edk2-devel] [PATCH v4 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity issue

2023-07-30 Thread Wu, Hao A
> -Original Message- > From: Ranbir Singh > Sent: Monday, July 17, 2023 12:25 PM > To: devel@edk2.groups.io; rsi...@ventanamicro.com > Cc: Wu, Hao A ; Ni, Ray > Subject: [PATCH v4 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix > UNUSED_VALUE Coverity issue > > From: Ranbir Singh > >

[edk2-devel] public-inbox instance for edk2-devel, allowing use of b4 patch tool

2023-07-30 Thread Rebecca Cran
I've set up a public-inbox instance for edk2-devel at https://openfw.io/edk2-devel . This lets people use the 'b4' tool (https://b4.docs.kernel.org/en/latest/) to apply patches from the mailing list. One issue at the moment is that line endings are normally mangled by email clients or

Re: [edk2-devel] [PATCH v2 0/3] OvmfPkg/Bhyve: enable bus enumeration

2023-07-30 Thread Rebecca Cran
Sorry for the delay! I started a new job recently and haven't had time for upstream EDK2 work. I've created https://github.com/tianocore/edk2/pull/4698 and set the 'push' label. -- Rebecca Cran On 7/24/23 04:34, Corvin Köhne wrote: On Tue, 2023-07-11 at 09:16 +0200, Corvin Köhne wrote:

[edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowser: Load storage via GetVariable for EfiVarStore

2023-07-30 Thread Dandan Bi
For EfiVarStore (EFI_HII_VARSTORE_EFI_VARIABLE_BUFFER), it will call ExtractConfig-GetVariable-HiiBlockToConfig-ConfigToBlock when load storage value in LoadStorage function. It's not necessary and costs lots of time to do the conversion between config and block. So now enhance it to call

Re: [edk2-devel] [PATCH v2 0/3] OvmfPkg/Bhyve: enable bus enumeration

2023-07-30 Thread Rebecca Cran
For the series: Reviewed-by: Rebecca Cran On 7/11/23 01:16, Corvin Köhne wrote: CI: https://github.com/tianocore/edk2/pull/4543 Corvin Köhne (3): Revert "OvmfPkg/Bhyve: consume PciHostBridgeLibScan" Revert "OvmfPkg/Bhyve: remove IncompatiblePciDeviceSupport DXE driver"

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, July 31, 2023 #cal-reminder

2023-07-30 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, July 31, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:*

[edk2-devel] [Patch V7 4/4] UefiCpuPkg:Wake up APs after power-up or RESET through SIPI.

2023-07-30 Thread Yuanhao Xie
The implementation of this new behavior aligns with the guidelines outlined in the Intel SDM. Following a power-up or RESET of an MP system, system hardware dynamically selects one of the processors on the system bus as the BSP. The remaining processors are designated as APs. The APs complete a

[edk2-devel] [Patch V7 3/4] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

2023-07-30 Thread Yuanhao Xie
Disable PcdFirstTimeWakeUpAPsBySipi for OVMF to let BSP wake up APs by INIT-SIPI-SIPI. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Signed-off-by: Yuanhao Xie Reviewed-by: Ray Ni --- OvmfPkg/OvmfPkgIa32.dsc| 9

[edk2-devel] [Patch V7 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi

2023-07-30 Thread Yuanhao Xie
Add PcdFirstTimeWakeUpAPsBySipi to check if it is in the OVMF environment and necessary to wake up APs by INIT-SIPI-SIPI. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Yuanhao Xie Reviewed-by: Ray Ni --- UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 +

[edk2-devel] [Patch V7 1/4] UefiCpuPkg: Add SendStartupIpiAllExcludingSelf

2023-07-30 Thread Yuanhao Xie
From: Yuanhao Xie Add new API SendStartupIpiAllExcludingSelf(), and modify SendInitSipiSipiAllExcludingSelf() by let it call the new API. Cc: Eric Dong Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ray Ni Signed-off-by: Ray Ni Signed-off-by: Yuanhao Xie Reviewed-by: Ray Ni ---

[edk2-devel] [Patch V7 0/4] Wake up APs after power-up or RESET through SIPI.

2023-07-30 Thread Yuanhao Xie
The implementation of this new behavior aligns with the guidelines outlined in the Intel SDM. Following a power-up or RESET of an MP system, system hardware dynamically selects one of the processors on the system bus as the BSP. The remaining processors are designated as APs. The APs complete a