Reviewed-by: Jayaprakash Nevara
-Original Message-
From: R, Vishal
Sent: Thursday, August 3, 2023 10:12 PM
To: devel@edk2.groups.io
Cc: R, Vishal ; Rebecca Cran ; Kinney,
Michael D ; Jayaprakash, N
Subject: [edk2-libc Patch 1/1] edk2-libc/AppPkg: Fix documentation issue with
Hi Jeff,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107632): https://edk2.groups.io/g/devel/message/107632
Mute This Topic:
Hi Jeff,
Thank you for this patch.
Other than the missing sign-off, this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107631):
Hi Jeff,
Thank you for this patch.
Please see my response inline.
On Mon, Jul 10, 2023 at 03:26 PM, Jeff Brasen wrote:
>
> +
> + Status = AmlVarListAddTail (
> + (AML_NODE_HANDLE)PackageNode,
> + (AML_NODE_HANDLE)DataNode
> + );
> + ASSERT_EFI_ERROR (Status);
> +
I think if the above function
Hi Jeff,
Apologies for the delay in feedback.
Please see my response inline.
On Mon, Jul 10, 2023 at 03:26 PM, Jeff Brasen wrote:
>
> +
> + // AmlCodeGenReturn() deletes DataNode if error.
> + Status = AmlCodeGenReturn (
> + (AML_NODE_HEADER *)DataNode,
> + ParentNode,
> +
> + );
> +
Hi Sunil,
I will be providing a detailed update soon, along with a new version. Thank you
for your careful review and comments.
Best regards,
Yin
-Original Message-
From: Sunil V L
Sent: Monday, August 7, 2023 8:02 PM
To: devel@edk2.groups.io; Wang, Yin
Subject: Re: [edk2-devel] [PATCH
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, August 8, 2023
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
*Tools, CI, Code base construction meeting series*
*When:*
Monday, August 7, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
The series as been pushed as ~107ddf1..3c274c0
-Original Message-
From: devel@edk2.groups.io On Behalf Of Nate DeSimone
Sent: Monday, July 31, 2023 11:43 AM
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Gao, Liming
; Liu, Zhiguang
Subject: [edk2-devel] [PATCH v1 0/2] MdePkg: Add
Reviewed-by: Nate DeSimone
> -Original Message-
> From: Joey Vagedes
> Sent: Monday, June 26, 2023 2:35 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Duggapu, Chinni B
> ; Chen, Gang C ;
> Zeng, Star ; Kuo, Ted ; S, Ashraf
> Ali ; Mohapatra, Susovan
>
>
Reviewed-by: Nate DeSimone
> -Original Message-
> From: Joey Vagedes
> Sent: Monday, June 26, 2023 2:34 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Duggapu, Chinni B
> ; Ng, Ray Han Lim ;
> Zeng, Star ; Kuo, Ted ; S, Ashraf
> Ali ; Mohapatra, Susovan
>
Reviewed-by: Nate DeSimone
> -Original Message-
> From: Joey Vagedes
> Sent: Monday, June 26, 2023 2:34 PM
> To: devel@edk2.groups.io
> Cc: Michael Kubacki ; Desimone, Nathaniel L
>
> Subject: [PATCH v1 19/24] PrmPkg: CI: Add PrEval entry
>
> Adds a PrEval entry to the package's
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, August 7, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
On Mon, 7 Aug 2023 at 13:31, Corvin Köhne wrote:
>
> On Mon, 2023-07-24 at 14:59 +0200, Corvin Köhne wrote:
> > Copy the function BuildPlatformInfoHob() from OvmfPkg/PlatformPei.
> >
> > QemuFwCfgLib expect this HOB to be present, or fails to do anything.
> > InternalQemuFwCfgIsAvailable() from
Hi Pierre,
> -Original Message-
> From: Pierre Gondois
> Sent: Friday, August 4, 2023 12:20 PM
> To: Rohit Mathew ; devel@edk2.groups.io
> Cc: Thomas Abraham ; Sami Mujawar
> ; James Morse ; Ray Ni
> ; Zhichao Gao ; nd
>
> Subject: Re: [edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add
Hi Wang,
Thanks for the patch!
It will be good if you add versions to the patch subject. Even if you
go back to v1, better to send as v3 with the change log.
On Fri, Jul 14, 2023 at 04:59:48PM +0800, Wang, Yin wrote:
> Onemore need change beside fixs:16acacf24c ("OvmfPkg: fix PlatformConfig")
> Set signature type to gEfiCertX509Guid when enroll RSA3072/RSA4096 KEK.
===
switch (KeyLenInBytes) {
case WIN_CERT_UEFI_RSA2048_SIZE:
CopyGuid (>SignatureType, );
break;
case WIN_CERT_UEFI_RSA3072_SIZE:
case WIN_CERT_UEFI_RSA4096_SIZE:
CopyGuid (>SignatureType, );
On Mon, 2023-07-24 at 14:59 +0200, Corvin Köhne wrote:
> Copy the function BuildPlatformInfoHob() from OvmfPkg/PlatformPei.
>
> QemuFwCfgLib expect this HOB to be present, or fails to do anything.
> InternalQemuFwCfgIsAvailable() from QemuFwCfgPeiLib module will not
> check if the HOB is actually
On 8/3/23 23:25, Ard Biesheuvel wrote:
> On Thu, 3 Aug 2023 at 21:21, Kinney, Michael D
> wrote:
>>
>> Hi Ard,
>>
>> This is the email with the analysis and the flag
>> setting required for SMP to work with SMM enabled for
>> IA32/X64 QEMU.
>>
>> https://edk2.groups.io/g/devel/message/102364
>>
Hi Jiewen,
I remove the new GUIDs.
I use signature type gEfiCertX509Guid when enroll RSA3072/RSA4096 KEK.
This signature type is used in below 6 places.
1) Show key name string in KEK delete page
UpdateDeletePage()
2) Check supported SignatureType when delete KEK
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3413
Change-Id: Ic13595ffb0581a178db71d231ba34f17862fa5d8
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Min Xu
Cc: Zeyi Chen
Cc: Fiona Wang
Signed-off-by: Sheng Wei
---
.../Library/AuthVariableLib/AuthService.c | 218 +++---
Register and initialize sha384/sha512 digest algorithms for PKCS#7 Handling.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3413
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Min Xu
Cc: Zeyi Chen
Cc: Fiona Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Cc: Michael D Kinney
Change-Id:
Patch V6:
Remove the changes in MdePkg.
The changes of patch v6 are in CryptoPkg and SecurityPkg.
Set signature type to gEfiCertX509Guid when enroll RSA3072/RSA4096 KEK.
This signature type is used to check the supported signature and show the
strings.
Patch V5:
Using define KEY_TYPE_RSASSA to
On Mon, 7 Aug 2023 at 03:56, Rebecca Cran wrote:
>
> There's an extra format specifier in the DEBUG_ERROR message that
> gets printed when the PCIe link check fails. This causes a
> synchronous exception. Remove the string format specifier.
>
> Signed-off-by: Rebecca Cran
Thanks
Pushed as
24 matches
Mail list logo
