Re: [edk2-devel] [PATCH v1] IntelFsp2Pkg: Add get and set FspSmmInit upd data pointer functions

Reviewed-by: S, Ashraf Ali Thanks., S, Ashraf Ali -Original Message- From: Chiu, Chasel Sent: Friday, August 25, 2023 9:37 AM To: Zhang, Hongbin1 ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Duggapu, Chinni B ; Ng, Ray Han Lim ; Zeng, Star ; Kuo, Ted ; S, Ashraf Ali ;

[edk2-devel] [PATCH v1] IntelFsp2Pkg: Add get and set FspSmmInit upd data pointer functions

FSP-SMM module need get and set FspSmmInit upd data pointer functions to get and set upd settings. Signed-off-by: Hongbin1 Zhang Cc: Chasel Chiu Cc: Nate DeSimone Cc: Duggapu Chinni B Cc: Ray Han Lim Ng Cc: Star Zeng Cc: Ted Kuo Cc: Ashraf Ali S Cc: Susovan Mohapatra ---

[edk2-devel] [PATCH] UefiPayloadPkg:Enhance the build processing for Universalpayload

From: KasimX Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4532 To Copy the PrebuildUplBinary to Build folder then add/replace Fvs. Cc: Guo Dong Cc: Ray Ni Cc: James Lu Cc: Gua Guo Signed-off-by: KasimX Liu --- UefiPayloadPkg/UniversalPayloadBuild.py | 8 +++- 1 file

Re: [edk2-devel] [PATCH v1] IntelFsp2Pkg: Add get and set FspSmmInit upd data pointer functions

Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Zhang, Hongbin1 > Sent: Thursday, August 24, 2023 8:15 PM > To: devel@edk2.groups.io > Cc: Zhang, Hongbin1 ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Duggapu, Chinni B > ; Ng, Ray Han Lim ; > Zeng, Star ; Kuo, Ted

Re: [edk2-devel] About EDK2 supports Self Modifying Code

Hi Mike, Sorry for reply late, I'm a bit busy this week. The Linux kernel defines some inline assembly functions to access CSR registers, as GCC compiled the Linux kernel is very popler now. Chao, Thinks -原始邮件- 发件人:"Michael D Kinney" 发送时间:2023-08-19 12:29:12 (星期六) 收件人: 李超 ,

[edk2-devel] [PATCH v4 1/1] MdePkg: Add Cxl20.h into IndustryStandard

@Foster @Mike @Liming and all kindly help review/vote again. RegisterBlock[] is used. 1) Add CXL 2.0 header file to comply with CXL 2.0 specification 2) CXL 2.0 header will embed Cxl11.h 3) Updated Cxl.h to point to 2.0 header file Signed-off-by: Chris Li ---

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc/StdLib: Fix console jump to 0, 0 issue in lseek()

On Thu, Aug 24, 2023 at 5:34 PM Jayaprakash, N wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4531 > > Python code opens console file descriptor and uses lseek() > with position == 0 and SEEK_CUR as > 'do nothing, check console is alive' operation. > > Current implementation of

Re: [edk2-devel] Visual Studio Code extension for EDK2

Thanks Willy! I have added your extensions to my recommended list of vscode extensions: Nate's Recommended VSCode Extensions and Settings * tianocore/tianocore.github.io Wiki Best Regards,

Re: [edk2-devel] [PATCH] Use C99 flexible arrays

I don't think I got around to explicitly requiring C11 with -std=c11, but since we use _Static_assert on compilers that don't have MSC Extensions or are C++ compilers we implicitly require it. It's possible it's implemented via an extension though. -- Rebecca Cran On 8/23/23 18:36, Pedro

Re: [edk2-devel] [PATCH] Use C99 flexible arrays

I'd support that. That would leave us with VS2017, VS2019 and VS2022. -- Rebecca Cran On 8/24/23 09:19, Oliver Smith-Denny wrote: On 8/23/2023 2:41 PM, Rebecca Cran wrote: With Visual Studio 2019 adding C11 and C17 support as first-class features, I think we should be safe nowadays to rely

Re: [edk2-devel] [PATCH v3 5/5] DynamicTablesPkg: Smbios Physical Memory Array (Type 16)

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Girish > Mahadevan via groups.io > Sent: Wednesday, July 26, 2023 12:38 AM > To: devel@edk2.groups.io; Sami Mujawar > Cc: gmahade...@nvidia.com; Alexei Fedorov ; > Pierre Gondois ; Jeff Brasen (jbra...@nvidia.com) > ;

Re: [edk2-devel] [PATCH v3 1/5] DynamicTablesPkg: Add SMBIOS table generation

Hi, I have a couple of minor comments. reviewed-by: Jose Marinho > -Original Message- > From: devel@edk2.groups.io On Behalf Of Girish > Mahadevan via groups.io > Sent: Wednesday, July 26, 2023 12:38 AM > To: devel@edk2.groups.io; Sami Mujawar > Cc: gmahade...@nvidia.com; Alexei

[edk2-devel] [PATCH 3/3] UefiCpuPkg/Include/Guid: Use C99 flexible arrays

One-element or zero-length arrays have been deprecated since last millennium. Use C99 flexible arrays instead, it allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Signed-off-by: Elyes Haouas ---

[edk2-devel] [PATCH 2/3] OvmfPkg/Library/CcExitLib: Use C99 flexible arrays

One-element or zero-length arrays have been deprecated since last millennium. Use C99 flexible arrays instead, it allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Signed-off-by: Elyes Haouas ---

[edk2-devel] [PATCH 1/3] MdeModulePkg/Include/UniversalPayload: Use C99 flexible arrays

One-element or zero-length arrays have been deprecated since last millennium. Use C99 flexible arrays instead, it allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Signed-off-by: Elyes Haouas ---

[edk2-devel] [edk2-libc Patch 1/1] edk2-libc/StdLib: Fix console jump to 0, 0 issue in lseek()

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4531 Python code opens console file descriptor and uses lseek() with position == 0 and SEEK_CUR as 'do nothing, check console is alive' operation. Current implementation of daConsole ignores whence argument, this is wrong in case lseek(0,

[edk2-devel] [edk2-libc Patch 0/1] Fix issue with lseek function

This patch fixes a corner case issue with the lseek function. The issue is captured in BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4531 Jayaprakash N (1): edk2-libc/StdLib: Fix console jump to 0, 0 issue in lseek() StdLib/LibC/Uefi/Devices/Console/daConsole.c | 10 +- 1 file

Re: [edk2-devel] [RFC PATCH 1/1] BaseTools: drop tautological warning overrides for CLANGDWARF

Thanks Rebecca, Ard, I'll fix the typo "progfile" -> "profile" in the commit message and merge after stable tag is done unless someone objects beforehand. As a sidenote, it may be worth looking into this for CLANGPDB as well, but I don't have a setup for that. / Leif On 2023-08-23

[edk2-devel] [PATCH 3/6] EmulatorPkg/Include/Ppi:: Use C99 flexible arrays

One-element or zero-length arrays have been deprecated since last millennium. Use C99 flexible arrays instead, it allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Signed-off-by: Elyes Haouas --- EmulatorPkg/Include/Ppi/EmuThunk.h | 2 +-

[edk2-devel] [PATCH 6/6] UefiCpuPkg/Library/CpuPageTableLib: Use C99 flexible arrays

One-element or zero-length arrays have been deprecated since last millennium. Use C99 flexible arrays instead, it allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Signed-off-by: Elyes Haouas ---

[edk2-devel] [PATCH 1/6] UefiPayloadPkg: Use C99 flexible arrays

One-element or zero-length arrays have been deprecated since last millennium. Use C99 flexible arrays instead, it allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Signed-off-by: Elyes Haouas --- UefiPayloadPkg/Include/Coreboot.h

[edk2-devel] [PATCH 4/6] MdeModulePkg/Include/Guid:: Use C99 flexible arrays

One-element or zero-length arrays have been deprecated since last millennium. Use C99 flexible arrays instead, it allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Signed-off-by: Elyes Haouas ---

[edk2-devel] [PATCH 5/6] MdeModulePkg/Universal/ResetSystemPei: Use C99 flexible arrays

One-element or zero-length arrays have been deprecated since last millennium. Use C99 flexible arrays instead, it allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Signed-off-by: Elyes Haouas ---

[edk2-devel] [PATCH 2/4] MdePkg/Include: Use C99 flexible arrays

One-element or zero-length arrays have been deprecated since last millennium. Use C99 flexible arrays instead, it allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Signed-off-by: Elyes Haouas ---

[edk2-devel] [PATCH 2/6] CryptoPkg/Include/Library:: Use C99 flexible arrays

One-element or zero-length arrays have been deprecated since last millennium. Use C99 flexible arrays instead, it allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Signed-off-by: Elyes Haouas --- CryptoPkg/Include/Library/BaseCryptLib.h |

[edk2-devel] [PATCH 3/4] MdeModulePkg/Library/FrameBufferBltLib: Use C99 flexible arrays

One-element or zero-length arrays have been deprecated since last millennium. Use C99 flexible arrays instead, it allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Signed-off-by: Elyes Haouas ---

[edk2-devel] [PATCH 1/4] EmbeddedPkg: Use C99 flexible arrays

One-element or zero-length arrays have been deprecated since last millennium. Use C99 flexible arrays instead, it allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Signed-off-by: Elyes Haouas --- EmbeddedPkg/Include/fdt.h | 4 ++-- 1 file

[edk2-devel] [PATCH 4/4] UefiPayloadPkg: Use C99 flexible arrays

One-element or zero-length arrays have been deprecated since last millennium. Use C99 flexible arrays instead, it allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Signed-off-by: Elyes Haouas --- UefiPayloadPkg/Include/Coreboot.h | 10

Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy

On Thu, 24 Aug 2023 at 10:06, Gerd Hoffmann wrote: > > On Wed, Aug 23, 2023 at 07:10:52PM +0100, Pedro Falcato wrote: > > On Wed, Aug 23, 2023 at 4:12 PM Ard Biesheuvel wrote: > > > > > > On Wed, 23 Aug 2023 at 13:08, Gerd Hoffmann wrote: > > > > > > > > Hmm, QE reports back it slows down the

[edk2-devel] [PATCH] MdeModulePkg/DxeCorePerformanceLib:fix smm perf issue

Fix smm perf issue in DxeCorePerformanceLib. In current code logic, total SMM perf record is copied multiple times to FPDT table if multiple ReadyToBoot events are signaled. This patch changes the function InternalGetSmmPerfData() to only get newly generated Smm perf data. Then previous generated

Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy

On Wed, Aug 23, 2023 at 07:10:52PM +0100, Pedro Falcato wrote: > On Wed, Aug 23, 2023 at 4:12 PM Ard Biesheuvel wrote: > > > > On Wed, 23 Aug 2023 at 13:08, Gerd Hoffmann wrote: > > > > > > Hmm, QE reports back it slows down the boot alot. No boot hangs yet > > > with 12 test runs so far, which