Reviewed-by: Star Zeng
BTW: You'd better to have a separated patch to also update
https://github.com/tianocore/edk2/blob/master/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c#L1713.
-Original Message-
From: gaoliming
Sent: Tuesday, September 5, 2023 10:29 AM
To:
Chris:
I have no comments on the patch. I suggest you trig open CI to verify the
coding format in this patch.
For this patch, Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Chris Li OS
> via groups.io
> 发送时间: 2023年8月25日 11:48
> 收件人: Kinney, Michael D
The change is good to me. Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 duntan
> 发送时间: 2023年9月1日 12:07
> 收件人: devel@edk2.groups.io; Tan, Dun
> 抄送: Wang, Jian J ; Gao, Liming
> ; Ni, Ray
> 主题: Re: [edk2-devel] [Patch V2]
> MdeModulePkg/DxeCorePerformanceLib:fix smm
Avi:
The change is good. Reviewed-by: Liming Gao
But, I have one minor comment. Please see below.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Avinash
> 发送时间: 2023年9月2日 2:21
> 收件人: devel@edk2.groups.io
> 抄送: avinashbhargava ; Zhiguang Liu
> ; Dandan Bi ; Star Zeng
> ;
Hi Oliver, thank you for taking a look at this patch.
On 9/2/2023 3:43 AM, Oliver Smith-Denny wrote:
On 8/31/2023 1:20 AM, Nhi Pham via groups.io wrote:
Hi Ard,
Thanks for your response on this patch. Please see my reply inline...
On 8/30/2023 8:10 PM, Ard Biesheuvel wrote:
[EXTERNAL EMAIL
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, September 5, 2023
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
*Tools, CI, Code base construction meeting series*
*When:*
Monday, September 4, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, September 4, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
Sorry I've not responded to your emails before now.
I don't normally use the build.sh script, so I'm fine with reverting to
the previous behavior.
--
Rebecca Cran
On 9/4/23 08:24, Mike Beaton wrote:
-Original Message-
From: Rebecca Cran
Sent: Wednesday, February 8, 2023 6:02 PM
I am moving this command outside of EDK2.
This reverts commit 2c2cb235289642775a7c4e6eaeffa6d3828d279c.
---
ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 2430 --
ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.inf | 31 -
ArmPkg/ArmPkg.dsc|1 -
3
In June I sent patchset of improvements to ArmCpuInfo command. No one
responded so I do not see sense in keeping it in EDK2.
I created https://github.com/hrw/edk2-armcpuinfo to have a place to
store final version. Will add information how to build it into README in
repository.
Changes since v2:
Hi Yuqing (?),
Thank you for this contribution.
I have a few high-level comments, but I will also look into the
individual patches and comment if I find things I feel will make the
port easier to maintain.
1) Git
If it is possible for you to push these patches to some public git
tree, that makes
In case the message didn't reach the relevant maintainers:
On 9/4/23 15:01, Sami Mujawar wrote:
Hi All,
This patch series implements code first USWG ECR 2386
(https://mantis.uefi.org/mantis/view.php?id=2386) and also fixes other issues
to enable RNG support on Arm.
The RNG implementation for
> -Original Message-
> From: Rebecca Cran
> Sent: Wednesday, February 8, 2023 6:02 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Ard Biesheuvel
> ; Jiewen Yao ; Jordan Justen
> ; Gerd Hoffmann
> Subject: [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then
> running
Hi Yuquan,
On Mon, Sep 04, 2023 at 14:30:57 +0800, Yuquan Wang wrote:
> Hi, Leif
> On 2023-08-31 21:06, Leif wrote:
>
> I had to move one hunk (.dec change) from 2/3 to 1/3 in order to
> not break bisect.
>
> If you're happy with the slightly modified version, I think this
> is good to go in.
Hi All,
This patch series implements code first USWG ECR 2386
(https://mantis.uefi.org/mantis/view.php?id=2386) and also fixes other issues
to enable RNG support on Arm.
The RNG implementation for Arm is broken without this series on some platforms.
If there are no further comments by end of
On Mon, 4 Sept 2023 at 13:45, Gerd Hoffmann wrote:
>
> On Thu, Aug 31, 2023 at 06:01:56PM +0200, Ard Biesheuvel wrote:
> > On Mon, 28 Aug 2023 at 13:13, Ard Biesheuvel wrote:
> > >
> > > On Mon, 28 Aug 2023 at 11:16, Gerd Hoffmann wrote:
> > > >
> > > > Hi,
> > > >
> > > > > I have tried the
On Thu, Aug 31, 2023 at 06:01:56PM +0200, Ard Biesheuvel wrote:
> On Mon, 28 Aug 2023 at 13:13, Ard Biesheuvel wrote:
> >
> > On Mon, 28 Aug 2023 at 11:16, Gerd Hoffmann wrote:
> > >
> > > Hi,
> > >
> > > > I have tried the patch below, and I don't see any slowdowns with or
> > > > without the
Skip those files in DscCompleteCheck is workaround IMO, I think we can add all
mbedtls libraries and components to CryptoPkg.dsc with new CRYPTO_SERVICES.
-Original Message-
From: Hou, Wenxing
Sent: Saturday, September 2, 2023 10:16 PM
To: devel@edk2.groups.io
Cc: Yao, Jiewen ; Li, Yi1
TestPublicExponent[] is same as default value so this test is nonsense.
Please use a different value to generate key and use RsaGetKey to confirm PE is
same as expect.
-Original Message-
From: Hou, Wenxing
Sent: Saturday, September 2, 2023 10:16 PM
To: devel@edk2.groups.io
Cc: Yao,
From: Linus Liu
https://bugzilla.tianocore.org/show_bug.cgi?id=3004
Cc: Qi Zhang
Cc: Rahul Kumar
Cc: Jiewen Yao
---
SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
Hi, Leif
On 2023-08-31 21:06, Leif wrote:
I had to move one hunk (.dec change) from 2/3 to 1/3 in order to
not break bisect.
If you're happy with the slightly modified version, I think this
is good to go in. Please let me know.
It' ok.
In the second version of this series patches, in
Hi Sean,
I would like to clarify that the purpose of this patch sequence is to
supplement the defects of openssl3.0 rather than seek a substitute for openssl.
Crypto implementations other than HASH and AES in Openssl3.0 cannot be used in
the PREMEM stage, and all implementations will be like
23 matches
Mail list logo
