Reviewed-by: Zhichao Gao
Thanks,
Zhichao
> -Original Message-
> From: Sami Mujawar
> Sent: Wednesday, September 13, 2023 8:50 PM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar ; Gao, Zhichao
> ; pierre.gond...@arm.com;
> anshuman.khand...@arm.com; matteo.carl...@arm.com;
>
[AMD Official Use Only - General]
Hi Nickle,
See my comments in line.
Thanks
Abner
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, September 12, 2023 11:10 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH]
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Igor Kulchytskyy
> Sent: Wednesday, September 13, 2023 3:07 AM
> To: Nickle Wang ; devel@edk2.groups.io
> Cc: Chang, Abner ; Nick Ramirez
>
> Subject: RE: [EXTERNAL] [PATCH v2 1/1]
>
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Thursday, September 14, 2023 1:06 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Nickle Wang
> ; Igor Kulchytskyy
> Subject: [PATCH v2 1/7]
On 9/12/23 10:11, CrossedCarpet wrote:
Delightful! Thank you for your swift response.
Would you mind telling me if this is the appropriate mailing list for
questions like such (and maybe some help)?
After posting I noticed that perhaps I ought have tagged my topic,
which led me to believe I
Reviewed-by: Sai Chaganty
-Original Message-
From: Kasbekar, Saloni
Sent: Wednesday, September 13, 2023 3:06 PM
To: devel@edk2.groups.io
Cc: Kasbekar, Saloni ; Chaganty, Rangasai V
; Desimone, Nathaniel L
; Chuang, Rosen
Subject: [PATCH 3/4] Readme.md: Add AlderlakeOpenBoardPkg
Add
Reviewed-by: Sai Chaganty
-Original Message-
From: Kasbekar, Saloni
Sent: Wednesday, September 13, 2023 3:06 PM
To: devel@edk2.groups.io
Cc: Kasbekar, Saloni ; Chaganty, Rangasai V
; Desimone, Nathaniel L
; Chuang, Rosen
Subject: [PATCH 2/4] Enable build for AlderlakeOpenBoardPkg
Reviewed-by: Sai Chaganty
-Original Message-
From: Kasbekar, Saloni
Sent: Wednesday, September 13, 2023 3:05 PM
To: devel@edk2.groups.io
Cc: Kasbekar, Saloni ; Chaganty, Rangasai V
; Desimone, Nathaniel L
; Chuang, Rosen
Subject: [PATCH 1/4] AlderlakeOpenBoardPkg/AlderlakePRvp: Add
Reviewed-by: Sai Chaganty
-Original Message-
From: Kasbekar, Saloni
Sent: Wednesday, September 13, 2023 3:06 PM
To: devel@edk2.groups.io
Cc: Kasbekar, Saloni ; Chaganty, Rangasai V
; Desimone, Nathaniel L
; Chuang, Rosen
Subject: [PATCH 4/4] Maintainers.txt: Add maintainers
Add
Adds the following modules:
- AdlCpu/CpuPcieRp
- AdlCpu/Include
- AdlCpu/IncludePrivate
- AdlCpu/LibraryPrivate
- AdlCpu/PeiReportCpuHob
- AdlCpu DSCs
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Rosen Chuang
Signed-off-by: Saloni Kasbekar
---
.../Fru/AdlCpu/CommonLib.dsc
Adds the following modules:
- Product/Alderlake/Include
- Product/Alderlake/Library
- Product/Alderlake DSCs
- SiPkg.dec
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Rosen Chuang
Signed-off-by: Saloni Kasbekar
---
.../Product/Alderlake/Include/Ppi/SiPolicy.h | 55 ++
Adds the following Includes:
- Include/
- Include/Protocol
- Include/Register
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Rosen Chuang
Signed-off-by: Saloni Kasbekar
---
.../AlderlakeSiliconPkg/Include/ConfigBlock.h | 53 +++
.../AlderlakeSiliconPkg/Include/CpuPcieHob.h | 48 +++
Adds the following modules:
- AdlPch/Include
- AdlPch/IncludePrivate
- AdlPch/Library
- AdlPch DSCs
- IncludePrivate
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Rosen Chuang
Signed-off-by: Saloni Kasbekar
---
.../Fru/AdlPch/CommonLib.dsc | 29 ++
Adds the following modules:
- IpBlock/Pmc/IncludePrivate
- IpBlock/Pmc/Library
- IpBlock/Pmc/LibraryPrivate
- IpBlock/Spi/IncludePrivate
- IpBlock/Spi/Library
- IpBlock/Spi/LibraryPrivate
- IpBlock/Spi/Smm
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Rosen Chuang
Signed-off-by: Saloni
Adds the following Includes:
- Include/Library
- Include/Pins
- Include/Ppi
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Rosen Chuang
Signed-off-by: Saloni Kasbekar
---
.../Include/Library/ConfigBlockLib.h | 64 +++
.../Include/Library/EspiLib.h | 34 ++
Adds the following modules:
- IpBlock/P2sb/IncludePrivate
- IpBlock/P2sb/Library
- IpBlock/P2sb/LibraryPrivate
- IpBlock/PchDmi/IncludePrivate
- IpBlock/PchDmi/LibraryPrivate
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Rosen Chuang
Signed-off-by: Saloni Kasbekar
---
Adds the following modules:
- IpBlock/Graphics/Include
- IpBlock/Graphics/IncludePrivate
- IpBlock/Graphics/Library
- IpBlock/Graphics/LibraryPrivate
- IpBlock/HostBridge/IncludePrivate
- IpBlock/PcieRp/Library
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Rosen Chuang
Signed-off-by:
Adds the following modules:
- IpBlock/CpuPcieRp/Include
- IpBlock/Espi/Library
- IpBlock/Gpio/IncludePrivate
- IpBlock/Gpio/Library
- IpBlock/Gpio/LibraryPrivate
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Rosen Chuang
Signed-off-by: Saloni Kasbekar
---
Add AlderlakeSiliconPkg and AlderlakeOpenBoardPkg maintainers
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Rosen Chuang
Signed-off-by: Saloni Kasbekar
---
Maintainers.txt | 14 ++
1 file changed, 14 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index
Adds the DSC and build files necessary to build the
AlderlakePRvp board instance.
Key files:
* build_config.cfg - Board-specific build configuration file.
* OpenBoardPkg.dsc - The AlderlakePRvp board description file.
* OpenBoardPkgPcd.dsc - Used for other PCD customization.
*
This change adds the configuration to enable build for AlderlakePRvp.
Also it updates Alderlake P Rvp details to the Readme.md.
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Rosen Chuang
Signed-off-by: Saloni Kasbekar
---
Platform/Intel/Readme.md | 11 +++
Platform/Intel/build.cfg | 1 +
2
Add AlderlakeOpenBoardPkg in the Readme
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Rosen Chuang
Signed-off-by: Saloni Kasbekar
---
Readme.md | 1 +
1 file changed, 1 insertion(+)
diff --git a/Readme.md b/Readme.md
index 624f9a6da6..8de9eaa7cf 100644
--- a/Readme.md
+++ b/Readme.md
@@ -254,6
On Wed, Sep 13, 2023 at 12:55:49PM +0200, Laszlo Ersek wrote:
> Riscv64 KVM services SBI calls internally, so OpenSBI is not used in such
> setups. Restrict the "-bios" flag accordingly. Thanks: Andrei, Drew.
>
> Cc: Andrei Warkentin
> Cc: Andrew Jones
> Cc: Ard Biesheuvel
> Cc: Gerd Hoffmann
On Wed, 13 Sept 2023 at 19:07, wrote:
>
> From: Michael Kubacki
>
> Adds a CI YAML entry to acknowledge a case where a macro is expanded
> that contains a print specifier.
>
> Cc: Ard Biesheuvel
> Cc: Leif Lindholm
> Cc: Sami Mujawar
> Cc: Gerd Hoffmann
> Signed-off-by: Michael Kubacki
From: Michael Kubacki
Adds a plugin that finds debug macro formatting issues. These errors
often creep into debug prints in error conditions not frequently
executed and make debug more difficult when they are encountered.
The code can be as a standalone script which is useful to find
problems
From: Michael Kubacki
Disables the DebugMacroCheck CI plugin to reduce CI checks performed
in the package.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Michael Kubacki
Reviewed-by: Jiewen Yao
---
OvmfPkg/PlatformCI/PlatformBuildLib.py | 1 +
1 file
From: Michael Kubacki
Adds a CI YAML entry to acknowledge a case where custom strings
contain print specifiers for a single debug macro.
Cc: Sami Mujawar
Cc: Alexei Fedorov
Cc: Pierre Gondois
Signed-off-by: Michael Kubacki
---
DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 8
1 file
From: Michael Kubacki
Adds a CI YAML entry to acknowledge a case where a macro is expanded
that contains a print specifier.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Signed-off-by: Michael Kubacki
---
ArmVirtPkg/ArmVirtPkg.ci.yaml | 8
1 file
From: Michael Kubacki
Adds a CI YAML entry to acknowledge a case where a single argument
is matched to a format specifier with a ternary operator.
Cc: Jiewen Yao
Cc: Jian J Wang
Signed-off-by: Michael Kubacki
Reviewed-by: Jiewen Yao
---
SecurityPkg/SecurityPkg.ci.yaml | 9 +
1 file
From: Michael Kubacki
Some macros added have a mismatched number of print specifiers to
arguments.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Michael Kubacki
---
RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.c
| 8
From: Michael Kubacki
regex is a popular PIP module for regular expression support.
https://pypi.org/project/regex/
This change adds regex for the upcoming DebugMacroCheck plugin.
Cc: Sean Brogan
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Michael Kubacki
Reviewed-by: Michael D
From: Michael Kubacki
Adds a new script and build plugin called DebugMacroCheck.
The script verifies that the number of print specifiers match the
number of arguments in DEBUG() calls.
Overview:
- Build plugin: BuildPlugin/DebugMacroCheckBuildPlugin.py
- Runs on any build target that is not
Not sure it's worth creating a new patchset for, but the "GetEArmObjEtInfo
(OPTIONAL)" comment should probably not have the "Get" prefix (ie. "
EArmObjEtInfo (OPTIONAL)").
-Original Message-
From: Sami Mujawar
Sent: Wednesday, September 13, 2023 6:50 AM
To: devel@edk2.groups.io
Cc:
On 9/13/23 13:02, Ard Biesheuvel wrote:
> On Wed, 13 Sept 2023 at 12:56, Laszlo Ersek wrote:
>>
>> "acpi=off" is arguably unusual with UEFI guest OSes; add a note to explain
>> it. Original explanation by Drew Jones.
>>
>
> Out of curiosity: how is this different from the -no-acpi QEMU command
>
When TRBE is enabled the FVP model uses the PPI 15
(i.e. INT ID 31) as the TRBE interrupt.
Ref: https://www.kernel.org/doc/Documentation/
devicetree/bindings/arm/arm,trace-buffer-extension.yaml
Therefore, check the debug feature register
ID_AA64DFR0_EL1.TraceBuffer field to see if TRBE is
enabled
Add support to dynamically generate the CPU nodes in SSDT.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change from v1 patch series. [SAMI]
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl
| 38 +---
When ETE is enabled in the FVP model the firmware can check
the debug feature register ID_AA64DFR0_EL1.TraceVer field
to identify the presence of FEAT_ETE and add an ETE device
to the CPU node in the AML CPU hierarchy. This enables the
Operating System driver to probe and enable ETE support.
This patch series updates the FVP platform firmware
to add support for dynamically generating CPU nodes
in AML and also reports the TRBE interrupt in the
MADT GICC structure. The last patch in the series
enables support for adding an ETE device to the CPU
device nodes in AML.
This patch series
The Coresight Embedded Trace Extension (ETE) feature
can be detected by the platform firmware by examining
the debug feature register ID_AA64DFR0_EL1.TraceVer
field.
The platform configuration manager can then describe
the ETE by creating CM_ARM_ET_INFO object(s) and
referencing these in
The ACPI 6.5 specification updates the MADT table to add
a new field to GICC for specifying the TRBE interrupt and
also adds support for Online Capable flag to the GICC flags.
The Online Capable flags should be passed transparently
through as specified in the CM_ARM_GICC_INFO.Flags field
and only
ACPI 6.5 introduces a new filed to the MADT GICC
structure to specify the TRBE interrupt. The TRBE
interrupt is a Processor Private interrupt (PPI)
and is used to specify a platform-specific
interrupt to signal TRBE events.
Therefore, update the MADT GICC structure parser
to parse the new TRBE
This patch series provides the following updates:
- The patches 1 & 2 add the new fields introduced
in MADT (APIC table) by ACPI 6.5 and the patch
7/11 updates the Acpiview MADT parser accordingly.
- The patches 3, 4 & 5 adds TRBE support to the MADT
table generator in DynamicTablesPkg.
-
The ASWG ECR 2303 introduces a new field 'TRBE
interrupt' to GICC structure in ACPI 6.5.
The Trace Buffer Extension (TRBE) interrupt is a
Processor Private interrupt (PPI) and is used to
specify a platform-specific interrupt to signal
TRBE events.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
The CpcToken has been incorrectly referenced in the
CreateTopologyFromGicC() and always points to the
CPC token in the first GICC Info object.
Therefore, fix this by correctly indexing into the
GicCInfo object array.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change from v1
Add an Embedded Trace (ET) info object that can be
used to provide information about Embedded Trace
Extension (ETE) or Embedded Trace Module (ETM)
available on a platform.
Although ETE and ETM share the same HID,
ETE has a system register interfaces, unlike
ETM which requires memory mapped
Bugzilla: 3706 'Code First - MADT GICC new flags'
On ARM systems physical CPU hotplug is not supported.
All CPUs are considered present and this is true
throughout the system uptime.
The ECR 2285 introduces a new 'online-capable' flag
in the GICC structure flags in ACPI 6.5, to signal
firmware
An Embedded Trace (ET) info object is used to provide
information about an Embedded Trace Extension (ETE) or
an Embedded Trace Module (ETM) available on a platform.
The CM_ARM_ET_INFO object has already been added to the
Arm namespace objects list by a previous patch.
Therefore, update the CM
The ACPI 6.5 specification updates the minor revision
of the FADT table to 5. Therefore, update the FADT
generator to setup the minor revision for ACPI 6.5.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change from v1 patch series. [SAMI]
ACPI 6.5 introduces a new filed to the MADT GICC structure
to specify the Trace Buffer Extension (TRBE) interrupt. The
TRBE interrupt is a Processor Private interrupt (PPI) and is
used to specify a platform-specific interrupt to signal TRBE
events.
This field has already been added to the
ACPI 6.5 introduces a new filed to the MADT GICC structure
to specify the Trace Buffer Extension (TRBE) interrupt. The
TRBE interrupt is a Processor Private interrupt (PPI) and is
used to specify a platform-specific interrupt to signal TRBE
events.
Therefore, update the CM_ARM_GICC_INFO to
On Wed, Sep 13, 2023 at 01:02:07PM +0200, Ard Biesheuvel wrote:
> On Wed, 13 Sept 2023 at 12:56, Laszlo Ersek wrote:
> >
> > "acpi=off" is arguably unusual with UEFI guest OSes; add a note to explain
> > it. Original explanation by Drew Jones.
> >
>
> Out of curiosity: how is this different from
On Wed, 13 Sept 2023 at 12:56, Laszlo Ersek wrote:
>
> "acpi=off" is arguably unusual with UEFI guest OSes; add a note to explain
> it. Original explanation by Drew Jones.
>
Out of curiosity: how is this different from the -no-acpi QEMU command
line option?
> Cc: Andrei Warkentin
> Cc: Andrew
Thanks Laszlo for the detail explanation, appreciate that.
I hope people will take action when it is close to 16MiB, then.
Anyway, I am OK with this so far.
Acked-by: Jiewen Yao
> -Original Message-
> From: Laszlo Ersek
> Sent: Tuesday, September 12, 2023 11:36 PM
> To: Yao, Jiewen
Direct (fw_cfg) kernel boot works on the RiscVVirt firmware platform too;
I've tested it after extracting the kernel, initrd, and kernel command
line from "openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw". Document this
type of boot, because at least historically, fw_cfg kernel boot was
implemented
"acpi=off" is arguably unusual with UEFI guest OSes; add a note to explain
it. Original explanation by Drew Jones.
Cc: Andrei Warkentin
Cc: Andrew Jones
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Sunil V L
Signed-off-by: Laszlo Ersek
---
Riscv64 KVM services SBI calls internally, so OpenSBI is not used in such
setups. Restrict the "-bios" flag accordingly. Thanks: Andrei, Drew.
Cc: Andrei Warkentin
Cc: Andrew Jones
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Sunil V L
Signed-off-by: Laszlo
The shortlog below provides a good summary :)
Cc: Andrei Warkentin
Cc: Andrew Jones
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Sunil V L
Thanks
Laszlo
Laszlo Ersek (3):
OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG
The length of the Board ID is being updated based on the BOARD_ID
string. If the PCH_TYPE is empty space/single quotes(''), removing the
empty space/single quotes('') and concatenating the
TARGET_PLATFORM_SHORT and BUILD flag strings.
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Cc: T V
On Mon, 11 Sept 2023 at 04:47, Zhenyu Zhang wrote:
>
> From: "Zhenyu Zhang"
>
> We observed that EDK2 hits an ASSERT (Out of Resources) when
> booting with a full variable store. The message provided in
> this case is not helpful for non-experts.
> Add debug information to help users understand
59 matches
Mail list logo
