Re: [edk2-devel] [PATCH v2 10/10] AlderlakeSiliconPkg: Add Alderlake Product and SiPkg.dec

2023-09-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 9:46 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH v2 10/10] AlderlakeSiliconPkg: Add Alderlake

Re: [edk2-devel] [PATCH v2 09/10] AlderlakeSiliconPkg: Add AdlPch Fru and IncludePrivate modules

2023-09-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 9:46 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH v2 09/10] AlderlakeSiliconPkg: Add AdlPch Fru

Re: [edk2-devel] [PATCH v2 07/10] AlderlakeSiliconPkg/Include: Add Protocol, Register, Other Includes

2023-09-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 9:46 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH v2 07/10] AlderlakeSiliconPkg/Include: Add

Re: [edk2-devel] [PATCH v2 08/10] AlderlakeSiliconPkg/Fru: Add AdlCpu Fru

2023-09-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 9:46 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH v2 08/10] AlderlakeSiliconPkg/Fru: Add AdlCpu

Re: [edk2-devel] [PATCH v2 06/10] AlderlakeSiliconPkg/Include: Add Library, Pins, Ppi Includes

2023-09-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 9:46 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH v2 06/10] AlderlakeSiliconPkg/Include: Add

Re: [edk2-devel] [PATCH v2 04/10] AlderlakeSiliconPkg/IpBlock: Add Pmc, Spi components

2023-09-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 9:46 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH v2 04/10] AlderlakeSiliconPkg/IpBlock: Add Pmc,

Re: [edk2-devel] [PATCH v2 01/10] AlderlakeSiliconPkg/IpBlock: Add CpuPcieRp, Espi, Gpio components

2023-09-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 9:46 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH v2 01/10] AlderlakeSiliconPkg/IpBlock: Add

Re: [edk2-devel] [PATCH v2 03/10] AlderlakeSiliconPkg/IpBlock: Add P2sb, PchDmi components

2023-09-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 9:46 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH v2 03/10] AlderlakeSiliconPkg/IpBlock: Add

Re: [edk2-devel] [PATCH v2 02/10] AlderlakeSiliconPkg/IpBlock: Add Graphics, HostBridge, PcieRp components

2023-09-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 9:46 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH v2 02/10] AlderlakeSiliconPkg/IpBlock: Add

[edk2-devel] [PATCH v2 10/10] AlderlakeSiliconPkg: Add Alderlake Product and SiPkg.dec

2023-09-14 Thread Saloni Kasbekar
Adds the following modules: - Product/Alderlake/Include - Product/Alderlake/Library - Product/Alderlake DSCs - SiPkg.dec Cc: Sai Chaganty Cc: Nate DeSimone Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar --- .../Product/Alderlake/Include/Ppi/SiPolicy.h | 55 ++

[edk2-devel] [PATCH v2 09/10] AlderlakeSiliconPkg: Add AdlPch Fru and IncludePrivate modules

2023-09-14 Thread Saloni Kasbekar
Adds the following modules: - AdlPch/Include - AdlPch/IncludePrivate - AdlPch/Library - AdlPch DSCs - IncludePrivate Cc: Sai Chaganty Cc: Nate DeSimone Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar --- .../Fru/AdlPch/CommonLib.dsc | 29 ++

[edk2-devel] [PATCH v2 08/10] AlderlakeSiliconPkg/Fru: Add AdlCpu Fru

2023-09-14 Thread Saloni Kasbekar
Adds the following modules: - AdlCpu/CpuPcieRp - AdlCpu/Include - AdlCpu/IncludePrivate - AdlCpu/LibraryPrivate - AdlCpu/PeiReportCpuHob - AdlCpu DSCs Cc: Sai Chaganty Cc: Nate DeSimone Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar --- .../Fru/AdlCpu/CommonLib.dsc

[edk2-devel] [PATCH v2 07/10] AlderlakeSiliconPkg/Include: Add Protocol, Register, Other Includes

2023-09-14 Thread Saloni Kasbekar
Adds the following Includes: - Include/ - Include/Protocol - Include/Register Cc: Sai Chaganty Cc: Nate DeSimone Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar --- .../AlderlakeSiliconPkg/Include/ConfigBlock.h | 53 +++ .../AlderlakeSiliconPkg/Include/CpuPcieHob.h | 48 +++

[edk2-devel] [PATCH v2 06/10] AlderlakeSiliconPkg/Include: Add Library, Pins, Ppi Includes

2023-09-14 Thread Saloni Kasbekar
Adds the following Includes: - Include/Library - Include/Pins - Include/Ppi Cc: Sai Chaganty Cc: Nate DeSimone Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar --- .../Include/Library/ConfigBlockLib.h | 64 +++ .../Include/Library/EspiLib.h | 34 ++

[edk2-devel] [PATCH v2 03/10] AlderlakeSiliconPkg/IpBlock: Add P2sb, PchDmi components

2023-09-14 Thread Saloni Kasbekar
Adds the following modules: - IpBlock/P2sb/IncludePrivate - IpBlock/P2sb/Library - IpBlock/P2sb/LibraryPrivate - IpBlock/PchDmi/IncludePrivate - IpBlock/PchDmi/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar ---

[edk2-devel] [PATCH v2 04/10] AlderlakeSiliconPkg/IpBlock: Add Pmc, Spi components

2023-09-14 Thread Saloni Kasbekar
Adds the following modules: - IpBlock/Pmc/IncludePrivate - IpBlock/Pmc/Library - IpBlock/Pmc/LibraryPrivate - IpBlock/Spi/IncludePrivate - IpBlock/Spi/Library - IpBlock/Spi/LibraryPrivate - IpBlock/Spi/Smm Cc: Sai Chaganty Cc: Nate DeSimone Cc: Rosen Chuang Signed-off-by: Saloni

[edk2-devel] [PATCH v2 02/10] AlderlakeSiliconPkg/IpBlock: Add Graphics, HostBridge, PcieRp components

2023-09-14 Thread Saloni Kasbekar
Adds the following modules: - IpBlock/Graphics/Include - IpBlock/Graphics/IncludePrivate - IpBlock/Graphics/Library - IpBlock/Graphics/LibraryPrivate - IpBlock/HostBridge/IncludePrivate - IpBlock/PcieRp/Library Cc: Sai Chaganty Cc: Nate DeSimone Cc: Rosen Chuang Signed-off-by:

Re: [edk2-devel] [PATCH 4/4] Maintainers.txt: Add maintainers

2023-09-14 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang -Original Message- From: Chaganty, Rangasai V Sent: Thursday, September 14, 2023 6:47 AM To: Kasbekar, Saloni ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chuang, Rosen Subject: RE: [PATCH 4/4] Maintainers.txt: Add maintainers Reviewed-by: Sai

Re: [edk2-devel] [PATCH 3/4] Readme.md: Add AlderlakeOpenBoardPkg

2023-09-14 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang -Original Message- From: Chaganty, Rangasai V Sent: Thursday, September 14, 2023 7:42 AM To: Kasbekar, Saloni ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chuang, Rosen Subject: RE: [PATCH 3/4] Readme.md: Add AlderlakeOpenBoardPkg Reviewed-by: Sai

Re: [edk2-devel] [PATCH 2/4] Enable build for AlderlakeOpenBoardPkg

2023-09-14 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang -Original Message- From: Chaganty, Rangasai V Sent: Thursday, September 14, 2023 7:38 AM To: Kasbekar, Saloni ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chuang, Rosen Subject: RE: [PATCH 2/4] Enable build for AlderlakeOpenBoardPkg Reviewed-by: Sai

Re: [edk2-devel] [PATCH 1/4] AlderlakeOpenBoardPkg/AlderlakePRvp: Add DSC and build files

2023-09-14 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 6:05 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH 1/4] AlderlakeOpenBoardPkg/AlderlakePRvp: Add

Re: [edk2-devel] [PATCH 10/10] AlderlakeSiliconPkg: Add Alderlake Product and SiPkg.dec

2023-09-14 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 6:14 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH 10/10] AlderlakeSiliconPkg: Add Alderlake

Re: [edk2-devel] [PATCH 09/10] AlderlakeSiliconPkg: Add AdlPch Fru and IncludePrivate modules

2023-09-14 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang -Original Message- From: Chaganty, Rangasai V Sent: Friday, September 15, 2023 6:20 AM To: Kasbekar, Saloni ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chuang, Rosen Subject: RE: [PATCH 09/10] AlderlakeSiliconPkg: Add AdlPch Fru and IncludePrivate

Re: [edk2-devel] [PATCH 08/10] AlderlakeSiliconPkg/Fru: Add AdlCpu Fru

2023-09-14 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 6:14 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH 08/10] AlderlakeSiliconPkg/Fru: Add AdlCpu Fru

Re: [edk2-devel] [PATCH 07/10] AlderlakeSiliconPkg/Include: Add Protocol, Register, Other Includes

2023-09-14 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang -Original Message- From: Chaganty, Rangasai V Sent: Friday, September 15, 2023 6:02 AM To: Kasbekar, Saloni ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chuang, Rosen Subject: RE: [PATCH 07/10] AlderlakeSiliconPkg/Include: Add Protocol, Register,

Re: [edk2-devel] [PATCH 06/10] AlderlakeSiliconPkg/Include: Add Library, Pins, Ppi Includes

2023-09-14 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 6:14 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH 06/10] AlderlakeSiliconPkg/Include: Add

Re: [edk2-devel] [PATCH 04/10] AlderlakeSiliconPkg/IpBlock: Add Pmc, Spi components

2023-09-14 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang -Original Message- From: Chaganty, Rangasai V Sent: Friday, September 15, 2023 5:40 AM To: Kasbekar, Saloni ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chuang, Rosen Subject: RE: [PATCH 04/10] AlderlakeSiliconPkg/IpBlock: Add Pmc, Spi components

Re: [edk2-devel] [PATCH 03/10] AlderlakeSiliconPkg/IpBlock: Add P2sb, PchDmi components

2023-09-14 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang -Original Message- From: Chaganty, Rangasai V Sent: Friday, September 15, 2023 1:41 AM To: Kasbekar, Saloni ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chuang, Rosen Subject: RE: [PATCH 03/10] AlderlakeSiliconPkg/IpBlock: Add P2sb, PchDmi components

Re: [edk2-devel] [PATCH 02/10] AlderlakeSiliconPkg/IpBlock: Add Graphics, HostBridge, PcieRp components

2023-09-14 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang -Original Message- From: Chaganty, Rangasai V Sent: Friday, September 15, 2023 1:24 AM To: Kasbekar, Saloni ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chuang, Rosen Subject: RE: [PATCH 02/10] AlderlakeSiliconPkg/IpBlock: Add Graphics, HostBridge,

Re: [edk2-devel] [PATCH 01/10] AlderlakeSiliconPkg/IpBlock: Add CpuPcieRp, Espi, Gpio components

2023-09-14 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang -Original Message- From: Chaganty, Rangasai V Sent: Friday, September 15, 2023 12:02 AM To: Kasbekar, Saloni ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chuang, Rosen Subject: RE: [PATCH 01/10] AlderlakeSiliconPkg/IpBlock: Add CpuPcieRp, Espi, Gpio

[edk2-devel] [PATCH v2 0/2] StandaloneMmPkg: Make StandaloneMmCpu platform

2023-09-14 Thread Tuan Phan
This series makes StandaloneMmCpu platform independent so that other platforms besides ARM/AARCH64 can use it without creating new driver. There are two parts in this series: 1. Remove ARM/AARCH64 code from StandaloneMmCpu. 2. Update ARM/AARCH64 entry point library code. Tuan Phan (2):

[edk2-devel] [PATCH v2 2/2] StandaloneMmPkg: Arm: Update to use the new StandaloneMmCpu driver

2023-09-14 Thread Tuan Phan
Update entry point library for Arm to use the new platform independent StandaloneMmCpu driver. Signed-off-by: Tuan Phan --- .../Library/Arm/StandaloneMmCoreEntryPoint.h | 17 ++-- .../Arm/CreateHobList.c | 43 ++- .../Arm/StandaloneMmCoreEntryPoint.c

[edk2-devel] [PATCH v2 1/2] StandaloneMmPkg: Make StandaloneMmCpu driver platform independent

2023-09-14 Thread Tuan Phan
StandaloneMmCpu now can supports more platforms like RISC-V besides ARM/AARCH64. Signed-off-by: Tuan Phan --- .../Drivers/StandaloneMmCpu/EventHandle.c | 25 +++ .../Drivers/StandaloneMmCpu/StandaloneMmCpu.c | 42 +-- .../StandaloneMmCpu/StandaloneMmCpu.inf |

Re: [edk2-devel] [PATCH 10/10] AlderlakeSiliconPkg: Add Alderlake Product and SiPkg.dec

2023-09-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Wednesday, September 13, 2023 3:14 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH 10/10] AlderlakeSiliconPkg: Add Alderlake

Re: [edk2-devel] [PATCH 09/10] AlderlakeSiliconPkg: Add AdlPch Fru and IncludePrivate modules

2023-09-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Wednesday, September 13, 2023 3:14 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH 09/10] AlderlakeSiliconPkg: Add AdlPch Fru and

Re: [edk2-devel] [PATCH 07/10] AlderlakeSiliconPkg/Include: Add Protocol, Register, Other Includes

2023-09-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Wednesday, September 13, 2023 3:14 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH 07/10] AlderlakeSiliconPkg/Include: Add

Re: [edk2-devel] [PATCH 06/10] AlderlakeSiliconPkg/Include: Add Library, Pins, Ppi Includes

2023-09-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Wednesday, September 13, 2023 3:14 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH 06/10] AlderlakeSiliconPkg/Include: Add

Re: [edk2-devel] [PATCH 04/10] AlderlakeSiliconPkg/IpBlock: Add Pmc, Spi components

2023-09-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Wednesday, September 13, 2023 3:14 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH 04/10] AlderlakeSiliconPkg/IpBlock: Add Pmc,

Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version

2023-09-14 Thread Michael D Kinney
Forcing to 0 does not sound right. You did not answer my question about the property of the global variables. Without knowing the format of the information in the global variables you cannot safely use them. If they are in BCD then no need to check for out of range. If they are hex values,

Re: [edk2-devel] [PATCH 03/10] AlderlakeSiliconPkg/IpBlock: Add P2sb, PchDmi components

2023-09-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Wednesday, September 13, 2023 3:14 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH 03/10] AlderlakeSiliconPkg/IpBlock: Add P2sb,

Re: [edk2-devel] [PATCH 02/10] AlderlakeSiliconPkg/IpBlock: Add Graphics, HostBridge, PcieRp components

2023-09-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Wednesday, September 13, 2023 3:14 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH 02/10] AlderlakeSiliconPkg/IpBlock: Add

Re: [edk2-devel] [PATCH 01/10] AlderlakeSiliconPkg/IpBlock: Add CpuPcieRp, Espi, Gpio components

2023-09-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Wednesday, September 13, 2023 3:14 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH 01/10] AlderlakeSiliconPkg/IpBlock: Add

[edk2-devel] Problems mocking UEFI Protocol in gMock

2023-09-14 Thread CrossedCarpet
Greetings, I have successfully mocked standalone functions employing the FunctionMockLib macros. Nonetheless, I have been stuck in making progress regarding mocking a protocol. The problem is that the function pointers of the protocol mock structure are not being properly initialized. Below I

Re: [edk2-devel] [PATCH 0/3] updates for "OvmfPkg/RiscVVirt/README.md"

2023-09-14 Thread Sunil V L
On Thu, Sep 14, 2023 at 12:55:02PM +0200, Laszlo Ersek wrote: > On 9/13/23 12:55, Laszlo Ersek wrote: > > The shortlog below provides a good summary :) > > > > Cc: Andrei Warkentin > > Cc: Andrew Jones > > Cc: Ard Biesheuvel > > Cc: Gerd Hoffmann > > Cc: Jiewen Yao > > Cc: Jordan Justen > >

Re: [edk2-devel] [PATCH 0/3] updates for "OvmfPkg/RiscVVirt/README.md"

2023-09-14 Thread Laszlo Ersek
On 9/13/23 12:55, Laszlo Ersek wrote: > The shortlog below provides a good summary :) > > Cc: Andrei Warkentin > Cc: Andrew Jones > Cc: Ard Biesheuvel > Cc: Gerd Hoffmann > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Sunil V L > > Thanks > Laszlo > > Laszlo Ersek (3): >

Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version

2023-09-14 Thread Lien, HoraceX
Hi Mike, https://github.com/tianocore/edk2/pull/4771 I have changed code following rule: It is only accept range 0-9 for Major and Minor version to fill in SmbiosBcdRevision, if one of Major or Minor is greater than 9 then fill in 00h. Please help to review this, thanks :) Thanks, Horace Lien

Re: [edk2-devel] [PATCH v2 5/7] DynamicTablesPkg.ci.yaml: Add debug macro exception

2023-09-14 Thread Sami Mujawar
Hi Michael, Apologies, I initially misunderstood what this patch was trying to do. As I understand this is an exception for one of the special cases to be handled differently by the plugin. Acked-by: Sami Mujawar Regards, Sami Mujawar On 14/09/2023, 09:42, "devel@edk2.groups.io

Re: [edk2-devel] [PATCH 0/3] updates for "OvmfPkg/RiscVVirt/README.md"

2023-09-14 Thread Laszlo Ersek
On 9/14/23 11:05, Sunil V L wrote: > Hi Laszlo, > > For the series with anticipated change for Drew's comment. > > Reviewed-by: Sunil V L > > Do you plan to queue this up with that change? Feel free to let me know > if you want me to take care. Yes I'll try to submit the MR with the "push"

Re: [edk2-devel] [PATCH 0/3] updates for "OvmfPkg/RiscVVirt/README.md"

2023-09-14 Thread Sunil V L
Hi Laszlo, For the series with anticipated change for Drew's comment. Reviewed-by: Sunil V L Do you plan to queue this up with that change? Feel free to let me know if you want me to take care. Thanks, Sunil On Wed, Sep 13, 2023 at 12:55:48PM +0200, Laszlo Ersek wrote: > The shortlog below

Re: [edk2-devel] [PATCH v2 5/7] DynamicTablesPkg.ci.yaml: Add debug macro exception

2023-09-14 Thread Sami Mujawar
Hi Michael, I would prefer to have the debug macro checks enabled in DynamicTablesPkg to catch any issues. Please do not disable this feature for this package. Regards, Sami Mujawar On 13/09/2023, 18:08, "mikub...@linux.microsoft.com "

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG

2023-09-14 Thread Laszlo Ersek
On 9/13/23 18:28, Andrew Jones wrote: > On Wed, Sep 13, 2023 at 12:55:49PM +0200, Laszlo Ersek wrote: >> Riscv64 KVM services SBI calls internally, so OpenSBI is not used in such >> setups. Restrict the "-bios" flag accordingly. Thanks: Andrei, Drew. >> >> Cc: Andrei Warkentin >> Cc: Andrew Jones

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG

2023-09-14 Thread Andrew Jones
On Thu, Sep 14, 2023 at 09:23:12AM +0200, Andrew Jones wrote: > On Wed, Sep 13, 2023 at 12:55:49PM +0200, Laszlo Ersek wrote: > > Riscv64 KVM services SBI calls internally, so OpenSBI is not used in such > > setups. Restrict the "-bios" flag accordingly. Thanks: Andrei, Drew. > > > > Cc: Andrei

Re: [edk2-devel] [PATCH 3/3] OvmfPkg/RiscVVirt/README: document direct kernel boot

2023-09-14 Thread Andrew Jones
On Wed, Sep 13, 2023 at 12:55:51PM +0200, Laszlo Ersek wrote: > Direct (fw_cfg) kernel boot works on the RiscVVirt firmware platform too; > I've tested it after extracting the kernel, initrd, and kernel command > line from "openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw". Document this > type of

Re: [edk2-devel] [PATCH 2/3] OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property

2023-09-14 Thread Andrew Jones
On Wed, Sep 13, 2023 at 12:55:50PM +0200, Laszlo Ersek wrote: > "acpi=off" is arguably unusual with UEFI guest OSes; add a note to explain > it. Original explanation by Drew Jones. > > Cc: Andrei Warkentin > Cc: Andrew Jones > Cc: Ard Biesheuvel > Cc: Gerd Hoffmann > Cc: Jiewen Yao > Cc:

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG

2023-09-14 Thread Andrew Jones
On Wed, Sep 13, 2023 at 12:55:49PM +0200, Laszlo Ersek wrote: > Riscv64 KVM services SBI calls internally, so OpenSBI is not used in such > setups. Restrict the "-bios" flag accordingly. Thanks: Andrei, Drew. > > Cc: Andrei Warkentin > Cc: Andrew Jones > Cc: Ard Biesheuvel > Cc: Gerd Hoffmann

Re: [edk2-devel] [PATCH v2 10/11] DynamicTablesPkg: Add ETE device to CPU node in AML

2023-09-14 Thread Sami Mujawar
Hi Jeshua, Thank you for the feedback. On 13/09/2023, 16:06, "Jeshua Smith" mailto:jesh...@nvidia.com>> wrote: Not sure it's worth creating a new patchset for, but the "GetEArmObjEtInfo (OPTIONAL)" comment should probably not have the "Get" prefix (ie. " EArmObjEtInfo (OPTIONAL)"). [SAMI] I

Re: [edk2-devel] [PATCH] MdeModulePkg: Support customized FV Migration Information

2023-09-14 Thread Wang Fan
Hi Mike, Liming and Guomin Could you help review this change? Best Regards Fan -Original Message- From: devel@edk2.groups.io On Behalf Of Wang Fan Sent: Thursday, September 7, 2023 2:55 PM To: devel@edk2.groups.io Cc: Wang, Fan ; Kinney, Michael D ; Gao, Liming ; Jiang, Guomin ; Bi,