Re: [edk2-devel] [PATCH v2] UefiCpuPkg: RISC-V: MMU: Introduce a PCD for SATP mode

On Thu, Oct 12, 2023 at 07:29:59PM +0100, Pedro Falcato wrote: > On Thu, Oct 12, 2023 at 1:12 PM Sunil V L wrote: > > > > Hi Ray, > > > > On Wed, Oct 04, 2023 at 11:34:26AM -0700, Tuan Phan wrote: > > > Introduce a PCD to control the maximum SATP mode that MMU allowed > > > to use. This PCD helps

Re: [edk2-devel] [edk2-platforms PATCH 12/19] AmpereAltraPkg/Ac01PcieLib: fix compilation error

HI Lazslo, I was not reviewing carefully. The MmioRead32 is redundant code. Can you help me get rid of that code? Thanks, Nhi On 10/13/2023 9:20 AM, Nhi Pham wrote: Thanks for fixing it. Reviewed-by: Nhi Pham Regards, Nhi On 10/12/2023 4:09 PM, Laszlo Ersek wrote: Commit 380b4b40c60d

Re: [edk2-devel] [edk2-platforms PATCH 13/19] JadePkg/PCF85063RealTimeClockLib: hide LibRtcVirtualNotifyEvent

It looks good to me. Reviewed-by: Nhi Pham Thanks, Nhi On 10/12/2023 4:09 PM, Laszlo Ersek wrote: The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib

Re: [edk2-devel] [edk2-platforms PATCH 12/19] AmpereAltraPkg/Ac01PcieLib: fix compilation error

Thanks for fixing it. Reviewed-by: Nhi Pham Regards, Nhi On 10/12/2023 4:09 PM, Laszlo Ersek wrote: Commit 380b4b40c60d ("AmpereAltraPkg: Update Ampere specific platform PCIe core", 2023-03-29) removed the DEBUG macro call from Ac01PcieCoreUpdateLink() that was the only reader of "Val".

Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBus: Get device/config descriptor after port reset

Hello Hao/Ray/Jian/Gao, Any feedback on this patch? Thanks Ashish From: Rick Tseng Sent: Sunday, September 24, 2023 7:54 PM To: devel@edk2.groups.io Cc: hao.a...@intel.com ; ray...@intel.com ; jian.j.w...@intel.com ; gaolim...@byosoft.com.cn ; Ashish Singhal

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: RISC-V: MMU: Introduce a PCD for SATP mode

On Thu, Oct 12, 2023 at 1:12 PM Sunil V L wrote: > > Hi Ray, > > On Wed, Oct 04, 2023 at 11:34:26AM -0700, Tuan Phan wrote: > > Introduce a PCD to control the maximum SATP mode that MMU allowed > > to use. This PCD helps RISC-V platform set bare or minimum SATP mode > > during bring up to debug

[edk2-devel] [PATCH] Basetools: Include PCD declarations from Library Instance

The patch "[PATCH v3 1/2] StandaloneMmPkg: Make StandaloneMmCpu driver architecture independent" (https://edk2.groups.io/g/devel/message/109178) removed ArmPkg/ArmPkg.dec from the Packages section in the INF file: StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf This change was done as

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Optimize BmExpandPartitionDevicePath

On 10/11/23 19:36, Aaron Young wrote: > >  Thanks for the comments, Laszlo. > >  I could look into optimizing SetBootOrderFromQemu()->Match() by using >  EfiBootManagerGetNextLoadOptionDevicePath() instead of > EfiBootManagerGetLoadOptionBuffer(). >  Makes sense to me and at first glance seems

Re: [edk2-devel] [edk2-platforms PATCH 16/19] Armada7k8k/RealTimeClockLib: hide LibRtcVirtualNotifyEvent

Hi, czw., 12 paź 2023 o 11:10 Laszlo Ersek napisał(a): > > The RealTimeClockLib class header in edk2 mistakenly declares a function > called LibRtcVirtualNotifyEvent(). No component ever calls this function > crossing module boundaries; all RealTimeClockLib instances in edk2 and > edk2-platforms

Re: [edk2-devel] [PATCH 1/5] PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename LibRtcVirtualNotifyEvent

Hi Laszlo, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Tested by booting a Linux guest using Kvmtool guest firmware (ArmVirtPkg/ArmVirtKvmTool.dsc) for AArch64. Tested-by: Sami Mujawar Regards, Sami Mujawar On 12/10/2023, 10:25,

Re: [edk2-devel] [PATCH 2/5] ArmPlatformPkg/PL031RealTimeClockLib: hide LibRtcVirtualNotifyEvent

Hi Laszlo, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 12/10/2023, 10:27, "devel@edk2.groups.io on behalf of Laszlo Ersek via groups.io" mailto:devel@edk2.groups.io> on behalf of

Re: [edk2-devel] [edk2-platforms PATCH 14/19] LoongArchQemuPkg/LsRealTimeClockLib: hide LibRtcVirtualNotifyEvent

Hi Laszlo, This patch is look good to me. Thanks. Acked-by: Chao Li Thanks, Chao 在 2023/10/12 20:14, xianglai 写道: Hi Laszlo Ersek: The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing

Re: [edk2-devel] [edk2-platforms PATCH 14/19] LoongArchQemuPkg/LsRealTimeClockLib: hide LibRtcVirtualNotifyEvent

Hi Laszlo Ersek: The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register)

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: RISC-V: MMU: Introduce a PCD for SATP mode

Hi Ray, On Wed, Oct 04, 2023 at 11:34:26AM -0700, Tuan Phan wrote: > Introduce a PCD to control the maximum SATP mode that MMU allowed > to use. This PCD helps RISC-V platform set bare or minimum SATP mode > during bring up to debug memory map issue. > Could you help with review of this?

[edk2-devel] [PATCH 5/5] EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib class

The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their

[edk2-devel] [PATCH 4/5] EmbeddedPkg/VirtualRealTimeClockLib: drop LibRtcVirtualNotifyEvent

The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their

[edk2-devel] [PATCH 3/5] EmbeddedPkg/TemplateRealTimeClockLib: drop LibRtcVirtualNotifyEvent

The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their

[edk2-devel] [PATCH 2/5] ArmPlatformPkg/PL031RealTimeClockLib: hide LibRtcVirtualNotifyEvent

The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their

[edk2-devel] [PATCH 0/5] EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib class

https://bugzilla.tianocore.org/show_bug.cgi?id=4564 The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function across module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms

[edk2-devel] [PATCH 1/5] PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename LibRtcVirtualNotifyEvent

PcatRealTimeClockRuntimeDxe seems to have copied the interface name LibRtcVirtualNotifyEvent() from EmbeddedPkg's RealTimeClockLib class. That's not right, for two reasons: - PcatRealTimeClockRuntimeDxe doesn't consume "EmbeddedPkg.dec" in the first place, - in EmbeddedPkg, the

[edk2-devel] [edk2-non-osi PATCH 1/1] Hisilicon: rename OemMiscLib class dependencies to HisiOemMiscLib

Edk2 commit [1] introduced the library class header to ArmPkg; commit [2] introduced the first OemMiscLib instance to ArmPkg; and commit [3] introduced (retroactively) the library class itself to ArmPkg. Alas, when all these edk2 commits were made, edk2-platforms already had a

[edk2-devel] [edk2-non-osi PATCH 0/1] Hisilicon: rename OemMiscLib class dependencies to HisiOemMiscLib

https://bugzilla.tianocore.org/show_bug.cgi?id=4564 This patch accompanies "[edk2-platforms PATCH 04/19] Hisilicon: rename OemMiscLib class to HisiOemMiscLib". Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Wenyi Xie Thanks Laszlo Laszlo Ersek (1): Hisilicon: rename OemMiscLib class

[edk2-devel] [edk2-platforms PATCH 08/19] Hisilicon: drop unused DS3231RealTimeClockLib instance

Edk2-platforms contains two DS3231RealTimeClockLib instances: - Silicon/Hisilicon/Library/DS3231RealTimeClockLib - Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib The latter is still used (by the D03 and D05 platforms), but the former has not been referenced since commit 478282ea28c7

[edk2-devel] [edk2-platforms PATCH 16/19] Armada7k8k/RealTimeClockLib: hide LibRtcVirtualNotifyEvent

The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their

[edk2-devel] [edk2-platforms PATCH 18/19] FT2000-4Pkg/RealTimeClockLib: hide LibRtcVirtualNotifyEvent

The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their

[edk2-devel] [edk2-platforms PATCH 13/19] JadePkg/PCF85063RealTimeClockLib: hide LibRtcVirtualNotifyEvent

The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their

[edk2-devel] [edk2-platforms PATCH 19/19] Omap35xxPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent

The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their

[edk2-devel] [edk2-platforms PATCH 17/19] NXP/Pcf8563RealTimeClockLib: hide LibRtcVirtualNotifyEvent

The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their

[edk2-devel] [edk2-platforms PATCH 14/19] LoongArchQemuPkg/LsRealTimeClockLib: hide LibRtcVirtualNotifyEvent

The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their

[edk2-devel] [edk2-platforms PATCH 15/19] Styx/RealTimeClockLib: hide LibRtcVirtualNotifyEvent

The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their

[edk2-devel] [edk2-platforms PATCH 12/19] AmpereAltraPkg/Ac01PcieLib: fix compilation error

Commit 380b4b40c60d ("AmpereAltraPkg: Update Ampere specific platform PCIe core", 2023-03-29) removed the DEBUG macro call from Ac01PcieCoreUpdateLink() that was the only reader of "Val". Since then, Val has only been set, but never read. This triggers "-Werror=unused-but-set-variable". Found

[edk2-devel] [edk2-platforms PATCH 10/19] Hisilicon/DS3231RealTimeClockLib: drop LibRtcVirtualNotifyEvent

The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their

[edk2-devel] [edk2-platforms PATCH 11/19] Hisilicon/RX8900RealTimeClockLib: drop LibRtcVirtualNotifyEvent

The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their

[edk2-devel] [edk2-platforms PATCH 03/19] Hisilicon.dsc.inc: resolve VariableFlashInfoLib

Since edk2 commit 8db39c60cdf3 ("MdeModulePkg/FaultTolerantWrite: Consume Variable Flash Info", 2022-05-19), the Hisilicon platforms (D03, D05, D06, HiKey, HiKey960) must have been broken; they don't resolve the new VariableFlashInfoLib class to the (only) BaseVariableFlashInfoLib instance. Do

[edk2-devel] [edk2-platforms PATCH 09/19] Hisilicon: drop unused VirtualRealTimeClockLib instance

VirtualRealTimeClockLib is not used in either edk2-platforms or edk2-non-osi, and there never has been a reference to it -- even the initial code drop that added it to edk2-platforms [*] contained zero references to it. Remove it. [*] commit 600081b52deb ("Platform,Silicon: Import Hisilicon

[edk2-devel] [edk2-platforms PATCH 04/19] Hisilicon: rename OemMiscLib class to HisiOemMiscLib

Edk2 commit [1] introduced the library class header to ArmPkg; commit [2] introduced the first OemMiscLib instance to ArmPkg; and commit [3] introduced (retroactively) the library class itself to ArmPkg. Alas, when all these edk2 commits were made, edk2-platforms already had a

[edk2-devel] [edk2-platforms PATCH 02/19] Hisilicon/FlashFvbDxe: fix PcdNorFlashCheckBlockLocked token space GUID

Edk2 commit cc650a0378f8 ("ArmPlatformPkg: Retire NorFlashDxe driver", 2022-11-06) removed PcdNorFlashCheckBlockLocked from "gArmPlatformTokenSpaceGuid"; edk2-platforms commit d7b286ae5f53 ("Platform/ARM: clone NorFlashDxe from ArmPlatformPkg", 2022-10-19) provided it in the *different* namespace

[edk2-devel] [edk2-platforms PATCH 06/19] Hisilicon/Hi1620AcpiTables: fix up ASL

Recent "iasl" does not accept "Hi1620Iort.asl" any longer: - various "Interrupt" fields are now called "GSIV", - "DeviceID mapping index" has been renamed to "Device ID Mapping Index". Update the field names in "Hi1620Iort.asl"; it's necessary for building the Hisilicon platform DSCs. Cc: Ard

[edk2-devel] [edk2-platforms PATCH 05/19] Hisilicon: add missing include file to Pptt components

Some more random bitrot in Hisilicon; must be fixed for building the Hisilicon DSCs. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Wenyi Xie Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek --- Silicon/Hisilicon/Hi1616/Pptt/Pptt.h | 1 +

[edk2-devel] [edk2-platforms PATCH 07/19] Hisilicon/ProcessorSubClassDxe: drop conflicting PROCESSOR_STATUS_DATA type

Edk2 commit 4e1f316cec3f ("MdePkg: Update IndustryStandard/SmBios.h with processor status data", 2021-02-08) upstreamed the PROCESSOR_STATUS_DATA type, so now the identical typedef in "ProcessorSubClass.h" is superfluous, and conflicts, breaking the Hisilicon DSCs' compilation. Remove it. Cc: Ard

[edk2-devel] [edk2-platforms PATCH 00/19] let LibRtcVirtualNotifyEvent() be dropped

https://bugzilla.tianocore.org/show_bug.cgi?id=4564 The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function across module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms

[edk2-devel] [edk2-platforms PATCH 01/19] Hisilicon: enable NOOPT builds

There's no reason for not supporting NOOPT in the Hisilicon platform DSCs, and there is a reason for supporting them: build-only testing. Add NOOPT wherever it's missing, and stick to a consistent order wherever NOOPT already exists. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Wenyi Xie Ref:

[edk2-devel] EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib class

https://bugzilla.tianocore.org/show_bug.cgi?id=4564 I'm only posting this message as a common root for three upcoming patch series that belong together (one series for each of edk2-platforms, edk2-non-osi, and edk2). Please see the cover letter in each of those series. Thanks Laszlo

Re: [edk2-devel] [Patch V3] UefiCpuPkg/CpuDxe: Eliminate the unused variable.

Reviewed-by: Ray Ni Thanks, Ray From: Xie, Yuanhao Sent: Thursday, October 12, 2023 10:22 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Xie, Yuanhao ; Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann Subject: [Patch V3] UefiCpuPkg/CpuDxe: Eliminate the unused