[edk2-devel] Error during OvmfPkg build on Windows

2023-10-13 Thread antonio parata
Hello, I'm trying to build the OvmfPkg package on Windows by following the instruction at https://github.com/tianocore/tianocore.github.io/wiki/How-to-Build-With-Stuart#i-want-to-build-ovmfpkg-and-automatically-run-with-my-firmware-after-build . When I run the command: stuart_build -c

Re: 回复: 回复: [edk2-devel] [PATCH v4 00/14] Add ImagePropertiesRecordLib and Fix MAT Bugs

2023-10-13 Thread Taylor Beebe
Thank you Liming :) Patches 2, 3, 4, 5, and 11 still need reviews -- 4 of them are just adding the new library to the package DSC files. This bug has cost me a significant amount of hours to debug, fix, and unit-test. I have been specific in the cases which cause issues and demonstrated

Re: [edk2-devel] [edk2-platforms PATCH 00/19] let LibRtcVirtualNotifyEvent() be dropped

2023-10-13 Thread Laszlo Ersek
On 10/13/23 12:12, Ard Biesheuvel wrote: > On Thu, 12 Oct 2023 at 11:10, Laszlo Ersek wrote: >> >> https://bugzilla.tianocore.org/show_bug.cgi?id=4564 >> >> The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly >> declares a function called LibRtcVirtualNotifyEvent(). No component

Re: [edk2-devel] [edk2-platforms PATCH 12/19] AmpereAltraPkg/Ac01PcieLib: fix compilation error

2023-10-13 Thread Laszlo Ersek
On 10/13/23 05:24, Nhi Pham wrote: > HI Lazslo, > > I was not reviewing carefully. The MmioRead32 is redundant code. Can you > help me get rid of that code? Sure, if you don't need the read access to the LINK_CONTROL_LINK_STATUS_REG register, I can drop that too; I just didn't want to do it

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/BaseXApicX2ApicLib: fix CPUID_V2_EXTENDED_TOPOLOGY detection

2023-10-13 Thread Laszlo Ersek
On 10/11/23 12:06, Gerd Hoffmann wrote: > Checking the max cpuid leaf is not enough to figure whenever > CPUID_V2_EXTENDED_TOPOLOGY is supported. Quoting a comment for > CPUID_EXTENDED_TOPOLOGY in GetProcessorLocationByApicId(): > > // If CPUID.(EAX=0BH, ECX=0H):EBX returns zero and maximum

Re: [edk2-devel] [PATCH edk2-platforms WIP 0/5] Provide EHCI or XHCI USB controller

2023-10-13 Thread Marcin Juszkiewicz
W dniu 13.10.2023 o 15:31, Marcin Juszkiewicz via groups.io pisze: W dniu 13.10.2023 o 15:24, Gerd Hoffmann pisze: So two solutions came to my mind: 1. rewrite DSDT generation into C You might want have a look at DynamicTablesPkg/ for that Wasn't is involving using ConfigurationManager?

[edk2-devel] [PATCH edk2-platforms v5 5/7] Sophgo/SG2042_EVB_Board: Add Sophgo SG2042 platform.

2023-10-13 Thread caiyuqing_hz
From: caiyuqing379 Add infrastructure files to build edk2-platforms for Sophgo SG2042 platform. It follows PEI less design. Signed-off-by: caiyuqing379 Co-authored-by: USER0FISH Cc: dahogn Cc: meng-cz Cc: yli147 Cc: ChaiEvan Cc: Leif Lindholm Cc: Michael D Kinney Acked-by: Sunil V L

[edk2-devel] [PATCH edk2-platforms v5 1/7] Sophgo/SG2042Pkg: Add SmbiosPlatformDxe module.

2023-10-13 Thread caiyuqing_hz
From: caiyuqing379 This driver installs SMBIOS information for SG2042. Install hardware information by creating an SMBIOS table which includes BIOS version, system manufacturer, product name, processor, memory, slots, storage, and other. Signed-off-by: caiyuqing379 Co-authored-by: USER0FISH

[edk2-devel] [PATCH edk2-platforms v5 3/7] Sophgo/SG2042Pkg: Add base MMC driver.

2023-10-13 Thread caiyuqing_hz
From: caiyuqing379 This driver implements the MMC Host protocol, which is used by SD interface driver that the Sophgo SG2042 EVB supports. Add this driver in Sophgo/SG2042Pkg leveraging the one form Embedded Package. Signed-off-by: caiyuqing379 Co-authored-by: USER0FISH Cc: dahogn Cc:

[edk2-devel] [PATCH edk2-platforms v5 6/7] Sophgo/SG2042Pkg: Add SG2042Pkg.

2023-10-13 Thread caiyuqing_hz
From: caiyuqing379 Add SG2042Pkg for Sophgo SG2042 platform. Provides PCD tokens. Signed-off-by: caiyuqing379 Co-authored-by: USER0FISH Cc: dahogn Cc: meng-cz Cc: yli147 Cc: ChaiEvan Cc: Sunil V L Cc: Leif Lindholm Cc: Michael D Kinney --- Silicon/Sophgo/SG2042Pkg/SG2042Pkg.dec |

[edk2-devel] [PATCH edk2-platforms v5 4/7] Sophgo/SG2042Pkg: Add SEC module.

2023-10-13 Thread caiyuqing_hz
From: caiyuqing379 This module supports Sophgo SG2042 EVB platform. It uses the PEI less design. Add this module in SG2042Pkg leveraging the one from OvmfPkg/RiscVVirt. Add only lowest memory node in SEC module. Currently, RISC-V with a multi-range memory layout hits relocation overflow

Re: [edk2-devel] failure in build

2023-10-13 Thread Matthew Gillman via groups.io
Hi again I managed to fix it by updating my .dsc file. Thanks Matthew From: Matthew Gillman Sent: 12 October 2023 16:08 To: devel@edk2.groups.io Subject: failure in build Hi I just experienced a build failure. Please see below: Build environment:

[edk2-devel] [PATCH edk2-platforms v5 2/7] Sophgo/SG2042Pkg: Add Sophgo SDHCI driver.

2023-10-13 Thread caiyuqing_hz
From: caiyuqing379 This driver implements Sophgo SDHCI controller, which provides the necessary interfaces for handling communication and data transfer with SD cards. Signed-off-by: caiyuqing379 Co-authored-by: USER0FISH Cc: dahogn Cc: meng-cz Cc: yli147 Cc: ChaiEvan Cc: Leif Lindholm

[edk2-devel] failure in build

2023-10-13 Thread Matthew Gillman via groups.io
Hi I just experienced a build failure. Please see below: Build environment: Linux-6.2.0-34-generic-x86_64-with-glibc2.35 Build start time: 16:03:02, Oct.12 2023 WORKSPACE= /home/matt/repos/bios_stuff/edk2 EDK_TOOLS_PATH = /home/matt/repos/bios_stuff/edk2/BaseTools CONF_PATH

[edk2-devel] [PATCH edk2-platforms v5 0/7] EDK2 on RISC-V Sophgo SG2042 platform

2023-10-13 Thread caiyuqing_hz
From: caiyuqing379 Description: Deploy EDK2 to run on 64-core CPU under RISC-V architecture, and successfully boot to OS. Implementation can be seen at: https://github.com/AII-SDU/edk2-platforms/tree/devel-Sophgo/SG2042Pkg/Platform/Sophgo. Current status: 1) Adopted the scheme of

Re: [edk2-devel] [PATCHv2 1/2] MdePkg/UefiDevicePathLib: Fix AcpiEx print logic

2023-10-13 Thread Michael D Kinney
One comment below. With that fix, Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Albecki, Mateusz > Sent: Wednesday, September 27, 2023 8:51 AM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz ; Kinney, Michael D > ; Gao, Liming ; > Liu, Zhiguang > Subject:

Re: [edk2-devel] [PATCHv2 2/2] MdePkg/Test: Add DevicePathLib host test module

2023-10-13 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Albecki, Mateusz > Sent: Wednesday, September 27, 2023 8:51 AM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz ; Kinney, Michael D > ; Gao, Liming ; > Liu, Zhiguang > Subject: [PATCHv2 2/2] MdePkg/Test: Add DevicePathLib host

Re: [edk2-devel] [PATCH edk2-platforms WIP 0/5] Provide EHCI or XHCI USB controller

2023-10-13 Thread Marcin Juszkiewicz
W dniu 13.10.2023 o 15:24, Gerd Hoffmann pisze: So two solutions came to my mind: 1. rewrite DSDT generation into C You might want have a look at DynamicTablesPkg/ for that Wasn't is involving using ConfigurationManager? Or maybe I just had wrong assumption after reading code. 2. provide

Re: [edk2-devel] [PATCH edk2-platforms WIP 0/5] Provide EHCI or XHCI USB controller

2023-10-13 Thread Gerd Hoffmann
Hi, > So two solutions came to my mind: > > 1. rewrite DSDT generation into C You might want have a look at DynamicTablesPkg/ for that > 2. provide EHCI/XHCI in SSDT table instead of DSDT Should work, except that I'd suggest to worry about xhci only. ehci never actually worked anyway, so

[edk2-devel] [PATCH edk2-platforms WIP 4/5] SbsaQemu: add EHCI to SSDT

2023-10-13 Thread Marcin Juszkiewicz
I want to add EHCI/XHCI switching so platforms older than 0.3 would not complain about missing XHCI. --- Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 1 + Silicon/Qemu/SbsaQemu/AcpiTables/Ehci.asl | 132 2 files changed, 133 insertions(+) diff --git

[edk2-devel] [PATCH edk2-platforms WIP 5/5] WIP: try to enable/disable proper USB controller

2023-10-13 Thread Marcin Juszkiewicz
If platform version < 0.3 then we want EHCI. Otherwise XHCI needs to be present. The problem: LocateAndInstallAcpiFromFvConditional() gets only DBG2 and FACP tables. Looks like synchronization issue as there were moments when it got all present tables. Anyway even if all goes well then SSDT

[edk2-devel] [PATCH edk2-platforms WIP 3/5] SbsaQemu: move XHCI to SSDT

2023-10-13 Thread Marcin Juszkiewicz
I want to add EHCI/XHCI switching so platforms older than 0.3 would not complain about missing XHCI. --- Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 1 + Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 116 - Silicon/Qemu/SbsaQemu/AcpiTables/Xhci.asl | 132

[edk2-devel] [PATCH edk2-platforms WIP 2/5] WIP: SbsaQemu: rename USB controller variables to be generic

2023-10-13 Thread Marcin Juszkiewicz
If run on PlatformVersion <0.3 then we have EHCI controller (not working) instead of XHCI one. *BSD platforms hang with wrong combination. --- Silicon/Qemu/SbsaQemu/SbsaQemu.dec| 4 ++-- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 4

[edk2-devel] [PATCH edk2-platforms WIP 0/5] Provide EHCI or XHCI USB controller

2023-10-13 Thread Marcin Juszkiewicz
change-id: 20231013-ehci-xhci-fix-c529356a7a8f Best regards, -- Marcin Juszkiewicz -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109586): https://edk2.groups.io/g/devel/message/109586 Mute This Topic: https://groups.io/mt/101938735/21656

[edk2-devel] [PATCH edk2-platforms WIP 1/5] SbsaQemu: introduce macro to compare platform version

2023-10-13 Thread Marcin Juszkiewicz
We want to check "if platver < 0.3" in an easy way. --- .../IndustryStandard/SbsaQemuPlatformVersion.h | 25 1 file changed, 25 insertions(+) diff --git a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuPlatformVersion.h

Re: [edk2-devel] [edk2-discuss] PLDM messages via MCTP over KCS

2023-10-13 Thread Konstantin Aladyshev
Hi Chang! Thanks for the response! Is it ok that because of 1) we would need to include MCTP SrcEID/DstEID in each function of the PLDM_SMBIOS_TRANSFER_PROTOCOL?

Re: [edk2-devel] [edk2-platforms PATCH 00/19] let LibRtcVirtualNotifyEvent() be dropped

2023-10-13 Thread Ard Biesheuvel
On Thu, 12 Oct 2023 at 11:10, Laszlo Ersek wrote: > > https://bugzilla.tianocore.org/show_bug.cgi?id=4564 > > The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly > declares a function called LibRtcVirtualNotifyEvent(). No component ever > calls this function across module

Re: [edk2-devel] [PATCH] Basetools: Include PCD declarations from Library Instance

2023-10-13 Thread Sami Mujawar
Adding Tuan. Regards, Sami Mujawar On 12/10/2023, 18:12, "levi.yun" mailto:yeoreum@arm.com>> wrote: The patch "[PATCH v3 1/2] StandaloneMmPkg: Make StandaloneMmCpu driver architecture independent" (https://edk2.groups.io/g/devel/message/109178