[AMD Official Use Only - General]
Hi Aladyshev,
I had updated code according to our discussion on PLDM over MCTP, please take a
look at https://github.com/changab/edk2-platforms/tree/MCTP_OVER_KCS_UPDATE and
verify it at you end if possible. The PLDM command table is also removed at
this
Hi Liming,
This patch set is already reviewed. Can you help on the merge?
Thanks,
Zhichao
> -Original Message-
> From: Jeff Brasen
> Sent: Wednesday, October 4, 2023 10:37 PM
> To: Gao, Liming ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Bi, Dandan
> ; Gao, Zhichao
> Subject: RE:
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, October 17, 2023
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 7/13/23 09:24, Joey Vagedes wrote:
Automatically set the nxcompat flag in the DLL Characteristics field of
the Optional Header of the PE32+ image. For this flag to be set
automatically, the section alignment must be evenly divisible
by 4K
It looks like this still needs reviewed and merged.
I'm working on the BaseTools patch (2/2) in this series.
--
Rebecca Cran
On 7/13/23 09:24, Joey Vagedes via groups.io wrote:
Add the bit masks for DLL Characteristics, used within the optional
header of a PE, to the PeImage.h header file.
*Tools, CI, Code base construction meeting series*
*When:*
Monday, October 16, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
Reviewed-by: Rebecca Cran
Looks like this is still waiting to be merged by an ArmPkg maintainer.
--
Rebecca Cran
On 6/29/23 14:46, Jeff Brasen wrote:
Add EFI_NOT_READY return if the CPU can not be enabled if the
processor is already on.
This can occur in normal use if the CPU is still
Pushed as:
https://github.com/tianocore/edk2/commit/e07948255cfafb75fa9cbe4555bfe3421488dd9a
https://github.com/tianocore/edk2/commit/03d6569f70939d2a1653265367121212459a6b89
--
Rebecca Cran
On 8/25/23 19:57, Mike Maslenkin wrote:
Please review small improvements to UsbNetwork
Here is
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, October 16, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
Sorry for the extreme delay!
No need to send a v2 - I can commit this.
--
Rebecca Cran
On 10/8/23 04:20, Mike Maslenkin wrote:
On Thu, Aug 31, 2023 at 3:32 PM Rebecca Cran wrote:
On 8/29/2023 8:05 PM, Richard Ho (何明忠) wrote:
Hi Rebecca,
We have tried the patch. It works on my device.
I
Hi Fan,
The logic looks functional, but there are some names and descriptions
that could be added to help describe this feature and some code
changes to make the code easier to understand.
1) The GUID gEdkiiToMigrateFvInfoGuid is hard to understand what
information it conveys from the name
The v1 series was on the list for about 3 weeks with no response. More
attention on v2 would be appreciated.
Thanks,
Michael
On 10/16/2023 4:12 PM, Michael Kubacki wrote:
From: Michael Kubacki
CodeQL currently runs via the codeql-analysis.yml GitHub workflow
which uses the
From: Michael Kubacki
Updates the CodeQL queries opted into by edk2 to a set of queries from
the standard CodeQL query package `codeql/cpp-queries`.
After testing a large number of queries the included set here were
found to be the most useful with the least number of false positives.
Some
From: Michael Kubacki
Since a large number of CodeQL queries are being enabled to identify
issues that the community can collectively resolve, audit mode needs to
be enabled to prevent the build from failing.
In the future, this global audit mode can be disabled and individual
packages can
From: Michael Kubacki
Adds a workflow to run CodeQL against all packages built in
.pytool/CISettings.py. The following is done:
1. Determine which packages to build against. Those that support
are managed by .pytool/CISettings.py will be selected.
For each package:
2. Determine how to
From: Michael Kubacki
Adds the `--codeql` parameter to `stuart_update` and
`stuart_ci_build`.
- `stuart_update --codeql` - Downloads the CodeQL CLI locally. The
command will pull the appropriate binary for the host OS.
- `stuart_ci_build --codeql` - Runs CodeQL during the build resulting
in
From: Michael Kubacki
Adds a Python module to the CodeQL plugin directory that exports
functions commonly needed for Stuart-based platforms to easily
enable CodeQL in their platform build.
This functionality has already moved to edk2-pytool-extensions
From: Michael Kubacki
Adds a CodeQL plugin that supports CodeQL in the build system.
1. CodeQlBuildPlugin - Generates a CodeQL database for a given build.
2. CodeQlAnalyzePlugin - Analyzes a CodeQL database and interprets
results.
3. External dependencies - Assist with downloading the CodeQL
From: Michael Kubacki
CodeQL currently runs via the codeql-analysis.yml GitHub workflow
which uses the `github/codeql-action/init@v2` action (pre-build)
and the `github/codeql-action/analyze@v2` action (post-build) to
setup the CodeQL environment and extract results.
This infrastructure is
From: Michael Kubacki
CodeQL currently runs via the codeql-analysis.yml GitHub workflow
which uses the github/codeql-action/init@v2 action (pre-build)
and the github/codeql-action/analyze@v2 action (post-build) to
setup the CodeQL environment and extract results.
This infrastructure is removed
Signed-off-by: Arun Sura
Cc: Chasel Chiu
Cc: Ray Han Lim Ng
Cc: Nate DeSimone
Cc: Ashraf Ali S
---
IntelFsp2Pkg/Tools/ConfigEditor/ConfigEditor.py | 226
[Public]
Hello Hao, Ashish, Rick,
I recently uploaded a patch to fix the same assert (BZ 4456), but it is still
under review although I haven't heard anything since August. Please look at my
corresponding patch which I have attached as an outlook item, and we can
discuss which patch should be
Currently the MCTP TAG_OWNER bit is checked against 1 both in MTCP
request and response.
According to the MTCP Base specification in case of the MCTP response
the TAG_OWNER bit should be equal to 0.
Correct MCTP_MESSAGE_TAG_OWNER_RESPONSE flag value to fix the issue.
Signed-off-by: Konstantin
Since the current driver doesn't yet support handling of
multiple-packet MCTP responses, return EFI_UNSUPPORTED error in such
cases.
Signed-off-by: Konstantin Aladyshev
---
.../MctpProtocol/Common/MctpProtocolCommon.c | 11 +++
1 file changed, 11 insertions(+)
diff --git
Currently PldmProtocol code uses magic numbers in the PLDM header
checks. Since PLDM headers have all the necessary definitions replace
magic numbers with the appropriate defines.
Signed-off-by: Konstantin Aladyshev
---
.../Universal/PldmProtocol/Common/PldmProtocolCommon.c| 8
1
Although MtcpSubmit function receives source and destination MCTP EID
arguments these value are not used in any way currently. Instead the
code always uses EID values from the PCDs.
To correct this issue modify function interface to receive source and
destination MCTP EIDs via pointers and use PCD
If MCTP KCS communication has failed we need to abort MCTP transfer
function before checking any MCTP header data.
Signed-off-by: Konstantin Aladyshev
---
.../MctpProtocol/Common/MctpProtocolCommon.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git
Correct wrong structure member used for MCTP destination EID.
Signed-off-by: Abner Chang
Signed-off-by: Konstantin Aladyshev
---
.../Universal/PldmProtocol/Common/PldmProtocolCommon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Add checks for the MCTP header fields in the MCTP response.
Signed-off-by: Konstantin Aladyshev
---
.../MctpProtocol/Common/MctpProtocolCommon.c | 82 +++
1 file changed, 82 insertions(+)
diff --git
The Manageability KCS transport library needs to support requests both
from MCTP and IPMI transports. Currently the code only handles IPMI
case correctly.
In the MCTP case the communication should be based on the MCTP-over-KCS
specification (DSP0254). This specification defines a special KCS
Currently there is only a definition for the MCTP KCS HEADER structure.
Add definition for the MCTP KCS TRAILER structure as well.
Signed-off-by: Konstantin Aladyshev
Signed-off-by: Abner Chang
---
.../Library/ManageabilityTransportMctpLib.h| 5 +
MTCP base specification marks EIDs 1-7 as reserved. Therefore return
EFI_INVALID_PARAMETER if such EIDs were provided to the
MctpSubmitMessage function.
Signed-off-by: Konstantin Aladyshev
Signed-off-by: Abner Chang
---
.../Universal/MctpProtocol/Dxe/MctpProtocol.c | 17 +
1
The Manageability KCS transport library needs to support requests both
from MCTP and IPMI transports. Currently the code only handles IPMI
case correctly.
In the MCTP case the communication should be based on the MCTP-over-KCS
specification (DSP0254). This specification defines a special KCS
The PLDM protocol uses Request bit to help differentiate between PLDM
request and response messages.
Currently the Pldm.h header only have a flag for the request message.
Add a flag for the response message as well.
Signed-off-by: Konstantin Aladyshev
---
MdePkg/Include/IndustryStandard/Pldm.h
Correct MCTP_TRANSPORT_HEADER structure field 'SourceEndpointIdId' to
'SourceEndpointId'.
Signed-off-by: Abner Chang
Signed-off-by: Konstantin Aladyshev
---
MdePkg/Include/IndustryStandard/Mctp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Ok, I will move this lib when submit LoongArch virtual-machine patch set.
Thanks,
Chao
在 2023/10/16 16:08, Gerd Hoffmann 写道:
On Mon, Oct 16, 2023 at 04:03:04PM +0800, Chao Li wrote:
Hi Gerd,
So, what I understand that is I can move the Fdt16550SerialPortHookLib into
OvmfPkg?
Yes.
take
We need platform version to be at least 0.3 to have XHCI
in virtual hardware. On older platforms there is non-working
EHCI which we ignore.
Set DSDT node to be disabled so operating system will not try
to initialize not-existing hardware.
Signed-off-by: Marcin Juszkiewicz
---
It will be needed for playing with disabling XHCI later.
Signed-off-by: Marcin Juszkiewicz
---
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
index 36723e21d7b5..1e650350cb63
We need platform version to be at least 0.3 to have XHCI
in virtual hardware. On older platforms there is non-working
EHCI which we ignore.
Signed-off-by: Marcin Juszkiewicz
---
.../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c| 47 +++-
1 file changed, 25 insertions(+), 22
Platform version 0.3 introduced XHCI USB controller instead of EHCI one.
But we did it in a way that there is no in-EDK2 check for platform
version (XHCI is always given).
This behaviour works with Linux as it complains about being unable to
initialize EHCI and goes on. Free/Net/Open BSD systems
We want to check "if platver < 0.3" in an easy way.
---
.../IndustryStandard/SbsaQemuPlatformVersion.h | 25
1 file changed, 25 insertions(+)
diff --git
a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuPlatformVersion.h
On Mon, Oct 16, 2023 at 04:03:04PM +0800, Chao Li wrote:
> Hi Gerd,
>
> So, what I understand that is I can move the Fdt16550SerialPortHookLib into
> OvmfPkg?
Yes.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online
Hi Gerd,
So, what I understand that is I can move the Fdt16550SerialPortHookLib
into OvmfPkg?
Thanks,
Chao
在 2023/10/16 15:47, Gerd Hoffmann 写道:
On Mon, Oct 16, 2023 at 10:58:29AM +0800, Chao Li wrote:
Hi Ard,
I'm porting the LoongArch virt-machine to edk2. LoongArch virt-machine uses
On Mon, Oct 16, 2023 at 10:58:29AM +0800, Chao Li wrote:
> Hi Ard,
>
> I'm porting the LoongArch virt-machine to edk2. LoongArch virt-machine uses
> Fdt16550SerialPortHookLib to handle the UartBase, and the
> gEarly16550UartBaseAddressGuid is defined in ArmVirtPkg.dec.
>
> I think this library
Sorry, the last mail was misspelled, what I meant was: can we detaching
the Fdt16550SerialPortHookLib into OvmfPkg?
Thanks,
Chao
在 2023/10/16 10:58, Chao Li 写道:
Hi Ard,
I'm porting the LoongArch virt-machine to edk2. LoongArch virt-machine
uses Fdt16550SerialPortHookLib to handle the
45 matches
Mail list logo
