W dniu 18.10.2023 o 05:28, Nhi Pham pisze:
Hi Marcin,
There is a nitpicking below.
Other than, it looks good to me.
Acked-by: Nhi Pham
a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c
b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c
index
[AMD Official Use Only - General]
For entire series, Reviewed-by: Abner Chang
Hi Aladyshev,
Could you please provide the corresponding branch somewhere that contains the
latest version of this patch set? Then I can move forward to merge it after
edk2 portion is merged.
Thanks for this
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Konstantin Aladyshev
> Sent: Monday, October 16, 2023 9:18 PM
> To: devel@edk2.groups.io
> Cc: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn;
> zhiguang@intel.com; Chang, Abner ;
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Konstantin Aladyshev
> Sent: Monday, October 16, 2023 9:18 PM
> To: devel@edk2.groups.io
> Cc: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn;
> zhiguang@intel.com; Chang, Abner ;
[AMD Official Use Only - General]
Hi Nate and Liming,
Please help to review this patch.
Thanks
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Tuesday, October 10, 2023 4:22 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef
[AMD Official Use Only - General]
Hi Reviewers,
Please help to review this patch.
Thanks
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Tuesday, October 10, 2023 4:22 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef
[AMD Official Use Only - General]
Hi maintainers,
Please help to review this.
I also would like to propose myself and one more person as the maintainers of
some manageability C header files under both MdePkg and MdeModulePkg. Such as
Pldm, IPMI and etc.. How do you think?
Thanks
Abner
>
[AMD Official Use Only - General]
Hi maintainers,
Please help to review this.
Thanks
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Tuesday, October 10, 2023 4:36 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul
Hi Marcin,
There is a nitpicking below.
Other than, it looks good to me.
Acked-by: Nhi Pham
Regards,
Nhi
On 10/17/2023 8:23 PM, Marcin Juszkiewicz wrote:
We need platform version to be at least 0.3 to have XHCI
in virtual hardware. On older platforms there is non-working
EHCI which we
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, October 17, 2023
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
From: Michael Kubacki
Updates the CodeQL queries opted into by edk2 to a set of queries from
the standard CodeQL query package `codeql/cpp-queries`.
After testing a large number of queries the included set here were
found to be the most useful with the least number of false positives.
Some
From: Michael Kubacki
Since a large number of CodeQL queries are being enabled to identify
issues that the community can collectively resolve, audit mode needs to
be enabled to prevent the build from failing.
In the future, this global audit mode can be disabled and individual
packages can
From: Michael Kubacki
Adds a workflow to run CodeQL against all packages built in
.pytool/CISettings.py. The following is done:
1. Determine which packages to build against. Those that support
are managed by .pytool/CISettings.py will be selected.
For each package:
2. Determine how to
From: Michael Kubacki
Adds the `--codeql` parameter to `stuart_update` and
`stuart_ci_build`.
- `stuart_update --codeql` - Downloads the CodeQL CLI locally. The
command will pull the appropriate binary for the host OS.
- `stuart_ci_build --codeql` - Runs CodeQL during the build resulting
in
From: Michael Kubacki
Adds a Python module to the CodeQL plugin directory that exports
functions commonly needed for Stuart-based platforms to easily
enable CodeQL in their platform build.
This functionality has already moved to edk2-pytool-extensions
From: Michael Kubacki
Adds a CodeQL plugin that supports CodeQL in the build system.
1. CodeQlBuildPlugin - Generates a CodeQL database for a given build.
2. CodeQlAnalyzePlugin - Analyzes a CodeQL database and interprets
results.
3. External dependencies - Assist with downloading the CodeQL
From: Michael Kubacki
CodeQL currently runs via the codeql-analysis.yml GitHub workflow
which uses the `github/codeql-action/init@v2` action (pre-build)
and the `github/codeql-action/analyze@v2` action (post-build) to
setup the CodeQL environment and extract results.
This infrastructure is
From: Michael Kubacki
CodeQL currently runs via the codeql-analysis.yml GitHub workflow
which uses the github/codeql-action/init@v2 action (pre-build)
and the github/codeql-action/analyze@v2 action (post-build) to
setup the CodeQL environment and extract results.
This infrastructure is removed
Thanks! Since you're okay with it, as a BaseTools maintainer I'll go
ahead with that plan.
--
Rebecca
On 10/17/23 13:56, Joey Vagedes wrote:
While I’m not a maintainer, so I don’t have much say - I don’t see an
issue with your solution that rewrites the entire file as the small
change I
MdePkg maintainers: could you review this, and I'll be happy to
merge/commit it.
--
Rebecca Cran
On 7/13/23 09:24, Joey Vagedes via groups.io wrote:
Add the bit masks for DLL Characteristics, used within the optional
header of a PE, to the PeImage.h header file.
Update the Visual Studio,
Unfortunately the patch doesn't pass CI because
BaseTools/UserManuals/GenFw_Utility_Man_Page.rtf contains trailing
whitespace.
I'm unsure whether I can manually fix it, or if I should open it in
LibreOffice and re-save it? Doing so appears to rewrite the entire file,
which might not be
On 10/17/23 14:17, Dhaval Sharma wrote:
> This PCD provides a way for platform to override any
> HW features that are default enabled by previous stages
> of FW (like OpenSBI). For the case where previous/prev
> stage has disabled the feature, this override is not
> useful and its usage should be
On 10/17/23 16:22, Laszlo Ersek wrote:
> On 10/17/23 14:17, Dhaval Sharma wrote:
>> Implementing code to support Cache Management Operations
>> (CMO) defined by RV spec https://github.com/riscv/riscv-CMOs
(28) Please do not abbreviate RISC-V as "RV". It's incredibly confusing.
(29) Inconsistent
On 10/17/23 14:17, Dhaval Sharma wrote:
> This PCD provides a way for platform to override any
> HW features that are default enabled by previous stages
> of FW (like OpenSBI). For the case where previous/prev
> stage has disabled the feature, this override is not
> useful and its usage should be
On 10/17/23 14:17, Dhaval Sharma wrote:
> Implementing code to support Cache Management Operations
> (CMO) defined by RV spec https://github.com/riscv/riscv-CMOs
>
> Notes:
> 1. CMO only supports block based Operations. Meaning complete
>cache flush/invd/clean Operations are not available. In
We need platform version to be at least 0.3 to have XHCI
in virtual hardware. On older platforms there is non-working
EHCI which we ignore.
Signed-off-by: Marcin Juszkiewicz
---
.../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c| 47 +++-
1 file changed, 25 insertions(+), 22
We need platform version to be at least 0.3 to have XHCI
in virtual hardware. On older platforms there is non-working
EHCI which we ignore.
Set DSDT node to be disabled so operating system will not try
to initialize not-existing hardware.
Signed-off-by: Marcin Juszkiewicz
---
It will be needed for playing with disabling XHCI later.
Signed-off-by: Marcin Juszkiewicz
---
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
index 36723e21d7b5..1e650350cb63
Platform version 0.3 introduced XHCI USB controller instead of EHCI one.
But we did it in a way that there is no in-EDK2 check for platform
version (XHCI is always given).
This behaviour works with Linux as it complains about being unable to
initialize EHCI and goes on. Free/Net/Open BSD systems
We want to check "if platver < 0.3" in an easy way.
---
.../IndustryStandard/SbsaQemuPlatformVersion.h | 25
1 file changed, 25 insertions(+)
diff --git
a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuPlatformVersion.h
W dniu 17.10.2023 o 13:46, Nhi Pham pisze:
Then looked again at code from
Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c and noticed
UpdateStatusMethodObject() function. Copied some code and it worked.
Could you please check whether we can replace the
UpdateStatusMethodObject() function
This PCD provides a way for platform to override any
HW features that are default enabled by previous stages
of FW (like OpenSBI). For the case where previous/prev
stage has disabled the feature, this override is not
useful and its usage should be avoided.
Ard Biesheuvel
Jiewen Yao
Jordan
Implementing code to support Cache Management Operations
(CMO) defined by RV spec https://github.com/riscv/riscv-CMOs
Notes:
1. CMO only supports block based Operations. Meaning complete
cache flush/invd/clean Operations are not available. In that case
we fallback on fence.i instructions.
Implementing code to support Cache Management Operations (CMO) defined by RV
spec https://github.com/riscv/riscv-CMOs
Notes:
CMO only supports block based Operations. Meaning complete cache
flush/invd/clean Operations are not available. In that case we fallback on
fence.i instructions.
Rely on
On 10/17/23 13:38, Nhi Pham via groups.io wrote:
> Thanks, Laszlo for this patch.
>
> Reviewed-by: Nhi Pham
>
> Regards,
> Nhi
Thank you both for reviewing; commit 7f3e7fc0b4ed.
Laszlo
>
> On 10/17/2023 5:05 PM, Laszlo Ersek via groups.io wrote:
>> Nhi says that reading
Hi Marcin,
On 10/16/2023 5:06 PM, Marcin Juszkiewicz wrote:
Platform version 0.3 introduced XHCI USB controller instead of EHCI one.
But we did it in a way that there is no in-EDK2 check for platform
version (XHCI is always given).
This behaviour works with Linux as it complains about being
On 10/17/23 13:28, Gerd Hoffmann wrote:
> Checking the max cpuid leaf is not enough to figure whenever
> CPUID_V2_EXTENDED_TOPOLOGY is supported. Intel SDM says:
>
>Software must detect the presence of CPUID leaf 1FH by verifying
>(a) the highest leaf index supported by CPUID is >= 1FH,
Thanks, Laszlo for this patch.
Reviewed-by: Nhi Pham
Regards,
Nhi
On 10/17/2023 5:05 PM, Laszlo Ersek via groups.io wrote:
Nhi says that reading LINK_CONTROL_LINK_STATUS_REG is redundant; its only
use was debugging (before commit 380b4b40c60d). Thus, we can go farther
than commit
Checking the max cpuid leaf is not enough to figure whenever
CPUID_V2_EXTENDED_TOPOLOGY is supported. Intel SDM says:
Software must detect the presence of CPUID leaf 1FH by verifying
(a) the highest leaf index supported by CPUID is >= 1FH, and
(b) CPUID.1FH:EBX[15:0] reports a non-zero
[AMD Official Use Only - General]
> -Original Message-
> From: Konstantin Aladyshev
> Sent: Tuesday, October 17, 2023 4:54 PM
> To: Chang, Abner
> Cc: disc...@edk2.groups.io; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [edk2-discuss] PLDM messages via MCTP over KCS
>
> Caution:
On 10/17/2023 4:05 AM, Laszlo Ersek wrote:
Nhi says that reading LINK_CONTROL_LINK_STATUS_REG is redundant; its only
use was debugging (before commit 380b4b40c60d). Thus, we can go farther
than commit 2e27c62ef000, and remove the MmioRead32() call altogether.
Build-tested with "Jade.dsc".
Cc:
Nhi says that reading LINK_CONTROL_LINK_STATUS_REG is redundant; its only
use was debugging (before commit 380b4b40c60d). Thus, we can go farther
than commit 2e27c62ef000, and remove the MmioRead32() call altogether.
Build-tested with "Jade.dsc".
Cc: Chuong Tran
Cc: Leif Lindholm
Cc: Nhi Pham
Hi,
> This is a terrible *organization* bug in the Intel SDM.
[ ... ]
> So, keep scrolling... a whopping 14 pages later, on page 850, we find:
>
> INPUT EAX = 1FH: Returns V2 Extended Topology Information
>
> When CPUID executes with EAX set to 1FH, the processor returns
>
Hi Abner,
In the code you are using:
PLDM_TERMINUS_ID_UNASSIGNED
PLDM_TERMINUS_ID_RESERVED
PLDM_TERMINUS_ID_SPECIAL
but I don't see any definitions for these values.
I'm particularly confused about the meaning and usage of the
PLDM_TERMINUS_ID_SPECIAL value.
My understanding was that we give
Hello,
FYIW:
Tested-by: Pierre Gondois
On 10/12/23 19:11, levi.yun wrote:
The patch "[PATCH v3 1/2] StandaloneMmPkg: Make StandaloneMmCpu driver
architecture independent" (https://edk2.groups.io/g/devel/message/109178)
removed ArmPkg/ArmPkg.dec from the Packages section in the
INF file:
45 matches
Mail list logo
