Re: [edk2-devel] Question about OvmfPackage cxl emulation support

2023-10-24 Thread Yoshinoya
Hi, Gerd: Got it! Thanks At 2023-10-24 16:05:06, "Gerd Hoffmann" wrote: >On Tue, Oct 24, 2023 at 02:48:33PM +0800, Yoshinoya wrote: >> Hi, Lersek: >> I have a question about acpi tables in OvmfPkg. >> >> >> Does qemu create acpi tables template for Ovmf BIOS ? > >Yes, qemu

Re: [edk2-devel] [PATCH] Remove memory cache setting for memory under 1MB

2023-10-24 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Xie, Yuanhao Sent: Thursday, October 19, 2023 11:20 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Isaac Oram ; Gao, Liming ; Dong, Eric ; Xie, Yuanhao Subject: [PATCH] Remove memory cache setting for memory

Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg/AcpiPlatformDxe: Fix Coverity report issues

2023-10-24 Thread Min Xu
Reviewed-by: Min Xu > -Original Message- > From: Sun, CepingX > Sent: Monday, October 23, 2023 5:06 PM > To: devel@edk2.groups.io > Cc: Sun, CepingX ; Aktas, Erdem > ; James Bottomley ; Yao, > Jiewen ; Xu, Min M ; Tom > Lendacky ; Michael Roth > ; Gerd Hoffmann > Subject: [PATCH V2

Re: [edk2-devel] [PATCH v1 2/3] ShellPkg: Add varpolicy dynamic shell command

2023-10-24 Thread Michael Kubacki
On 10/24/2023 2:21 AM, Gao, Zhichao wrote: Hi Michael: The patch looks good to me. Reviewed-by: Zhichao Gao Agree with Liming, Michael do you consider to add the APP version inf like DP/HTTP/TFTP? Yes, that's a good suggestion. I will add it in a v2 update. Thanks, Zhichao

Re: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update

2023-10-24 Thread VivianNK
Hi, following up to see if there's any update on this. Thanks for your help, - Vivian On 9/27/2023 12:43 PM, Vivian Nowka-Keane wrote: Hi Mike, Can you help merge this? Looks like it has all of the reviews. Thank you! - Vivian On 9/12/2023 7:42 AM, Michael D Kinney wrote: Series

Re: [edk2-devel] [PATCH v6 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

2023-10-24 Thread Pedro Falcato
On Sat, Oct 21, 2023 at 6:33 PM Dhaval Sharma wrote: > > Use newly defined cache management operations for RISC-V where possible > It builds up on the support added for RISC-V cache management > instructions in BaseLib. > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Laszlo

[edk2-devel] Here is a problem

2023-10-24 Thread Jean-Luc Ehms
Good morning, Here is a problem encountered today where the creation of the USB key does not succeed if we select the first box for removing the secure boot and TPM verification. thank you Jluc -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply

Re: [edk2-devel] [PATCH] ArmPlatformPkg/PL031RealTimeClockLib: remove superfluous instance init steps

2023-10-24 Thread Laszlo Ersek
On 10/20/23 14:27, Ard Biesheuvel wrote: > On Fri, 20 Oct 2023 at 14:17, Laszlo Ersek wrote: >> >> RealTimeClockLib instances are consumed by edk2's >> EmbeddedPkg/RealTimeClockRuntimeDxe driver. In its entry point function >> InitializeRealTimeClock(), the driver: >> >> (1) calls

Re: [edk2-devel] [edk2-platforms PATCH 0/7] drop needless init steps in RealTimeClockLib instances

2023-10-24 Thread Laszlo Ersek
On 10/20/23 14:18, Laszlo Ersek wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=4565 > > RealTimeClockLib instances should neither set gRT fields nor install > EFI_REAL_TIME_CLOCK_ARCH_PROTOCOL in LibRtcInitialize(); > EmbeddedPkg/RealTimeClockRuntimeDxe already performs those actions. >

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Optimize BmExpandPartitionDevicePath

2023-10-24 Thread Laszlo Ersek
On 10/24/23 14:29, Laszlo Ersek wrote: > On 10/24/23 04:18, Gao, Zhichao wrote: >> The patch looks good to me. >> Reviewed-by: Zhichao Gao >> >> The comments of this patch and proposal would be taken care in another >> patch. Better to have a Bugzilla record for the planned change. > > I've

Re: [edk2-devel] [PATCH v6 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

2023-10-24 Thread Laszlo Ersek
On 10/21/23 19:33, Dhaval Sharma wrote: > Use newly defined cache management operations for RISC-V where possible > It builds up on the support added for RISC-V cache management > instructions in BaseLib. > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Laszlo Ersek > >

Re: [edk2-devel] [PATCH v6 5/5] OvmfPkg/RiscVVirt: Override for RV CPU Features

2023-10-24 Thread Laszlo Ersek
On 10/21/23 19:33, Dhaval Sharma wrote: > This PCD provides a way for platform to override any > HW features that are default enabled by previous stages > of FW (like OpenSBI). For the case where previous/prev > stage has disabled the feature, this override is not > useful and its usage should be

Re: [edk2-devel] [PATCH v6 3/5] MdePkg: Implement RISC-V Cache Management Operations

2023-10-24 Thread Laszlo Ersek
On 10/21/23 19:33, Dhaval Sharma wrote: > Implement Cache Management Operations (CMO) defined by > RISC-V spec https://github.com/riscv/riscv-CMOs. > > Notes: > 1. CMO only supports block based Operations. Meaning cache >flush/invd/clean Operations are not available for the entire >range.

Re: [edk2-devel] [PATCH v6 2/5] MdePkg: Rename Cache Management Function To Clarify Fence Based Op

2023-10-24 Thread Laszlo Ersek
On 10/21/23 19:33, Dhaval Sharma wrote: > There are different ways to manage cache on RISC-V Processors. > One way is to use fence instruction. Another way is to use CPU > specific cache management operation instructions ratified as > per RISC-V ISA specifications to be introduced in future >

Re: [edk2-devel] [PATCH v6 1/5] MdePkg: Move RISC-V Cache Management Declarations Into BaseLib

2023-10-24 Thread Laszlo Ersek
On 10/21/23 19:33, Dhaval Sharma wrote: > The declarations for cache Management functions belong to BaseLib > instead of instance source file. This helps with further restructuring > of cache management code for RISC-V. > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Laszlo

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/BaseXApicX2ApicLib: fix CPUID_V2_EXTENDED_TOPOLOGY detection

2023-10-24 Thread Laszlo Ersek
Eric, Ray, Rahul -- can you ACK this patch please? I intend to merge it in one or two days. Thanks Laszlo On 10/17/23 13:42, Laszlo Ersek wrote: > On 10/17/23 13:28, Gerd Hoffmann wrote: >> Checking the max cpuid leaf is not enough to figure whenever >> CPUID_V2_EXTENDED_TOPOLOGY is supported.

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Optimize BmExpandPartitionDevicePath

2023-10-24 Thread Laszlo Ersek
On 10/24/23 04:18, Gao, Zhichao wrote: > The patch looks good to me. > Reviewed-by: Zhichao Gao > > The comments of this patch and proposal would be taken care in another patch. > Better to have a Bugzilla record for the planned change. I've submitted

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg: Fix the failure to find uncompressed inner FV.

2023-10-24 Thread Laszlo Ersek
On 10/24/23 07:53, Xu, Wei6 wrote: > The MmCoreFfsFindMmDriver only checks for encapsulated compressed FVs. > When an inner FV is uncompressed, StandaloneMmCore will miss the FV and > all the MM drivers in the FV will not be dispatched. > Add checks for uncompressed inner FV to fix this issue. >

Re: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM

2023-10-24 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] BTW Lisa, As Issac told me the implementation which Intel upstream to IpmiFeaturePkg was from a pretty old intel code base. Also, something like FAST_VIDEO_SUPPORT, BmcSlaveAddress and GetBmcStatus seems not used. I think those code should be removed as well.

Re: [edk2-devel] [PATCH v3 2/7] BaseTools/Plugin/CodeQL: Add CodeQL build plugin

2023-10-24 Thread Yuwei Chen
Reviewed-by: Yuwei Chen > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, October 18, 2023 9:05 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Kinney, Michael D > ; Rebecca Cran ; Sean > Brogan ; Chen, Christine > > Subject: [PATCH v3 2/7]

Re: [edk2-devel] [PATCH v2] DynamicTablesPkg: HOWTO for Handcrafted tables

2023-10-24 Thread Sami Mujawar
Hi Jose, Thank you for this patch. There was a minor numbering change that I have done before pushing the patch for merging. Otherwise this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this

Re: [edk2-devel] [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support

2023-10-24 Thread Sami Mujawar
Dear MdePkg Maintainers, Can I have your review feedback for the first 2 patches in this series, please? - MdePkg: MADT: Add Online capable flag in GICC - MdePkg: MADT: Add TRBE interrupt to GICC I plan to merge this series by end of this week. Regards, Sami Mujawar On 23/10/2023 04:30

[edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller

2023-10-24 Thread Nickle Wang via groups.io
Call Ex interface to get HTTP headers and return to caller. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

[edk2-devel] [PATCH 2/3] RedfishPkg/libredfish: introduce new interfaces.

2023-10-24 Thread Nickle Wang via groups.io
- Add new interfaces to return HTTP headers back to caller. New interfaces are: getUriFromServiceEx(), patchUriFromServiceEx(), postUriFromServiceEx() and putUriFromServiceEx(). - Fix compile error in payload.c Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez

[edk2-devel] [PATCH 1/3] RedfishPkg/RedfishLib: introduce new interfaces.

2023-10-24 Thread Nickle Wang via groups.io
Add two new interface: RedfishServiceInPayload() and RedfishPutToUri() for Redfish HTTP protocol implementation. Fix several typos and add missing JsonLib in INF file. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez ---

[edk2-devel] [PATCH 0/3] RedfishPkg/RedfishLib: Return HTTP headers to caller

2023-10-24 Thread Nickle Wang via groups.io
The purpose of this patch series is to add new interfaces in RedfishLib to return HTTP headers to caller. I also fix typos and compile error in RedfishLib. PR is opened here: https://github.com/tianocore/edk2/pull/4944 Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick

Re: [edk2-devel] Question about OvmfPackage cxl emulation support

2023-10-24 Thread Gerd Hoffmann
On Tue, Oct 24, 2023 at 02:48:33PM +0800, Yoshinoya wrote: > Hi, Lersek: > I have a question about acpi tables in OvmfPkg. > > > Does qemu create acpi tables template for Ovmf BIOS ? Yes, qemu generates the acpi tables (not just templates). The same is true for the smbios tables. take care,

Re: [edk2-devel] Question about OvmfPackage cxl emulation support

2023-10-24 Thread Yoshinoya
Hi, Lersek: I have a question about acpi tables in OvmfPkg. Does qemu create acpi tables template for Ovmf BIOS ? I could not find any acpi tables template(asl files) for x86 platform in OvmfPkg. best wishes, At 2023-10-21 11:50:01, "Yoshinoya" wrote: Hi, Lersek: Got it!

Re: [edk2-devel] [PATCH v1 2/3] ShellPkg: Add varpolicy dynamic shell command

2023-10-24 Thread Gao, Zhichao
Hi Michael: The patch looks good to me. Reviewed-by: Zhichao Gao Agree with Liming, Michael do you consider to add the APP version inf like DP/HTTP/TFTP? Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of > gaoliming via groups.io > Sent: Tuesday, October