Hi Abner,
FAST_VIDEO_SUPPORT exists in GenericIPMI Dxe driver, my patch focuses on
StandaloneMm support, and will not touch other drivers.
BTW, the patch format is also updated and pass all check.
Could you help to review again? Thanks.
Regards,
Lisa
-Original Message-
From: Chang,
[AMD Official Use Only - General]
Ah sorry. Please ignore this. The patch is 0/3.
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Thursday, October 26, 2023 1:40 PM
> To: Nickle Wang ; devel@edk2.groups.io
> Cc: Igor Kulchytskyy
[AMD Official Use Only - General]
Hi Nickle,
Seems no differences in this patch.
Abner
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, October 24, 2023 4:39 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [PATCH 0/3]
[AMD Official Use Only - General]
Merged. I will send another patch for Uncrustify updates if any.
Abner
> -Original Message-
> From: Chang, Abner
> Sent: Tuesday, October 24, 2023 10:44 AM
> To: Konstantin Aladyshev ; devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ;
>
Hi, Ray:
For example:
CXL Host Bridge / Root Port / Switch / Device enumeration / HDM Config, maybe
could be integrated into pci drivers stack.
Thanks
At 2023-10-25 18:13:57, "Ni, Ray" wrote:
I think CXL device enumeration doesn't require extra logic in today's pci bus
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, October 25, 2023 6:25 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez ; Mike Maslenkin
>
> Subject: [PATCH v2]
[AMD Official Use Only - General]
Here it is https://edk2.groups.io/g/devel/topic/101587129#109614
> -Original Message-
> From: Pedro Falcato
> Sent: Thursday, October 26, 2023 2:10 AM
> To: devel@edk2.groups.io; ler...@redhat.com
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner
From: Charles Hyde
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2861
I believe the attached ConfigRouting.txt patch will resolve bug 2861, plus
resolve an uninitialized pointer issue in HiiConfigRoutingExportConfig().
The uninitialized pointer was identified when running the EDK2 Self
Chris:
I just add push label for this PR
https://github.com/tianocore/edk2/pull/4932.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Chris Li OS
> via groups.io
> 发送时间: 2023年10月20日 17:22
> 收件人: devel@edk2.groups.io; 'Kinney, Michael D'
> ; 'Nong, Foster' ;
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4571
Utilize both PeiVirtualBlockIo and PeiVirtualBlockIo2 PPI while searching for
recovery capsule from storage devices
Cc: Jiangang He
Cc: Abner Chang
Signed-off-by: Neo Hsueh
---
FatPkg/FatPei/FatLiteApi.c | 141
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 10/12/23 11:11, levi.yun wrote:
The patch "[PATCH v3 1/2] StandaloneMmPkg: Make StandaloneMmCpu driver
architecture independent" (https://edk2.groups.io/g/devel/message/109178)
removed ArmPkg/ArmPkg.dec from the Packages section in the
INF file:
On Wed, Oct 25, 2023 at 9:35 AM Laszlo Ersek wrote:
>
> Email to Isaac's address bounces ("5.1.0 Address
> rejected"); remove that address.
FWIW, there's a patch in the ML list (by Nate IIRC?) that never got
merged that addresses this very issue, with proposed replacements.
--
Pedro
I also noticed that the Author was not set correctly on
these patches. I updated using the same name/email from
your Signed-off-by tag.
Please review your git config to match for future patches.
I have started EDK II CI with the following PR:
https://github.com/tianocore/edk2/pull/4957
Hi Vivian,
I am working on this. However, I noticed that Patch 6/7 was
missing Signed-off-by tag. Is that supposed to be the same
as the other 6 patches?
Signed-off-by: Vivian Nowka-Keane
Thanks,
Mike
> -Original Message-
> From: Vivian Nowka-Keane
> Sent: Tuesday, October 24,
Reviewed-by: Sai Chaganty
-Original Message-
From: Laszlo Ersek
Sent: Wednesday, October 25, 2023 1:36 AM
To: edk2-devel-groups-io
Cc: Abdul Lateef Attar ; Abner Chang
; S, Ashraf Ali ; Chiu, Chasel
; Dong, Eric ; Gao, Liming
; Desimone, Nathaniel L
; Nickle Wang ; Pedro
Falcato
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, October 25, 2023 1:36 AM
> To: edk2-devel-groups-io
> Cc: Abdul Lateef Attar ; Abner Chang
> ; S, Ashraf Ali ; Chiu,
> Chasel ; Dong, Eric ; Gao,
> Liming ;
[AMD Official Use Only - General]
Reviewed-by: Attar, AbdulLateef (Abdul Lateef) ;
-Original Message-
From: Konstantin Aladyshev
Sent: Monday, October 23, 2023 6:35 PM
To: devel@edk2.groups.io
Cc: Chang, Abner ; Attar, AbdulLateef (Abdul Lateef)
; nick...@nvidia.com; Konstantin
[AMD Official Use Only - General]
Reviewed-by: Attar, AbdulLateef (Abdul Lateef)
-Original Message-
From: Konstantin Aladyshev
Sent: Monday, October 23, 2023 6:35 PM
To: devel@edk2.groups.io
Cc: Chang, Abner ; Attar, AbdulLateef (Abdul Lateef)
; nick...@nvidia.com; Konstantin
> double declaration of 'strcpy' is still there.
Thanks for catching this, Mike. Version 2 patch file was sent.
Regards,
Nickle
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Mike
> Maslenkin via groups.io
> Sent: Tuesday, October 24, 2023 4:23 AM
> To: Nickle Wang
>
[AMD Official Use Only - General]
Thanks Laszlo!
Abner
> -Original Message-
> From: Laszlo Ersek
> Sent: Wednesday, October 25, 2023 6:13 PM
> To: devel@edk2.groups.io; Chang, Abner
> Cc: Andrew Fish ; Leif Lindholm
> ; Michael D Kinney
> ; Attar, AbdulLateef (Abdul Lateef)
> ; Nickle
Hi Laszlo,
Thanks a lot for the feedbacks and quick response.
I updated the commit message, please check v3.
The changes includes:
-An explanation for the first chunk, which aims to report the incrementation of
"finished" for as late as possible.
-Renamed the subject line and added the module.
Aim:
- To solve the assertion that checks if CpuMpData->FinishedCount
equals (CpuMpData->CpuCount - 1). The assertion arises from a timing
discrepancy between the BSP's completion of startup signal checks and
the APs' incrementation of the FinishedCount.
- This patch also ensures that "finished"
From: Pierre Gondois
The SsdtCpuTopologyGenerator can generate _CPC objects.
This is done by querying the SCP for the relevant performance
state information through SCMI. CM_ARM_CPC_INFO are then populated
and used to generate _CPC objects in the Ssdt Cpu topology.
Use the ArmScmiInfoLib and
From: Pierre Gondois
The SsdtCpuTopologyGenerator can generate _PSD objects.
Add _PSD information and handling to the Configuration Manager
to generate them.
Change-Id: I4bb23582d250d43c173a3e6ee86eb6b0349f1b03
Signed-off-by: Pierre Gondois
---
.../ConfigurationManager.c|
From: Pierre Gondois
Fix a typo.
Change-Id: I84807f18855ff4c0a2f34a3556edc4698eea2170
Signed-off-by: Pierre Gondois
---
.../ConfigurationManagerDxe/ConfigurationManager.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Pierre Gondois
v1:
- https://edk2.groups.io/g/devel/message/104127
v2:
- Rebase patches on latest version.
- Correct frequency values which were advertised in KHz
when CPPC spec require them to be in MHz.
A recent patchset [1] allows the generation of _PSD/_CPC ACPI objects by
querying
From: Pierre Gondois
The SCP holds some power information that could be advertised
through the _CPC object. The communication with the SCP is done
through SCMI protocols (c.f. ArmScmiDxe).
Use the SCMI protocols to query information and feed it to
the DynamicTablesPkg.
Signed-off-by: Pierre
From: Pierre Gondois
When generating _CPC objects, some fields are mandatory.
Some fields cannot be supported by a the Juno platform, which is used
to test the _CPC generation. Therefore, don't prevent from generating
_CPC objects if the fields below are missing, and let the OS handle
the
From: Pierre Gondois
Make use of the newly added AmlCreatePsdNode() to generate
_PSD objects.
_PSD objects allow to describe 'performance control, P-state
or CPPC, logical processor dependency', Cf. ACPI 6.4,
s8.4.5.5 _PSD (P-State Dependency).
Signed-off-by: Pierre Gondois
---
From: Pierre Gondois
Add AmlCreatePsdNode() to the AmlLib to generate _PSD objects.
_PSD objects allow to describe 'performance control, P-state
or CPPC, logical processor dependency', Cf. ACPI 6.4,
s8.4.5.5 _PSD (P-State Dependency).
Signed-off-by: Pierre Gondois
---
From: Pierre Gondois
The _PSD object (cf. ACPI 6.4, s8.4.5.5 _PSD (P-State Dependency)
allows to describe CPU's power state dependencies. Add a PsdToken
field to the CM_ARM_GICC_INFO object so that interdependent CPUs
can reference the same CM_ARM_PSD_INFO object.
Signed-off-by: Pierre Gondois
From: Pierre Gondois
Add an object describing _PSD information, cf. ACPI 6.4,
s8.4.5.5 _PSD (P-State Dependency).
Also add the corresponding CmObjParser.
Signed-off-by: Pierre Gondois
---
DynamicTablesPkg/Include/AcpiObjects.h| 20 +++
.../Include/ArmNameSpaceObjects.h
From: Pierre Gondois
The DynamicTables framework uses the AmlLib to generate some
Aml objects. It is done by using structured known by both
frameworks, e.g. the AML_CPC_INFO/CM_ARM_CPC_INFO structures.
To prepare adding similar structures (e.g. representing _PSD
information), rename
From: Pierre Gondois
Make use of the newly added CPC revision macro.
Signed-off-by: Pierre Gondois
---
DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
From: Pierre Gondois
Add macros for:
- _PSD version
- _CPC version
- C-state/T-state/P-state Coordination Types
These objects were present in previous ACPI specification version,
but are only added to the latest availbable version (6.4).
Signed-off-by: Pierre Gondois
---
From: Pierre Gondois
The PERFORMANCE_DESCRIBE_FASTCHANNEL Scmi command is available
since SCMI v2.0 and allows to query information about the supported
fast-channels of the Scmi performance protocol.
Add support for this command.
Signed-off-by: Pierre Gondois
---
From: Pierre Gondois
Rename PERFORMANCE_PROTOCOL_VERSION to reflect the different
versions of the protocol. The macro is neither used in edk2 nor
in edk2-platforms.
Signed-off-by: Pierre Gondois
---
ArmPkg/Include/Library/ArmLib.h | 1 +
From: Pierre Gondois
v1:
- https://edk2.groups.io/g/devel/message/104115
v2:
- Rebase patches on latest version.
The SCMI performance protocol allows to query the Operating Performance
Points (OPPs) available for each performance domain. Each OPP has a
specific frequency/power
Aim:
This patch aims to solve an assertion happens after SwitchApContext()
on checking if CpuMpData->FinishedCount == (CpuMpData->CpuCount - 1).
The assertion issue due to a timing discrepancy between the BSP
completing its Start-up signal checking and the APs incrementing the
FinishedCount.
In
On 10/25/23 12:07, Yuanhao Xie wrote:
> The purpose is to fix an assertion with applying the following patch
> series:
>
> UefiCpuPkg: Refactor the logic for placing APs in HltLoop.
> UefiCpuPkg: Refactor the logic for placing APs in Mwait/Runloop.
> UefiCpuPkg: Create MpHandOff.
> UefiCpuPkg:
There are two definitions for below functions in RedfishCrtLib.h. Create
this change to remote duplicated functions.
Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(),
strchr(), strcasecmp(), strstr(), memcmp(), memset(), memcpy() and
memchr().
Signed-off-by: Nickle Wang
Cc:
I think CXL device enumeration doesn't require extra logic in today's pci bus
driver.
But I might be wrong. Can you list any missing logic in pci bus driver?
Thanks,
Ray
From: devel@edk2.groups.io on behalf of Yoshinoya
Sent: Wednesday, October 25, 2023 2:01
On 10/19/23 07:43, Chang, Abner via groups.io wrote:
> From: Abner Chang
>
> - Add two entries of MdePkg and MdeModulePkg for
> manageability modules and files.
> - Add one entry of UefiCpuPkg AMD related files.
>
> Signed-off-by: Abner Chang
> Cc: Andrew Fish
> Cc: Leif Lindholm
> Cc:
On 10/23/23 11:05, sunceping wrote:
> From: Ceping Sun
>
> v1 -> v2 Changed list:
> 1:Since both commits are intended to fix coverity issues, they are merged
> into one
> 2: Changed the debug info level to debug error when "DsdtTable == NULL"
> 3:Add the Cc member as below
> Erdem Aktas
On 10/17/23 13:28, Gerd Hoffmann wrote:
> Checking the max cpuid leaf is not enough to figure whenever
> CPUID_V2_EXTENDED_TOPOLOGY is supported. Intel SDM says:
>
>Software must detect the presence of CPUID leaf 1FH by verifying
>(a) the highest leaf index supported by CPUID is >= 1FH,
The purpose is to fix an assertion with applying the following patch
series:
UefiCpuPkg: Refactor the logic for placing APs in HltLoop.
UefiCpuPkg: Refactor the logic for placing APs in Mwait/Runloop.
UefiCpuPkg: Create MpHandOff.
UefiCpuPkg: ApWakeupFunction directly use CpuMpData.
UefiCpuPkg:
On 10/25/23 10:37, Xie, Yuanhao wrote:
> Hi Laszlo,
>
> I searched for my name to find the patch, and did not find a numbered tag
> associated with the patch title, and overlook the comment. I'm sorry for the
> ignoring and inconvenience this have caused. Could you please help with
> reverting
With the fact that CSM is not supported,
the request is to remove the cache setting for memory under 1MB.
This can be treated as the missing part of legacy CSM deprecation.
This patch only set the 0 to 9 and C to F as Write Back.
A-B range is still uncacheable for VGA.
Reviewed-by: Ashraf Ali S
Thanks.,
S, Ashraf Ali
-Original Message-
From: Laszlo Ersek
Sent: Wednesday, October 25, 2023 2:06 PM
To: edk2-devel-groups-io
Cc: Abdul Lateef Attar ; Abner Chang
; S, Ashraf Ali ; Chiu, Chasel
; Dong, Eric ; Gao, Liming
; Desimone, Nathaniel L
;
Hi Laszlo,
I searched for my name to find the patch, and did not find a numbered tag
associated with the patch title, and overlook the comment. I'm sorry for the
ignoring and inconvenience this have caused. Could you please help with
reverting the patch? I will submit Version 2.
Yuanhao
Email to Isaac's address bounces ("5.1.0 Address
rejected"); remove that address.
Cc: Abdul Lateef Attar
Cc: Abner Chang
Cc: Ashraf Ali S
Cc: Chasel Chiu
Cc: Eric Dong
Cc: Liming Gao
Cc: Nate DeSimone
Cc: Nickle Wang
Cc: Pedro Falcato
Cc: Rangasai V Chaganty
Cc: Ray Ni
Cc: Sai
On 10/19/23 07:43, Chang, Abner via groups.io wrote:
> From: Abner Chang
>
> - Add two entries of MdePkg and MdeModulePkg for
> manageability modules and files.
> - Add one entry of UefiCpuPkg AMD related files.
>
> Signed-off-by: Abner Chang
> Cc: Andrew Fish
> Cc: Leif Lindholm
> Cc:
Add Standalone Mm Generic Impi driver. And add type 'PcdsFixedAtBuild'
for PcdIpmiSmmIoBaseAddress to access in StandaloneMm driver
Cc: Abner Chang
Cc: Nate DeSimone
Signed-off-by: Lixia Huang
---
Yuanhao,
On 10/19/23 05:20, Yuanhao Xie wrote:
> With the fact that CSM is not supported,
> the request is to remove the cache setting for memory under 1MB.
> This can be treated as the missing part of legacy CSM deprecation.
>
> This patch only set the 0 to 9 and C to F as Write
Just one patch, in patch v1, the commit message check failed, sorry for I never
use PatchCheck.py to check the commit message in patch v1
Thanks
Jinlong
-Original Message-
From: gaoliming
Sent: Wednesday, October 25, 2023 3:24 PM
To: Xu, Jinlong ; devel@edk2.groups.io
Cc: Kinney,
Jinlong:
I want to confirm whether there is only one patch. If yes, why patch shows
2/5? Seemly, this is the second one of the patch serial.
For this change, Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: Jinlong Xu
> 发送时间: 2023年10月20日 19:14
> 收件人: devel@edk2.groups.io
>
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Chang, Abner
> via groups.io
> 发送时间: 2023年10月19日 13:43
> 收件人: devel@edk2.groups.io
> 抄送: Andrew Fish ; Leif Lindholm
> ; Michael D Kinney
> ; Abdul Lateef Attar
> ; Nickle Wang ; Jian J
> Wang ; Liming Gao ;
> Zhiguang Liu
Hi,
CXL devices are more polular.
Is there any plan to add cxl device enumeration in pci bus driver?
Thanks
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110016): https://edk2.groups.io/g/devel/message/110016
Mute This Topic:
58 matches
Mail list logo
