Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Remove unused OvmfPkg Confidential Computing path

On Tue, Nov 07, 2023 at 07:49:53PM -0800, Michael D Kinney wrote: > The following commit removed PlatformBootManagerLibGub from > OvmfPkg. Update Maintainers.txt to remove reference to > deleted directory. > > https://github.com/tianocore/edk2/commit/6fb2760dc8939b16a906b8e6bb224764907168f3

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishFeatureUtilityLib: validate string array

- Add function to validate Redfish request for string array type. There is case that user request invalid string array and feature driver can not find corresponding HII option. - Fix typo. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez ---

Re: [edk2-devel] [PATCH v1] OvmfPkg/PlatformInitLib: Don't override user specified PciMmio64Size

Hi Gerd, > > > > Strictly speaking you don't care that much about the size of the mmio > > > window, but where it gets placed. Moving it to the end of the vcpu > > > address space is what breaks your use case in case the iommu address > > > space happens to be too small for that. > > Right, the

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Fix issue with ACPI table creation

The changes looks good to me. One minor comment about the coding style: Could we make the "else if" at the same line with brace "}", which is aligned with current edk2 coding style, rather than in a new line ? Thanks. Like: } else if (((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE

[edk2-devel] [PATCH] IntelFsp2Pkg\Tools\ConfigEditor: Added new USF config workstream support Config Edit utility addition/changes.

This patch is to enable config editor to have a new feature that can load and view the configuration data of compiled VFR or HFR in form of YAML. This can help users to understand and track the configuration data when modifications are made. Running Configuration Editor: python ConfigEditor.py

Re: [edk2-devel] [PATCH v2 1/2] MdeModulePkg/Bus/Pci/PciHostBridgeDxe: Fix OVERRUN Coverity issues

Thanks for the detailed analysis Laszlo. I don't deny that there cannot be false positives by the tool. For now, I can move forward with your proposal of replacing continue with CpuDeadLoop and will post v3. On Tue, Nov 7, 2023 at 9:17 PM Laszlo Ersek wrote: > Hi Ranbir, > > On 11/7/23

Re: [edk2-devel] [PATCH v2 2/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix MISSING_BREAK Coverity issues

Hi Mike, I agree that any manual inspection is sort of a burden, more so when it becomes repetitive in the long run. When I was doing these Coverity checks (Nov-Dec' 2022), I was working in Dell and had access to the real systems to check the execution flow as well as the Coverity status. I

Re: [edk2-devel] [PATCH V2 2/2] OvmfPkg/BaseMemEncryptTdxLib: Handle retry result of MapGPA

I think the macro definition (#define TDVMCALL_STATUS_RETRY 0x1) should be in https://github.com/tianocore/edk2/blob/master/MdePkg/Include/IndustryStandard/Tdx.h, together with other TDX definition. Thank you Yao, Jiewen > -Original Message- > From: Sun, CepingX > Sent: Thursday,

Re: [edk2-devel] [PATCH V2 1/2] MdePkg/BaseLib: Update TdVmcall to always output the value in R11

Reviewed-by: Jiewen Yao > -Original Message- > From: Sun, CepingX > Sent: Thursday, November 2, 2023 5:10 PM > To: devel@edk2.groups.io > Cc: Sun, CepingX ; Gao, Liming > ; Kinney, Michael D ; > Aktas, Erdem ; James Bottomley > ; Yao, Jiewen ; Xu, Min M > ; Tom Lendacky ; Michael > Roth

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/PiSmmCpuDxeSmm: Use processor extended information

Hi Laszlo, > > > > The patch looks OK to me, but: > > > > - I would like to test it with CPU hotplug (later, likely under v2), and > > Sure, I can wait the update from you. > > - I think this should be two patches. > > > > First, the SmmAddProcessor() function should be extended just to > >

Re: [edk2-devel] [PATCH v2 2/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix MISSING_BREAK Coverity issues

Hi Ranbir, Ignoring false positive in static analysis tools is typically a burden. It is better to avoid false positives with code changes as long as the code changes do not make the implementation confusing and hard to maintain. I think depending on fall through case statements is confusing

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Remove unused OvmfPkg Confidential Computing path

Acked-by: Jiewen Yao > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, November 8, 2023 11:50 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Leif Lindholm ; > Aktas, Erdem ; Yao, Jiewen ; > Xu, Min M ; Tom Lendacky > ; Michael Roth > Subject: [Patch 1/1]

Re: [edk2-devel] [PATCH v2 2/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix MISSING_BREAK Coverity issues

As mentioned in the commit message, the comment helps in making it explicit and evident that the missing break is not a human miss, but intentional. Hence, the comment should be considered as being added for the human code readers / developers. So even if some static analysis tool flags such an

[edk2-devel] [Patch 1/1] Maintainers.txt: Remove unused OvmfPkg Confidential Computing path

The following commit removed PlatformBootManagerLibGub from OvmfPkg. Update Maintainers.txt to remove reference to deleted directory. https://github.com/tianocore/edk2/commit/6fb2760dc8939b16a906b8e6bb224764907168f3 Cc: Andrew Fish Cc: Leif Lindholm Cc: Erdem Aktas Cc: Jiewen Yao Cc: Min Xu

Re: [edk2-devel] [PATCH v8 0/5] Cache Management Operations Support For RISC-V

On Tue, Nov 07, 2023 at 07:04:58PM +0100, Laszlo Ersek wrote: > On 11/7/23 08:15, Sunil V L wrote: > > On Mon, Nov 06, 2023 at 08:23:51AM +0530, Dhaval wrote: > >> Implementing code to support Cache Management Operations (CMO) defined by > >> RISC-V CMO

Re: [edk2-devel] [edk2-platforms][PATCH] Features/IpmiFeaturePkg: Remove IpmiCommandLib from IpmiFeaturePkg

[AMD Official Use Only - General] Hi Nate and Liming, Please check this patch. The one under IpmiFeaturePkg is an old one, we should remove it to avoid the confusions. Thanks Abner > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent:

Re: [edk2-devel] [PATCH v3] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Hi @Liming Gao, @Kinney, Michael D > If the patch is sent before Soft Feature Freeze, and plans to catch this > stable tag, the patch contributor need reply to his patch and notify edk2 > community We would like to

[edk2-devel] [PATCH v3 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Change CR4.CET bit only

Do not use fixed CR4 value 0x668, change CR4.CET bit only. Signed-off-by: Sheng Wei Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Wu Jiaxin Cc: Tan Dun --- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.nasm | 9 ++--- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 3 ++- 2 files changed, 8

[edk2-devel] [PATCH v3 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Clear CR4.CET before restoring MSR IA32_S_CET

Clear CR4.CET bit before restoring MSR IA32_S_CET. Backup/restore MSR IA32_U_CET in SMI. Signed-off-by: Sheng Wei Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Wu Jiaxin Cc: Tan Dun --- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.nasm | 53 ---

[edk2-devel] [PATCH v3 0/2] UefiCpuPkg/PiSmmCpuDxeSmm: Clear CR4.CET before

Patch V3: Remove the 3rd patch. mSmmInterruptSspTables is a global variable. It is unnecessary to initializ it to zero manually. Patch V2: No function change with Patch V1. Split the patch to into 3 separate patches. Sheng Wei (2): UefiCpuPkg/PiSmmCpuDxeSmm: Clear CR4.CET before

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear CR4.CET before restoring MSR IA32_S_CET

Hi Laszlo, Thank you for the review comments. (1) This change is used to fix a hung issue when enable kernel CET-IBT. Kernel will enable CET-IBT by set IA32_U_CET.bit2. The issue only happens when it enters SMI with the state machine == WAIT_FOR_ENDBRANCH state. In SMI handler, when Set CR4.CET

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Fix typos

Keep the upper case: @@ -870,7 +870,7 @@ BcfgAdd ( } /** - Funciton to remove an item. + function to remove an item. @param[in] Target The target item to move. @param[in] CurrentOrder The pointer to the current order of items. @@ -934,7 +934,7 @@ BcfgRemove ( } /** -

Re: [edk2-devel] [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Fix CP Exception when CET enable

Hi Liming & Mike & Ray, Could you help approve this change for the coming edk2 stable tag? This is critical bug fix in smm cpu driver to handler the CET check failure, I think we need this change for the stable tag. Thanks, Jiaxin > -Original Message- > From: Laszlo Ersek > Sent:

Re: [edk2-devel] [PATCH v2] MdeModulePkg/PciHostBridgeDxe: Add readback after final Cfg-Write

Hi Jose, 1. This logic needs to move into an AARCH64 specific directory/file. Other architectures handle this in other ways. 2. There are many places throughout edk2 sources that perform PCI config write operations. You are only fixing it in a single location. You may want to look at

Re: [edk2-devel] [PATCH v3] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Igor Kulchytskyy > Sent: Tuesday, November 7, 2023 8:06 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Nickle Wang > > Subject: [PATCH v3] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 >

Re: [edk2-devel] question about cxl device enumeration in pci bus driver

I see a long discussion on lore.kernel.org: https://lore.kernel.org/linux-cxl/byapr12mb3336f5addedbb6245bc2b48dbd...@byapr12mb3336.namprd12.prod.outlook.com/T/ This document also has some info on how CXL hotplug is handled:

Re: [edk2-devel] [PATCH v2] MdeModulePkg/PciHostBridgeDxe: Add readback after final Cfg-Write

++ Laszlo and Michael On Tue, Nov 7, 2023 at 10:54 AM Jose Lopez wrote: > ++ CC'd > > > On Mon, Nov 6, 2023 at 6:02 PM Joe Lopez wrote: > >> From: joelopez333 >> >> REF:https://edk2.groups.io/g/devel/topic/102310377#110456 >> >> Problem Report: >> >> On AARCH64, there is no

Re: [edk2-devel] [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Fix CP Exception when CET enable

On 11/7/23 02:24, Wu, Jiaxin wrote: > Root cause: > 1. Before DisableReadonlyPageWriteProtect() is called, the return > address (#1) is pushed in shadow stack. > 2. CET is disabled. > 3. DisableReadonlyPageWriteProtect() returns to #1. > 4. Page table is modified. > 5.

Re: [edk2-devel] [PATCH v2] MdeModulePkg/PciHostBridgeDxe: Add readback after final Cfg-Write

++ CC'd On Mon, Nov 6, 2023 at 6:02 PM Joe Lopez wrote: > From: joelopez333 > > REF:https://edk2.groups.io/g/devel/topic/102310377#110456 > > Problem Report: > > On AARCH64, there is no ordering guarantee between configuration > space (ECAM) writes and memory space reads

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/PiSmmCpuDxeSmm: Use processor extended information

On 11/7/23 19:40, Laszlo Ersek wrote: > On 11/7/23 03:43, Wu, Jiaxin wrote: >> Processor extended information is filled when >> CPU_V2_EXTENDED_TOPOLOGY is set in parameter ProcessorNumber >> from GetProcessorInfo() (See commit: 1fadd18d). >> >> This filed value is retrieved from CPUID leaf 1FH,

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/PiSmmCpuDxeSmm: Use processor extended information

On 11/7/23 03:43, Wu, Jiaxin wrote: > Processor extended information is filled when > CPU_V2_EXTENDED_TOPOLOGY is set in parameter ProcessorNumber > from GetProcessorInfo() (See commit: 1fadd18d). > > This filed value is retrieved from CPUID leaf 1FH, which is > a preferred superset to leaf 0BH.

Re: [edk2-devel] [PATCH v8 0/5] Cache Management Operations Support For RISC-V

On 11/7/23 08:15, Sunil V L wrote: > On Mon, Nov 06, 2023 at 08:23:51AM +0530, Dhaval wrote: >> Implementing code to support Cache Management Operations (CMO) defined by >> RISC-V CMO instructions.https://github.com/riscv/riscv-CMOs >> This is a re-write of original series v5. >> The patchset

Re: [edk2-devel] [PATCH v2 2/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix MISSING_BREAK Coverity issues

This comment style only works with Coverity. Other static analysis tools may flag the same issue again. It is better to update the logic so no static analysis tool will flag this issue. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: Tuesday,

Re: [edk2-devel] [PATCH v2 2/2] FatPkg/EnhancedFatDxe: Fix OVERFLOW_BEFORE_WIDEN Coverity issue

On 11/7/23 07:28, Ranbir Singh wrote: > From: Ranbir Singh > > The function FatInitializeDiskCache evaluates an expression > > FAT_DATACACHE_GROUP_COUNT << DiskCache[CacheData].PageAlignment > > and assigns it to DataCacheSize which is of type UINTN. > > As per Coverity report, >

Re: [edk2-devel] [PATCH v2 1/2] FatPkg/EnhancedFatDxe: Fix SIGN_EXTENSION Coverity issues

On 11/7/23 07:28, Ranbir Singh wrote: > From: Ranbir Singh > > The functions FatGetDirEntInfo and FatOpenDirEnt contains the code > statements > > Cluster= (Entry->FileClusterHigh << 16) | > Entry->FileCluster; > and > OFile->FileCluster =

Re: [edk2-devel] [PATCH v2 5/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix UNUSED_VALUE Coverity issues

On 11/7/23 07:19, Ranbir Singh wrote: > The return value after calls to functions > gBS->UninstallMultipleProtocolInterfaces, StartPciDevicesOnBridge, > PciPciDeviceInfoCollector, BarExisted, PciRootBridgeIo->Pci.Write, > gPciHotPlugInit->InitializeRootHpc and PciRootBridgeP2CProcess is > stored

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Resolve invalid escape sequence

Reviewed-by: Rebecca Cran On 10/31/2023 12:23 AM, Joey Vagedes wrote: Resolves an invalid escape sequence in a regex string that occurs because the string was not marked as a raw string, so backslash characters create unexpected escape sequences. This was brought to light due to Python 3.12

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

On 11/7/23 07:19, Ranbir Singh wrote: > From: Ranbir Singh > > The function StartPciDevices has a check > > ASSERT (RootBridge != NULL); > > but this comes into play only in DEBUG mode. In Release mode, there > is no handling if the RootBridge value is NULL and the code proceeds > to

Re: [edk2-devel] [PATCH v2 3/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix ARRAY_VS_SINGLETON Coverity issues

On 11/7/23 07:19, Ranbir Singh wrote: > From: Ranbir Singh > > The function PciHostBridgeResourceAllocator is not making use of the > generic approach as is used in one of the other function namely - > DumpResourceMap. As a result, the following warnings can be seen as > reported by Coverity

Re: [edk2-devel] [PATCH v2 2/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix MISSING_BREAK Coverity issues

On 11/7/23 07:19, Ranbir Singh wrote: > From: Ranbir Singh > > The function UpdatePciInfo has switch-case code in which there are fall > through from case 32: to case 64:. While this is seeemingly intentional, > it is not evident to any general code reader why there is no break; in > between.

Re: [edk2-devel] [PATCH v2 1/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix DEADCODE Coverity issue

On 11/7/23 07:19, Ranbir Singh wrote: > From: Ranbir Singh > > The function PciHotPlugRequestNotify has two if blocks towards the end > of function both containing return. Due to the parameter checks ensured > at the beginning of the function, one of the two if blocks is bound to > come in

Re: [edk2-devel] [PATCH v2 2/2] MdeModulePkg/Bus/Pci/XhciDxe: Fix MISSING_BREAK Coverity issues

On 11/7/23 06:58, Ranbir Singh wrote: > From: Ranbir Singh > > The functions > XhcInitializeEndpointContext and XhcInitializeEndpointContext64 has > a switch-case code in which the case USB_ENDPOINT_CONTROL: falls > through to default: > > While this may be intentional, it is not evident to any

Re: [edk2-devel] [PATCH v2 1/2] MdeModulePkg/Bus/Pci/XhciDxe: Fix FORWARD_NULL Coverity issues

On 11/7/23 06:57, Ranbir Singh wrote: > From: Ranbir Singh > > The functions UsbHcGetHostAddrForPciAddr, UsbHcGetPciAddrForHostAddr > and UsbHcFreeMem do have > > ASSERT ((Block != NULL)); > > statements after for loop, but these are applicable only in DEBUG mode. > In RELEASE mode, if for

Re: [edk2-devel] [PATCH v3 1/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: Fix REVERSE_INULL Coverity issue

On 11/7/23 16:52, Laszlo Ersek wrote: > On 11/7/23 06:38, Ranbir Singh wrote: >> From: Ranbir Singh >> >> The function USBMouseDriverBindingStart do have >> >> ASSERT (UsbMouseDevice != NULL); >> >> after AllocateZeroPool, but it is applicable only in DEBUG mode. >> In RELEASE mode, if for

Re: [edk2-devel] [PATCH v3 1/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: Fix REVERSE_INULL Coverity issue

On 11/7/23 06:38, Ranbir Singh wrote: > From: Ranbir Singh > > The function USBMouseDriverBindingStart do have > > ASSERT (UsbMouseDevice != NULL); > > after AllocateZeroPool, but it is applicable only in DEBUG mode. > In RELEASE mode, if for whatever reasons UsbMouseDevice is NULL > at

Re: [edk2-devel] [PATCH v2 2/2] MdeModulePkg/Bus/Pci/PciHostBridgeDxe: Fix MISSING_BREAK Coverity issue

On 11/7/23 06:06, Ranbir Singh wrote: > From: Ranbir Singh > > The function SubmitResources has a switch-case code in which the > case ACPI_ADDRESS_SPACE_TYPE_MEM: which falls through to > case ACPI_ADDRESS_SPACE_TYPE_IO: if there is no scenario of > return EFI_INVALID_PARAMETER; > > While this

Re: [edk2-devel] [PATCH v2 1/2] MdeModulePkg/Bus/Pci/PciHostBridgeDxe: Fix OVERRUN Coverity issues

Hi Ranbir, On 11/7/23 06:06, Ranbir Singh wrote: > From: Ranbir Singh > > The function NotifyPhase has a check > > ASSERT (Index < TypeMax); > > but this comes into play only in DEBUG mode. In Release mode, there is > no handling if the Index value is within array limits or not. If for >

Re: [edk2-devel] [Patch v2 1/1] Maintainers.txt: Remove Orphan status option

On 2023-11-05 20:04, Michael D Kinney wrote: We would like any proposed change in the edk2 codebase to be assignable to a human maintainer/reviewer. If there is a feature for which there is no longer any support, we should find a way to remove it from the head of the repository. For critical

Re: [edk2-devel] [PATCH v3] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

> On 7. 11. 2023., at 15:06, Igor Kulchytskyy via groups.io > wrote: > > Supported function of the driver changed to wait for all newtwork > interface to be installed. > Filer out the network interfaces which are not supported by > Redfish Host Interface. > > Cc: Abner Chang > Cc: Nickle

Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-regs-only for AArch64 CLANGDWARF

Liming, You reviewed this patch before the stable tag. Am I OK to stage a github PR for this change? Reviewed-by: Leif Lindholm Regards, Leif On 2023-11-07 13:11, Yeping Song (QUIC) wrote: Hi all, I would like for this to be include in stable tag. Please help to review and merge this

Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-regs-only for AArch64 CLANGDWARF

Hi all, I would like for this to be include in stable tag. Please help to review and merge this patch into stable release. Thanks Yepings -Original Message- From: devel@edk2.groups.io On Behalf Of Yeping Song Sent: Saturday, November 4, 2023 12:38 AM To: devel@edk2.groups.io Cc: Yeping

Re: [edk2-devel] [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Fix CP Exception when CET enable

On 11/7/23 13:01, Wu, Jiaxin wrote: > Hi Ray & Laszlo, > > Any more comments to this? It's in my review queue. Laszlo > > Thanks, > Jiaxin > >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Wu, >> Jiaxin >> Sent: Tuesday, November 7, 2023 9:25 AM >> To:

Re: [edk2-devel] [PATCH v3] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Thanks for fixing this issue. This version looks good to me. I test it on my system and it works well. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Igor Kulchytskyy > Sent: Tuesday, November 7, 2023 8:06 PM > To: devel@edk2.groups.io > Cc: Abner Chang ;

Re: [edk2-devel] Use dynamic pcd in smm mode

On 11/7/23 12:31, Yoshinoya wrote: > Hi, All: > Could dynamic PCD be used in smm driver code? > > It seems pcd has pei/dxe drivers, but not have smm related infrastructur > drivers. Dynamic PCDs (or more generally, DXE protocols) can be used in the entry point functions of DXE_SMM_DRIVER

[edk2-devel] [PATCH v3] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Supported function of the driver changed to wait for all newtwork interface to be installed. Filer out the network interfaces which are not supported by Redfish Host Interface. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Igor Kulchytskyy ---

Re: 回复: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix clang error

On 11/6/23 01:59, gaoliming wrote: > Laszlo： > I agree your suggestion. We can submit a new request to update oniguruma to > the latest version. > > This patch avoids the warning on the current version. I think this change > is OK. I would like to merge this fix first. OK. Filed this

Re: [edk2-devel] [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Fix CP Exception when CET enable

Hi Ray & Laszlo, Any more comments to this? Thanks, Jiaxin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wu, > Jiaxin > Sent: Tuesday, November 7, 2023 9:25 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Zeng, Star > ; Gerd Hoffmann ; Kumar, Rahul R > ;

Re: [edk2-devel] [Patch v2 1/1] Maintainers.txt: Remove Orphan status option

On 11/5/23 21:04, Michael D Kinney wrote: > We would like any proposed change in the edk2 codebase to be > assignable to a human maintainer/reviewer. If there is a feature > for which there is no longer any support, we should find a way > to remove it from the head of the repository. For critical

Re: [edk2-devel] [PATCH v1 7/7] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SmmCpuSyncLib

Thanks Laszlo, much appreciate all comments. I will check one by one for fix in next version. /Jiaxin > -Original Message- > From: Laszlo Ersek > Sent: Tuesday, November 7, 2023 7:01 PM > To: devel@edk2.groups.io; Wu, Jiaxin > Cc: Dong, Eric ; Ni, Ray ; Zeng, Star > ; Gerd Hoffmann ;

[edk2-devel] Use dynamic pcd in smm mode

Hi, All: Could dynamic PCD be used in smm driver code? It seems pcd has pei/dxe drivers, but not have smm related infrastructur drivers. Thanks -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110842):

Re: [edk2-devel] [PATCH v1 7/7] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SmmCpuSyncLib

On 11/3/23 16:30, Wu, Jiaxin wrote: > There is the SmmCpuSyncLib Library class define the SMM CPU sync > flow, which is aligned with existing SMM CPU driver sync behavior. > This patch is to consume SmmCpuSyncLib instance directly. > > With this change, SMM CPU Sync flow/logic can be customized >

Re: [edk2-devel] [PATCH v1 5/7] OvmfPkg: Specifies SmmCpuSyncLib instance

On 11/3/23 16:30, Wu, Jiaxin wrote: > The SmmCpuSyncLib instance is included in UefiCpuLibs.dsc.inc. > This patch is to specify SmmCpuSyncLib instance in OvmfPkg by > using "!include UefiCpuPkg/UefiCpuLibs.dsc.inc". > > Change-Id: I2ab1737425e26a7bfc4f564b3b7f15ca5c2268fb > Cc: Ard Biesheuvel >

Re: [edk2-devel] [PATCH v1 4/7] UefiCpuPkg: Implements SmmCpuSyncLib library instance

On 11/3/23 16:30, Wu, Jiaxin wrote: > diff --git a/UefiCpuPkg/UefiCpuLibs.dsc.inc b/UefiCpuPkg/UefiCpuLibs.dsc.inc > new file mode 100644 > index 00..6b9b362729 > --- /dev/null > +++ b/UefiCpuPkg/UefiCpuLibs.dsc.inc > @@ -0,0 +1,15 @@ > +## @file > +# UefiCpu DSC include file for

Re: [edk2-devel] [PATCH v1 4/7] UefiCpuPkg: Implements SmmCpuSyncLib library instance

On 11/3/23 16:30, Wu, Jiaxin wrote: > Implements SmmCpuSyncLib Library class. The instance follows the > existing SMM CPU driver (PiSmmCpuDxeSmm) sync implementation: > 1.Abstract Counter and Run semaphores into SmmCpuSyncCtx. > 2.Abstract CPU arrival count operation to >

Re: [edk2-devel] [PATCH v1 3/7] UefiCpuPkg: Adds SmmCpuSyncLib library class

On 11/7/23 11:26, Laszlo Ersek wrote: > Furthermore, counts of objects should be generally represented as UINTN > values, unless you have a good (explained!) reason for using a different > type. If the argument is that we need atomics for manipulating CPU counts, and that we don't want to assume

Re: [edk2-devel] [PATCH v1 1/7] UefiCpuPkg/PiSmmCpuDxeSmm: Optimize Semaphore Sync between BSP and AP

On 11/7/23 09:28, Laszlo Ersek wrote: > On 11/3/23 16:30, Wu, Jiaxin wrote: >> This patch is to define 3 new functions (WaitForBsp & ReleaseBsp & >> ReleaseOneAp) used for the semaphore sync between BSP & AP. With the >> change, BSP and AP Sync flow will be easy understand as below: >> BSP:

Re: [edk2-devel] [PATCH v1] OvmfPkg/PlatformInitLib: Don't override user specified PciMmio64Size

Hi, > > Strictly speaking you don't care that much about the size of the mmio > > window, but where it gets placed. Moving it to the end of the vcpu > > address space is what breaks your use case in case the iommu address > > space happens to be too small for that. > Right, the crux of the

Re: [edk2-devel] [PATCH v1 3/7] UefiCpuPkg: Adds SmmCpuSyncLib library class

On 11/3/23 16:30, Wu, Jiaxin wrote: > Intel is planning to provide different SMM CPU Sync implementation > along with some specific registers to improve the SMI performance, > hence need SmmCpuSyncLib Library for Intel. > > This patch is to: > 1.Adds SmmCpuSyncLib Library class in UefiCpuPkg.dec.

Re: [edk2-devel] [PATCH v2 20/30] OvmfPkg/LoongArchVirt: Add serial port library

Hi Gerd, These two libraries is not only copy code, the way of obtain the serial base address is different from ARM, and the early serial port output also different from ARM, so these two libraries are LoongArch specific. Thanks, Chao 在 2023/11/7 17:47, Gerd Hoffmann 写道: On Mon, Nov 06,

Re: [edk2-devel] [PATCH v2 17/30] OvmfPkg/LoongArchVirt: Add PciCpuIo2Dxe module

Hi Gerd, Yes, you are right, this driver could probably be located somewhere else where other ARCH can easily use it, but I can not find the right place, maybe MdeModulePkg or MdePkg? I also feel that something is not quite right about these two places... Thanks, Chao 在 2023/11/7 17:42,

Re: [edk2-devel] [PATCH 0/2] SEV-SNP guest support fixes

On Mon, Nov 06, 2023 at 04:45:29PM -0600, Tom Lendacky wrote: > This patch series provides fixes around AP startup and sorting: > > - The CPUID_EXTENDED_TOPOLOGY CPUID leaf takes a sub-leaf as input. The > current SEV-SNP support is attempting to retrieve the this leaf with > sub-leaf 0, but

Re: [edk2-devel] [PATCH v2 20/30] OvmfPkg/LoongArchVirt: Add serial port library

On Mon, Nov 06, 2023 at 11:29:45AM +0800, Chao Li wrote: > Add two libraries named Fdt16550SerialPortHookLib and > EarlyFdtSerialPortLib16550, requested by LoongArch virtual > machine. Moving libs from ArmVirtPkg to OvmfPkg (so non-arm archs can use the libs too) is perfectly fine. I think this

Re: [edk2-devel] [PATCH v1 2/7] UefiCpuPkg/PiSmmCpuDxeSmm: Reduce times of BSP and AP Sync for SMM Exit

On 11/3/23 16:30, Wu, Jiaxin wrote: > After review, there are unnecessary steps for BSP and AP sync for SMM > exit. This patch is to reduce one round BSP and AP sync so as to improve > SMI performance: > BSP: WaitForAllAPs <-- AP: ReleaseBsp > BSP: ReleaseAllAPs --> AP: WaitForBsp > > Change-Id:

Re: [edk2-devel] [PATCH v2 17/30] OvmfPkg/LoongArchVirt: Add PciCpuIo2Dxe module

On Mon, Nov 06, 2023 at 11:29:20AM +0800, Chao Li wrote: > Add PciCpuIo2Dxe for LoongArch, this module is similar to > ArmPciCpuIo2Dxe drvier. What are the differences to ArmPciCpuIo2Dxe? On a quick glance I can't see anything arch-specific here. Maybe we should find a better place for

Re: [edk2-devel] [PATCH v2 16/30] ArmVirtPkg: Move PCD of FDT base address and FDT padding to OvmfPkg

On Mon, Nov 06, 2023 at 11:29:12AM +0800, Chao Li wrote: > Moved PcdDeviceTreeInitialBaseAddress and PcdDeviceTreeAllocationPadding > to OvmfPkg for easier use by other architectures. > > Build-tested only (with "ArmVirtQemu.dsc"). > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584

Re: [edk2-devel] [PATCH v1 6/7] CryptoPkg/OpensslLib: Add AArch64Cap for arch specific hooks

> [Sources.AARCH64] > + OpensslStub/AArch64Cap.c > # Autogenerated files list starts here >$(OPENSSL_PATH)/crypto/aes/aes_cbc.c >$(OPENSSL_PATH)/crypto/aes/aes_cfb.c > @@ -1598,7 +1599,7 @@ [Sources.AARCH64] >$(OPENSSL_PATH)/crypto/kdf/kdf_err.c >

Re: [edk2-devel] [PATCH V2 0/2] OvmfPkg: Update TdVmCall to handle the retry for MapGPA

On Thu, Nov 02, 2023 at 05:09:55PM +0800, sunceping wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4572 > > According to section 3.2 of the [GHCI] spec, if the result is > "TDG.VP.VMCALL_RETRY" for TDG.VP.VMCALL.MapGPA, TD must retry the > mapping for the pages in the region

Re: [edk2-devel] [PATCH v2 16/30] ArmVirtPkg: Move PCD of FDT base address and FDT padding to OvmfPkg

Hi Ard, Leif, Sami, Gerd and Jordan, Could you please to review this patch? Thanks, Chao 在 2023/11/6 11:29, Chao Li 写道: Moved PcdDeviceTreeInitialBaseAddress and PcdDeviceTreeAllocationPadding to OvmfPkg for easier use by other architectures. Build-tested only (with "ArmVirtQemu.dsc").

Re: [edk2-devel] [PATCH v2 15/30] EmbeddedPkg: Add PcdPrePiCpuIoSize width for LOONGARCH64

Hi Leif, Ard, Abner and Daniel, Could you please to review this patch? Thanks, Chao 在 2023/11/6 11:29, Chao Li 写道: Added LoongArch64 architecture CPU IO width. https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer

Re: [edk2-devel] [PATCH v1 1/7] UefiCpuPkg/PiSmmCpuDxeSmm: Optimize Semaphore Sync between BSP and AP

On 11/3/23 16:30, Wu, Jiaxin wrote: > This patch is to define 3 new functions (WaitForBsp & ReleaseBsp & > ReleaseOneAp) used for the semaphore sync between BSP & AP. With the > change, BSP and AP Sync flow will be easy understand as below: > BSP: ReleaseAllAPs or ReleaseOneAp --> AP: WaitForBsp >

Re: [edk2-devel] [PATCH v2 2/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix MISSING_BREAK Coverity issues

Reviewed-by: Ray Ni Thanks, Ray From: Ranbir Singh Sent: Tuesday, November 7, 2023 2:19 PM To: devel@edk2.groups.io ; rsi...@ventanamicro.com Cc: Ni, Ray ; Veeresh Sangolli Subject: [PATCH v2 2/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix MISSING_BREAK Coverity