Re: [edk2-devel] [PATCH v3 0/5] BaseTools/Scripts/GetMaintainer: Handle reviewer only case

2023-11-10 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/pull/5033 > -Original Message- > From: Rebecca Cran > Sent: Friday, November 10, 2023 12:36 PM > To: Leif Lindholm ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Feng, Bob C ; Chen, > Christine > Subject: Re: [PATCH v3 0/5]

[edk2-devel] [PATCH] OvmfPkg/MemEncryptSevLib: Fix address overflow during PVALIDATE

2023-11-10 Thread Roth, Michael via groups.io
The struct used for GHCB-based page-state change requests uses a 40-bit bit-field for the GFN, which is shifted by PAGE_SHIFT to generate a 64-bit address. However, anything beyond 40-bits simply gets shifted off when doing this, which will cause issues when dealing with 1TB+ addresses. Fix this

Re: [edk2-devel] [PATCH 00/37] OvmfPkg: remove the CSM (after edk2-stable202311)

2023-11-10 Thread Yao, Jiewen
Glad to see we can get rid of the legacy burden. All: Reviewed-by: Jiewen Yao > -Original Message- > From: Laszlo Ersek > Sent: Saturday, November 11, 2023 7:58 AM > To: devel@edk2.groups.io > Cc: Anatol Belski ; Warkentin, Andrei > ; Anthony Perard ; > Ard Biesheuvel ; Corvin Köhne >

[edk2-devel] [PATCH 36/37] OvmfPkg: remove Pcd8259LegacyModeEdgeLevel and Pcd8259LegacyModeMask

2023-11-10 Thread Laszlo Ersek
The following PCDs are unused at this point; remove them: - Pcd8259LegacyModeEdgeLevel - Pcd8259LegacyModeMask This shrinks the list of resources scheduled for removal to nil. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Michael Roth Cc: Min

[edk2-devel] [PATCH 37/37] OvmfPkg: remove CSM_ENABLE build macro

2023-11-10 Thread Laszlo Ersek
At this point, the CSM_ENABLE conditionals only bracket the !error directives that we added at the front of this series; it's time to remove CSM_ENABLE. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Corvin Köhne Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Rebecca Cran Ref:

[edk2-devel] [PATCH 35/37] OvmfPkg: remove gEfiLegacy8259ProtocolGuid

2023-11-10 Thread Laszlo Ersek
At this point, gEfiLegacy8259ProtocolGuid is unused; remove it. This shrinks the list of resources scheduled for removal to: - PCDs: - Pcd8259LegacyModeEdgeLevel - Pcd8259LegacyModeMask Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Ref:

[edk2-devel] [PATCH 34/37] OvmfPkg: remove 8259InterruptControllerDxe

2023-11-10 Thread Laszlo Ersek
8259InterruptControllerDxe is not used by any platforms at this point, remove it. This patch removes mentions of the following CSM resources from the source code: - GUIDs (protocols or otherwise): - gEfiLegacy8259ProtocolGuid - headers: - Protocol/Legacy8259.h - PCDs: -

[edk2-devel] [PATCH 33/37] OvmfPkg: exclude 8259InterruptControllerDxe

2023-11-10 Thread Laszlo Ersek
With 8254TimerDxe gone, no module in OVMF consumes gEfiLegacy8259ProtocolGuid; exclude 8259InterruptControllerDxe therefore. Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/OvmfPkgIa32.dsc

[edk2-devel] [PATCH 32/37] OvmfPkg: remove 8254TimerDxe

2023-11-10 Thread Laszlo Ersek
8254TimerDxe is not used by any platforms at this point, remove it. This patch removes mentions of the following CSM resources from the source code: - GUIDs (protocols or otherwise): - gEfiLegacy8259ProtocolGuid - headers: - Protocol/Legacy8259.h which extends the list of resources

[edk2-devel] [PATCH 30/37] OvmfPkg: remove Csm16

2023-11-10 Thread Laszlo Ersek
Csm16 is not used by any platform at this point, remove it. This shrinks the list of resources scheduled for removal to: - GUIDs (protocols or otherwise): - gEfiLegacy8259ProtocolGuid - headers: - Protocol/Legacy8259.h Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Ref:

[edk2-devel] [PATCH 29/37] OvmfPkg: remove Rule.Common.USER_DEFINED.CSM from all FDF files

2023-11-10 Thread Laszlo Ersek
We no longer have INF RuleOverride=CSM OvmfPkg/Csm/Csm16/Csm16.inf lines in any of the OVMF platform FDF files; remove the CSM rules themselves. (Note that some of the more recent platforms had cargo-culted this rule from the original ones, without ever referencing the rule with

[edk2-devel] [PATCH 28/37] OvmfPkg: exclude Csm16.inf / Csm16.bin

2023-11-10 Thread Laszlo Ersek
The Csm16 module wraps the CONFIG_CSM build of SeaBIOS. "Csm16.inf" has FILE_GUID 1547B4F3-3E8A-4FEF-81C8-328ED647AB1A, which was previously referenced by the (now removed) CsmSupportLib, under the name SYSTEM_ROM_FILE_GUID. Nothing relies on the SeaBIOS binary any longer, so exclude the Csm16

[edk2-devel] [PATCH 31/37] OvmfPkg: exclude 8254TimerDxe

2023-11-10 Thread Laszlo Ersek
In the original three OVMF platforms, CSM_ENABLE selects the legacy timer driver; exclude it. Instead, include LocalApicTimerDxe unconditionally (which in turn consumes PcdFSBClock). Background: commits c37cbc030d96 ("OvmfPkg: Switch timer in build time for OvmfPkg", 2022-04-02) and 07c0c2eb0a59

[edk2-devel] [PATCH 27/37] OvmfPkg: remove

2023-11-10 Thread Laszlo Ersek
The header is not used by any source file at this point, remove it. is a thin wrapper for including all header files under the "OvmfPkg/Csm/Include/Framework" directory. Remove that directory at the same time (nothing else references contents in that directory directly). Consequently, the

[edk2-devel] [PATCH 26/37] OvmfPkg: remove gEfiLegacyInterruptProtocolGuid

2023-11-10 Thread Laszlo Ersek
At this point, gEfiLegacyInterruptProtocolGuid is unused; remove it. This shrinks the list of resources scheduled for removal to: - GUIDs (protocols or otherwise): - SYSTEM_ROM_FILE_GUID (1547B4F3-3E8A-4FEF-81C8-328ED647AB1A) - gEfiLegacy8259ProtocolGuid - headers: - FrameworkDxe.h -

[edk2-devel] [PATCH 25/37] OvmfPkg: remove gEfiLegacyBiosProtocolGuid

2023-11-10 Thread Laszlo Ersek
At this point, gEfiLegacyBiosProtocolGuid is unused; remove it. This shrinks the list of resources scheduled for removal to: - GUIDs (protocols or otherwise): - SYSTEM_ROM_FILE_GUID (1547B4F3-3E8A-4FEF-81C8-328ED647AB1A) - gEfiLegacy8259ProtocolGuid - gEfiLegacyInterruptProtocolGuid -

[edk2-devel] [PATCH 22/37] OvmfPkg: remove CsmSupportLib

2023-11-10 Thread Laszlo Ersek
CsmSupportLib is not used by any platform at this point, remove it. This patch removes mentions of the following CSM resources from the source code [*]: - GUIDs (protocols or otherwise): - SYSTEM_ROM_FILE_GUID (1547B4F3-3E8A-4FEF-81C8-328ED647AB1A) - gEfiFirmwareVolumeProtocolGuid (by

[edk2-devel] [PATCH 24/37] OvmfPkg: remove gEfiLegacyBiosPlatformProtocolGuid

2023-11-10 Thread Laszlo Ersek
At this point, gEfiLegacyBiosPlatformProtocolGuid is unused; remove it. This shrinks the list of resources scheduled for removal to: - GUIDs (protocols or otherwise): - SYSTEM_ROM_FILE_GUID (1547B4F3-3E8A-4FEF-81C8-328ED647AB1A) - gEfiLegacy8259ProtocolGuid - gEfiLegacyBiosProtocolGuid -

[edk2-devel] [PATCH 23/37] OvmfPkg: remove gEfiFirmwareVolumeProtocolGuid

2023-11-10 Thread Laszlo Ersek
At this point, gEfiFirmwareVolumeProtocolGuid is unused; remove it. This shrinks the list of resources scheduled for removal to: - GUIDs (protocols or otherwise): - SYSTEM_ROM_FILE_GUID (1547B4F3-3E8A-4FEF-81C8-328ED647AB1A) - gEfiLegacy8259ProtocolGuid - gEfiLegacyBiosPlatformProtocolGuid

[edk2-devel] [PATCH 21/37] OvmfPkg: unplug CsmSupportLib from BdsDxe

2023-11-10 Thread Laszlo Ersek
CsmSupportLib is effectively a hack. It produces the following protocols: - Legacy Bios Platform, - Legacy Interrupt, - Legacy Region2. (Note that the "OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.inf" file contains an error where it claims that "Legacy Bios Platform" is "consumed" -- it is not; the

[edk2-devel] [PATCH 19/37] OvmfPkg: remove gEfiLegacyBiosGuid

2023-11-10 Thread Laszlo Ersek
At this point, gEfiLegacyBiosGuid is unused; remove it. This shrinks the list of resources scheduled for removal to: - GUIDs (protocols or otherwise): - gEfiLegacy8259ProtocolGuid - gEfiLegacyBiosPlatformProtocolGuid - gEfiLegacyBiosProtocolGuid - gEfiLegacyInterruptProtocolGuid -

[edk2-devel] [PATCH 16/37] OvmfPkg: exclude NullMemoryTestDxe driver

2023-11-10 Thread Laszlo Ersek
NullMemoryTestDxe was included in the OVMF platforms in historical commit 999a815e9ff3 ("OvmfPkg: Add NullMemoryTestDxe driver", 2011-01-21). It produces gEfiGenericMemTestProtocolGuid. With LegacyBiosDxe gone, the only consumer of this protocol in all of edk2 is

[edk2-devel] [PATCH 20/37] OvmfPkg: remove LegacyBiosDxe PCDs

2023-11-10 Thread Laszlo Ersek
The following PCDs are unused at this point; remove them: - PcdEbdaReservedMemorySize - PcdEndOpromShadowAddress - PcdHighPmmMemorySize - PcdLegacyBiosCacheLegacyRegion - PcdLowPmmMemorySize - PcdOpromReservedMemoryBase - PcdOpromReservedMemorySize This shrinks the list of resources scheduled

[edk2-devel] [PATCH 18/37] OvmfPkg: remove gEfiIsaAcpiProtocolGuid

2023-11-10 Thread Laszlo Ersek
At this point, gEfiIsaAcpiProtocolGuid is unused; remove it. This shrinks the list of resources scheduled for removal to: - GUIDs (protocols or otherwise): - gEfiLegacy8259ProtocolGuid - gEfiLegacyBiosGuid - gEfiLegacyBiosPlatformProtocolGuid - gEfiLegacyBiosProtocolGuid -

[edk2-devel] [PATCH 17/37] OvmfPkg: remove gEfiIsaIoProtocolGuid

2023-11-10 Thread Laszlo Ersek
At this point, gEfiIsaIoProtocolGuid is unused; remove it. Recursively, this patch removes mentions of the following further CSM resources from the source code: - GUIDs (protocols or otherwise): - gEfiIsaAcpiProtocolGuid (by cutting the link) - headers: - Protocol/IsaAcpi.h This changes

[edk2-devel] [PATCH 14/37] Revert "OvmfPkg: don't assign PCI BARs above 4GiB when CSM enabled"

2023-11-10 Thread Laszlo Ersek
This reverts commit c7341877f69505e69acd199c84b6c09218058bfa. That commit was a later (2019-06-26), heavier weight exclusion of 64-bit BARs when a CSM was included, and is similarly superfluous now, so revert it. Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Ref:

[edk2-devel] [PATCH 12/37] OvmfPkg: exclude LegacyBiosDxe

2023-11-10 Thread Laszlo Ersek
LegacyBiosDxe is the core CSM driver. It procudes gEfiLegacyBiosProtocolGuid, on top of several smaller, more foundational legacy BIOS protocols, whose drivers we've not excluded yet. In the course of tearing down CSM support in (reverse) dependency order, exclude LegacyBiosDxe at this point. Cc:

[edk2-devel] [PATCH 13/37] OvmfPkg/IncompatiblePciDeviceSupportDxe: ignore CSM presence

2023-11-10 Thread Laszlo Ersek
The UEFI protocol database cannot contain gEfiLegacyBiosProtocolGuid any longer, after excluding LegacyBiosDxe from the OVMF platforms. Therefore, instruct PciBusDxe from IncompatiblePciDeviceSupportDxe to allocate 64-bit BARs above 4 GB regardless of a CSM. Regression test: in commit

[edk2-devel] [PATCH 11/37] OvmfPkg: remove Bios Video PCDs

2023-11-10 Thread Laszlo Ersek
PcdBiosVideoSetTextVgaModeEnable, PcdBiosVideoCheckVbeEnable and PcdBiosVideoCheckVgaEnable are unused at this point, remove them. This shrinks the list of resources scheduled for removal to: - GUIDs (protocols or otherwise): - gEfiLegacyBiosGuid - gEfiLegacyBiosProtocolGuid - headers: -

[edk2-devel] [PATCH 10/37] OvmfPkg: remove gEfiVgaMiniPortProtocolGuid

2023-11-10 Thread Laszlo Ersek
At this point, gEfiVgaMiniPortProtocolGuid is unused; remove it. This shrinks the list of resources scheduled for removal to: - GUIDs (protocols or otherwise): - gEfiLegacyBiosGuid - gEfiLegacyBiosProtocolGuid - headers: - FrameworkDxe.h - Guid/LegacyBios.h - Protocol/LegacyBios.h -

[edk2-devel] [PATCH 08/37] OvmfPkg: exclude the CSM-based VideoDxe driver

2023-11-10 Thread Laszlo Ersek
The CSM-based VideoDxe driver is a special UEFI_DRIVER module that both follows and doesn't follow the UEFI driver model. Namely, in the Supported and Start members of its Driver Binding Protocol instance, it consumes the Legacy Bios Protocol directly from the UEFI protocol database, as opposed

[edk2-devel] [PATCH 06/37] OvmfPkg: remove LegacyBootMaintUiLib

2023-11-10 Thread Laszlo Ersek
LegacyBootMaintUiLib is not used by any platform at this point, remove it. This patch removes mentions of the following CSM resources from the source code: - GUIDs (protocols or otherwise): - gEfiLegacyBiosProtocolGuid - gEfiLegacyDevOrderVariableGuid - headers: - Guid/LegacyDevOrder.h

[edk2-devel] [PATCH 07/37] OvmfPkg: remove gEfiLegacyDevOrderVariableGuid

2023-11-10 Thread Laszlo Ersek
At this point, gEfiLegacyDevOrderVariableGuid is unused; remove it. This shrinks the list of resources scheduled for removal to: - GUIDs (protocols or otherwise): - gEfiLegacyBiosProtocolGuid - headers: - Protocol/LegacyBios.h Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Ref:

[edk2-devel] [PATCH 05/37] OvmfPkg: unplug LegacyBootMaintUiLib from UiApp

2023-11-10 Thread Laszlo Ersek
LegacyBootMaintUiLib registers a form (HII Config Access Protocol instance) with UiApp, for configuring legacy boot options; stop plugging it into UiApp. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Corvin Köhne Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Rebecca Cran Ref:

[edk2-devel] [PATCH 04/37] OvmfPkg: remove LegacyBootManagerLib

2023-11-10 Thread Laszlo Ersek
LegacyBootManagerLib is not used by any platform at this point, remove it. This patch removes mentions of the following CSM resources from the source code: - GUIDs (protocols or otherwise): - gEfiLegacyBiosProtocolGuid - gEfiLegacyDevOrderVariableGuid - headers: - Guid/LegacyDevOrder.h

[edk2-devel] [PATCH 03/37] OvmfPkg: unplug LegacyBootManagerLib from BdsDxe and UiApp

2023-11-10 Thread Laszlo Ersek
Don't register the LegacyBmRefreshAllBootOption() and LegacyBmBoot() functions in BdsDxe and UiApp. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Corvin Köhne Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Rebecca Cran Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek

[edk2-devel] [PATCH 02/37] OvmfPkg: remove PcdCsmEnable

2023-11-10 Thread Laszlo Ersek
PcdCsmEnable was introduced in commits 50f911d25d39 ("OvmfPkg: introduce PcdCsmEnable feature flag", 2020-02-05) and 75839f977d37 ("OvmfPkg/PlatformPei: detect SMRAM at default SMBASE (for real)", 2020-02-05). Remove it, and substitute constant FALSE wherever it has been evaluated thus far.

[edk2-devel] [PATCH 01/37] OvmfPkg: cripple CSM_ENABLE macro

2023-11-10 Thread Laszlo Ersek
We're going to gradually tear down and remove the Compatibility Support Module (CSM) in OvmfPkg (due to it having no maintainer). Start by making all platforms that have thus far accepted "-D CSM_ENABLE" reject that macro, so that mid-series, the partially removed infrastructure cannot be built or

[edk2-devel] [PATCH 00/37] OvmfPkg: remove the CSM (after edk2-stable202311)

2023-11-10 Thread Laszlo Ersek
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 CI: https://github.com/tianocore/edk2/pull/5031 (@ 961d5add9f03) Remove the Compatibility Support Module (CSM) from OVMF (after edk2-stable202311). Modify the following platforms: OvmfPkg/AmdSev/AmdSevX64.dsc OvmfPkg/Bhyve/BhyveX64.dsc

Re: [edk2-devel] [PATCH v3 0/5] BaseTools/Scripts/GetMaintainer: Handle reviewer only case

2023-11-10 Thread Rebecca Cran
For the series: Acked-by: Rebecca Cran On 11/10/23 12:30, Leif Lindholm wrote: OK, so this a bit of a backwards review, but I figured I might as well show how I would prefer the split. I'm adding a patch that changes internal returns to dictionaries instead of multiple return values. There

Re: [edk2-devel] [PATCH v3 3/5] BaseTools/Scripts/GetMaintainer: refactor internal returns as dicts

2023-11-10 Thread Michael D Kinney
Hi Leif, Thank you for the addition cleanup. Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Leif Lindholm > Sent: Friday, November 10, 2023 11:31 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Rebecca Cran > ; Gao, Liming ; Feng, Bob > C ; Chen, Christine >

[edk2-devel] [PATCH v3 4/5] BaseTools/Scripts/GetMaintainer: Handle reviewer only case

2023-11-10 Thread Leif Lindholm
From: Michael D Kinney REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 If a package only has reviewers and no maintainers, then also return the maintainers. In order to detect this case, get_maintainers() is updated to return maintainers, reviews, and lists separately instead of a

[edk2-devel] [PATCH v3 5/5] BaseTools/Scripts/GetMaintainer: Sort output addresses

2023-11-10 Thread Leif Lindholm
From: Michael D Kinney REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 Sort the list of output addresses alphabetically so this script produces the same output even if the order of patches in a patch series is modified such that that order of files processed by this script changes.

[edk2-devel] [PATCH v3 3/5] BaseTools/Scripts/GetMaintainer: refactor internal returns as dicts

2023-11-10 Thread Leif Lindholm
To clean up interfaces, change the lookup functions to return dictionaries rather than multiple values. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Michael D Kinney Signed-off-by: Leif Lindholm --- BaseTools/Scripts/GetMaintainer.py | 19 ++- 1 file

[edk2-devel] [PATCH v3 2/5] BaseTools/Scripts/GetMaintainer: Simplify logic

2023-11-10 Thread Leif Lindholm
From: Michael D Kinney REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 get_section_maintainers() either returns a list with valid entries or an empty list. It never returns None. Simplify logic that accumulates maintainers and lists by unconditionally appending lists returned from

[edk2-devel] [PATCH v3 1/5] BaseTools/Scripts/GetMaintainer: Fix logic bug collecting maintainers

2023-11-10 Thread Leif Lindholm
From: Michael D Kinney REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 Fix logic bug where maintainers is incorrectly added to lists. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Leif Lindholm Signed-off-by: Michael D Kinney ---

[edk2-devel] [PATCH v3 0/5] BaseTools/Scripts/GetMaintainer: Handle reviewer only case

2023-11-10 Thread Leif Lindholm
OK, so this a bit of a backwards review, but I figured I might as well show how I would prefer the split. I'm adding a patch that changes internal returns to dictionaries instead of multiple return values. There are no functional differences between the original submission and this for

[edk2-devel] [PATCH edk2-test v2 4/4] Fix the URL for the edk2-test repo

2023-11-10 Thread Rebecca Cran
Fix the URL for the edk2-test repo: the uefi-sct is a directory inside the repo. Signed-off-by: Rebecca Cran Contributed-under: TianoCore Contribution Agreement 1.1 --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index

[edk2-devel] [PATCH edk2-test v2 3/4] Point users to the URL for edk2-test-parser if it doesn't exist

2023-11-10 Thread Rebecca Cran
If edk2-test-parser doesn't exist, tell the user where they can clone it from. Signed-off-by: Rebecca Cran Contributed-under: TianoCore Contribution Agreement 1.1 --- uefi-sct/SctPkg/buildzip.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/uefi-sct/SctPkg/buildzip.sh

[edk2-devel] [PATCH edk2-test v2 2/4] Rename files in HowToBuild to avoid spaces in filenames

2023-11-10 Thread Rebecca Cran
Rename the text files in the HowToBuild directory to remove the spaces and use CamelCase instead. Signed-off-by: Rebecca Cran Contributed-under: TianoCore Contribution Agreement 1.1 --- uefi-sct/HowToBuild/{How to accelerate SCT execution.txt => HowToAccelerateSctExecution.txt} | 0

[edk2-devel] [PATCH edk2-test v2 1/4] Unbreak buildzip.sh

2023-11-10 Thread Rebecca Cran
Unbreak buildzip.sh by removing the line sourcing edksetup.sh: unless WORKSPACE and PACKAGES_PATH are already configured, edksetup.sh will error out. Signed-off-by: Rebecca Cran Contributed-under: TianoCore Contribution Agreement 1.1 --- uefi-sct/SctPkg/buildzip.sh | 3 --- 1 file changed, 3

[edk2-devel] [PATCH edk2-test v2 0/4] Various improvements to the repo

2023-11-10 Thread Rebecca Cran
Some improvements to the edk2-test repository. Since buildzip.sh creates output that appears more useful for running on the target machine, I wonder if we might want to mention it in the documentation someplace? Also, I suspect the HowToBuildSctInUdk2017.txt file is now pretty outdated. Should

Re: [edk2-devel] [PATCH edk2-test 0/4] Various improvements to the repo

2023-11-10 Thread Rebecca Cran
It looks like Maintainers.txt also needs to be updated since I got bounces from Eric Jin and Arvin Chen's email addresses. On 11/10/23 12:01, Rebecca Cran wrote: Some improvements to the edk2-test repository. Since buildzip.sh creates output that appears more useful for running on the target

[edk2-devel] [PATCH edk2-test 4/4] Fix the URL for the edk2-test repo

2023-11-10 Thread Rebecca Cran
Fix the URL for the edk2-test repo: the uefi-sct is a directory inside the repo. Signed-off-by: Rebecca Cran Contributed-under: TianoCore Contribution Agreement 1.1 --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index

[edk2-devel] [PATCH edk2-test 3/4] Point users to the URL for edk2-test-parser if it doesn't exist

2023-11-10 Thread Rebecca Cran
If edk2-test-parser doesn't exist, tell the user where they can clone it from. Signed-off-by: Rebecca Cran Contributed-under: TianoCore Contribution Agreement 1.1 --- uefi-sct/SctPkg/buildzip.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/uefi-sct/SctPkg/buildzip.sh

[edk2-devel] [PATCH edk2-test 1/4] Unbreak buildzip.sh

2023-11-10 Thread Rebecca Cran
Unbreak buildzip.sh by removing the line sourcing edksetup.sh: unless WORKSPACE and PACKAGES_PATH are already configured, edksetup.sh will error out. Signed-off-by: Rebecca Cran Contributed-under: TianoCore Contribution Agreement 1.1 --- uefi-sct/SctPkg/buildzip.sh | 3 --- 1 file changed, 3

[edk2-devel] [PATCH edk2-test 2/4] Rename files in HowToBuild to avoid spaces in filenames

2023-11-10 Thread Rebecca Cran
Rename the text files in the HowToBuild directory to remove the spaces and use CamelCase instead. Signed-off-by: Rebecca Cran Contributed-under: TianoCore Contribution Agreement 1.1 --- uefi-sct/HowToBuild/{How to accelerate SCT execution.txt => HowToAccelerateSctExecution.txt} | 0

[edk2-devel] [PATCH edk2-test 0/4] Various improvements to the repo

2023-11-10 Thread Rebecca Cran
Some improvements to the edk2-test repository. Since buildzip.sh creates output that appears more useful for running on the target machine, I wonder if we might want to mention it in the documentation someplace? Also, I suspect the HowToBuildSctInUdk2017.txt file is now pretty outdated. Should

[edk2-devel] TPM2 NVM WRITE IN EDK2

2023-11-10 Thread Hamit Can Karaca
Hello, I am a young UEFI developer and I am trying to use the functions in Tpm2CommandLib to write data to TPM2. I have defined the index that, I am going to write data to, using the DefineSpace function. But whenever I am trying to use the Tpm2NvWrite function, I keep getting EFI_DEVICE_ERROR

[edk2-devel] [PATCH] IntelFsp2WrapperPkg: Add variable initialization

2023-11-10 Thread jasonx . hsu
From: "JasonX.Hsu" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4595 Fix build error when remove "-Wno-sometimes-uninitialized" option, Add variable "FspMultiPhaseApiOffset" initialization. Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Cc: Chen Gang C Cc: Duggapu Chinni B Cc: Ted

[edk2-devel] [PATCH] IntelFsp2WrapperPkg: Add variable initialization

2023-11-10 Thread jasonx . hsu
From: "JasonX.Hsu" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4595 Fix build error when remove "-Wno-sometimes-uninitialized" option, Add variable "FspMultiPhaseApiOffset" initialization. --- .../PeiFspWrapperMultiPhaseProcessLib.c | 1 + 1 file changed, 1

[edk2-devel] [PATCH] IntelFsp2WrapperPkg: Add variable initialization

2023-11-10 Thread jasonx . hsu
From: "JasonX.Hsu" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4595 Fix build error when remove "-Wno-sometimes-uninitialized" option, Add variable "FspMultiPhaseApiOffset" initialization. Cc: Nate DeSimone Cc: Star Zeng Cc: James Lu Cc: Gua Guo Signed-off-by: Jason Hsu ---

[edk2-devel] [edk2-stable202311][Patch v2 2/4] BaseTools/Scripts/GetMaintainer: Handle reviewer only case

2023-11-10 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 If a package only has reviewers and no maintainers, then also return the maintainers. In order to detect this case, get_maintainers() is updated to return maintainers, reviews, and lists separately instead of a single merged list. This

[edk2-devel] [edk2-stable202311][Patch v2 1/4] BaseTools/Scripts/GetMaintainer: Fix logic bug collecting maintainers

2023-11-10 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 Fix logic bug where maintainers is incorrectly added to lists. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Leif Lindholm Signed-off-by: Michael D Kinney --- BaseTools/Scripts/GetMaintainer.py | 2 +- 1 file

[edk2-devel] [edk2-stable202311][Patch v2 3/4] BaseTools/Scripts/GetMaintainer: Simplify logic

2023-11-10 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 get_section_maintainers() either returns a list with valid entries or an empty list. It never returns None. Simplify logic that accumulates maintainers, reviewers, and lists by unconditionally appending lists returned from

[edk2-devel] [edk2-stable202311][Patch v2 4/4] BaseTools/Scripts/GetMaintainer: Sort output addresses

2023-11-10 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 Sort the list of output addresses alphabetically so this script produces the same output even if the order of patches in a patch series is modified such that that order of files processed by this script changes. Use set() logic instead of

[edk2-devel] [edk2-stable202311][Patch v2 0/4] BaseTools/Scripts/GetMaintainer: Handle reviewer only case

2023-11-10 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 New in V2: Split into patch series Fix logic bug where maintainers was incorrectly added to lists. If a package only has reviewers and no maintainers, then also return the maintainers. In order to detect this case, get_maintainers() is

Re: [edk2-devel] [edk2-stable202311][Patch 1/1] BaseTools/Scripts: Handle reviewer only case in GetMaintainer.py

2023-11-10 Thread Leif Lindholm
On 2023-11-10 16:34, Kinney, Michael D wrote: Hi Leif, Agree with your points. I was trying to make minimal changes to address the reviewers with no maintainers case. Returning a dictionary would make more sense. A couple questions: 1) Do you want to see this patch broken up into a series,

Re: [edk2-devel] [edk2-stable202311][Patch 1/1] BaseTools/Scripts: Handle reviewer only case in GetMaintainer.py

2023-11-10 Thread Michael D Kinney
Hi Leif, Agree with your points. I was trying to make minimal changes to address the reviewers with no maintainers case. Returning a dictionary would make more sense. A couple questions: 1) Do you want to see this patch broken up into a series, with the logic fix, reviewers with no

Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: Sample python scripts for socket client capabilities on UEFI shell

2023-11-10 Thread Jayaprakash, N
These are simple Python apps to demonstrate the usage of socket communication using the HTTP library. Reviewed-by : Jayaprakash N Regards, JP -Original Message- From: devel@edk2.groups.io On Behalf Of Jayaprakash, N Sent: Friday, October 27, 2023 9:57 PM To: devel@edk2.groups.io Cc:

Re: [edk2-devel] [PATCH v2 01/11] ArmPkg/ArmScmiDxe: Rename PERFORMANCE_PROTOCOL_VERSION

2023-11-10 Thread Leif Lindholm
On 2023-11-10 09:11, Pierre Gondois wrote: Hello Leif, On 11/2/23 11:20, Pierre Gondois wrote: Hello Leif, Thanks for the review, On 10/26/23 12:05, Leif Lindholm wrote: On Wed, Oct 25, 2023 at 13:25:30 +0200, pierre.gond...@arm.com wrote: From: Pierre Gondois Rename

Re: [edk2-devel] [PATCH v3] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

2023-11-10 Thread Leif Lindholm
On Fri, Nov 10, 2023 at 00:39:53 +, Chang, Abner wrote: > [AMD Official Use Only - General] > > Thanks Leif, some responses are given in line. > As we would like to have this be part of edk2-stable202312, we > prefer letting this change gets in stable release first and address > the comment

Re: [edk2-devel] [edk2-stable202311][Patch 1/1] BaseTools/Scripts: Handle reviewer only case in GetMaintainer.py

2023-11-10 Thread Leif Lindholm
On Wed, Nov 08, 2023 at 12:43:23 -0800, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 > > If a package only has reviewers and no maintainers, then also > return the maintainers. > > Update get_maintainers() to return maintainers, reviews, and > lists

[edk2-devel] [Patch V2] UefiCpuPkg/MpInitLib: Enable execute disable bit.

2023-11-10 Thread Yuanhao Xie
From: Yuanhao Xie This patch synchronizes the No-Execute bit in the IA32_EFER register for the APs before the RestoreVolatileRegisters operation. The commit 964a4f0, titled "Eliminate the second INIT-SIPI-SIPI sequence," replaces the second INIT-SIPI-SIPI sequence with the BSP calling the

[edk2-devel] [PATCH v3 6/6] CryptoPkg: Enable Openssl Accel builds for AARCH64

2023-11-10 Thread PierreGondois
Enable the following modules builds for AARCH64: - OpensslLibAccel.inf - OpensslLibFullAccel.inf Signed-off-by: Pierre Gondois --- CryptoPkg/CryptoPkg.dsc | 23 --- CryptoPkg/Readme.md | 14 +++--- 2 files changed, 19 insertions(+), 18 deletions(-) diff --git

[edk2-devel] [PATCH v3 5/6] CryptoPkg/OpensslLib: Add AArch64Cap for arch specific hooks

2023-11-10 Thread PierreGondois
Add AARCH64 specific implementations of: - OPENSSL_cpuid_setup(), probing hardware capabilitie (presence of FEAT_AES, etc.) - OPENSSL_rdtsc(), returning non-trusted entropy by accessing system counter. Signed-off-by: Pierre Gondois --- .../Library/OpensslLib/OpensslLibAccel.inf| 7 ++

[edk2-devel] [PATCH v3 3/6] CryptoPkg/OpensslLib: Add native instruction support for AARCH64

2023-11-10 Thread PierreGondois
Add native instruction support for AARCH64. Signed-off-by: Pierre Gondois --- .../Library/OpensslLib/OpensslLibAccel.inf| 21 ++- .../OpensslLib/OpensslLibFullAccel.inf| 21 ++- CryptoPkg/Library/OpensslLib/UefiAsm.conf | 6 ++

[edk2-devel] [PATCH v3 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependency upon ArmPkg

2023-11-10 Thread PierreGondois
Allow dependency upon ArmPkg to pass the dependency Check. Signed-off-by: Pierre Gondois --- CryptoPkg/CryptoPkg.ci.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml index f961d85927c0..3bbb220d3224 100644 ---

[edk2-devel] [PATCH v3 1/6] ArmPkg/ArmLib: Move ArmReadIdAA64Isar0() to ArmLib

2023-11-10 Thread PierreGondois
Add ArmReadIdAA64Isar0() to ArmLib along with macros to read specific register fields. Signed-off-by: Pierre Gondois --- ArmPkg/Include/Library/ArmLib.h| 68 ++ ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 6 -- 2 files changed, 68 insertions(+), 6 deletions(-)

[edk2-devel] [PATCH v3 0/6] CryptoPkg: Enable Openssl native instruction support for AARCH64

2023-11-10 Thread PierreGondois
v3: - Use ArmPkg's function to access register: - Dropped: - [PATCH v2 1/7] MdePkg/BaseLib: AARCH64: Add ArmReadCntPctReg() - [PATCH v2 2/7] MdePkg/BaseLib: AARCH64: Add ArmReadIdAA64Isar0Reg() - [PATCH v2 3/7] MdePkg/BaseRngLib: Prefer ArmReadIdAA64Isar0Reg() over ArmReadIdIsar0()

[edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Enable execute disable bit.

2023-11-10 Thread Yuanhao Xie
From: Yuanhao Xie This patch synchronizes the No-Execute bit in the IA32_EFER register for the APs before the RestoreVolatileRegisters operation. The commit 964a4f0, titled "Eliminate the second INIT-SIPI-SIPI sequence," replaces the second INIT-SIPI-SIPI sequence with the BSP calling the

Re: [edk2-devel] [PATCH v2 24/30] OvmfPkg/LoongArchVirt: Add platform boot manager library

2023-11-10 Thread Gerd Hoffmann
On Fri, Nov 10, 2023 at 03:09:47PM +0800, Chao Li wrote: > Hi Laszlo, > > Sorry, I'm not check carefully, it is really **copied**, and we not think > the ARM version is not good enough. > > So, can I move this library to OvmfPkg so other ARCH use it easily? Moving code from ArmVirtPkg to

Re: [edk2-devel] [PATCH v2 01/11] ArmPkg/ArmScmiDxe: Rename PERFORMANCE_PROTOCOL_VERSION

2023-11-10 Thread PierreGondois
Hello Leif, On 11/2/23 11:20, Pierre Gondois wrote: Hello Leif, Thanks for the review, On 10/26/23 12:05, Leif Lindholm wrote: On Wed, Oct 25, 2023 at 13:25:30 +0200, pierre.gond...@arm.com wrote: From: Pierre Gondois Rename PERFORMANCE_PROTOCOL_VERSION to reflect the different versions of

Re: [edk2-devel] [PATCH v2 10/11] DynamicTablesPkg: Add ArmScmiInfoLib

2023-11-10 Thread PierreGondois
On 11/9/23 12:26, Leif Lindholm wrote: On Thu, Nov 09, 2023 at 10:58:58 +0100, Pierre Gondois wrote: Hello Leif, On 11/2/23 11:20, Pierre Gondois wrote: On 10/26/23 13:03, Leif Lindholm wrote: On Wed, Oct 25, 2023 at 13:25:39 +0200, PierreGondois wrote: From: Pierre Gondois The SCP

Re: [edk2-devel] [PATCH v2 1/7] MdePkg/BaseLib: AARCH64: Add ArmReadCntPctReg()

2023-11-10 Thread PierreGondois
On 11/9/23 15:11, Leif Lindholm wrote: On Thu, Nov 09, 2023 at 10:23:01 +0100, Pierre Gondois wrote: To enable AARCH64 native instruction support for Openssl, some interfaces must be implemented. OPENSSL_rdtsc() requests an access to a counter to get some non-trusted entropy. Add

Re: [edk2-devel] [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Fix CP Exception when CET enable

2023-11-10 Thread Ni, Ray
merged. Thanks, Ray From: Wu, Jiaxin Sent: Friday, November 10, 2023 8:43 AM To: Kinney, Michael D ; Laszlo Ersek ; devel@edk2.groups.io ; Gao, Liming Cc: Dong, Eric ; Ni, Ray ; Zeng, Star ; Gerd Hoffmann ; Kumar, Rahul R Subject: RE: [edk2-devel] [PATCH