[edk2-devel] [PATCH v2 6/6] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SmmCpuSyncLib

There is the SmmCpuSyncLib Library class define the SMM CPU sync flow, which is aligned with existing SMM CPU driver sync behavior. This patch is to consume SmmCpuSyncLib instance directly. With this change, SMM CPU Sync flow/logic can be customized with different implementation no matter for any

[edk2-devel] [PATCH v2 5/6] UefiPayloadPkg: Specifies SmmCpuSyncLib instance

This patch is to specify SmmCpuSyncLib instance for UefiPayloadPkg. Cc: Laszlo Ersek Cc: Guo Dong Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Cc: Ray Ni Cc: Zeng Star Signed-off-by: Jiaxin Wu --- UefiPayloadPkg/UefiPayloadPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2-devel] [PATCH v2 4/6] OvmfPkg: Specifies SmmCpuSyncLib instance

This patch is to specify SmmCpuSyncLib instance for OvmfPkg. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Eric Dong Cc: Ray Ni Cc: Zeng Star Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Jiaxin Wu --- OvmfPkg/CloudHv/CloudHvX64.dsc | 2 ++

[edk2-devel] [PATCH v2 3/6] UefiCpuPkg: Implements SmmCpuSyncLib library instance

Implements SmmCpuSyncLib Library instance. The instance refers the existing SMM CPU driver (PiSmmCpuDxeSmm) sync implementation and behavior: 1.Abstract Counter and Run semaphores into SmmCpuSyncCtx. 2.Abstract CPU arrival count operation to SmmCpuSyncGetArrivedCpuCount(), SmmCpuSyncCheckInCpu(),

[edk2-devel] [PATCH v2 2/6] UefiCpuPkg: Adds SmmCpuSyncLib library class

Intel is planning to provide different SMM CPU Sync implementation along with some specific registers to improve the SMI performance, hence need SmmCpuSyncLib Library for Intel. This patch is to: 1.Adds SmmCpuSyncLib Library class in UefiCpuPkg.dec. 2.Adds SmmCpuSyncLib.h function declaration

[edk2-devel] [PATCH v2 1/6] UefiCpuPkg/PiSmmCpuDxeSmm: Optimize Semaphore Sync between BSP and AP

This patch is to define 3 new functions (WaitForBsp & ReleaseBsp & ReleaseOneAp) used for the semaphore sync between BSP & AP. With the change, BSP and AP Sync flow will be easy understand as below: BSP: ReleaseAllAPs or ReleaseOneAp --> AP: WaitForBsp BSP: WaitForAllAPs <-- AP:

[edk2-devel] [PATCH v2 0/6] Refine SMM CPU Sync flow and abstract SmmCpuSyncLib

The series patches are to refine SMM CPU Sync flow. After the refinement, SmmCpuSyncLib is abstracted for any user to provide different SMM CPU Sync implementation. Compared to V1, has following refinement & changes: 1. Remove below patch from this series patches: UefiCpuPkg/PiSmmCpuDxeSmm:

[edk2-devel] [PATCH v2 3/3] UefiCpuPkg/CpuMpPei: Use CpuPageTableLib to set memory attribute.

Currently, there are code to set memory attribute in CpuMpPei module. However, the code doesn't handle the case of 5 level paging. Use the CpuPageTableLib to set memory attribute for two purpose: 1. Add 5 level paging support 2. Clean up code Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc:

[edk2-devel] [PATCH v2 2/3] UefiCpuPkg/CpuPageTableLib/TestCase: Refine test case for PAE paging.

Refine test case: 1. Check PAE paging reserved bits is zero. 2. Set stack as random value. Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Laszlo Ersek Signed-off-by: Zhiguang Liu --- .../CpuPageTableLib/UnitTest/RandomTest.c | 24 ++-

[edk2-devel] [PATCH v2 1/3] UefiCpuPkg/CpuPageTableLib: Init local variable before using it.

The local variable OneOfPagingEntry is used before initialized, this may cause reserved bit in page table entry is set especially in PAE paging mode. The bug is random because it depends on the value in stack. Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Laszlo Ersek Signed-off-by:

Re: [edk2-devel] [edk2-non-osi][Silicon/AMD/VanGogh][PATCH] Silicon/AMD/VanGogh: Update VanGogh firmware binaries

Reviewed-by: Abdul Lateef Attar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111888): https://edk2.groups.io/g/devel/message/111888 Mute This Topic: https://groups.io/mt/102868346/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

[AMD Official Use Only - General] Hi Mike, There is an error in CI. Could you please check it here https://github.com/tianocore/edk2/pull/5091/checks?check_run_id=19163237933? As it says Mergify needs permission from you. I think this is new to edk2 CI. Thanks Abner > -Original

Re: [edk2-devel] [PATCH 0/2] MdePkg: Fix CRC16-ANSI calculation

On Thu, Nov 30, 2023 at 2:46 AM Pedro Falcato via groups.io wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4609 > > CalculateCrc16Ansi is currently miscalculating all checksums and causing > ext4 mount failures on older (~13 year old) filesystems. > > This patchset: > 1) Fixes

[edk2-devel] [PATCH 2/2] MdePkg/Test: Add google tests for BaseLib

Add GoogleTestBaseLib, which contains gtest unit tests for BaseLib. For now, only add checksum tests for CRC32C and CRC16; these tests check for correctness on various inputs using precomputed hashes. Signed-off-by: Pedro Falcato Cc: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu ---

[edk2-devel] [PATCH 1/2] MdePkg/BaseLib: Fix CRC16-ANSI calculation

The current CalculateCrc16Ansi implementation does the following: 1) Invert the passed checksum 2) Calculate the new checksum by going through data and using the lookup table 3) Invert it back again This emulated my design for CalculateCrc32c, where 0 is passed as the initial checksum, and it

[edk2-devel] [PATCH 0/2] MdePkg: Fix CRC16-ANSI calculation

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4609 CalculateCrc16Ansi is currently miscalculating all checksums and causing ext4 mount failures on older (~13 year old) filesystems. This patchset: 1) Fixes CalculateCrc16Ansi to properly calculate checksums This is a breaking change. 2)

Re: [edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg

Hi Ray, Thanks for review, here are some of my thoughts: Thanks, Chao On 2023/11/30 08:59, Ni, Ray wrote: Chao, Since the lib class is so general, I'd like to understand more details to make sure it can properly fit into any CPU arch. In X86, cache setting is through MSRs and Page tables,

Re: [edk2-devel] [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

[AMD Official Use Only - General] We need a PR to trigger CI test and then maintainer can set the label to "Push" to merge the code if the change passes all CI tests. I think I done this way for a long time. Regards, Abner From: Ashish Singhal Sent: Thursday, November 30, 2023 10:16 AM To:

Re: [edk2-devel] [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

I thought the process was to share the patch via email and maintainers create the PR. Author creating PR used to be optional. Has that changed recently? Thanks Ashish Get Outlook for iOS From: Chang, Abner Sent: Wednesday, November 29,

Re: [edk2-devel] [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

[AMD Official Use Only - General] Ah sure. I can do it at anytime. Could you please create a PR for this change and let me know? Abner From: Ashish Singhal Sent: Thursday, November 30, 2023 12:37 AM To: Chang, Abner ; devel@edk2.groups.io; quic_llind...@quicinc.com;

Re: [edk2-devel] [edk2-non-osi][Silicon/AMD/VanGogh][PATCH] Silicon/AMD/VanGogh: Update VanGogh firmware binaries

Reviewed-by: Abner Chang -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111878): https://edk2.groups.io/g/devel/message/111878 Mute This Topic: https://groups.io/mt/102868346/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [edk2-platforms][PATCH] MinPlatformPkg: should build Performance driver only when perf enabled

Pushed as 4e34823 -Original Message- From: Li, Yi1 Sent: Monday, November 27, 2023 9:09 PM To: devel@edk2.groups.io Cc: Li, Yi1 ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric Subject: [edk2-platforms][PATCH] MinPlatformPkg: should build Performance driver only

Re: [edk2-devel] [edk2-platforms][PATCH] MinPlatformPkg: should build Performance driver only when perf enabled

Reviewed-by: Nate DeSimone -Original Message- From: Li, Yi1 Sent: Monday, November 27, 2023 9:09 PM To: devel@edk2.groups.io Cc: Li, Yi1 ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric Subject: [edk2-platforms][PATCH] MinPlatformPkg: should build Performance

Re: [edk2-devel] [PATCH 1/1] Platform/Intel/Readme.md: Link to the OSS FSP repo

Pushed as 2cd4f97 -Original Message- From: Pedro Falcato Sent: Wednesday, November 29, 2023 3:41 PM To: devel@edk2.groups.io Cc: Pedro Falcato ; Desimone, Nathaniel L ; Chaganty, Rangasai V Subject: [PATCH 1/1] Platform/Intel/Readme.md: Link to the OSS FSP repo Link to

Re: [edk2-devel] [edk2-platforms][PATCH v1] IpmiFeaturePkg: Fix Build

Pushed as 967557e -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Wednesday, November 29, 2023 4:40 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel] [edk2-platforms][PATCH v1] IpmiFeaturePkg: Fix Build Add missing

Re: [edk2-devel] [PATCH edk2-platforms 1/1] UserAuthFeaturePkg/UserAuthenticationSmm: Support Standalone MM.

Hi Wei, There is a bigger issue here that your patch series highlights. It is not possible to implement the user authentication feature in standalone MM without also having a DXE driver. But that is an issue that is beyond the scope of this patch series as it will require modifications to the

Re: [edk2-devel] [PATCH v3 03/11] MdePkg/Acpi65: Add _PSD/_CPC/State Coordination Types macros

I suggest you add the definition to the specific Acpi##.h where ## is the APCI spec version when these definitions were added. Since the newer Acpi##.h includes older Acpi##.h, the definitions would be naturally included even if user includes Acpi65.h. The macro name does not have to carry the

Re: [edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg

Chao, Since the lib class is so general, I'd like to understand more details to make sure it can properly fit into any CPU arch. In X86, cache setting is through MSRs and Page tables, and memory access control (read-only, not-present, non-executable) is through page tables. This CpuMmuLib is

Re: [edk2-devel] [PATCH v2 edk2-platforms 1/1] IpmiFeaturePkg/SmmIpmiBaseLib: Support Standalone MM.

Pushed as 2466092 -Original Message- From: Xu, Wei6 Sent: Sunday, November 5, 2023 7:19 AM To: devel@edk2.groups.io Cc: Xu, Wei6 ; Abner Chang ; Desimone, Nathaniel L ; Gao, Liming Subject: [PATCH v2 edk2-platforms 1/1] IpmiFeaturePkg/SmmIpmiBaseLib: Support Standalone MM. Add

Re: [edk2-devel] [PATCH 1/1] Platform/Intel/Readme.md: Link to the OSS FSP repo

I do see the existing link gets redirected to the new link. Still a good change. Thanks! Reviewed-by: Sai Chaganty -Original Message- From: Pedro Falcato Sent: Wednesday, November 29, 2023 3:41 PM To: devel@edk2.groups.io Cc: Pedro Falcato ; Desimone, Nathaniel L ; Chaganty,

Re: [edk2-devel] [edk2-platforms][PATCH v1] IpmiFeaturePkg: Fix Build

Reviewed-by: Sai Chaganty -Original Message- From: Desimone, Nathaniel L Sent: Wednesday, November 29, 2023 4:40 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-platforms][PATCH v1] IpmiFeaturePkg: Fix Build Add missing MemoryAllocationLib

Re: [edk2-devel] [PATCH v2 edk2-platforms 1/1] IpmiFeaturePkg/SmmIpmiBaseLib: Support Standalone MM.

Reviewed-by: Nate DeSimone -Original Message- From: Xu, Wei6 Sent: Sunday, November 5, 2023 7:19 AM To: devel@edk2.groups.io Cc: Xu, Wei6 ; Abner Chang ; Desimone, Nathaniel L ; Gao, Liming Subject: [PATCH v2 edk2-platforms 1/1] IpmiFeaturePkg/SmmIpmiBaseLib: Support Standalone MM.

Re: [edk2-devel] [PATCH 1/1] Platform/Intel/Readme.md: Link to the OSS FSP repo

Reviewed-by: Nate DeSimone -Original Message- From: Pedro Falcato Sent: Wednesday, November 29, 2023 3:41 PM To: devel@edk2.groups.io Cc: Pedro Falcato ; Desimone, Nathaniel L ; Chaganty, Rangasai V Subject: [PATCH 1/1] Platform/Intel/Readme.md: Link to the OSS FSP repo Link to

[edk2-devel] [edk2-platforms][PATCH v1] IpmiFeaturePkg: Fix Build

Add missing MemoryAllocationLib dependency Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Nate DeSimone --- .../IpmiFeaturePkg/GenericElog/Smm/GenericElog.inf | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

Hi Abner, I dropped patch 3/3, added R-b and created PR https://github.com/tianocore/edk2/pull/5091 Regards, Mike On Mon, Nov 27, 2023 at 5:25 AM Chang, Abner wrote: > > [AMD Official Use Only - General] > > Ok, thanks. Then we will just merge 1/3 and 2/3. > > Not quite right, as maintainer

[edk2-devel] [PATCH 1/1] Platform/Intel/Readme.md: Link to the OSS FSP repo

Link to github.com/intel/FSP, which is the canonical OSS place for all your FSP needs. The old link is not accessible publicly. Signed-off-by: Pedro Falcato Cc: Nate DeSimone Cc: Sai Chaganty --- Platform/Intel/Readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Add edk2-platforms/Features to PACKAGES_PATH

Pushed as be6742a -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Monday, November 27, 2023 5:04 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Gao, Liming ; Dong, Eric Subject: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Add

Re: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Update PatchFv Tools for Python 3.x

Pushed as d02c09d -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Monday, November 27, 2023 5:04 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Gao, Liming ; Dong, Eric Subject: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Update PatchFv Tools

Re: [edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg/BoardMtOlympus: Fix Build

Pushed as 0114e8b -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Monday, November 27, 2023 5:04 PM To: devel@edk2.groups.io Cc: Chiu, Chasel Subject: [edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg/BoardMtOlympus: Fix Build Updates Microcode

Re: [edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Fix Build

Pushed as 4009d4c -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Monday, November 27, 2023 5:04 PM To: devel@edk2.groups.io Cc: Chiu, Chasel Subject: [edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Fix Build Adds SmmLockBox driver which is

Re: [edk2-devel] [edk2-non-osi][Silicon/AMD/VanGogh][PATCH] Silicon/AMD/VanGogh: Update VanGogh firmware binaries

[AMD Official Use Only - General] It looks good to me. Reviewed-by: Zhai MingXin Thanks! Duke Zhai -Original Message- From: Xing, Eric Sent: Wednesday, November 29, 2023 4:37 PM To: devel@edk2.groups.io Cc: Zhai, MingXin (Duke) ; Attar, AbdulLateef (Abdul Lateef) ; Chang, Abner

[edk2-devel] [PATCH v1] MdePkg: Add Cxl30.h into IndustryStandard

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4516 1) Add CXL 3.0 header file to comply with CXL 3.0 specification 2) CXL 3.0 header will embed Cxl20.h 3) Updated Cxl.h to point to 3.0 header file Signed-off-by: Foster Nong Cc: Michael D Kinney Cc: Liming Gao Cc: Ray Ni Cc: Chris Li

[edk2-devel] [PATCH v2 1/1] ShellPkg: Tidy for code readability

Use error handling instead of success handling. Less indented logic is easier to read. Cc: Zhichao Gao Cc: Ray Ni Signed-off-by: Daniel Nguyen --- ShellPkg/Library/UefiShellLevel2CommandsLib/Reset.c | 41 +++- 1 file changed, 23 insertions(+), 18 deletions(-) diff --git

[edk2-devel] [PATCH v2 0/1] ShellPkg: Tidy for code readability

Use error handling instead of success handling. Less indented logic is easier to read. Daniel Nguyen (1): ShellPkg: Tidy for code readability ShellPkg/Library/UefiShellLevel2CommandsLib/Reset.c | 41 +++- 1 file changed, 23 insertions(+), 18 deletions(-) -- 2.25.1

Re: [edk2-devel] [PATCH v1 1/1] .github/workflows/codeql.yml: Add emacs output

Acked-by: Michael D Kinney > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, November 29, 2023 9:01 AM > To: devel@edk2.groups.io > Cc: Joey Vagedes ; Laszlo Ersek > ; Kinney, Michael D ; Sean > Brogan > Subject: [PATCH v1 1/1] .github/workflows/codeql.yml:

Re: [edk2-devel] [PATCH v1 1/1] .github/workflows/codeql.yml: Add emacs output

Reviewed-by: Joey Vagedes On Wed, Nov 29, 2023 at 9:01 AM wrote: > From: Michael Kubacki > > Updates the workflow to also output files that can be loaded in emacs > to show CodeQL issues (in addition to the existing SARIF output for > standard SARIF viewers). > > The emacs files are in the

[edk2-devel] [PATCH v1 1/1] .github/workflows/codeql.yml: Add emacs output

From: Michael Kubacki Updates the workflow to also output files that can be loaded in emacs to show CodeQL issues (in addition to the existing SARIF output for standard SARIF viewers). The emacs files are in the SARIF zip file attached to each "CodeQL" run

Re: [edk2-devel] [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

Hello, Checking if there is a timeline for this patchset to be merged. Thanks Ashish From: Chang, Abner Sent: Monday, November 20, 2023 6:57 PM To: Ashish Singhal ; devel@edk2.groups.io ; quic_llind...@quicinc.com ; ardb+tianoc...@kernel.org ;

[edk2-devel] [PATCH v1 3/3] DynamicTablesPkg: Corrects function pointer typedef of AML_PARSE_FUNCTION

From: Abdul Lateef Attar Corrects the function pointer typedef AML_PARSE_FUNCTION, otherwise some compiler like VS2019 gives error. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar --- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c | 3 +-- 1 file changed, 1

[edk2-devel] [PATCH v1 2/3] DynamicTablesPkg: Corrects AmlCodeGenRdWordBusNumber parameters

From: Abdul Lateef Attar Corrects the parameters of AmlCodeGenRdWordBusNumber() to UINT16 to generate word bus number. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar --- DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h | 10 +-

[edk2-devel] [PATCH v1 1/3] DynamicTablesPkg: AML Code generation for word I/O ranges

From: Abdul Lateef Attar Add helper functions to generate AML resource data for word I/O. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar --- .../Include/Library/AmlLib/AmlLib.h | 65 ++ .../AmlLib/CodeGen/AmlResourceDataCodeGen.c | 88

[edk2-devel] [PATCH v1 0/3] DynamicTablesPkg: Updated word I/O

From: Abdul Lateef Attar Code changes to Add API to generate word I/O ranges. Correct the parameter to generate word bus number. Corrects the function pointer typedef PR: https://github.com/tianocore/edk2/pull/5090 Cc: Pierre Gondois Cc: Sami Mujawar Abdul Lateef Attar (3):

回复: [edk2-devel] [Patch V2 1/4] BaseTools: fixing FMMT ShrinkFv issue

Yuwei: Please update commit message with reviewed-by info, then I will add push label for this patch set. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Yuwei Chen > 发送时间: 2023年11月29日 16:26 > 收件人: Gao, Liming ; Feng, Bob C > > 抄送: 'Rebecca Cran' ; devel@edk2.groups.io; Chen,

Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg: Fix issue with ACPI table creation

Hi, > > +// ACPI Spec 6.5+ Table 5-9 X_DSDT definition > > +// > > +if (((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE > > *)ChildTable)->XDsdt != 0) { > > + TableToInstall = (VOID > > *)(UINTN)((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE *)ChildTable)->XDsdt; >

Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for Change-id

Hi Pedro, On 29/11/2023, 06:40, "Pedro Falcato" mailto:pedro.falc...@gmail.com>> wrote: On Wed, Nov 29, 2023 at 12:56 AM Ni, Ray mailto:ray...@intel.com>> wrote: > > It's good. But I am curious why --ignore-change-id is needed? I didn't ask, but presumably, if you have an internal gerrit

Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for Change-id

Hi Ray, On 29/11/2023, 00:56, "Ni, Ray" mailto:ray...@intel.com>> wrote: It's good. But I am curious why --ignore-change-id is needed? [SAMI] This option can be useful if an internal CI uses the same script for checking patches before they are posted on the list. Regards, Sami Mujawar

Re: [edk2-devel] [Patch V2 1/4] BaseTools: fixing FMMT ShrinkFv issue

Hi Liming and Cran, I have created the Edk2 PR for this one: https://github.com/tianocore/edk2/pull/5009 As it has been reviewed, please help merge that. Thanks~ Thanks, Yuwei (Christine) > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yuwei > Chen > Sent: Monday,

Re: [edk2-devel] [PATCH edk2-test v2 4/4] Fix the URL for the edk2-test repo

Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111840): https://edk2.groups.io/g/devel/message/111840 Mute This Topic: https://groups.io/mt/102513318/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] [PATCH edk2-test v2 3/4] Point users to the URL for edk2-test-parser if it doesn't exist

Thank you for the update. Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111839): https://edk2.groups.io/g/devel/message/111839 Mute This Topic: https://groups.io/mt/102513315/21656 Group Owner:

Re: [edk2-devel] [PATCH edk2-test v2 2/4] Rename files in HowToBuild to avoid spaces in filenames

Hi Rebecca, Thank you for these updates. Just a matter of style, but can we do HowToBuild *SCT*.txt instead of HowToBuild *Sct*.txt? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111838): https://edk2.groups.io/g/devel/message/111838