Re: [edk2-devel] [PATCH V2 1/1] Silicon/Intel/FitGen：FIT change for FBM entry.

Reviewed-by: Yuwei Chen > -Original Message- > From: Liu, Liqi > Sent: Tuesday, December 12, 2023 4:42 PM > To: devel@edk2.groups.io > Cc: Liu, Liqi ; Chen, Christine ; > Feng, Bob C ; Chaganty, Rangasai V > ; Gao, Liming > Subject: [PATCH V2 1/1] Silicon/Intel/FitGen：FIT change for

Re: [edk2-devel] Copyright for an individual contributor

On 12/17/23 20:01, Chang, Abner via groups.io wrote: [AMD Official Use Only - General] Hi all, How do we have the copyright for the contribution from an individual? I don’t see the formatting defined in edk2 C coding standard. Is the below format ok? Copyright (c) 2023, Contributor I

Re: [edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg: use POST method while provisioning new property.

[AMD Official Use Only - General] Yes, this is something we have to make it clear to support PUT, POST and PATCH for different scenarios. Agree we can just drop 4/4 for now, I will add this to the TODO list. Thanks Abner From: M M Sent: Monday, December 18, 2023 8:58 AM To:

Re: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers in uncompressed inner fv.

Reviewed-by: Ray Ni Can you kindly update the PR to add the Reviewed-by? I can help to set "push" label after that. Thanks, Ray > -Original Message- > From: Xu, Wei6 > Sent: Monday, December 18, 2023 9:37 AM > To: devel@edk2.groups.io; Xu, Wei6 > Cc: Laszlo Ersek ; Ard Biesheuvel > ;

Re: [edk2-devel] [PATCH v2 14/14] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses

[AMD Official Use Only - General] > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 14/14] RedfishPkg: RedfishDiscoverDxe: add []

Re: [edk2-devel] [PATCH v2 13/14] RedfishDiscoverDxe: handle memory allocation error conditions.

[AMD Official Use Only - General] > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 13/14] RedfishDiscoverDxe: handle memory

Re: [edk2-devel] [PATCH v2 12/14] RedfishDiscoverDxe: refine InitInformationData() function

[AMD Official Use Only - General] It's easy to read with this change. Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin >

Re: [edk2-devel] [PATCH v2 11/14] RedfishDiscoverDxe: refine InitInformationData(), remove unnecessary casts

[AMD Official Use Only - General] After addressing comment on 10/14, Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin ;

Re: [edk2-devel] [PATCH v2 10/14] RedfishDiscoverDxe: introduce InitInformationData helper function

[AMD Official Use Only - General] > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 10/14] RedfishDiscoverDxe: introduce

[edk2-devel][edk2-platforms][PATCH v1] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64

https://bugzilla.tianocore.org/show_bug.cgi?id=4623 1.Added PeiCoreEntry.nasm, SecEntry.nasm and Stack.nasm for X64. 2.Made changes in common file to support both IA32 and X64. 3.Added the PCDs below for FSP-T UPD revsions and X64 feature. - PcdFspWrapperResetVectorInFsp -

Re: [edk2-devel] [PATCH v2 08/14] EmulatorPkg: fix typo. PcdRedfishServie -> PcdRedfishService

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 08/14] EmulatorPkg:

Re: [edk2-devel] [PATCH v2 09/14] EmulatorPkg: RedfishPlatformHostInterfaceLib: get rid of unused variable

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 09/14] EmulatorPkg:

Re: [edk2-devel] [PATCH v2 07/14] RedfishPkg: add proper initialization of IPMI request

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 07/14] RedfishPkg:

[edk2-devel] Copyright for an individual contributor

[AMD Official Use Only - General] Hi all, How do we have the copyright for the contribution from an individual? I don't see the formatting defined in edk2 C coding standard. Is the below format ok? Copyright (c) 2023, Contributor Thanks Abner -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You

Re: [edk2-devel] [PATCH v2 06/14] RedfishPkg: add Component Name protocols to RedfishConfigHandler driver

[AMD Official Use Only - General] Hi Mike, Not sure how do we have the copyright for individual contributor. Let me check with community. And btw, you can in the patch format in below, there are additional blank line for each line. I believe you can use option " --transfer-encoding=8bit" to

Re: [edk2-devel] [PATCH v2 05/14] RedfishPkg: RedfishDiscoverDxe: fix memory leak on error path.

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 05/14] RedfishPkg:

Re: [edk2-devel] [PATCH v2 04/14] RedfishPkg: RedfishPlatformConfigDxe: reduce memory allocations

[Public] Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 04/14] RedfishPkg: RedfishPlatformConfigDxe:

Re: [edk2-devel] [PATCH v2 03/14] RedfishPkg: get rid of unused definitions from RedfishCrtLib.h

[Public] Not able to apply this patch from either email or group.io. You may want to try option "--transfer-encoding=8bit" when git send-email. Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io >

Re: [edk2-devel] [PATCH v2 02/14] RedfishPkg: fix RedfishPlatformCredentialLib library class name typo.

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 02/14] RedfishPkg:

Re: [edk2-devel] [PATCH v2 01/14] RedfishPkg: fix RedfishPlatformHostInterfaceLib library class name typo.

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 01/14] RedfishPkg:

Re: [edk2-devel] [PATCH 2/9] RedfishPkg: fix RedfishPlatformCredentialLib library class name typo.

[AMD Official Use Only - General] Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, December 12, 2023 10:54 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH 2/9] RedfishPkg: fix

Re: [edk2-devel] [PATCH 1/9] RedfishPkg: fix RedfishPlatformHostInterfaceLib library class name typo.

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, December 12, 2023 10:54 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH 1/9] RedfishPkg: fix

Re: [edk2-devel] [PATCH] EmbeddedPkg: Add DtPlatformLoaderLib gmock support

[AMD Official Use Only - General] Not familiar with gmock and no idea of adding a cpp source file to edk2 (we done this on edk2 before?). May need someone else to review this change. Thanks Abner > -Original Message- > From: Jeff Brasen > Sent: Monday, December 11, 2023 11:47 PM > To:

Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiMemoryAllocationLib: Add ReallocatePool

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Jeff Brasen > Sent: Monday, December 11, 2023 11:48 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; ardb+tianoc...@kernel.org; > quic_llind...@quicinc.com; Jeff Brasen > Subject: [PATCH]

Re: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers in uncompressed inner fv.

This patch series already got "reviewed-by" from Laszlo. Could anyone help to merge the changes? Thanks a lot. Thanks Laszlo for reviewing the patches. BR, Wei -Original Message- From: devel@edk2.groups.io On Behalf Of Xu, Wei6 Sent: Monday, November 6, 2023 3:53 PM To:

Re: [edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg: use POST method while provisioning new property.

> On 18. 12. 2023., at 03:33, Mike Maslenkin via groups.io > wrote: > > > Hi Nickle, > >> On 15. 12. 2023., at 04:53, Nickle Wang > > wrote: >> >> Hi Mike, >> >> Per Redfish specification 7.9 POST(create) >> >> "The POST request is submitted to the resource

Re: [edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg: use POST method while provisioning new property.

Hi Nickle, > On 15. 12. 2023., at 04:53, Nickle Wang wrote: > > Hi Mike, > > Per Redfish specification 7.9 POST(create) > > "The POST request is submitted to the resource collection to which the new > resource will belong." > > If this is not a collection resource, we cannot use POST

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, December 18, 2023 #cal-reminder

*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, December 18, 2023 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:*