[edk2-devel] [PATCH 1/2] UefiCpuPkg: Retrive EXTENDED_PROCESSOR_INFORMATION

2024-01-03 Thread duntan
Retrive EXTENDED_PROCESSOR_INFORMATION in the API MpInitLibGetProcessorInfo() of MpInitLibUp instance when the BIT24 of input ProcessorNumber is set. It's to align with the behavior in PEI/DXE MpInitLib Signed-off-by: Dun Tan Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann Cc:

[edk2-devel] [PATCH 2/2] UefiCpuPkg: Check lower 24 bits of ProcessorNumber

2024-01-03 Thread duntan
Check lower 24 bits of ProcessorNumber instead of the value of ProcessorNumber in the API MpInitLibGetProcessorInfo() of MpInitLibUp instance. Lower 24 bits of ProcessorNumber contains the actual processor number. The BIT24 of input ProcessorNumber might be set to indicate if the

[edk2-devel] [PATCH 0/2] Change the usage of input parameter ProcessorNumber in MpInitLibGetProcessorInfo() of MpInitLibUp

2024-01-03 Thread duntan
In this patch set, the usage of input parameter ProcessorNumber in MpInitLibGetProcessorInfo() of MpInitLibUp instance is changed. 1.Retrive EXTENDED_PROCESSOR_INFORMATION in the API MpInitLibGetProcessorInfo() of MpInitLibUp instance when the BIT24 of input ProcessorNumber is set. It's to align

Re: [edk2-devel] [PATCH v5 33/36] OvmfPkg/LoongArchVirt: Support SEC phase

2024-01-03 Thread Chao Li
Hi Bibo, Here are my comments: Thanks, Chao On 2024/1/4 09:49, maobibo wrote: On 2023/12/28 下午6:07, Chao Li wrote: Add SEC code for LoongArch virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann

[edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg/Features: introduce boot option

2024-01-03 Thread Nickle Wang via groups.io
- Introduce Redfish boot option driver and library. This is to support Redfish resource at: /redfish/v1/Systems/SYSTEM_ID/BootOptions - Make ETag parameter as optional parameter in CreatePayloadToPatchResource function. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick

[edk2-devel] [edk2-redfish-client][PATCH 3/4] RedfishClientPkg/Features: introduce boot option collection

2024-01-03 Thread Nickle Wang via groups.io
Introduce Redfish boot option collection driver and library. This is to support Redfish resource at: /redfish/v1/Systems/SYSTEM_ID/BootOptions Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishClientComponents.dsc.inc | 4 +-

[edk2-devel] [edk2-redfish-client][PATCH 2/4] RedfishClientPkg/ConverterLib: fix GCC build error

2024-01-03 Thread Nickle Wang via groups.io
Address below GCC build error: variable 'CsParentJson' set but not used [-Werror=unused-but-set-variable] Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../BootOption.V1_0_4/BootOption.V1_0_4.c | 1005 - .../BootOptionCollection.c

[edk2-devel] [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: add ETag to Redfish resource check function

2024-01-03 Thread Nickle Wang via groups.io
Add ETag parameter to RedfishCheckResourceCommon(). When the ETag from Redfish resource is not changed, feature driver can skip the check function. This helps to improve the feature driver performance. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez ---

[edk2-devel] [edk2-redfish-client][PATCH 0/4] Introduce Redfish boot option drivers

2024-01-03 Thread Nickle Wang via groups.io
Introduction Redfish boot option collection and boot option drivers to support Redfish resource at /redfish/v1/Systems/SYSTEM_ID/BootOptions. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Nickle Wang (4): RedfishClientPkg: add ETag to Redfish resource

Re: [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors

2024-01-03 Thread Abdul Lateef Attar via groups.io
Hi Sami Mujawar,     Looks like current edk2 CI handles the X64, IA32 for both GCC and VS2019 to build DynamicTablesPkg. I can see that TARGET_FMP_FAT_TEST is failed for VS2019 for below PR(which is expected). https://github.com/tianocore/edk2/pull/5215 Thanks AbduL On 04-01-2024

Re: [edk2-devel] [RFC][PATCH 0/2] Introduce HTTPS Platform TLS policy

2024-01-03 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Brown via groups.io > Sent: Wednesday, January 3, 2024 1:47 AM > To: devel@edk2.groups.io; Chang, Abner > Cc: Saloni Kasbekar ; Zachary Clark-williams > ; Nickle Wang ; Igor >

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 00/10] RedfishClientPkg: introduce Redfish HTTP cache library

2024-01-03 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] For this patch set, Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, January 4, 2024 10:31 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH

Re: [edk2-devel] [edk2-redfish-client][PATCH 01/10] RedfishClientPkg: introduce Redfish HTTP cache library

2024-01-03 Thread Nickle Wang via groups.io
Thanks Abner. Version 2 patch series is sent for review. Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Wednesday, January 3, 2024 9:02 PM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nick Ramirez

[edk2-devel] [edk2-redfish-client][PATCH v2 10/10] RedfishClientPkg/RedfishFeatureUtilityLib: use HTTP cache lib

2024-01-03 Thread Nickle Wang via groups.io
Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishFeatureUtilityLib.inf | 3 +- .../Library/RedfishFeatureUtilityLib.h| 21 +- .../RedfishFeatureUtilityInternal.h

[edk2-devel] [edk2-redfish-client][PATCH v2 09/10] RedfishClientPkg/RedfishVersionLib: use HTTP cache lib

2024-01-03 Thread Nickle Wang via groups.io
Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishVersionLib/RedfishVersionLib.inf | 3 ++ .../Include/Library/RedfishVersionLib.h | 5 +--

[edk2-devel] [edk2-redfish-client][PATCH v2 08/10] RedfishClientPkg/EdkIIRedfishResourceConfigLib: use HTTP cache lib

2024-01-03 Thread Nickle Wang via groups.io
Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../EdkIIRedfishResourceConfigLib.inf | 2 ++ .../EdkIIRedfishResourceConfigLib.c | 6 -- 2 files

[edk2-devel] [edk2-redfish-client][PATCH v2 07/10] RedfishClientPkg/Bios: use HTTP cache lib

2024-01-03 Thread Nickle Wang via groups.io
Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +- .../Features/Bios/v1_0_9/Dxe/BiosDxe.c| 82 --- 2 files changed, 38

[edk2-devel] [edk2-redfish-client][PATCH v2 06/10] RedfishClientPkg/Memory: use HTTP cache lib

2024-01-03 Thread Nickle Wang via groups.io
Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c| 70 +++ 2 files changed, 57

[edk2-devel] [edk2-redfish-client][PATCH v2 05/10] RedfishClientPkg/MemoryCollectionDxe: use HTTP cache lib

2024-01-03 Thread Nickle Wang via groups.io
Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../MemoryCollectionDxe.inf | 2 ++ .../MemoryCollectionDxe/MemoryCollectionDxe.c | 26 +-- 2 files changed, 15

[edk2-devel] [edk2-redfish-client][PATCH v2 04/10] RedfishClientPkg/ComputerSystem: use HTTP cache lib

2024-01-03 Thread Nickle Wang via groups.io
Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +- .../v1_5_0/Dxe/ComputerSystemDxe.c| 70 +++ 2 files changed, 57

[edk2-devel] [edk2-redfish-client][PATCH v2 03/10] RedfishClientPkg/ComputerSystemCollectionDxe: use HTTP cache lib

2024-01-03 Thread Nickle Wang via groups.io
Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../ComputerSystemCollectionDxe.inf | 2 ++ .../ComputerSystemCollectionDxe.c | 26 +-- 2 files changed, 15

[edk2-devel] [edk2-redfish-client][PATCH v2 02/10] RedfishClientPkg: use HTTP cache lib

2024-01-03 Thread Nickle Wang via groups.io
Add RedfishHttpCacheLib header file for feature driver to use RedfishHttpCacheLib. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishClientPkg/Include/RedfishCollectionCommon.h | 4 +++- RedfishClientPkg/Include/RedfishResourceCommon.h | 3 ++- 2

[edk2-devel] [edk2-redfish-client][PATCH v2 00/10] RedfishClientPkg: introduce Redfish HTTP cache library

2024-01-03 Thread Nickle Wang via groups.io
v2: Replace "BMC" with "Redfish service" in this patch series. v1: Introduce RedfishHttpCacheLib to improve HTTP GET performance in Redfish feature drivers. Feature drivers often query same Redfish resource multiple times for different purpose. Add HTTP cache mechanism to improve the

[edk2-devel] [edk2-redfish-client][PATCH v2 01/10] RedfishClientPkg: introduce Redfish HTTP cache library

2024-01-03 Thread Nickle Wang via groups.io
Introduce RedfishHttpCacheLib to improve HTTP GET performance in Redfish feature drivers. Feature drivers often query same Redfish resource multiple times for different purpose. Add HTTP cache mechanism to improve the performance. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy

Re: [edk2-devel] [Patch V2 0/3] Move gMpInformationHobGuid from StandaloneMmPkg to UefiCpuPkg.

2024-01-03 Thread duntan
I think it's a limitation of the existing implementation. Currently the HobLength in EFI_HOB_GENERIC_HEADER is UINT16. Thanks, Dun -Original Message- From: Ard Biesheuvel Sent: Wednesday, January 3, 2024 11:11 PM To: Tan, Dun ; Samer El-Haj-Mahmoud ; Jose Marinho Cc: Ard Biesheuvel

Re: [edk2-devel] [PATCH 3/3] StandaloneMmPkg:Remove MpInformation.h

2024-01-03 Thread duntan
Hi Ard, This patch set has been dropped. Another patch set "Create and consume a new gMpInformationHobGuid2 in UefiCpuPkg." is adopted. When the Maximum length 64KB is not enough, there might be more than 1 HOB instance of this gMpInformationHobGuid2. There is no change in ARM related code in

Re: [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors

2024-01-03 Thread Abdul Lateef Attar via groups.io
Hi Sami Mujawar,     Thanks for quick response, update and merge of the patch. Yes, I build DynamicTablesPkg for IA32 and X64 using VS2019(tool-chain VS2019) and also using GCC 11.4 (tool-chain GCC). I'll take a look at edk2 CI. Thanks AbduL I'll take a look at edk2 CI and On 03-01-2024

Re: [edk2-devel] [PATCH v5 33/36] OvmfPkg/LoongArchVirt: Support SEC phase

2024-01-03 Thread maobibo
On 2023/12/28 下午6:07, Chao Li wrote: Add SEC code for LoongArch virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Chao Li Co-authored-by: Xianglai Li Co-authored-by: Bibo Mao

Re: [edk2-devel] [PATCH v5 32/36] OvmfPkg/LoongArchVirt: Add reset system library

2024-01-03 Thread maobibo
On 2023/12/28 下午6:07, Chao Li wrote: This library provides interface related to restart and shudown the LoongArch64 virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Chao Li

Re: [edk2-devel] [PATCH 2/3] ArmPkg: Fix the calculation of the timer period in GenericWatchdogDxe

2024-01-03 Thread Ard Biesheuvel
Hi Rebecca, On Wed, 3 Jan 2024 at 21:44, Rebecca Cran wrote: > > Fix the calculation of the timer period in GenericWatchdogDxe: we need > to multiply before dividing to keep the values as integers. > > Signed-off-by: Rebecca Cran > --- > ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c |

[edk2-devel] [PATCH 2/3] ArmPkg: Fix the calculation of the timer period in GenericWatchdogDxe

2024-01-03 Thread Rebecca Cran via groups.io
Fix the calculation of the timer period in GenericWatchdogDxe: we need to multiply before dividing to keep the values as integers. Signed-off-by: Rebecca Cran --- ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [PATCH 3/3] ArmPkg: Disable watchdog interaction after exiting boot services

2024-01-03 Thread Rebecca Cran via groups.io
Update GenericWatchdogDxe to disable watchdog interaction after exiting boot services. Also, move the mEfiExitBootServicesEvent event to the top of the file with the other static variables. Signed-off-by: Rebecca Cran --- ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 14

[edk2-devel] [PATCH 1/3] ArmPkg: Update GenericWatchdogDxe to allow setting full 48-bit offset

2024-01-03 Thread Rebecca Cran via groups.io
The generic watchdog offset register is 48 bits wide, and can be set by performing two 32-bit writes. Add support for writing the high 16 bits of the offset register and update the signature of the WatchdogWriteOffsetRegister function to take a UINT64 value. Signed-off-by: Rebecca Cran ---

[edk2-devel] [PATCH 0/3] ArmPkg: GenericWatchdogDxe fixes and improvements

2024-01-03 Thread Rebecca Cran via groups.io
Fixes and improvements to GenericWatchdogDxe. PR: https://github.com/tianocore/edk2/pull/5176 Rebecca Cran (3): ArmPkg: Update GenericWatchdogDxe to allow setting full 48-bit offset ArmPkg: Fix the calculation of the timer period in GenericWatchdogDxe ArmPkg: Disable watchdog interaction

Re: [edk2-devel] [PATCH 3/3] StandaloneMmPkg:Remove MpInformation.h

2024-01-03 Thread Oliver Smith-Denny
On 1/3/2024 7:11 AM, Ard Biesheuvel wrote: On Thu, 9 Nov 2023 at 03:51, duntan wrote: Remove MpInformation.h in StandaloneMmPkg since it has been moved to UefiCpuPkg Signed-off-by: Dun Tan Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Ray Ni Doesn't this break the ARM build? Right, this

Re: [edk2-devel] [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default

2024-01-03 Thread Ashish Singhal via groups.io
Hello Saloni, Thanks for the feedback. After the reset, or when we disable configure from menu, GetData returns policy to static as the enum value is 0. However, setting value as static does not have any benefit as it forces to reuse the old network settings. Using DHCP really mimics the reset

Re: [edk2-devel] [PATCH 3/3] StandaloneMmPkg:Remove MpInformation.h

2024-01-03 Thread Ard Biesheuvel
On Thu, 9 Nov 2023 at 03:51, duntan wrote: > > Remove MpInformation.h in StandaloneMmPkg since > it has been moved to UefiCpuPkg > > Signed-off-by: Dun Tan > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Ray Ni Doesn't this break the ARM build? > --- >

Re: [edk2-devel] [PATCH v3 1/1] OvmfPkg/VirtNorFlashDxe: sanity-check variables

2024-01-03 Thread Gerd Hoffmann
Hi, > Second (and worse): the bug. In "OvmfPkg/RiscVVirt/VarStore.fdf.inc", it > turns out that we *still* generate the gEfiVariableGuid varstore header > signature, in case SECURE_BOOT_ENABLE is FALSE. For some reason, commit > 92b27c2e6ada ("OvmfPkg/RiscVVirt: Add build files for Qemu Virt >

Re: [edk2-devel] [Patch V2 0/3] Move gMpInformationHobGuid from StandaloneMmPkg to UefiCpuPkg.

2024-01-03 Thread Ard Biesheuvel
(cc Samer and Jose) Hello Dun Tan, On Fri, 17 Nov 2023 at 10:57, Tan, Dun wrote: > > Hi Ard, > > I'm working on moving gMpInformationHobGuid from StandaloneMmPkg to > UefiCpuPkg in this patch series. Currently in Edk2, the HOB is only consumed > by StandaloneMmCpu.inf. > > As we know that

Re: [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors

2024-01-03 Thread Sami Mujawar
Hi Abdul, I have merged this series as d7d4f09ff815..2576cbafec98. Now that support for X64 and IA32 is enabled in DynamicTablesPkg, it would be good to enable that in the edk2 CI. That way we do not accidently break the builds. To enable edk2 CI for AARCH64 using GCC, I had made the change at

[edk2-devel] Event: TianoCore edk2-test Bug Triage Meeting - Thursday, January 4, 2024 #cal-reminder

2024-01-03 Thread Group Notification
*Reminder: TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, January 4, 2024 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/94348061758?pwd=Q3RDeFA5K2JFaU5jdWUxc1FnaGdyUT09=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com (

[edk2-devel] [PATCH 4/4] OvmfPkg/RiscVVirt: Override Sstc extension

2024-01-03 Thread Sunil V L
Override Sstc extension and use SBI calls itself by default for RISC-V qemu virt platform. Cc: Andrei Warkentin Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Laszlo Ersek Signed-off-by: Sunil V L --- OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc | 2 +- 1 file changed, 1 insertion(+), 1

[edk2-devel] [PATCH 3/4] UefiCpuPkg/CpuTimerDxeRiscV64: Add support for Sstc

2024-01-03 Thread Sunil V L
Sstc extension allows to program the timer and receive the interrupt without using an SBI call. This reduces the latency to generate the timer interrupt. So, detect whether Sstc extension is supported and use the stimecmp register directly to program the timer interrupt. Cc: Gerd Hoffmann Cc:

[edk2-devel] [PATCH 2/4] MdePkg/BaseLib: RISC-V: Add function to update stimecmp register

2024-01-03 Thread Sunil V L
stimecmp is a CSR supported only when Sstc extension is supported by the platform. This register can be used to set the timer interrupt directly in S-mode instead of going via SBI call. Add a function to update this register. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Andrei

[edk2-devel] [PATCH 1/4] MdePkg.dec: RISC-V: Define override bit for Sstc extension

2024-01-03 Thread Sunil V L
Define the BIT 1 as the override bit for Sstc extension. This will be used by the timer driver to decide whether to use SBI calls or direct CSR access to configure the timer. Cc: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu Cc: Andrei Warkentin Signed-off-by: Sunil V L ---

[edk2-devel] [PATCH 0/4] RISC-V: Add support for Sstc extension

2024-01-03 Thread Sunil V L
This series adds the support for RISV-V Sstc extension in EDK2 timer implementation. Sstc extension allows S-mode software to program the timer directly without using SBI calls. Currently, PCD variable is used to detect whether feature is enabled. By default the feature is enabled and platforms

Re: [edk2-devel] [PATCH v2 0/3] EmbeddedPkg ReallocatePool and Mock changes

2024-01-03 Thread Ard Biesheuvel
On Thu, 28 Dec 2023 at 21:47, Jeff Brasen wrote: > > Adding Mock support for DtPlatformLoaderLib and changing ci.yaml to support > this > Adding ReallocatePool support to PrePi Library. > > Passing CI in https://github.com/tianocore/edk2/pull/5197 > > Change log > v2 - > Fix uncrustify errors

Re: [edk2-devel] [edk2-platforms: PATCH v4] Marvell/Armada80x0Db: Fix build

2024-01-03 Thread Ard Biesheuvel
On Sun, 31 Dec 2023 at 12:07, Marcin Wojtas wrote: > > Commit ec5de71d83 ("Silicon/Marvell: Restructure package") > broke Armada80x0Db build by unintentional removal of > device tree component. Restore it. > > Signed-off-by: Marcin Wojtas Applied, thanks. > --- >

Re: [edk2-devel] [PATCH] Maintainers: Update my email address

2024-01-03 Thread Ard Biesheuvel
On Tue, 26 Dec 2023 at 00:03, Marcin Wojtas wrote: > > I no longer use m...@semihalf.com email. Update Marvell entry with > my alternative address. As there are more than one SolidRun > pltaforms, on the occasion extend the scope. > > Signed-off-by: Marcin Wojtas Applied, thanks. > --- >

Re: [edk2-devel] [PATCH v3 1/1] OvmfPkg/VirtNorFlashDxe: sanity-check variables

2024-01-03 Thread Laszlo Ersek
On 1/3/24 14:09, Laszlo Ersek wrote: > On 1/3/24 13:56, Laszlo Ersek wrote: > >> (8) Apologies if it was me who suggested ALIGN_VALUE() previously, but >> this is, in effect, an unchecked addition. I can't off-hand see evidence >> that it can never overflow (the previous checks don't seem to

Re: [edk2-devel] [PATCH v3 1/1] OvmfPkg/VirtNorFlashDxe: sanity-check variables

2024-01-03 Thread Laszlo Ersek
On 1/3/24 13:56, Laszlo Ersek wrote: > (8) Apologies if it was me who suggested ALIGN_VALUE() previously, but > this is, in effect, an unchecked addition. I can't off-hand see evidence > that it can never overflow (the previous checks don't seem to prevent an > overflow here), so I suggest: > >

Re: [edk2-devel] [edk2-redfish-client][PATCH 00/10] RedfishClientPkg: introduce Redfish HTTP cache library

2024-01-03 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Besides the comment given to patch 1/10, for all others Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Wednesday, January 3, 2024 8:02 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez >

Re: [edk2-devel] [edk2-redfish-client][PATCH 01/10] RedfishClientPkg: introduce Redfish HTTP cache library

2024-01-03 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Nickle, I have no problem with this feature as we have been using this for a while. Per discussion off line, HttpCacheLibrary would be replaced with protocol version later. I would just give my RB to this patch as this patch is sent for cleaning up the

Re: [edk2-devel] [PATCH v3 1/1] OvmfPkg/VirtNorFlashDxe: sanity-check variables

2024-01-03 Thread Laszlo Ersek
On 12/14/23 16:31, Gerd Hoffmann wrote: > Extend the ValidateFvHeader function, additionally to the header checks > walk over the list of variables and sanity check them. > > In case we find inconsistencies indicating variable store corruption > return EFI_NOT_FOUND so the variable store will be

Re: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to RFC7323

2024-01-03 Thread Ren, Suqiang
Add the Pull Request link: https://github.com/tianocore/edk2/pull/5190. Thanks Ren, Suqiang -Original Message- From: devel@edk2.groups.io On Behalf Of Ren, Suqiang Sent: Tuesday, January 2, 2024 2:33 PM To: devel@edk2.groups.io; Ren, SuqiangX Cc: Kinney, Michael D ; Gao, Liming ; Liu,

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the definition of CapsuleImageSize on EFI_CAPSULE_HEADER

2024-01-03 Thread Ren, Suqiang
Hi Liming, Thanks for reminding me. Here are the PR for test CI: https://github.com/tianocore/edk2/pull/5189. Could you help to merge this patch? Thanks Ren, Suqiang -Original Message- From: gaoliming Sent: Wednesday, January 3, 2024 8:50 AM To: Ren, SuqiangX ;

[edk2-devel] [edk2-redfish-client][PATCH 00/10] RedfishClientPkg: introduce Redfish HTTP cache library

2024-01-03 Thread Nickle Wang via groups.io
Introduce RedfishHttpCacheLib to improve HTTP GET performance in Redfish feature drivers. Feature drivers often query same Redfish resource multiple times for different purpose. Add HTTP cache mechanism to improve the performance. An enhanced Redfish HTTP driver is under development and it will

[edk2-devel] [edk2-redfish-client][PATCH 10/10] RedfishClientPkg/RedfishFeatureUtilityLib: use HTTP cache lib

2024-01-03 Thread Nickle Wang via groups.io
Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishFeatureUtilityLib.inf | 3 +- .../Library/RedfishFeatureUtilityLib.h| 21 +- .../RedfishFeatureUtilityInternal.h

[edk2-devel] [edk2-redfish-client][PATCH 09/10] RedfishClientPkg/RedfishVersionLib: use HTTP cache lib

2024-01-03 Thread Nickle Wang via groups.io
Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishVersionLib/RedfishVersionLib.inf | 3 ++ .../RedfishVersionLib/RedfishVersionLib.c | 30 ++- 2 files changed, 25

[edk2-devel] [edk2-redfish-client][PATCH 08/10] RedfishClientPkg/EdkIIRedfishResourceConfigLib: use HTTP cache lib

2024-01-03 Thread Nickle Wang via groups.io
Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../EdkIIRedfishResourceConfigLib.inf | 2 ++ .../EdkIIRedfishResourceConfigLib.c | 6 -- 2 files

[edk2-devel] [edk2-redfish-client][PATCH 07/10] RedfishClientPkg/Bios: use HTTP cache lib

2024-01-03 Thread Nickle Wang via groups.io
Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +- .../Features/Bios/v1_0_9/Dxe/BiosDxe.c| 80 --- 2 files changed, 37

[edk2-devel] [edk2-redfish-client][PATCH 06/10] RedfishClientPkg/Memory: use HTTP cache lib

2024-01-03 Thread Nickle Wang via groups.io
Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c| 70 +++ 2 files changed, 57

[edk2-devel] [edk2-redfish-client][PATCH 05/10] RedfishClientPkg/MemoryCollectionDxe: use HTTP cache lib

2024-01-03 Thread Nickle Wang via groups.io
Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../MemoryCollectionDxe.inf | 2 ++ .../MemoryCollectionDxe/MemoryCollectionDxe.c | 24 +-- 2 files changed, 14

[edk2-devel] [edk2-redfish-client][PATCH 04/10] RedfishClientPkg/ComputerSystem: use HTTP cache lib

2024-01-03 Thread Nickle Wang via groups.io
Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +- .../v1_5_0/Dxe/ComputerSystemDxe.c| 70 +++ 2 files changed, 57

[edk2-devel] [edk2-redfish-client][PATCH 03/10] RedfishClientPkg/ComputerSystemCollectionDxe: use HTTP cache lib

2024-01-03 Thread Nickle Wang via groups.io
Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../ComputerSystemCollectionDxe.inf | 2 ++ .../ComputerSystemCollectionDxe.c | 24 +-- 2 files changed, 14

[edk2-devel] [edk2-redfish-client][PATCH 02/10] RedfishClientPkg: use HTTP cache lib

2024-01-03 Thread Nickle Wang via groups.io
Add RedfishHttpCacheLib header file for feature driver to use RedfishHttpCacheLib. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishClientPkg/Include/RedfishCollectionCommon.h | 4 +++- RedfishClientPkg/Include/RedfishResourceCommon.h | 3 ++- 2

[edk2-devel] [edk2-redfish-client][PATCH 01/10] RedfishClientPkg: introduce Redfish HTTP cache library

2024-01-03 Thread Nickle Wang via groups.io
Introduce RedfishHttpCacheLib to improve HTTP GET performance in Redfish feature drivers. Feature drivers often query same Redfish resource multiple times for different purpose. Add HTTP cache mechanism to improve the performance. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy

[edk2-devel] [edk2-redfish-client][PATCH 00/10] RedfishClientPkg: introduce Redfish HTTP cache library

2024-01-03 Thread Nickle Wang via groups.io
Introduce RedfishHttpCacheLib to improve HTTP GET performance in Redfish feature drivers. Feature drivers often query same Redfish resource multiple times for different purpose. Add HTTP cache mechanism to improve the performance. An enhanced Redfish HTTP driver is under development and it will

Re: [edk2-devel] [PATCH v2 2/2] DynamicTablesPkg: Fix IA32 compilation errors

2024-01-03 Thread Sami Mujawar
Hi Abdul, Thank you for this patch. I have some minor suggestions  that I will fix before merging. Otherwise this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 03/01/2024 09:52 am, Abdul Lateef Attar wrote: From: Abdul Lateef Attar Add the support for X64

Re: [edk2-devel] [PATCH v2 1/2] DynamicTablesPkg: Fix X64 compilation errors

2024-01-03 Thread Sami Mujawar
Hi Abdul, Thank you for this patch. I have some minor suggestions  that I will fix before merging. Otherwise this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 03/01/2024 09:52 am, Abdul Lateef Attar wrote: From: Abdul Lateef Attar Add the support for X64

Re: [edk2-devel] [PATCH V2 0/2] Add DECLARE_LENGTH opcode of dependency expression

2024-01-03 Thread Li, Yi
Hi Liming, I created a PR and CI passed, could you help merge it? https://github.com/tianocore/edk2/pull/5210 Thanks, Yi -Original Message- From: gaoliming Sent: Wednesday, January 3, 2024 8:52 AM To: Xu, Wei6 ; Li, Yi1 ; devel@edk2.groups.io Cc: Kinney, Michael D ; Liu, Zhiguang

Re: [edk2-devel] [PATCH v5 29/36] OvmfPkg/LoongArchVirt: Add real time clock library

2024-01-03 Thread maobibo
On 2023/12/28 下午6:07, Chao Li wrote: This library is provides real time clock for LoongArch virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Chao Li Co-authored-by: Baoqi Zhang

Re: [edk2-devel] [PATCH v5 27/36] OvmfPkg/LoongArchVirt: Add serial port hook library

2024-01-03 Thread maobibo
On 2023/12/28 下午6:07, Chao Li wrote: Add a serial port hook library in LoongArchVirt named Fdt16550SerialProtHookLib, this library is referenced from ArmVirtPkg. LoongArch QEMU virtual machine uses register of LOONGARCH_CSR_KS1 to transfer serial port base addres from the PEI phase to the

[edk2-devel] [PATCH v2 1/2] DynamicTablesPkg: Fix X64 compilation errors

2024-01-03 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar Add the support for X64 compilation to the CI. Fix the compilation errors. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar --- DynamicTablesPkg/DynamicTables.dsc.inc | 17 - DynamicTablesPkg/DynamicTablesPkg.dsc

[edk2-devel] [PATCH v2 2/2] DynamicTablesPkg: Fix IA32 compilation errors

2024-01-03 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar Add the support for X64 compilation to the CI. - Fix the signed and unsigned variable comparision. warning C4018: '>': signed/unsigned mismatch - Fix the NOOPT build error for IA32 by replacing 64bit shift operator with LShiftU64. Cc: Pierre Gondois Cc: Sami

[edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors

2024-01-03 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar PR: https://github.com/tianocore/edk2/pull/5209 v2: Fix the IA32 compilation errors. v1: Fix the X64 compilation errors. Cc: Pierre Gondois pierre.gond...@arm.com Cc: Sami Mujawar sami.muja...@arm.com Cc: Abdul Lateef Attar Abdul Lateef Attar (2): DynamicTablesPkg:

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 0/3] change method for provisioning + minor fixes

2024-01-03 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Mike, is https://bugzilla.tianocore.org/show_bug.cgi?id=4625 BZ ticket for this patch set? Abner > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, December 19, 2023 9:00 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ;

Re: [edk2-devel] [PATCH v5 34/36] OvmfPkg/LoongArchVirt: Support PEI phase

2024-01-03 Thread maobibo
On 2023/12/28 下午6:07, Chao Li wrote: Platfrom PEI module for LoongArch platfrom initialization. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Chao Li Co-authored-by: Xianglai Li