Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of the EFI_NVDIMM_LABEL

Hi Liming, Thanks! I created a PR: https://github.com/tianocore/edk2/pull/5191 Could you help push it? B.R. Junfeng -Original Message- From: gaoliming Sent: Thursday, January 11, 2024 10:19 AM To: devel@edk2.groups.io; Guan, JunfengX Cc: Kinney, Michael D ; Liu, Zhiguang ; Li,

Re: [edk2-devel] [PATCH 5/5] Platform/RaspberryPi: Update PCIe MMIO window for DT

On Thu, 11 Jan 2024 at 00:52, Jeremy Linton wrote: > > Since we are updating the DT memory map and telling it how > we have configured the PCIe, there isn't a reason for moving the > MMIO window. In fact this appears to fix OpenBSD+DT as well as > it makes the linux XHCI reset sequence happier. >

Re: [edk2-devel] [PATCH 4/5] Platform/RaspberryPi: Give the user control over the XHCI mailbox

On Thu, 11 Jan 2024 at 00:52, Jeremy Linton wrote: > > Its a complete tossup whether removing the mailbox call after we have > set up the XHCI works for a given kernel+distro in DT mode. So lets > give users which want to try DT the option of flipping this on/off. > > Users that don't want to

Re: [edk2-devel] [PATCH 1/5] Platform/RaspberryPi/DualSerialPortLib: Always configure the pl011

Hi Jeremy, Thanks for the patches. On Thu, 11 Jan 2024 at 00:52, Jeremy Linton wrote: > > The rpi's config.txt controls which uart (pl011, or miniuart) is > selected as the console. TFA and edk2 follow its lead, but if the > miniuart is selected as the primary and the machine is booted in ACPI

[edk2-devel] [PATCH] MdePkg: Update ReceiveData and SendData function description

From: Qingyu Shang Refer to Uefi spec 2.10 section 13.14, update the parameter 'MediaId' description for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL function ReceiveData and SendData. Signed-off-by: Qingyu Shang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu ---

Re: [edk2-devel] [PATCH v1 2/4] StandaloneMmPkg/Hob: Integer Overflow in CreateHob()

On Thu, 11 Jan 2024 at 07:52, Ard Biesheuvel wrote: > > On Thu, 11 Jan 2024 at 06:15, wrote: > > > > From: Gerd Hoffmann > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166 > > > > Fix integer overflow in various CreateHob instances. > > Fixes: CVE-2022-36765 > > > > The

[edk2-devel] [PATCH 1/2] CloudHv: Add CloudHv support to PlatformScanE820 utility function.

Signed-off-by: Thomas Barrett --- OvmfPkg/Library/PlatformInitLib/MemDetect.c | 95 ++--- 1 file changed, 65 insertions(+), 30 deletions(-) diff --git a/OvmfPkg/Library/PlatformInitLib/MemDetect.c b/OvmfPkg/Library/PlatformInitLib/MemDetect.c index 662e7e85bb..76a9dc9211 100644

[edk2-devel] [PATCH 2/2] CloudHv: Update PlatformAddressWidthInitialization logic

When booting CloudHv guests with greater than 1TiB of high memory, the PlatformAddressWidthInitialization function incorrect calculates the address width using the overflowed 24-bit CMOS register rather than the E820 entries. Signed-off-by: Thomas Barrett --- OvmfPkg/CloudHv/CloudHvX64.dsc

Re: [edk2-devel] [PATCH v1 3/4] EmbeddedPkg/Hob: Integer Overflow in CreateHob()

On Thu, 11 Jan 2024 at 06:15, wrote: > > From: Gerd Hoffmann > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166 > > Fix integer overflow in various CreateHob instances. > Fixes: CVE-2022-36765 > > The CreateHob() function aligns the requested size to 8 > performing the following

[edk2-devel] Cancelled Event: TianoCore Community Meeting EMEA/NAMO - Thursday, January 11, 2024 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20231222T233358Z

Re: [edk2-devel] TianoCore Community Meeting - call for topics

Meeting canceled. Mike > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, January 10, 2024 10:37 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: TianoCore Community Meeting - call for topics > > Any topics for the TianoCore Community meeting this week?

Re: [edk2-devel] [PATCH v1 2/4] StandaloneMmPkg/Hob: Integer Overflow in CreateHob()

On Thu, 11 Jan 2024 at 06:15, wrote: > > From: Gerd Hoffmann > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166 > > Fix integer overflow in various CreateHob instances. > Fixes: CVE-2022-36765 > > The CreateHob() function aligns the requested size to 8 > performing the following

[edk2-devel] [PATCH v1 4/4] MdeModulePkg/Hob: Integer Overflow in CreateHob()

From: Gerd Hoffmann REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166 Fix integer overflow in various CreateHob instances. Fixes: CVE-2022-36765 The CreateHob() function aligns the requested size to 8 performing the following operation: ``` HobLength = (UINT16)((HobLength + 0x7) &

[edk2-devel] [PATCH v1 3/4] EmbeddedPkg/Hob: Integer Overflow in CreateHob()

From: Gerd Hoffmann REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166 Fix integer overflow in various CreateHob instances. Fixes: CVE-2022-36765 The CreateHob() function aligns the requested size to 8 performing the following operation: ``` HobLength = (UINT16)((HobLength + 0x7) &

[edk2-devel] [PATCH v1 2/4] StandaloneMmPkg/Hob: Integer Overflow in CreateHob()

From: Gerd Hoffmann REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166 Fix integer overflow in various CreateHob instances. Fixes: CVE-2022-36765 The CreateHob() function aligns the requested size to 8 performing the following operation: ``` HobLength = (UINT16)((HobLength + 0x7) &

[edk2-devel] [PATCH v1 1/4] UefiPayloadPkg/Hob: Integer Overflow in CreateHob()

From: Gerd Hoffmann REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166 Fix integer overflow in various CreateHob instances. Fixes: CVE-2022-36765 The CreateHob() function aligns the requested size to 8 performing the following operation: ``` HobLength = (UINT16)((HobLength + 0x7) &

[edk2-devel] [PATCH v1 0/4] Bz4166: Integer Overflow in CreateHob()

From: Gua Guo Fix Integer Overflow for CVE-2022-36765 1. UefiPayloadPkg/Hob: Integer Overflow in CreateHob() 2. StandaloneMmPkg/Hob: Integer Overflow in CreateHob() 3. EmbeddedPkg/Hob: Integer Overflow in CreateHob() 4. MdeModulePkg/Hob: Integer Overflow in CreateHob() Gerd Hoffmann (4):

Re: [edk2-devel] [Patch V2] UefiCpuPkg:Limit PhysicalAddressBits in speicial case

Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Tan, Dun > Sent: Thursday, January 11, 2024 10:11 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V2] UefiCpuPkg:Limit PhysicalAddressBits in speicial case > >

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - Thursday, January 11, 2024 #cal-reminder

*Reminder: TianoCore Community Meeting - APAC/NAMO* *When:* Thursday, January 11, 2024 7:30pm to 8:30pm (UTC-08:00) America/Los Angeles *Where:*

回复: [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus function description

Junfeng: I add push label for this PR. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Junfeng Guan > 发送时间: 2024年1月11日 9:14 > 收件人: Gao, Liming ; devel@edk2.groups.io > 抄送: Kinney, Michael D ; Liu, Zhiguang > ; Li, Yi1 > 主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Update

回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of the EFI_NVDIMM_LABEL

Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Junfeng Guan > 发送时间: 2023年12月27日 9:57 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Yi Li > > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of the > EFI_NVDIMM_LABEL

回复: [edk2-devel] [PATCH 1/1] MdePkg: Updated the comments of EFI_SYSTEM_TABLE and ReadKeyStroke

Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Junfeng Guan > 发送时间: 2023年12月21日 10:02 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Yi Li > > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Updated the comments of > EFI_SYSTEM_TABLE and

[edk2-devel] [Patch V2] UefiCpuPkg:Limit PhysicalAddressBits in speicial case

When creating smm page table, limit maximum supported physical address bits returned by CalculateMaximumSupportAddress() to 47 if 5-Level Paging is disabled. When 5-Level Paging is disabled and the PhysicalAddressBits retrived from CPU HOB or CpuId is bigger than 47, and since virtual addresses

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuMpPei: Don't write CR3 in ConvertMemoryPageToNotPresent

Thanks, Ray > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, January 10, 2024 7:57 PM > To: Liu, Zhiguang ; devel@edk2.groups.io > Cc: Ni, Ray ; Kumar, Rahul R ; > Gerd Hoffmann > Subject: Re: [PATCH] UefiCpuPkg/CpuMpPei: Don't write CR3 in > ConvertMemoryPageToNotPresent >

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix issue that IsModified is wrongly set in PageTableMap

> This function is incredibly complicated, so reviewing this patch is > hard, even after reading the bugzilla ticket. > > The commit message is useless. It should contain a brief description of > the problem, and how the fix resolves the problem. > > The documentation of the

Re: [edk2-devel] [PATCH] UefiCpuPkg:Limit PhysicalAddressBits in speicial case

Hi Gerd, Thanks for your comments. I agree with your opinion. Will change the code and related comments in V2 patch. Thanks, Dun -Original Message- From: Gerd Hoffmann Sent: Wednesday, January 10, 2024 6:55 PM To: Tan, Dun Cc: devel@edk2.groups.io; Ni, Ray ; Laszlo Ersek ; Kumar,

[edk2-devel] [PATCH v1 1/1] PrmPkg/PrmInfo: Drop -r parameter

From: Michael Kubacki The "-r" parameter was not added to the application so remove it from the help string. The standards section is also updated to point to the current specification location on uefi.org. Cc: Nate DeSimone Cc: Ankit Sinha Signed-off-by: Michael Kubacki ---

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus function description

Hi Liming, Thanks! I created a PR: https://github.com/tianocore/edk2/pull/5248 Could you help push it? B.R. Junfeng -Original Message- From: gaoliming Sent: Wednesday, January 10, 2024 2:19 PM To: devel@edk2.groups.io; Guan, JunfengX Cc: Kinney, Michael D ; Liu, Zhiguang ; Li,

[edk2-devel] [PATCH] Platform/RaspberryPi: Enable FPDT data on RPi4

FPDT data gives an approximation of how long each stage of the firmware boot takes. Since the RPi has a generic timer this is a fairly accurate timestamp from the point where edk2 takes over, which is a few ms from actual power on. While its not perfect its sufficiently granular that a command

[edk2-devel] [RFC 3/6] Platform/RasberryPi: Create I2C driver bound to RTC

Now that we have a generic Bcm I2C driver lets instantiate one against a possible RTC hat on the pi4. Signed-off-by: Jeremy Linton --- .../Drivers/BcmI2CPlatform/BcmI2CPlatform.c | 127 ++ .../Drivers/BcmI2CPlatform/BcmI2CPlatform.inf | 54 2 files changed, 181

[edk2-devel] [RFC 4/6] Silicon/Maxim: Fix runtime issues

The Ds1307 is ideally a runtime RTC but its use of the I2C protocol might make it better if it updated the I2C_MASTER_PROTOCOL callbacks it uses, although... hmmm maybe think about this a bit more. Signed-off-by: Jeremy Linton --- .../Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c | 36

[edk2-devel] [RFC 2/6] Silicon/Bcm283x: Add core I2C drivers

There are a number of I2C interfaces on the rpi, some of which are available on the GPIO connector and are utilized by various HATs. In particular we are interested in the RTCs (usually based on DS1037) which are attached to GPIO2/3 which can be pin muxed to I2C #1. This commit adds a basic

[edk2-devel] [RFC 5/6] Platform/RasberryPi: Add I2C1 to uefi runtime memory map

We intend to allow the OS to update the RTC after exit boot services. THis means we need to assure that the I2C IO map is marked correctly. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 8 1 file changed, 8 insertions(+) diff --git

[edk2-devel] [RFC 6/6] Platform/RaspberryPi: Add menu and build options for HW RTC

Now that the i2c drivers, config setup, and DS1307 driver are in place, lets add the drivers to the build. We also add a menu item to enable/disable it since the device I have: https://www.amazon.com/Makerfire%C2%AE-Raspberry-Module-DS1307-Battery/dp/B00ZOXWHK4 Doesn't utilize the HAT protocol

[edk2-devel] [RFC 0/6] RasberryPi: RTC HAT support

There are a number of Dallas 1307 based RTC HATs available for the RPi that don't follow the HAT ID protocol but are simple, inexpensive and widely available. Lets add an I2C driver and then allow the user to enable them in the advanced menu. Once enabled and detected we then dynamically swap them

[edk2-devel] [RFC 1/6] Silicon/Bcm283x: Document the I2C registers

Since we are now using I2C in edk2, its helpful if we document the register names. Signed-off-by: Jeremy Linton --- .../Include/IndustryStandard/Bcm2836.h| 34 +++ 1 file changed, 34 insertions(+) diff --git a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h

[edk2-devel] [PATCH 3/7] Platform/RaspberryPi: Add constants for controlling SPI

Add the #defines needed to access the SPI interface documented in the BCM2711 Peripheral guide chapter 8. Signed-off-by: Jeremy Linton --- .../Include/IndustryStandard/Bcm2836.h| 34 +++ 1 file changed, 34 insertions(+) diff --git

[edk2-devel] [PATCH 5/7] Platform/RaspberryPi: Add SPI/GPIO to memory map

A large reason for using the SPI flash on this platform is that it can be updated without OS interference at rutime. In order for that to happen we need both the SPI, as well as the GPIO which is used to change the pinmux from the PWM device to SPI added to the UEFI memory map as being used by the

[edk2-devel] [PATCH 6/7] Platform/RaspberryPi: Allow pin function selection at runtime

Update GpioLib slightly so that we can change the GPIO pin muxing at runtime. For the moment only the GpioPinFuncGet/Set() routines are used at runtime, and only by the Variable service. Signed-off-by: Jeremy Linton --- .../Broadcom/Bcm283x/Include/Library/GpioLib.h | 6 ++

[edk2-devel] [PATCH 7/7] Platform/RaspberryPi: Add SPI flash variable store.

The RPi4 has a 512KB SPI flash, which depending on RPi and firmware revision has 300-180K free. We can use this storage to persist variables when the OS is running or over firmware upgrades. The problem is that the SPI is pin mux'ed with the PWM audio, so we want to leave the PWM configured for OS

[edk2-devel] [PATCH 1/7] Platform/RaspberryPi: Move GPIO/SPI/I2C to SSDT

The UEFI firmware uses the GPIO port for the fan and real soon now the runtime SPI variable store. As such we need to be able to either isolate those devices from the OS or we risk clashing with OS's that reconfigure the GPIO pins. Ideally we would just rip this out and use _DSM() or just

[edk2-devel] [PATCH 2/7] Platform/RaspberryPi: Add menu item to enable/disable GPIO

Now that the GPIO devices are in their own SSDT lets add a menu item for the rpi4 to enable/disable it. For the rpi3 the SSDT is always exported. Signed-off-by: Jeremy Linton --- .../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 17 -

[edk2-devel] [PATCH 4/7] Platform/RaspberryPi: Add mailbox cmd to control audio amp

The lower level firmware can enable/disable a LDO audio amp, which allows us to mute/unmute audio output while the firmware is running. Signed-off-by: Jeremy Linton --- .../Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 60 ++- .../Include/IndustryStandard/RpiMbox.h| 1 +

[edk2-devel] [PATCH 0/7] RaspberryPi: SPI Variables, again

There is a 512KB SPI flash EEPROM on the RPi4, which is used to hold the early boot firmware. Versions of this this firmware which predate the network recovery have 160-300+KB unused, which is a perfect place to drop a UEFI variable store. This code scans the region and makes the decision at

[edk2-devel] [PATCH 1/5] Platform/RaspberryPi/DualSerialPortLib: Always configure the pl011

The rpi's config.txt controls which uart (pl011, or miniuart) is selected as the console. TFA and edk2 follow its lead, but if the miniuart is selected as the primary and the machine is booted in ACPI mode the baud/etc is never configured for the pl011. The linux kernel won't reconfigure it either

[edk2-devel] [PATCH 5/5] Platform/RaspberryPi: Update PCIe MMIO window for DT

Since we are updating the DT memory map and telling it how we have configured the PCIe, there isn't a reason for moving the MMIO window. In fact this appears to fix OpenBSD+DT as well as it makes the linux XHCI reset sequence happier. Signed-off-by: Jeremy Linton ---

[edk2-devel] [PATCH 4/5] Platform/RaspberryPi: Give the user control over the XHCI mailbox

Its a complete tossup whether removing the mailbox call after we have set up the XHCI works for a given kernel+distro in DT mode. So lets give users which want to try DT the option of flipping this on/off. Users that don't want to have to deal with DT, can use ACPI. Signed-off-by: Jeremy Linton

[edk2-devel] [PATCH 0/5] Platform/RaspberryPi: Various minor fixes

This includes a change to always initialize the PL011 to the configured baud (which should be 115200 for the SBSA UART), which fixes linux's assumption that SBSA UARTs are pre-programmed for 115200. This in turn (re)enables the PL011 when the console is on the miniuart per the config.txt file.

[edk2-devel] [PATCH 2/5] Silicon/Broadcom/BcmGenetDxe: Suppress some bogus compiler warnings

Some recent GCC revisions will throw warnings about values being used before being initialized. But in the case where the lack of initialization is the result of the called function returning error status the EFI_ERROR() macro/error seems to confuse the compiler about the fact that the value is

[edk2-devel] [PATCH 3/5] Platform/RaspberryPi: Cleanup menu visibility

Lets allow some of these options to change when the system is in ACPI+DT mode. Plus the fan temp should be disabled when ACPI isn't enabled. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [edk2-devel] [RFC PATCH v1 00/20] DynamicTablesPkg: Prepare to add RISC-V support

> > It looks like instead of moving the common code to > EObjNameSpaceStandard namespace or a new (Arch? Common?) namespace, > you're renaming the entire EObjNameSpaceArm namespace to > EObjNameSpaceArch. It seems to me that if ARM code vs. common code is > being separated out, then the

Re: [edk2-devel] Memory Attribute for depex section

On Wed, Jan 10, 2024 at 1:45 PM Laszlo Ersek wrote: > > (+ Andrew) > > On 1/10/24 14:09, Laszlo Ersek wrote: > > > I think that keeping the depex section read-only is valuable, so I'd > > rule out #2. I'd also not start with option #1 -- copying the depex to > > heap memory, just so this

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Initialise serial port early in StandaloneMmEntryPoint

On 1/10/24 11:16, levi.yun wrote: Hi, Laszlo. This will keep initing the serial port upon every API call until the global variable becomes writeable, and then the next API call will init the serial port for one last time, and also prevent further page table checks. The CheckWritable() function

[edk2-devel] TianoCore Community Meeting - call for topics

Any topics for the TianoCore Community meeting this week? Mike -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113539): https://edk2.groups.io/g/devel/message/113539 Mute This Topic: https://groups.io/mt/103646667/21656 Group Owner:

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Fix raw strings containing valid escape characters

On 1/9/2024 11:52 PM, Huang, Yanbo wrote: @Gao, Liming @'Rebecca Cran' Could you please help to merge this PR? BaseTools: Fix raw strings containing valid escape characters by YuweiChen1110 · Pull Request #5238 · tianocore/edk2

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Initialise serial port early in StandaloneMmEntryPoint

Hi, Laszlo. This will keep initing the serial port upon every API call until the global variable becomes writeable, and then the next API call will init the serial port for one last time, and also prevent further page table checks. The CheckWritable() function is an implementation detail. In

Re: [edk2-devel] [PATCH V1 1/1] UefiCpuPkg/ResetVector: Cache Disable should not be set by default in CR0

Disabling cache by default results in violation of BTG protections (if BTG enabled). BIOS cannot assume that cache is disabled before it executes as ACM may be required to enable NEM. Whatever solution needs to be done here cannot evict ACM-enabled NEM. Why is boot time increasing? In this

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Initialise serial port early in StandaloneMmEntryPoint

On 1/10/24 17:13, levi.yun wrote: >> My personal conclusion in that thread was [1], and correspondingly, >> commit 5087a0773645 ("ArmVirtPkg/FdtPL011SerialPortLib: initialize >> implicitly", 2023-10-07). In the end, the only tractable solution was to >> initialize the serial port (hardware, and

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Initialise serial port early in StandaloneMmEntryPoint

My personal conclusion in that thread was [1], and correspondingly, commit 5087a0773645 ("ArmVirtPkg/FdtPL011SerialPortLib: initialize implicitly", 2023-10-07). In the end, the only tractable solution was to initialize the serial port (hardware, and library instance) exactly once, in (a) the

[edk2-devel] Event: TianoCore Community Meeting EMEA/NAMO - Thursday, January 11, 2024 #cal-reminder

*Reminder: TianoCore Community Meeting EMEA/NAMO* *When:* Thursday, January 11, 2024 8:00am to 9:00am (UTC-08:00) America/Los Angeles *Where:* Microsoft Teams meeting Join on your computer or mobile app Click here to join the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams |

Re: [edk2-devel] Memory Attribute for depex section

(+ Andrew) On 1/10/24 14:09, Laszlo Ersek wrote: > I think that keeping the depex section read-only is valuable, so I'd > rule out #2. I'd also not start with option #1 -- copying the depex to > heap memory, just so this optimization can succeed. I'd simply start by > removing the optimization,

Re: [edk2-devel] Memory Attribute for depex section

Hi, On 1/8/24 11:11, Nhi Pham via groups.io wrote: > Hi Ard, all, > > Could you please help explain how the depex section in an image is > mapped in terms of memory attribute? > > As my observation, dispatcher locates[1] the depex section inside the > module image and write[2] an evaluated data

Re: [edk2-devel] [PATCH v2] CryptoPkg: Fix redefinition error of int defines

Looks good to me. Reviewed-by: Yi Li -Original Message- From: Hou, Wenxing Sent: Wednesday, January 10, 2024 7:36 PM To: devel@edk2.groups.io Cc: Yao, Jiewen ; Li, Yi1 ; Jiang, Guomin Subject: [PATCH v2] CryptoPkg: Fix redefinition error of int defines

Re: [edk2-devel] [PATCH] UefiCpuPkg:Limit PhysicalAddressBits in speicial case

On 1/10/24 11:54, Gerd Hoffmann wrote: > On Wed, Jan 10, 2024 at 04:05:44PM +0800, Dun Tan wrote: >> When creating smm page table, limit maximum >> supported physical address bits returned by >> CalculateMaximumSupportAddress() to 48 if >> 5-Level Paging is disabled. >> When 5-Level Paging is

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix issue that IsModified is wrongly set in PageTableMap

On 1/10/24 06:38, Zhiguang Liu wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4614 > > Fix issue that IsModified is wrongly set in PageTableMap. > > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Cc: Crystal Lee > Signed-off-by: Zhiguang Liu > --- >

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuMpPei: Don't write CR3 in ConvertMemoryPageToNotPresent

On 1/10/24 06:43, Zhiguang Liu wrote: > After ConvertMemoryPageToNotPresent, there is always a flush TLB > function. So, to improve performance, there is no need to write CR3 > inside ConvertMemoryPageToNotPresent > > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Cc: Gerd Hoffmann >

[edk2-devel] [PATCH v2] CryptoPkg: Fix redefinition error of int defines

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4632 Move the define to stdint and add MACRO to prevent duplicate inclusion. Cc: Jiewen Yao Cc: Yi Li Cc: Guomin Jiang Signed-off-by: Wenxing Hou --- CryptoPkg/Library/Include/CrtLibSupport.h | 15 ---

Re: [edk2-devel] [PATCH] CryptoPkg: change the define

Hi, this title is too simple. Please change it to CryptoPkg: Fix redefinition error of int defines -Original Message- From: Hou, Wenxing Sent: Wednesday, January 10, 2024 7:16 PM To: devel@edk2.groups.io Cc: Yao, Jiewen ; Li, Yi1 ; Jiang, Guomin Subject: [PATCH] CryptoPkg: change the

[edk2-devel] [PATCH] CryptoPkg: change the define

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4632 Move the define to stdint and add MACRO to prevent duplicate inclusion. Cc: Jiewen Yao Cc: Yi Li Cc: Guomin Jiang Signed-off-by: Wenxing Hou --- CryptoPkg/Library/Include/CrtLibSupport.h | 15 ---

Re: [edk2-devel] [PATCH] UefiCpuPkg:Limit PhysicalAddressBits in speicial case

On Wed, Jan 10, 2024 at 04:05:44PM +0800, Dun Tan wrote: > When creating smm page table, limit maximum > supported physical address bits returned by > CalculateMaximumSupportAddress() to 48 if > 5-Level Paging is disabled. > When 5-Level Paging is disabled and the > PhysicalAddressBits retrived

Re: [edk2-devel] [PATCH v6 26/36] OvmfPkg/LoongArchVirt: Add a NULL library named CollectApResouceLibNull

On 2024/1/10 上午10:47, Chao Li wrote: Hi Bibo, Thanks, Chao On 2024/1/10 09:24, maobibo wrote: On 2024/1/5 下午5:45, Chao Li wrote: This Library is used to collect APs resources, but is currently NULL for OvmfPkg, because it is not used by the LoongArch virtual machine. BZ:

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix issue that IsModified is wrongly set in PageTableMap

Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Liu, Zhiguang > Sent: Wednesday, January 10, 2024 1:38 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Ni, Ray ; Laszlo > Ersek ; Kumar, Rahul R ; Gerd > Hoffmann ; Lee, Crystal > Subject: [PATCH] UefiCpuPkg: Fix issue

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuMpPei: Don't write CR3 in ConvertMemoryPageToNotPresent

Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Liu, Zhiguang > Sent: Wednesday, January 10, 2024 1:43 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Ni, Ray ; Laszlo > Ersek ; Kumar, Rahul R ; Gerd > Hoffmann > Subject: [PATCH] UefiCpuPkg/CpuMpPei: Don't write CR3 in

Re: [edk2-devel] [PATCH] UefiCpuPkg:Limit PhysicalAddressBits in speicial case

Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: Tan, Dun > Sent: Wednesday, January 10, 2024 4:06 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [PATCH] UefiCpuPkg:Limit PhysicalAddressBits in speicial case > >

[edk2-devel] [PATCH] UefiCpuPkg:Limit PhysicalAddressBits in speicial case

When creating smm page table, limit maximum supported physical address bits returned by CalculateMaximumSupportAddress() to 48 if 5-Level Paging is disabled. When 5-Level Paging is disabled and the PhysicalAddressBits retrived from CPU HOB or CpuId is bigger than 48, only [0, 2^48 -1] range in