Re: [edk2-devel] [PATCH 0/6] SECURITY PATCHES TCBZ4117 & TCBZ4118

2024-01-15 Thread Yao, Jiewen
Merged https://github.com/tianocore/edk2/pull/5264 > -Original Message- > From: Douglas Flick [MSFT] > Sent: Friday, January 12, 2024 2:16 AM > To: devel@edk2.groups.io > Cc: Douglas Flick [MSFT] ; Yao, Jiewen > > Subject: [PATCH 0/6] SECURITY PATCHES TCBZ4117 & TCBZ4118 > > This patch

[edk2-devel] [PATCH edk2-platforms v2 4/4] Platform/SbsaQemu: move FdtHandlerLib to SbsaQemuHardwareInfoLib

2024-01-15 Thread Marcin Juszkiewicz
There is no need for EDK2 to know that there is DeviceTree around. All hardware information is read using functions from SbsaQemuHardwareInfoLib library. Library fallbacks to parsing DT if needed (used with too old TF-A). Signed-off-by: Marcin Juszkiewicz ---

[edk2-devel] [PATCH edk2-platforms v2 3/4] Platform/SbsaQemu: use PcdCoreCount directly

2024-01-15 Thread Marcin Juszkiewicz
During platform initialization we read amount of cpu cores and set PcdCoreCount so there is no need to call FdtHandler. Signed-off-by: Marcin Juszkiewicz --- Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf | 6 ++ Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c |

[edk2-devel] [PATCH edk2-platforms v2 1/4] Platform/SbsaQemu: add SbsaQemuHardwareInfoLib

2024-01-15 Thread Marcin Juszkiewicz
This library provides functions to check for hardware information. For now it covers CPU ones: - amount of cpu cores - MPIDR value for cpu core - NUMA node id for cpu core Values are read from TF-A using platform specific SMC calls. Signed-off-by: Marcin Juszkiewicz ---

[edk2-devel] [PATCH edk2-platforms v2 0/4] get rid of DeviceTree from SbsaQemu

2024-01-15 Thread Marcin Juszkiewicz
| 9 +- .../SbsaQemu/Library/FdtHelperLib/FdtHelperLib.c| 98 -- .../SbsaQemuHardwareInfoLib.c | 204 14 files changed, 308 insertions(+), 197 deletions(-) --- base-commit: a1598bbcd167f4a5cf61229156426ef6f0784ab3 change-id: 20240115-no-dt

[edk2-devel] [PATCH edk2-platforms v2 2/4] Platform/SbsaQemu: read amount of cpus during init

2024-01-15 Thread Marcin Juszkiewicz
We read it once and store in Pcd for future use. Signed-off-by: Marcin Juszkiewicz --- .../SbsaQemu/Drivers/SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.inf | 4 +++- .../SbsaQemu/Drivers/SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c | 9 + 2 files changed, 8 insertions(+), 5 deletions(-)

Re: [edk2-devel] [PATCH v3 1/1] Sophgo/SG2042Pkg: Disable CMO and Sstc features

2024-01-15 Thread Sunil V L
On Mon, Jan 15, 2024 at 04:11:44PM +0800, caiyuqing...@163.com wrote: > From: caiyuqing379 > > Disable CMO and Sstc features because they are not supported by the > platform. And use SBI calls itself by default for Sophgo SG2042 platform. > Merged as #118. -=-=-=-=-=-=-=-=-=-=-=- Groups.io

[edk2-devel] [PATCH 2/2] ShellPkg: Update smbiosview for LoongArch

2024-01-15 Thread Dongyan Qian
According to SMBIOS spec3.6, LoongArch information support has been added, so this patch is submitted for display as information in smbiosview. Cc: Zhichao Gao Cc: Chao Li Signed-off-by: Dongyan Qian --- .../SmbiosView/PrintInfo.c| 68 +++

[edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo

2024-01-15 Thread Dongyan Qian
This fixes messages like: "Image type X64 can't be loaded on UEFI system" Cc: Liming Gao Cc: Chao Li Signed-off-by: Dongyan Qian --- MdeModulePkg/Core/Dxe/Image/Image.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c

[edk2-devel] [PATCH v1 2/2] UefiCpuPkg/BaseXApicX2ApicLib: Implements AMD extended cpu topology

2024-01-15 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar This patch adds support for AMD's new extended topology. If processor supports CPUID 8026 leaf then obtain the topology information using new method. Algorithm: if CPUID is AMD: then check for AMD's extended cpu tology leaf. if yes then

[edk2-devel] [PATCH v1 1/2] MdePkg: Adds AMD Extended CPU topology CPUID

2024-01-15 Thread Abdul Lateef Attar via groups.io
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113868): https://edk2.groups.io/g/devel/message/113868 Mute This Topic: https://groups.io/mt/103757656/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

[edk2-devel] [PATCH v1 0/2] AMD CPU extended topology

2024-01-15 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar PR: https://github.com/tianocore/edk2/pull/5263 Implements AMD extended toplogy. Adds CPUID macro update APIC library to use new exteded cpuid. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Abdul Lateef

Re: [edk2-devel] [PATCH v3 0/3] Support CloudHv guests with >1TB of RAM

2024-01-15 Thread Anatol Belski
Hi, i was late to the party as well. At least i went now for a manual build and some tests with Cloud Hypervisor and it looks good. On Mon, 2024-01-15 at 10:26 -0800, Thomas Barrett wrote: > Hey all, > > Yeah I don’t disagree Laszlo. While developing these patches, It was > pretty confusing to

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: Function to remove Redfish unchangeable properties

2024-01-15 Thread Nickle Wang via groups.io
> I didn't choose ReadOnly is because at BIOS perspective as a provider, we > still > update the read only property defined in schema such as BootOptions. Thus I > thought to use ReadOnly is not quite accurate. How do you think? I see. Thanks for your explanation. Please fix the typos and keep

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: Function to remove Redfish unchangeable properties

2024-01-15 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Nickle Wang > Sent: Tuesday, January 16, 2024 11:18 AM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: RE: [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: > Function to remove

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: Function to remove Redfish unchangeable properties

2024-01-15 Thread Nickle Wang via groups.io
I found typos. Please see below. Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, January 12, 2024 11:26 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: >

Re: [edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg/RedfishFeatureUtilityLib: Add two helper functions

2024-01-15 Thread Nickle Wang via groups.io
Please see my comments below. Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, January 12, 2024 11:26 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH 2/3] >

Re: [edk2-devel] [edk2-redfish-client][PATCH 1/3] RedfishClientPkg/jansson: Define json_object_del

2024-01-15 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, January 12, 2024 11:26 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH 1/3] RedfishClientPkg/jansson: Define >

Re: [edk2-devel] [RESEND PATCH] RedfishPkg/JsonLib: Add JSON delete object function

2024-01-15 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, January 12, 2024 11:24 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [RESEND PATCH] RedfishPkg/JsonLib: Add JSON delete object function > >

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, January 16, 2024 #cal-reminder

2024-01-15 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, January 16, 2024 6:30pm to 7:30pm (UTC-08:00) America/Los Angeles *Where:*

Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg

2024-01-15 Thread Chao Li
OK, let me finish this work tomorrow, I'm a little busy today. Thanks, Chao On 2024/1/15 16:11, Ni, Ray wrote: Yes. Fine to me. Thanks! Thanks, Ray -Original Message- From: Sunil V L Sent: Monday, January 15, 2024 2:46 PM To: Chao Li Cc:devel@edk2.groups.io; Ni, Ray; Kinney, Michael

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of the EFI_NVDIMM_LABEL

2024-01-15 Thread Junfeng Guan
Hi Liming, Would you like help to push this PR: https://github.com/tianocore/edk2/pull/5191 Thanks. B.R. Junfeng -Original Message- From: Guan, JunfengX Sent: Thursday, January 11, 2024 3:55 PM To: gaoliming ; devel@edk2.groups.io Cc: Kinney, Michael D ; Liu, Zhiguang ; Li, Yi1

回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig

2024-01-15 Thread gaoliming via groups.io
Suqiang: All three PRs have been merged. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Ren, Suqiang > 发送时间: 2024年1月15日 10:09 > 收件人: gaoliming ; devel@edk2.groups.io > 抄送: Kinney, Michael D ; Liu, Zhiguang > ; Li, Yi1 > 主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, January 15, 2024 #cal-notice

2024-01-15 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, January 15, 2024 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:*

[edk2-devel] [PATCH v3 1/1] Sophgo/SG2042Pkg: Disable CMO and Sstc features

2024-01-15 Thread caiyuqing_hz
From: caiyuqing379 Disable CMO and Sstc features because they are not supported by the platform. And use SBI calls itself by default for Sophgo SG2042 platform. Cc: dahogn Cc: meng-cz Cc: USER0FISH Signed-off-by: caiyuqing379 Reviewed-by: Sunil V L ---

Re: [edk2-devel] [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension

2024-01-15 Thread caiyuqing379
Hi, Sunil Thanks for the suggestion, I'll keep the commit message up to date. Thanks again! Yuqing Cai Replied Message | From | Sunil V L | | Date | 1/15/2024 12:41 | | To | | | Cc | , USER0FISH | | Subject | Re: [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension | On Sat, Jan

[edk2-devel] [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension

2024-01-15 Thread caiyuqing_hz
From: caiyuqing379 Override Sstc extension and use SBI calls itself by default for RISC-V Sophgo SG2042 platform. Cc: dahogn Cc: meng-cz Cc: USER0FISH Cc: Sunil V L Signed-off-by: caiyuqing379 --- Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1 + 1 file changed, 1 insertion(+) diff

[edk2-devel] [PATCH v2 0/1] Sophgo/SG2042Pkg: Disable Sstc feature

2024-01-15 Thread caiyuqing_hz
From: caiyuqing379 By default the Sstc feature is enabled and Sophgo SG2042 platform need to set the PCD to disable the feature because Sstc is not supported. Changes since v1: 1) Format error resolved. Cc: dahogn Cc: meng-cz Cc: USER0FISH Cc: Sunil V L Signed-off-by: caiyuqing379

Re: [edk2-devel] [PATCH v3 0/3] Support CloudHv guests with >1TB of RAM

2024-01-15 Thread Anatol Belski
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113850): https://edk2.groups.io/g/devel/message/113850 Mute This Topic: https://groups.io/mt/103689730/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, January 15, 2024 #cal-reminder

2024-01-15 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, January 15, 2024 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:*

Re: [edk2-devel] [edk2-platforms PATCH v2 4/8] Silicon/Marvell: Odyssey watchdog driver

2024-01-15 Thread Narinder Dhillon
Hi Marcin, This watchdog is not compatible with ARM generic. Thanks, Narinder > -Original Message- > From: Marcin Wojtas > Sent: Friday, January 12, 2024 3:35 AM > To: devel@edk2.groups.io; Narinder Dhillon > Cc: Leif Lindholm ; marcin.s.woj...@gmail.com; > Szymon Balcerak > Subject:

Re: [edk2-devel] [PATCH 1/6] UefiCpuPkg/LocalApicTimerDxe: Duplicate OvmfPkg/LocalApicTimerDxe driver

2024-01-15 Thread Laszlo Ersek
On 1/15/24 09:59, Pedro Falcato wrote: > On Mon, Jan 15, 2024 at 8:04 AM Ni, Ray wrote: >> >> This commit only duplicates the OvmfPkg/LocalApicTimerDxe. >> Following commits will enhance the driver. > > Hi, > > Please describe why you're doing this change. i.e what's your use case > for

Re: [edk2-devel] [PATCH v2 1/6] OvmfPkg/VirtNorFlashDxe: add casts to UINTN and UINT32

2024-01-15 Thread Laszlo Ersek
On 1/15/24 16:59, Gerd Hoffmann wrote: > This is needed to avoid bit operations being applied to signed integers. > > Suggested-by: László Érsek > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/VirtNorFlashDxe/VirtNorFlash.h | 2 +- > OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c | 2 +- > 2 files

Re: [edk2-devel] [PATCH v3 0/3] Support CloudHv guests with >1TB of RAM

2024-01-15 Thread Laszlo Ersek
On 1/15/24 17:13, Ard Biesheuvel wrote: > On Mon, 15 Jan 2024 at 16:32, Ard Biesheuvel wrote: >> >> On Mon, 15 Jan 2024 at 16:27, Gerd Hoffmann wrote: >>> >>> On Fri, Jan 12, 2024 at 06:31:41PM +, Thomas Barrett wrote: This series adds support for cloud-hypervisor guests with >1TiB

Re: [edk2-devel] Memory Attribute for depex section

2024-01-15 Thread Laszlo Ersek
On 1/15/24 15:04, Ard Biesheuvel wrote: > On Mon, 15 Jan 2024 at 14:07, Nhi Pham wrote: >> >> On 1/12/2024 4:45 PM, Laszlo Ersek wrote: >>> (Independently: I think that's a valid thing to do for *SMM* drivers, >>> because the entry point functions of those drivers are permitted to use >>> both

Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: get cpu information from TF-A

2024-01-15 Thread Marcin Juszkiewicz
W dniu 15.01.2024 o 19:02, Leif Lindholm pisze: As part of removing DeviceTree use we moved cpu related parts to TF-A. On EDK2 side we get values via SMC calls during platform initialization. Could you split this into three patches?: - Adding new Library (Library name should have a Lib

Re: [edk2-devel] [PATCH v3 0/3] Support CloudHv guests with >1TB of RAM

2024-01-15 Thread Thomas Barrett
Hey all, Yeah I don’t disagree Laszlo. While developing these patches, It was pretty confusing to determine which parts of PlatformLibInit were compatible with CloudHv and which parts weren’t. I have no idea how much work would be involved in splitting out cloud-hypervisor code. It would be good

Re: [edk2-devel] [PATCH 1/6] UefiCpuPkg/LocalApicTimerDxe: Duplicate OvmfPkg/LocalApicTimerDxe driver

2024-01-15 Thread Michael D Kinney
Hi Ray, I think nesting may be possible in physical platforms, but very hard to induce. One option is to consolidate to a single LocalApicTimerDxe implementation in the UefiCpuPkg, but allow the platform DSC to either specify a Null NestedInterruptTplLib for physical platforms or the full one

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix issue that IsModified is wrongly set in PageTableMap

2024-01-15 Thread Laszlo Ersek
On 1/15/24 10:43, Pedro Falcato wrote: > On Thu, Jan 11, 2024 at 8:56 AM Laszlo Ersek wrote: >> >> On 1/11/24 03:03, Ni, Ray wrote: This function is incredibly complicated, so reviewing this patch is hard, even after reading the bugzilla ticket. The commit message is useless.

Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: get cpu information from TF-A

2024-01-15 Thread Leif Lindholm
On 2024-01-15 15:11, Marcin Juszkiewicz wrote: As part of removing DeviceTree use we moved cpu related parts to TF-A. On EDK2 side we get values via SMC calls during platform initialization. Could you split this into three patches?: - Adding new Library (Library name should have a Lib suffix.)

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix issue that IsModified is wrongly set in PageTableMap

2024-01-15 Thread Laszlo Ersek
On 1/15/24 03:59, Liu, Zhiguang wrote: > Hi Laszlo, > > I don't think it is a good idea to explicitly mask out the Accessed/Dirty > bit. We can't assume Accessed/Dirty bit are only changed by hardware, because > the caller also can change the Accessed/Dirty bit. > > For API PageTableMap, the

Re: [edk2-devel] [PATCH 0/4] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

2024-01-15 Thread Ard Biesheuvel
On Mon, 15 Jan 2024 at 11:21, Laszlo Ersek wrote: > > On 1/12/24 12:37, Gerd Hoffmann wrote: > > This is a little series containing the flash corruption fix sent > > yesterday with an slightly improved commit message and some small > > improvements on top of this. > > > > Gerd Hoffmann (4): > >

Re: [edk2-devel] [PATCH v3 0/3] Support CloudHv guests with >1TB of RAM

2024-01-15 Thread Ard Biesheuvel
On Mon, 15 Jan 2024 at 18:40, Laszlo Ersek wrote: > > On 1/12/24 19:31, Thomas Barrett wrote: > > This series adds support for cloud-hypervisor guests with >1TiB > > of RAM to Ovmf. This bug was solved for Qemu back in 2017 > > https://bugzilla.redhat.com/show_bug.cgi?id=1468526. The bug is > >

Re: [edk2-devel] [PATCH v3 0/3] Support CloudHv guests with >1TB of RAM

2024-01-15 Thread Laszlo Ersek
On 1/12/24 19:31, Thomas Barrett wrote: > This series adds support for cloud-hypervisor guests with >1TiB > of RAM to Ovmf. This bug was solved for Qemu back in 2017 > https://bugzilla.redhat.com/show_bug.cgi?id=1468526. The bug is > still occuring for CloudHv guests because the PlatformScanE820 >

Re: [edk2-devel] [PATCH v3 0/3] Support CloudHv guests with >1TB of RAM

2024-01-15 Thread Ard Biesheuvel
On Mon, 15 Jan 2024 at 16:32, Ard Biesheuvel wrote: > > On Mon, 15 Jan 2024 at 16:27, Gerd Hoffmann wrote: > > > > On Fri, Jan 12, 2024 at 06:31:41PM +, Thomas Barrett wrote: > > > This series adds support for cloud-hypervisor guests with >1TiB > > > of RAM to Ovmf. This bug was solved for

[edk2-devel] [PATCH v2 2/6] OvmfPkg/VirtNorFlashDxe: clarify block write logic & fix shadowbuffer reads

2024-01-15 Thread Gerd Hoffmann
Introduce 'Start' and 'End' variables to make it easier to follow the logic and code flow. Also add a ascii art diagram (based on a suggestion by Laszlo). This also fixes the 'Size' calculation for the NorFlashRead() call. Without this patch the code will read only one instead of two

[edk2-devel] [PATCH v2 6/6] OvmfPkg/VirtNorFlashDxe: move DoErase code block into new function

2024-01-15 Thread Gerd Hoffmann
Move the DoErase code block into a separate function, call the function instead of jumping around with goto. Signed-off-by: Gerd Hoffmann --- OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c | 76 +- 1 file changed, 51 insertions(+), 25 deletions(-) diff --git

[edk2-devel] [PATCH v2 5/6] OvmfPkg/VirtNorFlashDxe: ValidateFvHeader: unwritten state is EOL too

2024-01-15 Thread Gerd Hoffmann
It is possible to find variable entries with State being 0xff, i.e. not updated since flash block erase. This indicates the variable driver could not complete the header write while appending a new entry, and therefore State was not set to VAR_HEADER_VALID_ONLY. This can only happen at the end

[edk2-devel] [PATCH v2 3/6] OvmfPkg/VirtNorFlashDxe: add a loop for NorFlashWriteBuffer calls.

2024-01-15 Thread Gerd Hoffmann
Replace the two NorFlashWriteBuffer() calls with a loop containing a single NorFlashWriteBuffer() call. With the changes in place the code is able to handle updates larger than two P30_MAX_BUFFER_SIZE_IN_BYTES blocks, even though the patch does not actually change the size limit. Signed-off-by:

[edk2-devel] [PATCH v2 4/6] OvmfPkg/VirtNorFlashDxe: allow larger writes without block erase

2024-01-15 Thread Gerd Hoffmann
Raise the limit for writes without block erase from two to four P30_MAX_BUFFER_SIZE_IN_BYTES blocks. With this in place almost all efi variable updates are handled without block erase. With the old limit some variable updates (with device paths) took the block erase code path. Signed-off-by:

[edk2-devel] [PATCH v2 1/6] OvmfPkg/VirtNorFlashDxe: add casts to UINTN and UINT32

2024-01-15 Thread Gerd Hoffmann
This is needed to avoid bit operations being applied to signed integers. Suggested-by: László Érsek Signed-off-by: Gerd Hoffmann --- OvmfPkg/VirtNorFlashDxe/VirtNorFlash.h | 2 +- OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [PATCH v2 0/6] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

2024-01-15 Thread Gerd Hoffmann
This is a little series containing the flash corruption fix sent yesterday with an slightly improved commit message and some small improvements on top of this. v2: - drop broken bugfix, fix the bug when introducing Start+End variables instead. - add patch with UINTN and UINT32 casts. - add

Re: [edk2-devel] [PATCH v3 0/3] Support CloudHv guests with >1TB of RAM

2024-01-15 Thread Ard Biesheuvel
On Mon, 15 Jan 2024 at 16:27, Gerd Hoffmann wrote: > > On Fri, Jan 12, 2024 at 06:31:41PM +, Thomas Barrett wrote: > > This series adds support for cloud-hypervisor guests with >1TiB > > of RAM to Ovmf. This bug was solved for Qemu back in 2017 > >

Re: [edk2-devel] [PATCH v3 0/3] Support CloudHv guests with >1TB of RAM

2024-01-15 Thread Gerd Hoffmann
On Fri, Jan 12, 2024 at 06:31:41PM +, Thomas Barrett wrote: > This series adds support for cloud-hypervisor guests with >1TiB > of RAM to Ovmf. This bug was solved for Qemu back in 2017 > https://bugzilla.redhat.com/show_bug.cgi?id=1468526. The bug is > still occuring for CloudHv guests

[edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: get cpu information from TF-A

2024-01-15 Thread Marcin Juszkiewicz
As part of removing DeviceTree use we moved cpu related parts to TF-A. On EDK2 side we get values via SMC calls during platform initialization. Handled are: - get cpu cores count - get MPIDR - get NUMA node id If too old TF-A is used then cpu count and MPIDR are read directly from DeviceTree.

[edk2-devel] [PATCH edk2-platforms 0/1] get rid of DeviceTree from SbsaQemu

2024-01-15 Thread Marcin Juszkiewicz
We want to stop parsing DeviceTree to gather hardware information. Instead we ask TF-A for those details using SMC calls. On real hardware platform it could be asking on-board Embedded Controller. If TF-A answer to SMC call would be not success then we assume that it is old version and go back to

Re: [edk2-devel] Memory Attribute for depex section

2024-01-15 Thread Ard Biesheuvel
On Mon, 15 Jan 2024 at 14:07, Nhi Pham wrote: > > On 1/12/2024 4:45 PM, Laszlo Ersek wrote: > > (Independently: I think that's a valid thing to do for *SMM* drivers, > > because the entry point functions of those drivers are permitted to use > > both SMM and DXE/UEFI protocols. But whether the

Re: [edk2-devel] Memory Attribute for depex section

2024-01-15 Thread Nhi Pham via groups.io
On 1/12/2024 4:45 PM, Laszlo Ersek wrote: > (Independently: I think that's a valid thing to do for *SMM* drivers, > because the entry point functions of those drivers are permitted to use > both SMM and DXE/UEFI protocols. But whether the same is valid for the > *standalone* MM drivers -- that

Re: [edk2-devel] [PATCH 0/4] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

2024-01-15 Thread Laszlo Ersek
On 1/15/24 11:21, Laszlo Ersek wrote: > - please only ever apply the bit-neg operator on values that are UINT32, > UINTN, or UINT64. Otherwise we get sign bit flipping, and that's > terrible. (Most people are not even aware of it happening.) Doing this is BTW not as obvious as it might seem,

Re: [edk2-devel] When TPM is enabled, Ubuntu doesn't boot

2024-01-15 Thread Hamit Can Karaca
Hi Yao, Jiewen, I actually tried to get help from the ubuntu people but they really don't understand what is going in the UEFI side. I am trying to fix this problem for 3 weeks now and I am about the give up. I hope somebody can help me :( Thanks, Hamit Can -=-=-=-=-=-=-=-=-=-=-=- Groups.io

Re: [edk2-devel] [PATCH] DynamicTablesPkg/SSDT: Remove incorrect root node check

2024-01-15 Thread PierreGondois
Hello Jeshua, On 1/9/24 17:55, Jeshua Smith wrote: Two physical packages are on a multi-chip module and share resources on the module. The module then plugs into the baseboard/motherboard. Is it possible to elaborate on the resource being shared ? In our specific case the problem is related

Re: [edk2-devel] [edk2-platforms][PATCH V2 0/8] Platform/Sgi: Add support for RD-Fremont platform

2024-01-15 Thread PierreGondois
Hello Prabin, Except for patches 1,3,4 where I had a remark/question, for all other patches: Reviewed-by: Pierre Gondois Also, I could not directly apply the patches you sent on the latest master branch. Indeed, the serie is on top of other patches on the branch you shared:

Re: [edk2-devel] [edk2-platforms][PATCH V2 3/8] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms

2024-01-15 Thread PierreGondois
Hello Prabin, On 1/12/24 16:47, Prabin CA via groups.io wrote: Introducing a flag called PCIE_ENABLE, which can be set to TRUE or FALSE from the respective .dsc files to enable or disable the PCIe support. As not all reference design platforms have PCIe support enabled, this flag is introduced.

Re: [edk2-devel] [edk2-platforms][PATCH V2 4/8] Platform/Sgi: Add ACPI tables for RD-Fremont platform

2024-01-15 Thread PierreGondois
On 1/12/24 16:47, Prabin CA via groups.io wrote: From: Shriram K RD-Fremont is the next platform in the Arm's reference design platform series. This platform includes 32 CPUs but the fixed virtual platform (FVP) simulates 16 CPUs of the platform. There is one CPU per cluster in the system

Re: [edk2-devel] [PATCH 0/4] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

2024-01-15 Thread Laszlo Ersek
On 1/12/24 12:37, Gerd Hoffmann wrote: > This is a little series containing the flash corruption fix sent > yesterday with an slightly improved commit message and some small > improvements on top of this. > > Gerd Hoffmann (4): > OvmfPkg/VirtNorFlashDxe: fix shadowbuffer reads >

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix issue that IsModified is wrongly set in PageTableMap

2024-01-15 Thread Pedro Falcato
On Thu, Jan 11, 2024 at 8:56 AM Laszlo Ersek wrote: > > On 1/11/24 03:03, Ni, Ray wrote: > >> This function is incredibly complicated, so reviewing this patch is > >> hard, even after reading the bugzilla ticket. > >> > >> The commit message is useless. It should contain a brief description of >

Re: [edk2-devel] [PATCH] UefiPayloadPkg: CbParseLib: Fix integer overflow

2024-01-15 Thread Sean Rhodes
Reviewed-by: Sean Rhodes On Fri, 12 Jan 2024 at 11:43, Guo, Gua wrote: > Reviewed-by: Gua Guo > -- > *From:* Lean Sheng Tan > *Sent:* Friday, January 12, 2024 7:33:00 PM > *To:* Rudolph, Patrick > *Cc:* devel@edk2.groups.io ; Rhodes, Sean > ; Guo, Gua ; Lu, James

Re: [edk2-devel] [PATCH 1/6] UefiCpuPkg/LocalApicTimerDxe: Duplicate OvmfPkg/LocalApicTimerDxe driver

2024-01-15 Thread Pedro Falcato
On Mon, Jan 15, 2024 at 8:04 AM Ni, Ray wrote: > > This commit only duplicates the OvmfPkg/LocalApicTimerDxe. > Following commits will enhance the driver. Hi, Please describe why you're doing this change. i.e what's your use case for LocalApicTimerDxe, and why are you duplicating this instead

Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg

2024-01-15 Thread Laszlo Ersek
On 1/12/24 11:19, Sunil V L wrote: > Hi Ray, > > On Fri, Jan 12, 2024 at 09:12:34AM +, Ni, Ray wrote: >> Sunil, >> I would like to hear your feedback regarding locations of following RiscV64 >> components in UefiCpuPkg: >> * UefiCpuPkg/Library/BaseRiscV64CpuExceptionHandlerLib/ >> *

Re: [edk2-devel] [PATCH v7 25/37] ArmVirtPkg: Move PlatformBootManagerLib to OvmfPkg

2024-01-15 Thread Laszlo Ersek
On 1/12/24 09:25, Chao Li wrote: > Moved the PlatformBootManagerLib to OvmfPkg and renamed to > PlatformBootManagerLibLight for easy use by other ARCH. > > Build-tested only (with "ArmVirtQemu.dsc"). > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 > > Cc: Ard Biesheuvel > Cc: Leif

Re: [edk2-devel] [PATCH v7 00/37] Enable LoongArch virtual machine in edk2

2024-01-15 Thread Laszlo Ersek
On 1/12/24 09:21, Chao Li wrote: > **Changes from V6 to V7:** > [...] > For the review opinions: > 1. Moved the changes to OvmfPkg.dec from old patch 24 to new patch 23. > Questioner: Laszlo. IIUC, you may have inteded to do this, but didn't actually do it. Laszlo -=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v7 23/37] ArmVirtPkg: Move the FdtSerialPortAddressLib to OvmfPkg

2024-01-15 Thread Laszlo Ersek
On 1/12/24 09:25, Chao Li wrote: > Move the FdtSerialPortAddressLib to Ovmfpkg so that other ARCH can > easily use it. > > Build-tested only (with "ArmVirtQemu.dsc"). > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar >

Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg

2024-01-15 Thread Ni, Ray
Yes. Fine to me. Thanks! Thanks, Ray > -Original Message- > From: Sunil V L > Sent: Monday, January 15, 2024 2:46 PM > To: Chao Li > Cc: devel@edk2.groups.io; Ni, Ray ; Kinney, Michael D > ; Laszlo Ersek ; Gerd > Hoffmann > Subject: Re: [edk2-devel] RFC: Folder layout change in

[edk2-devel] [PATCH 6/6] UefiCpuPkg/LocalApicTimerDxe: Passing fixed timer period is not a bug.

2024-01-15 Thread Ni, Ray
The patch adds detailed comments to explain that passing fixed timer period to mTimerNotifyFunction() is not a bug. Signed-off-by: Ray Ni Cc: Michael D Kinney Cc: Nate DeSimone Cc: Laszlo Ersek Cc: Rahul Kumar --- UefiCpuPkg/LocalApicTimerDxe/LocalApicTimerDxe.c | 15 +++ 1 file

[edk2-devel] [PATCH 5/6] UefiCpuPkg/LocalApicTimerDxe: warn if APIC Timer is used by other code

2024-01-15 Thread Ni, Ray
LocalApicTimerDxe uses APIC Timer as the timer interrupt source. Other code should not program the APIC Timer as it may cause the timer interrupt be signaled at the incorrect timer period or the timer interrupt might be disabled. The patch prints warning debug messages in driver entrypoint when

[edk2-devel] [PATCH 4/6] UefiCpuPkg/LocalApicTimerDxe: Enhance Timer Frequency calculation logic

2024-01-15 Thread Ni, Ray
Old logic is simply to get the APIC Timer Frequency from PcdFSBClock. New logic follows the SDM to firstly get the crystal clock frequency from CPUID.0x15 leaf. If CPUID.0x15 is not supported, the crystal clock frequency is retrieved from PcdCpuCoreCrystalClockFrequency. Then the new logic finds

[edk2-devel] [PATCH 3/6] UefiCpuPkg: Add LocalApicTimerDxe driver in DSC file

2024-01-15 Thread Ni, Ray
Signed-off-by: Ray Ni Cc: Michael D Kinney Cc: Nate DeSimone Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/UefiCpuPkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc index

[edk2-devel] [PATCH 2/6] UefiCpuPkg/LocalApicTimerDxe: Remove NestedInterruptTplLib call

2024-01-15 Thread Ni, Ray
a086f4a adds NestedInterruptTplLib call in OvmfPkg/LocalApicTimerDxe to avoid stack overflow due to interrupt storm in VM guest. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2815 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4162 The interrupt storm only happens in VM guest

[edk2-devel] [PATCH 1/6] UefiCpuPkg/LocalApicTimerDxe: Duplicate OvmfPkg/LocalApicTimerDxe driver

2024-01-15 Thread Ni, Ray
This commit only duplicates the OvmfPkg/LocalApicTimerDxe. Following commits will enhance the driver. FILE_GUID in INF file is updated with a new GUID. Signed-off-by: Ray Ni Cc: Michael D Kinney Cc: Nate DeSimone Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann ---

[edk2-devel] Add LocalApicTimerDxe driver in UefiCpuPkg

2024-01-15 Thread Ni, Ray
Ray Ni (6): UefiCpuPkg/LocalApicTimerDxe: Duplicate OvmfPkg/LocalApicTimerDxe driver UefiCpuPkg/LocalApicTimerDxe: Remove NestedInterruptTplLib call UefiCpuPkg: Add LocalApicTimerDxe driver in DSC file UefiCpuPkg/LocalApicTimerDxe: Enhance Timer Frequency calculation logic