Hi Laszlo,
On 1/16/2024 2:00 AM, Laszlo Ersek wrote:
On 1/15/24 15:04, Ard Biesheuvel wrote:
On Mon, 15 Jan 2024 at 14:07, Nhi Pham wrote:
On 1/12/2024 4:45 PM, Laszlo Ersek wrote:
(Independently: I think that's a valid thing to do for *SMM* drivers,
because the entry point functions of
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Laszlo Ersek
> Sent: Wednesday, January 17, 2024 6:24 PM
> To: devel@edk2.groups.io; Liu, Zhiguang
> Cc: Ni, Ray ; Kumar, Rahul R ;
> Gerd Hoffmann
> Subject: Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg/CpuMpPei: Don't write
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Laszlo Ersek
> Sent: Wednesday, January 17, 2024 6:23 PM
> To: devel@edk2.groups.io; Liu, Zhiguang
> Cc: Ni, Ray ; Kumar, Rahul R ;
> Gerd Hoffmann
> Subject: Re: [edk2-devel] [PATCH v2 1/2] UefiCpuPkg/CpuPageTableLib:
>
From: Abdul Lateef Attar
This patch adds support for AMD's new extended topology.
If processor supports CPUID 8026 leaf then obtain
the topology information using new method.
Algorithm:
if CPUID is AMD:
then
check for AMD's extended cpu tology leaf.
if yes
then
From: Abdul Lateef Attar
Resending the patch with updated Cc list.
PR: https://github.com/tianocore/edk2/pull/5269
V2: delta changes
- Added additional check apart from supported CPUID extneded number.
- removed EFIAPI
Implements AMD extended toplogy.
Adds CPUID macro
update APIC library to
From: Abdul Lateef Attar
Adds cpuid macro for AMD extended CPU topology.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Abdul Lateef Attar
---
MdePkg/Include/Register/Amd/Cpuid.h | 23 ++-
1 file
Thank you Doug for the prompt response.
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Douglas Flick [MSFT]
> Sent: Thursday, January 18, 2024 6:47 AM
> To: devel@edk2.groups.io
> Cc: Douglas Flick [MSFT] ; Yao, Jiewen
> ; Kumar, Rahul R
> Subject: [PATCH 0/3] DxeTpm and
Thanks Laszlo for the comment, I will send a new version of patch to fix this.
Also include Pedro to see if Pedro have more comments.
Thanks
Zhiguang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, January 17, 2024 6:51 PM
> To:
From: Narinder Dhillon
This patch adds driver that can provide device tree to OS if user so
wishes. PCD's are used to enable this, default is not to take this
action.
Signed-off-by: Narinder Dhillon
---
.../Drivers/Fdt/FdtPlatformDxe/FdtPlatform.c | 259 ++
From: Narinder Dhillon
This patch adds Odyssey SoC project description and flash description
files.
Signed-off-by: Narinder Dhillon
---
Platform/Marvell/OdysseyPkg/OdysseyPkg.dsc| 219 ++
Platform/Marvell/OdysseyPkg/OdysseyPkg.fdf| 304 +
From: Narinder Dhillon
This patch adds an EDK2 shell command to dump configuration device tree.
Signed-off-by: Narinder Dhillon
---
.../Marvell/Applications/DumpFdt/DumpFdt.c| 344 ++
.../Marvell/Applications/DumpFdt/DumpFdt.inf | 52 +++
From: Narinder Dhillon
This patch adds a device tree driver that is used to read board
configuration information from a device tree.
Signed-off-by: Narinder Dhillon
---
.../Drivers/Fdt/FdtClientDxe/FdtClientDxe.c | 382 ++
.../Drivers/Fdt/FdtClientDxe/FdtClientDxe.inf | 43
From: Narinder Dhillon
This patch adds watchdog driver for Odyssey SoC.
Signed-off-by: Narinder Dhillon
---
.../Drivers/Wdt/GtiWatchdogDxe/GtiWatchdog.c | 408 ++
.../Wdt/GtiWatchdogDxe/GtiWatchdogDxe.inf | 45 ++
2 files changed, 453 insertions(+)
create mode 100644
From: Narinder Dhillon
New Marvell Odyssey SoC
This patchset contains only the very basic elements needed to boot to
EDK2 UiApp on Marvell Odyssey SoC
- ARM BL31 firmware component copies EDK2 image into memory, so it is
always executing from memory
- There is a SMC library to get system
From: Narinder Dhillon
This patch adds helper library to initialize Odyssey SoC.
Signed-off-by: Narinder Dhillon
---
.../OdysseyLib/AArch64/ArmPlatformHelper.S| 97
.../Library/OdysseyLib/OdysseyLib.c | 79 ++
.../Library/OdysseyLib/OdysseyLib.inf
From: Narinder Dhillon
This patch provides SMC call needed by Odyssey to determine size
of available memory.
Signed-off-by: Narinder Dhillon
---
Silicon/Marvell/Library/SmcLib/SmcLib.c | 24 +++
Silicon/Marvell/Library/SmcLib/SmcLib.inf | 29 +++
Linking this here
https://edk2.groups.io/g/devel/message/113966
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113970): https://edk2.groups.io/g/devel/message/113970
Mute This Topic: https://groups.io/mt/103675434/21656
Group Owner:
Updates the sanitation function names to be lib unique names
Cc: Jiewen Yao
Cc: Rahul Kumar
Signed-off-by: Doug Flick [MSFT]
---
.../DxeTpm2MeasureBootLibSanitization.h | 8 +++---
.../DxeTpm2MeasureBootLib.c | 8 +++---
.../DxeTpm2MeasureBootLibSanitization.c
Adding the new commit titles for the symbol renames
Cc: Jiewen Yao
Cc: Rahul Kumar
Signed-off-by: Doug Flick [MSFT]
---
SecurityPkg/SecurityFixes.yaml | 28 +---
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/SecurityPkg/SecurityFixes.yaml
Updates the sanitation function names to be lib unique names
Cc: Jiewen Yao
Cc: Rahul Kumar
Signed-off-by: Doug Flick [MSFT]
---
.../DxeTpmMeasureBootLibSanitization.h| 8 +++---
.../DxeTpmMeasureBootLib.c| 8 +++---
.../DxeTpmMeasureBootLibSanitization.c
OVMF is failing because it includes both DxeTpm2MeasureBootLib and
DxeTpm2MeasureBootLib which makes the symbols collide. This patch
renames the function names to be unique to avoid symbol collision.
Cc: Jiewen Yao
Cc: Rahul Kumar
Signed-off-by: Doug Flick [MSFT]
Douglas Flick [MSFT] (3):
Its a complete tossup whether removing the mailbox call after we have
set up the XHCI works for a given kernel+distro in DT mode. So lets
give users which want to try DT the option of flipping this on/off.
Users that don't want to have to deal with DT, can use ACPI.
Signed-off-by: Jeremy Linton
Since we are updating the DT memory map and telling it how
we have configured the PCIe, there isn't a reason for moving the
MMIO window. In fact this appears to fix OpenBSD+DT as well as
it makes the linux XHCI reset sequence happier.
Signed-off-by: Jeremy Linton
---
Some recent GCC revisions will throw warnings about values being used
before being initialized. But in the case where the lack of initialization
is the result of the called function returning error status the EFI_ERROR()
macro/error seems to confuse the compiler about the fact that the value
is
The rpi's config.txt controls which uart (pl011, or miniuart) is
selected as the console. TFA and edk2 follow its lead, but if the
miniuart is selected as the primary and the machine is booted in ACPI
mode the baud/etc is never configured for the pl011. The linux kernel
won't reconfigure it either
Lets allow some of these options to change when the
system is in ACPI+DT mode. Plus the fan temp should
be disabled when ACPI isn't enabled.
Signed-off-by: Jeremy Linton
---
Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
This includes a change to always initialize the PL011 to the
configured baud (which should be 115200 for the SBSA UART), which
fixes linux's assumption that SBSA UARTs are pre-programmed for
115200. This in turn (re)enables the PL011 when the console is on the
miniuart per the config.txt file.
On 11/28/23 08:35, Lendacky, Thomas via groups.io wrote:
On 11/6/23 17:15, Tom Lendacky wrote:
On 11/6/23 16:45, Lendacky, Thomas via groups.io wrote:
The CPUID_EXTENDED_TOPOLOGY CPUID leaf takes a subleaf as input when
returning CPUID information. However, the AsmCpuid() function does not
I'll propose a patch to correct this. Building against Ovmf now to confirm it
corrects the issue.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113958): https://edk2.groups.io/g/devel/message/113958
Mute This Topic:
The source file definition in INF file is ServerManagementELog.c,
while the actual file name is ServerManagementElog.c. The case is
mismatched. Correct the definition in INF file to fix this issue.
Cc: Abner Chang
Cc: Nate DeSimone
Signed-off-by: Wei6 Xu
---
Liming, Mike,
Could you please help merge this PR?
Thanks,
Saloni
From: Ashish Singhal
Sent: Wednesday, January 17, 2024 6:08 AM
To: Kasbekar, Saloni ; devel@edk2.groups.io;
Clark-williams, Zachary ; Jeff Brasen
Subject: Re: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default
Hello,
Checking
On Wed, Jan 17, 2024 at 03:25:37PM +0530, Abdul Lateef Attar via groups.io
wrote:
Hmm? Empty patch. Forgot "git add $file"?
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113955):
> + /// Check if extended toplogy supported
> + AsmCpuid (CPUID_EXTENDED_FUNCTION, , NULL, NULL,
> NULL);
> + if (MaxExtendedCpuIdIndex >= AMD_CPUID_EXTENDED_TOPOLOGY) {
> +do {
> + AsmCpuidEx (
> +AMD_CPUID_EXTENDED_TOPOLOGY,
> +TopologyLevel,
> +,
> +
On Tue, Jan 16, 2024 at 11:38:12PM +, Yao, Jiewen wrote:
> Gerd
> I am OK with the patch.
>
> Quick question: Have you validated that the TPM2 is still working?
TPM1_ENABLE=FALSE is known to work and this series should give identical
results. See other replies for more details.
take care,
Hi Marc
I notice you are reviewer for TPM module in OvmfPkg.
Would you please help to test the TPM2.0 feature with patch from Gerd?
Thank you
Yao, Jiewen
> -Original Message-
> From: Gerd Hoffmann
> Sent: Wednesday, January 17, 2024 10:06 PM
> To: devel@edk2.groups.io; Yao, Jiewen
>
> This patch is good:
>
> Reviewed-by: Laszlo Ersek
>
> but the series shouldn't stop here. In "OvmfPkg/Tcg/Tcg2Config", we're
> left with an INF file (Tcg2ConfigPei.inf) that still references
> "Tpm12Support.h", and the common C source file "Tcg2ConfigPeim.c" still
> calls the one API --
Hello,
Checking back for an update on when this PR can be merged or if there are any
other changes you recommend.
Thanks
Ashish
From: Ashish Singhal
Sent: Saturday, January 6, 2024 5:53 AM
To: Kasbekar, Saloni ; devel@edk2.groups.io
; Clark-williams, Zachary
On Wed, Jan 17, 2024 at 08:23:19AM +, Yao, Jiewen wrote:
> That is weird.
> It seems we need to merge Gerd's patch soon -
> https://github.com/tianocore/edk2/pull/5265 to unblock CI.
>
> Hi Gerd
> Would you please confirm what test you have done for removing TPM1.2?
> Does TPM2.0 in OvmfPkg
On 1/17/24 09:09, Zhiguang Liu wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4614
>
> About the IsModified, current function doesn't consider that hardware
> also may change the pagetable. The issue is that in the first call of
> internal function PageTableLibMapInLevel, the
On 17/01/2024 07:11, Ni, Ray wrote:
The above flow shows endless re-entrance of timer interrupt handler.
But, my question is: above flow only can happen in real platform when the below
4 steps occupies more time than the timer period (usually 10ms).
[Timer Interrupt #2]1. RaiseTPL
On 1/17/24 07:22, Zhiguang Liu wrote:
> The purpose of writing CR3 in ConvertMemoryPageToNotPresent is just
> to flush TLB, because CR3 won't be changed in function
> ConvertMemoryPageToNotPresent.
> After ConvertMemoryPageToNotPresent, there is always a flush TLB
> function. Also, because
On 1/17/24 07:21, Zhiguang Liu wrote:
> PageTableMap() only modifies the PageTable root pointer when creating from
> zero.
> Explicitly explain it in function header.
>
> Cc: Ray Ni
> Cc: Laszlo Ersek
> Cc: Rahul Kumar
> Cc: Gerd Hoffmann
> Signed-off-by: Zhiguang Liu
> ---
>
On 1/16/24 18:11, Gerd Hoffmann wrote:
> Move the DoErase code block into a separate function, call the function
> instead of jumping around with goto.
>
> Signed-off-by: Gerd Hoffmann
> ---
> OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c | 76 ++
> 1 file changed, 52
From: Abdul Lateef Attar
This patch adds support for AMD's new extended topology.
If processor supports CPUID 8026 leaf then obtain
the topology information using new method.
Algorithm:
if CPUID is AMD:
then
check for AMD's extended cpu tology leaf.
if yes
then
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113942): https://edk2.groups.io/g/devel/message/113942
Mute This Topic: https://groups.io/mt/103782767/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
From: Abdul Lateef Attar
PR: https://github.com/tianocore/edk2/pull/5269
V2: delta changes
- Added additional check apart from supported CPUID extneded number.
- removed EFIAPI
Implements AMD extended toplogy.
Adds CPUID macro
update APIC library to use new exteded cpuid.
Cc: Michael D
On 1/16/24 16:42, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
> OvmfPkg/Tcg/Tcg2Config/Tcg12ConfigPei.inf | 56 ---
> OvmfPkg/Tcg/Tcg2Config/Tpm12Support.c | 83 ---
> 2 files changed, 139 deletions(-)
> delete mode 100644
On 1/16/24 16:42, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
> OvmfPkg/Include/Dsc/OvmfTpmComponentsDxe.dsc.inc | 6 --
> OvmfPkg/Include/Dsc/OvmfTpmComponentsPei.dsc.inc | 5 -
> OvmfPkg/Include/Dsc/OvmfTpmDefines.dsc.inc | 3 ---
>
That is weird.
It seems we need to merge Gerd's patch soon -
https://github.com/tianocore/edk2/pull/5265 to unblock CI.
Hi Gerd
Would you please confirm what test you have done for removing TPM1.2?
Does TPM2.0 in OvmfPkg still work?
Hi Doug
I cannot tell why CI passed before but failed now.
But
Hi Jiewen,
Sounds strange, but new PRs in today all broken due to this issue, e.g.:
https://github.com/tianocore/edk2/pull/5210
https://github.com/tianocore/edk2/pull/5268
I checked build log, it matched the description from Gerd:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4614
About the IsModified, current function doesn't consider that hardware
also may change the pagetable. The issue is that in the first call of
internal function PageTableLibMapInLevel, the function assume page
table is not changed, and add
Please check https://github.com/tianocore/edk2/pull/5264. It is merged after
pass CI.
May I know where you see PR CI builds are broken?
Thank you
Yao, Jiewen
> -Original Message-
> From: Li, Yi1
> Sent: Wednesday, January 17, 2024 3:21 PM
> To: devel@edk2.groups.io; Yao, Jiewen ; Gerd
52 matches
Mail list logo
