Re: [edk2-devel] [PATCH 1/1] OvmfPkg/ResetVector: send post codes to qemu debug console

On 1/25/24 08:50, Gerd Hoffmann wrote: > On Wed, Jan 24, 2024 at 05:43:29PM -0800, Erdem Aktas wrote: >> Same for TDX, I did not run it but it should cause failure >> as debugShowPostCode is called OvmfPkg/ResetVector/Ia32/IntelTdx.asm before >> actually the #VE handlers are installed. >> >>> Had

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/Sec: Setup MTRR early in the boot process.

On 1/25/24 07:52, Gerd Hoffmann wrote: > On Wed, Jan 24, 2024 at 05:14:10PM +0100, Laszlo Ersek wrote: >> On 1/24/24 16:15, Gerd Hoffmann wrote: >>> Specifically before running lzma uncompress of the main firmware volume. >>> This is needed to make sure caching is enabled, otherwise the uncompress

Re: [edk2-devel] [PATCH] MdeModulePkg/SMM: Support to unregister SMI handler inside SMI handler

On 1/25/24 13:05, Ni, Ray wrote: > Laszlo, > SMI handler is called from SmmCore. > So SmmCore knows which handle is passed to the SMI handler. > How about let Unregister() rejects the request coming from a SMI handler > which unregisters other handles? > > A "gCurrentSmiHandle" can be assigned

Re: [edk2-devel] [PATCH v2 3/4] UefiCpuPkg/MtrrLib.h: use cache type #defines from ArchitecturalMsr.h

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Thursday, January 25, 2024 12:23 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Laszlo Ersek > ; Aktas, Erdem ; Michael Roth > ; Xu, Min M ; Gerd Hoffmann > ; Yao, Jiewen ; Tom Lendacky > ;

Re: [edk2-devel] [edk2-platforms][PATCH V2 4/8] Platform/Sgi: Add ACPI tables for RD-Fremont platform

Thanks, resolved. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114456): https://edk2.groups.io/g/devel/message/114456 Mute This Topic: https://groups.io/mt/103685116/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [edk2-platforms][PATCH V2 3/8] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms

Hi Pierre, Since, Pcie is not enabled in the platform we have to suppress the Pcie related modules while in booting, other wise it cause the boot hazard to the platforms. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114455):

Re: [edk2-devel] [edk2-platforms][PATCH V2 0/8] Platform/Sgi: Add support for RD-Fremont platform

Hi Pierre, Thanks for reviewing it, I have followed the links you send to correct the signed-off. Please review the patches. This patch have dependencies with https://edk2.groups.io/g/devel/message/113732. I had already mentioned same in the cover letter of this Patches too.

[edk2-devel] [edk2-platforms][PATCH v3 8/8] Platform/Sgi: Add CPPC support for RD-Fremont platform

Enable ACPI CPPC mechanism for RD-Fremont as defined by the ACPI specification. The implementation uses AMU registers accessible as Fixed-feature Hardware (FFixedHW) for monitoring the performance. Non-secure SCMI fastchannels are used to communicate with LCP to set the desired performance.

[edk2-devel] [edk2-platforms][PATCH v3 7/8] Platform/Sgi: Low Power Idle States for RD-Fremont

RD-Fremont platform supports two LPI states, LPI1 (Standby WFI) and LPI3 (Power-down). The cluster supports LPI2 (Power-down) state. The LPI implementation also supports combined power state for core and cluster. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH v3 6/8] Platform/Sgi: Extend SMBIOS support for RD-Fremont

Extend the SMBIOS support for RD-Fremont platform. RD-Fremont is a 16 core platform with Poseidon CPU. Each of the CPUs include 64KB L1 Data cache, 64KB L1 Instruction cache and 2MB L2 cache. The platform also includes system level cache of 32MB and 8GB of RAM. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH v3 5/8] Platform/Sgi: Add initial support for RD-Fremont platform

The RD-Fremont fixed virtual platform simulates 16 CPUs and 8GB of RAM. Add initial support for this platform by adding the required platform build configuration files. This platform has considerable differences in its memory map compared to its predecessors. So add a corresponding memory map file

[edk2-devel] [edk2-platforms][PATCH v3 4/8] Platform/Sgi: Add ACPI tables for RD-Fremont platform

From: Shriram K RD-Fremont is the next platform in the Arm's reference design platform series. This platform includes 32 CPUs but the fixed virtual platform (FVP) simulates 16 CPUs of the platform. There is one CPU per cluster in the system and so the FVP simulates 16 clusters. In preparation

[edk2-devel] [edk2-platforms][PATCH v3 3/8] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms

Introducing a flag called PCIE_ENABLE, which can be set to TRUE or FALSE from the respective .dsc files to enable or disable the PCIe support. As not all reference design platforms have PCIe support enabled, this flag is introduced. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH v3 2/8] Platform/Sgi: Refactor system memory base and size definitions

In preparation of adding the next generation of reference design platform that have different memory map, refactor the PcdSystemMemoryBase and PcdSystemMemorySize PCD definitions from the common PCD definitions file into the various platform generation specific memory map PCD definitions file.

[edk2-devel] [edk2-platforms][PATCH v3 1/8] Platform/Sgi: Update the datatype of PcdSmmuBase from u32 to u64

From: Vivek Gautam On RD-N2 and previous generation platforms, the base address was within 32-bit region. However, on upcoming platforms, the SMMUv3 base address is beyond 32-bit address region. So, update the datatype of SMMUv3 base PCD. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH v3 0/8] Platform/Sgi: Add support for RD-Fremont platform

Changes since V2: - Removed author's signed-off on the patches, which is owned by another author. Changes since V1: - Corrected memory map in the DSDT file. This patch series introduce support for RD-Fremont reference design platform. This platform includes 32 CPUs, but the fixed virtual

[edk2-devel] [edk2-platforms][PATCH v4 6/6] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

From: Pranav Madhu The Neoverse RD-V2 FVP platform includes 16 CPUs and each CPU has 64KB of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level cache. Extend the SMBIOS support for RD-V2 platform with this configuration and reuse rest of the RD-N2 SMBIOS configuration for the

[edk2-devel] [edk2-platforms][PATCH v4 5/6] Platform/Sgi: Define RD-V2 platform id values

From: Pranav Madhu Add RD-V2 platform identification values including the part number and configuration number. This information will be used in populating the SMBIOS tables. Signed-off-by: Prabin CA --- Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7 ++-

[edk2-devel] [edk2-platforms][PATCH v4 4/6] Platform/Sgi: Add support for RD-N2-Cfg3 platform

The Neoverse RD-N2-Cfg3 platform is a variant of RD-N2 platform with a different mesh size and GIC ITS count. As part of the initial platform support, add the corresponding platform and flash description files. Use PcdPlatformVariant for the RD-N2-Cfg3 platform to specify the platform variant.

[edk2-devel] [edk2-platforms][PATCH v4 3/6] Platform/Sgi: Add a PCD to specify platform variant

A new PCD named PcdPlatformVariant is introduced to specify the variant number of a platform. This PCD can be used to select platform variant specific configurations. The default value of this PCD is 0 which selects the base variant. Signed-off-by: Prabin CA ---

[edk2-devel] [edk2-platforms][PATCH v4 2/6] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency

From: Vijayenthiran Subramaniam REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3479 A recent change in MdeModulePkg [1] introduced VariableFlashInfoLib as a dependency to support dynamic variable flash information. Add an instance for the library class VariableFlashInfoLib in

[edk2-devel] [edk2-platforms][PATCH v4 1/6] Platform/Sgi: remove +nofp gcc option flag

From: Omkar Anand Kulkarni The software executing at a higher privileged level on the reference design platforms have been updated to allow software executing at EL1 and EL0 to access the Advanced SIMD and floating-point registers (FPEN field of CPACR_EL1 system register is programmed to allow

[edk2-devel] [edk2-platforms][PATCH v4 0/6] Platform/Sgi: Add support for RD-N2-Cfg3 and RD-V2 platform

Changes since V3: - Removed author's signed-off on the patches, which is owned by another author. Changes since V2: - Removed the patch which introduce fno-stack-protector in the build flag. Changes since V1: - Addressed comments from Sami This patch series introduces support for two reference

Re: [edk2-devel] [PATCH 11/11] OvmfPkg/CI: copy shell to virtual drive

On 1/24/24 17:38, Gerd Hoffmann wrote: > Place the EFI shell as EFI/BOOT/BOOT{ARCH}.EFI on the virtual drive. > This allows the "run to shell" CI test case to work even in case the > shell is not included in the firmware image. In the commit message, can you list the platforms explicitly that

Re: [edk2-devel] [PATCH 10/11] OvmfPkg: switch MicrovmX64 to new shell include files

On 1/24/24 17:38, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/Microvm/MicrovmX64.dsc | 55 -- > OvmfPkg/Microvm/MicrovmX64.fdf | 9 ++ > 2 files changed, 14 insertions(+), 50 deletions(-) > > diff --git

Re: [edk2-devel] [PATCH 09/11] OvmfPkg: switch IntelTdxX64 to new shell include files

On 1/24/24 17:38, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 33 +++- > OvmfPkg/IntelTdx/IntelTdxX64.fdf | 9 ++--- > 2 files changed, 5 insertions(+), 37 deletions(-) > > diff --git

Re: [edk2-devel] [PATCH 08/11] OvmfPkg: switch AmdSevX64 to new shell include files

On 1/24/24 17:37, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/AmdSev/AmdSevX64.dsc | 32 ++-- > OvmfPkg/AmdSev/AmdSevX64.fdf | 8 ++-- > 2 files changed, 4 insertions(+), 36 deletions(-) > > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc

Re: [edk2-devel] [PATCH 07/11] OvmfPkg: switch OvmfPkgIa32X64 to new shell include files

On 1/24/24 17:37, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/OvmfPkgIa32X64.dsc | 54 +- > OvmfPkg/OvmfPkgIa32X64.fdf | 11 ++-- > 2 files changed, 8 insertions(+), 57 deletions(-) > > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc

Re: [edk2-devel] [PATCH 06/11] OvmfPkg: switch OvmfPkgIa32 to new shell include files

On 1/24/24 17:37, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/OvmfPkgIa32.dsc | 49 ++--- > OvmfPkg/OvmfPkgIa32.fdf | 11 ++--- > 2 files changed, 4 insertions(+), 56 deletions(-) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc

Re: [edk2-devel] [PATCH 05/11] OvmfPkg: ShellDxe.fdf.inc: add VariablePolicyDynamicCommand to FV

On 1/24/24 17:37, Gerd Hoffmann wrote: > Needed to make the new 'varpolicy' EFI shell command > actually available in the OVMF firmware builds. > > Fixes: fe6cd1c18721 ("OvmfPkg: Add varpolicy shell command") > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/Include/Fdf/ShellDxe.fdf.inc | 1 + > 1

Re: [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended topology

On 1/25/24 04:20, Ni, Ray via groups.io wrote: Acked-by: Ray Ni + Tom Looks good to me. Should AmdGetProcessorLocation2ByApicId() be STATIC? Not asking for this patch series, but there is a lot of duplicated code between the two APIC libraries. It would be nice if there was a way to have

Re: [edk2-devel] [PATCH v5 00/11] DynamicTablesPkg: Enable _PSD/_CPC generation using SCMI

Hi Pierre, On Thu, 25 Jan 2024 at 16:19, PierreGondois wrote: > > v1: > - https://edk2.groups.io/g/devel/message/104115 > v2: > - https://edk2.groups.io/g/devel/message/104115 > - Rebase patches on latest version. > v3: > - https://edk2.groups.io/g/devel/message/111567 > [PATCH 01/11]

Re: [edk2-devel] [PATCH v2] UefiPayloadPkg/Crypto: Support external Crypto drivers.

Thanks Gua! Reviewed-by: Chasel Chiu > -Original Message- > From: Guo, Gua > Sent: Wednesday, January 24, 2024 9:09 PM > To: devel@edk2.groups.io > Cc: Guo, Gua ; Chiu, Chasel ; > Dong, Guo ; Rhodes, Sean ; Lu, > James > Subject: [PATCH v2] UefiPayloadPkg/Crypto: Support external

Re: [edk2-devel] RFC: Another solution to the nested interrupt issue

On 25/01/2024 15:06, Ni, Ray wrote: I agree with you about the above PI spec clarifications. Would you like to write a PI spec ECR? I am not a UEFI Forum member, so I don't think I have standing to do this. (I also don't have the spare time to do this for free, sorry.) But I do not think

[edk2-devel] [PATCH v5 4/4] Platform/ARM: Juno: Use Pcd for _CPC generation

From: Pierre Gondois Make use of the newly added PcdDevelopmentPlatformRelaxations to decide to try generating _CPC information. Signed-off-by: Pierre Gondois --- Platform/ARM/JunoPkg/ArmJuno.dsc | 5 + .../ConfigurationManagerDxe/ConfigurationManager.c| 11

[edk2-devel] [PATCH v5 3/4] Platform/ARM: Juno: Generate _CPC objects for JunoR2

From: Pierre Gondois The SsdtCpuTopologyGenerator can generate _CPC objects. This is done by querying the SCP for the relevant performance state information through SCMI. CM_ARM_CPC_INFO are then populated and used to generate _CPC objects in the Ssdt Cpu topology. Use the

[edk2-devel] [PATCH v5 2/4] Platform/ARM: Juno: Generate _PSD objects

From: Pierre Gondois The SsdtCpuTopologyGenerator can generate _PSD objects. Add _PSD information and handling to the Configuration Manager to generate them. Reviewed-by: Sami Mujawar Signed-off-by: Pierre Gondois --- .../ConfigurationManager.c| 98 +--

[edk2-devel] [PATCH v5 1/4] Platform/ARM: Juno: Fix typo

From: Pierre Gondois Fix a typo. Reviewed-by: Sami Mujawar Signed-off-by: Pierre Gondois --- .../ConfigurationManagerDxe/ConfigurationManager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH v5 0/4] Platform/ARM: Enable _CPC/_PSD generation on Juno-r2

From: Pierre Gondois v1: - https://edk2.groups.io/g/devel/message/104127 v2: - https://edk2.groups.io/g/devel/message/110048 - Rebase patches on latest version. - Correct frequency values which were advertised in KHz when CPPC spec require them to be in MHz. v3: -

[edk2-devel] [PATCH v5 10/11] DynamicTablesPkg: Add PcdDevelopmentPlatformRelaxations Pcd

Some development platforms might not be compliant on some points of some specifications. In order to have a generic code accurately checking against specifications while still allowing some relaxation on specific points for the platforms that desire it, add a Pcd acting as a bitfield to warn

[edk2-devel] [PATCH v5 11/11] DynamicTablesPkg: Exempt some _CPC field from checks

When generating _CPC objects, some fields are mandatory by spec [1]. Some fields cannot be supported by a the Juno platform, which is used to test the _CPC generation. Therefore, rely on the PcdDevelopmentPlatformRelaxations Pcd to either: - warn about the missing fields and and let the OS handle

[edk2-devel] [PATCH v5 09/11] DynamicTablesPkg: Add DynamicTablesScmiInfoLib

The SCP holds some power information that could be advertised through the _CPC object. The communication with the SCP is done through SCMI protocols (c.f. ArmScmiDxe). Use the SCMI protocols to query information and feed it to the DynamicTablesPkg. Acked-by: Leif Lindholm Signed-off-by: Pierre

[edk2-devel] [PATCH v5 08/11] DynamicTablesPkg: Generate _PSD in SsdtCpuTopologyGenerator

Make use of the newly added AmlCreatePsdNode() to generate _PSD objects. _PSD objects allow to describe 'performance control, P-state or CPPC, logical processor dependency', Cf. ACPI 6.4, s8.4.5.5 _PSD (P-State Dependency). Reviewed-by: Sami Mujawar Signed-off-by: Pierre Gondois ---

[edk2-devel] [PATCH v5 07/11] DynamicTablesPkg: Add AmlCreatePsdNode() to generate _PSD

Add AmlCreatePsdNode() to the AmlLib to generate _PSD objects. _PSD objects allow to describe 'performance control, P-state or CPPC, logical processor dependency', Cf. ACPI 6.5, s8.4.5.5 _PSD (P-State Dependency). Signed-off-by: Pierre Gondois --- .../Include/Library/AmlLib/AmlLib.h |

[edk2-devel] [PATCH v5 06/11] DynamicTablesPkg: Add PsdToken field to CM_ARM_GICC_INFO object

The _PSD object (cf. ACPI 6.5, s8.4.5.5 _PSD (P-State Dependency) allows to describe CPU's power state dependencies. Add a PsdToken field to the CM_ARM_GICC_INFO object so that interdependent CPUs can reference the same CM_ARM_PSD_INFO object. Reviewed-by: Sami Mujawar Signed-off-by: Pierre

[edk2-devel] [PATCH v5 05/11] DynamicTablesPkg: Add CM_ARM_PSD_INFO object

Add an object describing _PSD information, cf. ACPI 6.5, s8.4.5.5 _PSD (P-State Dependency). Also add the corresponding CmObjParser. Signed-off-by: Pierre Gondois --- DynamicTablesPkg/Include/AcpiObjects.h| 20 +++ .../Include/ArmNameSpaceObjects.h | 10

[edk2-devel] [PATCH v5 04/11] DynamicTablesPkg: Rename AmlCpcInfo.h to AcpiObjects.h

The DynamicTables framework uses the AmlLib to generate some Aml objects. It is done by using structured known by both frameworks, e.g. the AML_CPC_INFO/CM_ARM_CPC_INFO structures. To prepare adding similar structures (e.g. representing _PSD information), rename AmlCpcInfo.h to AcpiObjects.h.

[edk2-devel] [PATCH v5 02/11] ArmPkg/ArmScmiDxe: Add PERFORMANCE_DESCRIBE_FASTCHANNEL support

The PERFORMANCE_DESCRIBE_FASTCHANNEL Scmi command is available since SCMI v2.0 and allows to query information about the supported fast-channels of the Scmi performance protocol. Add support for this command. Also move SCMI_MESSAGE_ID_PERFORMANCE enum definition up in the file to use it in

[edk2-devel] [PATCH v5 03/11] DynamicTablesPkg: Use new CPC revision macro

Make use of the newly added CPC revision macro. Reviewed-by: Sami Mujawar Signed-off-by: Pierre Gondois --- DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH v5 01/11] ArmPkg/ArmScmiDxe: Rename PERFORMANCE_PROTOCOL_VERSION

Rename PERFORMANCE_PROTOCOL_VERSION to reflect the different versions of the protocol. The macro is neither used in edk2 nor in edk2-platforms. Reviewed-by: Leif Lindholm Reviewed-by: Sami Mujawar Signed-off-by: Pierre Gondois --- .../Include/Protocol/ArmScmiPerformanceProtocol.h | 13

[edk2-devel] [PATCH v5 00/11] DynamicTablesPkg: Enable _PSD/_CPC generation using SCMI

v1: - https://edk2.groups.io/g/devel/message/104115 v2: - https://edk2.groups.io/g/devel/message/104115 - Rebase patches on latest version. v3: - https://edk2.groups.io/g/devel/message/111567 [PATCH 01/11] ArmPkg/ArmScmiDxe: Rename PERFORMANCE_PROTOCOL_VERSION - Note the referenced spec spec is

Re: [edk2-devel] RFC: Another solution to the nested interrupt issue

> That would then be a bug in HpetTimer, which ought to be fixed. If > HpetTimer were to be used on a platform where the NotifyFunction > correctly assumes that it is called at TPL_HIGH_LEVEL and does something > that would break at a lower level, then this could lead to undefined > behaviour.

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver

From: Abner Chang Initial version of edk2 Redfish feature of Redfish schema ComputerSystem_1_13_0. This driver handles ComputerSystem Boot properties but not all. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../v1_13_0/Dxe/ComputerSystemDxe.inf | 53 ++

Re: [edk2-devel] RFC: Another solution to the nested interrupt issue

On 25/01/2024 13:54, Ni, Ray wrote: I don't disagree with the approach, but it does break the API as per the UEFI PI specification (version 1.8 section II-12.10), and so this is not something that can just be dropped in as an EDK2 code change. You think that the TimerInterruptHandler() doesn't

Re: [edk2-devel] [PATCH v4 2/3] Platform/ARM: Juno: Generate _PSD objects

Hi Pierre, Please see my response inline marked [SAMI]. Regards, Sami Mujawar On 25/01/2024, 12:48, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote: Hello Sami, On 1/25/24 12:31, Sami Mujawar wrote: > Hi Pierre, > > Thank you for this patch. > I just have a minor suggestion marked

Re: [edk2-devel] RFC: Another solution to the nested interrupt issue

> On 25/01/2024 07:57, Ni, Ray wrote: > > This mail is to bring another approach to solve the stack-overflow due > > to nested interrupts. Michael solved this problem in OVMF through > > NestedInterruptTplLib. > > > > I made a draft patch as attached “DxeCore.diff”. The patch simply to > > avoid

Re: [edk2-devel] [PATCH 04/11] OvmfPkg: Shell*.inc: allow building without network support

On 1/24/24 17:37, Gerd Hoffmann wrote: > Add NETWORK_ENABLE conditionals for the components > which need network support. > > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/Include/Dsc/ShellComponents.dsc.inc | 4 > OvmfPkg/Include/Fdf/ShellDxe.fdf.inc| 2 ++ > 2 files changed, 6

Re: [edk2-devel] [PATCH 03/11] OvmfPkg: add ShellDxe.fdf.inc

On 1/24/24 17:37, Gerd Hoffmann wrote: > Move EFI Shell firmware volume files to > the new ShellDxe.fdf.inc file. > > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/OvmfPkgX64.fdf | 11 ++- > OvmfPkg/Include/Fdf/ShellDxe.fdf.inc | 14 ++ > 2 files changed, 16

Re: [edk2-devel] [PATCH 02/11] OvmfPkg: add ShellLibs.dsc.inc

I have several comments on this one: On 1/24/24 17:37, Gerd Hoffmann wrote: > Move EFI Shell libraries from OvmfPkgX64.dsc to > the new ShellComponents.dsc.inc include file. > > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/Include/Dsc/ShellLibs.dsc.inc | 11 +++ > OvmfPkg/OvmfPkgX64.dsc

Re: [edk2-devel] RFC: Another solution to the nested interrupt issue

On 25/01/2024 07:57, Ni, Ray wrote: This mail is to bring another approach to solve the stack-overflow due to nested interrupts. Michael solved this problem in OVMF through NestedInterruptTplLib. I made a draft patch as attached “DxeCore.diff”. The patch simply to avoid the interrupt in

Re: [edk2-devel] [PATCH v4 2/3] Platform/ARM: Juno: Generate _PSD objects

Hello Sami, On 1/25/24 12:31, Sami Mujawar wrote: Hi Pierre, Thank you for this patch. I just have a minor suggestion marked inline as [SAMI]. Otherwise, this patch looks good to me. With that addressed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 12/12/2023, 09:31,

Re: [edk2-devel] [PATCH v3 0/5] MdeModulePkg: Move NestedInterruptTplLib to MdeModulePkg

Michael, Can you check my mail https://edk2.groups.io/g/devel/message/114369? I proposed another solution to fix the infinite nested interrupt issue which I think is simpler. Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Brown > Sent: Tuesday,

Re: [edk2-devel] [PATCH v2 1/2] MdeModulePkg: rename PcdUse5LevelPageTable to PcdEnable5LevelPageTable

On Thu, Jan 25, 2024 at 12:01:46PM +, Ni, Ray wrote: > Rename an existing PCD might break lots of platform builds. > > When 5-level paging capability was added to ResetVector, I also > considered to remove the PcdUse5LevelPageTable reference from C code. > > Let me think about it... Purging

[edk2-devel] [PATCH] AMD/VanGogh: Update VanGogh firmware binaries to UCC4126.3B30 Update firmware binaries for VanGogh B0 processors to UCC4126.3B30

From: Duke Zhai Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang --- Silicon/AMD/VanGogh/Firmwares/TypeId0x08.sbin | Bin 262656 -> 262656 bytes Silicon/AMD/VanGogh/Firmwares/TypeId0x12.sbin | Bin 262656 -> 262656 bytes

Re: [edk2-devel] [Patch V2] BaseTools: VfrCompiler Adds DefaultValueError Feature

Hi Liming, We adopt the solution to send option from module level. We will add --catch_default option into INF for module which need to do VFR default flag check. Thus, VFR Compiler only need to catch one option then do module check. @Yuting, could you help to update the patch for review? Best

[edk2-devel] [PATCH V2 33/33] AMD/VanGoghBoard: Improvement coding style

-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114394): https://edk2.groups.io/g/devel/message/114394 Mute This Topic: https://groups.io/mt/103950361/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH] MdeModulePkg/SMM: Support to unregister SMI handler inside SMI handler

Laszlo, SMI handler is called from SmmCore. So SmmCore knows which handle is passed to the SMI handler. How about let Unregister() rejects the request coming from a SMI handler which unregisters other handles? A "gCurrentSmiHandle" can be assigned before calling the SMI handler and set to NULL

Re: [edk2-devel] [PATCH v2 1/2] MdeModulePkg: rename PcdUse5LevelPageTable to PcdEnable5LevelPageTable

Rename an existing PCD might break lots of platform builds. When 5-level paging capability was added to ResetVector, I also considered to remove the PcdUse5LevelPageTable reference from C code. Let me think about it... Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On

Re: [edk2-devel] [PATCH 01/11] OvmfPkg: add ShellComponents.dsc.inc

On 1/24/24 17:37, Gerd Hoffmann wrote: > Move EFI Shell components from OvmfPkgX64.dsc to > the new ShellComponents.dsc.inc include file. > > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/Include/Dsc/ShellComponents.dsc.inc | 49 + > OvmfPkg/OvmfPkgX64.dsc

Re: [edk2-devel] [PATCH v4 3/3] Platform/ARM: Juno: Generate _CPC objects for JunoR2

Hi Pierre, Thank you for this patch. Please find my feedback inline marked [SAMI]. Regards, Sami Mujawar On 12/12/2023, 09:31, "pierre.gond...@arm.com " mailto:pierre.gond...@arm.com>> wrote: From: Pierre Gondois mailto:pierre.gond...@arm.com>> The

Re: [edk2-devel] [PATCH v4 2/3] Platform/ARM: Juno: Generate _PSD objects

Hi Pierre, Thank you for this patch. I just have a minor suggestion marked inline as [SAMI]. Otherwise, this patch looks good to me. With that addressed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 12/12/2023, 09:31, "pierre.gond...@arm.com "

Re: [edk2-devel] [PATCH v4 1/3] Platform/ARM: Juno: Fix typo

Hi Pierre, Thank you for this patch. This change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 12/12/2023, 09:31, "pierre.gond...@arm.com " mailto:pierre.gond...@arm.com>> wrote: From: Pierre Gondois mailto:pierre.gond...@arm.com>>

Re: [edk2-devel] [PATCH v4 09/10] DynamicTablesPkg: Add DynamicTablesScmiInfoLib

Hi Pierre, I have some minor feedback inline marked [SAMI]. With that fixed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 12/12/2023, 09:30, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote: The SCP holds some power information that could be advertised through the _CPC object.

Re: [edk2-devel] [PATCH v2 1/4] OvmfPkg/Sec: Setup MTRR early in the boot process.

On Thu, Jan 25, 2024 at 8:23 AM Gerd Hoffmann wrote: > > Specifically before running lzma uncompress of the main firmware volume. > This is needed to make sure caching is enabled, otherwise the uncompress > can be extremely slow. > > Adapt the ASSERTs and MTRR setup in PlatformInitLib to the

Re: [edk2-devel] [PATCH] MdeModulePkg/SMM: Support to unregister SMI handler inside SMI handler

On 1/24/24 05:03, Zhiguang Liu wrote: > To support unregister SMI handler inside SMI handler itself, > get next node before SMI handler is executed, since LIST_ENTRY that > Link points to may be freed if unregister SMI handler in SMI handler > itself. > > Cc: Liming Gao > Cc: Jiaxin Wu > Cc:

Re: [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended topology

Acked-by: Ray Ni + Tom Thanks, Ray > -Original Message- > From: Attar, AbdulLateef (Abdul Lateef) > Sent: Thursday, January 25, 2024 1:02 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Liming Gao > ; Liu, Zhiguang ; Ni, > Ray ; Kumar, Rahul R ; Gerd > Hoffmann > Subject: Re:

Re: [edk2-devel] [PATCH] AMD/VanGogh: Update VanGogh firmware binaries to UCC4126.3B30 Update firmware binaries for VanGogh B0 processors to UCC4126.3B30

[AMD Official Use Only - General] Thanks Duke. Reviewed by: Eric Xing > -Original Message- > From: duke.z...@amd.com > Sent: Thursday, January 25, 2024 5:56 PM > To: devel@edk2.groups.io > Cc: Xing, Eric ; Yao, Ken ; Fu, > Igniculus ; Chang, Abner > Subject: [PATCH] AMD/VanGogh:

Re: [edk2-devel] [PATCH v4 1/3] ArmPkg: Update GenericWatchdogDxe to allow setting full 48-bit offset

Hi Rebecca, On 24/01/2024, 19:36, "Rebecca Cran" mailto:rebe...@os.amperecomputing.com>> wrote: On 1/23/2024 7:10 AM, Sami Mujawar wrote: > @@ -310,6 +318,7 @@ GenericWatchdogEntry ( > { > EFI_STATUS Status; > EFI_HANDLE Handle; > + UINT32 WatchdogIId; > [SAMI] Minor, the above variable name

[edk2-devel] [PATCH v2 4/4] OvmfPkg/Sec: use cache type #defines from ArchitecturalMsr.h

Signed-off-by: Gerd Hoffmann --- OvmfPkg/IntelTdx/Sec/SecMain.c | 2 +- OvmfPkg/Sec/SecMain.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/IntelTdx/Sec/SecMain.c b/OvmfPkg/IntelTdx/Sec/SecMain.c index e8ff0e9081d1..6ad2214293b2 100644 ---

[edk2-devel] [PATCH v2 3/4] UefiCpuPkg/MtrrLib.h: use cache type #defines from ArchitecturalMsr.h

Signed-off-by: Gerd Hoffmann --- UefiCpuPkg/Include/Library/MtrrLib.h | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/UefiCpuPkg/Include/Library/MtrrLib.h b/UefiCpuPkg/Include/Library/MtrrLib.h index 86cc1aab3b8e..c7d505ac06ed 100644 ---

[edk2-devel] [PATCH v2 2/4] MdePkg/ArchitecturalMsr.h: add #defines for MTRR cache types

Signed-off-by: Gerd Hoffmann --- MdePkg/Include/Register/Intel/ArchitecturalMsr.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h index 756e7c86ec31..2b2e34b08c8b 100644 ---

[edk2-devel] [PATCH v2 0/4] OvmfPkg/Sec: Setup MTRR early in the boot process.

Also add #defines for MTRR cache types to ArchitecturalMsr.h and followup patches to use these #defines. Gerd Hoffmann (4): OvmfPkg/Sec: Setup MTRR early in the boot process. MdePkg/ArchitecturalMsr.h: add #defines for MTRR cache types UefiCpuPkg/MtrrLib.h: use cache type #defines from

[edk2-devel] [PATCH v2 1/4] OvmfPkg/Sec: Setup MTRR early in the boot process.

Specifically before running lzma uncompress of the main firmware volume. This is needed to make sure caching is enabled, otherwise the uncompress can be extremely slow. Adapt the ASSERTs and MTRR setup in PlatformInitLib to the changes. Background: Depending on virtual machine configuration kvm

[edk2-devel] [PATCH v2 2/2] MdeModulePkg/VirtualMemory: fix 5-level paging assert

The ResetVector decides at runtime (depending on CPU capabilities) whenever it uses 5-level paging or not. Firmware builds with 5-level paging enabled (PcdEnable5LevelPageTable=TRUE) may run run in 4-level paging mode. The code handles that just fine, by looking at the la57 bit in cr4 instead of

[edk2-devel] [PATCH v2 1/2] MdeModulePkg: rename PcdUse5LevelPageTable to PcdEnable5LevelPageTable

The PCD will allow but not require 5-level paging. Whenever 5-level paging is used or not will be decided by the ResetVector, by looking at CPU capabilities. Rename the PCD to make that clear. Signed-off-by: Gerd Hoffmann --- MdeModulePkg/MdeModulePkg.dec| 2 +-

[edk2-devel] [PATCH v2 0/2] MdeModulePkg: 5-level paging fixes

- rename PcdUse5LevelPageTable to PcdEnable5LevelPageTable - relax 5-level paging assert Gerd Hoffmann (2): MdeModulePkg: rename PcdUse5LevelPageTable to PcdEnable5LevelPageTable MdeModulePkg/VirtualMemory: fix 5-level paging assert MdeModulePkg/MdeModulePkg.dec| 2 +-

Re: [edk2-devel] [PATCH 04/33] AMD/VanGoghBoard: Check in AgesaPublic pkg

[AMD Official Use Only - General] Hi Abner, Thanks for your review, we have V2 patch improved the coding style issue. [PATCH V2 33/33] AMD/VanGoghBoard: Improvement coding style Thanks, Eric > -Original Message- > From: Chang, Abner > Sent: Tuesday, January 23, 2024 12:44 PM > To:

Re: [edk2-devel] [PATCH v3 0/4] Bz4166: Integer Overflow in CreateHob()

Hi @Gerd Hoffmann It's PR https://github.com/tianocore/edk2/pull/5298 if no more concern received, will merge it tomorrow morning. Thanks, Gua -Original Message- From: Gerd Hoffmann Sent: Wednesday, January 24, 2024 8:48 PM To: Guo, Gua Cc: devel@edk2.groups.io; Ard Biesheuvel ;

<    1   2