[edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Change MinPlatform MinDsdt and Update SpiFlashCommonLib

2024-03-25 Thread dorax . hsueh
From: DoraX Hsueh https://bugzilla.tianocore.org/show_bug.cgi?id=4662 1. Change MinPlatform MinDsdt to fix hang logo issue. 2. Update SecFspWrapperPlatformSecLib for FSP use. 3. Update SpiFlashCommonLib to fix boot assert issue. 4. Create SmmLocked callback to fix assert Cc: Sai Chaganty Cc:

Re: [edk2-devel] [PATCH 1/3] CryptoPkg/BaseCryptLib: add additional RSAEP-OAEP crypto functions

2024-03-25 Thread Li, Yi
Hi Chris, 1. Add BZ link to commit message, 2. Add null implementation of new APIs to BaseCryptLibMbedTls to avoid build error. For other comments please check the PR: https://github.com/tianocore/edk2/pull/5473 Regards, Yi -Original Message- From: Chris Ruffin Sent: Tuesday, March

Re: [edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool

2024-03-25 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of > phanindrax.babu.pa...@intel.com > Sent: Thursday, February 22, 2024 10:52 PM > To: devel@edk2.groups.io > Cc: Pabba, PhanindraX Babu ; Desimone, > Nathaniel L ; Liming Gao > >

Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg

2024-03-25 Thread Chao Li
Hi Ray, I responded your comments yesterday, it looks like we have different opinions on patches 10 and 11, the rest looks fine. Could you please consider patches 10 and 11? I think this way is probably the best solution. I hope this series to be merged as soon as passable, because the next

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, March 26, 2024 #cal-reminder

2024-03-25 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, March 26, 2024 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH] Platform/Loongson: Remove minimium memory size limitation

2024-03-25 Thread maobibo
On 2024/3/25 下午5:25, xianglai wrote: From: Bibo Mao Temparory stack memory on PEI is hardcoded now, also minimium memory size 256M is hardcoded now. Here memory map table from fw cfg can be parsed. If there is memory map entry contains pei stack, it can be published as usable memory at PEI

Re: [edk2-devel] Cancelled Event: Tools, CI, Code base construction meeting series - Monday, March 25, 2024 #cal-cancelled

2024-03-25 Thread Sean
No requests listed here: Tools and CI Meeting - vNext - Date TBD · tianocore/edk2 · Discussion #5366 (github.com) Cancelling for today. Thanks Sean On 3/25/2024 4:16 PM, Group Notification wrote: *Cancelled: Tools, CI, Code base

[edk2-devel] Cancelled Event: Tools, CI, Code base construction meeting series - Monday, March 25, 2024 #cal-cancelled

2024-03-25 Thread Group Notification
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20231222T233358Z

Re: [edk2-devel] [PATCH] MinPlatformPkg: Add missed call to FreePool

2024-03-25 Thread Nate DeSimone
Hi Babu, If the call to InitializeHeader() fails then the buffer will still not be de-allcoated properly. Please add a Done: label and a goto Done; so that the buffer will still be freed in the case of an error. Thanks, Nate -Original Message- From: Pabba, PhanindraX Babu Sent:

Re: [edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool

2024-03-25 Thread Nate DeSimone
Pushed as 6feac9b -Original Message- From: Pabba, PhanindraX Babu Sent: Thursday, February 22, 2024 10:52 PM To: devel@edk2.groups.io Cc: Pabba, PhanindraX Babu ; Desimone, Nathaniel L ; Liming Gao Subject: [PATCH] IpmiFeaturePkg: Add missed call to FreePool From: PhanindraX Babu

Re: [edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool

2024-03-25 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Pabba, PhanindraX Babu Sent: Thursday, February 22, 2024 10:52 PM To: devel@edk2.groups.io Cc: Pabba, PhanindraX Babu ; Desimone, Nathaniel L ; Liming Gao Subject: [PATCH] IpmiFeaturePkg: Add missed call to FreePool From:

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, March 25, 2024 #cal-reminder

2024-03-25 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, March 25, 2024 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH edk2-platforms v9 4/4] Platform/SbsaQemu: get the information of memory via SMC calls

2024-03-25 Thread Leif Lindholm
On Fri, Mar 22, 2024 at 17:08:50 +0100, Marcin Juszkiewicz wrote: > From: Xiong Yining > > Provide functions to check for memory information: > > - amount of memory nodes > - memory address > - NUMA node id for memory > > Values are read from TF-A using platform specific SMC calls. Same

Re: [edk2-devel] [PATCH edk2-platforms v9 3/4] Platform/SbsaQemu: drop use of DeviceTree

2024-03-25 Thread Leif Lindholm
On Fri, Mar 22, 2024 at 17:08:49 +0100, Marcin Juszkiewicz wrote: > There is no need for EDK2 to know that there is DeviceTree around. > All hardware information is read using functions from > SbsaQemuHardwareInfoLib library. > > Signed-off-by: Marcin Juszkiewicz Reviewed-by: Leif Lindholm /

Re: [edk2-devel] [PATCH edk2-platforms v9 2/4] Platform/SbsaQemu: use SbsaQemuHardwareInfoLib for cpu information

2024-03-25 Thread Leif Lindholm
On Fri, Mar 22, 2024 at 17:08:48 +0100, Marcin Juszkiewicz wrote: > We have SbsaQemuHardwareInfoLib to ask for hardware details. No need to > parse DeviceTree anymore. > > Signed-off-by: Marcin Juszkiewicz Nitpicks or changing function calls based on what I commented on in previous patch does

Re: [edk2-devel] [PATCH edk2-platforms v9 1/4] Platform/SbsaQemu: add SbsaQemuHardwareInfoLib

2024-03-25 Thread Leif Lindholm
On Fri, Mar 22, 2024 at 17:08:47 +0100, Marcin Juszkiewicz wrote: > This library provides functions to check for hardware information. > For now it covers CPU ones: > > - amount of cpu cores > - MPIDR value for cpu core > - NUMA node id for cpu core > > Values are read from TF-A using platform

Re: [edk2-devel] [RFC PATCH] OvmfPkg/SecurityPkg: Add build option for coexistance of vTPM and RTMR.

2024-03-25 Thread Dionna Glaze via groups.io
On Mon, Mar 25, 2024 at 6:07 AM Mikko Ylinen wrote: > > > > > > > Looking at systemd-boot I see it will likewise not measure to both RTMR > > > and vTPM, but with reversed priority (use vTPM not RTMR in case both are > > > present). > > > > > > > Interesting. Thanks for this report. We'll push

Re: [edk2-devel] [PATCH RESEND edk2-platforms v1 0/3] Platform/Arm: StandloneMm support for FVP.

2024-03-25 Thread Sami Mujawar
Merged as 80ee8b861edb..e090e6698bda Thanks. Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117086): https://edk2.groups.io/g/devel/message/117086 Mute This Topic: https://groups.io/mt/103827099/21656 Group

Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consecutive Pxe-Http Boot Issue

2024-03-25 Thread Sivaraman Nainar via groups.io
Hi Saloni: " On 2/27/24 05:49, Sivaraman Nainar wrote: > Hi Laszlo, > > We can see the issue not only with SLES, it can be seen with Ubuntu 22 also. > > Do we have any channel to work with grub team to fix this issue? No particular channel. Oliver has been participating in upstream grub2

[edk2-devel] [PATCH] Platform/Loongson: Remove minimium memory size limitation

2024-03-25 Thread xianglai
From: Bibo Mao Temparory stack memory on PEI is hardcoded now, also minimium memory size 256M is hardcoded now. Here memory map table from fw cfg can be parsed. If there is memory map entry contains pei stack, it can be published as usable memory at PEI stage. Signed-off-by: Bibo Mao

Re: [edk2-devel] [PATCH v2 0/2] ShellPkg/AcpiView: Adds HPET and WSMT parser

2024-03-25 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Attar, AbdulLateef (Abdul Lateef) > Sent: Thursday, March 21, 2024 11:19 AM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Pierre Gondois > Subject: Re: [edk2-devel] [PATCH v2 0/2] ShellPkg/AcpiView: Adds HPET and

Re: [edk2-devel] [PATCH 2/4] ShellPkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx

2024-03-25 Thread Gao, Zhichao
Good catch. Please update the commit message. Then take my R-B. Thanks, Zhichao From: Chao Li Sent: Wednesday, March 13, 2024 10:13 AM To: devel@edk2.groups.io; Shang, Qingyu Cc: Liming Gao ; Gao, Zhichao Subject: Re: [edk2-devel] [PATCH 2/4] ShellPkg: Update the comments of ReadKeyStroke

Re: [edk2-devel] [PATCH 2/4] ShellPkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx

2024-03-25 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Shang, Qingyu > Sent: Monday, March 11, 2024 4:41 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; Gao, Zhichao > ; Chao Li > Subject: [PATCH 2/4] ShellPkg: Update the comments of ReadKeyStroke and > ReadKeyStrokeEx