[edk2-devel] PcdMemoryProfilePropertyMask declared as dynamic type

2024-04-08 Thread Yoshinoya
Hello, PcdMemoryProfilePropertyMask declared as a PcdsFixedAtBuild type It means user should recompile source code if he wants to change this pcd default value. So, could we declare it as a PcdsDynamic type? So, user could change PcdMemoryProfilePropertyMask's setting value through BIOS

Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg

2024-04-08 Thread Ni, Ray
Chao, Current patch introduces the CpuMmuInitLib which contains ConfigureMemoryManagementUnit () API. You told me the API will be called by a PEIM. Then, the new proposal is to move the library code into that PEIM. I don't quite understand your needs of the new GUID to store the memory map

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Optional Plugin for FSP SecCore/PeiCore Rebasing

2024-04-08 Thread Ni, Ray
This optional plugin is designed to execute before the FSP SecCore to rebase SecCore and PeiCore during runtime. If the FSP binary requires rebasing at runtime, this module should be included within the FSP binary. Additionally, specific patches must be applied to ensure proper functionality. In

Re: [edk2-devel] OVMF SMM Support

2024-04-08 Thread Wu, Jiaxin
Thank you Michael & Gerd, it does the problem of https://gitlab.com/qemu-project/qemu/-/issues/2064. The issue is gone with latest QEMU version. Thanks, Jiaxin > -Original Message- > From: Michael Kubacki > Sent: Tuesday, April 9, 2024 8:55 AM > To: devel@edk2.groups.io; Wu, Jiaxin ;

Re: [edk2-devel] [edk2-platforms][PATCH v3 1/5] MdeModulePkg: Allow dynamic generation of HEST ACPI table

2024-04-08 Thread Dhaval Sharma
Hi, Is there any plan to upstream these HEST/ACPI patches? They seem to be arch agnostic. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117526): https://edk2.groups.io/g/devel/message/117526 Mute This Topic:

[edk2-devel] [PATCH v5 6/6] uefi-sct/SctPkg: TCG MORLOCK Locked with Key State Test

2024-04-08 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLock Locked with Key State test cases -Add remaining Assertions 32 - 49 from SCT spec -Add Test Case to

[edk2-devel] [PATCH v5 5/6] uefi-sct/SctPkg: TCG MORLOCK Locked No Key State Test

2024-04-08 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLock Locked No Key State test cases -Add Assertions 21 - 31 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G

[edk2-devel] [PATCH v5 4/6] uefi-sct/SctPkg: TCG MORLOCK Unlocked State Test

2024-04-08 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLock Unlocked State test cases -Add Assertions 17, 18, 19, and 20 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest

[edk2-devel] [PATCH v5 3/6] uefi-sct/SctPkg: TCG MORLOCK SetVariable Test

2024-04-08 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLockSetVariable test cases -Add Assertions 7 through 16 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G

[edk2-devel] [PATCH v5 2/6] uefi-sct/SctPkg: TCG MOR SetVariable Test

2024-04-08 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlSetVariable test cases -Add Assertions 5 and 6 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G Edhaya Chandran

[edk2-devel] [PATCH v5 1/6] uefi-sct/SctPkg: TCG Platform Reset Check Test

2024-04-08 Thread Abhimanyu Singh
From: "Abhi.Singh" SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement initial test infrastructure for all test cases including updates to: CommonGenFramework.sh, UEFI_SCT.dsc, and Category.ini. -Add Guid.c and

[edk2-devel] [PATCH v5 0/6] EDK2-TEST TCG MOR Tests

2024-04-08 Thread Abhimanyu Singh
Updates after feedback from Sunny -updated several SCT assertion string outputs -these were done make the assertions more descriptive -fixed the issue in patch 5/6 that contained stray chars from a merge Patch series: These tests support platform firmware that implement

Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg

2024-04-08 Thread Chao Li
Hi Ray, I'm willing change it to a PEIM if it doesn't fit as a library. I think if it is a PEIM, we need a new GUID to sotre the memory map resouce, or use an already defined GUID. I will put it under the UefiCpuPkg, called CpuMmuInitPei, folder: UefiCpuPkg/CpuMmuInitPei/LoongArch64/. May

Re: [edk2-devel] [PATCH 1/3] OptionRomPkg: Update the comments of GetInformation function

2024-04-08 Thread Pedro Falcato
On Mon, Apr 8, 2024 at 10:48 AM Qingyu wrote: > > Refer to Uefi spec 2.10 section 11.11.2, add a new retval > EFI_NOT_FOUND to EFI_ADAPTER_INFORMATION_PROTOCOL.GetInformation(). > Reference: [mantis #1866] - GetInfo() of Adapter Information > Protocol should have a provision for IHV to return no

Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg

2024-04-08 Thread Ni, Ray
Chao, Sorry I missed your mail. If ConfigureMemoryManagementUnit() is called in PEI, can you move the logic to a LoongArch specific PEIM? My concern is we may need more review on the lib API ConfigureMemoryManagementUnit() if we position it as a library. If we move the logic in a PEIM and the

Re: [edk2-devel] [PATCH 1/3] OptionRomPkg: Update the comments of GetInformation function

2024-04-08 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray From: Shang, Qingyu Sent: Monday, April 8, 2024 17:47 To: devel@edk2.groups.io Cc: Pedro Falcato ; Ni, Ray ; Gahan Saraiya Subject: [PATCH 1/3] OptionRomPkg: Update the comments of GetInformation function Refer to Uefi spec

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, April 9, 2024 #cal-reminder

2024-04-08 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, April 9, 2024 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] OVMF SMM Support

2024-04-08 Thread Michael Kubacki
Might be related to this issue https://gitlab.com/qemu-project/qemu/-/issues/2064. On 4/8/2024 4:33 AM, Wu, Jiaxin wrote: Hi Gerd, With below OVMF build and QEMU command, OVMF hangs after SendSmiIpi (mBspApicId) during SmmRelocateBases(), is there any issues with latest code to support SMM

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, April 8, 2024 #cal-notice

2024-04-08 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, April 8, 2024 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Change MinPlatform MinDsdt and Update SpiFlashCommonLib

2024-04-08 Thread Nate DeSimone
Pushed as 39bb294 > -Original Message- > From: Hsueh, DoraX > Sent: Monday, March 25, 2024 10:48 PM > To: devel@edk2.groups.io > Cc: Hsueh, DoraX ; Chaganty, Rangasai V > ; Chuang, Rosen ; > Kasbekar, Saloni ; Tang, Haoyu > ; Desimone, Nathaniel L > > Subject: [PATCH]

Re: [edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Change MinPlatform MinDsdt and Update SpiFlashCommonLib

2024-04-08 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Hsueh, DoraX > Sent: Monday, March 25, 2024 10:48 PM > To: devel@edk2.groups.io > Cc: Hsueh, DoraX ; Chaganty, Rangasai V > ; Chuang, Rosen ; > Kasbekar, Saloni ; Tang, Haoyu > ; Desimone, Nathaniel L > > Subject: [PATCH]

Re: [edk2-devel] [PATCH] AlderlakeSiliconPkg: Update for SPI2 Protocol and Identify flash regions by GUID

2024-04-08 Thread Nate DeSimone
Pushed as e0051bc > -Original Message- > From: devel@edk2.groups.io On Behalf Of > dorax.hs...@intel.com > Sent: Thursday, February 1, 2024 10:32 PM > To: devel@edk2.groups.io > Cc: Hsueh, DoraX ; Chaganty, Rangasai V > ; Chuang, Rosen ; > Kasbekar, Saloni ; Tang, Haoyu > > Subject:

Re: [edk2-devel] [PATCH] AlderlakeSiliconPkg: Update for SPI2 Protocol and Identify flash regions by GUID

2024-04-08 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: devel@edk2.groups.io On Behalf Of > dorax.hs...@intel.com > Sent: Thursday, February 1, 2024 10:32 PM > To: devel@edk2.groups.io > Cc: Hsueh, DoraX ; Chaganty, Rangasai V > ; Chuang, Rosen ; > Kasbekar, Saloni ; Tang, Haoyu > >

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, April 8, 2024 #cal-reminder

2024-04-08 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, April 8, 2024 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Fix BootStage 5 can't install Windows11.

2024-04-08 Thread Nate DeSimone
Hi Dora, Removing FvAdvanced in a violation of the MinPlatform specification. The relevant section is here: https://tianocore-docs.github.io/edk2-MinimumPlatformSpecification/draft/appendix_a_full_maps/a1_firmware_volume_layout.html#a1-firmware-volume-layout Please add FvAdvanced back into the

Re: [edk2-devel] [PATCH 2/3] MinPlatformPkg: Update the comments of GetInformation function

2024-04-08 Thread Nate DeSimone
Pushed as 1c41906 > -Original Message- > From: Shang, Qingyu > Sent: Monday, April 8, 2024 2:47 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric ; Gahan Saraiya > Subject: [PATCH 2/3] MinPlatformPkg: Update the comments of >

Re: [edk2-devel] [PATCH 2/3] MinPlatformPkg: Update the comments of GetInformation function

2024-04-08 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Shang, Qingyu > Sent: Monday, April 8, 2024 2:47 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric ; Gahan Saraiya > Subject: [PATCH 2/3] MinPlatformPkg: Update the comments of

Re: [edk2-devel] [PATCH v6 3/3] IntelFsp2WrapperPkg: Fix UPD structure Reserved bytes

2024-04-08 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Duggapu, Chinni B > Sent: Friday, April 5, 2024 10:06 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L ; Chiu, Chasel > ; Duggapu, Chinni B > Subject: [PATCH v6 3/3] IntelFsp2WrapperPkg: Fix UPD

Re: [edk2-devel] [PATCH v6 2/3] IntelFsp2WrapperPkg: Fsp T new ARCH UPD Support

2024-04-08 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Duggapu, Chinni B > Sent: Friday, April 5, 2024 10:06 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L ; Chiu, Chasel > ; Duggapu, Chinni B > Subject: [PATCH v6 2/3] IntelFsp2WrapperPkg: Fsp T new

Re: [edk2-devel] [PATCH v6 1/3] IntelFsp2Pkg: Fsp T new ARCH UPD Support

2024-04-08 Thread Nate DeSimone
Hi Chinni, One minor feedback below. With that change... Reviewed-by: Nate DeSimone > -Original Message- > From: Duggapu, Chinni B > Sent: Friday, April 5, 2024 10:06 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L ; Chiu, Chasel > ; Duggapu, Chinni

Re: [edk2-devel] [PATCH v2] NetworkPkg/HttpBootDxe: Correctly uninstall HttpBootCallbackProtocol

2024-04-08 Thread Mike Beaton
Does anybody have any suggestions who I should cc as regards this? Is it preferred to make a bugtracker issue too? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117500): https://edk2.groups.io/g/devel/message/117500 Mute This Topic:

[edk2-devel] [PATCH 3/3] Silicon/Marvell: Update the comments of GetInformation function

2024-04-08 Thread Qingyu
Refer to Uefi spec 2.10 section 11.11.2, add a new retval EFI_NOT_FOUND to EFI_ADAPTER_INFORMATION_PROTOCOL.GetInformation(). Reference: [mantis #1866] - GetInfo() of Adapter Information Protocol should have a provision for IHV to return no data. Cc: Marcin Wojtas Signed-off-by: Qingyu

[edk2-devel] [PATCH 2/3] MinPlatformPkg: Update the comments of GetInformation function

2024-04-08 Thread Qingyu
Refer to Uefi spec 2.10 section 11.11.2, add a new retval EFI_NOT_FOUND to EFI_ADAPTER_INFORMATION_PROTOCOL.GetInformation(). Reference: [mantis #1866] - GetInfo() of Adapter Information Protocol should have a provision for IHV to return no data. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao

[edk2-devel] [PATCH 1/3] OptionRomPkg: Update the comments of GetInformation function

2024-04-08 Thread Qingyu
Refer to Uefi spec 2.10 section 11.11.2, add a new retval EFI_NOT_FOUND to EFI_ADAPTER_INFORMATION_PROTOCOL.GetInformation(). Reference: [mantis #1866] - GetInfo() of Adapter Information Protocol should have a provision for IHV to return no data. Cc: Pedro Falcato Cc: Ray Ni Signed-off-by:

[edk2-devel] [PATCH 0/3] Update the comments of GetInformation function

2024-04-08 Thread Qingyu
Refer to Uefi spec 2.10 section 11.11.2, add a new retval EFI_NOT_FOUND to EFI_ADAPTER_INFORMATION_PROTOCOL.GetInformation(). Reference: [mantis #1866] - GetInfo() of Adapter Information Protocol should have a provision for IHV to return no data. This patch series update GetInformation() API

Re: [edk2-devel] OVMF SMM Support

2024-04-08 Thread Gerd Hoffmann
On Mon, Apr 08, 2024 at 08:33:30AM +, Wu, Jiaxin wrote: > Hi Gerd, > > With below OVMF build and QEMU command, OVMF hangs after SendSmiIpi > (mBspApicId) during SmmRelocateBases(), is there any issues with > latest code to support SMM on OVMF or my local command/configuration > issue? Have

[edk2-devel] [PATCH] MdePkg: Update the comments of GetInformation function

2024-04-08 Thread Qingyu
Refer to Uefi spec 2.10 section 11.11.2, add a new retval EFI_NOT_FOUND to EFI_ADAPTER_INFORMATION_PROTOCOL.GetInformation(). Reference: [mantis #1866] - GetInfo() of Adapter Information Protocol should have a provision for IHV to return no data. Cc: Liming Gao Cc: Michael D Kinney Cc: Zhiguang

[edk2-devel] OVMF SMM Support

2024-04-08 Thread Wu, Jiaxin
Hi Gerd, With below OVMF build and QEMU command, OVMF hangs after SendSmiIpi (mBspApicId) during SmmRelocateBases(), is there any issues with latest code to support SMM on OVMF or my local command/configuration issue? Build (latest edk2 code): build -p OvmfPkg\OvmfPkgIa32X64.dsc -a IA32 -a X64

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg: OVMF supports USB mouses

2024-04-08 Thread Gerd Hoffmann
On Sat, Apr 06, 2024 at 02:41:54PM +0200, Heinrich Schuchardt wrote: > From: Phillip Tennen > > From: Phillip Tennen > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4747 > > UsbMouseDxe was missing from the OVMF build description, so=20 > the Simple Pointer Protocol wasn't usable from