Share the PR here: https://github.com/tianocore/edk2/pull/5546
From: Ni, Ray
Sent: Thursday, April 11, 2024 11:15 AM
To: Wu, Jiaxin ; devel@edk2.groups.io
Cc: Zeng, Star ; Gerd Hoffmann ; Kumar,
Rahul R ; Dong, Guo ; Rhodes, Sean
; Lu, James ; Guo, Gua
; Ard Biesheuvel ; Yao, Jiewen
I think the commit message can have more details to help OVMF developers
understand the needs of this patch.
E.g.:
Before using SmmRelocationLib, the PiSmmCpuDxeSmm driver allocates the SMRAM
to be used for SMI handler + save state area of each processor from
Smst->AllocatePages().
With
Please change the DSC in the earlier patch that adds the lib instance and avoid
this patch.
Thanks,
Ray
From: Wu, Jiaxin
Sent: Wednesday, April 10, 2024 21:57
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R
Subject: [PATCH
No. Please do not create a OVMF specific lib instance in UefiCpuPkg.
Thanks,
Ray
From: Wu, Jiaxin
Sent: Wednesday, April 10, 2024 21:57
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Ard
Biesheuvel ; Yao, Jiewen ;
Gerd Hoffmann ; Kumar, Rahul R
Subject:
Not sure if "--find-copies-harder" helps to detect that the new files are
copies of existing files.
Can you try in next version if some comments request a new version of patch?
Thanks,
Ray
From: Wu, Jiaxin
Sent: Wednesday, April 10, 2024 21:57
To:
Jiaxin, can you kindly share a PR in GitHub so that it will be easier to review?
Thanks,
Ray
From: Wu, Jiaxin
Sent: Wednesday, April 10, 2024 21:57
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R ; Dong, Guo
; Rhodes, Sean ;
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4735
Should not call HiiGetBrowserData() and HiiSetBrowserData() in FORM_OPEN
call back function.
Those APIs are called within OpalHiiSetBrowserData/OpalHiiGetBrowserData
which have been used by OpalHii.c.
1. Change callback action from
[AMD Official Use Only - General]
Hi maintainers,
Please help to check this update as we added an entry for Bus\Spi under
MdeModulePkg.
Thanks
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Sunday, August 13, 2023 12:37 PM
>
Hi Dionna/Qinkun
I am not sure if systemd is the last software in guest we need to patch to
support coexistence to extend the measurement.
Are you aware of any other Linux guest software needs to be updated? Such as
Linux IMA (Integrity Measurement Architecture)?
To move this forward.
In
Reviewed-by: Zachary Clark-Williams
-Original Message-
From: Tan, Ming
Sent: Thursday, March 21, 2024 6:16 PM
To: devel@edk2.groups.io
Cc: Kasbekar, Saloni ; Clark-williams, Zachary
; Bi, Dandan ; POLUDOV,
FELIX ; Liu, Liqi
Subject: [PATCH] NetworkPkg/WifiConnectionManagerDxe:
Sure, Jiewen, Yes, I have tested on OVMF:
1) Checked the OVMF can normal boot with SMM enabled.
2) Checked the multiple processor support on OVMF with -smp 4 command.
3) Test the OVMF can response soft SMI, the smbase has been rebased before smm
cpu driver dispatch.
4) Pass SMM test on intel
Hello
Would you please describe what test has been done for OvmfPkg?
For example, have you validated OVMF with SMM enabled?
> -Original Message-
> From: Wu, Jiaxin
> Sent: Wednesday, April 10, 2024 9:57 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Zeng, Star ; Gerd
> Hoffmann ; Kumar,
Reviewed-by: Gua Guo
From: Wu, Jiaxin
Sent: Wednesday, April 10, 2024 9:57:17 PM
To: devel@edk2.groups.io
Cc: Dong, Guo ; Rhodes, Sean ; Lu,
James ; Guo, Gua ; Ni, Ray
Subject: [PATCH v1 06/13] UefiPayloadPkg/UefiPayloadPkg.dsc: Include
SmmRelocationLib
This patch is to remove legacy SmBase relocation in
PiSmmCpuDxeSmm Driver, and the SmBase relocation
behavior will be in the SmmRelocationInit interface:
1. Relocate smbases for each processor.
2. Create the gSmmBaseHobGuid HOB.
Then, PiSmmCpuDxeSmm driver can be simplified to:
1. Consume the
This patch is to consume SmmRelocationInit for SmBase
Relocation.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Ray Ni
Signed-off-by: Jiaxin Wu
---
OvmfPkg/PlatformPei/Platform.c | 1 +
OvmfPkg/PlatformPei/Platform.h | 5 +++
OvmfPkg/PlatformPei/PlatformPei.inf | 5
Based on gSmmBaseHobGuid:
If gSmmBaseHobGuid found, means SmBase info has been relocated
and recorded in the SmBase array.
So, this patch check smbase relocation is done or not in
SmmCpuFeaturesInitializeProcessor().
With SmmRelocationLib, gSmmBaseHobGuid will be always created.
Here this patch
This patch refines the SmmAccess implementation:
1. SmramMap will be retrieved from the
gEfiSmmSmramMemoryGuid instead of original from
the TSEG Memory Base register.
2. Remove the gEfiAcpiVariableGuid creation, thus
the DESCRIPTOR_INDEX definition can be also cleaned.
The gEfiAcpiVariableGuid HOB
This patch is for OVMF to create the gEfiAcpiVariableGuid
since it has been removed from the SmmAccess driver.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Ray Ni
Signed-off-by: Jiaxin Wu
---
OvmfPkg/Library/PlatformInitLib/MemDetect.c | 9 +
SmmRelocationLib instance will reserve the memory from
gEfiSmmSmramMemoryGuid for the smbase relocation.
So, system must produce the gEfiSmmSmramMemoryGuid.
This patch is for the OVMF to produce the
gEfiSmmSmramMemoryGuid HOB.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Ray Ni
This patch just includes SmmRelocationLib in OvmfPkg.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Ray Ni
Signed-off-by: Jiaxin Wu
---
OvmfPkg/AmdSev/AmdSevX64.dsc | 1 +
OvmfPkg/CloudHv/CloudHvX64.dsc | 1 +
OvmfPkg/Microvm/MicrovmX64.dsc | 1 +
OvmfPkg/OvmfPkgIa32.dsc
This patch just includes SmmRelocationLib in UefiPayloadPkg.
Cc: Guo Dong
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Cc: Ray Ni
Signed-off-by: Jiaxin Wu
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
This patch just includes SmmRelocationLib in UefiCpuPkg.
Cc: Ray Ni
Cc: Zeng Star
Cc: Gerd Hoffmann
Cc: Rahul Kumar
Signed-off-by: Jiaxin Wu
---
UefiCpuPkg/UefiCpuPkg.dsc | 3 +++
1 file changed, 3 insertions(+)
diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc
index
This patch separates the smbase relocation logic from
PiSmmCpuDxeSmm driver, and moves to the
SmmRelocationInit interface.
Platform shall consume the interface for the smbase
relocation if need SMM support.
Cc: Ray Ni
Cc: Zeng Star
Cc: Gerd Hoffmann
Cc: Rahul Kumar
Signed-off-by: Jiaxin Wu
Due to the definition difference of SMRAM Save State,
SmmBase config in SMRAM Save State for AMD is also different.
This patch provides the AmdSmmRelocationLib library instance
to handle the SMRAM Save State difference.
Cc: Abdul Lateef Attar
Cc: Abner Chang
Cc: Ray Ni
Cc: Zeng Star
Cc: Gerd
Due to the definition difference of SMRAM Save State,
SmmBase config in SMRAM Save State for OVMF is also different.
This patch provides the OvmfSmmRelocationLib library instance
to handle the SMRAM Save State difference.
Cc: Ray Ni
Cc: Zeng Star
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd
Intel plans to separate the smbase relocation logic from
PiSmmCpuDxeSmm driver, and the related behavior will be
moved to the new interface defined by the SmmRelocationLib
class.
The SmmRelocationLib class provides the SmmRelocationInit()
interface for platform to do the smbase relocation, which
Intel plans to separate the smbase relocation logic from
PiSmmCpuDxeSmm driver, and the related behavior will be
moved to the new interface defined by the SmmRelocationLib
class.
The SmmRelocationLib class provides the SmmRelocationInit()
interface for platform to do the smbase relocation, which
Hi Yi,
I Removed 'Reviewed-by: @yi1...@intel.com' and Sent V2 patch to
devel@edk2.groups.io.
Thanks,
Sountharya
-Original Message-
From: Li, Yi1
Sent: Tuesday, April 2, 2024 6:42 AM
To: Sountharya N ; devel@edk2.groups.io
Cc: Srinivasan Mani ; Prarthana Sagar V
; Yao, Jiewen ; Hou,
---
CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c
b/CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c
index 1182323b63..021cc328f8 100644
---
Looks good to me.
Reviewed-by: Krzysztof Lewandowski
From: Cai, Xianglei
Sent: Wednesday, April 10, 2024 09:01
To: devel@edk2.groups.io
Cc: Cai, Xianglei ; Ni, Ray ; Liming
Gao ; Lewandowski, Krzysztof
; Huang, Jenny ; Shih,
More ; Chiu, Ian
Subject: [PATCH
On Tue, Apr 09, 2024 at 04:51:20PM +0100, Pedro Falcato wrote:
> On Tue, Apr 9, 2024 at 12:56 PM Gerd Hoffmann wrote:
> >
> > On Mon, Apr 08, 2024 at 08:53:10AM +0100, Phillip Tennen wrote:
> > > Hi, thank you for taking a look at the patch!
> > >
> > > This patch can be verified to be working
Reviewed-by: S, Ashraf Ali
mailto:ashraf.al...@intel.com>>
Thanks.,
S, Ashraf Ali
From: Ni, Ray
Sent: Wednesday, April 10, 2024 1:27 PM
To: Liu, Zhiguang ; devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Duggapu, Chinni B
; Zeng, Star ; Kuo, Ted
; S, Ashraf Ali ; Susovan
[AMD Official Use Only - General]
Ok, then you can just merge this patch set.
thanks
Abner
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, April 10, 2024 4:17 PM
> To: devel@edk2.groups.io; Chang, Abner
> Cc: Igor Kulchytskyy ; Nick Ramirez
> Subject: RE: [edk2-devel]
Thanks for your review, Abner!
The reason why I keep HPE copyright statement is because I create this feature
driver by copying existing one and modifying it. Since I still leverage some
functions contributed by HPE, I think I am supposed to keep HPE copyright
statement.
Regards,
Nickle
>
Reviewed-by: Ray Ni
Thanks,
Ray
From: devel@edk2.groups.io on behalf of Zhiguang Liu
Sent: Wednesday, April 10, 2024 15:49
To: devel@edk2.groups.io
Cc: Liu, Zhiguang
Subject: [edk2-devel] [PATCH v3 0/6] Support to unregister SMI handler in SMI
handlers
Reviewed-by: Ray Ni
Thanks,
Ray
From: Liu, Zhiguang
Sent: Wednesday, April 10, 2024 15:08
To: devel@edk2.groups.io
Cc: Liu, Zhiguang ; Chiu, Chasel
; Desimone, Nathaniel L
; Duggapu, Chinni B
; Zeng, Star ; Kuo, Ted
; S, Ashraf Ali ; Susovan Mohapatra
;
Unregistering MMI handler will free the MMI_HANDLER. However, the
MmiManage() may be using the link node from MMI_HANDLER for loop if
the unregistering happens in MMI handlers.
To avoid that, the idea is to inform MmiHandlerUnRegister() whether
it's running or not running on the stack of
Unregistering SMI handler will free the SMI_HANDLER. However, the
SmiManage() may be using the link node from SMI_HANDLER for loop if
the unregistering happens in SMI handlers.
To avoid that, the idea is to inform SmiHandlerUnRegister() whether
it's running or not running on the stack of
This reverts "MdeModulePkg/SMM: Support to unregister
SMI handler inside SMI handler" for better design later.
Cc: Liming Gao
Cc: Jiaxin Wu
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Signed-off-by: Zhiguang Liu
---
This reverts commit "MdeModulePkg/SMM: Disallow unregister
SMI handler in other SMI handler" for better design later.
Cc: Liming Gao
Cc: Jiaxin Wu
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Signed-off-by: Zhiguang Liu
---
This reverts commit "StandaloneMmPkg: Support to unregister
MMI handler inside MMI handler" for better design later.
Cc: Liming Gao
Cc: Jiaxin Wu
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Signed-off-by: Zhiguang Liu
---
This reverts commit "StandaloneMmPkg: Disallow unregister MMI
handler in other MMI handler" for better design later.
Cc: Liming Gao
Cc: Jiaxin Wu
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Signed-off-by: Zhiguang Liu
---
Months ago, I sent patch set to fix potential issues in the usage of SMI
handler unregistering SMI handler. Discussion can be found in below
link:
https://edk2.groups.io/g/devel/topic/103925794#114251
The conclusion was to only support SMI handler unregistering itself, and not
allow SMI
Note this plugin only applies to 64-bit PSP
This optional plugin is designed to execute before the FSP SecCore to
rebase SecCore and PeiCore during runtime. If the FSP binary requires
rebasing at runtime, this module should be included within the FSP
binary. Additionally, specific patches must be
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4746
The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr APIs
supported in edk2 module. These extension APIs makes it possible
to read / write MSRs from specific processors and fills an existing gap
in this area.
Cc: Rebecca
This patch adds 2 new functions to read and write msrs from specific CPUs.
rdmsr_ex and wrmsr_ex are the 2 new functions added into edk2module to
provide the read and write of CPU specific MSRs.
Jayaprakash N (1):
edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific
msrs
Reviewed-by : Jayaprakash N
-Original Message-
From: devel@edk2.groups.io On Behalf Of Jayaprakash, N
Sent: Thursday, April 4, 2024 3:14 PM
To: devel@edk2.groups.io
Cc: Jayaprakash, N ; Rebecca Cran ;
Kinney, Michael D
Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: wrmsr
47 matches
Mail list logo
