Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

Hi Edhay, Okay, I will retest using the rc2 today and expect to upload the logs tonight or next Monday under edk2-test-rc2-202405. Thanks, Chao On 2024/5/10 22:56, G Edhaya Chandran wrote: Hi Chao, Yes, it is best to test based on the new tag at-least on one environment. Note: The

Re: [edk2-devel] [PATCH v2 07/13] SecurityPkg: RngDxe: Remove incorrect limitation on GetRng

Thanks to confirm that. I am OK on what you have said. Since the ARM part is added by Pierre Gondois pierre.gond...@arm.com, I will let him comment if there is any concern on the change for ARM. Thank you Yao, Jiewen From: Doug Flick via groups.io Sent:

Re: [edk2-devel] [PATCH v2 07/13] SecurityPkg: RngDxe: Remove incorrect limitation on GetRng

So, I'm trying to consult with some RNG experts because I'm by no means an expert and anything I say should be taken with huge grain of salt. When I get the experts take, I'll share it. Basically, the way I read this code is that it by no means tries to enforce any entropy requirement outside

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

On 5/3/24 12:38, Pedro Falcato wrote: On Thu, May 2, 2024 at 7:17 PM Kinney, Michael D wrote: -Original Message- From: r...@edk2.groups.io On Behalf Of Pedro Falcato Sent: Thursday, May 2, 2024 10:51 AM To: devel@edk2.groups.io; Kinney, Michael D Cc: r...@edk2.groups.io; Leif

Re: [edk2-devel] [edk2-platforms] [PATCH v1 2/2] AlderlakeOpenBoardPkg: Include MpInfo2HobPei

Reviewed-by: Sai Chaganty -Original Message- From: Desimone, Nathaniel L Sent: Wednesday, May 08, 2024 5:09 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chuang, Rosen ; Kasbekar, Saloni ; Chiu, Chasel ; Liming Gao ; Dong, Eric Subject: [edk2-platforms] [PATCH v1 2/2]

Re: [edk2-devel] 回复: [edk2-devel] [PATCH v2 03/13] OvmfPkg:PlatformCI: Support virtio-rng-pci

At a high level, this isn't my project and I would look towards the maintainers to provide guidance about the direction they want to go. However, In my opinion, this is a debate on Security vs Compatibility. I'm biased more towards security, and I've tried to make it easy for a platform to

回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

Stewards: Now, there are several patches to catch this table tag. Could you give the comments for them? 1. Adding support for verbose UEFI Table dumping to Dmem.c (https://edk2.groups.io/g/devel/message/118582) [Liming] This patch set has been reviewed before soft feature freeze. It

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver in early DXE

Sorry, I did not provide full picture. After this discussion on devel I've linked, I spoke to Michael what changes would be in compliance with EDK2 driver model guidelines. An agreement was reached: Root Bridge driver that implements SIO Protocol and Serial I/O driver (with new entrypoint) that

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

Hi Chao, Yes, it is best to test based on the new tag at-least on one environment. Note: The difference between old and new tag is mainly resolving build related issues. There is no change in test coverage. With WarM Regards, Edhay From: Chao Li Sent: Thursday, May 9, 2024 9:56 PM To:

[edk2-devel] [PATCH v2 1/1] MdeModulePkg: Warn if out of space when writing variables

Emit a DEBUG_ERROR message if there is not enough flash variable left to write/update a variable. This condition is currently not logged appropriately in all cases, given that full variable store can easily render the system unbootable. This new message helps identifying this condition. Cc:

[edk2-devel] [PATCH v2 0/1] MdeModulePkg: Warn if out of space when writing variables

Emit a DEBUG_ERROR message if there is not enough space left to write/update a variable. This condition is currently not logged appropriately in all cases, given that full variable store can easily render the system unbootable. This new message helps identifying this condition quickly.

[edk2-devel] [PATCH v1 4/4] ShellPkg/Acpiview: Add EINJ Parser

Add a new parser for the Error Injection Table (EINJ). The EINJ table provides machinism through which OSPM can inject hardware errors to the platform without requiring platform specific OSPM software. Cc: Zhiguang Liu Cc: Dandan Bi Cc: Liming Gao Cc: Zhichao Gao Cc: Sami Mujawar Cc: Pierre

[edk2-devel] [PATCH v1 3/4] MdePkg/Include/IndustryStandard: Update EINJ information according to ACPI 6.5

ACPI 6.5 specification updates EINJ revision to 0x02 and adds new Error Injection Actions - EINJV2_SET_ERROR_TYPE - EINJV2_GET_ERROR_TYPE This patches updates EINJ information based on ACPI 6.5 specification. Also, add missing Error Injection Actions too. Cc: Zhiguang Liu Cc: Dandan Bi

[edk2-devel] [PATCH v1 2/4] MdePkg/Include/IndustryStandard: Update GET_EXECUTE_OPERATION_TIMINGS Error Injection Actions

GET_EXECUTE_OPERATION_TIMINGS Error Injection Actions was added from ACPI 6.1 specification. Update Error Injection Action with the ACPI spec. Cc: Zhiguang Liu Cc: Dandan Bi Cc: Liming Gao Cc: Zhichao Gao Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: levi.yun ---

[edk2-devel] [PATCH v1 1/4] MdePkg/Include/IndustryStandard: Update SET_ERROR_TYPE_WITH_ADDRESS Error Injection Actions

SET_ERROR_TYPE_WITH_ADDRESS Error Injection Actions was added from ACPI 5.1 specification. Update Error Injection Action with the ACPI spec. Cc: Zhiguang Liu Cc: Dandan Bi Cc: Liming Gao Cc: Zhichao Gao Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: levi.yun ---

[edk2-devel] [PATCH v1 0/4] Add EINJ table parser.

Add Error Injection Table (EINJ) parser for AcpiView and add some missing Error Injection Action definitions in each Acpi* headers. The changes can be seen at: https://github.com/LeviYeoReum/edk2/tree/levi/3075_einj_table_v1 levi.yun (4): MdePkg/Include/IndustryStandard: Update

[edk2-devel] [PATCH] NetworkPkg:HttpDxe:CoverityIssues

Resolved Coverity Issues in Http Dxe 1.HttpResponseWorker(DEADCODE) The result of pointer arithmetic "HttpHeaders + AsciiStrLen("HTTP/1.1") + 1" is never null. 2.HttpDns4 (DEAD LOOP) Coverity reports dead loop error since IsDone is always false ,In Some scenario it might not update the to true

[edk2-devel] [PATCH] NetworkPkg:HttpDxe:CoverityIssues

Resolved Coverity Issues in Http Dxe 1.HttpResponseWorker(DEADCODE) The result of pointer arithmetic "HttpHeaders + AsciiStrLen("HTTP/1.1") + 1" is never null. 2.HttpDns4 (DEAD LOOP) Coverity reports dead loop error since IsDone is always false ,In Some scenario it might not update the to true

Re: [edk2-devel] [PATCH v2 07/13] SecurityPkg: RngDxe: Remove incorrect limitation on GetRng

Hi Doug First, I agree with you that "A caller is free to request less than 256 bit". Second, I think we still need to meet 256 bit entropy requirement in UEFI spec, right? With above assumption, I checked how the callee is implemented when input length is small.

[edk2-devel] [PATCH 18/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE

This MpService2Ppi field in SMM_S3_RESUME_STATE is used to wakeup AP to do the CPU initialization during smm s3 boot when the execution mode of PEI and DXE are the same. Currently, in CpuS3.c of smm cpu driver, BSP doesn't need to wakeup AP anymore. The initialization for AP will be done in

[edk2-devel] [PATCH 17/18] UefiCpuPkg: Remove GetAcpiCpuData() in CpuS3.c

Remove GetAcpiCpuData() in CpuS3.c. The mAcpiCpuData is not needed in S3 boot anymore. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Jiaxin Wu --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 243

[edk2-devel] [PATCH 14/18] UefiCpuPkg: Remove code to set register table

Remove code to set register table in CpuS3.c. In previous commit, PcdCpuFeaturesInitOnS3Resume has been set to TRUE. So that CpuFeaturesPei PEIM will initialize the CPU registers and perform CPU features initialization. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc:

[edk2-devel] [PATCH 16/18] UefiCpuPkg:Remove code to wakeup AP and relocate ap

After the code to load mtrr setting, set register table, handle APIC setting and Interrupt after INIT-SIPI-SIPI is moved, the InitializeCpuProcedure() only contains following code logic: 1.Bsp runs ExecuteFirstSmiInit(). 2.Bsp transfers AP to safe hlt-loop During S3 boot, since APs will be

[edk2-devel] [PATCH 13/18] UefiCpuPkg:Set PcdCpuFeaturesInitOnS3Resume to TRUE

Set PcdCpuFeaturesInitOnS3Resume to TRUE. So that CpuFeaturesPei PEIM will initialize the CPU registers and perform CPU features initialization. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Jiaxin Wu --- UefiCpuPkg/UefiCpuPkg.dec | 2 +- 1 file

[edk2-devel] [PATCH 15/18] UefiCpuPkg:Remove code to handle APIC setting and Interrupt

Remove ProgramVirtualWireMode()/DisableLvtInterrupts() since APs won't be waken by INIT-SIPI-SIPI in CpuS3.c any more. The two functions has been executed in MpInitLibInitialize() in PeiMplib. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Jiaxin Wu

[edk2-devel] [PATCH 12/18] UefiCpuPkg: Remove code to load mtrr setting

Remove code to load mtrr setting in CpuS3.c. In previous commits, before transferring to CpuS3.c, MTRR setting has been loaded in S3RestoreConfig2() for all CPU. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Jiaxin Wu ---

[edk2-devel] [PATCH 11/18] UefiCpuPkg: Disable PG in IA32 ApLoopCode

Disable paging in IA32 RelocateApLoop assembly code to fix the issue that the AP page table is unavailiable after boot OS under IA32 execution mode. This issue exist in IA32 PEI + IA32 DXE normal boot (also S3 boot with IA32 PEI after previous three commits are accepted). In current MpLib code,

[edk2-devel] [PATCH 10/18] UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib

In this commit, change PeiMpLib to install callback of gEdkiiEndOfS3ResumeGuid to relocate AP to new safe buffer. The gEdkiiEndOfS3ResumeGuid is installed in S3Resume.c before jmping to OS waking vector. Previously, code in CpuS3.c of PiSmmCpuDxe driver will prepare the new safe buffer for AP and

[edk2-devel] [PATCH 09/18] UefiCpuPkg:Move some code in DxeMpLib to common place

Move some code in DxeMpLib.C to common MpLib.c. The related code is to relocate Ap to new safe buffer before booting into OS. In next commits, these code also will be used by PeiMpLib. This commit doesn't change any code functionality. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Laszlo Ersek Cc:

[edk2-devel] [PATCH 08/18] UefiCpuPkg:Abstract some DxeMpLib code to function

Abstract some DxeMpLib code to function in this commit. Some of these internal functions will be moved to common MpLib.c in following commits. Then PeiMpLib can reuse the code. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Jiaxin Wu ---

[edk2-devel] [PATCH 07/18] UefiCpuPkg: Install gEdkiiEndOfS3ResumeGuid in S3Resume

Install gEdkiiEndOfS3ResumeGuid in S3Resume to trigger callback registered by PeiMpLib. The callback is to relocate Ap to new safe memory before jump to OS waking vector in S3 boot flow. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Jiaxin Wu ---

[edk2-devel] [PATCH 06/18] UefiCpuPkg: Remove the duplicated mpservice locate

Remove the duplicated mpservice locate in the code logic. Previously, when the execution combination of PEI and DXE are the same, the pointer of mpservice ppi will be passed to CpuS3.c in smm cpu driver to wakeup all APs, instead of init-sipi-sipi. Currently, CpuS3.c doesn't need to wakeup Aps

[edk2-devel] [PATCH 05/18] UefiCpuPkg: LoadMtrrData for all cpu in S3Resume

In this commit, S3Resume.c wakeup all Aps to run LoadMtrrData for all cpu before transfer to CpuS3.c in smm cpu driver. The MtrrSetting table can be restored by gEdkiiS3MtrrSettingGuid which is saved by lockbox in PEI phase. This can avoid waking up APs in CpuS3.c. Signed-off-by: Dun Tan Cc: Ray

[edk2-devel] [PATCH 04/18] UefiCpuPkg: Save MTRR by lockbox in CpuS3DataDxe

Save MTRR by lockbox in CpuS3DataDxe. In S3 boot, The MTRR setting will be restored in S3Resume.c in following patches. Then S3Resume.c will wakeup all APs to load the MTRR setting. This can avoid waking up APs in CpuS3.c. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann

[edk2-devel] [PATCH 03/18] UefiCpuPkg: Add locbox lib instance in DSC

Add locbox lib instance in DSC. The SmmLockBoxDxeLib will be consumed by CpuS3DataDxe driver Signed-off-by: Dun Tan Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Jiaxin Wu --- UefiCpuPkg/UefiCpuPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/UefiCpuPkg/UefiCpuPkg.dsc

[edk2-devel] [PATCH 02/18] OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe

Save MTRR by lockbox in CpuS3DataDxe. In S3 boot, The MTRR setting will be restored in S3Resume.c in following patches. Then S3Resume.c will wakeup all APs to load the MTRR setting. This can avoid waking up APs in CpuS3.c. Signed-off-by: Dun Tan Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Gerd

[edk2-devel] [PATCH 01/18] MdeModulePkg: Add gEdkiiS3MtrrSettingGuid

Add gEdkiiS3MtrrSettingGuid a new GUID for s3 MTRR setting. This GUID will be used to save MTRR_SETTINGS at EndOfDxe by LockBox and restore at S3 boot PEI phase for s3 usage. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Liming Gao Cc: Jiaxin Wu --- MdeModulePkg/MdeModulePkg.dec | 3 +++ 1 file

[edk2-devel] [PATCH 00/19] Remove some S3 related code in CpuS3.c of smm cpu driver

This patch set is to remove some S3 related code in CpuS3.c of smm cpu driver. It contain commits to: 1.Save MTRR setting by lockbox in PEI phase 2.Load MTRR in S3Resume.c before transferring to CpuS3.c in smm cpu driver. 3.Add callback of gEdkiiEndOfS3ResumeGuid in PeiMpLib to relocate Ap to

[edk2-devel] [PATCH] NetworkPkg:MnpDxe:CoverityIssues

Resolved INTEGER_OVERFLOW Coverity Issues in MNP Dxe 1.MnpStop,MnpInstanceDeliverPacket Expression "MnpDeviceData->ConfiguredChildrenNumber--" and Instance->RcvdPacketQueueSize-- where Both variables are known to be equal to 0, underflows the type that receives it. Cc: Saloni Kasbekar Cc:

[edk2-devel] [PATCH v2 0/1] MdeModulePkg: Warn if out of space when writing variables

Emit a DEBUG_ERROR message if there is not enough space left to write/update a variable. This condition is currently not logged appropriately in all cases, given that full variable store can easily render the system unbootable. This new message helps identifying this condition quickly.

[edk2-devel] [PATCH] NetworkPkg:SnpDxe:Fix Coverity Issues

Resolved Coverity Issues reported in SNP Dxe. 1.ComponentName.c (Overflow) Expression "OffSet--", which is equal to 18446744073709551615, where "OffSet" is known to be equal to 0, underflows the type that receives it. 2.SnpUndi32GetStatus,SnpUndi32Initialize,SnpUndi32Transmit (Deadcode) Execution