Re: [edk2-devel] [RESEND 0/7] AmdPlatformPkg: Adds board independent modules

2024-05-14 Thread Chang, Abner via groups.io
[AMD Official Use Only - AMD Internal Distribution Only] Already reviewed off-line. For this patch set, Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Wednesday, May 15, 2024 11:50 AM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ;

[edk2-devel] [RESEND 6/7] AmdPlatformPkg: Adds SecureBootDefaultKeysInit driver

2024-05-14 Thread Abdul Lateef Attar via groups.io
Adds SecureBootDefaultKeysInit driver to enroll secure boot default keys. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 12 + .../SecureBootDefaultKeysInit.c | 645 ++

[edk2-devel] [RESEND 7/7] AmdPlatformPkg: Adds ACPI common driver

2024-05-14 Thread Abdul Lateef Attar via groups.io
Adds ACPI common driver which generates. Generates CPU topology SSDT table. Generates PCIe topology SSDT table. Generates SPMI table. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 13 +-

[edk2-devel] [RESEND 5/7] AmdPlatformPkg: Adds AmdConfigRouting driver

2024-05-14 Thread Abdul Lateef Attar via groups.io
Adds AmdConfigRouting driver to improve HII performance. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc |1 + .../HiiConfigRouting/AmdConfigRouting.inf | 45 + .../HiiConfigRouting/AmdConfigRoutingEntry.c | 57 +

[edk2-devel] [RESEND 4/7] AmdPlatformPkg: Adds PlatformSocLib library class

2024-05-14 Thread Abdul Lateef Attar via groups.io
Adds PlatformSocLib library class. Implements null instance of PlatformSocLib. PlatformSocLib provides interface to the SoC specific functionality. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 7 +

[edk2-devel] [RESEND 3/7] AmdPlatformPkg: Implements SerialPortLib for simulator

2024-05-14 Thread Abdul Lateef Attar via groups.io
Implements SerialPortLib library class for simulator. It redirects the output to the port 80. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 3 +- .../SimulatorSerialPortLibPort80.c| 208 ++

[edk2-devel] [RESEND 1/7] AmdPlatformPkg: Adds LogoDxe driver

2024-05-14 Thread Abdul Lateef Attar via groups.io
Adds LogoDxe driver to display AMD logo. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 10 +- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 31 ++- .../Universal/LogoDxe/LogoDxe/JpegLogo.idf| 10 +

[edk2-devel] [RESEND 2/7] AmdPlatformPkg: Adds BaseAlwaysFalseDepexLib Library

2024-05-14 Thread Abdul Lateef Attar via groups.io
Adds BaseAlwaysFalseDepexLib Library which always adds DEPEX to FALSE. Using this library will prevent module/driver being dispatched. Usage: MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.inf {

[edk2-devel] [RESEND 0/7] AmdPlatformPkg: Adds board independent modules

2024-05-14 Thread Abdul Lateef Attar via groups.io
PR: https://github.com/tianocore/edk2-platforms/pull/141 Adds various libraries and drivers for AMD Platform. Cc: Abner Chang Cc: Paul Grimes Abdul Lateef Attar (7): AmdPlatformPkg: Adds LogoDxe driver AmdPlatformPkg: Adds BaseAlwaysFalseDepexLib Library AmdPlatformPkg: Implements

Re: [edk2-devel] [PATCH v8] MinPlatformPkg: Update HWSignature filed in FACS

2024-05-14 Thread VincentX Ke
Hi, Nate The patch has been merged on May 31, 2023 with patch v10. For details, please check below two links. Thanks. https://bugzilla.tianocore.org/show_bug.cgi?id=4428 https://github.com/tianocore/edk2-platforms/commit/1a7bd150d39007bfb72c4727feda3184c23efe96 Best Regards, Vincent

回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

2024-05-14 Thread gaoliming via groups.io
Mike: Thanks for your comments. I update the status below. Thanks Liming 发件人: Kinney, Michael D 发送时间: 2024年5月15日 0:35 收件人: gaoliming ; devel@edk2.groups.io; 'Andrew Fish' ; 'Leif Lindholm' 抄送: 'Ard Biesheuvel' ; sam.kay...@arm.com; dougfl...@microsoft.com; Mathews, John ; Hou,

回复: [edk2-devel] 回复: [edk2-devel][edk2-stable202405] [PATCH v2 00/13] NetworkPkg: CVE-2023-45236 and CVE-2023-45237

2024-05-14 Thread gaoliming via groups.io
Doug: Thanks for your clarification. For the changes in MdePkg and EmulatorPkg, I have no comments. Reviewed-by: Liming Gao Thanks Liming 发件人: Doug Flick via groups.io 发送时间: 2024年5月10日 2:26 收件人: gaoliming ; devel@edk2.groups.io 主题: Re: [edk2-devel] 回复: [edk2-devel][edk2-stable202405]

Re: [edk2-devel] [PATCH v1 1/1] BoardModulePkg: Added Mock library for BiosIdLib

2024-05-14 Thread Nate DeSimone
Hi Vivian, Please see feedback below inline. The # MU_CHANGE comment seems unnecessary. Thanks, Nate > -Original Message- > From: devel@edk2.groups.io On Behalf Of VivianNK > Sent: Wednesday, May 8, 2024 1:32 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Liming Gao > > Subject:

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Wednesday, May 15, 2024 #cal-reminder

2024-05-14 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Wednesday, May 15, 2024 5:30pm to 6:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH v8] MinPlatformPkg: Update HWSignature filed in FACS

2024-05-14 Thread Nate DeSimone
Hi Vincent, This patch has merge conflicts with the newest edk2-platforms. Is this change still needed? If yes, please rebase it to latest and re-send the patch. Thank You, Nate > -Original Message- > From: Ke, VincentX > Sent: Friday, May 19, 2023 3:29 AM > To: devel@edk2.groups.io >

Re: [edk2-devel] 回复: [edk2-devel] [PATCH v2 03/13] OvmfPkg:PlatformCI: Support virtio-rng-pci

2024-05-14 Thread Pedro Falcato
On Mon, May 13, 2024 at 10:23 AM Gerd Hoffmann via groups.io wrote: > > On Sat, May 11, 2024 at 10:40:23AM GMT, Ard Biesheuvel wrote: > > As I pointed out before, on the ARM side there are a few intersecting > > issues with these changes. (On x86, this is mostly avoided due to the > > fact that

Re: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

2024-05-14 Thread Michael D Kinney
Hi Liming, My responses below in [Mike]. Mike From: gaoliming Sent: Friday, May 10, 2024 8:29 AM To: devel@edk2.groups.io; Kinney, Michael D ; 'Andrew Fish' ; 'Leif Lindholm' Cc: 'Ard Biesheuvel' ; sam.kay...@arm.com; dougfl...@microsoft.com; Mathews, John ; Hou, Wenxing Subject: 回复:

Re: [edk2-devel][edk2-stable202405][PATCH] MdeModulePkg: Potential UINT32 overflow in S3 ResumeCount

2024-05-14 Thread Michael D Kinney
I agree it should catch edk2-stable202405 Mike > -Original Message- > From: gaoliming > Sent: Thursday, May 9, 2024 12:24 AM > To: devel@edk2.groups.io; Pakkirisamy, ShanmugavelX > > Cc: Liu, Zhiguang ; Bi, Dandan ; > 'Leif Lindholm' ; 'Andrew Fish' ; > Kinney, Michael D > Subject:

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

2024-05-14 Thread Nickle Wang via groups.io
Hi Abner, > Ok, then I don't have the problem with invoking GetAuthInfo again. However, I > will suggest to add more description in GetAuthInfo function header, mention > that > we will keep the auth info in EFI variable until exist boot service. > Also, give some more descriptions on the code

[edk2-devel] [edk2-redfish-client][PATCH v2] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

2024-05-14 Thread Nickle Wang via groups.io
-Introduce RedfishBootstrapAccountDxe to delete bootstrap account from /redfish/v1/AccountService/Accounts after BIOS finished all Redfish jobs. The bootstrap account won't be available to other application. So deleting bootstrap account helps to release resource at BMC. - After bootstrap account

[edk2-devel] [PATCH 6/6] AmdPlatformPkg: Adds SecureBootDefaultKeysInit driver

2024-05-14 Thread Abdul Lateef Attar via groups.io
Adds SecureBootDefaultKeysInit driver to enroll secure boot default keys. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 12 + .../SecureBootDefaultKeysInit.c | 645 ++

[edk2-devel] [PATCH 5/6] AmdPlatformPkg: Adds AmdConfigRouting driver

2024-05-14 Thread Abdul Lateef Attar via groups.io
Adds AmdConfigRouting driver to improve HII performance. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc |1 + .../HiiConfigRouting/AmdConfigRouting.inf | 45 + .../HiiConfigRouting/AmdConfigRoutingEntry.c | 57 +

[edk2-devel] [PATCH 4/6] AmdPlatformPkg: Adds PlatformSocLib library class

2024-05-14 Thread Abdul Lateef Attar via groups.io
Adds PlatformSocLib library class. Implements null instance of PlatformSocLib. PlatformSocLib provides interface to the SoC specific functionality. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 7 +

[edk2-devel] [PATCH 3/6] AmdPlatformPkg: Implements SerialPortLib for simulator

2024-05-14 Thread Abdul Lateef Attar via groups.io
Implements SerialPortLib library class for simulator. It redirects the output to the port 80. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 3 +- .../SimulatorSerialPortLibPort80.c| 208 ++

[edk2-devel] [PATCH 1/6] AmdPlatformPkg: Adds LogoDxe driver

2024-05-14 Thread Abdul Lateef Attar via groups.io
Adds LogoDxe driver to display AMD logo. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 10 +- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 31 ++- .../Universal/LogoDxe/LogoDxe/JpegLogo.idf| 10 +

[edk2-devel] [PATCH 2/6] AmdPlatformPkg: Adds BaseAlwaysFalseDepexLib Library

2024-05-14 Thread Abdul Lateef Attar via groups.io
Adds BaseAlwaysFalseDepexLib Library which always adds DEPEX to FALSE. Using this library will prevent module/driver being dispatched. Usage: MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.inf {

[edk2-devel] [PATCH 0/6] AmdPlatformPkg: Adds board independent modules

2024-05-14 Thread Abdul Lateef Attar via groups.io
PR: https://github.com/tianocore/edk2-platforms/pull/141 Adds various libraries and drivers for AMD Platform. Cc: Abner Chang Cc: Paul Grimes Abdul Lateef Attar (6): AmdPlatformPkg: Adds LogoDxe driver AmdPlatformPkg: Adds BaseAlwaysFalseDepexLib Library AmdPlatformPkg: Implements

Re: [edk2-devel] [PATCH 10/18] UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib

2024-05-14 Thread Gerd Hoffmann
On Tue, May 14, 2024 at 05:17:51AM GMT, Ni, Ray wrote: > Gerd, > I agree that the logic might be duplicated in multi places. > > But even CPU supports 1G paging, caller can decide whether to use 1G paging > or 2M paging, or 4K paging. > Using a single API to encapsulate the entire logic may not