Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Doug Flick via
> groups.io
> 发送时间: 2024年5月24日 13:45
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu
> 主题: [edk2-devel] [PATCH v3 16/20] MdePkg/BaseRngLib AARCH64: Remove
> overzealous ASSERT
Acked-by: Jiewe Yao
BTW: This patch is already got RB from below people. I suggest you can put them
in commit directly.
Reviewed-by: Pierre Gondois
Reviewed-by: Ard Biesheuvel
Thank you
Yao, Jiewen
> -Original Message-
> From: Flickdm
> Sent: Friday, May 24, 2024 1:45 PM
> To: deve
From: Ard Biesheuvel
Currently, only TPM2 builds enable the PCD PEIM, which is a prerequisite
for being able to use dynamic PCDs already at the PEI stage. This
facility will be used for other reasons too so move those pieces out of
code block that are conditional on TPM2_ENABLE
Cc: Ard Biesheuve
From: Ard Biesheuvel
On ARM systems, whether SMC or HVC instructions need to be used to issue
monitor calls is typically dependent on the exception level, but there
are also cases where EL1 might use SMC instructions, so there is no hard
and fast rule.
For ArmVirtQemu, this does depend strictly
From: Ard Biesheuvel
BaseRngLib on AARCH64 will discover whether or not RNDR instructions are
supported, by inspecting the ISAR0 identification register, and setting
a global boolean accordingly. This boolean is used in subsequent
execution to decide whether or not to issue the instruction.
The
This moves the PcdMonitorConduitHvc from PcdsFeatureFlag.Common to
PcdsFixedAtBuild.Common
This is a follow on to the previous commit:
ArmPkg: Allow SMC/HVC monitor conduit to be specified at runtime
ArmVirtQemu may execute at EL2, in which case monitor calls are
generally made using SMC instruct
From: Doug Flick
This commit adds a new MockHash2 protocol to the MdePkg. This allows
the unit tests to pick up the new protocol and use it for testing.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Doug Flick [MSFT]
---
MdePkg/Test/Mock/Include/GoogleTest/Protocol/Mo
From: Ard Biesheuvel
ArmVirtQemu may execute at EL2, in which case monitor calls are
generally made using SMC instructions instead of HVC instructions.
Whether or not this is the case can only be decided at runtime, and so
the associated PCD needs to be settable at runtime, if the platform
defin
From: Doug Flick
This patch updates the PxeBcDhcp6GoogleTest due to the changes in the
underlying code. The changes are as follows:
- Random now comes from the RngLib Protocol
- The TCP ISN is now generated by the hash function
Cc: Saloni Kasbekar
Cc: Zachary Clark-williams
Signed-off-by: D
From: Doug Flick
This commit adds a mock library for UefiBootServicesTableLib.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Doug Flick [MSFT]
---
MdePkg/Test/MdePkgHostTest.dsc
| 1 +
MdePkg/Test/M
From: Doug Flick
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4541
REF: https://www.rfc-editor.org/rfc/rfc1948.txt
REF: https://www.rfc-editor.org/rfc/rfc6528.txt
REF: https://www.rfc-editor.org/rfc/rfc9293.txt
Bug Overview:
PixieFail Bug #8
CVE-2023-45236
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:C
From: Doug Flick
This patch adds a protocol for MockRng. This protocol is used to
mock the Rng protocol for testing purposes.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Doug Flick [MSFT]
---
MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockRng.h | 48
+++
From: Doug Flick
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4542
Bug Overview:
PixieFail Bug #9
CVE-2023-45237
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:N/A:N
CWE-338 Use of Cryptographically Weak Pseudo-Random Number Generator (PRNG)
Use of a Weak PseudoRandom Number Generator
Change Ove
This patch adds "virtio-rng-pci" to the PlatformBuildLib.py
This adds Rng services to the guest VM
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Signed-off-by: Doug Flick [MSFT]
---
OvmfPkg/PlatformCI/PlatformBuildLib.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/OvmfPkg/Pla
Removed from gEfiRngAlgorithmRaw an incorrect assumption that
Raw cannot return less than 256 bits. The DRNG Algorithms
should always use a 256 bit seed as per nist standards
however a caller is free to request less than 256 bits.
>
> //
>// When a DRBG is used on the output of a entropy so
This patch adds "virtio-rng-pci" to the PlatformBuildLib.py
This adds Rng services to the guest VM
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Signed-off-by: Doug Flick [MSFT]
---
ArmVirtPkg/PlatformCI/PlatformBuildLib.py | 2 ++
1 file changed, 2 insertions(+)
This patch adds Hash2DxeCrypto to ArmVirtPkg. The Hash2DxeCrypto is
used to provide the hashing protocol services.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Signed-off-by: Doug Flick [MSFT]
---
ArmVirtPkg/ArmVirtQemu.dsc | 5 +
ArmVirtPkg/ArmVirtQ
From: Doug Flick
This patch adds Hash2DxeCrypto to OvmfPkg. The Hash2DxeCrypto is
used to provide the hashing protocol services.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Signed-off-by: Doug Flick [MSFT]
---
OvmfPkg/OvmfPkgIa32.dsc| 6 +-
OvmfPkg/OvmfPkgIa32X64.dsc | 6 ++
This patch adds RngDxe to EmulatorPkg. The RngDxe is used to provide
random number generation services to the UEFI firmware.
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Doug Flick [MSFT]
Reviewed-by: Ray Ni
---
EmulatorPkg/EmulatorPkg.dsc | 7 ++-
EmulatorPkg/EmulatorPkg.fdf | 6 +-
2
From: Doug Flick
This patch adds Hash2DxeCrypto to EmulatorPkg. The Hash2DxeCrypto is
used to provide the hashing protocol services.
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Doug Flick [MSFT]
---
EmulatorPkg/EmulatorPkg.dsc | 9 +++--
EmulatorPkg/EmulatorPkg.fdf | 5 +
2 files chan
REF:https://blog.quarkslab.com/pixiefail-nine-vulnerabilities-in-tianocores-edk-ii-ipv6-network-stack.html
This patch series patches the following CVEs:
- CVE-2023-45236: Predictable TCP Initial Sequence Numbers
- CVE-2023-45237: Use of a Weak PseudoRandom Number Generator
In order to patch the
From: Ard Biesheuvel
On ARM systems, whether SMC or HVC instructions need to be used to issue
monitor calls is typically dependent on the exception level, but there
are also cases where EL1 might use SMC instructions, so there is no hard
and fast rule.
For ArmVirtQemu, this does depend strictly
From: Ard Biesheuvel
Add the RngDxe driver to the build, backed by either RNDR or TRNG, one
of which is expected to be available in most cases:
- RNDR is implemented by the 'max' CPU that QEMU implements in TCG mode
- TRNG is implemented by the KVM hypervisor, which backs QEMU's 'host'
CPU
Oth
From: Ard Biesheuvel
MdeLibs.inc sets default library class resolutions which are much more
general than the ones that might be specified in ArmVirt.dsc.inc. So the
latter should be included *after* MdeLibs.inc to ensure that its
definitions take precedence.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
From: Doug Flick
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4542
Bug Overview:
PixieFail Bug #9
CVE-2023-45237
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:N/A:N
CWE-338 Use of Cryptographically Weak Pseudo-Random Number Generator (PRNG)
Use of a Weak PseudoRandom Number Generator
Change Ove
From: Ard Biesheuvel
Currently, only TPM2 builds enable the PCD PEIM, which is a prerequisite
for being able to use dynamic PCDs already at the PEI stage. This
facility will be used for other reasons too so move those pieces out of
code block that are conditional on TPM2_ENABLE
Cc: Ard Biesheuve
From: Ard Biesheuvel
BaseRngLib on AARCH64 will discover whether or not RNDR instructions are
supported, by inspecting the ISAR0 identification register, and setting
a global boolean accordingly. This boolean is used in subsequent
execution to decide whether or not to issue the instruction.
The
This moves the PcdMonitorConduitHvc from PcdsFeatureFlag.Common to
PcdsFixedAtBuild.Common
This is a follow on to the previous commit:
ArmPkg: Allow SMC/HVC monitor conduit to be specified at runtime
ArmVirtQemu may execute at EL2, in which case monitor calls are
generally made using SMC instruct
From: Doug Flick
This commit adds a new MockHash2 protocol to the MdePkg. This allows
the unit tests to pick up the new protocol and use it for testing.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Doug Flick [MSFT]
---
MdePkg/Test/Mock/Include/GoogleTest/Protocol/Mo
From: Doug Flick
This patch updates the PxeBcDhcp6GoogleTest due to the changes in the
underlying code. The changes are as follows:
- Random now comes from the RngLib Protocol
- The TCP ISN is now generated by the hash function
Cc: Saloni Kasbekar
Cc: Zachary Clark-williams
Signed-off-by: D
From: Ard Biesheuvel
ArmVirtQemu may execute at EL2, in which case monitor calls are
generally made using SMC instructions instead of HVC instructions.
Whether or not this is the case can only be decided at runtime, and so
the associated PCD needs to be settable at runtime, if the platform
defin
From: Doug Flick
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4541
REF: https://www.rfc-editor.org/rfc/rfc1948.txt
REF: https://www.rfc-editor.org/rfc/rfc6528.txt
REF: https://www.rfc-editor.org/rfc/rfc9293.txt
Bug Overview:
PixieFail Bug #8
CVE-2023-45236
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:C
From: Doug Flick
This patch adds a protocol for MockRng. This protocol is used to
mock the Rng protocol for testing purposes.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Doug Flick [MSFT]
---
MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockRng.h | 48
+++
From: Doug Flick
This commit adds a mock library for UefiBootServicesTableLib.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Doug Flick [MSFT]
---
MdePkg/Test/MdePkgHostTest.dsc
| 1 +
MdePkg/Test/M
This patch adds Hash2DxeCrypto to ArmVirtPkg. The Hash2DxeCrypto is
used to provide the hashing protocol services.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Signed-off-by: Doug Flick [MSFT]
---
ArmVirtPkg/ArmVirtQemu.dsc | 5 +
ArmVirtPkg/ArmVirtQ
Removed from gEfiRngAlgorithmRaw an incorrect assumption that
Raw cannot return less than 256 bits. The DRNG Algorithms
should always use a 256 bit seed as per nist standards
however a caller is free to request less than 256 bits.
>
> //
>// When a DRBG is used on the output of a entropy so
This patch adds "virtio-rng-pci" to the PlatformBuildLib.py
This adds Rng services to the guest VM
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Signed-off-by: Doug Flick [MSFT]
---
ArmVirtPkg/PlatformCI/PlatformBuildLib.py | 2 ++
1 file changed, 2 insertions(+)
From: Doug Flick
This patch adds Hash2DxeCrypto to OvmfPkg. The Hash2DxeCrypto is
used to provide the hashing protocol services.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Signed-off-by: Doug Flick [MSFT]
---
OvmfPkg/OvmfPkgIa32.dsc| 6 +-
OvmfPkg/OvmfPkgIa32X64.dsc | 6 ++
This patch adds "virtio-rng-pci" to the PlatformBuildLib.py
This adds Rng services to the guest VM
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Signed-off-by: Doug Flick [MSFT]
---
OvmfPkg/PlatformCI/PlatformBuildLib.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/OvmfPkg/Pla
This patch adds RngDxe to EmulatorPkg. The RngDxe is used to provide
random number generation services to the UEFI firmware.
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Doug Flick [MSFT]
Reviewed-by: Ray Ni
---
EmulatorPkg/EmulatorPkg.dsc | 7 ++-
EmulatorPkg/EmulatorPkg.fdf | 6 +-
2
REF:https://blog.quarkslab.com/pixiefail-nine-vulnerabilities-in-tianocores-edk-ii-ipv6-network-stack.html
This patch series patches the following CVEs:
- CVE-2023-45236: Predictable TCP Initial Sequence Numbers
- CVE-2023-45237: Use of a Weak PseudoRandom Number Generator
In order to patch thes
From: Doug Flick
This patch adds Hash2DxeCrypto to EmulatorPkg. The Hash2DxeCrypto is
used to provide the hashing protocol services.
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Doug Flick [MSFT]
---
EmulatorPkg/EmulatorPkg.dsc | 9 +++--
EmulatorPkg/EmulatorPkg.fdf | 5 +
2 files chan
Reviewed-by: Abdul Lateef Attar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119205): https://edk2.groups.io/g/devel/message/119205
Mute This Topic: https://groups.io/mt/106257080/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscri
Reviewed-by: Abdul Lateef Attar (
abdullateef.at...@amd.com )
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119204): https://edk2.groups.io/g/devel/message/119204
Mute This Topic: https://groups.io/mt/106257082/21656
Group Owner: devel
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Paul Grimes mailto:paul.gri...@amd.com>>
From: devel@edk2.groups.io on behalf of Abdul Lateef
Attar via groups.io
Sent: Thursday, May 23, 2024 7:00:03 PM
To: devel@edk2.groups.io ; michael.d.
[AMD Official Use Only - AMD Internal Distribution Only]
Thanks for the up-stream, Abner.
Looks good to me.
Reviewed-by: Paul Grimes
From: Yao, Ken
Sent: Thursday, May 23, 2024 1:30:48 AM
To: Zhai, MingXin (Duke) ; Chang, Abner
; devel@edk2.groups.io
Cc: Grim
Reviewed-by: Saloni Kasbekar
-Original Message-
From: Doug Flick
Sent: Wednesday, May 8, 2024 10:57 PM
To: devel@edk2.groups.io
Cc: Kasbekar, Saloni ; Clark-williams, Zachary
Subject: [PATCH v2 13/13] NetworkPkg: Update the PxeBcDhcp6GoogleTest due to
underlying changes
From: Doug F
No other concerns.
Reviewed-by: Saloni Kasbekar
From: gaoliming
Sent: Thursday, May 23, 2024 6:24 PM
To: devel@edk2.groups.io; dougfl...@microsoft.com; Kasbekar, Saloni
Subject: 回复: [edk2-devel] [PATCH v2 09/13] NetworkPkg: TcpDxe: SECURITY PATCH
CVE-2023-45236
Saloni:
Have you any other
Add FDT detection and comsume FDT when needed.
Move some x86 specific function in the x86 folder.
Create HandOffHob via FDT memory node.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayload
Add FDTParser and CustomFdtNodePaser
to retrive all FDT node and create the relate hobs.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
UefiPayloadPkg/Library/CustomFdtNodeParserLib/CustomFdtNodeParserLib.c
| 158 +
Uefi
Create FDT nodes (reserved-memory, serial, pci-rb, options) in
FdtPpiNotifyCallback function right after gEfiEndOfPeiSignalPpiGuid.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
UefiPayloadPkg/PayloadLoaderPeim/FitPayloadLoaderPeim.c
Initialize mUartInfo with PCD for debug message
when Hob was not available.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
UefiPayloadPkg/Library/BaseSerialPortLibHob/BaseSerialPortLibHob.c
| 69
UefiP
Add Library header, DeviceTree hob header and PCD definitions.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
UefiPayloadPkg/Include/Guid/UniversalPayloadBase.h | 2 +
UefiPayloadPkg/Include/Library/FdtParserLib.h| 64 ++
Disable some compiling warnings caused by submodule code.
Those can be removed later once issues fixed by submodule owner.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
MdePkg/Library/BaseFdtLib/BaseFdtLib.inf | 7 +--
1 file chang
To align with ecosystem common interface, the FDT support is added to Universal
Payload)
PR : https://github.com/tianocore/edk2/pull/5669
V2: Update typo [3/6] avalible ,[6/6] speciifc, HandOffhbo
V3: Update cover letter content.
*** BLURB HERE ***
Linus Liu (6):
MdePkg: Fix build error afte
Add FDT detection and comsume FDT when needed.
Move some x86 specific function in the x86 folder.
Create HandOffHob via FDT memory node.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayload
Add FDTParser and CustomFdtNodePaser
to retrive all FDT node and create the relate hobs.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
UefiPayloadPkg/Library/CustomFdtNodeParserLib/CustomFdtNodeParserLib.c
| 158 +
Uefi
Create FDT nodes (reserved-memory, serial, pci-rb, options) in
FdtPpiNotifyCallback function right after gEfiEndOfPeiSignalPpiGuid.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
UefiPayloadPkg/PayloadLoaderPeim/FitPayloadLoaderPeim.c
Initialize mUartInfo with PCD for debug message
when Hob was not available.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
UefiPayloadPkg/Library/BaseSerialPortLibHob/BaseSerialPortLibHob.c
| 69
UefiP
Add Library header, DeviceTree hob header and PCD definitions.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
UefiPayloadPkg/Include/Guid/UniversalPayloadBase.h | 2 +
UefiPayloadPkg/Include/Library/FdtParserLib.h| 64 ++
Disable some compiling warnings caused by submodule code.
Those can be removed later once issues fixed by submodule owner.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
MdePkg/Library/BaseFdtLib/BaseFdtLib.inf | 7 +--
1 file chang
*** BLURB HERE ***
Linus Liu (6):
MdePkg: Fix build error after enable FDT support.
UefiPayloadPkg: Addd header files for FDT structure and function.
UefiPayloadPkg: Support Debug function when Hob was not available.
UefiPayloadPkg: Update PayloadLoader to suport FDT.
UefiPayloadPkg: Add
Hi Liming,
Could you please help to review the following 2 patches in the patch series?
[Patch V2 01/18] MdeModulePkg: Add gEdkiiS3MtrrSettingGuid
[Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi field in
SMM_S3_RESUME_STATE
Thanks,
Dun
From: Ni, Ray
Sent:
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Tan, Dun
> Sent: Friday, May 17, 2024 5:45 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Kumar, Rahul R ;
> Gerd Hoffmann ; Wu, Jiaxin ;
> Zhou, Jianfeng
> Subject: [PATCH] UefiCpuPkg:fix issue when splitting paging entry
>
> This pat
Series Reviewed-by: Jiaxin Wu
The series patches are good to me now. Thanks Dun.
Thanks,
Jiaxin
> -Original Message-
> From: Tan, Dun
> Sent: Friday, May 17, 2024 5:46 PM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Wu, Jiaxin
> ; Ni, Ray ; Ard Biesheuvel
> ; Yao, Jiewen ; Gerd
> Hoff
Ning,
I missed one minor issue with your patch.
Can you check if the following GetBspNumber() call can be removed?
if (FirstMpHandOff == NULL) {
...
} else {
...
CpuMpData->CpuCount = MaxLogicalProcessorNumber;
CpuMpData->BspNumber = GetBspNumber (FirstMpHandOff);
CpuInfoInHob
Doug:
Have you any update for this patch set?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Gerd Hoffmann
> 发送时间: 2024年5月17日 17:48
> 收件人: devel@edk2.groups.io; a...@kernel.org
> 抄送: Doug Flick ; Jiewen Yao
> ; Liming Gao (Byosoft address)
>
> 主题: Re: [edk2-devel] 回复: [edk2-deve
Add FDT detection and comsume FDT when needed.
Move some x86 speciifc function in the x86 folder.
Create HandOffHbo via FDT memory node.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayload
Hello
Thanks for Michael Kubacki's effort. The cmocka for libspdm is switched to
https://gitlab.com/cmocka/cmocka.git
(https://github.com/DMTF/libspdm/pull/2710).
The next libspdm release is planned at the end of June.
Please let us know if the preference for libspdm submodule. (Below options)
Add FDT detection and comsume FDT when needed.
Move some x86 speciifc function in the x86 folder.
Create HandOffHbo via FDT memory node.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayload
Add FDTParser and CustomFdtNodePaser
to retrive all FDT node and create the relate hobs.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
UefiPayloadPkg/Library/CustomFdtNodeParserLib/CustomFdtNodeParserLib.c
| 158 +
Uefi
Create FDT nodes (reserved-memory, serial, pci-rb, options) in
FdtPpiNotifyCallback function right after gEfiEndOfPeiSignalPpiGuid.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
UefiPayloadPkg/PayloadLoaderPeim/FitPayloadLoaderPeim.c
Initialize mUartInfo with PCD for debug message
when Hob was not avalible.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
UefiPayloadPkg/Library/BaseSerialPortLibHob/BaseSerialPortLibHob.c
| 69
UefiPa
Add Library header, DeviceTree hob header and PCD definitions.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
UefiPayloadPkg/Include/Guid/UniversalPayloadBase.h | 2 +
UefiPayloadPkg/Include/Library/FdtParserLib.h| 64 ++
Disable some compiling warnings caused by submodule code.
Those can be removed later once issues fixed by submodule owner.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Cc: Dhaval Sharma
Signed-off-by: Linus Liu
---
MdePkg/Library/BaseFdtLib/BaseFdtLib.inf | 7 +--
1 file chang
Reviewed-by: Abdul Lateef Attar
On 23-05-2024 21:57, Michael D Kinney via groups.io wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Reviewed-by: Michael D Kinney
-Original Message-
From:abn
hi, ray looks like after only changed the title, there created another groups,
please check below link. thanks
[PATCH] Pkg-Module:UefiCpuPkg/MpLib:Do not assume BSP is #0 (groups.io) (
https://edk2.groups.io/g/devel/message/119161 )
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messa
Saloni:
Have you any other comments for this patch?
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Doug Flick via groups.io
发送时间: 2024年5月22日 3:29
收件人: Saloni Kasbekar ; devel@edk2.groups.io
主题: Re: [edk2-devel] [PATCH v2 09/13] NetworkPkg: TcpDxe: SECURITY PATCH
CVE-2023-45236
This was m
On 5/23/2024 2:17 AM, Du Lin wrote:
Thanks for the quick response.
Agree that the PI and UEFI specs are vague on SP. That is also why I opted to
minimize code changes to DXE core for SP support in patch
https://edk2.groups.io/g/devel/message/118712.
Would it make more sense to let the caller
Hi Michael,
These updates look good.
Can you provide a brief overview/summary of the process changes
in email to make sure there are no misunderstandings from the
details in the wiki page updates.
Thanks,
Mike
> -Original Message-
> From: Michael Kubacki
> Sent: Monday, May 20, 2024
Reviewed-by: Michael D Kinney
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Wednesday, May 22, 2024 9:12 PM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm ; Kinney, Michael D
>
> Subject: [edk2-platforms][PATCH 3/3] edk2-platform/Maintainer: Add entries
> for AMD packages
>
Hi Sahil,
I cannot apply your patches cleanly. Can you share a github branch with your
patches, please?
Regards,
Sami Mujawar
On 23/05/2024, 11:56, "Sahil Kaushal" mailto:sahil.kaus...@arm.com>> wrote:
From: sahil mailto:sa...@arm.com>>
Moving these functions from NorFlash.c to NorFlashBl
Hi Sahil,
Thank you for this patch.
I have a minor suggession marked inline as [SAMI].
Otherwise this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/05/2024 11:55 am, Sahil Kaushal wrote:
From: sahil
This patch adds error_handler1 and error_handler2 labels
[AMD Official Use Only - AMD Internal Distribution Only]
[AMD Official Use Only - AMD Internal Distribution Only]
Thanks Abner for the up-stream.
Looks good to me.
Reviewed-by: Ken Yao
-Original Message-
From: Zhai, MingXin (Duke)
Sent: Thursday, May 23, 2024 3:47 PM
To: Chang, Abner
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4778
MPInitlib have wrong expectation that BSP index should always be 0 in
MpInitLibInitialize(), SwitchBsp(),ApWakeupFunction().
That will cause the data mismatch, if the initial BSP is not 0.
Cc: Ray Ni
Signed-off-by: Ning Feng
---
UefiCpuPkg/
Ning,
The patch looks good to me.
But it seems you did not change the patch title to a more specific message.
[Ray.1] The subject should be more specific. E.g.: UefiCpuPkg/MpInitLib: Do not
assume BSP is #0.
Thanks,
Ray
From: Feng, Ning
Sent: Friday, May 24,
From: sahil
This driver enables Fault Tolerant Write protocol, which provides
fault tolerant write capability for block devices.
Signed-off-by: sahil
---
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 5 +
Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 1 +
2 files changed, 6 insertions(+)
diff --git a/P
From: sahil
Enable persistent storage on QSPI flash device.
Signed-off-by: sahil
---
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 19 ++-
Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 2 ++
2 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
From: sahil
In N1Sdp platform, the SoC is connected to IOFPGA which has a
Cadence Quad SPI (QSPI) controller. This QSPI controller manages
the flash chip device via QSPI bus.
This patch adds CadenceQspiNorFlashDeviceLib which is used to
manage and access the above configuration.
Signed-off-by:
From: sahil
Add NOR flash library, this library provides APIs for getting the list
of NOR flash devices on the platform.
This flash is shared between AP core and System Control Processor. The
lower addresses are used to store SCP and AP boot images and higher
addresses will be used for variable
From: sahil
Enable SCP QSPI flash region access by adding it in the PlatformLibMem.
This flash is shared between AP core and System Control Processor. The
lower addresses are used to store SCP and AP boot images and higher
addresses will be used for variable storage.
Signed-off-by: sahil
---
S
From: sahil
This patch adds an optional functionality in NorFlashDxe to fetch and
print NOR Flash information from NorFlashInfoLib using its JEDEC ID.
NOR Flash libraries will implement a function "NorFlashReadID" which
will fetch and return JEDEC ID. This JEDEC ID can be then printed
along with
From: sahil
This patch adds error_handler1 and error_handler2 labels in
NorFlashCreateInstance() function to handle the cleanup.
error_handler1: Frees just the Instance structure as the
ShadowBuffer is not allocated yet.
error_handler2: Frees both Instance and Instance->ShadowBuffer.
Signed-of
From: sahil
This variable holds the QSPI controller's base address.
It is defined in ARM.dec as well with the default value of 0x0.
In case a platform is not using it, they can just ignore this
variable and the default value of 0x0 will be propogated and
the variable will not be used.
Signed-off
From: sahil
NorFlashDeviceLib can be used to provide implementations of different
NOR Flash to NorFlashDxe, i.e. NorFlashDxe links with NorFlashDeviceLib
and the platforms can specify their respective NorFlashDeviceLib
instances.
This patch adds the following major changes:
1. Adds changes in N
From: sahil
This patch implements functions to interact with P30 NOR Flash.
The code is taken from Platform/ARM/Drivers/NorFlashDxe/NorFlash.c
file.
Signed-off-by: sahil
---
Platform/ARM/Library/P30NorFlashDeviceLib/P30NorFlashDeviceLib.inf | 35 +
Platform/ARM/Library/P30NorFlashDeviceLib/P3
From: sahil
NorFlashDeviceLib can be used to provide implementations of different
NOR Flash to NorFlashDxe, i.e. NorFlashDxe links with NorFlashDeviceLib
and the platforms can specify their respective NorFlashDeviceLib
instances.
This patch splits NorFlash.h and moves out the function prototypes
From: sahil
This patch makes local functions not being used outside
NorFlash.c STATIC.
Also, NorFlashWriteBuffer() is specific to a particular
flash implementation and need not be implemented by
other NOR flash device IPs.
Signed-off-by: sahil
---
Platform/ARM/Drivers/NorFlashDxe/NorFlash.h |
From: sahil
This patch removes NorFlashReadCfiData() and NorFlashWrite()
prototypes from NorFlash.h as these are not implemented or
used anywhere in NorFlashDxe driver.
Signed-off-by: sahil
---
Platform/ARM/Drivers/NorFlashDxe/NorFlash.h | 17 -
1 file changed, 17 deletions(-)
From: sahil
Refactoring done in this patch has two major parts:
1. Moving out NorFlashUnlockAndEraseSingleBlock and
NorFlashWriteFullBlock functions from NorFlashDxe.c and
NorFlashStandaloneMm.c to NorFlash.c files.
2. At the same time, we are adding NorFlashLock and NorFlashUnlock
functions wh
1 - 100 of 113 matches
Mail list logo
