Implements SmmCorePlatformHookLib library for AMD platform.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 5 +
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 6 +
.../Library/AmdSmmCorePlatformHookLib.h | 68
Register a smm core platform hook handler for SPI device,
using AMD SmmCorePlatformHookLib library.
This platform hook saves the SPI host controller state.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 3 +
Removes unused gBoardBdsBootFromDevicePathProtocolGuid protocol,
and its corresponding code changes.
Adds missing Pcd/SmbiosPcd.h file.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AmdPlatformPkg/Include/Pcd/SmbiosPcd.h| 58
PR: https://github.com/tianocore/edk2-platforms/pull/148
Fix the build failure for SmbiosDxe driver by removing
unused protocol.
Adds PCD defines for smbios.
Adds SPI supporting libraries.
Cc: Abner Chang
Cc: Paul Grimes
Abdul Lateef Attar (3):
AmdPlatformPkg: Removes unused
Fix windows VC compilattion warning for AcpiCommon driver.
Cc: Paul Grimes
Cc: Abner Chang
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/Universal/Acpi/AcpiCommon/PciSsdt.c| 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
PR: https://github.com/tianocore/edk2-platforms/pull/146
Cc: Paul Grimes
Cc: Abner Chang
Abdul Lateef Attar (2):
AmdPlatformPkg: Corrects file path of LogoDxe driver
AmdPlatformPkg: Fix windows VC compilation warning
.../Universal/Acpi/AcpiCommon/PciSsdt.c | 4 +-
Removes extra directory.
Cc: Paul Grimes
Cc: Abner Chang
Signed-off-by: Abdul Lateef Attar
---
.../LogoDxe/{LogoDxe => }/JpegLogo.idf| 0
.../LogoDxe/{LogoDxe => }/JpegLogoDxe.inf | 0
.../Universal/LogoDxe/{LogoDxe => }/Logo.bmp | Bin
Reviewed-by: Abdul Lateef Attar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119205): https://edk2.groups.io/g/devel/message/119205
Mute This Topic: https://groups.io/mt/106257080/21656
Group Owner: devel+ow...@edk2.groups.io
Reviewed-by: Abdul Lateef Attar (
abdullateef.at...@amd.com )
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119204): https://edk2.groups.io/g/devel/message/119204
Mute This Topic: https://groups.io/mt/106257082/21656
Group Owner:
Reviewed-by: Abdul Lateef Attar
On 23-05-2024 21:57, Michael D Kinney via groups.io wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Reviewed-by: Michael D Kinney
-Original Message-
Adds SMBIOS common driver which generates various
tables for AMD platforms.
Cc: Paul Grimes
Reviewed-by: Abner Chang
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 61 +
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 3 +-
PeiBoardInitPreMemLib library provides board-specific
initialization functions for the PEI phase.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec | 8 +
.../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 5 +
Adds SMBIOS common driver which generates various
tables for AMD platforms.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 63 -
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 3 +-
PeiBoardInitPreMemLib library provides board-specific
initialization functions for the PEI phase.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec | 8 +
.../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 5 +
PR: https://github.com/tianocore/edk2-platforms/pull/144
V2 delta changes:
Updated the "AmdMinBoardPkg: Implement BoardInitLib for PEI phase" PATCH
with correct .dec and .dsc file.
Cc: Paul Grimes
Cc: Abner Chang
Abdul Lateef Attar (5):
AmdMinBoardPkg: Uncrustify PciHotPlug module
Implements BoardBdsHookLib library class for AMD platforms.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec | 10 +
.../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc |2 +
.../Include/Library/AmdBoardBdsHookLib.h |
DxeBoardInitLib library provides board-specific
initialization functions for the DXE phase.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 6 +-
.../Library/DxeBoardInitLib/DxeBoardInitLib.c | 253 +++
Uncrustify the library module.
Update the function header.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../Library/PeiReportFvLib/PeiReportFvLib.c | 12 +++-
.../Library/SetCacheMtrrLib/SetCacheMtrrLib.c| 3 +--
2 files changed, 12
PeiBoardInitPreMemLib library provides board-specific
initialization functions for the PEI phase.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 2 +
.../PeiBoardInitPreMemLib/AmdMemoryInfoHob.h | 50
Uncrustify PciHotPlug module.
corrects the [in, out] parameters.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
Platform/AMD/AmdMinBoardPkg/PciHotPlug/PciHotPlugInit.c | 4 +++-
Platform/AMD/AmdMinBoardPkg/PciHotPlug/PciHotPlugInit.inf | 5 +++--
2 files changed, 6
PR: https://github.com/tianocore/edk2-platforms/pull/143
Adds various module common to AMD boards.
Cc: Abner Chang
Cc: Paul Grimes
Abdul Lateef Attar (5):
AmdMinBoardPkg: Uncrustify PciHotPlug module
AmdMinBoardPkg/Library: Uncrustify the Library module
AmdMinBoardPkg: Implement
Adds SecureBootDefaultKeysInit driver to enroll
secure boot default keys.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 12 +
.../SecureBootDefaultKeysInit.c | 645 ++
Adds ACPI common driver which generates.
Generates CPU topology SSDT table.
Generates PCIe topology SSDT table.
Generates SPMI table.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 13 +-
Adds AmdConfigRouting driver to improve HII performance.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc |1 +
.../HiiConfigRouting/AmdConfigRouting.inf | 45 +
.../HiiConfigRouting/AmdConfigRoutingEntry.c | 57 +
Adds PlatformSocLib library class.
Implements null instance of PlatformSocLib.
PlatformSocLib provides interface to the SoC
specific functionality.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 7 +
Implements SerialPortLib library class for simulator.
It redirects the output to the port 80.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 3 +-
.../SimulatorSerialPortLibPort80.c| 208 ++
Adds LogoDxe driver to display AMD logo.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 10 +-
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 31 ++-
.../Universal/LogoDxe/LogoDxe/JpegLogo.idf| 10 +
Adds BaseAlwaysFalseDepexLib Library which always
adds DEPEX to FALSE.
Using this library will prevent module/driver being dispatched.
Usage:
MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.inf {
PR: https://github.com/tianocore/edk2-platforms/pull/141
Adds various libraries and drivers for AMD Platform.
Cc: Abner Chang
Cc: Paul Grimes
Abdul Lateef Attar (7):
AmdPlatformPkg: Adds LogoDxe driver
AmdPlatformPkg: Adds BaseAlwaysFalseDepexLib Library
AmdPlatformPkg: Implements
Adds SecureBootDefaultKeysInit driver to enroll
secure boot default keys.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 12 +
.../SecureBootDefaultKeysInit.c | 645 ++
Adds AmdConfigRouting driver to improve HII performance.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc |1 +
.../HiiConfigRouting/AmdConfigRouting.inf | 45 +
.../HiiConfigRouting/AmdConfigRoutingEntry.c | 57 +
Adds PlatformSocLib library class.
Implements null instance of PlatformSocLib.
PlatformSocLib provides interface to the SoC
specific functionality.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 7 +
Implements SerialPortLib library class for simulator.
It redirects the output to the port 80.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 3 +-
.../SimulatorSerialPortLibPort80.c| 208 ++
Adds LogoDxe driver to display AMD logo.
Cc: Abner Chang
Cc: Paul Grimes
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 10 +-
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 31 ++-
.../Universal/LogoDxe/LogoDxe/JpegLogo.idf| 10 +
Adds BaseAlwaysFalseDepexLib Library which always
adds DEPEX to FALSE.
Using this library will prevent module/driver being dispatched.
Usage:
MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.inf {
PR: https://github.com/tianocore/edk2-platforms/pull/141
Adds various libraries and drivers for AMD Platform.
Cc: Abner Chang
Cc: Paul Grimes
Abdul Lateef Attar (6):
AmdPlatformPkg: Adds LogoDxe driver
AmdPlatformPkg: Adds BaseAlwaysFalseDepexLib Library
AmdPlatformPkg: Implements
Hi Pierre and Sami,
I'll submit separate patches for each table, which will be ready
and easy to merge after the current hard feature freeze over.
Thanks
AbduL
On 03-05-2024 13:11, Sami Mujawar wrote:
Caution: This message originated from an External Source. Use proper caution
when
when opening attachments, clicking links, or responding.
Abdul:
Can you give more information why this change is required for this
stable
tag 202405?
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io 代表Abdul Lateef
> Attar via groups.io
> 发送时间: 2024年5月9日12:49
> 收件人:
tag 202405?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Abdul Lateef
> Attar via groups.io
> 发送时间: 2024年5月9日 12:49
> 收件人: devel@edk2.groups.io
> 抄送: Abdul Lateef Attar ; Pierre Gondois
> ; Sami Mujawar
> 主题: [edk2-devel] [edk2-stable202405 RESEND PATCH v2
Adds an AmlAddIntegerToNamedPackage() API to generate AML code,
which adds an integer value to the package node.
Cc: Pierre Gondois
Cc: Sami Mujawar
Signed-off-by: Abdul Lateef Attar
---
.../Include/Library/AmlLib/AmlLib.h | 41 +++-
.../Common/AmlLib/CodeGen/AmlCodeGen.c
Please concider this patch for stable release.
PR: https://github.com/tianocore/edk2/pull/5636
This patch adds integer to the AML package node.
v2 delta : Addressed comments from Pierre Gondois
Cc: Pierre Gondois
Cc: Sami Mujawar
Cc: Liming Gao
Cc: Michael D Kinney
Abdul Lateef Attar (1):
Adds an AmlAddIntegerToNamedPackage() API to generate AML code,
which adds an integer value to the package node.
Cc: Pierre Gondois
Cc: Sami Mujawar
Signed-off-by: Abdul Lateef Attar
---
.../Include/Library/AmlLib/AmlLib.h | 41 +++-
.../Common/AmlLib/CodeGen/AmlCodeGen.c
This patch adds integer to the AML package node.
v2 delta : Addressed comments from Pierre Gondois
Cc: Pierre Gondois
Cc: Sami Mujawar
Abdul Lateef Attar (1):
DynamicTablesPkg: Adds integer to the AML package node
.../Include/Library/AmlLib/AmlLib.h | 41 +++-
Adds an AmlAddIntegerPackageEntry() API to generate AML code,
which adds an integer value to the package node.
Cc: Pierre Gondois
Cc: Sami Mujawar
Signed-off-by: Abdul Lateef Attar
---
.../Include/Library/AmlLib/AmlLib.h | 41 +-
.../Common/AmlLib/CodeGen/AmlCodeGen.c
Hi Pierre Gondois and Sami Mujawar,
Could you please review below patch set and consider for upcoming
stable release ?
There are non-disruptive patches and won't impact existing ARM platform.
Thanks
AbduL
On 29-04-2024 11:33, Abdul Lateef Attar wrote:
PR:
Hi Ray,
Some of AMD platform doesnt use CpuMpPeim.
Also this patch helps not to enforce the platform to brinup all AP's in
PEI phase.
Thanks
AbduL
On 30-04-2024 11:17, Ni, Ray wrote:
Caution: This message originated from an External Source. Use proper
caution when opening
Reviewed-by: Abdul Lateef Attar
On 29-04-2024 10:31, abner.ch...@amd.com wrote:
From: Abner Chang
BZ# 4695
Signed-off-by: Abner Chang
Cc: Abdul Lateef Attar
Cc: Nickle Wang
---
.../ManageabilityPkg/ManageabilityPkg.dsc | 72 ++-
1 file changed, 56 insertions(+), 16
If gMpInformation2HobGuid HOB is NULL,
then fall back to an older way of collecting
CPU information from the MP services library.
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Abdul Lateef Attar
---
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 87
Adds X64 architecture specific MADT/APIC Table generator.
Register/Deregister MADT table.
Adds X64 architecture namespace objects.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
DynamicTablesPkg/DynamicTables.dsc.inc| 6 +
Adds generic ACPI SSDT HPET table generator library.
Register/Deregister HPET table.
Adds ACPI namespace object for HPET device.
Adds Address space for HPET device.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
DynamicTablesPkg/DynamicTables.dsc.inc| 2 +
Adds generic ACPI WSMT table generator library.
Register/Deregister WSMT table.
Update the WSMT table during boot as per specification.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
DynamicTablesPkg/DynamicTables.dsc.inc| 2 +
PR: https://github.com/tianocore/edk2/pull/5500/
V4: delta changes
Added X64 arch specific MADT table generator.
V3: delta changes
Restructure the code as the review comments.
Added sanity check for WSMT flags.
Added CM object for HPET base address.
V2: delta changes
Addressed review
Adds generic ACPI FADT table generator library.
Register/Deregister FADT table.
Adds Arch namespace ids.
Update the FADT table during boot as per specification.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
DynamicTablesPkg/DynamicTables.dsc.inc| 10 +-
Adds generic ACPI HPET table generator library.
Register/Deregister HPET table.
Update the HPET table during boot as per specification.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
DynamicTablesPkg/DynamicTables.dsc.inc| 2 +
s
that is in the industry now.
Thanks
Sean
On 4/22/2024 3:50 AM, Abdul Lateef Attar via groups.io wrote:
Gentle reminder, review please.
On 30-03-2024 10:52, Abdul Lateef Attar wrote:
Define IPMI interface type as per specification version 2.0,
section C1-1.1.
Cc: Abner Chang <mailto:a
Update the MadtLen varaible before the next record is read,
to void infinite loop.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Abdul Lateef Attar
---
.../Test/Library/TestPointCheckLib/DxeCheckAcpiMadt.c | 7 +--
1 file changed, 5 insertions(+), 2
Gentle reminder, review please.
On 30-03-2024 10:52, Abdul Lateef Attar wrote:
Define IPMI interface type as per specification version 2.0,
section C1-1.1.
Cc: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Abdul Lateef Attar
---
MdePkg/MdePkg.dec | 11
Reviewed-by: Abdul Lateef Attar
On 10-04-2024 19:27, Jiaxin Wu wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Due to the definition difference of SMRAM Save State,
SmmBase config in SMRAM Save
Reviewed-by: Abdul Lateef Attar
On 04-04-2024 14:54, abner.ch...@amd.com wrote:
From: Abner Chang
BZ#: 4473
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Jian J Wang
Cc: Abdul Lateef Attar
---
MdeModulePkg/MdeModulePkg.dec | 28 +++-
1 file changed, 27
Reviewed-by: Abdul Lateef Attar
On 04-04-2024 14:54, abner.ch...@amd.com wrote:
From: abnchang
BZ#: 4472
Add definition of JEDEC Serial Flash Discoverable Parameters
(SFDP) specification.
https://www.jedec.org/standards-documents/docs/jesd216b
Signed-off-by: Abner Chang
Cc: Michael D
Reviewed-by: Abdul Lateef Attar
On 04-04-2024 14:40, abner.ch...@amd.com wrote:
From: abnchang
BZ#: 4471
Update definitions according to PI spec 1.8 errata A
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Abdul Lateef Attar
Cc: Brit Chesley
---
Define IPMI interface type as per specification version 2.0,
section C1-1.1.
Cc: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Abdul Lateef Attar
---
MdePkg/MdePkg.dec | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git
Define IPMI interface type as per specification version 2.0,
section C1-1.1.
Cc: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Abdul Lateef Attar
---
MdePkg/MdePkg.dec | 9 +
1 file changed, 9 insertions(+)
diff --git a/MdePkg/MdePkg.dec
Adds X64 architecture specific MADT/APIC Table generator.
Register/Deregister MADT table.
Adds X64 architecture namespace objects.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
DynamicTablesPkg/DynamicTables.dsc.inc| 6 +
Adds generic ACPI SSDT HPET table generator library.
Register/Deregister HPET table.
Adds ACPI namespace object for HPET device.
Adds Address space for HPET device.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
DynamicTablesPkg/DynamicTables.dsc.inc| 2 +
Adds generic ACPI FADT table generator library.
Register/Deregister FADT table.
Adds Arch namespace ids.
Update the FADT table during boot as per specification.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
DynamicTablesPkg/DynamicTables.dsc.inc| 10 +-
Adds generic ACPI WSMT table generator library.
Register/Deregister WSMT table.
Update the WSMT table during boot as per specification.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
DynamicTablesPkg/DynamicTables.dsc.inc| 2 +
Adds generic ACPI HPET table generator library.
Register/Deregister HPET table.
Update the HPET table during boot as per specification.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
DynamicTablesPkg/DynamicTables.dsc.inc| 2 +
PR: https://github.com/tianocore/edk2/pull/5500/
V4: delta changes
Added X64 arch specific MADT table generator.
V3: delta changes
Restructure the code as the review comments.
Added sanity check for WSMT flags.
Added CM object for HPET base address.
V2: delta changes
Addressed review
Gentle reminder, please review and merge the patch.
On 08-03-2024 12:52, Abdul Lateef Attar via groups.io wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
From: Abdul Lateef Attar
PR : https
From: Abdul Lateef Attar
Adds generic ACPI SSDT HPET table generator library.
Register/Deregister HPET table.
Adds ACPI namespace object for HPET device.
Adds Address space for HPET device.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
From: Abdul Lateef Attar
Adds generic ACPI WSMT table generator library.
Register/Deregister WSMT table.
Update the WSMT table during boot as per specification.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
DynamicTablesPkg/DynamicTables.dsc.inc| 2 +
From: Abdul Lateef Attar
Adds generic ACPI FADT table generator library.
Register/Deregister FADT table.
Adds Arch namespace ids.
Update the FADT table during boot as per specification.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
From: Abdul Lateef Attar
Adds generic ACPI HPET table generator library.
Register/Deregister HPET table.
Update the HPET table during boot as per specification.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
DynamicTablesPkg/DynamicTables.dsc.inc| 2 +
From: Abdul Lateef Attar
PR: https://github.com/tianocore/edk2/pull/5468
V3: delta changes
Restructure the code as the review comments.
Added sanity check for WSMT flags.
Added CM object for HPET base address.
V2: delta changes
Addressed review comments
Adds ACPI HPET table to add
Thanks Pierre for the review, I'll address the review comments.
Please see inline for my reply
On 11-03-2024 19:46, Pierre Gondois wrote:
Caution: This message originated from an External Source. Use proper
caution when opening attachments, clicking links, or responding.
Hello Abdul,
On
Hi Narinder,
Patch looks good with minor comment inline.
Thanks
AbduL
On 18-01-2024 06:48, Narinder Dhillon via groups.io wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
From: Narinder Dhillon
Hi Narinder,
Patch looks good with minor comments inline.
Thanks
AbduL
On 18-01-2024 06:48, Narinder Dhillon via groups.io wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
From: Narinder
Hi Pierre,
I think the provided patch also serve the same purpose of
validating the COMM_BUFFER_NESTED_PTR_PROTECTION against FIXED_COMM_BUFFERS.
Do you want me to remove the "ValidateReserved" implementation?
Here is the sample test results.
1)
Protection Flag :
From: Abdul Lateef Attar
Adds WSMT parse to the UefiShellAcpiViewCommandLib library.
Cc: Zhichao Gao
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Pierre Gondois
---
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 17 ++
.../Parsers/Wsmt/WsmtParser.c
From: Abdul Lateef Attar
Adds HPET parse to the UefiShellAcpiViewCommandLib library.
Cc: Zhichao Gao
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Pierre Gondois
---
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 17 ++
.../Parsers/Hpet/HpetParser.c
From: Abdul Lateef Attar
PR : https://github.com/tianocore/edk2/pull/5449
Adds HPET and WSMT parser for acpiview.
V2 delta changes:
Addressed review comments.
Added validation functions as per the comments.
Cc: Zhichao Gao
Cc: Pierre Gondois
Abdul Lateef Attar (2):
ShellPkg/Acpiview:
Thanks Pierre for review, I'll address the review comment and submit the
V2 patch.
On 07-03-2024 16:07, Pierre Gondois wrote:
Caution: This message originated from an External Source. Use proper
caution when opening attachments, clicking links, or responding.
Hello Abdul,
With the
Hi Pierre,
Thanks for reaching out, my patches are non-disruptive (wont impact
existing ARM code base).
I think lets review and integrate to main branch.
Thanks
AbduL
On 05-03-2024 19:33, Pierre Gondois wrote:
Caution: This message originated from an External Source. Use proper
From: Abdul Lateef Attar
Adds HPET parse to the UefiShellAcpiViewCommandLib library.
Cc: Zhichao Gao
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 17 ++
.../Parsers/Hpet/HpetParser.c | 221 ++
From: Abdul Lateef Attar
Adds WSMT parse to the UefiShellAcpiViewCommandLib library.
Cc: Zhichao Gao
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 17
.../Parsers/Wsmt/WsmtParser.c | 89 +++
From: Abdul Lateef Attar
Adds HPET and WSMT parser for acpiview.
Cc: Zhichao Gao
Cc: Pierre Gondois
Abdul Lateef Attar (2):
ShellPkg/Acpiview: Adds HPET parser
ShellPkg/Acpiview: Adds ACPI WSMT Table parser
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 34 +++
Hi Sami, Sunil,
Yesterday I submitted few patches on main branch; I'll port those
changes to this staging branch.
Currently from AMD X64 perspective I'm working on ACPI tables, once that
is done, then will move to smbios tables.
Thanks
AbduL
On 05-03-2024 16:22, Sunil V L wrote:
From: Abdul Lateef Attar
Adds generic ACPI SSDT HPET table generator library.
Register/Deregister HPET table.
Adds ACPI namespace object for HPET device.
Adds Address space for HPET device.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
From: Abdul Lateef Attar
Adds generic ACPI WSMT table generator library.
Register/Deregister WSMT table.
Update the WSMT table during boot as per specification.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
DynamicTablesPkg/DynamicTables.dsc.inc| 2 +
From: Abdul Lateef Attar
Adds generic ACPI HPET table generator library.
Register/Deregister HPET table.
Update the HPET table during boot as per specification.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
DynamicTablesPkg/DynamicTables.dsc.inc| 2 +
From: Abdul Lateef Attar
Adds generic ACPI FADT table generator library.
Register/Deregister FADT table.
Adds Arch namespace ids.
Update the FADT table during boot as per specification.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
From: Abdul Lateef Attar
PR: https://github.com/tianocore/edk2/pull/5438
V2: delta changes
Addressed review comments
Adds ACPI HPET table to add HPET to ACPI namespace
V1:
Adds new space for ArchNameSpaceObjects.
Adds generic FADT table generator.
Adds generic HPET table generator.
Adds
Hi Pierre Gondois,
Thanks for review the comment, i will make the changes accordingly.
Please find my response in line.
Thanks
AbduL
On 27-02-2024 21:32, Pierre Gondois wrote:
Caution: This message originated from an External Source. Use proper
caution when opening attachments, clicking
From: Abdul Lateef Attar
Adds generic ACPI HPET table generator library.
Register/Deregister HPET table.
Update the HPET table during boot as per specification.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
DynamicTablesPkg/DynamicTables.dsc.inc| 2 +
From: Abdul Lateef Attar
Adds generic ACPI WSMT table generator library.
Register/Deregister WSMT table.
Update the WSMT table during boot as per specification.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
DynamicTablesPkg/DynamicTables.dsc.inc| 2 +
From: Abdul Lateef Attar
Adds generic ACPI FADT table generator library.
Register/Deregister FADT table.
Adds Arch namespace ids.
Update the FADT table during boot as per specification.
Cc: Sami Mujawar
Cc: Pierre Gondois
Signed-off-by: Abdul Lateef Attar
---
From: Abdul Lateef Attar
PR: https://github.com/tianocore/edk2/pull/5384
Adds new space for ArchNameSpaceObjects.
Adds generic FADT table generator.
Adds generic HPET table generator.
Adds generic WSMT table generator.
Cc: Sami Mujawar
Cc: Pierre Gondois
Cc: Abdul Lateef Attar
Abdul Lateef
Gentle reminder, please review the patch series.
On 18-01-2024 09:24, Abdul Lateef Attar via groups.io wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
From: Abdul Lateef Attar
Resending the patch
[AMD Official Use Only - General]
Why overriding the PiSmmCpuDxeSmm driver?
UefiCpuPkg has AMD specific SaveStatelib library
"UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveStateLib.inf".
Thanks
AbduL
-Original Message-
From: devel@edk2.groups.io On Behalf Of duke.zhai via
groups.io
1 - 100 of 349 matches
Mail list logo
