On Thu, 24 Aug 2023 at 06:46, Mike Beaton wrote:
>
> This reverts commit 173a7a7daaad560cd69e1000faca1d2b91774c46.
>
> Fixes https://bugzilla.tianocore.org/show_bug.cgi?id=4528
>
> Signed-off-by: Mike Beaton
> ---
> OvmfPkg/build.sh | 13 -
> 1 file changed, 8 insertions(+), 5
On Mon, 4 Sept 2023 at 13:45, Gerd Hoffmann wrote:
>
> On Thu, Aug 31, 2023 at 06:01:56PM +0200, Ard Biesheuvel wrote:
> > On Mon, 28 Aug 2023 at 13:13, Ard Biesheuvel wrote:
> > >
> > > On Mon, 28 Aug 2023 at 11:16, Gerd Hoffmann wrote:
> > > >
&g
On Mon, 28 Aug 2023 at 13:13, Ard Biesheuvel wrote:
>
> On Mon, 28 Aug 2023 at 11:16, Gerd Hoffmann wrote:
> >
> > Hi,
> >
> > > I have tried the patch below, and I don't see any slowdowns with or
> > > without the patch, running both DEBUG and RELE
On Thu, 31 Aug 2023 at 15:06, Leif Lindholm wrote:
>
> Hi,
>
> Apologies for the long delay reviewing this set.
>
> I have rebased your patches onto:
> https://github.com/leiflindholm/edk2-platforms/tree/sbsa-xhci
>
> I had to move one hunk (.dec change) from 2/3 to 1/3 in order to
> not break
On Wed, 16 Aug 2023 at 10:56, Nhi Pham wrote:
>
> Hi Ard and Ming,
>
> I have been seeing an issue with StandaloneMM HobLib that can be fixed
> by this patch as well.
>
> The function CreateHob() in the HobLib instance
> StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmCoreHobLib.inf
>
On Tue, 29 Aug 2023 at 16:37, Laszlo Ersek wrote:
>
> On 8/29/23 15:29, Ard Biesheuvel wrote:
> > Laszlo reports that the efi_gdb.py script fails to produce a full
> > backtrace when attaching it to an ARM firmware build that has halted on
> > an unhandled excep
-off-by: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Rebecca Cran
Reviewed-by: Ard BIesheuvel
> ---
>
> Ultimately, the size is still restricted to 32-bit since it is set
> directly from a PcdGet32 (PcdFvSize). This should ideally be broken
> out into an OemMiscLib functio
Laszlo reports that the efi_gdb.py script fails to produce a full
backtrace when attaching it to an ARM firmware build that has halted on
an unhandled exception.
The reason is that the asm code that processes the exception was not
implemented with this in mind, and therefore lacks any handling of
On Mon, 28 Aug 2023 at 20:37, Kinney, Michael D
wrote:
>
> Hi Ard,
>
> I think your main question is how all developers can find the
> details of any of these types of test failures. It is not
> obvious until you notice there is a "Tests" tab on one of the
> Azure Pipelines pages.
>
> The main
Could someone please explain to me how I can figure out why this PR
was rejected by the CI?
https://github.com/tianocore/edk2/pull/4763
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108060):
; The second patch adds a unit test for the ImagePropertiesRecordLib. The
> >> logic tests various potential layouts of the EFI memory map and runtime
> >> images. 3/4 of these tests will fail which demonstrates the MAT logic
> >> bugs.
> >>
> >> The third
On Mon, 28 Aug 2023 at 11:16, Gerd Hoffmann wrote:
>
> Hi,
>
> > I have tried the patch below, and I don't see any slowdowns with or
> > without the patch, running both DEBUG and RELEASE builds under
> > ordinary KVM/nested-virt. Note that the change in the first hunk will
> > cause the
On Thu, 24 Aug 2023 at 10:06, Gerd Hoffmann wrote:
>
> On Wed, Aug 23, 2023 at 07:10:52PM +0100, Pedro Falcato wrote:
> > On Wed, Aug 23, 2023 at 4:12 PM Ard Biesheuvel wrote:
> > >
> > > On Wed, 23 Aug 2023 at 13:08, Gerd Hoffmann wrote:
> > > >
: Leif Lindholm
> Cc: Rebecca Cran
> Cc: Liming Gao
> Cc: Bob Feng
> Cc: Yuwei Chen
> Cc: Ard Biesheuvel
Acked-by: Ard Biesheuvel
> ---
>
> Does anyone remember why these were added?
I added those when I first introduced Clang 3.5 support, and I am
quite sure i only a
On Wed, 23 Aug 2023 at 13:08, Gerd Hoffmann wrote:
>
> On Tue, Aug 22, 2023 at 09:57:12AM +0200, Ard Biesheuvel wrote:
> > On Tue, 22 Aug 2023 at 08:25, Gerd Hoffmann wrote:
> > >
> > > Looks good to me.
> > >
> > > What is the status? Mer
ything.
>
OK.
> On 2023-05-24 15:05, Gerd Hoffmann wrote:
> > Tell clang to not use external (via got) references for data access.
> >
> > Signed-off-by: Gerd Hoffmann
> > Reviewed-by: Ard Biesheuvel
> > ---
> > BaseTools/Conf/tools_def.template | 6
On Tue, 22 Aug 2023 at 08:25, Gerd Hoffmann wrote:
>
> On Thu, Jul 20, 2023 at 03:45:57PM +0200, Ard Biesheuvel wrote:
> > Instead of relying on raising the TPL to protect the critical sections
> > that manipulate the global bitmask that keeps track of bounce buffer
> >
GitHub PR: https://github.com/tianocore/edk2/pull/4750
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
> Cc: Gerd Hoffmann
>
> Signed-off-by: Oliver Smith-Denny
Reviewed-by: Ard Biesheuvel
Feel free to remind me to queue this up after the stable tag releas
On Tue, 15 Aug 2023 at 10:10, Ard Biesheuvel wrote:
>
> On Mon, 14 Aug 2023 at 10:15, Corvin Köhne wrote:
> >
> > On Thu, 2023-08-10 at 15:54 -0400, Michael Kubacki wrote:
> > > I'm not sure why test results are not being reported that may be a
> > > larger is
tTimeWakeUpAPsBySipi to false for AmdSev
> package, as was previously done for OvmfPkg variants.
>
> Fixes: eaffa1d7ff ("UefiCpuPkg:Wake up APs after power-up or RESET through
> SIPI.")
> Cc: YuanhaoXie
> Cc: Tom Lendacky
> Cc: Eric Dong
> Cc: Ray Ni
> Cc: Rahul Kum
On Wed, 16 Aug 2023 at 05:40, Rebecca Cran wrote:
>
> Intel has been releasing the EDK2/UEFI source code for their network
> drivers
> (https://www.intel.com/content/www/us/en/download/15755/intel-ethernet-connections-boot-utility-preboot-images-and-efi-drivers.html)
> but I've found a few
On Tue, 15 Aug 2023 at 18:31, Andrew Fish via groups.io
wrote:
>
>
>
> > On Aug 15, 2023, at 8:39 AM, Pedro Falcato wrote:
> >
> > On Tue, Aug 15, 2023 at 4:05 PM Andrew Fish via groups.io
> > wrote:
> >>
> >> Chao,
> >>
> >> From a quick google it looks like CSR* is used to access banks of
>
On Tue, 15 Aug 2023 at 10:20, Chao Li wrote:
>
> Hi Andrew,
>
> Yes, you are right, I also think that SMC is a bit flawed in terms of
> security, but can we use some security mechanism to protect the SMC, like
> encryption and decryption? Sorry, I'm not consider mature enough about SMC
>
On Mon, 14 Aug 2023 at 10:15, Corvin Köhne wrote:
>
> On Thu, 2023-08-10 at 15:54 -0400, Michael Kubacki wrote:
> > I'm not sure why test results are not being reported that may be a
> > larger issue.
> >
> > I pulled the branch locally, run uncrustify, and it automatically
> > fixed
> > the code
Could someone please decipher this for us please? I am sick and tired
of the CI impeding my work.
On Thu, 10 Aug 2023 at 15:33, Corvin Köhne wrote:
>
> On Thu, 2023-08-10 at 14:55 +0200, Ard Biesheuvel wrote:
> > On Thu, 10 Aug 2023 at 14:53, Corvin Köhne
> > wrote:
> >
On Thu, 10 Aug 2023 at 14:53, Corvin Köhne wrote:
>
> On Tue, 2023-08-08 at 18:25 +0200, Ard Biesheuvel wrote:
> > On Tue, 8 Aug 2023 at 15:33, Rebecca Cran wrote:
> > >
> > > Nit: "sizeof" is normally used like a function. And this patch
> > > m
On Mon, 31 Jul 2023 at 00:44, Yuanhao Xie wrote:
>
> The implementation of this new behavior aligns with the
> guidelines outlined in the Intel SDM.
>
> Following a power-up or RESET of an MP system, system hardware
> dynamically selects one of the processors on the system bus as
> the BSP. The
On Mon, 31 Jul 2023 at 00:44, Yuanhao Xie wrote:
>
> Disable PcdFirstTimeWakeUpAPsBySipi for OVMF to let BSP wake up APs by
> INIT-SIPI-SIPI.
>
> Cc: Eric Dong
> Cc: Ray Ni
> Cc: Rahul Kumar
> Cc: Gerd Hoffmann
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
>
Hi,
On Wed, 9 Aug 2023 at 23:35, Oliver Smith-Denny
wrote:
>
> Hi Ard,
>
> I just sent out a patch (MdeModulePkg: HeapGuard: Don't Assume Pool Head
> Allocated In First Page) to fix HeapGuard GuardAlignedToTail behavior on
> ARM64. However, this raised a question of why ARM64 sets
>
he pool head in the first place.
>
> With this patch in place, ArmVirtQemu boots with GuardAlignedToTail
> set to true (and when it is false, also).
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4521
> Github PR: https://github.com/tianocore/edk2/pull/4731
>
> Cc: L
t;
> > 1.Update the X64/AArch64 UEFI GOP driver into v1.13.03.
> > 2.Update the .inf version.
> > 3.Modify report framebuffer base behavior.
> >
> > Cc: Ard Biesheuvel
> > Cc: Isaac Oram
> > Cc: Nate DeSimone
> > Cc: Leif Lindholm
> > Cc: Micha
On Tue, 8 Aug 2023 at 15:33, Rebecca Cran wrote:
>
> Nit: "sizeof" is normally used like a function. And this patch mixes the
> two styles.
>
Actually, this is not unidiomatic for OVMF - sizeof takes either a
type name (in which case the () are required) or an expression (in
which case they are
upported +
> > mQemuFwCfgDmaSupported")
> > Signed-off-by: Corvin Köhne
> > Cc: Ard Biesheuvel
> > Cc: Jiewen Yao
> > Cc: Jordan Justen
> > Cc: Gerd Hoffmann
> > Cc: Rebecca Cran
> > Cc: Peter Grehan
> > ---
> > OvmfPkg/Bh
On Mon, 7 Aug 2023 at 03:56, Rebecca Cran wrote:
>
> There's an extra format specifier in the DEBUG_ERROR message that
> gets printed when the PCIe link check fails. This causes a
> synchronous exception. Remove the string format specifier.
>
> Signed-off-by: Rebecca Cran
Thanks
Pushed as
On Thu, 3 Aug 2023 at 23:25, Ard Biesheuvel wrote:
>
> On Thu, 3 Aug 2023 at 21:21, Kinney, Michael D
> wrote:
> >
> > Hi Ard,
> >
> > This is the email with the analysis and the flag
> > setting required for SMP to work with SMM enabled for
> > IA
ute concurrently. (It will be very hard to
catch/reproduce true concurrency issues in TCG anyway)
Oliver, mind spinning a v2?
Thanks,
> > -Original Message-
> > From: Ard Biesheuvel
> > Sent: Thursday, August 3, 2023 9:54 AM
> > To: devel@edk2.groups.io; mikub.
On Thu, 3 Aug 2023 at 16:37, Michael Kubacki
wrote:
>
> For the series.
>
> Reviewed-by: Michael Kubacki
>
Thanks
I've pushed this to the CI but Platform_CI OVMF_IA32X64_FULL_DEBUG
keeps timing out for me
https://github.com/tianocore/edk2/pull/4718
Might it help if we restrict SMP to a
>
Is there any basis in the UEFI or PI specifications for this functionality?
> On 7/26/2023 1:45 AM, Ard Biesheuvel wrote:
> > On Mon, 24 Jul 2023 at 22:15, Kun Qin wrote:
> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4466
> >>
> >> This p
t allocate memory when ConOut is available and instead use
> stack memory to convert the Ascii string needed for SerialPortWrite
> to the Unicode string needed for ConOut->OutputString. Correspondingly,
> ArmVirtQemu can now output the stack dump and CPU state when hitting
> an exceptio
On Tue, 18 Jul 2023 at 12:22, Marcin Juszkiewicz
wrote:
>
> From: Masahisa Kojima
>
> Fix typo in Readme.md
>
> Signed-off-by: Masahisa Kojima
> Signed-off-by: Marcin Juszkiewicz
> ---
> Platform/Qemu/SbsaQemu/Readme.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Pushed,
On Wed, 19 Jul 2023 at 14:09, Marcin Juszkiewicz
wrote:
>
> SBSA Reference Platform can have GIC ITS present. And when it has then
> we can have complex PCI Express setup (and some other things).
>
> First patch adds support for GIC ITS. Address is read from TF-A via SMC
> call. IORT is
On Thu, 3 Aug 2023 at 13:44, Oliver Steffen wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324
> PR: https://github.com/tianocore/edk2/pull/4711
>
> This series switches the OVMF CI jobs on Windows to a recent Qemu
> version and re-enables SMP in the Qemu "Run to shell" CI jobs.
e boot
support, and everything appears to operate as intended. (I didn't
manage to unlock my Linux root volume automatically but that appears
to be broken with openssl 1.1.1 as well)
So for the series
Acked-by: Ard Biesheuvel
Tested-by: Ard Biesheuvel
Let's not sit on this too long - Tianoco
On Wed, 2 Aug 2023 at 18:21, Oliver Smith-Denny
wrote:
>
> On 8/2/2023 9:06 AM, Ard Biesheuvel wrote:
> > On Tue, 1 Aug 2023 at 00:04, Oliver Smith-Denny
> > wrote:
> >>
> >> If gST->ConOut is available when Arm's DefaultExceptionHandler
> >> i
ode string needed for ConOut->OutputString. Correspondingly,
> ArmVirtQemu can now output the stack dump and CPU state when hitting
> an exception in memory code.
>
> GitHub PR: https://github.com/tianocore/edk2/pull/4703
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
&g
Thanks all.
Merged now as #4701
On Mon, 31 Jul 2023 at 13:29, Rebecca Cran wrote:
>
> Sorry for the delay. I've just added my R-b.
>
>
> --
>
> Rebecca
>
>
> On 7/31/23 04:29, Ard Biesheuvel wrote:
> > On Fri, 28 Jul 2023 at 07:32, Sunil V L wrote:
>
On Fri, 28 Jul 2023 at 07:32, Sunil V L wrote:
>
> On Tue, Jul 25, 2023 at 05:59:25PM +0200, Ard Biesheuvel wrote:
> > On Fri, 21 Jul 2023 at 06:52, Sunil V L wrote:
> > >
> > > On Mon, Jul 17, 2023 at 11:38:31AM +0200, Ard Biesheuvel wrote:
> > > > O
On Mon, 31 Jul 2023 at 02:46, Rebecca Cran wrote:
>
> For the series:
>
>
> Reviewed-by: Rebecca Cran
>
Thanks for taking care of this.
In the future, when you merge patches for a package that you don't
maintain, could you please mention this in a reply to the thread? That
way, I'll know I
On Mon, 31 Jul 2023 at 03:39, Rebecca Cran wrote:
>
> I've set up a public-inbox instance for edk2-devel at
> https://openfw.io/edk2-devel .
>
Excellent, thanks for doing this!
> This lets people use the 'b4' tool
> (https://b4.docs.kernel.org/en/latest/) to apply patches from the
> mailing
corrupt memory or straight-up crash.
>
> Make it EFI spec compliant, by adding proper NULL pointer checks
> around RI_SET_MSK and TI_SET_MSK retrieval/clearing.
>
> --
>
> In any case, take my:
>
> Acked-by: Pedro Falcato
>
Thanks,
I've pushed this as 4f316893c9ed..cbab
On Fri, 14 Jul 2023 at 15:03, Marcin Juszkiewicz
wrote:
>
> Update the TF-A binaries to have Neoverse-V1 cpu support.
>
> This support was merged into TF-A:
>
> https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/21813
>
> This allows SBSA Reference Platform to boot Linux on
;
> This change was tested on QEMU, FVP and proprietary hardware platforms.
>
> Pathc v1 branch: https://github.com/kuqin12/edk2/tree/improve_gic_v1
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
>
> Kun Qin (3):
> ArmPkg: ArmGic: Added support to sen
On Fri, 21 Jul 2023 at 06:52, Sunil V L wrote:
>
> On Mon, Jul 17, 2023 at 11:38:31AM +0200, Ard Biesheuvel wrote:
> > On Mon, 17 Jul 2023 at 03:51, gaoliming via groups.io
> > wrote:
> > >
> > > Sunil:
> > > Do you use whic
On Mon, 24 Jul 2023 at 19:28, Pedro Falcato wrote:
>
> On Mon, Jul 24, 2023 at 6:07 PM wrote:
> >
> > I am developing a UEFI application which functions as a bootloader. It is
> > required to handle loading between two Linux kernels dependending on which
> > one failed last (A/B system).
> >
On Sat, 22 Jul 2023 at 00:55, Pedro Falcato wrote:
>
> On Thu, Jul 20, 2023 at 2:46 PM Ard Biesheuvel wrote:
> >
> > Instead of relying on raising the TPL to protect the critical sections
> > that manipulate the global bitmask that keeps track of bounce buffer
>
comment to reflect that AllocatePool() is being avoided due to its
64k allocation size limit when the library is incorporated into a PEI
component.
Thanks,
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel
> Sent: Friday, July 21, 2023 10:49 PM
>
On Fri, 21 Jul 2023 at 17:38, chitralekha ck wrote:
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=4507
> AllocatePool limits to allocate memory of 64 KB at most.
What is the basis for this observation? In DXE, pool allocations are
unbounded afaik.
> if the the image size is higher than
On Thu, 20 Jul 2023 at 19:10, Michael D Kinney
wrote:
>
> Hi Ard,
>
> This is my mistake. I usually check the Author field when
> adding Rb/Ab tags because I have seen lots of cases where
> the Author field needs updating as well. I forgot to do this
> step in this one.
>
> I agree a CI check
On Thu, 20 Jul 2023 at 03:41, Michael D Kinney
wrote:
>
> Merged: https://github.com/tianocore/edk2/pull/4666
>
This commit is now merged as
commit 6510dcf6f71adbe282bff0ba2b236f1d074f819f
Author: devel@edk2.groups.io
AuthorDate: Fri Feb 10 04:34:03 2023 -0800
Commit: mergify[bot]
On Thu, 20 Jul 2023 at 16:30, G Edhaya Chandran wrote:
>
> The patch is upstreamed by:
> https://github.com/tianocore/edk2-test/commit/315e3a56a6d9261d4fad4c1950f2d01a052eeba4
Checking the memory map for memory below 4G only makes sense if the
system has no IOMMU and does not use translation
: Michael Brown
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2211060
Signed-off-by: Ard Biesheuvel
---
OvmfPkg/IoMmuDxe/IoMmuBuffer.c | 100
OvmfPkg/IoMmuDxe/IoMmuDxe.inf | 1 +
2 files changed, 60 insertions(+), 41 deletions(-)
diff --git a/OvmfPkg/IoMmuDxe/IoMmuBuffer.c
On Thu, 20 Jul 2023 at 10:28, Gerd Hoffmann wrote:
>
> > > > mReservedMemBitmap &= (UINT32)(~MapInfo->ReservedMemBitmap);
> > >
> > > I'd expect modern compilers optimize that to a single instruction,
> >
> > You mean something along the lines of
> >
> > andl %reg, mReservedMemBitmap(%rip)
>
On Thu, 20 Jul 2023 at 10:24, Gerd Hoffmann wrote:
>
> IoMmuAllocateCommonBuffer has the very same allocation pattern
> IoMmuAllocateBounceBuffer uses, so the fix added by commit a52044a9e602
> ("OvmfPkg/IoMmuDxe: add locking to IoMmuAllocateBounceBuffer") is needed
> here too.
>
> Reported-by:
On Wed, 19 Jul 2023 at 19:40, Michael Brown wrote:
>
> On 19/07/2023 17:52, Ard Biesheuvel wrote:
> > On Wed, 19 Jul 2023 at 18:32, Gerd Hoffmann wrote:
> >> On Wed, Jul 19, 2023 at 04:04:28PM +, Michael Brown wrote:
> >>> It looks as though IoMmuFre
On Wed, 19 Jul 2023 at 18:31, Gerd Hoffmann wrote:
>
> Searching for an unused bounce buffer in mReservedMemBitmap and
> reserving the buffer by flipping the bit is a critical section
> which must not be interrupted. Raise the TPL level to ensure
> that.
>
> Without this fix it can happen that
On Wed, 19 Jul 2023 at 18:32, Gerd Hoffmann wrote:
>
> On Wed, Jul 19, 2023 at 04:04:28PM +, Michael Brown wrote:
> > On 19/07/2023 12:33, Gerd Hoffmann wrote:
> > > Searching for an unused bounce buffer in mReservedMemBitmap and
> > > reserving the buffer by flipping the bit is a critical
from existing DSCs for library classes that only
have a single implementation.
For this series,
Acked-by: Ard Biesheuvel
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107031): https://edk2.groups.io/g/devel/message/107031
Mute This Topic
On Mon, 17 Jul 2023 at 18:15, Pedro Falcato wrote:
>
> On Wed, Jul 12, 2023 at 12:53 AM Taylor Beebe wrote:
> >
> > In the past, memory protection settings were configured via FixedAtBuild
> > PCDs,
> > which resulted in a build-time configuration of memory mitigations. This
> > approach
On Mon, 17 Jul 2023 at 03:51, gaoliming via groups.io
wrote:
>
> Sunil:
> Do you use which CLANG version is used to verify this change?
>
For the series,
Tested-by: Ard Biesheuvel # Debian clang version 14.0.6
> > -邮件原件-
> > 发件人: Sunil V L
> > 发送时间: 2
On Fri, 14 Jul 2023 at 22:28, Tom Lendacky wrote:
>
> Commit 63c50d3ff2854a76432b752af4f2a76f33ff1974 changed the check that is
> used to determine if SEV-ES is active. Originally, a CMP instruction with
> a supporting JZ instruction was used for the check. It was changed to use
> the BT
On Thu, 13 Jul 2023 at 18:57, Pedro Falcato wrote:
>
> On Tue, Jul 11, 2023 at 7:58 AM Gerd Hoffmann wrote:
> >
> > On Mon, Jul 10, 2023 at 04:58:15PM +0100, Pedro Falcato wrote:
> > > On Mon, Jul 10, 2023 at 2:28 PM wrote:
> > > >
> > > > I have an existing install of Ubuntu 22.04 on a QEMU
On Wed, 12 Jul 2023 at 10:41, Gerd Hoffmann wrote:
>
> Hi,
>
> Tried to debug a bug which looks like memory corruption, turned on page
> and heap guard:
>
> PcdHeapGuardPageType=0x7e
> PcdHeapGuardPoolType=0x7e
> PcdHeapGuardPropertyMask=0x03
>
> With that the firmware
On Wed, 12 Jul 2023 at 09:06, Wu, Hao A wrote:
>
> It works for me, better to override by:
>
> Status = EFI_SUCCESS;
>
>
So now we're adding unnecessary assignments just to please coverity? I
don't think this is a good idea.
If Coverity does not understand that the source references Status
d potetial return values.
>
> Taylor Beebe (4):
> ArmPkg: Apply Uncrustify to Non-Compliant Files
> ArmPkg: Update GetMemoryRegion() to Handle No mapping
> ArmPkg: Fix Unsafe ASSERTs in MMU Logic
> ArmPkg: Add Function Headers to MMU Logic
>
> Cc: Leif Lindholm
EDK2 for different architectures.
>
> Cc: Rebecca Cran
> Cc: Liming Gao
> Cc: Bob Feng
> Cc: Yuwei Chen
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc Gerd Hoffmann
> Cc: Andrei Warkentin
> Cc: Heinrich Schuchardt
>
> Sunil V L (4):
> OvmfP
k2/tree/arm_var_pei_v3
>
> Cc: Hao A Wu
> Cc: Liming Gao
> Cc: Jian J Wang
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
>
> Kun Qin (2):
> ArmPkg: MmCommunicationPei: Introduce MM communicate in PEI
> MdeModulePkg: Variable: Introduce
> used as communicate buffer and SMC will be invoked to communicate to
> TrustZone when MMI is requested.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
>
> Co-authored-by: Ronny Hansen
> Co-authored-by: Shriram Masanamuthu Chinnathurai
> Co-auth
.
Signed-off-by: Ard Biesheuvel
---
OvmfPkg/VirtioSerialDxe/VirtioSerial.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
b/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
index df545c080e9d9212..fd34ad75a9a079ce 100644
--- a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
On Wed, 21 Jun 2023 at 16:13, Pedro Falcato wrote:
>
> On Wed, Jun 21, 2023 at 8:55 AM Gerd Hoffmann wrote:
> >
> > On Wed, Jun 21, 2023 at 01:40:06AM +0100, Pedro Falcato wrote:
> > > On Tue, 20 Jun 2023, 12:11 Li, Yi, wrote:
> > >
> > > > The effect of LTO is limited with optimization turned
On Mon, 26 Jun 2023 at 12:38, Gerd Hoffmann wrote:
>
> Smallest IO window size for PCI bridges is 0x1000. Fix default size
> accordingly. Avoids broken resource assignments like this:
>
> [ ... ]
> PciBus: Resource Map for Root Bridge PciRoot(0x0)
> Type = Io16; Base = 0x6000;
On Tue, 20 Jun 2023 at 16:27, Gerd Hoffmann wrote:
>
> On Mon, Jun 12, 2023 at 07:27:37PM +, Kallol Biswas [C] wrote:
> > Hi,
> > We have been observing an issue that IO BARs can't be claimed due to
> > resource
> > conflict.
> >
> > [0.457693] pci :00:1d.0: can't claim BAR 4 [io
On Sun, 25 Jun 2023 at 04:59, gaoliming via groups.io
wrote:
>
> For the changes in MdeModulePkg, Reviewed-by: Liming Gao
>
>
Merged as #4573
Thanks all.
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Michael
> > Kubacki
> > 发送时间: 2023年6月7日 7:13
Now that we have a sane API to set and clear memory permissions that
works the same on ARM and AArch64, we no longer have a need for the
individual set/clear no-access/read-only/no-exec helpers so let's drop
them.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Drivers/CpuDxe/CpuDxe.c
The OP-TEE secure OS exposes a non-secure memory region for
communication between the secure OS itself and any clients in the
non-secure firmware. This memory is writable by non-secure and is not
used for code only data, and so it should be mapped non-executable.
Signed-off-by: Ard Biesheuvel
StandaloneMm has its own version of the ArmMmuLib library class, but
includes the ArmMmuLib header. This happens to work because the
prototypes that are referenced are the same, but this will no longer be
the case after a future patch. So correct the #includes.
Signed-off-by: Ard Biesheuvel
A couple of tweaks for the memory attribute handling code to go on top
of the memory attribute PPI changes.
Cc: Sami Mujawar
Cc: Leif Lindholm
Ard Biesheuvel (3):
StandaloneMmPkg: Include correct MmuLib header
ArmPkg: Drop individual memory permission helpers
ArmPkg/OpteeLib: Map shared
ran
> Acked-by: Gerd Hoffmann
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Peter Grehan
Merged as #4568
Thanks.
> ---
> OvmfPkg/Bhyve/BhyveX64.dsc | 17 +++--
> OvmfPkg/Bhyve/BhyveX64.fdf | 7 +++
> 2 files changed, 22 insert
On Wed, 21 Jun 2023 at 09:31, Corvin Köhne wrote:
>
> CI: https://github.com/tianocore/edk2/pull/4545
>
> Corvin Köhne (6):
> OvmfPkg/Library: fix definition of GetAcpiRsdpFromMemory
> OvmfPkg: avoid including AcpiPlatformLib twice
> OvmfPkg: move PciEncoding into AcpiPlatformLib
>
On Tue, 20 Jun 2023 at 19:07, Sean Brogan wrote:
>
> I don't think a MemoryAttributes2Protocol with a single API would have
> avoided the errors.
>
> The programming pattern that triggered this would still need multiple calls
> to any API and in the future where all memory is allocated as NX
On Fri, 23 Jun 2023 at 18:03, Joey Vagedes wrote:
>
> Utilize GenFw to automatically set the NXCOMPAT bit of the DLL Characteristics
> field of the Optional Header if the following requirements are met:
>
> 1. It is a 64bit PE
> 2. The section alignment is evently divisible by 4K
> 3. No section
On Tue, Jun 20, 2023, 12:33 Gerd Hoffmann wrote:
> On Mon, Jun 19, 2023 at 10:32:25PM +0200, Oliver Steffen wrote:
> > Recent versions of shim (15.6 and 15.7) crash when the newly added
> > EFI_MEMORY_ATTRIBUTE_PROTOCOL is provided by the firmware. To allow
> > existing installations to boot,
ential VMs).
It also provides a better basis for architectures to carry their own
specific logic for this, instead of having a subdirectory for each
arch under DxeIpl/
> On 6/8/2023 2:27 PM, Sean wrote:
> > On 6/8/2023 10:48 AM, Ard Biesheuvel wrote:
> >> On Thu, 8 Jun 2023 a
On Thu, 8 Jun 2023 at 19:39, Oliver Smith-Denny
wrote:
>
> On 6/8/2023 10:23 AM, Ard Biesheuvel wrote:
> > Currently, we rely on the logic in DXE IPL to create new page tables
> > from scratch when executing in X64 mode, which means that we run with
> > the initial page t
The DEBUG print that outputs the base and size of the page table
allocation always prints 0x0 for the size, given that BufferSize will be
updated by PageTableMap () and contain the unused allocation on return.
So move the DEBUG print right after the allocation.
Signed-off-by: Ard Biesheuvel
that switching
between 4 and 5 levels of paging is not currently supported without
dropping out of 64-bit mode temporarily, all we can do is carry on
without changing the number of levels.
Signed-off-by: Ard Biesheuvel
---
UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 2 +
UefiCpuPkg/CpuMpPei/CpuPaging.c
Beebe
Cc: Oliver Smith-Denny
Cc: Dandan Bi
Cc: Dun Tan
Cc: Liming Gao
Cc: "Kinney, Michael D"
Cc: Michael Kubacki
Cc: Eric Dong
Cc: Rahul Kumar
Cc: Kun Qin
Ard Biesheuvel (2):
UefiCpuPkg/CpuMpPei: Print correct buffer size used for page table
UefiCpuPkg/CpuMpPei X64: Reall
On Thu, 8 Jun 2023 at 04:28, duntan wrote:
>
> Remove RO and NX protection when unset guard page.
> When UnsetGuardPage(), remove all the memory attribute protection
> for guarded page.
>
Why is it acceptable to remove NX protections here?
> Signed-off-by: Dun Tan
> Cc: Liming Gao
> Cc: Ray
> This mitigates the issue seen, however, additional investigations
> >
> > into setting the GCD attributes earlier and maintaining a better
> >
> > sync between the GCD and the page table are being done.
> >
> >
> >
> > Feedback on this proposal is g
On Wed, 7 Jun 2023 at 19:02, Rebecca Cran wrote:
>
>
> On 6/7/23 11:00, Ard Biesheuvel wrote:
> > On Wed, 7 Jun 2023 at 17:39, Rebecca Cran wrote:
> >> I've pushed it.
> >>
> >
> > Thanks! How did you manage that?
>
>
> I just rea
On Wed, 7 Jun 2023 at 17:39, Rebecca Cran wrote:
>
> I've pushed it.
>
Thanks! How did you manage that?
>
> On 6/7/23 09:09, Ard Biesheuvel wrote:
> > I found the button too, and it works as expected.
> >
> > While the ongoing CI issues are investigat
301 - 400 of 3132 matches
Mail list logo
