[edk2-devel] [PATCH V1] SecurityPkg: Fix return handling in RdRandGenerateEntropy

2022-10-26 Thread Bjorge, Erik C
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4090 The function GetRandomNumber128 returns a BOOLEAN and not EFI_STATUS. Update the code to correctly handle the BOOLEAN return type. Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Erik Bjorge --- .../PeiDxeTpmPlatformHierarchyLib.c

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v2] EdkRepo: Adding performance option

2020-10-05 Thread Bjorge, Erik C
This new option will display the execution time of a successful command. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Erik Bjorge --- edkrepo/commands/arguments/edkrepo_cmd_args.py | 3 ++-

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Add timing for commands

2020-10-02 Thread Bjorge, Erik C
Added command timing in the entry point. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Erik Bjorge --- edkrepo/edkrepo_entry_point.py | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff

Re: [edk2-devel] [RFC] Request for new git repository for EdkRepo

2020-09-30 Thread Bjorge, Erik C
as well or just creating a manifest branch in the new EdkRepo repository? Thanks, -Erik -Original Message- From: Desimone, Nathaniel L Sent: Wednesday, September 30, 2020 2:56 PM To: devel@edk2.groups.io; r...@edk2.groups.io Cc: Desimone, Ashley E ; Bjorge, Erik C Subject: [RFC] Request

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V3] EdkRepo: Return exit codes in edkrepo_entry_point.py

2020-09-28 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Nathaniel L Sent: Friday, September 25, 2020 6:35 PM To: devel@edk2.groups.io; Desimone, Ashley E Cc: Pandya, Puja ; Bret Barkelew ; Agyeman, Prince ; Bjorge, Erik C Subject: RE: [edk2-devel] [edk2-staging/EdkRepo] [PATCH

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V3 2/2] EdkRepo: Add support for subst drives

2020-09-28 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Nate DeSimone Sent: Friday, September 25, 2020 6:28 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince ; Bjorge, Erik C Subject: [edk2-staging/EdkRepo] [PATCH V3 2/2] EdkRepo: Add

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixing inconsistent win32 HOME path mapping

2020-07-29 Thread Bjorge, Erik C
In Python 3.8.x the method of mapping the users home path was changed to look at USERPROFILE and then HOMEDRIVE\HOMEPATH. This change removed the check of HOME generated by git BASH based on HOMEDRIVE/HOMEPATH. For users with a USERPROFILE environment variable that does not match the

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Continue checkout on submodule deinit errors

2020-07-22 Thread Bjorge, Erik C
In some cases submodules may still not be deinitialzied even with the more aggressive deinit flags. In these cases the checkout will report a warning and attempt to continue the checkout process. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: EdkRepo Sync Fails to Update Local Manifest

2020-06-22 Thread Bjorge, Erik C
: Desimone, Ashley E Sent: Friday, June 19, 2020 4:33 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: EdkRepo Sync Fails to Update Local Manifest Only use the new manifests

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 3/3] EdkRepo: Fix submodule failures when switching combos.

2020-06-10 Thread Bjorge, Erik C
When switching combinations or checking out pins the submodule information may change or have modifications that will cause errors. Before changing to a new combination all submodules should be removed. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 1/3] EdkRepo: Add force flag when removing submodules

2020-06-10 Thread Bjorge, Erik C
Submodules may generate un-tracked or modify files in the repo. when removing the submodule do so even with modifications. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Erik Bjorge ---

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 2/3] EdkRepo: Adding backwards compatibility for old pin files

2020-06-10 Thread Bjorge, Erik C
Older pin files used the invalid enable_submodule attribute. This has been fixed for new pin files but we need to be able to support older pin files as well. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Erik

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 0/3] Small fixes to submodule support

2020-06-10 Thread Bjorge, Erik C
Fixed issues when submodule has untracked files and can't be deinitialized. Fixed backwards compatibility issue with old pin files. Fixed issue when switching combos to handle submodule removals. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc:

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string.

2020-06-10 Thread Bjorge, Erik C
Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Erik Bjorge --- edkrepo/commands/checkout_command.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/edkrepo/commands/checkout_command.py

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/2] Small fixes to submodule support

2020-06-09 Thread Bjorge, Erik C
Fixed issues when submodule has untracked files and can't be deinitialized. Fixed backwards compatibility issue with old pin files. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Erik Bjorge (2): EdkRepo: Add force flag when

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 1/2] EdkRepo: Add force flag when removing submodules

2020-06-09 Thread Bjorge, Erik C
Submodules may generate un-tracked or modify files in the repo. when removing the submodule do so even with modifications. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Erik Bjorge ---

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 2/2] EdkRepo: Adding backwards compatibility for old pin files

2020-06-09 Thread Bjorge, Erik C
Older pin files used the invalid enable_submodule attribute. This has been fixed for new pin files but we need to be able to support older pin files as well. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Erik

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Fix argument checks in manifest-repos

2020-06-08 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Nathaniel L Sent: Monday, June 8, 2020 5:18 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince ; Bjorge, Erik C Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Fix argument

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: check for manifest-repos section in edkrepo_user.cfg

2020-06-08 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Monday, June 8, 2020 2:52 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince ; Bjorge, Erik C Subject: [edk2-devel] [edk2-staging

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missing __init__.py files

2020-05-28 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Nathaniel L Sent: Thursday, May 28, 2020 2:31 PM To: Desimone, Ashley E ; devel@edk2.groups.io Cc: Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: RE: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 0/2] Enabling selective submodule initialization

2020-05-19 Thread Bjorge, Erik C
Enabling the ability to select the submodules to be initialized and maintained via the manifest file. project_utils.submodule contains the submodule logic and also functions as a command line script. Includes code review feedback. Signed-off-by: Erik Bjorge Cc: Ashley E Desimone Cc: Nate

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 2/2] EdkRepo: Update commands to use new submodule code

2020-05-19 Thread Bjorge, Erik C
Replaced use of maintain_submodules to use new common code. This allows for selective submodule initialization via the manifest file. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Erik Bjorge ---

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 1/2] EdkRepo: Adding selective submodule init script

2020-05-19 Thread Bjorge, Erik C
Adds selective submodule support functions and command line scripting support. The existing support will be ported over to use this functionality. Signed-off-by: Erik Bjorge Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge ---

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 1/2] EdkRepo: Adding selective submodule init script

2020-05-19 Thread Bjorge, Erik C
. Thanks, -Erik -Original Message- From: Desimone, Ashley E Sent: Monday, May 18, 2020 7:51 PM To: Bjorge, Erik C ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: RE: [edk2-staging/EdkRepo] [PATCH v1 1/2] EdkRepo: Adding selective

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 2/2] EdkRepo: Update commands to use new submodule code

2020-05-18 Thread Bjorge, Erik C
: -maintain_submodules(repo_to_clone, repo, args.verbose) - Can you please double check these comments? Thanks, -Erik -Original Message- From: Desimone, Ashley E Sent: Monday, May 18, 2020 8:01 PM To: Bjorge, Erik C ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed incorrect commit template warnings

2020-05-17 Thread Bjorge, Erik C
The repo name was being passed in instead of the path the repo. This caused all commit templates to be flagged as warnings. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Erik Bjorge ---

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 2/2] EdkRepo: Update commands to use new submodule code

2020-05-16 Thread Bjorge, Erik C
Replaced use of maintain_submodules to use new common code. This allows for selective submodule initialization via the manifest file. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Erik Bjorge ---

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 1/2] EdkRepo: Adding selective submodule init script

2020-05-16 Thread Bjorge, Erik C
Adds selective submodule support functions and command line scripting support. The existing support will be ported over to use this functionality. Signed-off-by: Erik Bjorge Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge ---

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/2] Enabling selective submodule initialization

2020-05-16 Thread Bjorge, Erik C
Enabling the ability to select the submodules to be initialized and maintained via the manifest file. project_utils.submodule contains the submodule logic and also functions as a command line script Signed-off-by: Erik Bjorge Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed submodule attribute in pin files

2020-05-16 Thread Bjorge, Erik C
When creating pin files the manifest parser added the incorrect attribute to the repo source tag. This resulted in submodules always being disabled in pin files. Signed-off-by: Erik Bjorge Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Pass a ManifestXML to find_project_in_all_indices

2020-05-15 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Ashley E Sent: Friday, May 15, 2020 5:19 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Pass

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Improve clone error handling.

2020-05-15 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Ashley E Sent: Friday, May 15, 2020 4:44 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Improve

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 1/2] EdkRepo: Normalize line endings

2020-05-15 Thread Bjorge, Erik C
The file had mixed line endings. Normalized line endings to CRLF. Signed-off-by: Erik Bjorge Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge --- edkrepo_manifest_parser/edk_manifest.py | 2022 +++ 1 file

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/2] Manifest parser line ending cleanup and small bug fixes

2020-05-15 Thread Bjorge, Erik C
Manifest parser line ending cleanup and small bug fixes. - Fixed line endings so they are consistent (CRLF) - Fixed variable name bugs Signed-off-by: Erik Bjorge Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Erik Bjorge (2):

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 2/2] EdkRepo: Fixed use of incorrect variable names

2020-05-15 Thread Bjorge, Erik C
Fixed two small issues. - Fixed current combo not being updated in local data. - Fixed use of name mangled (private) variable. Signed-off-by: Erik Bjorge Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge ---

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: Update list-repos to support multiple manifest repositories

2020-05-14 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Ashley E Sent: Monday, May 11, 2020 9:20 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: Update

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo_list

2020-05-12 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Ashley E Sent: Tuesday, May 12, 2020 11:45 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Adding manifest support for submodule init

2020-05-12 Thread Bjorge, Erik C
Enabling support for selective submodule initialization in the manifest file. This will allow for more control over the submodules that are initialized. If this section is not present the existing functionality will be used. Signed-off-by: Erik Bjorge Cc: Ashley E Desimone Cc: Nate DeSimone

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/3] Manifest parser cleanup

2020-05-05 Thread Bjorge, Erik C
Nate, if you run into this issue again please let me know and I can send out a new version. Thanks, -Erik -Original Message- From: Desimone, Nathaniel L Sent: Monday, May 4, 2020 8:59 PM To: Bjorge, Erik C ; devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bret Barkelew

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 3/3] EdkRepo: Refactoring private class members

2020-04-30 Thread Bjorge, Erik C
Refactoring private variables to remove name mangling from double underscores to using single underscores. This allows for better creation of derived classes. Signed-off-by: Erik Bjorge Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman ---

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/3] Manifest parser cleanup

2020-04-30 Thread Bjorge, Erik C
General cleanup of the manifest parser and minor improvements to make the code more flexible. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Erik Bjorge (3): EdkRepo: Flake8 cleanup EdkRepo: Improve error message with invalid XML EdkRepo:

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 1/3] EdkRepo: Flake8 cleanup

2020-04-30 Thread Bjorge, Erik C
Just cleaning up the file to meet Flake8 expectations. Signed-off-by: Erik Bjorge Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo_manifest_parser/edk_manifest.py | 159 ++-- 1 file changed, 94 insertions(+), 65

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 2/3] EdkRepo: Improve error message with invalid XML

2020-04-30 Thread Bjorge, Erik C
The ETree exception contains additional information about the location of XML tag errors. Adding this information to the error message for better debugging support. Signed-off-by: Erik Bjorge Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman ---

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 5/7] EdkRepo: Add ability to find projects across all manifest repositories

2020-04-30 Thread Bjorge, Erik C
Message- From: Desimone, Nathaniel L Sent: Thursday, April 30, 2020 2:29 PM To: Desimone, Ashley E ; devel@edk2.groups.io Cc: Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: RE: [edk2-staging/EdkRepo] [PATCH 5/7] EdkRepo: Add ability to find projects across all

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fix running from source detection

2020-04-29 Thread Bjorge, Erik C
Code did not add user site packages if they were enabled. This caused edkrepo installed in the user site packages as being run from source. Signed-off-by: Erik Bjorge Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman ---

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Improve removal of content with AlwaysExclude

2020-04-21 Thread Bjorge, Erik C
The AlwaysExclude XML tag has existed but only removed entries from the list of sparse objects. Now items in the AlwaysExclude tag will be actively removed by prefixing '!' to the entry. Signed-off-by: Erik Bjorge Cc: Nate DeSimone Cc: Ashley DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc:

Re: [edk2-devel] [PATCH] EdkRepo: Fix Linux install failures

2020-04-21 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Nathaniel L Sent: Monday, April 20, 2020 8:44 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [PATCH] EdkRepo: Fix Linux install failures

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove required delimiter from edkrepo base config class

2020-04-20 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: devel@edk2.groups.io On Behalf Of Ashley E Desimone Sent: Monday, April 20, 2020 3:21 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-devel] [edk2

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 2/6] EdkRepo: Add new sections to edkrepo.cfg

2020-04-17 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Ashley E Sent: Friday, April 17, 2020 10:18 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH v2 2/6] EdkRepo

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 5/6] EdkRepo: Move edkrepo_global_data directory to BaseConfig

2020-04-17 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Ashley E Sent: Friday, April 17, 2020 10:18 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH v2 5/6] EdkRepo

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 6/6] EdkRepo: Add 'get' functions for Manifest Repo data

2020-04-17 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Ashley E Sent: Friday, April 17, 2020 10:18 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH v2 6/6] EdkRepo

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 4/6] EdkRepo: Add manifest_repo_props()

2020-04-17 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Ashley E Sent: Friday, April 17, 2020 10:18 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH v2 4/6] EdkRepo

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 3/6] EdkRepo: Add the manifest_repo_list property to BaseConfig

2020-04-17 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Ashley E Sent: Friday, April 17, 2020 10:18 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH v2 3/6] EdkRepo

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 6/6] EdkRepo: Add 'get' functions for Manifest Repo data

2020-04-17 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Ashley E Sent: Thursday, April 16, 2020 8:31 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH 6/6] EdkRepo: Add

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 3/6] EdkRepo: Add the manifest_repo_list property to BaseConfig

2020-04-17 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Ashley E Sent: Thursday, April 16, 2020 8:31 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH 3/6] EdkRepo: Add

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 1/6] EdkRepo: Support Updated CFG Format Defining Multiple Manifest Repos

2020-04-17 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Ashley E Sent: Thursday, April 16, 2020 8:31 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH 1/6] EdkRepo

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 5/6] EdkRepo: Move edkrepo_global_data directory to BaseConfig

2020-04-17 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Ashley E Sent: Thursday, April 16, 2020 8:31 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH 5/6] EdkRepo: Move

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 4/6] EdkRepo: Add manifest_repo_props()

2020-04-17 Thread Bjorge, Erik C
Why is this not a list comprehension? return [x for x in self.prop_list if manifest_repo in x.name] -Original Message- From: Desimone, Ashley E Sent: Thursday, April 16, 2020 8:31 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 2/6] EdkRepo: Add new sections to edkrepo.cfg

2020-04-17 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Ashley E Sent: Thursday, April 16, 2020 8:31 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH 2/6] EdkRepo: Add

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v2] EdkRepo: Only install packages included with the installer

2020-04-16 Thread Bjorge, Erik C
When installing packages pip may attempt to download dependencies. The installer should contain all dependencies so tell pip where to look for any dependencies. Signed-off-by: Erik Bjorge Cc: Ashley DeSimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman ---

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Only install packages included with the installer

2020-04-15 Thread Bjorge, Erik C
When installing packages pip may attempt to download dependencies. The installer should contain all dependencies so tell pip where to look for any dependencies. Signed-off-by: Erik Bjorge Cc: Ashley DeSimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman ---

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add Support for macOS

2020-04-06 Thread Bjorge, Erik C
I will take a look at removing system wide installs on Linux and we can keep these change focused on Mac support. Thanks, -Erik Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Nathaniel L Sent: Monday, April 6, 2020 2:43 PM To: Bjorge, Erik C ; devel@edk2.groups.io Cc

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add Support for macOS

2020-04-06 Thread Bjorge, Erik C
- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Monday, April 6, 2020 1:59 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Agyeman, Prince ; Bret Barkelew ; Philippe Mathieu-Daude Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Checkout command is broken

2020-04-06 Thread Bjorge, Erik C
Thanks for fixing my mistake. Reviewed-by: Erik Bjorge -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Friday, April 3, 2020 4:27 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Agyeman, Prince ; Bret Barkelew

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/7] Adding support for archiving branch combos

2020-04-02 Thread Bjorge, Erik C
I will fix it next time. -Erik -Original Message- From: Desimone, Nathaniel L Sent: Wednesday, April 1, 2020 10:59 PM To: devel@edk2.groups.io; Bjorge, Erik C Cc: Desimone, Ashley E ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: RE: [edk2-devel] [edk2-staging/EdkRepo

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically

2020-03-31 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Nathaniel L Sent: Friday, March 27, 2020 1:31 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Philippe Mathieu-Daudé Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Improve state tracking when checking out pin files

2020-03-31 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: devel@edk2.groups.io On Behalf Of Desimone, Ashley E Sent: Tuesday, March 31, 2020 2:00 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-devel

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 7/7] EdkRepo: Update List Repos for archived combos

2020-03-31 Thread Bjorge, Erik C
When running the List Repos command archived combos will not be listed unless the archived flag is provided. Signed-off-by: Erik Bjorge Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/commands/list_repos_command.py | 37 ++ 1 file

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 5/7] EdkRepo: Update Checkout Pin for archived combos

2020-03-31 Thread Bjorge, Erik C
Added support for archived combos in the Checkout Pin command. Signed-off-by: Erik Bjorge Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/commands/checkout_pin_command.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 3/7] EdkRepo: Update Checkout for archived combos

2020-03-31 Thread Bjorge, Erik C
Now either an active or archived branch combination can be checked out. Signed-off-by: Erik Bjorge Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/common/common_repo_functions.py | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 2/7] EdkRepo: Added ability to display archived combinations

2020-03-31 Thread Bjorge, Erik C
Added support for using the -a / --archived flags to include archived combinations. Signed-off-by: Erik Bjorge Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/commands/arguments/combo_args.py | 5 +++-- edkrepo/commands/combo_command.py| 19

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 4/7] EdkRepo: Update Sync for archived combos

2020-03-31 Thread Bjorge, Erik C
Added support for archived combos in Sync command. Signed-off-by: Erik Bjorge Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/commands/sync_command.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 6/7] EdkRepo: Update clone for archived combos

2020-03-31 Thread Bjorge, Erik C
Adding support for archived combos in the clone command. Signed-off-by: Erik Bjorge Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/commands/clone_command.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 1/7] EdkRepo: Adding support for archiving combos

2020-03-31 Thread Bjorge, Erik C
Adding support to check the archived attribute on branch combos. This allows a combo to be archived and available if required but not dirty up the combo list. Signed-off-by: Erik Bjorge Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman ---

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/7] Adding support for archiving branch combos

2020-03-31 Thread Bjorge, Erik C
Adding the ability to mark a branch combination as archived. This will remove it from the list of valid combinations by default. It should not limit users from accessing the branch combination. The archive flag will allow users to list archived branch combinations in the combo command. Erik

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missing import definition

2020-03-26 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Ashley E Sent: Thursday, March 26, 2020 2:26 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 4/4] EdkRepo: Update 3rd party packages in installer config

2020-03-19 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Nathaniel L Sent: Wednesday, March 18, 2020 8:17 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew Subject: [edk2-staging/EdkRepo] [PATCH 4/4] EdkRepo: Update 3rd party

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures

2020-03-18 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Ashley E Sent: Wednesday, March 18, 2020 12:43 PM To: Desimone, Nathaniel L ; devel@edk2.groups.io Cc: Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew Subject: RE: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug

[edk2-devel] [edk2-staging/EdkRepo][PATCH v1] EdkRepo: Fixed execution of final_copy.py

2020-01-22 Thread Bjorge, Erik C
On Ubuntu the script final_copy.py was not able to run without prepending ./ to the script name. Signed-off-by: Erik Bjorge Cc: Nate DeSimone Cc: Ashley DeSimone Cc: Puja Pandya Cc: Bret Barkelew --- build-scripts/build_linux_installer.py | 2 +- 1 file changed, 1 insertion(+), 1

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove unused string

2020-01-16 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Thursday, January 16, 2020 4:47 PM To: Desimone, Ashley E ; devel@edk2.groups.io Cc: Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew Subject: Re: [edk2-devel] [edk2-staging/EdkRepo

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: build_linux_installer.py path fixes

2020-01-10 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Nathaniel L Sent: Thursday, January 9, 2020 5:04 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Philippe Mathieu-Daudé Subject: [edk2-staging/EdkRepo] [PATCH V2

Re: [edk2-devel] [PATCH v2 025/105] .mailmap: Add an entry for Erik Bjorge

2019-12-06 Thread Bjorge, Erik C
Looks good to me. Reviewed-by: Erik Bjorge -Original Message- From: Philippe Mathieu-Daude Sent: Friday, December 6, 2019 3:25 AM To: devel@edk2.groups.io Cc: Philippe Mathieu-Daude ; Bjorge, Erik C Subject: [PATCH v2 025/105] .mailmap: Add an entry for Erik Bjorge We use .mailmap