Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Yuwei Chen
Sent: Tuesday, July 14, 2020 1:31 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] [Patch v4] BaseTools: Add Guid name support in GenFfs.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id
modified the format without fuctional change.
Signed-off-by: Yuwei Chen
Cc: Bob Feng
Cc: Liming Gao
---
.../Source/Python/AutoGen/WorkspaceAutoGen.py | 24 +++
BaseTools/Source/Python/Common/GlobalData.py | 1 +
BaseTools/Source/Python/GenFds/FdfParser.py | 14
: I29b52663613286c6210d99eaaa09338677a21b31
Signed-off-by: Yuwei Chen
Cc: Bob Feng
Cc: Liming Gao
---
.../Source/Python/AutoGen/WorkspaceAutoGen.py | 24 +++
BaseTools/Source/Python/Common/GlobalData.py | 1 +
BaseTools/Source/Python/GenFds/FdfParser.py | 14 ++-
3 files changed, 38
Reviewed-by: Bob Feng
-Original Message-
From: Kinney, Michael D
Sent: Saturday, July 11, 2020 10:09 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Sean Brogan ; Bret Barkelew
; Yao, Jiewen
Subject: [Patch v3 01/16] BaseTools/Python: Allow HOST_APPLICATION to use NULL
Reviewed-by: Bob Feng
-Original Message-
From: Kinney, Michael D
Sent: Thursday, July 9, 2020 12:05 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Sean Brogan ; Bret Barkelew
; Yao, Jiewen
Subject: [Patch v2 01/16] BaseTools/Python: Allow HOST_APPLICATION to use NULL
suggested by Bob.)
Leif Lindholm (2):
BaseTools/PatchCheck.py: add exception for diff orderfile
BaseTools: explicitly import email.header PatchCheck.py
Cc: Bob Feng
Cc: Liming Gao
BaseTools/Scripts/PatchCheck.py | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
--
2.20.1
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Leif Lindholm
Sent: Thursday, July 2, 2020 11:40 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [edk2-devel] [PATCH 1/2] BaseTools/PatchCheck.py: add exception for
diff orderfile
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Leif Lindholm
Sent: Thursday, July 2, 2020 11:40 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [edk2-devel] [PATCH 2/2] BaseTools: explicitly import email.header
PatchCheck.py
On
Merged.
-Original Message-
From: PierreGondois
Sent: Wednesday, July 1, 2020 10:06 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois ; sami.muja...@arm.com;
tomas.pi...@arm.com; Feng, Bob C ; Gao, Liming
; n...@arm.com
Subject: [PATCH v5 0/5] Compile AML bytecode array into OBJ file
Foll
Reviewed-by: Bob Feng
-Original Message-
From: PierreGondois
Sent: Wednesday, July 1, 2020 10:06 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois ; sami.muja...@arm.com;
tomas.pi...@arm.com; Feng, Bob C ; Gao, Liming
; n...@arm.com
Subject: [PATCH v5 1/5] BaseTools: PatchCheck: Exclude
BinWrappers/PosixLike/AmlToC script
have been modified to CRLF when I sent the patch. I created a pull request from
the linked github branch noted in the patches. It is available at
https://github.com/PierreARM/edk2/commits/803_Compile_AML_bytecode_array_into_OBJ_file_v3
. The pull request is
.com/PierreARM/edk2/commits/803_Compile_AML_bytecode_array_into_OBJ_file_v3
. The pull request is available here (to show the result of the CI tests)
https://github.com/tianocore/edk2/pull/729 .
Do you want a v4 or is it possible to pull the patches from the github
repository?
Sorry for the inco
Regards,
Pierre
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng via
groups.io
Sent: 24 June 2020 16:16
To: devel@edk2.groups.io; Pierre Gondois
Cc: Sami Mujawar ; Tomas Pilar ;
Gao, Liming ; nd
Subject: Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into OBJ
inconvenience.
Regards,
Pierre
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng via
groups.io
Sent: 24 June 2020 16:16
To: devel@edk2.groups.io; Pierre Gondois
Cc: Sami Mujawar ; Tomas Pilar ;
Gao, Liming ; nd
Subject: Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode
Hi Pierre,
There are some build failed in OpenCI. Would you please check it?
https://github.com/tianocore/edk2/pull/727
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
Sent: Wednesday, June 24, 2020 5:09 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois
Hi Pierre,
The commit message should not have more than one Signed-off-by.
Use of Suggested-by may be more appropriate here.
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
Sent: Thursday, June 18, 2020 10:27 PM
To: devel@edk2.groups.io
Cc: Pierre G
Hi Pierre,
The commit message should not have more than one Signed-off-by.
Use of Suggested-by may be more appropriate here.
Thanks,
Bob
-Original Message-
From: PierreGondois
Sent: Thursday, June 18, 2020 10:27 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois ; sami.muja...@arm.com;
t
Reviewed-by: Bob Feng
Thanks,
Bob
-Original Message-
From: Abner Chang
Sent: Thursday, June 18, 2020 9:00 AM
To: devel@edk2.groups.io
Cc: abner.ch...@hpe.com; Feng, Bob C ; Gao, Liming
; Daniel Schaefer ; Leif
Lindholm
Subject: [BaseTools PATCH v2] BaseTools: Add external
Hi Pierre,
This patch set looks good to me.
Reviewed-by: Bob Feng
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
Sent: Thursday, June 18, 2020 10:27 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois ; sami.muja...@arm.com;
tomas.pi...@arm.com; Feng
Hi Pierre,
Yes. It's fine for me.
Thanks,
Bob
-Original Message-
From: Pierre Gondois
Sent: Monday, June 15, 2020 11:58 PM
To: Feng, Bob C ; devel@edk2.groups.io
Cc: Gao, Liming ; Sami Mujawar ;
Tomas Pilar ; nd
Subject: RE: [edk2-devel] [PATCH v1 1/3] BaseTools: Generate multiple
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel
Sent: Tuesday, June 9, 2020 1:34 AM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Feng, Bob C
; Gao, Liming ; Laszlo Ersek
; Leif Lindholm ; Ilias Apalodimas
; Julien Grall ; Yao, Jiewen
Reviewed-by: Bob Feng
-Original Message-
From: Gao, Liming
Sent: Tuesday, June 9, 2020 4:17 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C
Subject: [Patch] BaseTools GenFv: Report the correct spare FV image size
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2790
If the top FFS is
Hi Pierre,
I found there is an incorrect target generated in the OvmfPkg/AcpiTables
Makefile when I tried to build Ovmf. That incorrect target causes ovmf to build
failed.
$(DEBUG_DIR)\PlatformAcpiTables : $(MAKE_FILE)
$(DEBUG_DIR)\PlatformAcpiTables : $(STATIC_LIBRARY_FILES)
$(DEBUG_DIR)\Plat
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Yuwei
Sent: Monday, June 1, 2020 2:40 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [PATCH 1/1] BaseTools: Warn user the file not found issue instead of
break build.
From: Bob Feng
REF: https
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Irene Park
Sent: Wednesday, June 3, 2020 5:59 AM
To: devel@edk2.groups.io
Cc: Irene Park
Subject: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoGen
error occurred
From: Irene Park
My comments are inline marked as [Bob].
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
Sent: Monday, May 18, 2020 10:11 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois ; Feng, Bob C
; Gao, Liming ;
sami.muja...@arm.com; tomas.pi...@arm.com; n...@arm
Hi Pierre,
I agree with your solution. My comments are in the 1/3 patch mail.
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
Sent: Thursday, May 28, 2020 7:04 PM
To: devel@edk2.groups.io; Pierre Gondois
Cc: Feng, Bob C ; Gao, Liming ;
Sami Mujawa
Irene,
This patch looks good. For the subject, I think it's that the build will exit
with 1 when the AutoGen error occurred.
Would you update the subject to make it more clear?
With the subject update,
Reivewed-by: Bob Feng
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.i
happens, the build tool will hang.
Thanks,
Bob
-Original Message-
From: Irene Park
Sent: Friday, May 29, 2020 3:24 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: RE: [PATCH] BaseTools/Python: Add missing FatalError handling
A gentle reminder and adding Bob Feng and
Hi Pierre,
Sorry for late response. I'll review the patch in this week and response early
in the next week.
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
Sent: Thursday, May 28, 2020 7:04 PM
To: devel@edk2.groups.io; Pierre Gondois
Cc: Feng, Bob
l debugging we must
reuse an existing empty section, or add a new section header.
If there is not space to add a new section header append to the last section.
The resource entry if found via a directory entry so the PE/COFF loading code
does not depend on the section type.
Signed-off-by: Andrew
Andrew,
Would you please update the BZ status to IN_PROGRESS? And paste the patch
review link to the comments?
Reviewed-by: Bob Feng
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of Andrew Fish via
groups.io
Sent: Monday, May 25, 2020 10:38 AM
To: devel@edk2
in the BZ either in this case
> so I have done that and closed the BZ.
Thanks for this.
>
> Thanks,
> Michael
>
>
> On 5/14/2020 12:37 AM, Philippe Mathieu-Daudé wrote:
>> +Michael & Laszlo.
>>
>> On 5/13/20 4:15 AM, Bob Feng wrote:
>>>
Reviewed-by: Bob Feng
-Original Message-
From: Feng, YunhuaX
Sent: Saturday, May 9, 2020 8:15 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [PATCH v2] BaseTools: Fix parse PCD GUID expression issue
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2686
The
Reviewed-by: Bob Feng
-Original Message-
From: michael.kuba...@outlook.com
Sent: Saturday, May 9, 2020 10:23 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [PATCH v1 1/1] BaseTools/Ecc: Replace deprecated function time.clock()
From: Michael Kubacki
REF:https
This patch looks fine.
Reviewed-by: Bob Feng
-Original Message-
From: Feng, YunhuaX
Sent: Saturday, May 9, 2020 5:34 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [PATCH] BaseTools: Fix binary file not generate map file issue
REF: https://bugzilla.tianocore.org
ussed this in the bug scrub yesterday.
We think there may be a simpler way to address this issue without extending the
INF syntax.
It is our understanding that the ASL files need to be processed before C files
when both are present in an INF.
This is similar to the requirement that UNI files be proc
This patch looks good for me.
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Laszlo Ersek
Sent: Thursday, May 7, 2020 12:36 AM
To: Feng, Bob C ; Gao, Liming
Cc: devel@edk2.groups.io; l...@nuviainc.com; rebe...@bsdio.com
Subject: Re: [edk2-devel
Reviewed-by: Bob Feng
-Original Message-
From: Leif Lindholm
Sent: Thursday, April 30, 2020 12:36 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [PATCH 1/3] BaseTools: add handling for 'S:' flag to GetMaintainer.py
GetMaintainer.py already extracts th
Hi Laszlo,
Thanks for the reminder, I'll be more careful about the patch review.
Since this patch set early version cause build failure, my focus was mainly on
the code.
Thanks,
Bob
-Original Message-
From: Laszlo Ersek
Sent: Wednesday, April 29, 2020 6:15 PM
To: abner.ch...@hpe.com
ject has no attribute 'header'
> >
> > When using python3, this backtrace does not appear.
> >
> > Explicitly importing decode_header resolves this for python2 and
> > does not appear to cause any issues with python3.
> >
> > Cc: Bob Feng
&g
Hi Abner,
These errors are reported from our CI system. I re-triggered the CI build, all
errors disappeared.
For this patch set,
Reviewed-by: Bob Feng
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng
Sent: Friday, April 24, 2020 5:24 PM
To: Abner
evel@edk2.groups.io
Cc: abner.ch...@hpe.com; Gilbert Chen ; Daniel Helmut
Schaefer ; Leif Lindholm ;
Feng, Bob C ; Gao, Liming
Subject: [PATCH v4 3/3] BaseTools: BaseTools changes for RISC-V platform.
Tools definitions template file changes for building EDK2 RISC-V platform.
Signed-off
anks,
Mike
> -Original Message-----
> From: devel@edk2.groups.io On Behalf Of Bob
> Feng
> Sent: Wednesday, April 1, 2020 1:53 AM
> To: devel@edk2.groups.io; pierre.gond...@arm.com; Sami Mujawar
> ; Gao, Liming
> Cc: nd
> Subject: Re: [edk2-devel] [PATCH v1 1/1] I
tform.
>
> Tools definitions template file changes for building EDK2 RISC-V platform.
>
> Signed-off-by: Abner Chang
> Co-authored-by: Gilbert Chen
> Co-authored-by: Daniel Helmut Schaefer
> Reviewed-by: Leif Lindholm
>
> Cc: Bob Feng
> Cc: Liming Gao
> Cc:
A typo in the Readme.md. Others are fine for me.
**:+The old PACKAGES_PATH will be replaced by new one.s
After fix that typo,
Reviewed-by: Bob Feng
-Original Message-
From: Luo, Heng
Sent: Friday, April 10, 2020 9:06 AM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Dong, Eric ; Gao, Liming
Reviewed-by: Bob Feng
-Original Message-
From: Fan, ZhijuX
Sent: Monday, April 13, 2020 11:04 AM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C ;
Fan, ZhijuX
Subject: [PATCH V4] BaseTools:Add the spare space FV image size checker
REF:https://bugzilla.tianocore.org
Hi Sean,
That the Basetools works correctly depends on the PACAKGES_PATH is set
correctly. I think this patch provides common function and provides assistance
for the Basetools.
Thanks,
Bob
From: Ni, Ray
Sent: Tuesday, April 7, 2020 10:16 AM
To: devel@edk2.groups.io; sean.bro...@microsoft.com;
Reviewed-by: Bob Feng
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#56967): https://edk2.groups.io/g/devel/message/56967
Mute This Topic: https://groups.io/mt/72558135/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https
This change is good to me.
Reviewed-by: Bob C Feng
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Michael
Kubacki
Sent: Friday, April 3, 2020 1:05 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [edk2-devel] [PATCH v1 1/1] Ba
Hi Pierre,
I will review the spec and code change in this week.
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
PierreGondois
Sent: Monday, March 30, 2020 11:52 PM
To: devel@edk2.groups.io; Sami Mujawar ; Feng, Bob C
; Gao, Liming
C
Reviewed-by: Bob Feng
-Original Message-
From: Fan, ZhijuX
Sent: Thursday, March 26, 2020 5:48 PM
To: devel@edk2.groups.io
Cc: Fan, ZhijuX ; Gao, Liming ;
Feng, Bob C
Subject: [PATCH V6] BaseTools:GuidedSectionTools.txt is not generated correctly
REF:https://bugzilla.tianocore.org
s.txt.
>
> Signed-off-by: Zhiju.Fan
> Cc: Liming Gao
> Cc: Bob Feng
> ---
>
> A judgment condition was removed
> if self.Workspace.ToolDef.ToolsDefTxtDictionary.get(Def):
>
> BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 3 ++-
> BaseTools/Source/Python/bui
TargetTool is to print, modify and clean the target.txt
content. This tool is not used anymore.
Signed-off-by: Bob Feng
Cc: Liming Gao
---
BaseTools/BinWrappers/PosixLike/TargetTool| 14 -
.../BinWrappers/WindowsLike/TargetTool.bat| 3 -
.../Source/Python/TargetTool/TargetTool.py
The TargetTool is used to print, modify and clean
the content of Conf/Target.txt. But the modify function
has not worked for long time, I believe there is no
use this tool anymore. I propose to drop this tool.
Bob Feng (1):
BaseTools: Drop the TargetTool
BaseTools/BinWrappers/PosixLike
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2624
The .map file may not exist, adding .map as a target
with empty dependency and command will avoid build failure.
Signed-off-by: Bob Feng
Cc: Liming Gao
Cc: Bret Barkelew
---
BaseTools/Source/Python/AutoGen/GenMake.py | 1 +
1 file
Reviewed-by: Bob Feng
-Original Message-
From: Fan, ZhijuX
Sent: Monday, December 2, 2019 11:51 AM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C
Subject: [PATCH V2] BaseTools:fix issue for decode the stdout/stderr byte arrays
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id
Reviewed-by: : Bob Feng
-Original Message-
From: Fan, ZhijuX
Sent: Friday, March 20, 2020 11:58 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Fan, ZhijuX
Subject: [PATCH 1/1] BaseTools:Fix build tools print traceback info issue
REF: https://bugzilla.tianocore.org
error messages are
shown.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 3 ---
1 file changed, 3 deletions(-)
diff --git a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
b/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
I agree with Mike.
No need to change BaseTools.
Thanks,
Bob
-Original Message-
From: Gao, Liming
Sent: Friday, March 20, 2020 11:28 AM
To: Kinney, Michael D ; Chang, Abner (HPS SW/FW
Technologist) ; devel@edk2.groups.io; Ni, Ray
; Feng, Bob C
Cc: Leif Lindholm ; Chen, Gilbert ;
Sch
Hi Kondal ,
I agree the coding guidelines and tools can help improve the python code
quality, but I think these guidelines in this spec are too general for
BaseTools. Besides the coding style, BaseTools has many specific code issues,
such as the high coupling between modules, not clear module
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Zhang,
Shenglei
Sent: Monday, March 9, 2020 2:32 PM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Wang, Jian J ;
Wu, Hao A ; Feng, Bob C
Subject: [edk2-devel] [PATCH v2 0/2] Use
Reviewed-by: Bob Feng
-Original Message-
From: Fu, Siyuan
Sent: Wednesday, March 11, 2020 5:34 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [Patch] Silicon/Intel/Tools: Add parameter for microcode alignment in
FitGen.
The current FitGen has "-NA" pa
Reviewed-by: Bob Feng
-Original Message-
From: Fan, ZhijuX
Sent: Wednesday, March 11, 2020 5:51 PM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C ;
Fan, ZhijuX
Subject: [PATCH V4] BaseTools:copy the common PcdValueCommon.c to output
directory
REF:https
Laszlo,
I found this is the last one issue. I created a patch
https://edk2.groups.io/g/devel/message/55708. Please review.
Thanks,
Bob
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Sunday, March 8, 2020 5:00 PM
To: Feng, Bob C ; devel@edk2.groups.io;
ard.bies
ed
OvmfPkg\LinuxInitrdDynamicShellCommand\LinuxInitrdDynamicShellCommand.c(199):
warning C4244: '=': conversion from 'UINT64' to 'UINTN',
possible loss of data
This patch is to cast UINT64 type to UINTN type
when doing the variable assignment.
Signed-off-by: Bob Fe
GuidedSectionTools.txt.
Signed-off-by: Zhiju.Fan
Cc: Liming Gao
Cc: Bob Feng
---
Changed an issue with an incorrect full path in GuidedSectionTools
BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 4 +++-
BaseTools/Source/Python/build/build.py | 3 ++-
2 files changed, 5 insertions(+), 2
Hi Ard,
With this patch, Ovmf still build failed on windows with VS2017. The error
message like below:
Building ...
d:\edk2maintain\edk2\MdeModulePkg\Universal\Metronome\Metronome.inf [IA32]
d:\edk2maintain\edk2\OvmfPkg\LinuxInitrdDynamicShellCommand\LinuxInitrdDynamicShellCommand.c(199):
erro
Hi Ard,
I found this patch set cause Ovmf platform build failure on windows with
VS2017.
The error message is as following:
Generating code
d:\edk2\OvmfPkg\QemuKernelLoaderFsDxe\QemuKernelLoaderFsDxe.c(130): error
C2220: warning treated as error - no 'object' file generated
d:\edk2\OvmfPkg\Qe
; Kinney, Michael D ;
Pierre Gondois
Subject: RE: [edk2-devel] [Patch] BaseTools: Remove invalid leading space
before !INCLUDE in Makefile
Reviewed-by: Liming Gao
Tested-by: Liming Gao -Original Message-
> From: devel@edk2.groups.io On Behalf Of Bob
> Feng
> Sent: Thursday, Fe
Laszlo, I agree BZ status should be update in time. You do a very good
practices about that. I need to learn from you. And thank you that you have
done a lot on BZ maintenance for me and other assignees.
I think we need have a document to record these good practices on BZ
maintenance so that p
.groups.io; Pierre Gondois
Subject: Re: [edk2-devel] [Patch 1/1][edk2-stable202002]BaseTools: Fixed a
regression issue in Makefile for incremental build
On 02/27/20 10:47, Bob Feng wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2563
>
> This patch is to fix a increame
is no impact on the clean build.
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Pierre Gondois
Signed-off-by: Bob Feng
Acked-by: Laszlo Ersek
---
V2:
1. update the subject
2. remove the Reviewed-by and tested-by
.../Source/Python/AutoGen/IncludesAuto
is no impact on the clean build.
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Pierre Gondois
Signed-off-by: Bob Feng
Reviewed-by: Liming Gao
Tested-by: Liming Gao
---
.../Source/Python/AutoGen/IncludesAutoGen.py | 16
1 file changed, 8 i
Reviewed-by: Bob Feng
-Original Message-
From: Gao, Liming
Sent: Friday, February 14, 2020 3:51 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Lohr, Paul A
Subject: [edk2-platform][patch] FitGen: Add FIT spec revision in FitGen tool
help message
BZ: https://bugzilla.tianocore.org
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Fan, ZhijuX
Sent: Wednesday, February 12, 2020 5:59 PM
To: devel@edk2.groups.io
Cc: Fan, ZhijuX ; Gao, Liming ;
Feng, Bob C
Subject: [edk2-devel] [Patch 1/1] BaseTools:build failure in CLANGPDB tool chain
Reviewed-by: Bob Feng < bob.c.f...@intel.com >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#54274): https://edk2.groups.io/g/devel/message/54274
Mute This Topic: https://groups.io/mt/69769091/21656
Group Owner: devel+ow..
Reviewed-by: Bob C Feng
-Original Message-
From: Fan, ZhijuX
Sent: Wednesday, February 12, 2020 3:14 PM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C
Subject: [Patch] BaseTools: Fixed build failure when using python38
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2304
Pushed.
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng
Sent: Wednesday, February 12, 2020 10:07 AM
To: devel@edk2.groups.io; pierre.gond...@arm.com
Cc: Gao, Liming ; sami.muja...@arm.com; n...@arm.com
Subject: Re: [edk2-devel] [PATCH v4 0/2] BaseTools: Rationalise
This patch set is good to me.
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
Sent: Monday, February 10, 2020 6:49 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois ; Feng, Bob C
; Gao, Liming ;
sami.muja...@arm.com; pierre.gond...@arm.com
Hi Pierre,
Thanks for updating the patch. I’ll trigger Intel internal CI to test this
patch.
BTW, Since edk2 soft-freeze is coming, do you require this patch to be
committed in this stable tag?
Thanks,
Bob
From: PierreGondois [mailto:pierre.gond...@arm.com]
Sent: Monday, February 10, 2020 9:2
The .map file is not update to FFS_OUTPUT_DIR folder
in the incremental build.
Signed-off-by: Guo Dong
Signed-off-by: Bob Feng
Cc: Liming Gao
---
BaseTools/Source/Python/AutoGen/GenMake.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/AutoGen
From: Bob Feng
The .map file is not update to FFS_OUTPUT_DIR folder
in the incremental build.
Signed-off-by: Guo Dong
Signed-off-by: Bob Feng
Cc: Liming Gao
---
BaseTools/Source/Python/AutoGen/GenMake.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source
Hi Pierre,
This patch cause UefiCpuPkg build fail.
build -p UefiCpuPkg\UefiCpuPkg.dsc -a IA32 -t VS2015x86
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
Sent: Thursday, February 6, 2020 11:52 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois ; Feng, B
Reviewed-by: Bob Feng
-Original Message-
From: Kinney, Michael D
Sent: Friday, February 7, 2020 7:07 AM
To: devel@edk2.groups.io
Cc: Sean Brogan ; Feng, Bob C
; Gao, Liming
Subject: [Patch 1/4] BaseTools/Build: Do not use Common.lib in Structured PCD
app
https
Reviewed-by: Bob Feng
-Original Message-
From: Kinney, Michael D
Sent: Friday, February 7, 2020 7:07 AM
To: devel@edk2.groups.io
Cc: Sean Brogan ; Feng, Bob C
; Gao, Liming
Subject: [Patch 3/4] BaseTools/WindowsVsToolChain: Setup VS2017/VS2019 env
From: Sean Brogan
https
Reviewed-by: Bob Feng
-Original Message-
From: Kinney, Michael D
Sent: Friday, February 7, 2020 7:07 AM
To: devel@edk2.groups.io
Cc: Sean Brogan ; Feng, Bob C
; Gao, Liming
Subject: [Patch 4/4] BaseTools/WindowsVsToolChain: Clean up Python source
formatting
From: Sean Brogan
https
Reviewed-by: Bob Feng
-Original Message-
From: Gao, Liming
Sent: Wednesday, February 5, 2020 10:32 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C
Subject: [edk2-platform] FitGen: Support FV with the extension header
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2086
To find
Reviewed-by: Bob Feng
-Original Message-
From: Kinney, Michael D
Sent: Friday, February 7, 2020 7:07 AM
To: devel@edk2.groups.io
Cc: Sean Brogan ; Feng, Bob C
; Gao, Liming
Subject: [Patch 2/4] BaseTools/PcdValueCommon: Fix 64-bit host compiler error
From: Sean Brogan
https
Acked-by: Bob Feng
-Original Message-
From: Kinney, Michael D
Sent: Friday, January 24, 2020 10:10 AM
To: devel@edk2.groups.io
Cc: Sean Brogan ; Bret Barkelew
; Feng, Bob C ; Gao, Liming
Subject: [Patch 02/11] BaseTools/Plugin: Add HostBasedUnitTestRunner plugin
Add plugin to
Pushed.
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng
Sent: Thursday, February 6, 2020 6:09 PM
To: devel@edk2.groups.io; pierre.gond...@arm.com
Cc: ard.biesheu...@linaro.org; Gao, Liming ;
sami.muja...@arm.com; n...@arm.com
Subject: Re: [edk2-devel] [PATCH v4 1/1
Pushed.
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng
Sent: Wednesday, February 5, 2020 9:47 PM
To: Philippe Mathieu-Daude ; devel@edk2.groups.io
Cc: Gao, Liming
Subject: Re: [edk2-devel] [PATCH 0/3] BaseTools/Scripts: .mailmap improvements
This patch set looks
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
Sent: Wednesday, February 5, 2020 10:52 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois ; ard.biesheu...@linaro.org; Feng,
Bob C ; Gao, Liming ;
sami.muja...@arm.com; n...@arm.com
Subject
Reviewed-by: Bob Feng
-Original Message-
From: Gao, Liming
Sent: Wednesday, February 5, 2020 10:06 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Oram, Isaac W
Subject: [edk2-platform][patch v3] FitGen: Fix the issue to run in X64 linux
machine
BZ: https://bugzilla.tianocore.org
Reviewed-by: Bob Feng
-Original Message-
From: Gao, Liming
Sent: Tuesday, February 4, 2020 12:55 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C
Subject: [Patch] BaseTools tools_def.template: Add back -fno-pie option in
GCC49 tool chain
BZ: https://bugzilla.tianocore.org/show_bug.cgi
This patch set looks good to me.
Reviewed-by: Bob Feng
-Original Message-
From: Philippe Mathieu-Daude [mailto:phi...@redhat.com]
Sent: Wednesday, February 5, 2020 6:49 AM
To: devel@edk2.groups.io
Cc: Philippe Mathieu-Daude ; Feng, Bob C
; Gao, Liming
Subject: [PATCH 0/3] BaseTools
Hi Pierre,
This patch looks good to me.
Is there a Bugzilla for this patch? And will you send the patch for INF spec?
There may be a typo in the log message:
[Sources]
FileName1.X
FileName2.Y : FileName1.X
FileName3.Z : FileName1.X FileName3.Z# here the FileName3.Z should be
FileNam
I think INFO or DEBUG would be better. I think some project may care about the
warning message and try to resolve it, but actually it's no need to resolve.
-Original Message-
From: Pierre Gondois
Sent: Tuesday, February 4, 2020 11:53 PM
To: Pierre Gondois ; devel@edk2.groups.io
Cc: ard.
Hi Pierre,
I agree with this change.
But for this patch, I found there are two bugs.
1.
+# Get Makefile name.
+def getMakefileName(self):
+if not self._FileType:
+return _DEFAULT_FILE_NAME_
Should be self. _DEFAULT_FILE_NAME_
+else:
+return s
Hi Liming,
Would you add more description for this patch?
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming Gao
Sent: Thursday, January 16, 2020 3:11 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W
Subject: [edk2-devel] [edk2-platf
301 - 400 of 797 matches
Mail list logo
