Re: [edk2-devel] [edk2][PATCH V2] BaseTools:Enable the /MP option of MSVC compiler

2019-04-12 Thread BobCF
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Wednesday, April 10, 2019 4:51 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH V2] BaseTools:Enable the /MP option of MSVC compiler BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1672

[edk2-devel] [Patch V2] BaseTools: Add a build option to treat DynPcd as DynExPcd

2019-04-11 Thread BobCF
From: BobCF BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1688 In order to support binary build, build tool add a flag to convert type of Dynamic Pcd to DynamicEx Pcd User can append -D PCD_DYNAMIC_AS_DYNAMICEX to build command to enable this function. Also, user can add

Re: [edk2-devel] [edk2][PATCH V2] BaseTools:Enable the /MP option of MSVC compiler

2019-04-10 Thread BobCF
I also added the incremental build performance data in BZ https://bugzilla.tianocore.org/show_bug.cgi?id=1672 -Bob -Original Message- From: Fan, ZhijuX Sent: Wednesday, April 10, 2019 4:51 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH V2]

Re: [edk2-devel] [PATCH] BaseTools: Hash false success with back to back builds

2019-04-10 Thread BobCF
The patch looks good for me. Reviewed-by: Bob Feng -Bob -Original Message- From: Rodriguez, Christian Sent: Wednesday, April 10, 2019 11:27 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [PATCH] BaseTools: Hash false success with back to back

[edk2-devel] [Patch] BaseTools: Add a build option to treat DynPcd as DynExPcd

2019-04-09 Thread BobCF
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1688 In order to support binary build, build tool add a flag to convert type of Dynamic Pcd to DynamicEx Pcd User can append -D PCD_DYNAMIC_AS_DYNAMICEX to build command to enable this function. Contributed-under: TianoCore Contribution

Re: [edk2-devel] [Patch V2 4/4] BaseTools: Fix corner-cases of --hash feature

2019-04-08 Thread BobCF
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Christian Rodriguez Sent: Friday, April 5, 2019 12:04 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [edk2-devel] [Patch V2 4/4]

Re: [edk2-devel] [Patch V2 1/4] BaseTools: Fix corner-cases of --hash feature

2019-04-08 Thread BobCF
Reviewed-by: Bob Feng -Original Message- From: Rodriguez, Christian Sent: Friday, April 5, 2019 12:04 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [Patch V2 1/4] BaseTools: Fix corner-cases of --hash feature BZ:

Re: [edk2-devel] [Patch V2 3/4] BaseTools: Fix corner-cases of --hash feature

2019-04-08 Thread BobCF
Reviewed-by: Bob Feng -Original Message- From: Rodriguez, Christian Sent: Friday, April 5, 2019 12:04 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [Patch V2 3/4] BaseTools: Fix corner-cases of --hash feature BZ:

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

2019-04-07 Thread BobCF
For BaseTools, Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Michael D Kinney Sent: Thursday, April 4, 2019 7:42 AM To: devel@edk2.groups.io; Kinney, Michael D Subject: [edk2-devel] [edk2] [PATCH V3] Change EDK II to