Re: [edk2-devel] [EXTERNAL] [Patch 12/12] UnitTestFrameworkPkg: Update YAML to ignore specific ECC files/errors

Reviewed-by: Bret Barkelew - Bret From: Michael D Kinney<mailto:michael.d.kin...@intel.com> Sent: Tuesday, November 23, 2021 1:21 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: Sean Brogan<mailto:sean.bro...@microsoft.com>; Bret Barkelew<mailto:bret.b

[edk2-devel] [PATCH v3 13/14] StandaloneMmPkg: Add StandaloneMmCoreEntryNull to satisfy CI on all archs

From: Bret Barkelew In order to separate this libary into architecture-specific versions, first create a NULL implementation that can pass CI on any arch. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Cc: Sean Brogan Signed-off-by: Bret Barkelew

[edk2-devel] [PATCH v3 14/14] ArmPkg: Create an Arm-specific version of StandaloneMmCoreEntryPoint

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar

[edk2-devel] [PATCH v3 12/14] ArmPkg: Move the StandaloneMmCpu driver to ArmPkg

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar

[edk2-devel] [PATCH v3 11/14] StandaloneMmPkg: Switch to the MmuLib abstraction

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Cc: Sean Brogan Signed-off-by: Bret Barkelew --- StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/AArch64

[edk2-devel] [PATCH v3 09/14] ArmPkg: Add Basic MMU Lib for Arm silicon

?id=3651 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPkg/Library/MmuLib/MmuLib.c | 120 ArmPkg/ArmPkg.dsc| 1 + ArmPkg/Library/MmuLib/BaseMmuLib.inf | 30 + 3 files changed, 151 insertions

[edk2-devel] [PATCH v3 10/14] MdeModulePkg: Swap to MmuLib instead of Arm-specific lib

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Cc: Liming Gao Cc: Sean Brogan Signed-off-by: Bret Barkelew --- MdeModulePkg/Core/DxeIplPeim/Arm/DxeLoadFunc.c | 4 ++-- MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf

[edk2-devel] [PATCH v3 08/14] MdePkg: Create the MMU access lib to abstract memory protection settings

From: Bret Barkelew There are a number of Arm-specific accesses that are abstracted behind this. It may need to be refactored to work better across architectures. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Sean Brogan

[edk2-devel] [PATCH v3 07/14] ArmPkg and MdePkg: Move the AsmMacroIoLib from ArmPkg to MdePkg

From: Bret Barkelew Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Sean Brogan Signed-off-by: Bret Barkelew Reviewed-by: Leif Lindholm --- {ArmPkg/Include => MdePkg/Include/AArch64}/AsmMacroIoLibV8.h | 0 {ArmPkg/Include => MdePkg/I

[edk2-devel] [PATCH v3 06/14] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3650 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Bob Feng Cc

[edk2-devel] [PATCH v3 05/14] ArmPkg and MdePkg: Move the Arm CompilerIntrinsicsLib to MdePkg

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3649 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Michael D

[edk2-devel] [PATCH v3 04/14] ArmPkg: Disavow StandaloneMmMmuLib. It's just ArmMmuLib

From: Bret Barkelew This extra interface is redundant and unnecessary. Dropping it is more EDK2-ish. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew Reviewed-by: Leif Lindholm --- ArmPkg/ArmPkg.dec

[edk2-devel] [PATCH v3 03/14] ArmPkg/StandaloneMmCoreEntryPoint: Swap to ArmMmuLib

From: Bret Barkelew StandaloneMmMmuLib has been turned into an implementation of the ArmMmuLib class (without any change to the interface itself), so this module can now change its dependency. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Ard Biesheuvel Cc: Sami Mujawar Cc

[edk2-devel] [PATCH v3 02/14] ArmPkg/ArmMmuStandaloneMmLib: Update to match ArmMmuLib

From: Bret Barkelew Drop switch from the custom "StandaloneMmMmuLib" class to the more generic "ArmMmuLib" class and add the missing functions to fulfill that interface. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sea

[edk2-devel] [PATCH v3 01/14] ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM

From: Bret Barkelew Not sure what all module types this HAS been validated against, but it doesn't work with STANDALONE_MM or STANDALONE_MM_CORE. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew

[edk2-devel] [PATCH v3 00/14] Un-siloing Arm common code

Gao Cc: Maciej Rabeda Cc: Michael D Kinney Cc: Ray Ni Cc: Sami Mujawar Cc: Sean Brogan Cc: Siyuan Fu Cc: Supreeth Venkatesh Cc: Yuwei Chen Cc: Zhichao Gao Cc: Zhiguang Liu Signed-off-by: Bret Barkelew Bret Barkelew (13): ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM ArmPkg

Re: [edk2-devel] [PATCH v2 11/16] ArmPkg: Add Basic MMU Lib for Arm silicon

e > reviewer in the same context). > > / > Leif > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Sean Brogan > > Signed-off-by: Bret Barkelew > > --- > > ArmPkg/L

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v2 16/16] ArmPlatformPkg: Resolve build errors resulting from package moves

of modules and libraries in the "generic" or the ARM packages. Thanks a lot for the series! Best regards, Marvin 02.11.2021 21:21:59 Bret Barkelew : > From: Bret Barkelew > > REF: > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.

Re: [edk2-devel] [PATCH v1 05/16] ArmPkg and MdePkg: Move the Arm CompilerIntrinsicsLib to MdePkg

iyuan > >> Fu ; Ray Ni ; Zhichao Gao > >> ; Sean Brogan > >> 主题: Re: [edk2-devel] [PATCH v1 05/16] ArmPkg and MdePkg: Move the Arm > >> CompilerIntrinsicsLib to MdePkg > >> > >> On Mon, Nov 01, 2021 at 12:56:37 -0700, brbar...@microsoft.com wro

Re: [edk2-devel] [EXTERNAL] [Patch V2 6/7] MdeModulePkg/Variable/RuntimeDxeUnitTest: Fix 32-bit GCC builds

Reviewed-by: Bret Barkelew - Bret From: Michael D Kinney<mailto:michael.d.kin...@intel.com> Sent: Wednesday, November 3, 2021 4:00 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: Hao A Wu<mailto:hao.a...@intel.com>; Liming Gao<mailto:gaolim...@byosoft.co

Re: [EXTERNAL] [edk2-devel] [PATCH v1 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools

Sounds good. Will update in v3. - Bret From: Feng, Bob C Sent: Wednesday, November 3, 2021 8:35:33 AM To: Andrew Fish ; edk2-devel-groups-io ; Bret Barkelew Cc: Lindholm, Leif ; brbar...@microsoft.com ; Ard Biesheuvel ; Liming Gao ; Chen, Yuwei ; Sean Brogan

[edk2-devel] [PATCH v2 15/16] ArmPkg/ArmPkg.dsc: Resolve build errors resulting from package moves

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPkg/ArmPkg.dsc | 8 1 file changed, 8 insertions(+) diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc index

[edk2-devel] [PATCH v2 16/16] ArmPlatformPkg: Resolve build errors resulting from package moves

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPlatformPkg/ArmPlatformPkg.dsc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ArmPlatformPkg

[edk2-devel] [PATCH v2 14/16] ArmPkg/Library: Convert StandaloneMmCoreEntryPoint to Arm-only

From: Bret Barkelew Drop X64 references. Update GUID. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPkg/Library

[edk2-devel] [PATCH v2 13/16] ArmPkg: Move the StandaloneMmCoreEntryPoint lib to ArmPkg

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar

[edk2-devel] [PATCH v2 12/16] ArmPkg: Move the StandaloneMmCpu driver to ArmPkg

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar

[edk2-devel] [PATCH v2 11/16] ArmPkg: Add Basic MMU Lib for Arm silicon

ng higher-level code to be more common. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPkg/Library/MmuLib/MmuLib.c | 120 ArmPkg/ArmPkg.dsc| 1 + A

[edk2-devel] [PATCH v2 09/16] MdeModulePkg: Swap to MmuLib instead of Arm-specific lib

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Cc: Liming Gao Cc: Sean Brogan Signed-off-by: Bret Barkelew --- MdeModulePkg/Core/DxeIplPeim/Arm/DxeLoadFunc.c | 4 ++-- MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf

[edk2-devel] [PATCH v2 10/16] StandaloneMmPkg: Switch to the MmuLib abstraction

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Cc: Sean Brogan Signed-off-by: Bret Barkelew --- StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/AArch64

[edk2-devel] [PATCH v2 08/16] MdePkg: Create the MMU access lib to abstract memory protection settings

From: Bret Barkelew There are a number of Arm-specific accesses that are abstracted behind this. It may need to be refactored to work better across architectures. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Sean Brogan

[edk2-devel] [PATCH v2 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3650 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Bob Feng Cc

[edk2-devel] [PATCH v2 07/16] ArmPkg and MdePkg: Move the AsmMacroIoLib from ArmPkg to MdePkg

From: Bret Barkelew Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Sean Brogan Signed-off-by: Bret Barkelew --- {ArmPkg/Include => MdePkg/Include/AArch64}/AsmMacroIoLibV8.h | 0 {ArmPkg/Include => MdePkg/Include/Arm}/AsmMacroI

[edk2-devel] [PATCH v2 05/16] ArmPkg and MdePkg: Move the Arm CompilerIntrinsicsLib to MdePkg

From: Bret Barkelew TODO: Might keep the name of the .inf. Pending discussion. This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id

[edk2-devel] [PATCH v2 04/16] ArmPkg: Disavow StandaloneMmMmuLib. It's just ArmMmuLib

From: Bret Barkelew This extra interface is redundant and unnecessary. Dropping it is more EDK2-ish. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew Reviewed-by: Leif Lindholm --- ArmPkg/ArmPkg.dec

[edk2-devel] [PATCH v2 03/16] ArmPkg/StandaloneMmCoreEntryPoint: Swap to ArmMmuLib

From: Bret Barkelew StandaloneMmMmuLib has been turned into an implementation of the ArmMmuLib class (without any change to the interface itself), so this module can now change its dependency. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Ard Biesheuvel Cc: Sami Mujawar Cc

[edk2-devel] [PATCH v2 02/16] ArmPkg/ArmMmuStandaloneMmLib: Update to match ArmMmuLib

From: Bret Barkelew Drop switch from the custom "StandaloneMmMmuLib" class to the more generic "ArmMmuLib" class and add the missing functions to fulfill that interface. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sea

[edk2-devel] [PATCH v2 01/16] ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM

From: Bret Barkelew Not sure what all module types this HAS been validated against, but it doesn't work with STANDALONE_MM or STANDALONE_MM_CORE. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew

[edk2-devel] [PATCH v2 00/16] Un-siloing Arm common code

Gao Cc: Maciej Rabeda Cc: Michael D Kinney Cc: Ray Ni Cc: Sami Mujawar Cc: Sean Brogan Cc: Siyuan Fu Cc: Supreeth Venkatesh Cc: Yuwei Chen Cc: Zhichao Gao Cc: Zhiguang Liu Signed-off-by: Bret Barkelew Bret Barkelew (15): ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM ArmPkg

Re: [edk2-devel] [PATCH v1 12/16] ArmPkg: Move the StandaloneMmCpu driver to ArmPkg

bar...@microsoft.com wrote: > > From: Bret Barkelew > > > > This aligns better with Mu's philosophy around dependency structuring > > and is one of the steps to enable Basecore to have zero CI dependencies > > on other Mu repos. > > > > REF: https://bugzilla.tianoco

Re: [edk2-devel] [PATCH v1 11/16] ArmPkg: Add Basic MMU Lib for Arm silicon

gt; > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Sean Brogan > > Signed-off-by: Bret Barkelew > > --- > > ArmPkg/Library/MmuLib/MmuLib.c | 120 > > ArmPkg/ArmPkg.dsc| 1 + > > ArmPkg/Library/MmuLi

Re: [edk2-devel] [PATCH v1 07/16] ArmPkg and MdePkg: Move the AsmMacroIoLib from ArmPkg to MdePkg

Will address. Thanks! On Tue, Nov 2, 2021 at 2:25 AM Leif Lindholm wrote: > On Mon, Nov 01, 2021 at 12:56:39 -0700, brbar...@microsoft.com wrote: > > From: Bret Barkelew > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Michael D Kinney > &g

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools

ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools On Mon, Nov 01, 2021 at 12:56:38 -0700, brbar...@microsoft.com wrote: > From: Bret Barkelew > > This aligns better with Mu's philosophy around dependency structuring > and is one of the steps to enable Baseco

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 05/16] ArmPkg and MdePkg: Move the Arm CompilerIntrinsicsLib to MdePkg

Gao<mailto:zhichao@intel.com>; Sean Brogan<mailto:sean.bro...@microsoft.com> Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v1 05/16] ArmPkg and MdePkg: Move the Arm CompilerIntrinsicsLib to MdePkg On Mon, Nov 01, 2021 at 12:56:37 -0700, brbar...@microsoft.com wrote: > Fr

[edk2-devel] [PATCH v1 16/16] ArmPlatformPkg/ArmPlatformPkg.dsc: Resolve build errors resulting from package moves

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPlatformPkg/ArmPlatformPkg.dsc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ArmPlatformPkg

[edk2-devel] [PATCH v1 13/16] ArmPkg: Move the StandaloneMmCoreEntryPoint lib to ArmPkg

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar

[edk2-devel] [PATCH v1 15/16] ArmPkg/ArmPkg.dsc: Resolve build errors resulting from package moves

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPkg/ArmPkg.dsc | 8 1 file changed, 8 insertions(+) diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc index

[edk2-devel] [PATCH v1 14/16] ArmPkg/Library: Convert StandaloneMmCoreEntryPoint to Arm-only

From: Bret Barkelew Drop X64 references. Update GUID. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPkg/Library/StandaloneMmCoreEntryPoint/X64/StandaloneMmCoreEntryPoint.c | 71

[edk2-devel] [PATCH v1 11/16] ArmPkg: Add Basic MMU Lib for Arm silicon

From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPkg/Library/MmuLib/MmuLib.c | 120 ArmPkg/ArmPkg.dsc| 1 + ArmPkg/Library

[edk2-devel] [PATCH v1 12/16] ArmPkg: Move the StandaloneMmCpu driver to ArmPkg

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar

[edk2-devel] [PATCH v1 09/16] MdeModulePkg: Swap to MmuLib instead of Arm-specific lib

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Cc: Liming Gao Cc: Sean Brogan Signed-off-by: Bret Barkelew --- MdeModulePkg/Core/DxeIplPeim/Arm/DxeLoadFunc.c | 4 ++-- MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf

[edk2-devel] [PATCH v1 10/16] StandaloneMmPkg: Switch to the MmuLib abstraction

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Cc: Sean Brogan Signed-off-by: Bret Barkelew --- StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/AArch64

[edk2-devel] [PATCH v1 08/16] MdePkg: Create the MMU access lib to abstract memory protection settings

From: Bret Barkelew There are a number of Arm-specific accesses that are abstracted behind this. It may need to be refactored to work better across architectures. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Sean Brogan

[edk2-devel] [PATCH v1 07/16] ArmPkg and MdePkg: Move the AsmMacroIoLib from ArmPkg to MdePkg

From: Bret Barkelew Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Sean Brogan Signed-off-by: Bret Barkelew --- {ArmPkg => MdePkg}/Include/AsmMacroIoLib.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/ArmPkg/Incl

[edk2-devel] [PATCH v1 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3650 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Bob Feng Cc

[edk2-devel] [PATCH v1 05/16] ArmPkg and MdePkg: Move the Arm CompilerIntrinsicsLib to MdePkg

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3649 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Michael D

[edk2-devel] [PATCH v1 04/16] ArmPkg: Disavow StandaloneMmMmuLib. It's just ArmMmuLib

From: Bret Barkelew This extra interface is redundant and unnecessary. Dropping it is more EDK2-ish. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPkg/ArmPkg.dec

[edk2-devel] [PATCH v1 03/16] ArmPkg/StandaloneMmCoreEntryPoint: Swap to ArmMmuLib

From: Bret Barkelew StandaloneMmMmuLib has been turned into an implementation of the ArmMmuLib class. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Cc: Sean Brogan Signed-off-by: Bret Barkelew

[edk2-devel] [PATCH v1 02/16] ArmPkg/ArmMmuStandaloneMmLib: Update to match ArmMmuLib

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c | 37 ArmPkg/Library/StandaloneMmMmuLib

[edk2-devel] [PATCH v1 01/16] ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM

From: Bret Barkelew Not sure what all module types this HAS been validated against, but it doesn't work with STANDALONE_MM or STANDALONE_MM_CORE. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew

[edk2-devel] [PATCH v1 00/16] Un-siloing Arm common code

, StandaloneMmPkg) does not require ArmPkg or ArmPlatformPkg. Also, some things that were previously hidden away under ArmPkg are now located with the core functionality or build tooling that makes sense for it. Bret Barkelew (15): ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM ArmPkg/ArmMmuStandaloneMmLib

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

2/pull/2066 > > Thank you > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Bret > > Barkelew > > Sent: Thursday, October 14, 2021 1:33 AM > > To: devel@edk2.groups.io > > Cc: Yao, Jiewen ; Wang, Jian J < > jian.j.w...@intel

[edk2-devel] [PATCH v2 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

Used to provision and maintain certain HW-defined NV spaces. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2994 Signed-off-by: Bret Barkelew Reviewed-by: Jiewen Yao Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar --- SecurityPkg/Library/Tpm2CommandLib/Tpm2NVStorage.c

Re: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

e v2 patch. Just want to ensure I did not miss that by > mistake. > > > > Thank you > > Yao Jiewen > > > > *From:* Bret Barkelew > *Sent:* Friday, August 13, 2021 11:22 AM > *To:* Yao, Jiewen ; devel@edk2.groups.io; > gaolim...@byosoft.com.cn; b...@corthon.com;

Re: [EXTERNAL] [edk2-devel][edk2-platforms][PATCH V1 1/1] MinPlatformPkg/Variable*Lib: Build VariableRead and VariableWrite libs

Question: I’ve recently brought up with some that the GetVariable##() functions in UefiLib are probably incorrect as they are written (because they assume things like gRT and gBS availability). Would it perhaps make sense to move this interface up into the MdePkg scope and leverage it to start

Re: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

Thanks, Jiewen! I’ll make those changes! - Bret From: Yao, Jiewen Sent: Thursday, August 12, 2021 7:47:04 PM To: devel@edk2.groups.io ; Yao, Jiewen ; gaolim...@byosoft.com.cn ; Bret Barkelew ; b...@corthon.com ; Kinney, Michael D Cc: Wang, Jian J ; Zhang, Qi1

Re: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

2021 5:06 PM To: Bret Barkelew<mailto:bret.barke...@microsoft.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; b...@corthon.com<mailto:b...@corthon.com> Cc: Wang, Jian J<mailto:jian.j.w...@intel.com>; Zhang, Qi1<mailto:qi1.zh...@intel.com>; Kumar, Rahul1&

[edk2-devel] [PATCH v2 1/1] pip-requirements: Update Basetools pip module

edk2-basetools 0.1.6 brings things update to date with BaseTools/Source/Python as of commit: 97fdcbda4e69d6f085ec3f2bd9d29a04af2b50a4 Signed-off-by: Bret Barkelew Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney --- pip-requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1

Re: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

Thoughts? - Bret From: devel@edk2.groups.io on behalf of Bret Barkelew via groups.io Sent: Wednesday, August 11, 2021 12:37:52 PM To: devel@edk2.groups.io ; b...@corthon.com Cc: Yao, Jiewen ; Jian J Wang ; Qi Zhang ; Rahul Kumar Subject: Re: [EXTERNAL

[edk2-devel] [PATCH v1 1/1] pip-requirements: Update Basetools pip module

edk2-basetools 0.1.6 brings things update to date with BaseTools/Source/Python as of commit: 97fdcbda4e69d6f085ec3f2bd9d29a04af2b50a4 Signed-off-by: Bret Barkelew --- pip-requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pip-requirements.txt b/pip

Re: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

Thoughts? - Bret From: devel@edk2.groups.io on behalf of Bret Barkelew via groups.io Sent: Wednesday, August 4, 2021 9:32:32 AM To: devel@edk2.groups.io ; b...@corthon.com Cc: Yao, Jiewen ; Jian J Wang ; Qi Zhang ; Rahul Kumar Subject: Re: [EXTERNAL] [edk2

Re: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

it in conflict with the rest of the file? Thanks! - Bret From: Bret Barkelew via groups.io<mailto:bret.barkelew=microsoft@groups.io> Sent: Friday, July 30, 2021 11:08 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; b...@corthon.com<mailto:b...@corthon.com&g

Re: [edk2-devel] Proposing a new area of the edk2-test repository

Yeah, go for the patch. - Bret From: Samer El-Haj-Mahmoud via groups.io<mailto:samer.el-haj-mahmoud=arm@groups.io> Sent: Tuesday, August 3, 2021 6:10 AM To: Nelson, Eric<mailto:eric.nel...@intel.com>; Bret Barkelew<mailto:bret.barke...@microsoft.com>; devel@edk2.grou

Re: [EXTERNAL] [edk2-devel] [edk2][PATCH v1 1/1] StandaloneMmPkg: add support to populate StMM boot data from device tree

I don’t think this is a good dependency. StandaloneMmCore shouldn’t require anything from EmbeddedPkg, and if it does there’s probably some more generalization necessary. Further, we can’t require the MmCore (which should be considered generic at the level of PEI Core or DXE Core) include some

Re: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

ERROR - *The #define name [RC_NV_UndefineSpaceSpecial_nvIndex] does no Thoughts? - Bret From: Bret Barkelew via groups.io<mailto:bret=corthon@groups.io> Sent: Friday, July 30, 2021 10:55 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: Yao, Jiewen<mailto:jiewen..

[edk2-devel] [PATCH v1 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

Used to provision and maintain certain HW-defined NV spaces. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2994 Signed-off-by: Bret Barkelew Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar --- SecurityPkg/Library/Tpm2CommandLib/Tpm2NVStorage.c | 122

Re: [EXTERNAL] [edk2-devel] Missing TPM 2 related call to Tpm2HierarchyChangeAuth

Adding @Jeremiah… Jeremiah, weren’t you or @Michael shopping this change to MinPlatform? - Bret From: Stefan Berger via groups.io Sent: Monday, July 26, 2021 7:48 AM To: Yao,

Re: [edk2-devel] ArmVirt and Self-Updating Code

Expanding audience to the full dev list… See below… - Bret From: Thomas Abraham<mailto:thomas.abra...@arm.com> Sent: Wednesday, July 7, 2021 11:07 PM To: Bret Barkelew<mailto:bret.barke...@microsoft.com>; Ard Biesheuvel (TianoCore)<mailto:ardb+tianoc...@kernel.org>; Lindho

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo Ersek's entries

I shall pour out a cup of bits in your honor! Your diligence will be missed. - Bret From: Michael D Kinney via groups.io Sent: Thursday, July 8, 2021 9:42 AM To: Laszlo Ersek;

Re: [edk2-devel] [EXTERNAL] [Patch 2/3] .mergify: Simplify Mergify rules using GitHub status checks

Acked-by: Bret Barkelew - Bret From: Michael D Kinney<mailto:michael.d.kin...@intel.com> Sent: Wednesday, July 7, 2021 8:49 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: Liming Gao<mailto:gaolim...@byosoft.com.cn>; Sean Brogan<mailto:sean.bro...@microsoft

Re: [EXTERNAL] [edk2-devel] [Patch 1/3] BaseTools/Scripts: Ignore Mergify merge commits in PatchCheck.py

Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Michael D Kinney via groups.io Sent: Wednesday, July 7, 2021 8:49:00 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao ; Chen, Yuwei Subject: [EXTERNAL] [edk2-devel] [Patch 1

Re: [edk2-devel] [EXTERNAL] [Patch 3/3] .azurepipelines: Remove FINISHED and FAILED states

Reviewed-by: Bret Barkelew - Bret From: Michael D Kinney<mailto:michael.d.kin...@intel.com> Sent: Wednesday, July 7, 2021 8:49 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: Sean Brogan<mailto:sean.bro...@microsoft.com>; Bret Barkelew<mailto:bret.barke...@m

Re: [EXTERNAL] [edk2-devel] [Patch 1/1] MdePkg/Include: Add STATIC_ASSERT for L'' and L"" strings

I like it. Do you have an extra space after the (L’A’) and (L”A”)? Reviewed-by: Bret Barkelew - Bret From: Michael D Kinney via groups.io<mailto:michael.d.kinney=intel@groups.io> Sent: Wednesday, July 7, 2021 3:43 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc

Re: [EXTERNAL] Re: [edk2-devel] Do the edk2 CI unit tests work in Linux?

I swear I got mine working with just an ‘apt install mono-devel’. But YMMV. - Bret From: Rebecca Cran<mailto:rebe...@bsdio.com> Sent: Thursday, July 1, 2021 7:00 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; steven@intel.com<mailto:steven....@intel.com&g

Re: [EXTERNAL] Re: [edk2-devel] Do the edk2 CI unit tests work in Linux?

Good question! I don’t have much experience with that, but let me see what my Googling skills can turn up. - Bret From: Shi, Steven Sent: Thursday, July 1, 2021 6:36:31 PM To: Bret Barkelew ; devel@edk2.groups.io ; rebe...@nuviainc.com Subject: RE: [EXTERNAL

Re: [EXTERNAL] Re: [edk2-devel] Do the edk2 CI unit tests work in Linux?

I believe the Azure DevOps build agents that are used by the EDK2 CI pipeline already have mono installed. - Bret From: Shi, Steven<mailto:steven@intel.com> Sent: Thursday, July 1, 2021 5:54 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Bret Barkelew<ma

Re: [EXTERNAL] Re: [edk2-devel] Do the edk2 CI unit tests work in Linux?

Hmmm. If that works well, we might be able to investigate carrying both and picking based on the host OS. - Bret From: devel@edk2.groups.io on behalf of Rebecca Cran via groups.io Sent: Tuesday, June 29, 2021 9:42:41 AM To: devel@edk2.groups.io ;

Re: [EXTERNAL] Re: [edk2-devel] NetworkPkg: Unexpected DHCP RELEASE after PXE server reply on IPv6

Thanks, Maciej! We’ll investigate! - Bret From: Rabeda, Maciej Sent: Tuesday, June 29, 2021 9:39:59 AM To: devel@edk2.groups.io ; LathaKannan Arumugam ; Bret Barkelew Subject: Re: [EXTERNAL] Re: [edk2-devel] NetworkPkg: Unexpected DHCP RELEASE after PXE server

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 0/5] EDK2 Code First: PI Specification: Update EFI_MM_COMMUNICATE_HEADER

Good note. Thanks! - Bret From: Marvin Häuser<mailto:mhaeu...@posteo.de> Sent: Tuesday, June 29, 2021 1:58 AM To: Bret Barkelew<mailto:bret.barke...@microsoft.com>; Laszlo Ersek<mailto:ler...@redhat.com>; Kun Qin<mailto:kuqi...@gmail.com>; Kinney, Michael D<mailto

Re: [edk2-devel] Do the edk2 CI unit tests work in Linux?

Which executable are you referring to? Also, yes, it is entirely possible that Linux has more dependencies since the dependency list has conditionals based on your OS. - Bret From: Steven Shi via groups.io Sent: Tuesday, June 29, 2021 8:44 AM To:

Re: [EXTERNAL] Re: [edk2-devel] Do the edk2 CI unit tests work in Linux?

Here’s some of the documentation, but I believe the standard apt mono-devel package is now up-to-date enough that the extra apt source is not necessary. edk2-pytool-extensions/using_extdep.md at master · tianocore/edk2-pytool-extensions

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 0/5] EDK2 Code First: PI Specification: Update EFI_MM_COMMUNICATE_HEADER

gt;; Dong, Eric<mailto:eric.d...@intel.com>; Ni, Ray<mailto:ray...@intel.com>; Liming Gao<mailto:gaolim...@byosoft.com.cn>; Liu, Zhiguang<mailto:zhiguang@intel.com>; Andrew Fish<mailto:af...@apple.com>; Lindholm, Leif<mailto:l...@nuviainc.com>; Bret Bark

Re: [EXTERNAL] Re: [edk2-devel] NetworkPkg: Unexpected DHCP RELEASE after PXE server reply on IPv6

+ @LathaKannan Arumugam<mailto:larumu...@microsoft.com> - Bret From: Rabeda, Maciej Sent: Friday, June 25, 2021 7:40:16 AM To: devel@edk2.groups.io ; Bret Barkelew ; Bret Barkelew Subject: [EXTERNAL] Re: [edk2-devel] NetworkPkg: Unexpected DHCP RELEASE

Re: [edk2-devel] Proposing a new area of the edk2-test repository

Fun fact! Mu also has a number of apps and things that we could work on moving to EDK2 if there were a suitable location. Right now, many of them are here: mu_plus/UefiTestingPkg at release/202102 · microsoft/mu_plus

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 1/5] EDK2 Code First: PI Specification: EFI_MM_COMMUNICATE_HEADER Update

iming Gao<mailto:gaolim...@byosoft.com.cn>; Liu, Zhiguang<mailto:zhiguang@intel.com>; Andrew Fish<mailto:af...@apple.com>; Laszlo Ersek<mailto:ler...@redhat.com>; Lindholm, Leif<mailto:l...@nuviainc.com>; Bret Barkelew<mailto:bret.barke...@microsoft.co

[edk2-devel] NetworkPkg: Unexpected DHCP RELEASE after PXE server reply on IPv6

Hi all! Trying to track down an unexpected behavior for one of our teams here: “We tried to PXEBoot a VM using IPv6 and even though the server replied with all requested boot options, the firmware for some reason did a DHCPv6 release instead of going for a network boot.” The team dug in with

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters

Reviewed-by: Bret Barkelew - Bret From: Sean Brogan<mailto:spbro...@outlook.com> Sent: Tuesday, June 15, 2021 9:00 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; kuqi...@gmail.com<mailto:kuqi...@gmail.com> Cc: Sean Brogan<mailto:sean.bro...@microsoft

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v2 4/6] SecurityPkg: Add EnrollFromDefaultKeys application.

> +#define FAIL(fmt...) AsciiPrint("EnrollFromDefaultKeysApp: " fmt) I don’t think this sort of implied concatenation works on all compilers. - Bret From: Pete Batard via groups.io Sent: Wednesday, June 2, 2021 10:40 AM To:

[edk2-devel] ArmPkg: TranslationTable exceeding TempRam on virtual systems

I’m fielding a series of questions coming out of our compatriot team that deals with virtual FW (for HyperV). They’re seeing ARM64 systems that have lots of RAM vastly exceeding the TempRam that’s passed into the system due to HOB allocations to create all the 4k entries for the early page

Re: [edk2-devel] [EXTERNAL] [edk2-stable202105 PATCH] MdeModulePkg/VariableLock: downgrade compatibility warnings to DEBUG_WARN

Reviewed-by: Bret Barkelew bret.barke...@microsoft.com<mailto:bret.barke...@microsoft.com> I don’t regret making it ERROR at first because now no one can claim to have not been warned when the interface drops, but I agree that lowering to WARN now is prudent. - Bret From: Laszlo

Re: [edk2-devel] A plea for help

Yup, I was tired. Read the Python version all wrong. - Bret From: Hernandez Miramontes, Jose Miguel Sent: Wednesday, May 19, 2021 7:15:30 AM To: devel@edk2.groups.io ; Bret Barkelew ; fowler_e...@ne.bah.com Subject: [EXTERNAL] RE: [edk2-devel] A plea for help

  1   2   3   4   5   >