Hi Ard and other maintainers,
Could you help to review this patch set?
Thanks,
Chao
On 2024/5/17 15:33, Chao Li wrote:
Hi Ard,
No, it's just that my email was bounced just now, the groupio didn't
receive my email when I send the first time, and I sent them again
after it unbounce
Hi Ard,
No, it's just that my email was bounced just now, the groupio didn't
receive my email when I send the first time, and I sent them again after
it unbounce.
Thanks,
Chao
On 2024/5/17 15:21, Ard Biesheuvel wrote:
Hello Chao Li,
You sent two series in quick succession. Is there any
Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Signed-off-by: Chao Li
Signed-off-by: Xianglai Li
---
ArmVirtPkg/ArmVirtQemu.dsc | 21 +++--
ArmVirtPkg/ArmVirtQemuKernel.dsc | 20 ++--
ArmVirtPkg/VarStore.fdf.inc
/show_bug.cgi?id=4770
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Signed-off-by: Chao Li
Signed-off-by: Xianglai Li
---
.../FdtNorFlashQemuLib/FdtNorFlashQemuLib.c | 165 ++
.../FdtNorFlashQemuLib/FdtNorFlashQemuLib.inf | 46
i \
-device usb-mouse \
-device usb-kbd \
-hda /usr/share/edk2/aarch64/openEuler-22.03-LTS-SP3-aarch64.qcow2 \
-monitor tcp::,server,nowait
Step 3:
After the virt-machines starts, enter "F2" to enter the setup UI, try to
change the boot order or some ther variables sto
Reviewed-by: Chao Li
Thanks,
Chao
On 2024/5/15 17:47, Xianglai Li wrote:
QemuFwCfgLibMmio has been removed,
using the latest FwCfgLib to fix compilation errors
Cc: Bibo Mao
Cc: Chao Li
Cc: Gerd Hoffmann
Signed-off-by: Xianglai Li
---
Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 6
: The difference between old and new tag is mainly resolving build
related issues.
There is no change in test coverage.
With WarM Regards,
Edhay
*From:*Chao Li
*Sent:* Thursday, May 9, 2024 9:56 PM
*To:* devel@edk2.groups.io; G Edhaya Chandran
; David Wright ;
Heinrich Schuchardt
*Cc:* Alex Fox
Hi Edhay,
Do I need to retest based on the edk2-test-rc2_202405 tag?
Thanks,
Chao
On 2024/5/10 10:43, G Edhaya Chandran wrote:
Thank you, David.
The results are well received.
With Warm Regards,
Edhay
*From:*David Wright
*Sent:* Thursday, May 9, 2024 3:23 PM
*To:* G Edhaya Chandran ;
Hi Ard,
Thanks,
Chao
On 2024/5/6 18:24, Ard Biesheuvel wrote:
On Mon, 6 May 2024 at 12:02, Chao Li wrote:
Hi Gerd,
Thanks,
Chao
On 2024/3/19 16:03, Gerd Hoffmann wrote:
Hi,
I can't tell the implementation scheme of the current lib and existing
lib implementation scheme which one
Hi Gerd,
Thanks,
Chao
On 2024/3/19 16:03, Gerd Hoffmann wrote:
Hi,
I can't tell the implementation scheme of the current lib and existing
lib implementation scheme which one is better, Could you give we some
advice?
I'd suggest to merge your code as OvmfPkg/Library/FdtNorFlashQemuLib as
All of platforms are switching to QemuFwCfgMmioDxeLib.inf, remove
QemuFwCfgLibMmio.inf now.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
---
.../Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf | 54
Enable QemuFwCfgMmioDxeLib.inf in RiscVVirtQemu.dsc
Build-tested only (with "RiscVVirtQemu.dsc").
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Chao Li
---
OvmfPkg
Enable QemuFwCfgMmioDxeLib.inf in ArmVirtQemu.dsc and
ArmVirtQemuKernel.dsc.
Build-tested only (with "ArmVirtQemu.dsc").
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Signed-off-b
Copy QemuFwCfgLibMmio.inf to QemuFwCfgMmioDxeLib.inf,
QemuFwCfgLibMmio.inf will be deleted when all platforms switching is
completed.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
---
.../QemuFwCfgLib
Added the PEI stage library for QemuFwCfgMmioLib, which uses the FDT to
find the fw_cfg and parse it.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Co-authored-by: Xianglai Li
Signed-off-by: Chao Li
---
.../Library/QemuFwCfgLib
heuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Chao Li
---
.../Library/QemuFwCfgLib/QemuFwCfgLibMmio.c | 70 +++--
.../Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf | 5 +
.../QemuFwCfgLib/QemuFwCfgLibMmio
(with "ArmVirtQemu.dsc and RiscVVirtQemu.dsc").
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Chao Li
---
.../Library/Qe
Added a new GUID for QemuFwCfgLib MMIO version, called
gQemuFirmwareResourceHobGuid, which is used to save QEMU firmware
configure resource during PEI stage.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
ull/5568
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sunil V L
Cc: Andrei Warkentin
Chao Li (8):
OvmfPkg: Add a GUID for QemuFwCfgLib
OvmfPkg: Separate QemuFwCfgLibMmio.c into two files
OvmfPkg: Add the way of HOBs in QemuFwCfgLibMmio
Hi Ard,
Thanks,
Chao
On 2024/4/30 09:19, Chao Li wrote:
Hi Ard,
OK, I will submit the V5 today and make the adjustments according to
your suggestions.
On 2024/4/29 21:11, Ard Biesheuvel wrote:
On Fri, 26 Apr 2024 at 10:29, Chao Li wrote:
Added the PEI stage library for QemuFwCfgMmioLib
Hi Ard,
OK, I will submit the V5 today and make the adjustments according to
your suggestions.
Thanks,
Chao
On 2024/4/29 21:11, Ard Biesheuvel wrote:
On Fri, 26 Apr 2024 at 10:29, Chao Li wrote:
Added the PEI stage library for QemuFwCfgMmioLib, which uses the FDT to
find the fw_cfg
Thanks,
Chao
On 2024/4/29 15:14, Ard Biesheuvel wrote:
On Mon, 29 Apr 2024 at 09:09, Chao Li wrote:
Hi Ard,
OK, I will make adjustments according to your suggestions and submit the V5
today.
No, please do not make any adjustments. I will take the v4 and apply
these changes directly
Hi Ard,
OK, I will make adjustments according to your suggestions and submit the
V5 today.
Thanks,
Chao
On 2024/4/29 14:56, Ard Biesheuvel wrote:
On Mon, 29 Apr 2024 at 03:17, Chao Li wrote:
Hi Ard and Gerd and other maintainers,
Could you review this version and give your suggestions
Hi Ard and Gerd and other maintainers,
Could you review this version and give your suggestions?
Thanks,
Chao
On 2024/4/26 16:28, Chao Li wrote:
Patch1: Added three PCDs for QemuFwCfgLibMmio
Patch2: Sparate QemuFwCfgLibMmio.c into two files and default as DXE
stage library.
Patch3: Added
All of platforms are switching to QemuFwCfgMmioDxeLib.inf, remove
QemuFwCfgLibMmio.inf now.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
---
.../Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf | 54
Enable QemuFwCfgMmioDxeLib.inf in RiscVVirtQemu.dsc
Build-tested only (with "RiscVVirtQemu.dsc").
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Chao Li
---
OvmfPkg
Enable QemuFwCfgMmioDxeLib.inf in ArmVirtQemu.dsc and
ArmVirtQemuKernel.dsc.
Build-tested only (with "ArmVirtQemu.dsc").
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Signed-off-b
Copy QemuFwCfgLibMmio.inf to QemuFwCfgMmioDxeLib.inf,
QemuFwCfgLibMmio.inf will be deleted when all platforms switching is
completed.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
---
.../QemuFwCfgLib
Added the PEI stage library for QemuFwCfgMmioLib, which uses the FDT to
find the fw_cfg and parse it.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Co-authored-by: Xianglai Li
Signed-off-by: Chao Li
---
.../Library/QemuFwCfgLib
heuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Chao Li
---
.../Library/QemuFwCfgLib/QemuFwCfgLibMmio.c | 71 --
.../Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf | 5 +
.../QemuFwCfgLib/QemuFwCfgLibMmio
(with "ArmVirtQemu.dsc and RiscVVirtQemu.dsc").
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Chao Li
---
.../Library/Qe
Added a new GUID for QemuFwCfgLib MMIO version, called
gQemuFirmwareResourceHobGuid, which is used to save QEMU firmware
configure resource during PEI stage.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
PR: https://github.com/tianocore/edk2/pull/5568
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sunil V L
Cc: Andrei Warkentin
Chao Li (8):
OvmfPkg: Add a GUID for QemuFwCfgLib
OvmfPkg: Separate QemuFwCfg
Hi Ard,
Thanks,
Chao
On 2024/4/26 09:20, Chao Li wrote:
Hi Ard,
On 2024/4/25 21:02, Ard Biesheuvel wrote:
On Thu, 25 Apr 2024 at 14:13, Chao Li wrote:
Added the HOB methods to load and store the QEMU firmware configure
address, data address and DMA address, which are not enabled during
Hi Ard,
Thanks,
Chao
On 2024/4/25 21:02, Ard Biesheuvel wrote:
On Thu, 25 Apr 2024 at 14:13, Chao Li wrote:
Added the HOB methods to load and store the QEMU firmware configure
address, data address and DMA address, which are not enabled during the
DXE stage.
Build-tested only
Hi Ard,
Thanks,
Chao
On 2024/4/25 20:58, Ard Biesheuvel wrote:
On Thu, 25 Apr 2024 at 14:13, Chao Li wrote:
Separate QemuFwCfgLibMmio.c into two files named QemuFwCfgLibMmio.c and
QemuFwCfgLibMmioDxe.c, added a new header named
QemuFwCfgLibMmioInternal.h for MMIO version.
Build-tested only
Enable QemuFwCfgMmioDxeLib.inf in RiscVVirtQemu.dsc
Build-tested only (with "RiscVVirtQemu.dsc").
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Chao Li
---
OvmfPkg
All of platforms are switching to QemuFwCfgMmioDxeLib.inf, remove
QemuFwCfgLibMmio.inf now.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
---
.../Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf | 51
Enable QemuFwCfgMmioDxeLib.inf in ArmVirtQemu.dsc and
ArmVirtQemuKernel.dsc.
Build-tested only (with "ArmVirtQemu.dsc").
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Signed-off-b
Copy QemuFwCfgLibMmio.inf to QemuFwCfgMmioDxeLib.inf,
QemuFwCfgLibMmio.inf will be deleted when all platforms switching is
completed.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
---
.../QemuFwCfgLib
Added the PEI stage library for QemuFwCfgMmioLib, which uses the FDT to
find the fw_cfg and parse it.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Co-authored-by: Xianglai Li
Signed-off-by: Chao Li
---
.../Library/QemuFwCfgLib
heuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Chao Li
---
.../Library/QemuFwCfgLib/QemuFwCfgLibMmio.c | 81 +++--
.../Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf | 1 +
.../Qe
5
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Chao Li
---
.../Library/QemuFwCfgLib/QemuFwCfgLibMmio.c | 194 +-
.../Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf | 4 +-
.../Qe
https://bugzilla.tianocore.org/show_bug.cgi?id=4755
PR: https://github.com/tianocore/edk2/pull/5568
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sunil V L
Cc: Andrei Warkentin
Chao Li (7):
OvmfPkg: Separate QemuFwCfgLibMmio.c into two
Hi Gerd,
I get it, I will refactor the code as soon as I can, it looks like
there's still some work and will take some time. I will try to send the
V3 tonight if possible.
Thanks,
Chao
On 2024/4/25 17:02, Gerd Hoffmann wrote:
On Thu, Apr 25, 2024 at 04:06:13PM +0800, Chao Li wrote:
Hi
Hi Ard and Gerd,
Thanks,
Chao
On 2024/4/25 16:11, Ard Biesheuvel wrote:
On Thu, 25 Apr 2024 at 10:10, Chao Li wrote:
Hi Gerd,
Thanks,
Chao
On 2024/4/25 15:40, Gerd Hoffmann wrote:
Hi,
+EFI_GUID mFwCfgSelectorAddressGuid = FW_CONFIG_SELECTOR_ADDRESS_HOB_GUID;
+EFI_GUID
Hi Gerd,
Thanks,
Chao
On 2024/4/25 15:40, Gerd Hoffmann wrote:
Hi,
+EFI_GUID mFwCfgSelectorAddressGuid = FW_CONFIG_SELECTOR_ADDRESS_HOB_GUID;
+EFI_GUID mFwCfgDataAddressGuid = FW_CONFIG_DATA_ADDRESS_HOB_GUID;
+EFI_GUID mFwCfgDmaAddressGuid = FW_CONFIG_DMA_ADDRESS_HOB_GUID;
Hi Gerd,
Thanks,
Chao
On 2024/4/25 15:53, Gerd Hoffmann wrote:
Hi,
+UINTN mFwCfgSelectorAddress;
+UINTN mFwCfgDataAddress;
+UINTN mFwCfgDmaAddress;
Hmm, global variables for PEI? I think the point of storing these in
the HOB is to avoid the need for global variables? Also does that
All of platforms are switching to QemuFwCfgMmioDxeLib.inf, remove
QemuFwCfgLibMmio.inf now.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
---
.../Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf | 51
Enable QemuFwCfgMmioDxeLib.inf in RiscVVirtQemu.dsc
Build-tested only (with "RiscVVirtQemu.dsc").
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Chao Li
---
OvmfPkg
Copy QemuFwCfgLibMmio.inf to QemuFwCfgMmioDxeLib.inf,
QemuFwCfgLibMmio.inf will be deleted when all platforms switching is
completed.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
---
.../QemuFwCfgLib
Enable QemuFwCfgMmioDxeLib.inf in ArmVirtQemu.dsc and
ArmVirtQemuKernel.dsc.
Build-tested only (with "ArmVirtQemu.dsc").
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Signed-off-b
heuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Chao Li
---
.../Library/QemuFwCfgLib/QemuFwCfgLibMmio.c | 176 +-
.../Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf | 1 +
.../Qe
Added the PEI stage library for QemuFwCfgMmioLib, which uses the FDT to
find the fw_cfg and parse it.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Co-authored-by: Xianglai Li
Signed-off-by: Chao Li
---
.../Library/QemuFwCfgLib
5
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Chao Li
---
.../Library/QemuFwCfgLib/QemuFwCfgLibMmio.c | 194 +-
.../Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf | 4 +-
.../Qe
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sunil V L
Cc: Andrei Warkentin
Chao Li (7):
OvmfPkg: Separate QemuFwCfgLibMmio.c into two files
OvmfPkg: Add the way of HOBs in QemuFwCfgLibMmio
OvmfPkg: Add the QemuFwCfgMmioLib PEI stage vers
Hi Ard,
OK, let's go with HOBs and today I'm going to send the V2. :)
Thanks,
Chao
On 2024/4/25 00:23, Ard Biesheuvel wrote:
On Wed, 24 Apr 2024 at 13:19, Gerd Hoffmann wrote:
On Wed, Apr 24, 2024 at 09:57:50AM +0800, Chao Li wrote:
Hi Gerd and Ard,
Can I submit the V2 this week? I want
Gerd,
Ha, it seems that Ard have already given the answer... I will adjust
according to Ard's suggestion and send the V2 today. :)
Thanks,
Chao
On 2024/4/24 19:19, Gerd Hoffmann wrote:
On Wed, Apr 24, 2024 at 09:57:50AM +0800, Chao Li wrote:
Hi Gerd and Ard,
Can I submit the V2 this week
Hi Gerd and Ard,
Can I submit the V2 this week? I want all OvmfPkg changes to be meged
before the 202405 feature freeze.
Thanks,
Chao
On 2024/4/22 17:21, Chao Li wrote:
Hi Ard,
Could you take a look at this patch set and give you some suggestions?
On 2024/4/17 18:01, Chao Li wrote:
Hi
Hi Ard,
Could you take a look at this patch set and give you some suggestions?
Thanks,
Chao
On 2024/4/17 18:01, Chao Li wrote:
Hi Gerd,
On 2024/4/17 17:35, Gerd Hoffmann wrote:
On Wed, Apr 17, 2024 at 04:12:56PM +0800, Chao Li wrote:
Patch1: Added three PCDs for QemuFwCfgLibMmio
Patch2
Hi Gerd,
Thanks,
Chao
On 2024/4/17 17:35, Gerd Hoffmann wrote:
On Wed, Apr 17, 2024 at 04:12:56PM +0800, Chao Li wrote:
Patch1: Added three PCDs for QemuFwCfgLibMmio
Patch2: Sparate QemuFwCfgLibMmio.c into two files and default as DXE
stage library.
Patch3: Added QemuFwCfgMmiLib PEI version
Added the PEI stage library for QemuFwCfgMmioLib, which uses the FDT to
find the fw_cfg and parse it.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Co-authored-by: Xianglai Li
Signed-off-by: Chao Li
---
.../Library/QemuFwCfgLib
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Chao Li
---
ArmVirtPkg/ArmVirtQemu.dsc | 2 +-
ArmVirtPkg/ArmVirtQemuKernel.dsc| 2 +-
.../{QemuFwCfgL
5
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Chao Li
---
.../Library/QemuFwCfgLib/QemuFwCfgLibMmio.c | 213 ++
.../Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf | 10 +-
.../Qe
: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
---
OvmfPkg/OvmfPkg.dec | 18 ++
1 file changed, 18 insertions(+)
diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
index fbc81e4c80..c09b92df60 100644
--- a/OvmfPkg/OvmfPkg.dec
+++ b/OvmfPkg
://bugzilla.tianocore.org/show_bug.cgi?id=4755
PR: https://github.com/tianocore/edk2/pull/5568
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sunil V L
Cc: Andrei Warkentin
Chao Li (4):
OvmfPkg: Add three PCDs for QemuFwCfgLib
OvmfPkg: Separate
Hi Gerd,
Thanks,
Chao
On 2024/4/17 14:59, Gerd Hoffmann wrote:
On Wed, Apr 17, 2024 at 10:53:21AM +0800, Chao Li wrote:
Hi Gerd,
Part 2 has been be merged, I'm separating this Lib into two serve the PEI
stage and DXE stage.
Currently, This DXE library uses three global variables, and when
in Mmio version.
Do you mind if I replace these three vaiables with three dynamically
typed PCDs? If so, the PEI and DXE stage libraries can using some of
the same APIs.
Thanks,
Chao
On 2024/3/21 20:27, Chao Li wrote:
Hi Gerd,
On 2024/3/21 19:39, Gerd Hoffmann wrote:
Hi
LoongArch64 requires CpuMmio2Dxe, add it into LoongArch64 field.
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Reviewed-by: Ray Ni
---
UefiCpuPkg/UefiCpuPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc
Added LoongArch64 CPU driver into CpuDxe.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4734
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Co-authored-by: Baoqi Zhang
Co-authored-by: Dongyan Qian
Acked-by: Gerd Hoffmann
Acked-by: Ray Ni
---
UefiCpuPkg/CpuDxe
Added LoongArch multiprocessor initialization instance into MpInitLib.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4734
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Acked-by: Gerd Hoffmann
Reviewed-by: Ray Ni
---
UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
On a multi-processor system, if the BSP dose not know how many APs are
online or cannot wake up the AP via broadcast, it can collect AP
resouces before wakeing up the AP and add a new HOB to save the
processor resouces.
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Add a new base library named CpuMmuLib and add a LoongArch64 instance
with in the library.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4734
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Co-authored-by: Baoqi Zhang
Co-authored-by: Dongyan Qian
Co-authored
Signed-off-by: Chao Li
Acked-by: Gerd Hoffmann
Reviewed-by: Ray Ni
---
UefiCpuPkg/UefiCpuPkg.dec | 6 ++
1 file changed, 6 insertions(+)
diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec
index ca744fab55..1b890e975c 100644
--- a/UefiCpuPkg/UefiCpuPkg.dec
+++ b/UefiCpuPkg
: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Chao Li
Acked-by: Gerd Hoffmann
Reviewed-by: Ray Ni
---
UefiCpuPkg/Include/Library/CpuMmuLib.h | 41 ++
UefiCpuPkg/UefiCpuPkg.dec | 4
Added LoongArch exception handler into CpuExceptionHandlerLib.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4734
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Co-authored-by: Baoqi Zhang
Acked-by: Gerd Hoffmann
Reviewed-by: Ray Ni
Add the LoongArch64 CPU Timer instance to CpuTimerLib, using CPUCFG 0x4
and 0x5 for Stable Counter frequency.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4734
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Acked-by: Gerd Hoffmann
Reviewed-by: Ray Ni
Some of the order is not in alphabetical, reorder.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4726
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Acked-by: Gerd Hoffmann
Reviewed-by: Ray Ni
---
UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 29
Some of the order is not in alphabetical, reorder.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4726
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Acked-by: Gerd Hoffmann
Reviewed-by: Ray Ni
---
UefiCpuPkg/CpuDxe/CpuDxe.inf | 16
1 file changed
Some of the order is not in alphabetical, reorder.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4726
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Acked-by: Gerd Hoffmann
Reviewed-by: Ray Ni
---
.../DxeCpuExceptionHandlerLib.inf | 20
Some of the order is not in alphabetical, reorder.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4726
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Acked-by: Gerd Hoffmann
Reviewed-by: Ray Ni
---
UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf | 2 +-
1 file
ay Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Cc: Sami Mujawar
Cc: Sunil V L
Cc: Bibo Mao
Cc: Dongyan Qian
Chao Li (13):
UefiCpuPkg/CpuTimerLib: Reorder the INF file alphabetically
UefiCpuPkg/CpuExceptionHandlerLib: Reorder the INF files
alphabetically
UefiCpuPkg/MpInitLib: Reorder the
Hi Ray,
Thanks,
Chao
On 2024/4/15 10:10, Ni, Ray wrote:
+
+typedef struct {
+ UINT32 NumberOfProcessor;
+ UINTN *ApicId;
[Ray] How about "UINTN ApicId[]"? The difference between the two is
your version contains an 8-byte pointer pointing to somewhere else. My
version implies the
Hi Gerd,
Thanks,
Chao
On 2024/3/15 17:22, Gerd Hoffmann wrote:
On Mon, Mar 11, 2024 at 02:39:02AM -0700, Chao Li wrote:
This Library is used to collect APs resources, but is currently NULL
for OvmfPkg, because it is not used by the LoongArch virtual machine.
What is the point of having
LoongArch64 requires CpuMmio2Dxe, add it into LoongArch64 field.
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
---
UefiCpuPkg/UefiCpuPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc
index e92ceb6466
Added LoongArch64 CPU driver into CpuDxe.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4734
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Co-authored-by: Baoqi Zhang
Co-authored-by: Dongyan Qian
Acked-by: Gerd Hoffmann
---
UefiCpuPkg/CpuDxe/CpuDxe.inf
Added LoongArch multiprocessor initialization instance into MpInitLib.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4734
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Acked-by: Gerd Hoffmann
Reviewed-by: Ray Ni
---
UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
On a multi-processor system, if the BSP dose not know how many APs are
online or cannot wake up the AP via broadcast, it can collect AP
resouces before wakeing up the AP and add a new HOB to save the
processor resouces.
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Add a new base library named CpuMmuLib and add a LoongArch64 instance
with in the library.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4734
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Co-authored-by: Baoqi Zhang
Co-authored-by: Dongyan Qian
Co-authored
Signed-off-by: Chao Li
Acked-by: Gerd Hoffmann
---
UefiCpuPkg/UefiCpuPkg.dec | 6 ++
1 file changed, 6 insertions(+)
diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec
index ca744fab55..1b890e975c 100644
--- a/UefiCpuPkg/UefiCpuPkg.dec
+++ b/UefiCpuPkg/UefiCpuPkg.dec
: Gerd Hoffmann
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Chao Li
Acked-by: Gerd Hoffmann
---
UefiCpuPkg/Include/Library/CpuMmuLib.h | 41 ++
UefiCpuPkg/UefiCpuPkg.dec | 4 +++
2 files changed
Added LoongArch exception handler into CpuExceptionHandlerLib.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4734
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Co-authored-by: Baoqi Zhang
Acked-by: Gerd Hoffmann
Reviewed-by: Ray Ni
Add the LoongArch64 CPU Timer instance to CpuTimerLib, using CPUCFG 0x4
and 0x5 for Stable Counter frequency.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4734
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Acked-by: Gerd Hoffmann
Reviewed-by: Ray Ni
Some of the order is not in alphabetical, reorder.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4726
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Acked-by: Gerd Hoffmann
Reviewed-by: Ray Ni
---
UefiCpuPkg/CpuDxe/CpuDxe.inf | 16
1 file changed
Some of the order is not in alphabetical, reorder.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4726
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Acked-by: Gerd Hoffmann
Reviewed-by: Ray Ni
---
UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 29
Some of the order is not in alphabetical, reorder.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4726
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Acked-by: Gerd Hoffmann
Reviewed-by: Ray Ni
---
.../DxeCpuExceptionHandlerLib.inf | 20
Some of the order is not in alphabetical, reorder.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4726
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Chao Li
Acked-by: Gerd Hoffmann
Reviewed-by: Ray Ni
---
UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf | 2 +-
1 file
: Bibo Mao
Cc: Dongyan Qian
Chao Li (13):
UefiCpuPkg/CpuTimerLib: Reorder the INF file alphabetically
UefiCpuPkg/CpuExceptionHandlerLib: Reorder the INF files
alphabetically
UefiCpuPkg/MpInitLib: Reorder the INF files alphabetically
UefiCpuPkg/CpuDxe: Reorder the INF file alphabet
named PROCESSOR_RESOURCE_HOG_GUID.
3. Following Ray suggest, adjust CpuMmuLib API, rename the API name.
4. Rename the PcdCpuExceptionVectorBaseAddress to
PcdLoongArch64ExceptionVectorBaseAddress.
5. Enable CpuMmio2Dxe in LoongArch.
Chao Li (13):
UefiCpuPkg/CpuTimerLib: Reorder the INF file alphabetically
Uefi
Hi Mike,
I found the CI ECC check does not create a detailed log under the
Attachments when the code style check fail, can you check what is going on?
Azure link:
1 - 100 of 842 matches
Mail list logo
