Re: [edk2-devel] [PATCH] NetworkPkg/WifiConnectionManagerDxe: Update UI according to UEFI spec

2024-04-10 Thread Clark-williams, Zachary
Reviewed-by: Zachary Clark-Williams -Original Message- From: Tan, Ming Sent: Thursday, March 21, 2024 6:16 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Clark-williams, Zachary ; Bi, Dandan ; POLUDOV, FELIX ; Liu, Liqi Subject: [PATCH] NetworkPkg/WifiConnectionManagerDxe

[edk2-devel] [PATCH] MinPlatformPkg/PhatAcpiLib: Add to CoreDxeLib dsc

2024-02-20 Thread Clark-williams, Zachary
From: Zachary Clark-Williams PhatAcpiLib update to match all file names to PhatAcpiLib and add the library to CoreDxeLib for use. Hsd-es-id: 22019504949 Change-Id: Ic184715a2b5ab117d464bad5cb251c674416e0dd Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by:

[edk2-devel] [PATCH] MinPlatformPkg/DxePhatLib: Add to CoreDxeLib dsc

2024-02-20 Thread Clark-williams, Zachary
From: Zachary Clark-Williams PhatAcpiLib update to match all file names to DxePhatAcpiLib and add the library to CoreDxeLib for use. Hsd-es-id: 22019504949 Change-Id: Ic184715a2b5ab117d464bad5cb251c674416e0dd Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by:

[edk2-devel] [PATCH] MinPlatformPkg/DxePhatLib: Add to CoreCommon dsc

2024-02-20 Thread Clark-williams, Zachary
From: Zachary Clark-Williams PhatAcpiLib update to match all file names to DxePhatAcpiLib and add the library to CoreCommonPkg for use. Change-Id: I6e18ecf5acfdbc2053cf60b9a151b891e4e0fdfe Hsd-es-id: 22019504949 Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by:

Re: [edk2-devel] reg: Two IAID assignment for single MAC Address

2023-10-04 Thread Clark-williams, Zachary
there should not be 2 IAID’s during that operational flow. Thanks, Zack From: Sivaraman Nainar Sent: Tuesday, October 3, 2023 10:49 AM To: devel@edk2.groups.io; Kasbekar, Saloni ; Clark-williams, Zachary Cc: Santhosh Kumar V ; Mike Su (蘇得緣) ; Dhanaraj V Subject: RE: reg: Two IAID assignment

Re: [edk2-devel] [PATCH V3] NetworkPkg: Correct the length of EAP Identity when in ASCII format

2023-06-27 Thread Clark-williams, Zachary
Reviewed-by: Zachary Clark-Williams Hey Michael, Can you help with this change merge? Thanks, Zack -Original Message- From: Li, Yi1 Sent: Sunday, June 25, 2023 10:41 PM To: devel@edk2.groups.io Cc: Li, Yi1 ; Maciej Rabeda ; Clark-williams, Zachary Subject: [PATCH V3] NetworkPkg

Re: [edk2-devel] [PATCH] NetworkPkg: Correct the length of EAP Identity when in ASCII format

2023-06-27 Thread Clark-williams, Zachary
Looks good to me. From: Li, Yi1 Sent: Monday, June 26, 2023 1:36 AM To: Clark-williams, Zachary ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH] NetworkPkg: Correct the length of EAP Identity when in ASCII format Hi Zack, Please check V3 patch, thanks for review. Regards, Yi From

Re: [edk2-devel] [PATCH] NetworkPkg: Correct the length of EAP Identity when in ASCII format

2023-06-22 Thread Clark-williams, Zachary
, Zack From: devel@edk2.groups.io On Behalf Of Li, Yi Sent: Monday, June 19, 2023 9:49 PM To: Clark-williams; Clark-williams, Zachary ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH] NetworkPkg: Correct the length of EAP Identity when in ASCII format Hi Zachary, Thanks for review

Re: [edk2-devel] [PATCH] NetworkPkg: Correct the length of EAP Identity when in ASCII format

2023-06-16 Thread Clark-williams, Zachary
Hey Yi, Review the below changes. The protocol has changes since ADL from PlatSapmle to an advanced feature and the Protocol has shifted into EDK2, so the protocol name needs to be updated: + Status = gBS->LocateProtocol (, NULL, (VOID **) ); Status = gBS->LocateProtocol (, NULL, (VOID

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: Update NetworkPkg maintainers and reviewers

2023-06-15 Thread Clark-williams, Zachary
Reviewed-by: Zachary Clark-williams -Zack -Original Message- From: Kasbekar, Saloni Sent: Wednesday, June 14, 2023 10:47 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Kinney, Michael D ; Andrew Fish ; Leif Lindholm ; Clark-williams, Zachary Subject: [PATCH 1/1

Re: [edk2-devel] [PATCH] NetworkPkg: Add WiFi profile sync protocol support

2023-01-09 Thread Clark-williams, Zachary
Hey Jiaxin, Please rind my updated patch below. Let me know when you get this reviewed so I can get it merged as soon as possible. Thank you, Zack -Original Message- From: Clark-williams, Zachary Sent: Friday, January 6, 2023 5:31 PM To: devel@edk2.groups.io Cc: Zachary Clark

[edk2-devel] [PATCH] NetworkPkg: Add WiFi profile sync protocol support

2023-01-06 Thread Clark-williams, Zachary
From: Zachary Clark-Williams REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3845 Enables KVM and One Click Recovery WLAN capability with WiFi Profile Sync feature and protocol. Adding WiFiProfileSyncProtocol, which supports the profilesync driver operations for transferring WiFi profiles

Re: [edk2-devel] [PATCH] NetworkPkg: Add WiFi profile sync protocol support

2023-01-06 Thread Clark-williams, Zachary
Thank you Jiaxin, Find my responses inline. An updated patch with requested changes is in route today. Thanks, Zack -Original Message- From: Wu, Jiaxin Sent: Thursday, January 5, 2023 9:09 PM To: Clark-williams, Zachary ; devel@edk2.groups.io; Kinney, Michael D Cc: Zachary

Re: [edk2-devel] [PATCH v4] NetworkPkg/WifiProfileSync: Add WiFi profile sync protocol support

2022-12-15 Thread Clark-williams, Zachary
Hey All, Anyone able to review the EDK2 Network Pkg patch I've submitted? The patch is below in the original email. Let me know if you'd like a fresh patch file. Thanks, Zack -Original Message- From: Clark-williams, Zachary Sent: Tuesday, December 6, 2022 10:42 AM To: devel@edk2

Re: [edk2-devel] [PATCH v4] NetworkPkg/WifiProfileSync: Add WiFi profile sync protocol support

2022-12-06 Thread Clark-williams, Zachary
++ Michal's coverage Michal and Lukasz -Original Message- From: Clark-williams, Zachary Sent: Tuesday, December 6, 2022 10:38 AM To: devel@edk2.groups.io; Clark-williams, Zachary ; Rabeda, Maciej ; Zimmer, Vincent ; Luo, Heng ; Kuo, Scottie ; Kuo, Ted ; Dutkiewicz, Michal ; Wu

Re: [edk2-devel] [PATCH v4] NetworkPkg/WifiProfileSync: Add WiFi profile sync protocol support

2022-12-06 Thread Clark-williams, Zachary
Hey Maciej and All, Is there any update in ability to review this patch for Wifi Profile Sync Protocol and Wifi Connection Manager? Thank you, Zack -Original Message- From: devel@edk2.groups.io On Behalf Of Clark-williams, Zachary Sent: Wednesday, November 2, 2022 8:58 AM To: Rabeda

[edk2-devel] [PATCH] NetworkPkg: Add WiFi profile sync protocol support

2022-11-14 Thread Clark-williams, Zachary
From: Zachary Clark-Williams REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3845 Enables KVM and One Click Recovery WLAN capability with WiFi Profile Sync feature and protocol. Adding WiFiProfileSyncProtocol, which supports the profilesync driver operations for transferring WiFi profiles

Re: [edk2-devel] [PATCH v4] NetworkPkg/WifiProfileSync: Add WiFi profile sync protocol support

2022-11-02 Thread Clark-williams, Zachary
- From: Rabeda, Maciej Sent: Wednesday, November 2, 2022 5:35 AM To: Clark-williams, Zachary ; Zimmer, Vincent ; Luo, Heng ; Kuo, Scottie ; Kuo, Ted ; Dutkiewicz, Michal ; devel@edk2.groups.io; Wu, Jiaxin ; Otcheretianski, Andrei ; Kasbekar, Saloni ; Kinney, Michael D Cc: Alappat, Paul ; Patil

Re: [edk2-devel] [PATCH v4] NetworkPkg/WifiProfileSync: Add WiFi profile sync protocol support

2022-11-01 Thread Clark-williams, Zachary
Great thank you Vincent, I will add them to the protocol header file and send an updated patch today. -Original Message- From: Zimmer, Vincent Sent: Tuesday, November 1, 2022 10:39 AM To: Clark-williams, Zachary ; Rabeda, Maciej ; Luo, Heng ; Kuo, Scottie ; Kuo, Ted ; Dutkiewicz

Re: [edk2-devel] [PATCH v4] NetworkPkg/WifiProfileSync: Add WiFi profile sync protocol support

2022-11-01 Thread Clark-williams, Zachary
c document? Things like concept of profile sync? I'm guessing they are since Linux probably does the same in the intel iwl driver? Vincent -Original Message- From: devel@edk2.groups.io On Behalf Of Clark-williams, Zachary Sent: Monday, October 31, 2022 12:31 PM To: Kinney, Michael

Re: [edk2-devel] [PATCH v4] NetworkPkg/WifiProfileSync: Add WiFi profile sync protocol support

2022-10-31 Thread Clark-williams, Zachary
++ visibility -Original Message- From: Clark-williams, Zachary Sent: Friday, October 28, 2022 1:13 PM To: Kinney, Michael D ; Rabeda, Maciej ; Luo, Heng ; Kuo, Scottie ; Kuo, Ted ; Dutkiewicz, Michal ; devel@edk2.groups.io; Fu, Siyuan ; Wu, Jiaxin ; Otcheretianski, Andrei Subject

Re: [edk2-devel] [PATCH v4] NetworkPkg/WifiProfileSync: Add WiFi profile sync protocol support

2022-10-28 Thread Clark-williams, Zachary
++More for reviewal! -Original Message- From: Clark-williams, Zachary Sent: Friday, October 28, 2022 1:10 PM To: Kinney, Michael D ; Rabeda, Maciej ; Luo, Heng ; Kuo, Scottie ; Kuo, Ted ; Dutkiewicz, Michal ; devel@edk2.groups.io Subject: RE: [PATCH v4] NetworkPkg/WifiProfileSync: Add

Re: [edk2-devel] [PATCH v4] NetworkPkg/WifiProfileSync: Add WiFi profile sync protocol support

2022-10-28 Thread Clark-williams, Zachary
; Clark-williams, Zachary Subject: FW: [PATCH v4] NetworkPkg/WifiProfileSync: Add WiFi profile sync protocol support Hi Maciej, Can you please help review these NetworkPkg changes. I am not sure if you monitor your linux.intel.com account as closely as your intel.com account. Thanks, Mike

[edk2-devel] [PATCH v4 161/161] NetworkPkg: Add WiFi profile sync protocol support

2022-10-04 Thread Clark-williams, Zachary
From: Zachary Clark-Williams REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3845 Enables KVM and One Click Recovery WLAN capability with WiFi Profile Sync feature and protocol. Adding WiFiProfileSyncProtocol, which supports the profilesync driver operations for transferring WiFi profiles

Re: [edk2-devel] [PATCH V2 2/2] NetworkPkg: Add WiFi profile sync protocol support

2022-09-28 Thread Clark-williams, Zachary
.groups.io; Clark-williams, Zachary Cc: Zachary Clark-Williams Subject: RE: [edk2-devel] [PATCH V2 2/2] NetworkPkg: Add WiFi profile sync protocol support Hi Zack, 1. > + Status = UnicodeStrToAsciiStrS (Profile->Password, (CHAR8 > + *)AsciiPassword, ((StrLen (Profile->Password) +

[edk2-devel] [PATCH 104/104] NetworkPkg: Add WiFi profile sync protocol support

2022-09-28 Thread Clark-williams, Zachary
From: Zachary Clark-Williams REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3845 Enables KVM and One Click Recovery WLAN capability with WiFi Profile Sync feature and protocol. Adding WiFiProfileSyncProtocol, which supports the profilesync driver operations for transferring WiFi profiles

[edk2-devel] [PATCH V2 2/2] NetworkPkg: Add WiFi profile sync protocol support

2022-09-26 Thread Clark-williams, Zachary
From: Zachary Clark-Williams REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3845 Enables KVM and One Click Recovery WLAN capability with WiFi Profile Sync feature and protocol. Adding WiFiProfileSyncProtocol, which supports the profilesync driver operations for transferring WiFi profiles

Re: [edk2-devel] [PATCH] NetworkPkg: Add WiFi profile sync protocol support

2022-09-26 Thread Clark-williams, Zachary
. Please feel free to review the rest of this patch in the mean time and provide feedback of any other misalignments to be changed. Thanks, Zack -Original Message- From: Michael Brown Sent: Monday, September 26, 2022 9:27 AM To: devel@edk2.groups.io; Clark-williams, Zachary ; Luo, Heng

Re: [edk2-devel] [PATCH] NetworkPkg: Add WiFi profile sync protocol support

2022-09-26 Thread Clark-williams, Zachary
To: devel@edk2.groups.io; Clark-williams, Zachary Cc: Zachary Clark-Williams ; Maciej Rabeda Subject: RE: [edk2-devel] [PATCH] NetworkPkg: Add WiFi profile sync protocol support Hi Zachary, > @@ -420,22 +422,34 @@ WifiMgrConfigPassword ( >// >// Set password to s

[edk2-devel] [PATCH] NetworkPkg: Add WiFi profile sync protocol support

2022-09-14 Thread Clark-williams, Zachary
From: Zachary Clark-Williams REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3845 Enables KVM and One Click Recovery WLAN capability with WiFi Profile Sync feature and protocol. Adding WiFiProfileSyncProtocol, which supports the profilesync driver operations for transferring WiFi profiles

[edk2-devel] NetworkPkg PR for WiFi profile sync protocol addition

2022-09-12 Thread Clark-williams, Zachary
Hello EDK2 Community, Please review and comment on the EDK2 NetworkPkg PR: https://github.com/tianocore/edk2/pull/3197 Patch of the PR is attached. Firewalls are stopping the git-email capability, hence this email. Thank you, Zack -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all

[edk2-devel] Adding HTTP boot IO timeout programmability from PcdHttpIoTimeout

2021-07-22 Thread Clark-williams, Zachary
Hello, Please review the attached filed EDK2 tracker for feature enablement of programmable timeout of the HTTP boot IO timer. NetworkPkg-HttpBoot: Making the HTTP IO timeout value programmable with PCD. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3507 HTTP boot has a default set