Reviewed-by: Eric Dong
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, December 27, 2019 3:32 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Zeng, Star
> ; Fu, Siyuan ; Kinney, Michael
> D
> Subject: [PATCH v
Reviewed-by: Eric Dong
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, December 27, 2019 3:32 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Zeng, Star
> ; Fu, Siyuan ; Kinney, Michael
> D
> Subject: [PATCH v
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, December 27, 2019 3:32 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Zeng, Star
> ; Fu, Siyuan ; Kinney, Michael
> D
> Subject: [PATCH v4 4/6] UefiCpuPkg/MpInitL
Reviewed-by: Eric Dong
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Friday, December 27, 2019 3:32 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Zeng
Hao,
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, December 27, 2019 3:32 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Zeng, Star
> ; Fu, Siyuan ; Kinney, Michael
> D
> Subject: [PATCH v4 2/6] UefiCpuPkg/MpIn
Reviewed-by: Eric Dong
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, December 27, 2019 3:32 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Zeng, Star
> ; Fu, Siyuan ; Kinney, Michael
> D
> Subject: [PATCH v
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Token is new introduced by MM MP Protocol. Current logic allocate Token
every time when need to use it. The logic caused SMI latency raised to
very high. Update logic to allocate Token buffer at driver's entry point.
Later use the token
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Token is new introduced by MM MP Protocol. Current logic allocate Token
every time when need to use it. The logic caused SMI latency raised to
very high. Update logic to allocate Token buffer at driver's entry point.
Later use the token
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2268
In current implementation, when check whether APs called by StartUpAllAPs
or StartUpThisAp, it checks the Tokens value used by other APs. Also the AP
will update the Token value for itself if its task finished. In this
case, the potential
This patch serial
1. patch 1 fixed potential race condition issue for PiSmmCpuDxeSmm.
2. Patch 2 fixed a potential buffer overflow issue.
V3 change:
Minor changes based on comments.
Cc: Ray Ni
Cc: Laszlo Ersek
Eric Dong (2):
UefiCpuPkg/PiSmmCpuDxeSmm: Remove dependence between APs
The size for the array of mSmmMpSyncData->CpuData[] is 0 ~
mMaxNumberOfCpus -1. But current code may use
mSmmMpSyncData->CpuData[mMaxNumberOfCpus].
This patch fixed this issue.
Reviewed-by: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Eric Dong
---
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 16
Hi Ray,
> -Original Message-
> From: Ni, Ray
> Sent: Monday, December 23, 2019 3:38 PM
> To: devel@edk2.groups.io; Dong, Eric
> Cc: Laszlo Ersek
> Subject: RE: [edk2-devel] [PATCH v2 1/2] UefiCpuPkg/PiSmmCpuDxeSmm:
> Remove dependence between APs
>
>
Hi Ray,
> -Original Message-
> From: Ni, Ray
> Sent: Friday, December 20, 2019 2:15 PM
> To: Dong, Eric mailto:eric.d...@intel.com>>;
> devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Laszlo Ersek mailto:ler...@redhat.com>>
> Subject: RE: [P
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2268
In current implementation, when check whether APs called by StartUpAllAPs
or StartUpThisAp, it checks the Tokens value used by other APs. Also the AP
will update the Token value for itself if its task finished. In this
case, the potential
This patch serial
1. patch 1 fixed potential race condition issue for PiSmmCpuDxeSmm.
2. Patch 2 fixed a potential buffer overflow issue.
Cc: Ray Ni
Cc: Laszlo Ersek
Eric Dong (2):
UefiCpuPkg/PiSmmCpuDxeSmm: Remove dependence between APs
UefiCpuPkg/PiSmmCpuDxeSmm: Fix buffer overflow
The size for the array of mSmmMpSyncData->CpuData[] is 0 ~
mMaxNumberOfCpus -1. But current code may use
mSmmMpSyncData->CpuData[mMaxNumberOfCpus].
This patch fixed this issue.
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Eric Dong
---
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 16
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2268
In current implementation, when check whether APs called by StartUpAllAPs
or StartUpThisAp, it checks the Tokens value used by other APs. Also the AP
will update the Token value for itself if its task finished. In this
case, the potential
Thanks Philippe.
Reviewed-by: Eric Dong
Thanks,
Eric
> -Original Message-
> From: Philippe Mathieu-Daude
> Sent: Friday, December 6, 2019 7:25 PM
> To: devel@edk2.groups.io
> Cc: Philippe Mathieu-Daude ; Dong, Eric
>
> Subject: [PATCH v2 023/105] .mailmap: Add a
Reviewed-by: Eric Dong
> -Original Message-
> From: Philippe Mathieu-Daude [mailto:phi...@redhat.com]
> Sent: Wednesday, December 4, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Philippe
> Mathieu-Daude
&g
Reviewed-by: Eric Dong
> -Original Message-
> From: Philippe Mathieu-Daude [mailto:phi...@redhat.com]
> Sent: Wednesday, December 4, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Philippe
> Mathieu-Daude
&g
Reviewed-by: Eric Dong
> -Original Message-
> From: Philippe Mathieu-Daude [mailto:phi...@redhat.com]
> Sent: Wednesday, December 4, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Philippe
> Mathieu-Daude
&g
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Token is new introduced by MM MP Protocol. Current logic allocate Token
every time when need to use it. The logic caused SMI latency raised to
very high. Update logic to allocate Token buffer at driver's entry point.
Later use the token
Hi Ray,
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, December 5, 2019 1:25 PM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Laszlo Ersek
> Subject: RE: [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate
> Token every time
>
> Some comments.
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Token is new introduced by MM MP Protocol. Current logic allocate Token
every time when need to use it. The logic caused SMI latency raised to
very high. Update logic to allocate Token buffer at driver's entry point.
Later use the token
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, December 4, 2019 5:20 PM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: Re: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate Token
> every time
>
Hi all,
Please ignore this version change which based on old codebase. Will send new
change soon.
Thanks,
Eric
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Dong, Eric
> Sent: Wednesday, December 4, 2019 4:05 PM
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Token is new introduced by MM MP Protocol. Current logic allocate Token
every time when need to use it. The logic caused SMI latency raised to
very high. Update logic to allocate Token buffer at driver's entry point.
Later use the token
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Token is new introduced by MM MP Protocol. Current logic allocate Token
every time when need to use it. The logic caused SMI latency raised to
very high. Update logic to allocate Token buffer at driver's entry point.
Later use the token
Hi Philippe,
> -Original Message-
> From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com]
> Sent: Thursday, November 28, 2019 9:16 PM
> To: devel@edk2.groups.io; Dong, Eric
> Cc: Ni, Ray ; Laszlo Ersek
> Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Friday, November 29, 2019 3:39 PM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray ; Gao, Liming
> Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid
>
Hi Laszlo,
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo
Ersek
Sent: Thursday, November 28, 2019 9:57 PM
To: Dong, Eric ; devel@edk2.groups.io
Cc: Ni, Ray ; Gao, Liming
Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate
Token every
v2 changes:
Minor update based on comments.
v1 changes:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Current logic allocate Token every time when need to use it. The logic
caused SMI latency raised to very high. Update logic to allocate Token
buffer at driver's entry point. Later
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Current logic allocate Token every time when need to use it. The logic
caused SMI latency raised to very high. Update logic to allocate Token
buffer at driver's entry point. Later use the token from the allocated
token buffer. Only when all
Reviewed-by: Eric Dong
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, November 14, 2019 5:17 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei ; Dong, Eric
> ; Ni, Ray ; Laszlo Ersek
>
> Subject: [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add m
Reviewed-by: Eric Dong
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, November 14, 2019 5:17 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei ; Dong, Eric
> ; Ni, Ray ; Laszlo Ersek
>
> Subject: [PATCH] UefiCpuPkg: Update the coding styles
&
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Monday, November 11, 2019 11:05 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Laszlo Ersek
> Subject: [PATCH 1/2] UefiCpuPkg/CpuCommonFeaturesLib: Remove XD
> enable/disable
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Monday, November 11, 2019 11:05 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Laszlo Ersek
> Subject: [PATCH 2/2] UefiCpuPkg/RegisterCpuFeature: Remove
> CPU_FEATURE_XD macro
>
> REF: htt
Reviewed-by: Eric Dong
-Original Message-
From: Chu, Maggie
Sent: Monday, November 4, 2019 12:04 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Zhang, Chao B ;
Yao, Jiewen
Subject: [PATCH] SecurityPkg/OpalPassword: Remove dependency on
EFI_BLOCK_IO_PROTOCOL
https
Reviewed-by: Eric Dong
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, Ray
Sent: Wednesday, October 30, 2019 5:53 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Laszlo Ersek
Subject: [edk2-devel] [PATCH 2/2] UefiCpuPkg/MpInitLib: Remove global
Reviewed-by: Eric Dong
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, Ray
Sent: Wednesday, October 30, 2019 5:53 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Laszlo Ersek
Subject: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Set
Hi Mike and Laszlo,
I agree with Mike's proposal. We can submit new bugz to remove the binary.
Thanks,
Eric
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, October 23, 2019 7:39 AM
To: Laszlo Ersek ; devel@edk2.groups.io; Kinney, Michael D
Cc: Sean Brogan ; Dong, Eric
Hi Laszlo,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, October 8, 2019 7:27 PM
> To: edk2-devel-groups-io
> Cc: Dong, Eric ; Igor Mammedov
> ; Ni, Ray
> Subject: [edk2-devel
Reviewed-by: Eric Dong
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, October 5, 2019 1:29 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming
> Subject: [edk2-platforms][PATCH V2 3/3]
> BoardModulePkg/FirmwareBootMediaInfoPei: Add
Reviewed-by: Eric Dong
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, October 5, 2019 1:29 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming
> Subject: [edk2-platforms][PATCH V2 2/3]
> BoardModulePkg/FirmwareBootMediaInfoLib: Add l
Reviewed-by: Eric Dong
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 1, 2019 9:16 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming
> Subject: [edk2-platforms][PATCH V1 2/3]
> BoardModulePkg/FirmwareBootMediaInfoLib: Add l
Reviewed-by: Eric Dong
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chiu,
> Chasel
> Sent: Friday, September 27, 2019 3:51 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ;
> Desimone, Nathaniel L ; Gao, Li
szlo Ersek
> ; Ard Biesheuvel ; Kinney,
> Michael D ; Gao, Liming
> ; Dong, Eric ; Ni, Ray
> ; Singh, Brijesh ; You, Benjamin
> ; Bi, Dandan ; Dong, Guo
> ; Wu, Hao A ; Wang, Jian J
> ; Ma, Maurice
> Subject: Re: [edk2-devel] [RFC PATCH v2 00/44] SEV-ES guest support
>
> On 9
Reviewed-by: Eric Dong
And pushed:
SHA-1: f4c898f2b2db2819c519cdce05403d4ba0234979
Thanks,
Eric
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of John
> E Lofgren
> Sent: Wednesday, September 18, 2019 11:43 PM
> To: devel@edk2.groups.io
>
Reviewed-by: Eric Dong
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, September 18, 2019 3:49 AM
> To: edk2-devel-groups-io
> Cc: Dong, Eric ; Wu, Hao A ;
> Wang, Jian J ; Ni, Ray
> Subject: [PATCH 15/35] MdeModulePkg
Cc other reviewers.
Reviewed-by: Eric Dong
Thanks,
Eric
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of John E
> Lofgren
> Sent: Tuesday, September 10, 2019 2:41 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [Patch V2] UefiCpuPkg/CpuExceptionHandlerLib: Fix
> #AC
V2 changes:
Avoid use type case, use different file implementation.
V1 changes:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1039
Current implementation not checks system mode before using
PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.X64 or
PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.Ia32.
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, September 11, 2019 11:25 PM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: Re: [Patch] UefiCpuPkg/CpuDxe: clean up
> PAGE_TABLE_LIB_PAGING_CONTEXT us
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1039
Current implementation not checks system mode before using
PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.X64 or
PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.Ia32. This patch check
the mode before using the correct one.
Cc: Ray Ni
Cc: Laszlo
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Friday, September 6, 2019 6:19 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Dong, Eric ;
> Laszlo Ersek
> Subject: [PATCH] UefiCpuPkg/PiSmmCpu: Enable 5L paging only when phy addr
> line &g
Reviewed-by: Eric Dong
> -Original Message-
> From: Zhang, Shenglei
> Sent: Saturday, September 7, 2019 1:16 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming
> Subject: [PATCH v2] DebugFeaturePkg: Remove white space and update the
> ending format
&g
Reviewed-by: Eric Dong
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Saturday, September 7, 2019 1:16 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming
> Subject: [edk2-devel] [PAT
Hi John,
Thanks for your explanation. I agree with your analysis. I think you can
submit your next version patch.
Thanks,
Eric
> -Original Message-
> From: Lofgren, John E
> Sent: Saturday, September 7, 2019 3:01 AM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray
Hi John,
I'm not sure whether I understand the code correctly. If not, please correct me.
1. You change to the code to only exchange 32 bits(eax) instead of 64
bits(rax). After your change, how to handle the above 32 bits value (from bit
32 to bit 63)?
2. In this file, also have another two
Reviewed-by: Eric Dong
> -Original Message-
> From: Bi, Dandan
> Sent: Thursday, September 5, 2019 12:54 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming
> Subject: [patch] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid
>
> gEfiFormBrowserEx
Reviewed-by: Eric Dong
> -Original Message-
> From: Chiu, Chasel
> Sent: Thursday, September 5, 2019 12:27 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek
> Subject: [PATCH v2] UefiCpuPkg: support single
> EFI_PEI_CORE_FV_LOCATION_PPI in
Hi Chasel,
Thanks for your quick fix.
Reviewed-by: Eric Dong
Thanks,
Eric
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chiu,
> Chasel
> Sent: Wednesday, September 4, 2019 4:56 PM
> To: devel@edk2.groups.io
> Cc: Do
Wednesday, September 4, 2019 12:56 AM
> To: Nikodem, Damian ; devel@edk2.groups.io
> Cc: Dong, Eric ; You, Benjamin
> ; Laszlo Ersek ; Rusocki,
> Krzysztof
> Subject: RE: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Race condition between
> APHandler's release of Busy spinlock and user-tri
Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, August 29, 2019 8:37 PM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: Re: [Patch] UefiCpuPkg/SecCore: get AllSecPpiList after
> SecPlatformMain.
>
> Hi Eric,
>
> On 08/28/19 08:50, Eric Dong wrote:
> &
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2136
SecPlatformMain is a platform hook function which let platform does
some update. Some platform may adjust SecCoreData->PeiTemporaryRamBase
which caused former saved AllSecPpiList variable invalid.
This patch update the logic to get
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Monday, August 26, 2019 6:45 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Yao, Jiewen ;
> Laszlo Ersek
> Subject: [PATCH 5/5] UefiCpuPkg: Remove PcdCpuSmmStaticPageTable
>
> PcdC
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Monday, August 26, 2019 6:45 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Yao, Jiewen ;
> Laszlo Ersek
> Subject: [PATCH 4/5] UefiCpuPkg: Explain relationship between several SMM
> PCDs
&
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Monday, August 26, 2019 6:45 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Yao, Jiewen ;
> Laszlo Ersek
> Subject: [PATCH 3/5] UefiCpuPkg/PiSmmCpu: Restrict access per
> PcdCpuSmmRestrictedM
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Monday, August 26, 2019 6:45 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Yao, Jiewen ;
> Laszlo Ersek
> Subject: [PATCH 2/5] UefiCpuPkg/PiSmmCpu: Use new PCD
> PcdCpuSmmRestrictedMemoryAcces
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Monday, August 26, 2019 6:45 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Yao, Jiewen ;
> Laszlo Ersek
> Subject: [PATCH 1/5] UefiCpuPkg: Add PcdCpuSmmRestrictedMemoryAccess
>
> The pa
Reviewed-by: Eric Dong
> -Original Message-
> From: Kuo, Donald
> Sent: Thursday, August 15, 2019 5:11 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Zeng, Star ; Dong, Eric
> ; Chan, Amy ; Chaganty,
> Rangasai V
> Subject: [PATCH] UefiCpuPkg: Adding a new TSC lib
Reviewed-by: Eric Dong
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 15, 2019 4:15 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek
> Subject:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Supports new logic which test current value before write new value.
Only write new value when current value not same as new value.
Signed-off-by: Eric Dong
Cc: Ray Ni
Acked-by: Laszlo Ersek
---
.../CpuFeaturesInitialize.c
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Supports new logic which test current value before write new value.
Only write new value when current value not same as new value.
Signed-off-by: Eric Dong
Cc: Ray Ni
Reviewed-by: Laszlo Ersek
---
UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 29
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Add below new micros which test the current value before write the new
value. Only write new value when current value not same as new value.
CPU_REGISTER_TABLE_TEST_THEN_WRITE32
CPU_REGISTER_TABLE_TEST_THEN_WRITE64
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Below code is current implementation:
if (MsrRegister[ProcessorNumber].Bits.Lock == 0) {
CPU_REGISTER_TABLE_WRITE_FIELD (
ProcessorNumber,
Msr,
MSR_IA32_FEATURE_CONTROL,
MSR_IA32_FEATURE_CONTROL_REGISTER,
Signed-off-by: Eric Dong
Cc: Ray Ni
Reviewed-by: Laszlo Ersek
---
UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 104 ++
1 file changed, 62 insertions(+), 42 deletions(-)
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c
b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c
index
v4 changes:
1. Split Reserved field and use one byte as TestThenWrite field.
v3 changes:
1. Avoid changing exist API CpuRegisterTableWrite, add new API
CpuRegisterTableTestThenWrite which align new adds macros.
Only 1/6 patch been changed in v3.
V2 changes:
1. Split CR read/write action in to
Signed-off-by: Eric Dong
Cc: Ray Ni
Acked-by: Laszlo Ersek
---
.../CpuFeaturesInitialize.c | 110 ++
1 file changed, 63 insertions(+), 47 deletions(-)
diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> -Original Message-
> From: Zeng, Star
> Sent: Friday, August 16, 2019 10:08 AM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek ; Yao,
> Jiewen ; Gao, Liming ; Kinney,
> Michael D ; Zeng, Star
> Subject: RE: [Patch v3 1/6] UefiCpuPkg/Reg
> -Original Message-
> From: Zeng, Star
> Sent: Friday, August 16, 2019 9:15 AM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek ; Zeng,
> Star
> Subject: RE: [Patch v3 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test
> Then Write"
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Below code is current implementation:
if (MsrRegister[ProcessorNumber].Bits.Lock == 0) {
CPU_REGISTER_TABLE_WRITE_FIELD (
ProcessorNumber,
Msr,
MSR_IA32_FEATURE_CONTROL,
MSR_IA32_FEATURE_CONTROL_REGISTER,
Signed-off-by: Eric Dong
Cc: Ray Ni
Acked-by: Laszlo Ersek
---
.../CpuFeaturesInitialize.c | 110 ++
1 file changed, 63 insertions(+), 47 deletions(-)
diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
Signed-off-by: Eric Dong
Cc: Ray Ni
Reviewed-by: Laszlo Ersek
---
UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 104 ++
1 file changed, 62 insertions(+), 42 deletions(-)
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c
b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c
index
v3 changes:
1. Avoid changing exist API CpuRegisterTableWrite, add new API
CpuRegisterTableTestThenWrite which align new adds macros.
Only 1/6 patch been changed in v3.
V2 changes:
1. Split CR read/write action in to one discrete patch 2. Keep the old logic
which continue the process if error
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Add below new micros which test the current value before write
the new value. Only write new value when current value not
same as new value.
CPU_REGISTER_TABLE_TEST_THEN_WRITE32
CPU_REGISTER_TABLE_TEST_THEN_WRITE64
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Supports new logic which test current value before write new value.
Only write new value when current value not same as new value.
Signed-off-by: Eric Dong
Cc: Ray Ni
Reviewed-by: Laszlo Ersek
---
UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 29
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Supports new logic which test current value before write new value.
Only write new value when current value not same as new value.
Signed-off-by: Eric Dong
Cc: Ray Ni
Acked-by: Laszlo Ersek
---
.../CpuFeaturesInitialize.c
Reviewed-by: Eric Dong
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Donald Kuo
> Sent: Tuesday, August 13, 2019 6:53 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Zeng, Star ; Dong, Eric
> ; Chan, Amy ; Chaganty,
&g
Hi liming,
This is a bug fix. It is required by 201908 stable tag.
Thanks,
Eric
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, August 14, 2019 3:27 PM
> To: devel@edk2.groups.io; Dong, Eric ;
> ler...@redhat.com
> Cc: Ni, Ray ; leif.lindh...@linaro.or
Hi Donald,
Thanks for your explanation. In this case, Reviewed-by: Eric Dong
Thanks,
Eric
> -Original Message-
> From: Kuo, Donald
> Sent: Tuesday, August 13, 2019 11:26 AM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray ; Zeng, Star ; Chan,
> Amy ; Ch
Hi Laszlo,
Yes, I already checked IA32 build.
As Ray is leaving these days, can you help to review this serial?
Thanks,
Eric
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Monday, August 12, 2019 10:15 P
t; To: devel@edk2.groups.io
> Cc: Ni, Ray ; Zeng, Star ; Dong, Eric
> ; Chan, Amy ; Chaganty,
> Rangasai V
> Subject: [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15)
> TSC leaf
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909
>
> Cc: Ray Ni
Agree with Dandan's comments. With that update, Reviewed-by: Eric Dong
> -Original Message-
> From: Bi, Dandan
> Sent: Tuesday, August 13, 2019 10:04 AM
> To: Zhang, Shenglei ; devel@edk2.groups.io
> Cc: Gao, Liming ; Wu, Hao A ;
> Laszlo Ersek ; Dong, Eric
> Su
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Supports new logic which test current value before write new value.
Only write new value when current value not same as new value.
Signed-off-by: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
---
UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 29
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Supports new logic which test current value before write new value.
Only write new value when current value not same as new value.
Signed-off-by: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
---
.../CpuFeaturesInitialize.c |
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Add below new micros which test the current value before write
the new value. Only write new value when current value not
same as new value.
CPU_REGISTER_TABLE_TEST_THEN_WRITE32
CPU_REGISTER_TABLE_TEST_THEN_WRITE64
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Below code is current implementation:
if (MsrRegister[ProcessorNumber].Bits.Lock == 0) {
CPU_REGISTER_TABLE_WRITE_FIELD (
ProcessorNumber,
Msr,
MSR_IA32_FEATURE_CONTROL,
MSR_IA32_FEATURE_CONTROL_REGISTER,
V2 changes:
1. Split CR read/write action in to one discrete patch
2. Keep the old logic which continue the process if error found.
Below code is current implementation:
if (MsrRegister[ProcessorNumber].Bits.Lock == 0) {
CPU_REGISTER_TABLE_WRITE_FIELD (
ProcessorNumber,
Msr,
Signed-off-by: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
---
.../CpuFeaturesInitialize.c | 112 ++
1 file changed, 64 insertions(+), 48 deletions(-)
diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
Hi Laszlo,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Friday, August 9, 2019 11:31 PM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: Re: [edk2-devel] [Patch 3/4] Uefi
201 - 300 of 467 matches
Mail list logo
