Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

We can have some protocol where all Redfish clients register saying that they are using the bootstrap credentials. And when they finish their job they notify RedfishBootstrapAccountDxe driver and when all of registered modules finish their job RedfishBootstrapAccountDxe driver delete the

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

Hi Nickle, I have one more question to discuss regarding this driver. We have a bootstrap account and creation of this account controlled by RedfishCredentialDxe driver in RedfishPkg. But deletion of that bootstrap account is moved to RedfishClientPkg. What if we have another Redfish Client or

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: rename x-uefi-redfish to x-UEFI-redfish

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: Chang, Abner Sent: Thursday, May 02, 2024 11:49 PM To: Nickle Wang ; devel@edk2.groups.io Cc: Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] RE: [edk2-redfish-client][PATCH] RedfishClientPkg: rename

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

Hi Nickle and Abner, I also have the same question as Abner. Why do we need to delete those credentials? According to spec BMC should delete the bootstrap credentials automatically on host or service reset. Thank you, Igor -Original Message- From: Chang, Abner Sent: Sunday, April 21,

Re: [edk2-devel] [PATCH V3 4/6] RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted unexpectedly

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: abner.ch...@amd.com Sent: Thursday, April 4, 2024 6:18 AM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH V3 4/6] RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted

Re: [edk2-devel] [PATCH V3 6/6] RedfishPkg/RedfishPlatformConfigDxe: support menu path report

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: abner.ch...@amd.com Sent: Thursday, April 4, 2024 6:18 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nickle Wang Subject: [EXTERNAL] [PATCH V3 6/6] RedfishPkg/RedfishPlatformConfigDxe: support

Re: [edk2-devel] [PATCH V3 1/6] RedfishPkg/RedfishPlatformConfigDxe: Config language searching optimization

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: abner.ch...@amd.com Sent: Thursday, April 4, 2024 6:18 AM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH V3 1/6] RedfishPkg/RedfishPlatformConfigDxe: Config language searching

Re: [edk2-devel] [PATCH V3 3/6] RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: abner.ch...@amd.com Sent: Thursday, April 4, 2024 6:18 AM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH V3 3/6] RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support

Re: [edk2-devel] [PATCH V3 0/6] Config language searching algorithm enhancement and the bug fixes

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: abner.ch...@amd.com Sent: Thursday, April 4, 2024 6:18 AM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH V3 0/6] Config language searching algorithm enhancement and the bug

Re: [edk2-devel] [PATCH V3 2/6] RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG macro

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: abner.ch...@amd.com Sent: Thursday, April 4, 2024 6:18 AM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH V3 2/6] RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG macro

Re: [edk2-devel] [PATCH V2 1/6] RedfishPkg/RedfishPlatformConfigDxe: Config language searching optimization

Hi Abner, Sorry for that delay. Here is a couple of remarks. DescriptionStr was introduced and, I think, it can be used in RedfishPlatformConfigProtocolGetAttribute function instead of using HiiGetRedfishString. Also please check my comment below in NewRedfishXuefiStringArray and

Re: [edk2-devel] [PATCH V2 0/6] [PATCH V2 0/5] Config language searching algorithm enhancement and the bug fixes

Hi Abner, I'm very sorry, so busy those days with release. I will be able to check it next week only. Best regards, Igor Get Outlook for Android From: Chang, Abner Sent: Wednesday, March 27, 2024 3:43:55 AM To: Nickle Wang ;

Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol

Reviewed-by: Igor Kulchytskyy Whole patch reviewed Regards, Igor -Original Message- From: Nickle Wang Sent: Thursday, February 29, 2024 3:53 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy Subject: [EXTERNAL] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol

Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol

Hi Nickle, Sorry, for late response. AMI does not use RedfishLib in RedfishClientPkg, but library in RedfishPkg used. Thank you, Igor From: Nickle Wang Sent: Thursday, February 29, 2024 8:24 PM To: Mike Maslenkin ; devel@edk2.groups.io; Igor Kulchytskyy Cc: Abner Chang Subject: [EXTERNAL]

Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

-Original Message- From: Chang, Abner Sent: Wednesday, February 28, 2024 7:31 PM To: Nickle Wang ; Mike Maslenkin ; Igor Kulchytskyy Cc: devel@edk2.groups.io; Nick Ramirez Subject: [EXTERNAL] RE: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

Re: [edk2-devel] [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST JSON C Structure DXE driver

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: abner.ch...@amd.com Sent: Sunday, February 25, 2024 9:44 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST JSON C Structure DXE

Re: [edk2-devel] [PATCH v3 0/6] Introduce Redfish http protocol

Reviewed-by: Igor Kulchytskyy Reviewed the whole patch v3. Regards, Igor -Original Message- From: Nickle Wang Sent: Monday, February 26, 2024 7:44 PM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH v3 0/6] Introduce Redfish http

Re: [edk2-devel] [edk2-redfish-client][PATCH] edk2-Redfish-client: Clarify HTTP method used for provisioning

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: abner.ch...@amd.com Sent: Sunday, February 25, 2024 11:55 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy ; Mike Maslenkin Subject: [EXTERNAL] [edk2-redfish-client][PATCH] edk2-Redfish-client: Clarify

Re: [edk2-devel] [PATCH v2 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Thursday, February 22, 2024 4:12 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH v2 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue

Re: [edk2-devel] [PATCH v2 5/6] RedfishPkg/RedfishDebugLib: use RedfishHttpLib

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Thursday, February 22, 2024 4:12 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH v2 5/6] RedfishPkg/RedfishDebugLib: use RedfishHttpLib **CAUTION: The

Re: [edk2-devel] [PATCH v2 4/6] RedfishPkg/RedfishLib: include RedfishServiceData.h

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Thursday, February 22, 2024 4:12 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH v2 4/6] RedfishPkg/RedfishLib: include RedfishServiceData.h **CAUTION:

Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Thursday, February 22, 2024 4:11 AM To: devel@edk2.groups.io Cc: Igor Kulchytskyy ; Abner Chang ; Nick Ramirez Subject: [EXTERNAL] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol **CAUTION: The

Re: [edk2-devel] [PATCH v2 3/6] RedfishPkg: introduce RedfishHttpLib

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Thursday, February 22, 2024 4:12 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH v2 3/6] RedfishPkg: introduce RedfishHttpLib **CAUTION: The e-mail below

Re: [edk2-devel] [PATCH v2 1/6] RedfishPkg: introduce Redfish HTTP protocol

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Thursday, February 22, 2024 4:11 AM To: devel@edk2.groups.io Cc: Igor Kulchytskyy ; Abner Chang ; Nick Ramirez Subject: [EXTERNAL] [PATCH v2 1/6] RedfishPkg: introduce Redfish HTTP protocol **CAUTION: The

Re: [edk2-devel] [PATCH v2 0/6] Introduce Redfish http protocol

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Thursday, February 22, 2024 4:11 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH v2 0/6] Introduce Redfish http protocol **CAUTION: The e-mail below is

Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishDebugLib: add function to print buffer.

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: Nickle Wang Sent: Tuesday, January 9, 2024 6:13 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH v2] RedfishPkg/RedfishDebugLib: add function to print buffer.

Re: [edk2-devel] [edk2-redfish-client][PATCH V4] RedfishClientPkg: Add ETag PCD and revise Redfish ETag functions

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: abner.ch...@amd.com Sent: Sunday, January 07, 2024 9:49 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy ; Mike Maslenkin Subject: [EXTERNAL] [edk2-redfish-client][PATCH V4] RedfishClientPkg: Add ETag

Re: [edk2-devel] [edk2-redfish-client][PATCH V3] RedfishClientPkg: Add ETag PCD and revise Redfish ETag functions

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: Chang, Abner Sent: Sunday, January 07, 2024 9:43 PM To: Igor Kulchytskyy ; devel@edk2.groups.io Cc: Nickle Wang ; Mike Maslenkin Subject: RE: [EXTERNAL] [edk2-redfish-client][PATCH V3] RedfishClientPkg: Add ETag PCD

Re: [edk2-devel] [edk2-redfish-client][PATCH V3] RedfishClientPkg: Add ETag PCD and revise Redfish ETag functions

Hi Abner, Some small correction in comments syntax (see below). Thank you, Igor -Original Message- From: abner.ch...@amd.com Sent: Thursday, January 4, 2024 4:09 AM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy ; Mike Maslenkin Subject: [EXTERNAL]

Re: [edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg/libredfish: Fix build error

Reviewed-by: Igor Kulchytskyy Regards, Igor Kulchytskyy -Original Message- From: abner.ch...@amd.com Sent: Thursday, January 4, 2024 4:12 AM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [EXTERNAL] [edk2-redfish-client][PATCH V2] RedfishClientPkg/libredfish:

Re: [edk2-devel] [PATCH 6/9] RedfishPkg: add Component Name protocols to RedfishConfigHandler driver

Just mistype I guess (see below) -Original Message- From: Mike Maslenkin Sent: Tuesday, December 12, 2023 9:54 AM To: devel@edk2.groups.io Cc: abner.ch...@amd.com; nick...@nvidia.com; Igor Kulchytskyy ; Mike Maslenkin Subject: [EXTERNAL] [PATCH 6/9] RedfishPkg: add Component Name

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDicovery: Remedy Redfish service discovery flow

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: abner.ch...@amd.com Sent: Wednesday, December 6, 2023 10:05 AM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy ; Mike Maslenkin Subject: [EXTERNAL] [PATCH] RedfishPkg/RedfishDicovery: Remedy Redfish

Re: [edk2-devel] [edk2-redfish-client][PATCH v2] RedfishClientPkg/RedfishFeatureUtilityLib: validate string array

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: Nickle Wang Sent: Monday, December 4, 2023 4:41 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [edk2-redfish-client][PATCH v2]

Re: [edk2-devel] [PATCH V3 1/9] RedfishPkg/BmcUsbNicLib: Update BMC USB NIC searching algorithm

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: abner.ch...@amd.com Sent: Monday, November 27, 2023 12:31 AM To: devel@edk2.groups.io Cc: Mike Maslenkin ; Nickle Wang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH V3 1/9] RedfishPkg/BmcUsbNicLib: Update BMC USB

Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx

n > when opening attachments, clicking links, or responding. > > > On 11/15/23 23:12, Igor Kulchytskyy via groups.io wrote: > > Igor Kulchytskyy (2): > > RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after > > RestEx > > R

Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx

dk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 > installed after RestEx > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On 11/15/23 23:12, Igor Kulchytskyy

Re: 回复: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx

and append new commits. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Igor > Kulchytskyy via groups.io > 发送时间: 2023年11月16日 21:45 > 收件人: Chang, Abner ; devel@edk2.groups.io; Leif > Lindholm > 抄送: Gao, Liming > 主题: Re: [edk2-devel] [PATCH v6 0/2] Fix and op

Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx

] Great and happy ending!  Hi Igor, could you please inform Liming he can merge this change. Thanks Abner > -Original Message- > From: devel@edk2.groups.io On Behalf Of Igor > Kulchytskyy via groups.io > Sent: Thursday, November 16, 2023 8:31 PM > To: Leif Lindholm ; devel

Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx

-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** On Wed, Nov 15, 2023 at 22:12:34 +, Igor Kulchytskyy via groups.io wrote: > Igor Kulchytskyy (2): > RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 ins

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

Hi Leif, Already sent it yesterday. Thank you, Igor -Original Message- From: Leif Lindholm Sent: Thursday, November 16, 2023 7:15 AM To: devel@edk2.groups.io; mike.maslen...@gmail.com; Igor Kulchytskyy Cc: Abner Chang ; Nickle Wang Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v5 2/2]

[edk2-devel] [PATCH v6 2/2] [edk2-stable202311] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

Filter out the network interfaces which are not supported by Redfish Host Interface. Cc: Abner Chang Cc: Nickle Wang Cc: Mike Maslenkin Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 196 ++--

[edk2-devel] [PATCH v6 1/2] [edk2-stable202311] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Supported function of the driver changed to wait for all network interface to be installed. Reviewed-by: Abner Chang Reviewed-by: Nickle Wang Acked-by Mike Maslenkin Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 31 ++-- 1 file

[edk2-devel] [PATCH v6 0/2] [edk2-stable202311] Fix and optimize the issue if IPv4 installed after RestEx

Igor Kulchytskyy (2): RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 -- .../RedfishDiscoverInternal.h | 4 +

[edk2-devel] [PATCH v6 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

Filter out the network interfaces which are not supported by Redfish Host Interface. Cc: Abner Chang Cc: Nickle Wang Cc: Mike Maslenkin Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 196 ++--

[edk2-devel] [PATCH v6 1/2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Supported function of the driver changed to wait for all network interface to be installed. Reviewed-by: Abner Chang Reviewed-by: Nickle Wang Acked-by Mike Maslenkin Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 31 ++-- 1 file

[edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx

Igor Kulchytskyy (2): RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 -- .../RedfishDiscoverInternal.h | 4 +

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

-Original Message- From: Mike Maslenkin Sent: Wednesday, November 15, 2023 2:26 PM To: Igor Kulchytskyy Cc: Leif Lindholm ; devel@edk2.groups.io; Abner Chang ; Nickle Wang Subject: Re: [EXTERNAL] Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

Hi Mike, My implementation of checking the IpType supposed to be like this: /** Check if Network Protocol Type matches with SMBIOS Type 42 IP Address Type. @param[in] NetworkProtocolType The Network Protocol Type to check with. @param[in] IpType The Host IP Address Type

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

Discover flow **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** On 2023-11-14 23:52, Mike Maslenkin wrote: > On Tue, Nov 14, 2023 at 9:57 PM Igor Kulchytskyy via groups.io > wrote: >>

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

ginated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On Tue, Nov 14, 2023 at 9:57 PM Igor Kulchytskyy via groups.io > wrote: > > > > Hi Leif, > > Please see my comments below. > > Thank you, > &

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

: RedfishDiscoverDxe: Optimize the Redfish Discover flow **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** On 2023-11-14 14:28, Igor Kulchytskyy via groups.io wrote: > Filter out the network interfaces wh

Re: [edk2-devel] [PATCH v5 0/2] Fix and optimize the issue if IPv4 installed after RestEx

Hi Leif, I addressed your comments in that v5 patch. Do you have any other concerns? Thank you, Igor -Original Message- From: devel@edk2.groups.io On Behalf Of Igor Kulchytskyy via groups.io Sent: Tuesday, November 14, 2023 9:28 AM To: devel@edk2.groups.io Subject: [EXTERNAL] [edk2

[edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

Filter out the network interfaces which are not supported by Redfish Host Interface. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 163 ++-- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverInternal.h

[edk2-devel] [PATCH v5 1/2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Supported function of the driver changed to wait for all network interface to be installed. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 31 ++-- 1 file changed, 16 insertions(+), 15 deletions(-) diff

[edk2-devel] [PATCH v5 0/2] Fix and optimize the issue if IPv4 installed after RestEx

Igor Kulchytskyy (2): RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 132 +- .../RedfishDiscoverInternal.h | 6 +

[edk2-devel] [PATCH 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

Filter out the network interfaces which are not supported by Redfish Host Interface. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Igor Kulchytskyy --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 169 +- 1 file changed, 120 insertions(+), 49 deletions(-) diff --git

[edk2-devel] [PATCH 1/2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Supported function of the driver changed to wait for all network interface to be installed. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Igor Kulchytskyy --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 31 ++- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git

[edk2-devel] [PATCH 0/2] Fix and optimize the issue if IPv4 installed after RestEx

Igor Kulchytskyy (2): RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 138 +- 1 file changed, 105 insertions(+), 33 deletions(-) --

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishFeatureUtilityLib: validate string array

Hi Nickle, I noticed one typo. See below the text. And I have a question regarding newly introduced ValidateRedfishStringArrayValues function. You use that function to check if value in Redfish string array can be found in HII configuration string array. And you still call

[edk2-devel] [PATCH v3] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Supported function of the driver changed to wait for all newtwork interface to be installed. Filer out the network interfaces which are not supported by Redfish Host Interface. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Igor Kulchytskyy ---

Re: [edk2-devel] [PATCH] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

I changed TestForRequiredProtocols function as Mike suggested. I also kept GetHiIpProtocolType function without STATIC. Resend pull request with those changes. Thank you, Igor From: devel@edk2.groups.io On Behalf Of Igor Kulchytskyy via groups.io Sent: Monday, November 6, 2023 9:37 PM To: Chang

Re: [edk2-devel] [PATCH] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** Hi Igor please find my comments below. On Tue, Oct 31, 2023 at 8:56 PM Igor Kulchytskyy via groups.io<http://groups.io/> mailto:igork=ami@groups.i

Re: [edk2-devel] [PATCH] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Hi Nickle and Abner, What is your opinion – should we have GetHiIpProtocolType fuction as a static one? Thank you, Igor From: devel@edk2.groups.io On Behalf Of Igor Kulchytskyy via groups.io Sent: Monday, November 6, 2023 9:14 AM To: M M Cc: devel@edk2.groups.io; Abner Chang ; Nickle Wang

Re: [edk2-devel] [PATCH] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

** Hi Igor please find my comments below. On Tue, Oct 31, 2023 at 8:56 PM Igor Kulchytskyy via groups.io<http://groups.io/> mailto:igork=ami@groups.io>> wrote: Supported function of the driver changed to wait for all newtwork interface to be installed. Filer out the network in

Re: [edk2-devel] [PATCH v2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Fixed and resubmitted. Get Outlook for Android<https://aka.ms/AAb9ysg> From: devel@edk2.groups.io on behalf of Igor Kulchytskyy via groups.io Sent: Friday, November 3, 2023 2:01:36 PM To: Mike Maslenkin Cc: devel@edk2.groups.io ; Abner Chang ; Nickl

Re: [edk2-devel] [PATCH v2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Hi Mike, You are absolutely right. I moved that NetworkInterfaceGetSubnetInfo function up, not copied it. But somehow it was copied. My mistake. I will fix it and resubmit. Thank you, Igor -Original Message- From: Mike Maslenkin Sent: Friday, November 3, 2023 11:54 AM To: Igor

Re: [edk2-devel] [PATCH v2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Hi Nickle, I fixed all your comments, Abner and Mike comments. I also created PR https://github.com/tianocore/edk2/pull/4994/ I fixed all Uncrustify errors and CI passed except PatchCheck which shows the error * Missing Signed-off-by! (Note: this must be added by the code contributor!) Which I'm

[edk2-devel] [PATCH v2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Supported function of the driver changed to wait for all newtwork interface to be installed. Filer out the network interfaces which are not supported by Redfish Host Interface. Cc: Abner Chang Cc: Nickle Wang Cc: Mike Maslenkin Signed-off-by: Igor Kulchytskyy ---

Re: [edk2-devel] [PATCH] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** Hi Igor please find my comments below. On Tue, Oct 31, 2023 at 8:56 PM Igor Kulchytskyy

[edk2-devel] [PATCH] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Supported function of the driver changed to wait for all newtwork interface to be installed. Filer out the network interfaces which are not supported by Redfish Host Interface. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Igor Kulchytskyy ---

Re: [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller

Reviewed-by: Igor Kulchytskyy Reviewed the whole PATCH -Original Message- From: Nickle Wang Sent: Thursday, October 26, 2023 9:20 AM To: Igor Kulchytskyy ; Chang, Abner ; devel@edk2.groups.io Cc: Nick Ramirez Subject: RE: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP

Re: [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller

You mean, for the Redfish task functionality other functions will be used? Thank you, Igor -Original Message- From: Nickle Wang Sent: Thursday, October 26, 2023 8:58 AM To: Igor Kulchytskyy ; Chang, Abner ; devel@edk2.groups.io Cc: Nick Ramirez Subject: RE: [EXTERNAL] RE: [PATCH 3/3]

Re: [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller

Hi Nickle, Just one quick question. Is there any sense to return the headers for DELETE request? Thank you, Igor -Original Message- From: Chang, Abner Sent: Thursday, October 26, 2023 2:10 AM To: Nickle Wang ; devel@edk2.groups.io Cc: Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL]

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: introduce PcdRedfishSendReceiveTimeout

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Wednesday, October 18, 2023 9:08 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH] RedfishPkg/RedfishDiscoverDxe: introduce PcdRedfishSendReceiveTimeout **CAUTION: The

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: fix JsonObjectGetValue issue

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: Nickle Wang Sent: Monday, September 18, 2023 9:09 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH] RedfishPkg/JsonLib: fix JsonObjectGetValue issue

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: fix JsonObjectGetValue issue

Hi Nickle, Yes, I understand the mechanism of how seed works. And when I used the RedfishPkg and Jansson parser in my modules, I passed the seed to each driver, so, all of them used the same seed. All of them call a json_object_seed() function with the same seed. Now, there is no need to do it.

Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: Nickle Wang Sent: Monday, September 18, 2023 9:13 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez ; Mike Maslenkin Subject: [EXTERNAL] [PATCH v2] RedfishPkg/RedfishRestExDxe: return

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: fix JsonObjectGetValue issue

Hi Nickle, Does that mean, that json_object_seed function is useless anymore with those changes? And there is no need for other module to call json_object_seed? Thank you, Igor -Original Message- From: Nickle Wang Sent: Monday, September 18, 2023 9:09 AM To: devel@edk2.groups.io Cc:

Re: [edk2-devel] [PATCH v2 1/1] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue.

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: Nickle Wang Sent: Tuesday, September 12, 2023 3:02 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH v2 1/1] RedfishPkg/RedfishPlatformConfigDxe: fix can not

Re: [edk2-devel] [PATCH v2 6/6] RedfishClientPkg: spelling fixes

Reviewed-by: Igor Kulchytskyy Reviewed the whole patch V2 Regards, Igor Kulchytskyy -Original Message- From: Mike Maslenkin Sent: Tuesday, August 29, 2023 4:01 AM To: devel@edk2.groups.io Cc: abner.ch...@amd.com; nick...@nvidia.com; Igor Kulchytskyy ; Mike Maslenkin Subject: [EXTERNAL]

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue.

Thank you, Nickle. -Original Message- From: Nickle Wang Sent: Thursday, August 03, 2023 2:00 AM To: Igor Kulchytskyy ; devel@edk2.groups.io Cc: Abner Chang ; Nick Ramirez Subject: RE: [EXTERNAL] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue. Hi Igor,

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: fix netmask check issue

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Monday, July 24, 2023 8:15 PM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH] RedfishPkg/RedfishDiscoverDxe: fix netmask check issue **CAUTION: The

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Saturday, July 22, 2023 4:18 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue.

Hi Nickle, May I ask you a question. What is the point to allocate and copy buffer. Then delete the original buffer. Could we just assign StatementValue->Buffer to TempBuffer and then assign NULL to StatementValue->Buffer? TempBuffer = StatementValue->Buffer; StatementValue->Buffer = NULL;

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: multiple definitions of strncpy.

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Saturday, July 22, 2023 4:18 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH] RedfishPkg/RedfishCrtLib: multiple definitions of strncpy. **CAUTION: The

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add patch check

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Monday, June 12, 2023 11:15 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy Subject: [EXTERNAL] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add patch check **CAUTION: The e-mail below

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add build check and uncrustify check

Thank you, Nickle Get Outlook for Android From: Chang, Abner Sent: Wednesday, June 7, 2023 8:28:11 PM To: Nickle Wang ; devel@edk2.groups.io Cc: Igor Kulchytskyy Subject: [EXTERNAL] RE: [edk2-redfish-client][PATCH]

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix value type issue.

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Monday, May 29, 2023 2:24 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix value type issue. **CAUTION: The e-mail below is

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: Fix string assert issue

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Monday, May 15, 2023 12:25 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: Fix string assert issue **CAUTION: The e-mail below is

Re: [edk2-devel] [edk2-redfish-client][PATCH v2] Initial edk2 redfish client repository

Hi Nickle, Sorry for the delay. Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Friday, April 21, 2023 10:45 PM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Michael D Kinney Subject: [EXTERNAL] [edk2-redfish-client][PATCH v2] Initial edk2

Re: [edk2-devel] [PATCH] RedfishPkg: Remove the global variables related to Discover Token functionality

Hi Abner, I created PR. https://github.com/tianocore/edk2/pull/4297 Since it is my first PR created, I'm not sure if everything done correctly. Please double check everything. Thank you, Igor -Original Message- From: Chang, Abner Sent: Thursday, April 20, 2023 8:13 PM To: Igor

[edk2-devel] [PATCH V2] RedfishPkg: Remove the Discover Token global variables

gRedfishDiscoveredToken may be allocated several times, if multiple NIC installed on the system. To avoid this issue Discover Token related global variables replaced with the local variables. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Igor Kulchytskyy ---

Re: [edk2-devel] [PATCH] RedfishPkg: Remove the global variables related to Discover Token functionality

Hi Abner, I did what you asked to do - Patchcheck.py and UncrustiyCheck (got binary). Going to send PATCH V2. But I'm not sure what happened with white space. Going to check with MIS. Thank you, Igor -Original Message- From: Chang, Abner Sent: Wednesday, April 19, 2023 9:00 PM To: Igor

Re: [edk2-devel] [PATCH v3 0/5] Introduce EDKII Redfish Platform Config Protocol

Full PATCH reviewed Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Wednesday, April 19, 2023 5:09 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH v3 0/5] Introduce EDKII Redfish Platform Config

[edk2-devel] [PATCH] RedfishPkg: Remove the global variables related to Discover Token functionality

gRedfishDiscoveredToken may be allocated several times, if multiple NIC installed on the system. To avoid this issue Discover Token related global variables replaced with the local variables. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Igor Kulchytskyy ---

Re: [edk2-devel] [PATCH v4] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Wednesday, March 29, 2023 1:33 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH v4] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

Hi Nickle, It looks good except one small question I would like to raise. Please check my comment below. Thank you, Igor -Original Message- From: Nickle Wang Sent: Monday, March 27, 2023 9:42 PM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject:

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

Thank you, Nickle. -Original Message- From: Nickle Wang Sent: Sunday, March 12, 2023 8:05 AM To: Igor Kulchytskyy ; devel@edk2.groups.io Cc: Abner Chang ; Nick Ramirez Subject: RE: [EXTERNAL] [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation Hi Igor, Thank you

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

Hi Nickle, See my comments below the text. Thank you, Igor -Original Message- From: Nickle Wang Sent: Wednesday, March 8, 2023 2:21 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib:

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishConfigHandler: fix FreePool issue

Hi Abner, Yes, I will work on this to create the linked list. Thank you, Igor -Original Message- From: Chang, Abner Sent: Tuesday, February 14, 2023 1:55 AM To: Igor Kulchytskyy ; devel@edk2.groups.io Cc: Nickle Wang Subject: [EXTERNAL] RE: [PATCH] RedfishPkg/RedfishConfigHandler: fix

  1   2   >