回复: Re: [edk2-devel] [Patch V6 4/4] UefiCpuPkg:Wake up APs after power-up or RESET through SIPI.

2023-07-28 Thread Jeff Fan via groups.io
Yuanhao, Sorry. I are missing the following updating. +if ((CpuMpData->InitFlag == ApInitConfig) Please ignore my last comments ! :-) Reviewed-by: Jeff Fan Thanks! Jeff fanjianf...@byosoft.com.cn 发件人: fanjianf...@byosoft.com.cn 发送时间: 2023-07-28 14:49 收件人: devel@edk2.groups

Re: [edk2-devel] [Patch V6 4/4] UefiCpuPkg:Wake up APs after power-up or RESET through SIPI.

2023-07-28 Thread Jeff Fan via groups.io
Yuanhao, Have you verirfed whether APs could be waken-up from ApInHltLoop state or not? Thanks! Jeff fanjianf...@byosoft.com.cn From: Yuanhao Xie Date: 2023-07-28 14:25 To: devel CC: Eric Dong; Ray Ni; Rahul Kumar; Gerd Hoffmann; Yuanhao Xie Subject: [edk2-devel] [Patch V6 4/4]

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-18 Thread Jeff Fan via groups.io
Ray, If you chooses assembly solution, you'd better to consider stack adjust to follow calling convention. Otherwise, it may break some debugger tools to do call stack trace. Jeff fanjianf...@byosoft.com.cn From: Ni, Ray Date: 2023-05-19 10:53 To: Andrew (EFI) Fish; devel@edk2.groups.io;

Re: [edk2-devel] [PATCH V7 36/37] UefiCpuPkg: Setting initial-count register as the last step

2022-05-19 Thread Jeff Fan
Ray, Could we add one API (like InitializeApicTimerEx) to intialize CPU local APCI with additional parameter to indicate if interrupt is to be enabled or not? Just like HPE's solution. Jeff fanjianf...@byosoft.com.cn From: Henz, Patrick Date: 2022-05-20 05:54 To: devel@edk2.groups.io;

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuStackGuard property

2022-04-12 Thread Jeff Fan
Please correct the commit message which confused me. It should be "Update the PcdCpuStackGuard to support PcdsPatchableInModule, PcdsDynamci and PcdsDynamciEx ... ..." Thanks! Jeff fanjianf...@byosoft.com.cn From: Chen, Gang C Date: 2022-04-11 18:13 To: devel CC: guomin.jiang; dandan.bi;

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuStackGuard property

2022-04-12 Thread Jeff Fan
On 32bit protectd mode, is there any impact if PcdCpuStackGuard is set to TRUE? Even thers is no page table enabling at that time. Best Regards, Jeff fanjianf...@byosoft.com.cn From: Chen, Gang C Date: 2022-04-11 22:51 To: Ni, Ray; devel@edk2.groups.io; Liu, Shuo CC: Jiang, Guomin; Bi,

Re: [edk2-devel] I think we need a Panic API...

2022-02-09 Thread Jeff Fan
Ray, EFI_SYSTEM_CONTEXT was defined in MdePkg/Include/Protocol/DebugSupport.h Jeff fanjianf...@byosoft.com.cn From: Ni, Ray Date: 2022-02-10 10:54 To: Andrew Fish; edk2-devel-groups-io Subject: Re: [edk2-devel] I think we need a Panic API... Andrew, I agree Panic is useful because ASSERT is

Re: [edk2-devel] Read SPI BAR offset 0x10 throwing processor exception

2022-01-28 Thread Jeff Fan
Ranga, What's CR2 value in Exception dump information?It holds the actual address occurred PF exception. ExceptionData - P:0 means no page transition in page table. Jeff fanjianf...@byosoft.com.cn From: Rao G Date: 2022-01-28 21:08 To: Michael Brown CC: devel Subject: Re:

Re: [edk2-devel] [PATCH v4 1/1] MdeModulePkg: Add MpServicesTest application to exercise MP Services

2021-12-29 Thread Jeff Fan
I expect there to only ever be a single MP services instance. I agree that the AP function should do something, but I'm hoping to get this initial implementation committed first. -- Rebecca Cran On 12/29/21 20:21, Jeff Fan wrote: Hi,Rebecca I'd like to give two comments on this pat

Re: [edk2-devel] [PATCH v4 1/1] MdeModulePkg: Add MpServicesTest application to exercise MP Services

2021-12-29 Thread Jeff Fan
Hi,Rebecca I'd like to give two comments on this patch. 1, I don't think there are more than one MP services instances installed reuirement on one system. X86 platform installed one MP service instance even on mutiple-sockets system. For ARM platform, is there any requirement to handle

Re: [edk2-devel] [PATCH edk2 v1 1/3] StandaloneMmPkg: Fix issue about SpPcpuSharedBufSize field

2021-12-16 Thread Jeff Fan
You may try to enlarger stmm_ns_comm_buf_size in Optee to check if it could solve ASSERT issue. fanjianf...@byosoft.com.cn From: Masahisa Kojima Date: 2021-12-16 16:07 To: Ard Biesheuvel CC: Ming Huang; Masami Hiramatsu; edk2-devel-groups-io; Sami Mujawar; Ard Biesheuvel; Jiewen Yao;

Re: [edk2-devel] [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal

2021-10-12 Thread Jeff Fan
OVMF did a similare change on Time Driver, please refer to https://github.com/tianocore/edk2/commit/239b50a863704f7960525799eda82de061c7c458 I do not think this will be apply for ArmPkg/TimerDxe. If one real issue happened on platform, it seems that interrupt was reenabled by reigstered

Re: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

2021-09-27 Thread Jeff Fan
ianf...@byosoft.com.cn From: Jeff Fan Date: 2021-09-27 16:50 To: devel@edk2.groups.io; mhaeuser; Ni, Ray; 'gaoliming'; Chan, Amy; 'Andrew Fish' CC: Kinney, Michael D; 'Gao, Liming'; Liu, Zhiguang; Wang, Jian J; Gao, Zhichao Subject: Re: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg For former ca

Re: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

2021-09-27 Thread Jeff Fan
For former caller, they could still keep as is to call the old API in MdeModulePkg. I think Ray's design is compatible change for existing code. Only when the existing code wants to remove the dependency on MdeModuelPkg, they could migrate to the new API in baselib. I agree with one split-API

Re: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

2021-09-26 Thread Jeff Fan
Making baselib implementation depend on MemoryAllocationLib (indirectly on Pei Service and gBS), it may prevent this base API using at some seneraio. i don't think it's better. Add this parameter and make this parameter is optional, 1, when NULL, use the local 256 bytes stack 2, if 256 bytes

Re: [edk2-devel] SLDP: Usage of PE library context by debugger?

2021-08-01 Thread Jeff Fan
Marvin, ImageBase was saved in DR2 to help HOST debugger to locate the image base more easily, even though the HOST debugger could find the image base through searching the DOS image signagure. The reason choosing DR1 and DR2 to save PDB & ImageBase contexts is just implementation only. And

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-22 Thread Jeff Fan
groups.io On Behalf Of Jeff Fan Sent: Tuesday, February 23, 2021 11:43 AM To: devel@edk2.groups.io; Ni, Ray ; Ma, Maurice ; Patrick Rudolph ; Dong, Guo ; Dong, Eric Cc: devel@edk2.groups.io; You, Benjamin Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA R

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-22 Thread Jeff Fan
Ray, Yes. You are right. Acutally, x64 IDT table cannot work correctly on protected mode. :-) But for GDT location, I agree it should be located under 4G space to support AP mode changing. But we could allocate room under 4G for GDT table directly in CpuDxe. Thanks, Jeff From: Ni, Ray