ation
> repository.
>
> The Configuration Manager can then utilise this information
> to generate ACPI tables for the platform.
>
> Therefore, define an interface for the HwInfoParser library
> class.
>
Reviewed-by: Joey Gouly
Thanks,
Joey
-=-=-=-=-=-=-=-=-=-=-=-
Grou
Signed-off-by: Sami Mujawar
> ---
> ArmVirtPkg/ArmVirtKvmTool.dsc | 10 ++
> ArmVirtPkg/ArmVirtKvmTool.fdf | 5 +
> 2 files changed, 15 insertions(+)
>
Tested on Juno running kvmtool.
Tested-by: Joey Gouly
Thanks,
Joey
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive a
.
>
> Therefore, enable the EFI_RNG_PROTOCOL for Juno platform.
>
> Signed-off-by: Sami Mujawar
> ---
> Platform/ARM/JunoPkg/ArmJuno.dsc | 10 +-
> Platform/ARM/JunoPkg/ArmJuno.fdf | 7 ++-
> 2 files changed, 15 insertions(+), 2 deletions(-)
>
Tested on J
Hi again,
Replies inline,
>
> Hi Joey,
> Thanks for the review, I answered inline:
>
>
> On 9/24/21 9:56 AM, Joey Gouly wrote:
> > Hi,
> >
> > This looks good to me!
> >
> > [...]
> >
> >> +
> >> +/** A parser
Lib.inf
> +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf
> @@ -15,6 +15,8 @@ [Defines]
>LIBRARY_CLASS = TableHelperLib
>
> [Sources]
> + ConfigurationManagerObjectParser.c
> + ConfigurationManagerObjectParser.h
>TableHelper.c
>
> [Packa
From: Marc Moisson-Franckhauser
Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378)
This option informs the parser to generate a dot graph of a table.
This can be useful to understand or debug a table, such as the PPTT
table.
Signed-off-by: Joey Gouly
---
ShellPkg/Library
This series adds functionality to print a dot graph of a PPTT table.
This helps with understanding and debugging PPTT tables.
The dot graph generator functionality is generic and could be used by
other tables that would benefit from graph output.
Bugzilla: 3378
From: Marc Moisson-Franckhauser
Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378)
This is preparation for adding a second flag to the parsers.
Signed-off-by: Joey Gouly
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 77
From: Marc Moisson-Franckhauser
Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378)
These can be used to generate dot files, that can be used to visualise
graphs in tables, such as PPTT.
Signed-off-by: Joey Gouly
---
ShellPkg/Library/UefiShellAcpiViewCommandLib
From: Marc Moisson-Franckhauser
Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378)
This generates a dot file from the PPTT table that can be used to
visualise the topology of the CPUs and Caches.
Signed-off-by: Joey Gouly
---
ShellPkg/Library/UefiShellAcpiViewCommandLib
From: Marc Moisson-Franckhauser
Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378)
This new helper will not overwrite existing files, by appending a number
to the end of the filename.
Signed-off-by: Joey Gouly
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.h | 25
Building with Clang showed that `RootComplexCount` and
`DeviceIdMappingArrayCount` were unused. Use the
variables where they were intended to be used.
Signed-off-by: Joey Gouly
---
The changes can be seen at
https://github.com/jgouly/edk2-platforms/tree/1766_vexpress_count_v1
Platform/ARM
>From: Joey Gouly
> Sent: 09 March 2021 16:45
> Subject: [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3
Â
Hi,
A little ping on this. Can someone take a look?
There was a similar patch here, that addressed the same issue
https://edk2.groups.io/g/devel/topic/82327316
> From: Joey Gouly
> Sent: 07 May 2021 11:37
> The changes can be seen at
> https://github.com/jgouly/edk2/tree/1484_pptt_dot_graph_v1
The CI on github showed some coding style issues with this series. I will fix
those locally but wait for more review comments before I send a
From: Marc Moisson-Franckhauser
Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378)
This new helper will not overwrite existing files, by appending a number
to the end of the filename.
Signed-off-by: Marc Moisson-Franckhauser
Signed-off-by: Joey Gouly
---
ShellPkg/Library
From: Marc Moisson-Franckhauser
Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378)
This is preparation for adding a second flag to the parsers.
Signed-off-by: Marc Moisson-Franckhauser
Signed-off-by: Joey Gouly
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h
From: Marc Moisson-Franckhauser
Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378)
These can be used to generate dot files, that can be used to visualise
graphs in tables, such as PPTT.
Signed-off-by: Marc Moisson-Franckhauser
Signed-off-by: Joey Gouly
---
ShellPkg/Library
-off-by: Joey Gouly
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h|
2 ++
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewConfig.h|
3 ++-
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c |
9 +++-
ShellPkg
This series adds functionality to print a dot graph of a PPTT table.
This helps with understanding and debugging PPTT tables.
The dot graph generator functionality is generic and could be used by
other tables that would benefit from graph output.
Bugzilla: 3378
From: Marc Moisson-Franckhauser
Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378)
This generates a dot file from the PPTT table that can be used to
visualise the topology of the CPUs and Caches.
Signed-off-by: Marc Moisson-Franckhauser
Signed-off-by: Joey Gouly
This matches the ACPI spec 6.3, table 5.1: Generic Address Structure.
Signed-off-by: Joey Gouly
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
b
introduced in CM_ARM_SERIAL_PORT_INFO object.
This patch updates the SPCR generator to setup the AccessSize
field in the Generic Address Structure (GAS) for the UART in
the SPCR table with information provided by the platform.
Signed-off-by: Joey Gouly
---
DynamicTablesPkg/Library/Acpi/Arm
This series adds the Access Size parameter to the Serial Port in
DynamicTablesPkg.
This has been tested (by Sami) with kvmtool, which virtualises a UART
with 8 bit access size.
Changes available at
https://github.com/jgouly/edk2/tree/1586_serial_port_access_size_v1
Joey Gouly (4):
ShellPkg
Add access size to CM_ARM_SERIAL_PORT_INFO so that this can be
passed down to the Generic Address Structure.
Signed-off-by: Joey Gouly
---
DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h
b
introduced in CM_ARM_SERIAL_PORT_INFO object.
This patch updates the DBG2 generator to setup the AccessSize
field in the Generic Address Structure (GAS) for the UART in
the DBG2 table with information provided by the platform.
Signed-off-by: Joey Gouly
---
DynamicTablesPkg/Library/Acpi/Arm
> Hi Joey,
>
> Can you confirm that your sign-off ID is correct, please?
> Otherwise this patch looks good to me.
That was silly to typo my own name!
Signed-off-by: Joey Gouly
Thanks for the review!
Joey
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent t
According to ACPI 6.4, 6.1.5 _HID states:
- A valid PNP ID must be of the form "AAA" where A is an uppercase
letter and # is a hex digit.
- A valid ACPI ID must be of the form "" where N is an uppercase
letter or a digit ('0'-'9') and # is a hex digit.
> From: devel@edk2.groups.io on behalf of Ni, Ray via
> groups.io
> Is this for ARM only?
Yes, the GIC interrupt controller is for Arm only.
Thanks,
Joey
IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended
). However, maximum value (0x1f) is a special case
since that would indicate that 1024 interrupts are implemented.
Add handling for this special case in ArmGicGetMaxNumInterrupts.
Signed-off-by: Andreas Sandberg
Signed-off-by: Joey Gouly
---
The changes can be seen at
https://github.com/jgouly/edk2
> From: Joey Gouly
> Subject: [PATCH v2 1/1] ShellPkg: Validate that the Boot CPU is present in
> MADT
>
> The ACPI 6.3 Specification, January 2019, section 5.2.12.14 states that
> the firmware must convey each processor’s GIC information to the OS using
> the GICC str
Some platforms advertise support for a 16550 UART, but are not
compatible with the PNP0500 HID. Allow them to override the HID by
setting PcdNonBsaCompliant16550SerialHid.
Signed-off-by: Joey Gouly
---
DynamicTablesPkg/DynamicTablesPkg.dec
| 3
://github.com/jgouly/edk2/tree/1588_non_sbsa_hid_v2
v2:
- Renamed PcdNonSbsaCompliantSerialHid to PcdNonBsaCompliant16550SerialHid
Joey Gouly (2):
DynamicTablesPkg: Don't use gEfiMdeModulePkgTokenSpaceGuid
DynamicTablesPkg: Add an override for 16550 HID in SSDT
DynamicTablesPkg
Introduce gEdkiiDynamicTablesPkgTokenSpaceGuid and use that instead.
Signed-off-by: Joey Gouly
Reviewed-by: Liming Gao
---
DynamicTablesPkg/DynamicTablesPkg.dec |
10 ++
DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf
://github.com/jgouly/edk2/tree/1588_non_sbsa_hid_v1
Joey Gouly (2):
DynamicTablesPkg: Don't use gEfiMdeModulePkgTokenSpaceGuid
DynamicTablesPkg: Add an override for 16550 HID in SSDT
DynamicTablesPkg/DynamicTablesPkg.dec | 13 +
.../DynamicTableFactoryDxe.inf
Some platforms advertise support for a 16550 UART, but are not
compatible with the PNP0500 HID. Allow them to override the HID by
setting PcdNonSbsaCompliantSerialHid.
Signed-off-by: Joey Gouly
---
DynamicTablesPkg/DynamicTablesPkg.dec
| 3
Introduce gEdkiiDynamicTablesPkgTokenSpaceGuid and use that instead.
Signed-off-by: Joey Gouly
---
DynamicTablesPkg/DynamicTablesPkg.dec |
10 ++
DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf |
8
2 files
36 matches
Mail list logo
