Removes Michael Kubacki as an Intel maintainer.
Cc: Prince Agyeman
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
Maintainers.txt | 6 --
1 file changed, 6 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index
Shenglei ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Kubacki, Michael A
>
> Subject: [edk2-platforms] [PATCH] BoardModulePkg: Fix ECC Coding Style
> Issues
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2453
>
> Fixed coding style issues as reported by the ECC
This change makes the following updates to Section 8 - Stage VI
Advanced Feature Selection:
* Remove the advanced feature template
* This is no longer provided in the specification but maintained
in the Readme.md file in edk2-platforms/Features/Intel/Readme.md
* Remove the following
Adds FvAdvancedPreMemory as a Stage VI firmware volume.
Cc: Sai Chaganty
Cc: Nate DeSimone
Signed-off-by: Michael Kubacki
---
8_stage_6_advanced_feature_selection/82_firmware_volumes.md | 27 ++-
8_stage_6_advanced_feature_selection/83_configuration.md| 12 +-
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2417
Performance impact is an important consideration for feature
integration. This new section captures the general expectation
for overall boot performance impact due to using an advanced
feature.
Cc: Dandan Bi
Cc: Sai Chaganty
Cc: Chasel
Since I don't have a strong opinion either, I won't make any changes to V1 at
this time.
Thanks,
Michael
> -Original Message-
> From: Wang, Jian J
> Sent: Tuesday, January 14, 2020 8:09 PM
> To: Kubacki, Michael A ;
> devel@edk2.groups.io
> Cc: Gao, Liming ;
-Original Message-
> From: Wang, Jian J
> Sent: Monday, January 13, 2020 10:43 PM
> To: devel@edk2.groups.io; Kubacki, Michael A
>
> Cc: Gao, Liming ; Kinney, Michael D
> ; Michael Turner
> ; Wu, Hao A
> Subject: RE: [edk2-devel] [PATCH V1 1/1] MdeModulePkg/Variable:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2457
This commit fixes an offset calculation that is used to write the
VarErrorFlag UEFI variable to the UEFI variable runtime cache.
Currently a physical address is used instead of an offset. This
commit changes the offset to zero with a length
> Sent: Thursday, January 9, 2020 7:29 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chaganty, Rangasai V
> ; Ni, Ray ; Gao, Liming
> ; Zhang, Shenglei ; Chen,
> Marc W
> Subject: [edk2-devel][edk2-platforms][PATCH v4]
> IntelSiliconPkg/Feature/SmmAccess/*: Fix inco
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Chen, Marc W
> Sent: Thursday, January 9, 2020 1:09 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chaganty, Rangasai V
> ; Ni, Ray ; Gao, Liming
> ; Zhang, Shenglei ;
> Chen, Marc W
>
scription in SmmAccessDriver.h
With these updates:
Reviewed-by: Michael Kubacki
Thanks,
Michael
> -Original Message-
> From: Chen, Marc W
> Sent: Wednesday, December 25, 2019 10:53 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chaganty, Rangasai V
> ; Gao, Liming
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Friday, December 13, 2019 5:32 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms] [PATCH 02/11] Boar
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Friday, December 13, 2019 5:33 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Kubacki,
> Michael A
> Subject: [edk2-platforms] [PATCH 10/11] SimicsOpenBoardPkg: Add BDS
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Friday, December 13, 2019 5:33 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms] [PATCH 06/11] Boa
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Friday, December 13, 2019 5:33 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Kubacki,
> Michael A
> Subject: [edk2-platforms] [PATCH 09/11] SimicsOpenBoardPkg: A
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Friday, December 13, 2019 5:33 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms] [PATCH 05/11] MinP
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Friday, December 13, 2019 5:32 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms] [PATCH 01/11] MinP
oups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms] [PATCH 04/11] MinPlatformPkg: Add BDS Board
> Boot Manager library
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
>
> As Minplatform's PlatformBootManager libr
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Friday, December 13, 2019 5:33 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms] [PATCH 11/11] Sim
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Friday, December 13, 2019 5:32 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms] [PATCH 03/11] Boar
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Friday, December 13, 2019 5:33 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms] [PATCH 08/11] Whis
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Friday, December 13, 2019 5:33 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms] [PATCH 07/11] Kabyl
Adds a dynamic PCD that specifies whether the feature is active.
This is useful because the feature might be enabled via FeatureFlag
PCD PcdAcpiDebugFeatureEnable meaning it is built and included in
the flash image but the board might need to control whether the
feature is active based on input
nks,
Michael
> -Original Message-
> From: Ni, Ray
> Sent: Monday, December 16, 2019 12:50 AM
> To: Kubacki, Michael A
> Cc: Desimone, Nathaniel L ;
> devel@edk2.groups.io; Chiu, Chasel ; Agyeman,
> Prince
> Subject: RE: [edk2-devel] [edk2-platforms] [PATCH 01/11] Min
From: "Agyeman, Prince"
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2409
Updated WhiskeylakeURvp PCDs to enable FSP/BL stack sharing.
This fixes the boot failure seen with the latest Coffee Lake (CFL)
FSP binary (v 7.0.68.41).
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Michael Kubacki
e ; Desimone, Nathaniel L
>
> Cc: Kubacki, Michael A ;
> devel@edk2.groups.io
> Subject: RE: [edk2-platforms] [PATCH v2] WhiskeylakeOpenBoardPkg:
> Update PCDs to enable stack sharing
>
>
> Hi Nate, Prince,
>
> I would recommend that we set larger
> gSiPkgTokenS
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Wednesday, December 11, 2019 5:13 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Kubacki, Michael A
>
> Subject: [edk2-platforms] [PATCH] WhiskeylakeO
Please include [edk2-platforms] in the subject in the future.
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Friday, December 6, 2019 9:32 AM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Kubacki,
> Michael A
Phil, thanks for your effort to put this together.
Reviewed-by: Michael Kubacki
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Philippe
> Mathieu-Daudé
> Sent: Friday, December 6, 2019 3:26 AM
> To: devel@edk2.groups.io
> Cc: Philippe Mathieu-Daude
Removes the ACPI Debug feature from DebugFeaturePkg. The feature
does not follow the advanced feature design. The feature has been
moved to Features/Intel/Debugging/AcpiDebugFeaturePkg.
Cc: Eric Dong
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
Cc: Dandan Bi
Cc: Sai Chaganty
Cc: Eric Dong
Cc: Liming Gao
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
Maintainers.txt | 32 ++--
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index cb7ae0a95d..8cea67e310
Removes the S3 feature from AdvancedFeaturePkg. The feature does
not follow the advanced feature design. The feature has been moved
to Features/Intel/PowerManagement/S3FeaturePkg.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
This change removes the remaining files in AdvancedFeaturePkg that
were located in Platform/Intel.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec
| 30
This change updates the FvReportLib instance in MinPlatformPkg to
only install advanced feature firmware volumes if the advanced
feature stage should be active.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
This change enables advanced features to be used by the
GalagoPro3 board in KabylakeOpenBoardPkg.
Some platform macros in OpenBoardPkg.dsc are consolidated so all
values are set at the top of the file before including advanced
feature code.
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by:
Updates advanced feature references in SimicsOpenBoardPkg to the
new advanced feature packages in Features/Intel. Previously, the
advanced features in Platform/Intel were used.
SimicsOpenBoardPkg currently uses the SMBIOS and Network advanced
features. These are the same features used by the
This change enables advanced features to be used by the
WhiskeylakeURvp board in WhiskeylakeOpenBoardPkg.
Some platform macros in OpenBoardPkg.dsc are consolidated so all
values are set at the top of the file before including advanced
feature code.
Cc: Chasel Chiu
Cc: Nate DeSimone
This change adds the ability for board packages built with
build_bios.py to build advanced features located in
Features/Intel.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Agyeman Prince
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
Platform/Intel/build.cfg | 1
Updates the advanced feature location referenced in Readme.md to
edk2-platforms/Features/Intel.
Cc: Dandan Bi
Cc: Sai Chaganty
Cc: Eric Dong
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
Platform/Intel/Readme.md | 14 +++---
1 file
This change enables advanced features to be used by the
KabylakeRvp3 board in KabylakeOpenBoardPkg.
Some platform macros in OpenBoardPkg.dsc are consolidated so all
values are set at the top of the file before including advanced
feature code.
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by:
This change adds two new macros to OpenBoardPkg.dsc that identify
the build architecture for PEI and DXE modules. The intention of
this macro is to ensure that all DSC files that compose the package
build (such as those included from MinPlatformPkg or an advanced
feature package) build
This change updates OpenBoardPkg.dsc to use the PEI_ARCH and
DXE_ARCH specified in the DSC file for the board package components.
An EDK II build limitation currently prevents the macros from
being able to be used, so a todo has been placed with the action
needed when the BaseTools update is
This change adds a standalone firmware volume for pre-memory
advanced features called FvAdvancedPreMemory to the flash map.
Pre-memory advanced feature modules were previously kept in a child
firmware volume of FvAdvanced called FvAdvancedPreMem. This change
simplifies the flash layout and
This change adds two new macros to OpenBoardPkg.dsc that identify
the build architecture for PEI and DXE modules. The intention of
this macro is to ensure that all DSC files that compose the package
build (such as those included from MinPlatformPkg or an advanced
feature package) build
Adds FDF files that group all currently available advanced features
so they can be conveniently included into board packages.
The Minimum Platform defines two firmware volumes for advanced
features: FvAdvancedPreMemory and FvAdvanced.
This change provides all pre-memory advanced feature modules
This change adds a new firmware volume to MinPlatformPkg called
FvAdvancedPreMemory. This firmware volume is used to hold advanced
feature modules that must be available in pre-memory.
Previously, these modules were kept as an uncompressed child FV in
FvAdvanced. However, in memory constrained
This change adds a standalone firmware volume for pre-memory
advanced features called FvAdvancedPreMemory to the flash map.
Pre-memory advanced feature modules were previously kept in a child
firmware volume of FvAdvanced called FvAdvancedPreMem. This change
simplifies the flash layout and
This change adds two new macros to OpenBoardPkg.dsc that identify
the build architecture for PEI and DXE modules. The intention of
this macro is to ensure that all DSC files that compose the package
build (such as those included from MinPlatformPkg or an advanced
feature package) build
This change adds a temporary build workaround to allow the advanced
feature PCDs to be used in conditional statements in DSC files even
if they are not referenced in INF files.
Support to allow a FeaturePCD to be used in a conditional statement
without being referenced in an INF file has been
Adds a new feature package for the Network feature.
The Network feature code is actually in edk2/NetworkPkg at this
time so this package inclues the content from edk2/NetworkPkg. In
the future, it is preferred to move the source code from
NetworkPkg to NetworkFeaturePkg.
Cc: Sai Chaganty
Cc:
This change adds the modules for the IPMI feature to
IpmiFeaturePkg.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec
| 8 +
This change adds the libraries required for the IPMI feature to
IpmiFeaturePkg.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec
| 9 +
Adds the Readme.md file to briefly explain the types of features
supported in the OutOfBandManagement feature domain directory.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
Features/Intel/OutOfBandManagement/Readme.md | 8
1 file changed, 8 insertions(+)
diff
This change adds AdvancedFeaturePkg to the Features/Intel
directory. AdvancedFeaturePkg is a special package that is
located at the root level of Features/Intel.
All advanced features can be built using the AdvancedFeaturePkg
build. To build all advanced features, follow the instructions in
the
Updates the PCD string default values so they are generic. The
PCDs should be customized by the package that uses the feature.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec
Adds the Readme.md file to briefly explain the types of features
supported in the Network feature domain directory.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
Features/Intel/Network/Readme.md | 5 +
1 file changed, 5 insertions(+)
diff
Adds a new feature package for the SMBIOS feature.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec
| 172
Adds a new feature package for the S3 feature.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dec | 30 +
Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc | 122
Adds a new feature package for the ACPI Debug feature.
Cc: Eric Dong
Cc: Liming Gao
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec
| 39 ++
Adds a new feature package for the IPMI feature.
This change updates the advanced feature package template for IPMI
and adds the updated template to the IpmiFeaturePkg.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
Adds the Readme.md file to briefly explain the types of features
supported in the UserInterface feature domain directory.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
Features/Intel/UserInterface/Readme.md | 9 +
1 file changed, 9
Adds the Readme.md file to briefly explain the types of features
supported in the Debugging feature domain directory.
Note that the domain directory is named "Debugging" as opposed to
"Debug" to help indicate that the directory is related to features
used for debugging and it is not an output
This change adds a new package called TemplateFeaturePkg that
should be used as a starting point for the creation of new advanced
feature packages.
TemplateFeaturePkg is not meant to be built or used directly for
functionality. It simply serves as a template to be copied and
modified. The
Adds the Readme.md file to briefly explain the types of features
supported in the SystemInformation feature domain directory.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
Features/Intel/SystemInformation/Readme.md | 8
1 file changed,
This change adds the initial Readme.md to the root of the Features/
Intel directory. The features are maintained in an Intel
directory because they are not tested on other systems. If there
is interest to support a feature on systems other than Intel, the
feature should be tested on those other
This change refactors DebugFeaturePkg.dsc to consolidate
redundant sections and better group file content to improve
maintainability and readability.
This pattern is being applied in all Minimum Platform package
DSC files.
Cc: Eric Dong
Cc: Liming Gao
Signed-off-by: Michael Kubacki
s://github.com/makubacki/edk2-platforms/tree/advanced_feature_reorg_v2
Cc: Agyeman Prince
Cc: Chasel Chiu
Cc: Dandan Bi
Cc: Eric Dong
Cc: Isaac W Oram
Cc: Liming Gao
Cc: Nate DeSimone
Cc: Sai Chaganty
Cc: Wei David Y
Signed-off-by: Michael Kubacki
Michael Kubacki (47):
AdvancedFeat
This change refactors AdvancedFeaturePkg.dsc to consolidate
redundant sections and better group file content to improve
maintainability and readability.
This pattern is being applied in all Minimum Platform package
DSC files.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Michael Kubacki
This change refactors UserInterfaceFeaturePkg.dsc to consolidate
redundant sections and better group file content to improve
maintainability and readability.
This pattern is being applied in all Minimum Platform package
DSC files.
Cc: Dandan Bi
Cc: Liming Gao
Signed-off-by: Michael Kubacki
Adds the Readme.md file to briefly explain the types of features
supported in the PowerManagement feature domain directory.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
Features/Intel/PowerManagement/Readme.md | 10 ++
1 file changed,
Yes, I reordered the patch series this way in V2 and I will update the closed
source platforms before the old advanced feature dependencies are removed.
Thanks,
Michael
> -Original Message-
> From: Bi, Dandan
> Sent: Monday, November 18, 2019 12:41 AM
> To: Kubacki, Michael
ups.io; Kubacki, Michael A
>
> Cc: Bi, Dandan ; Gao, Liming ;
> Wang, Jian J ; Wu, Hao A
> Subject: Re: [edk2-devel] [PATCH V1 2/2] MdeModulePkg PeiCore: Improve
> comment semantics
>
> On 11/27/19 5:06 AM, Kubacki, Michael A via Groups.Io wrote:
> > Clarifies word
This patch clarifies wording in several PeiCore comments to improve
reading comprehension.
Cc: Dandan Bi
Cc: Liming Gao
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Core/Pei/FwVol/FwVol.h | 9
MdeModulePkg/Core/Pei/PeiMain.h
Cc: Dandan Bi
Cc: Liming Gao
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Core/Pei/PeiMain.inf | 10 ++--
MdeModulePkg/Core/Pei/FwVol/FwVol.h | 20
MdeModulePkg/Core/Pei/PeiMain.h | 40
into syntactical
and semantical changes. That suggestion is implemented in this
series.
The Reviewed-by responses were not carried forward so the maintainers
can evaluate this series as a whole. The previous patch has been
dropped.
Cc: Dandan Bi
Cc: Liming Gao
Cc: Jian J Wang
Cc: Hao A Wu
the scope of this change. But I do not agree with maintaining
redundant local copies of edk2 APIs in packages in edk2-platforms.
Thanks,
Michael
> -Original Message-
> From: Chaganty, Rangasai V
> Sent: Tuesday, November 26, 2019 10:43 PM
> To: Kubacki, Michael A ;
> devel@edk2.gro
. That suggestion is implemented in this
series.
The Reviewed-by responses were not carried forward so the maintainers
can evaluate this series as a whole. The previous patch has been
dropped.
Cc: Dandan Bi
Cc: Liming Gao
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Michael Kubacki
Michael Kubacki (2
Clarifies wording in several PeiCore comments to improve
reading comprehension.
Cc: Dandan Bi
Cc: Liming Gao
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Core/Pei/FwVol/FwVol.h | 4 ++--
MdeModulePkg/Core/Pei/PeiMain.h | 11 +-
Cc: Dandan Bi
Cc: Liming Gao
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Core/Pei/PeiMain.inf | 10 ++--
MdeModulePkg/Core/Pei/FwVol/FwVol.h | 20
MdeModulePkg/Core/Pei/PeiMain.h | 40
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2375
The following commits introduced a new implementation of
ResetSystem () in ResetLib instances in KabylakeSiliconPkg:
* 2393cff0d4
* 07fd95c9ca
* 0ad2f057d8
* a6e61d43c9
The PchResetLib instance PeiPchResetLib links against ResetLib and
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2375
Removes a stale ResetSystemLib.h override in KabylakeSiliconPkg
that does not contain the prototype for ResetSystem () and
ResetPlatformSpecific ().
The ResetSystemLib.h file from MdeModulePkg will be used. Any INF
files that did not
not reproduce in VS2015. The new
ResetSystem () implementation that led to the issue was introduced
in the following commits:
* 2393cff0d4
* 07fd95c9ca
* 0ad2f057d8
* a6e61d43c9
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Zhichao Gao
Signed-off-by: Michael Kubacki
Michael
Hi Liming,
I notice that after you applied my most recent patch locally and sent the Pull
Request, the author email is garbled in git log:
Kubacki, Michael A
Whereas in the original patch it is:
Michael Kubacki
Doing a quick grep across the edk2 log, I see quite a few other instances
Reviewed-by: Michael Kubacki
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Liming
> Gao
> Sent: Wednesday, November 20, 2019 11:41 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A
> Subject: [edk2-devel] [edk2-wiki][patch] Move fea
David Y Wei is no longer available as a maintainer. David is removed
as a maintainer for the following packages:
* Platform/Intel/SimicsOpenBoardPkg
* Silicon/Intel/SimicsIch10Pkg
* Silicon/Intel/SimicsX58SktPkg
Cc: Nate DeSimone
Cc: Agyeman Prince
Signed-off-by: Michael Kubacki
---
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, November 21, 2019 12:59 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
> ; Jeremy Soller
> Subject: [edk2-platforms] [PATCH V2 13/14] KabylakeO
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, November 21, 2019 12:59 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Gao, Liming
> Subject: [edk2-platforms] [PATCH V2 14/14] M
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, November 21, 2019 12:59 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Gao, Liming
> Subject: [edk2-platforms] [PATCH V2 11/14] MinPlat
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, November 21, 2019 12:59 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
>
> Subject: [edk2-platforms] [PATCH V2 09/14] WhiskeylakeO
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, November 21, 2019 12:59 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
> ; Chaganty, Rangasai V
>
> Subject: [edk2-platforms] [PATCH V2 05/
The copyright year should be updated in SiliconInit.c
With that change:
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, November 21, 2019 12:59 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
> ;
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, November 21, 2019 12:59 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
>
> Subject: [edk2-platforms] [PATCH V2 07/14] WhiskeylakeOpenBoardPkg:
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, November 21, 2019 12:59 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
>
> Subject: [edk2-platforms] [PATCH V2 12/14] KabylakeOpenBo
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, November 21, 2019 12:59 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
> ; Chaganty, Rangasai V
>
> Subject: [edk2-platforms] [PATCH V2 06/
Reviewed-by: Michael Kubacki
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nate
> DeSimone
> Sent: Thursday, November 21, 2019 12:59 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
> ; Chaganty, Rangasai V
>
> Subject: [
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, November 21, 2019 12:59 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Gao, Liming
> Subject: [edk2-platforms] [PATCH V2 10/14] MinPlat
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, November 21, 2019 12:59 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
>
> Subject: [edk2-platforms] [PATCH V2 08/14] WhiskeylakeOpenBoardPkg:
Reviewed-by: Michael Kubacki
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nate
> DeSimone
> Sent: Thursday, November 21, 2019 12:59 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
> ; Jeremy Soller
> Subject: [edk2-devel]
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, November 21, 2019 12:59 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
> ; Chaganty, Rangasai V
>
> Subject: [edk2-platforms] [PATCH V2 0
I think the plural name is more intuitive since there will be more than one
feature but I don’t have a strong preference.
Thanks,
Michael
From: Ni, Ray
Sent: Thursday, November 21, 2019 12:05 AM
To: Kubacki; Kubacki, Michael A ;
devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2-rfc] [edk2
1 - 100 of 589 matches
Mail list logo
