On 11/14/23 17:53, Laszlo Ersek wrote:
> Second, "SMM_DISPATCHER_MP_SYNC_DATA.BspIndex" has type "(volatile)
> UINT32", but WhoAmI() writes an UINTN. On IA32, you're going to corrupt
> memory.
sorry, it's on X64 where you are going to corrupt memory (the
Small patch, but I have several comments :)
On 11/14/23 03:08, Zhiguang Liu wrote:
> Currently, if BSP election is not enabled, will use Core0 as SMM BSP,
> however, Core0 does not always have the highest performance core.
> So, we can used NonSmm BSP as default BSP.
(1) Please consider
+Jiewen (I seem to remember Jiewen co-authored a whitepaper on edk2
variables; I could be wrong)
one more comment below:
On 11/14/23 09:23, Gao wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4597
>
> When creating a new variable, skip marking VAR_HEADER_VALID_ONLY so that
>
On 11/13/23 22:33, Pedro Falcato wrote:
> On Mon, Nov 13, 2023 at 8:37 PM Rebecca Cran wrote:
>>
>> On 11/13/2023 1:08 PM, Michael Kubacki wrote:
>>> Yes. I just did it. It is relatively minor and impacts expected code
>>> areas.
>>>
>>> https://github.com/tianocore/edk2/pull/5043/files
>>
>>
>>
On 11/13/23 20:07, Pedro Falcato wrote:
> On Mon, Nov 13, 2023 at 11:58 AM Laszlo Ersek wrote:
>>
>> Hi Michael,
>>
>> recently I encountered an uncrustify failure on github.
>>
>> The reason was that my local uncrustify was *more recent* (73.0.8) t
/PiSmmCpuDxeSmm/Ia32/Cet.nasm | 5 ++-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.nasm | 39 +++
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/Cet.nasm | 5 ++-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 40 +++-
> 5 files changed, 78 insertio
On 11/13/23 06:59, Yuanhao Xie wrote:
> From: Yuanhao Xie
>
> This patch synchronizes the No-Execute bit in the IA32_EFER
> register for the APs before the RestoreVolatileRegisters operation.
>
> The commit 964a4f0, titled "Eliminate the second INIT-SIPI-SIPI
> sequence," replaces the second
On 11/13/23 06:47, Yuanhao Xie wrote:
> SMM read save state requires AP must be present.
> This patch aim to avoid the AP not ready for save state check.
>
> Signed-off-by: Zhihao Li
> Cc: Ray Ni
> Cc: Rahul Kumar
> Cc: Gerd Hoffmann
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/CpuService.c | 25
nsfer ring is not allocated.\n"));
>default:
> -DEBUG ((DEBUG_INFO, "XhcInitializeEndpointContext64: Unknown EP
> found, Transfer ring is not allocated.\n"));
> +DEBUG ((
> + DEBUG_INFO,
> + "%a: %a found, Transfer ring is
+
>//
>// calculate the pci memory address for host memory address.
>//
> @@ -603,6 +623,15 @@ UsbHcFreeMem (
>//
>ASSERT (Block != NULL);
>
> + if (Block == NULL) {
> +//
> +// Should never be here
> +//
> +DEBUG ((DEBUG_ERROR,
remind the reader that a (perhaps non-obvious) predicate always holds
at that location!
So, the argument
ASSERT(X) is unneeded because X always holds
is backwards. You do an ASSERT(X) *because* X always holds, and X is
non-trivial!
The only reason for removing an ASSERT(X) is that X, while tr
In other
words, the behavior of both snippets is undistinguishable in RELEASE
builds too.
In my opinion, the current patch is right.
Reviewed-by: Laszlo Ersek
To elaborate on that more generally:
Core edk2 code has so consistently and so broadly *abused* and *misused*
ASSERT() for err
On 11/9/23 21:40, Michael D Kinney wrote:
> Hi Ranbir,
>
> A deadloop without even a debug print is not good behavior.
In DEBUG and NOOPT builds, the ASSERT() would fire, hence providing a
debug message.
In RELEASE builds, even if there were a separate DEBUG message, the
DEBUG would be compiled
On 11/13/23 16:38, Laszlo Ersek wrote:
> On 11/7/23 03:43, Wu, Jiaxin wrote:
>> Processor extended information is filled when
>> CPU_V2_EXTENDED_TOPOLOGY is set in parameter ProcessorNumber
>> from GetProcessorInfo() (See commit: 1fadd18d).
>>
>> This filed value
; mNumberOfCpus; Index++) {
> -if (PackageId < gSmmCpuPrivate->ProcessorInfo[Index].Location.Package) {
> - PackageId = gSmmCpuPrivate->ProcessorInfo[Index].Location.Package;
> + if (PackageId <
> gSmmCpuPrivate->ProcessorInfo[Index].ExtendedInformation.Locatio
Hi Charles,
On 10/26/23 03:05, Charles Hyde wrote:
> From: Charles Hyde
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2861
>
> I believe the attached ConfigRouting.txt patch will resolve bug 2861, plus
> resolve an uninitialized pointer issue in HiiConfigRoutingExportConfig().
> The
hub.com/tianocore/edk2-test/uefi-sct
> +T: git - https://github.com/tianocore/edk2-test
>
>
> Responsible Disclosure, Reporting Security Issues
Reviewed-by: Laszlo Ersek
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#
cally, the replacement of the protocol
with the HOB should be fine, but for the general case, we should
document somehow that specific fields of the HOB may be invalidated
between HOB production and HOB consumption. If platform code is required
to prevent that (i.e., the platform is responsible for
sorry, unfinished thought:
On 11/13/23 14:39, Laszlo Ersek wrote:
> - the "sarif emacs" output seems a bit broken, actually, so it's not usable.
> Consider the following entry from the original JSON file:
>
> }, {
> "ruleId" : "cpp/mis
On 11/7/23 16:43, Michael Kubacki wrote:
> The series that makes it easy to run CodeQL locally and have access to
> results from any PR or push to master.
>
> Those that have access can see the results directly in "Code Scanning"
> in the "Security" tab of the edk2 repo. That may be affected in
instance is left alone.
The RISC-V OVMF platform uses "BaseIoLibIntrinsic.inf", but RISC-V
already doesn't (can't) use the IA32/X64 NASM files.
So, surprisingly, the "IoFifo.nasm" files are actually unused,
pre-patch; IA32 and X64 OVMF only uses the "IoFifoSev.nasm&q
On 11/9/23 11:39, Hamit Can Karaca wrote:
> Hello,
> I am a young UEFI developer and I am trying to use the functions in
> Tpm2CommandLib to write data to TPM2. I have defined the index that, I
> am going to write data to, using the DefineSpace function. But whenever
> I am trying to use the
On 11/9/23 19:08, Michael D Kinney wrote:
> +Ray
>
>
>
> Unless I missed it, I do not see review of the patch series Ray sent
> back in July.
Right, please repost.
Laszlo
>
>
>
> Mike
>
>
>
> *From:* devel@edk2.groups.io *On Behalf Of *Aaron
> Young via groups.io
> *Sent:*
Hi Michael,
recently I encountered an uncrustify failure on github.
The reason was that my local uncrustify was *more recent* (73.0.8) than
the one we use in edk2 CI (which is 73.0.3, per the edk2 file
".pytool/Plugin/UncrustifyCheck/uncrustify_ext_dep.yaml").
Updating the version number in the
On 11/8/23 02:06, Michael D Kinney wrote:
> Hi Jose,
>
>
>
> 1. This logic needs to move into an AARCH64 specific directory/file.
> Other architectures handle this in other ways.
> 2. There are many places throughout edk2 sources that perform PCI
> config write operations. You are
On 11/8/23 05:11, Wu, Jiaxin wrote:
> Hi Laszlo,
>
>>>
>>> The patch looks OK to me, but:
>>>
>>> - I would like to test it with CPU hotplug (later, likely under v2), and
>>>
>
> Sure, I can wait the update from you.
>
>>> - I think this should be two patches.
>>>
>>> First, the
t Coverity, I
don't know if this patch is worth the churn. :( As I said, this ASSERT()
is one of those few justified ones in edk2 core that can indeed never
fail, IMO.
Laszlo
>
> On Tue, Nov 7, 2023 at 10:18 PM Laszlo Ersek <mailto:ler...@redhat.com>> wrote:
>
> On 11
On 11/8/23 05:29, Ranbir Singh wrote:
> Hi Mike,
>
> I agree that any manual inspection is sort of a burden, more so when it
> becomes repetitive in the long run.
>
> When I was doing these Coverity checks (Nov-Dec' 2022), I was working in
> Dell and had access to the real systems to check the
On 11/10/23 10:46, Gerd Hoffmann wrote:
> On Fri, Nov 10, 2023 at 03:09:47PM +0800, Chao Li wrote:
>> Hi Laszlo,
>>
>> Sorry, I'm not check carefully, it is really **copied**, and we not think
>> the ARM version is not good enough.
>>
>> So, can I move this library to OvmfPkg so other ARCH use it
On 11/10/23 07:44, Chao Li wrote:
> Hi Laszlo,
>
> This is a good question, same as the previous email, some ARCH don't
> require running code on memory during PEI phase or other reason can not
> used the MdePkg version, so this pointer will be saved by some register,
> I saw the ArmPkg version
not
> committed when I porting LoongArchVirt, my code base is based on
> stable202308, so I don't know you committed a new library, sorry.
Sure, that sometimes happens when a new feature takes long (either to
implement, or to review).
Laszlo
>
>
>
> Thanks,
>
On 11/13/23 04:15, Ni, Ray wrote:
> I provided 4 comments in below, starting with "[Ray".
>
> Sorry for the poor new Outlook that I am not able to put ">" in the
> original email.
>
> Thanks,
> Ray
>
>
>
> (1) I agree
07-14). The
commit message is similarly empty.
Laszlo
>
> Thanks,
> Chasel
>
>
>
>> -Original Message-
>> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek
>> Sent: Thursday, November 9, 2023 4:06 AM
>> To: devel@edk2.groups.io
>> Cc: Chaganty,
Xu
Cc: Tom Lendacky
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.dec | 26
OvmfPkg/AmdSev/AmdSevX64.dsc | 3 ---
OvmfPkg/IntelTdx/IntelTdxX64.dsc | 3 ---
OvmfPkg/Microvm/MicrovmX64.dsc | 3
://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Bhyve/BhyveX64.dsc | 7 +--
OvmfPkg/IntelTdx/IntelTdxX64.dsc | 3 ---
OvmfPkg/OvmfPkgIa32.dsc | 3 ---
OvmfPkg/OvmfPkgIa32X64.dsc | 3 ---
OvmfPkg/OvmfPkgX64.dsc | 3 ---
OvmfPkg/OvmfXen.dsc
?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.dec | 1 -
OvmfPkg/Include/Protocol/Legacy8259.h | 290
2 files changed, 291 deletions(-)
diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
index 9d326e8143eb..2e9e699aa6ab 100644
--- a/OvmfPkg
Hoffmann
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/8259InterruptControllerDxe/Legacy8259.uni | 16 -
OvmfPkg/8259InterruptControllerDxe/Legacy8259Extra.uni | 14 -
OvmfPkg/8259InterruptControllerDxe/8259.inf
With 8254TimerDxe gone, no module in OVMF consumes
gEfiLegacy8259ProtocolGuid; exclude 8259InterruptControllerDxe therefore.
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfPkgIa32.dsc
scheduled for removal to:
- GUIDs (protocols or otherwise):
- gEfiLegacy8259ProtocolGuid
- headers:
- Protocol/Legacy8259.h
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/8254TimerDxe/Timer.uni
://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Csm/Csm16/Csm16.inf | 17 -
OvmfPkg/Csm/Csm16/ReadMe.txt | 12
2 files changed, 29 deletions(-)
diff --git a/OvmfPkg/Csm/Csm16/Csm16.inf b/OvmfPkg/Csm/Csm16/Csm16.inf
deleted file mode
=CSM. Remove those rules as well.)
Cc: Anatol Belski
Cc: Anthony Perard
Cc: Ard Biesheuvel
Cc: Corvin Köhne
Cc: Gerd Hoffmann
Cc: Jianyong Wu
Cc: Jiewen Yao
Cc: Rebecca Cran
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Bhyve/BhyveX64.fdf
cca Cran
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Bhyve/BhyveX64.dsc | 4
OvmfPkg/OvmfPkgIa32.dsc| 4
OvmfPkg/OvmfPkgIa32X64.dsc | 4
OvmfPkg/OvmfPkgX64.dsc | 4
OvmfPkg/OvmfXen.dsc| 4
OvmfPkg/Bhyve/BhyveX64.fdf | 4
c0c2eb0a59 ("OvmfPkg: fix PcdFSBClock",
2022-05-25).
Regression test: verified that the BDS progress bar still advanced at
normal speed in each platform.
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo
F3-3E8A-4FEF-81C8-328ED647AB1A)
- gEfiLegacy8259ProtocolGuid
- headers:
- Protocol/Legacy8259.h
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.dec
- Protocol/Legacy8259.h
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.dec| 1 -
OvmfPkg/Csm/Include/Protocol/LegacyInterrupt.h | 121
2
- headers:
- FrameworkDxe.h
- Protocol/Legacy8259.h
- Protocol/LegacyInterrupt.h
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.dec |1 -
OvmfPkg/Csm/Include
heduled for removal.
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.inf | 55 -
OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.h | 48 -
OvmfPkg/Csm/CsmSupportL
- gEfiLegacyInterruptProtocolGuid
- headers:
- FrameworkDxe.h
- Protocol/Legacy8259.h
- Protocol/LegacyBios.h
- Protocol/LegacyInterrupt.h
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.dec | 1 -
OvmfPkg/Csm/Include/Protocol/FirmwareVolume.h | 339
2 files changed, 340 deletions(-)
diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
index 45a6105d39d6
us, and has
always been, since commit 656419f922c0 ("Add BhyvePkg, to support the
bhyve hypervisor", 2020-07-31).
Cc: Anthony Perard
Cc: Ard Biesheuvel
Cc: Corvin Köhne
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Rebecca Cran
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Sign
- PcdOpromReservedMemoryBase
- PcdOpromReservedMemorySize
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.dec | 1 -
OvmfPkg/Csm/Include/Guid/LegacyBios.h | 29
c: Gerd Hoffmann
Cc: Jianyong Wu
Cc: Jiewen Yao
Cc: Michael Roth
Cc: Min Xu
Cc: Rebecca Cran
Cc: Sunil V L
Cc: Tom Lendacky
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/AmdSev/AmdSevX64.dsc| 1 -
OvmfPkg/Bhyve/BhyveX64.dsc |
/LegacyBiosPlatform.h
- Protocol/LegacyInterrupt.h
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.dec | 38
1 file changed, 38 deletions(-)
diff --git a/OvmfPkg/OvmfPkg.dec b
- PcdLegacyBiosCacheLegacyRegion
- PcdLowPmmMemorySize
- PcdOpromReservedMemoryBase
- PcdOpromReservedMemorySize
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.dec| 1
- PcdLowPmmMemorySize
- PcdOpromReservedMemoryBase
- PcdOpromReservedMemorySize
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.dec | 1 -
OvmfPkg/Csm/Include/Protocol
://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfPkgIa32X64.dsc | 4
OvmfPkg/OvmfPkgX64.dsc | 4
2 files changed, 8 deletions(-)
diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
index 3a83418bdd4e..1f144b07a650 100644
--- a/OvmfPkg
: Anthony Perard
Cc: Ard Biesheuvel
Cc: Corvin Köhne
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Rebecca Cran
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Bhyve/BhyveX64.dsc | 1 -
OvmfPkg/OvmfPkgIa32.dsc| 1 -
OvmfPkg/OvmfPkgIa32X64.dsc | 1
is part finally shows that the iPXE option ROM for the device
(1af41000.efi) was detected and is loaded. (Same PCIe root port, and PCIe
root ports can only host a single device.)
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_
:
- FrameworkDxe.h
- Guid/LegacyBios.h
- Protocol/LegacyBios.h
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.dec | 20
1 file changed, 20 deletions(-)
diff --git
- PCDs:
- PcdBiosVideoCheckVbeEnable
- PcdBiosVideoCheckVgaEnable
- PcdBiosVideoSetTextVgaModeEnable
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.dec| 1
ne
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Rebecca Cran
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Bhyve/BhyveX64.dsc| 6 --
OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 --
OvmfPkg/OvmfPkgIa32.dsc | 6 --
OvmfPkg/
: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni | 20 -
OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiStrings.uni | 43 -
OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.dec | 1 -
OvmfPkg/Csm/Include/Guid/LegacyDevOrder.h | 39
2 files changed, 40 deletions(-)
diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
index
://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Bhyve/BhyveX64.dsc | 3 ---
OvmfPkg/OvmfPkgIa32.dsc| 3 ---
OvmfPkg/OvmfPkgIa32X64.dsc | 3 ---
OvmfPkg/OvmfPkgX64.dsc | 3 ---
OvmfPkg/OvmfXen.dsc| 3 ---
5 files changed, 15 deletions(-)
diff --git a/OvmfPkg/Bhyve
: Jiewen Yao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.uni | 20 -
OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.inf | 57 -
OvmfPkg/Csm/LegacyBootManagerLib/InternalLegacyBm.h | 60
Don't register the LegacyBmRefreshAllBootOption() and LegacyBmBoot()
functions in BdsDxe and UiApp.
Cc: Anthony Perard
Cc: Ard Biesheuvel
Cc: Corvin Köhne
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Rebecca Cran
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
nocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.dec | 5 ---
OvmfPkg/IntelTdx/IntelTdxX64.dsc| 1 -
OvmfPkg/OvmfPkgIa32.dsc | 1 -
OvmfPkg/OvmfPkgIa32X64.dsc | 1 -
OvmfPkg/OvmfPkgX64.dsc | 1
ao
Cc: Rebecca Cran
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Bhyve/BhyveX64.dsc | 1 +
OvmfPkg/IntelTdx/IntelTdxX64.dsc | 1 +
OvmfPkg/OvmfPkgIa32.dsc | 1 +
OvmfPkg/OvmfPkgIa32X64.dsc | 1 +
OvmfPkg/OvmfPkgX64.dsc
Sunil V L
Cc: Tom Lendacky
Thanks
Laszlo
Laszlo Ersek (37):
OvmfPkg: cripple CSM_ENABLE macro
OvmfPkg: remove PcdCsmEnable
OvmfPkg: unplug LegacyBootManagerLib from BdsDxe and UiApp
OvmfPkg: remove LegacyBootManagerLib
OvmfPkg: unplug LegacyBootMaintUiLib from UiApp
OvmfP
754
Signed-off-by: Laszlo Ersek
---
MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h | 288
1 file changed, 288 deletions(-)
diff --git a/MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h
b/MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h
deleted file mode 10
or edk2-platforms.
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Zhiguang Liu
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
Signed-off-by: Laszlo Ersek
---
MdePkg/MdePkg.dec | 3 --
MdePkg/Include/Guid/Mps.h | 29
2 files changed, 32 deletions(-)
diff --git
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
Remove two old headers that play no role in modern UEFI.
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Zhichao Gao
Cc: Zhiguang Liu
Laszlo Ersek (3):
MdePkg: remove
ShellPkg/UefiShellDebug1CommandsLib: remove gEfiMpsTableGuid ref
We're removing . First, remove the
gEfiMpsTableGuid system config table reference from the UEFI Shell's DMEM
debug command.
Cc: Zhichao Gao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
Signed-off-by: Laszlo Ersek
---
ShellPkg/Library/UefiShellDebug1CommandsLib
show_bug.cgi?id=1754
Signed-off-by: Laszlo Ersek
---
Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h | 1 -
1 file changed, 1 deletion(-)
diff --git
a/Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h
b/Platform/Intel/SimicsOpenBoardPkg/Lib
is also absent from edk2-platforms.)
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Chasel Chiu
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
Signed-off-by: Laszlo Ersek
---
Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.h
|
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
Remove references to two old headers that play no role in modern UEFI.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Sai Chaganty
Laszlo Ersek (2):
WhitleyOpenBoardPkg: remove references
SimicsOpenBoardPkg: remove reference
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
I'm sending this as a common anchor message for
[edk2-platforms PATCH 0/2] remove and refs
[PATCH 0/3] remove and ,
including refs
Thanks,
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all
On 11/6/23 04:30, Chao Li wrote:
> This library is provides boot mananger interfaces, and it is referenced
> from ArmVirtPkg.
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584
>
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Gerd Hoffmann
> Signed-off-by: Chao Li
On 11/6/23 04:30, Chao Li wrote:
> Use a register to save PeiServiceTable pointer. This Library provides
> PeiServiceTable pointer saveing and retrieval serivces.
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584
>
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Gerd
On 11/7/23 11:12, Chao Li wrote:
> Hi Gerd,
>
> These two libraries is not only copy code, the way of obtain the serial
> base address is different from ARM, and the early serial port output
> also different from ARM, so these two libraries are LoongArch specific.
I think we're going to have to
On 11/3/23 18:17, Taylor Beebe wrote:
> The function EnforceMemoryMapAttribute() in the SMM MAT logic will
> ensure that the CODE and DATA memory types have the desired attributes.
EnforceMemoryMapAttribute() leaves those descriptors alone where
Attribute is already nonzero ("PE image") [1].
For
On 11/6/23 10:07, Sheng Wei wrote:
> Initial the value of mSmmInterruptSspTables to 0.
>
> Signed-off-by: Sheng Wei
> Cc: Eric Dong
> Cc: Ray Ni
> Cc: Laszlo Ersek
> Cc: Wu Jiaxin
> Cc: Tan Dun
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c | 2 +-
>
On 11/6/23 10:07, Sheng Wei wrote:
> Do not use fixed CR4 value 0x668, change CR4.CET bit only.
>
> Signed-off-by: Sheng Wei
> Cc: Eric Dong
> Cc: Ray Ni
> Cc: Laszlo Ersek
> Cc: Wu Jiaxin
> Cc: Tan Dun
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.na
Eric Dong
> Cc: Ray Ni
> Cc: Laszlo Ersek
> Cc: Wu Jiaxin
> Cc: Tan Dun
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.nasm | 53 ---
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 69
> 2 files changed, 98 insertions(+), 24 de
x this issue.
>
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
> Cc: Ray Ni
> Signed-off-by: Wei6 Xu
> ---
> StandaloneMmPkg/Core/FwVol.c | 22 ++
> 1 file changed, 22 insertions(+)
>
> diff --git a/StandaloneMmPkg/Core/F
d this issue.
> MmCoreFfsFindMmDriver() also assumes section is EFI_COMMON_SECTION_HEADER.
> If Section is EFI_COMMON_SECTION_HEADER2, 'Section + 1' will get a wrong
> wrong InnerFvHeader adress. Add section head detection and calculate the
> address accordingly.
>
> Cc: Laszlo Ers
gt; + if (AllocatedDstBuffer != NULL) {
> +FreePages (AllocatedDstBuffer, EFI_SIZE_TO_PAGES (DstBufferSize));
> + }
>
>return Status;
> }
Right, if AllocatedDstBuffer is needed, then we free it only upon error;
otherwise, we free it early on, so that it's released upon both er
epth against that PCD.
>
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
> Cc: Ray Ni
> Signed-off-by: Wei6 Xu
> ---
> StandaloneMmPkg/Core/Dispatcher.c | 5 -
> StandaloneMmPkg/Core/FwVol.c | 16 --
> Stan
On 11/6/23 07:55, Joe L wrote:
> (1) I'd like (a) the problem report, and the full reasoning by Ard and
> Michael to be captured in the commit message, and (b) *minimally* a hint
> at the possible reordering, and at the PCI spec-based workaround, to be
> placed in the code comment
rmal SMI stack mismatch.
>
> Note: WRITE_UNPROTECT_RO_PAGES () must be called pair with
> WRITE_PROTECT_RO_PAGES () in same function.
>
> Cc: Eric Dong
> Cc: Ray Ni
> Cc: Zeng Star
> Cc: Gerd Hoffmann
> Cc: Rahul Kumar
> Cc: Laszlo Ersek
> Signed-off-by:
On 11/7/23 19:40, Laszlo Ersek wrote:
> On 11/7/23 03:43, Wu, Jiaxin wrote:
>> Processor extended information is filled when
>> CPU_V2_EXTENDED_TOPOLOGY is set in parameter ProcessorNumber
>> from GetProcessorInfo() (See commit: 1fadd18d).
>>
>> This filed value
On 11/7/23 03:43, Wu, Jiaxin wrote:
> Processor extended information is filled when
> CPU_V2_EXTENDED_TOPOLOGY is set in parameter ProcessorNumber
> from GetProcessorInfo() (See commit: 1fadd18d).
>
> This filed value is retrieved from CPUID leaf 1FH, which is
> a preferred superset to leaf 0BH.
;> 5. Add platform level PCD to allow overriding of RISC-V features.
>>
>> Code Link: https://github.com/tianocore/edk2/pull/5002
>>
>> Cc: Ard Biesheuvel
>> Cc: Jiewen Yao
>> Cc: Jordan Justen
>> Cc: Gerd Hoffmann
>> Cc: Sunil V L
>> Cc:
On 11/7/23 07:28, Ranbir Singh wrote:
> From: Ranbir Singh
>
> The function FatInitializeDiskCache evaluates an expression
>
> FAT_DATACACHE_GROUP_COUNT << DiskCache[CacheData].PageAlignment
>
> and assigns it to DataCacheSize which is of type UINTN.
>
> As per Coverity report,
>
On 11/7/23 07:28, Ranbir Singh wrote:
> From: Ranbir Singh
>
> The functions FatGetDirEntInfo and FatOpenDirEnt contains the code
> statements
>
> Cluster= (Entry->FileClusterHigh << 16) |
> Entry->FileCluster;
> and
> OFile->FileCluster =
On 11/7/23 07:19, Ranbir Singh wrote:
> The return value after calls to functions
> gBS->UninstallMultipleProtocolInterfaces, StartPciDevicesOnBridge,
> PciPciDeviceInfoCollector, BarExisted, PciRootBridgeIo->Pci.Write,
> gPciHotPlugInit->InitializeRootHpc and PciRootBridgeP2CProcess is
> stored
On 11/7/23 07:19, Ranbir Singh wrote:
> From: Ranbir Singh
>
> The function StartPciDevices has a check
>
> ASSERT (RootBridge != NULL);
>
> but this comes into play only in DEBUG mode. In Release mode, there
> is no handling if the RootBridge value is NULL and the code proceeds
> to
On 11/7/23 07:19, Ranbir Singh wrote:
> From: Ranbir Singh
>
> The function PciHostBridgeResourceAllocator is not making use of the
> generic approach as is used in one of the other function namely -
> DumpResourceMap. As a result, the following warnings can be seen as
> reported by Coverity
> break;
Agree, but the semicolon's placement is awkward. I propose
No break here, as this is an intentional fall through.
Reviewed-by: Laszlo Ersek
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110863): https:/
On 11/7/23 07:19, Ranbir Singh wrote:
> From: Ranbir Singh
>
> The function PciHotPlugRequestNotify has two if blocks towards the end
> of function both containing return. Due to the parameter checks ensured
> at the beginning of the function, one of the two if blocks is bound to
> come in
401 - 500 of 4300 matches
Mail list logo
