On 2022-09-06 11:30, Ard Biesheuvel wrote:
Bob, Liming, Leif: any thoughts?
I'm happy with this.
(Spotted one typo - "ofset".)
Acked-by: Leif Lindholm
On Sun, 21 Aug 2022 at 16:33, Rebecca Cran wrote:
Tested-by: Rebecca Cran
On 8/21/22 08:16, Ard Biesheuvel wrote:
0x%x"
> "bytes (%d kB), BufferPtr @ 0x%08x)\n"
>
> Although this requires 5 arguments, only 4 are provided. The kilobyte
> value was never given.
>
> This change removes that specifier so the 4 arguments match the 4
> specifiers in the debug macro.
>
> Cc: Leif
; 'Ard Biesheuvel'
; rebe...@bsdio.com; Chen, Christine
Cc: 'Andrew Fish' ; 'Leif Lindholm' ; Kinney,
Michael D ; Wang, Jian J
Subject: 回复: [edk2-devel] MdeModulePkg build fails for AARCH64 on Ubuntu 22.04
Bob:
The commit 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860
On Tue, Aug 23, 2022 at 18:00:15 +0200, pierre.gond...@arm.com wrote:
> From: Pierre Gondois
>
> In an effort to clean the documentation of the above
> package, remove duplicated words.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Abner Chang
> Signed-off-by: P
On Tue, Aug 23, 2022 at 18:00:09 +0200, pierre.gond...@arm.com wrote:
> From: Pierre Gondois
>
> In an effort to clean the documentation of the above
> package, remove duplicated words.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Signed-off-by: Pierre Gondois
On Tue, Aug 23, 2022 at 18:00:10 +0200, pierre.gond...@arm.com wrote:
> From: Pierre Gondois
>
> In an effort to clean the documentation of the above
> package, remove duplicated words.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Signed-off-by: Pierre Gondois
Re
Hi everyone,
As some of you might have noticed, my email setup broke a little over
a month ago. At the time I was on leave, so did not notice for a
while. And upon my return, it turned out it had broken in New and
Exciting ways - so it took some time to restore.
This has now been achieved, and I
eif
> -Original Message-
> From: Michael D Kinney
> Sent: 17 August 2022 18:43
> To: devel@edk2.groups.io
> Cc: Leif Lindholm ; Andrew Fish
> ; Konstantin Aladyshev ; Bob
> Feng ; Liming Gao ;
> Yuwei Chen
> Subject: [Patch V2 edk2-s
On Thu, May 05, 2022 at 12:23:18 +0200, Gerd Hoffmann wrote:
> On Thu, May 05, 2022 at 10:50:27AM +0100, Leif Lindholm wrote:
> > Apologies for late feedback.
> >
> > I'm super happy with this set, but...
> >
> > On Fri, Apr 29, 2022 at 12:20:14 +0200
Apologies for late feedback.
I'm super happy with this set, but...
On Fri, Apr 29, 2022 at 12:20:14 +0200, Gerd Hoffmann wrote:
> Copy over unmodified (except for running through uncrustify), from
> https://github.com/tianocore/edk2-libc/tree/master/StdLib/LibC/CRT
...I think these files should
port
> > NetworkPkg: Remove RVCT support
> > ArmVirtPkg: Remove RVCT support
> > EmbeddedPkg: Remove RVCT support
> > OvmfPkg: Remove RVCT support
> > BaseTools: Remove RVCT support
> >
>
> Thanks a lot for doing this.
>
> Reviewed-by: Ard Biesheuvel
&
Acked-by: Leif Lindholm
On Fri, Apr 01, 2022 at 15:24:39 +, Michael D Kinney wrote:
> Acked-by: Michael D Kinney
>
> > -Original Message-
> > From: Michael Kubacki
> > Sent: Friday, April 1, 2022 7:11 AM
> > To: devel@edk2.groups.io
> >
On Sat, Mar 26, 2022 at 16:12:07 +0700, Nhi Pham via groups.io wrote:
> > Would you be happy for me to fold that into
> > "AmpereAltraPkg, JadePkg: Add ACPI support", or would you be able to
> > submit a v6 of that patch only?
> >
> > Best Regards,
> >
> > Leif
>
> Thanks much for the patch. The
Reviewed-by: Leif Lindholm
Pushed as 0320db977fb2..7dcfcf88b8a9 in preparation of pushing the
edk2-platforms set.
On Fri, Oct 22, 2021 at 12:56:02 +0700, Vu Nguyen wrote:
> Create edk2-non-osi component holder for Ampere Libraries. This patchset
> also adds PciePhyLib which provides funct
Hi Nhi,
On Sun, Dec 19, 2021 at 10:35:41 +0700, Nhi Pham via groups.io wrote:
> Hi Rebecca,
>
> Leif is merging the rest of Altra port to the edk2-platforms which has SRAT
> ACPI table consuming the CPU Core Info table. Therefore, we will need to fix
> the SRAT too. I would defer the fix until th
On Thu, Mar 24, 2022 at 15:56:32 +0100, Pierre Gondois wrote:
> > > > > +/** Invoke the monitor call using the appropriate conduit.
> > > > > +If PcdMonitorConduitHvc is TRUE use the HVC conduit else use SMC
> > > > > conduit.
> > > > > +
> > > > > + @param [in, out] ArgsArguments passed
For the series:
Reviewed-by: Leif Lindholm
Pushed as 1b548f8e16a9..41628dcf3332.
Thanks!
On Sat, Mar 19, 2022 at 14:32:50 -0600, Rebecca Cran wrote:
> Trusted Firmware is no longer called ATF (ARM Trusted Firmware) but is
> now TF-A (Trusted Firmware for A-profile architecture).
Thanks!
Wow, I kicked this can quite far down the road. Sorry about that.
Reviewed-by: Leif Lindholm
Pushed as 1b548f8e16a9.
On Mon, Feb 07, 2022 at 17:19:20 +, Kinney, Michael D wrote:
> Reviewed-by: Michael D Kinney
>
> Mike
>
> > -Original Message-----
>
On Mon, Feb 07, 2022 at 12:21:21 +, Leif Lindholm wrote:
> NUVIA inc. was acquired by Qualcomm in March 2021, but we continued
> contributions under the existing IDs until the start of this year.
> We are now switching to use Qualcomm Innovation Center email, so
> update Mainta
NUVIA inc. was acquired by Qualcomm in March 2021, but we continued
contributions under the existing IDs until the start of this year.
We are now switching to use Qualcomm Innovation Center email, so
update Maintainers.txt to reflect this.
Cc: Michael D Kinney
Cc: Leif Lindholm
Signed-off-by
On Mon, Jan 31, 2022 at 11:40:40 +, Leif Lindholm wrote:
> The first patch adds some missing github IDs spotted when preparing the
> second patch.
>
> The second patch changes my email address from NUVIA to Qualcomm
> Innovation Center (Quicinc).
>
> Cc: Andrew Fish
&
AR resizing in the
> first place)
>
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
> ---
> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
&g
On Mon, Jan 31, 2022 at 11:40:42 +, Leif Lindholm wrote:
> NUVIA inc. was acquired by Qualcomm in March 2021, but we continued
> contributions under the existing IDs until the start of this year.
> We are now switching to use Qualcomm Innovation Center email, so
> update Mainta
is unnecessary any more.
> > Remove All UGA Support in ArmVirtPkg
> >
> > Signed-off-by: Guomin Jiang
> > Cc: Ard Biesheuvel
> > Cc: Leif Lindholm
> > Cc: Sami Mujawar
> > Cc: Gerd Hoffmann
>
> As I was not cc'ed on the cover letter,
>
&
+Jeremy
On Fri, Jan 28, 2022 at 10:38:18 -0500, Adrien Thierry wrote:
> Describe the miniuart clock frequency in a _DSD property, so that it can
> be read from the Linux driver.
>
> The miniuart clock frequency is the core clock frequency on the
> Raspberry Pi. It can be modified by the user usin
rom permanent PEI memory but after the MMU has been enabled.
>
> This means that the cache invalidation in ArmVirtMemoryInitPeiLib is no
> longer necessary, and can simply be dropped.
>
> Cc: Alexander Graf
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
> ---
>
On Mon, Jan 31, 2022 at 12:45:37 +0100, Ard Biesheuvel wrote:
> Some fixes related to the struct typedef change of ARM_CORE_INFO that
> were missed the first time around.
For the series:
Reviewed-by: Leif Lindholm
> Ard Biesheuvel (4):
> Platform/ARM: fix for ARM_CORE_INFO s
On Sun, Jan 30, 2022 at 11:36:51 +0100, Ard Biesheuvel wrote:
> On Sun, 19 Dec 2021 at 04:36, Nhi Pham wrote:
> >
> > Hi Rebecca,
> >
> > Leif is merging the rest of Altra port to the edk2-platforms which has
> > SRAT ACPI table consuming the CPU Core Info table. Therefore, we will
> > need to fix
The first patch adds some missing github IDs spotted when preparing the
second patch.
The second patch changes my email address from NUVIA to Qualcomm
Innovation Center (Quicinc).
Cc: Andrew Fish
Cc: Michael D Kinney
Cc: Leif Lindholm
Leif Lindholm (2):
Maintainers.txt: add missing github
This section seems to have been missed when introducing github IDs,
so add them.
Cc: Andrew Fish
Cc: Michael D Kinney
Signed-off-by: Leif Lindholm
---
Maintainers.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 4c5d3111c2ec
NUVIA inc. was acquired by Qualcomm in March 2021, but we continued
contributions under the existing IDs until the start of this year.
We are now switching to use Qualcomm Innovation Center email, so
update Maintainers.txt to reflect this.
Cc: Andrew Fish
Cc: Michael D Kinney
Cc: Leif Lindholm
.h
> -Definition of EDK2 RISC-V implementation.
>
> Signed-off-by: Abner Chang
> Co-authored-by: Daniel Schaefer
> Co-authored-by: Gilbert Chen
> Reviewed-by: Leif Lindholm
Hmm, no.
I gave a reviewed-by for that patch to be merged into edk2-platforms
once upon a time. This
belong to RiscV*Pkg for CI issues and have no functional changes.
>
> Signed-off-by: Abner Chang
> Cc: Sean Brogan
> Cc: Bret Barkelew
> Cc: Michael D Kinney
> Cc: Leif Lindholm
> Cc: Liming Gao
> Cc: Daniel Schaefer
> Cc: Sunil V L
>
> Abner C
lots of commitments, and its time to give him
> > a breather. As such, I will take over as a platform reviewer.
> >
> > Cc: Pete Batard
> > Cc: Ard Biesheuvel
> > Cc: Leif Lindholm
> > Cc: Andrei Warkentin
> > Cc: Samer El-Haj-Mahmoud
> > Signed-
ailto:devel@edk2.groups.io] On Behalf Of
> > > Nhi Pham via groups.io
> > > Sent: Friday, September 3, 2021 11:44 PM
> > > To: devel@edk2.groups.io
> > > Cc: patc...@amperecomputing.com; Nhi Pham
> > > ; Leif Lindholm ; Ard
> > > Biesheuvel ; C
On Sat, Nov 27, 2021 at 16:48:45 +0900, Masami Hiramatsu wrote:
> > On Fri, Nov 05, 2021 at 18:24:01 +0900, Masami Hiramatsu wrote:
> > > Expand NvStorage Variable size and FTW spare/working size
> > > for the DeveloperBox platform.
> > >
> > > Since the size of the NvStorage VariableSize is not en
On Fri, Nov 05, 2021 at 18:24:01 +0900, Masami Hiramatsu wrote:
> Expand NvStorage Variable size and FTW spare/working size
> for the DeveloperBox platform.
>
> Since the size of the NvStorage VariableSize is not enough
> large, FWTS uefirttime test, which updates the NV
> variables in runtime, fa
On Fri, Nov 05, 2021 at 18:23:53 +0900, Masami Hiramatsu wrote:
> Add DBG2 table to ACPI tables. The COM1 uart port will be used
> for OS debug, and it is 16550 compatible.
>
> Signed-off-by: Masami Hiramatsu
> ---
> .../Socionext/SynQuacer/AcpiTables/AcpiTables.inf |1
> Silicon/Socionext
On Fri, Nov 05, 2021 at 18:23:45 +0900, Masami Hiramatsu wrote:
> Fix the number of erase blocks by rounding up the result.
> The erase blocks must include the last block covered by the
> length bytes.
>
> Signed-off-by: Masami Hiramatsu
> Reported-by: Kazuhiko Sakamoto
On Fri, Nov 05, 2021 at 18:23:36 +0900, Masami Hiramatsu wrote:
> This fixes Socionext DeveloperBox GenericWatchdog interrupt
> number to 93 instead of 94. Since the 93 is the default interrupt
> number defined in ArmPkg/ArmPkg.dec, this doesn't redefine
> gArmTokenSpaceGuid.PcdGenericWatchdogEl2In
On Fri, Nov 05, 2021 at 18:23:28 +0900, Masami Hiramatsu wrote:
> If an EFI application frequently repeats SetTime and GetTime,
> the I2C bus can be busy and failed to start. To fix this issue,
> add waiting loop for the bus busy status. (Usually, it is
> enough to read 3 times for checking, but fo
On Fri, Nov 26, 2021 at 09:56:29 +0900, Masami Hiramatsu wrote:
> Hi Leif,
>
> Sorry for replying late.
>
> 2021年11月11日(木) 20:59 Leif Lindholm :
> >
> > Masami - while looking at your set from last Friday, patch 1/5 fails
> > to apply since the file being modif
Hi Masami,
My feedback was
https://edk2.groups.io/g/devel/message/83641
Best Regards,
Leif
On Thu, Nov 25, 2021 at 20:19:51 +0900, Masami Hiramatsu wrote:
> Hello Leif and Ard,
>
> Could you give me any feedback on this series?
>
> Thank you,
>
> 2021年11月5日(金) 18:23 Masami Hiramatsu :
> >
>
Agreed, but the commit message (and the BZ) should state which commit
introduced this issue.
/
Leif
On Thu, Nov 25, 2021 at 09:52:58 +0800, gaoliming wrote:
> I suggest to merge this fix for the stable tag 202111. This fix is low risk.
>
>
>
>
> Thanks
>
> Liming
>
> 发件人: devel@edk2.gr
On Wed, Nov 24, 2021 at 14:07:22 +0100, Ard Biesheuvel wrote:
> On Wed, 24 Nov 2021 at 14:05, Leif Lindholm wrote:
> >
> > On Wed, Nov 24, 2021 at 14:03:51 +0100, Ard Biesheuvel wrote:
> > > On Wed, 24 Nov 2021 at 13:07, Leif Lindholm wrote:
> > > >
> >
On Wed, Nov 24, 2021 at 14:03:51 +0100, Ard Biesheuvel wrote:
> On Wed, 24 Nov 2021 at 13:07, Leif Lindholm wrote:
> >
> > Ard - how does this interact with e.g. ArmVirtPsciResetSystemLib,
> > which reads its conduit out of the DT passed to it by QEMU?
> >
>
Hi Sami,
On Tue, Nov 16, 2021 at 11:32:55 +, Sami Mujawar wrote:
> Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
>
> The Arm True Random Number Generator Firmware, Interface 1.0,
> Platform Design Document
> (https://developer.arm.com/documentation/den0098/latest/)
> de
Ard - how does this interact with e.g. ArmVirtPsciResetSystemLib,
which reads its conduit out of the DT passed to it by QEMU?
/
Leif
On Tue, Nov 16, 2021 at 11:32:54 +, Sami Mujawar wrote:
> Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
>
> Define a PCD 'PcdMonitor
anges for these known
> issues.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
> Cc: Gerd Hoffmann
> Cc: Sean Brogan
> Cc: Bret Barkelew
> Cc: Liming Gao
> Cc: Michael Kubacki
> Signed-off-by: Michael D Kinney
Reviewed-by: Leif Lindholm
&
anges for these known
> issues.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sean Brogan
> Cc: Bret Barkelew
> Cc: Liming Gao
> Cc: Michael Kubacki
> Signed-off-by: Michael D Kinney
Reviewed-by: Leif Lindholm
> ---
> ArmPlatformPkg/ArmPlatformPkg
anges for these known
> issues.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sean Brogan
> Cc: Bret Barkelew
> Cc: Liming Gao
> Cc: Michael Kubacki
> Signed-off-by: Michael D Kinney
Reviewed-by: Leif Lindholm
> ---
> ArmPkg/ArmPkg.ci.yaml | 5
Since BZ3732 has been triggered by a standard build of a platform in
edk2-platforms, I would request that this fix is brought into the
upcoming stable tag.
SbsaQemu isn't a "real" platform, so I don't consider that in itself
sufficient reason, but I feel the risk of it affecting other
(including o
On Thu, Nov 18, 2021 at 20:41:15 +0700, Nhi Pham via groups.io wrote:
> From: Vu Nguyen
>
> Provides essential functions to initialize the PCIe Root Complex on
> Ampere Altra processor.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
&
On Thu, Nov 18, 2021 at 20:45:15 +0700, Nhi Pham wrote:
> On 18/11/2021 20:02, Leif Lindholm wrote:
> > Hi Nhi,
> >
> > 9/10 cannot be merged at this point, because that one is dependent on
> > "EmbeddedPkg/AcpiLib: Add more helper functions" to be merged into
ong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
> Cc: Nate DeSimone
>
> Signed-off-by: Nhi Pham
Reviewed-by: Leif Lindholm
(With the caveat that I have been unable to build test to this point
and could theoretically
ree/ampere-upstream-wip-v5
>
> Cc: Vu Nguyen
> Cc: Nhi Pham
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
> Cc: Nate DeSimone
>
> Signed-off-by: Nhi Pham
>
> Changes since
On Wed, Nov 17, 2021 at 23:46:59 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Provides functions to access the NVRAM, NVRAM2 and FailSafe region on the
> Flash over MM communication.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> C
#x27;m using:
gcc version 10.2.1 20210110 (Debian 10.2.1-6)
Best Regards,
Leif
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
> Cc: Nate DeSimone
>
> Signed-off-by: Nhi Pham
> ---
>
On Fri, Nov 12, 2021 at 16:16:01 +, Michael D Kinney wrote:
> Hi Andrew and Leif,
>
> Do you approve this patch for edk2-stable202111?
I'm fine with that one.
Regards,
Leif
> Thanks,
>
> Mike
>
>
> > -Original Message-
> > From: Gerd Hoffmann
> > Sent: Friday, November 12, 2021
These look fine to me.
/
Leif
On Thu, Nov 11, 2021 at 05:27:14 +, Kinney, Michael D wrote:
> Hi Liming,
>
> There are 2 issues that I would like to recommend get committed for the
> edk2-stable20211 tag.
> The code reviews were sent on the Soft Freeze start day, so I want to follow
> t
SynQuacerI2cDxe.c (and no other Socionext source files) has LF instead of
CRLF line endings, so fix that.
Signed-off-by: Leif Lindholm
Cc: Masami Hiramatsu
---
Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c | 1162
++--
1 file changed, 581 insertions
platforms. (This means
that you will be cc:d on any future patches to these, and that I
can use your Reviewed-by for 2/2.)
Does this sound good to you?
Leif Lindholm (2):
Maintainers.txt: add Masami as Socionext reviewer
Silicon/Socionext: fix line endings
Silicon/Socionext/SynQuacer/Drivers
Masami is the main contributor to these platforms, and would be
useful to have listed as a reviewer.
Signed-off-by: Leif Lindholm
Cc: Masami Hiramatsu
---
Maintainers.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index c839c71b2262..093d36e4088d
On Tue, Nov 09, 2021 at 21:20:51 +, Michael D Kinney wrote:
> > > Setting up a development work environment also requires the installation
> > > of tools such as
> > > compilers, NASM, IASL, etc. These are not handled as part of BaseTools
> > > today.
> >
> > No, but users are not required
Hi Mike,
On Tue, Nov 09, 2021 at 16:33:31 +, Michael D Kinney wrote:
> > >> 1. If virtually everyone will need Uncrustify, why cannot it be built
> > >> along with BaseTools from a submodule? Especially
> > >> with the fork that makes sense, after that it depends on the upstream
> > >> (it d
On Tue, Nov 09, 2021 at 09:40:02 +0100, Gerd Hoffmann wrote:
> Hi,
>
> > 3. Require use of uncrustify tool before submitting patch review emails
> > or PRs.
> > * The required version would be a formally released version from
> > the fork maintained by Michael Kubacki until the chan
On Mon, Nov 08, 2021 at 18:56:09 -0700, Rebecca Cran wrote:
> Could I have some reviews on this please?
I'm all for it. It's clunky, but less clunky than the situation
without, and it improves readability at call sites.
Ard had some reservations for v1 not actually adding any users.
Ard - do you
t; ArchSetupExceptionStack always returns EFI_INVALID_PARAMETER in OVMF Ia32
> with XCODE5 and CLANGPDB at least.
>
> Fix this by allocating extra space in mNewGdt and then aligning the
pointer
> upwards.
But I'm happy with this one.
Best Regards,
Leif
> Best wishes,
> Vi
UefiCpuPkg maintainers - please respond.
Meanwhile, Vitaly, could you please provide a commit message?
The BZ link is needed, but it's not a substitute.
/
Leif
On Mon, Sep 20, 2021 at 17:13:47 +0300, Vitaly Cheptsov wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3639
>
>
>
>
; the community.
>
> Cc: Agyeman Prince
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Signed-off-by: Nate DeSimone
With an ack from deleted maintainer *or* someone else from Intel
clarifying why that cannot be given:
Acked-by: Leif Lindholm
> ---
> Maintainers.txt | 6 ++
version rather than a few patches down the set (kees the
reviewer in the same context).
/
Leif
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sean Brogan
> Signed-off-by: Bret Barkelew
> ---
> ArmPkg/L
On Tue, Nov 02, 2021 at 13:17:39 -0700, brbar...@microsoft.com wrote:
> From: Bret Barkelew
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Zhiguang Liu
> Cc: Sean Brogan
> Signed-off-by: Bret Barkelew
For the moving
On Tue, Nov 02, 2021 at 13:17:37 -0700, brbar...@microsoft.com wrote:
> From: Bret Barkelew
>
> TODO: Might keep the name of the .inf. Pending discussion.
Seems a yes on that.
If so:
Reviewed-by: Leif Lindholm
> This aligns better with Mu's philosophy around dependency str
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sean Brogan
> Signed-off-by: Bret Barkelew
Reviewed-by: Leif Lindholm
> ---
> ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c | 3
failure seen
> on Linux GCC ARM builds of the MdeModulePkg due to
> mismatched ABI types between the HII resource section
> and the rest of the libraries.
>
> Cc: Bob Feng
> Cc: Liming Gao
> Cc: Yuwei Chen
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Signed-off-by: M
On Tue, Nov 02, 2021 at 16:34:15 -0700, Andrew Fish via groups.io wrote:
> > No objections to this for any of my use-cases, but I'd like for one of
> > the BaseTools maintainers to comment on whether this breaks anything
> > with regards to EDK_TOOLS_PATH, or if we can finally get rid of that
> > a
a.tianocore.org/show_bug.cgi?id=3652
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sean Brogan
> Signed-off-by: Bret Barkelew
> ---
> ArmPkg/Library/StandaloneMmCoreEntryPoint/X64/StandaloneMmCoreEntryPoint.c |
> 71
>
pos.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652
(Same comment as for preceding patch.)
/
Leif
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
> Cc: Jiewen Yao
> Cc: Supreeth Venkatesh
> Cc: Sean Brogan
> Signed-off-by: Bret Barkelew
pos.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652
I much prefer moving things out of ArmPkg (which shouldn't exist),
than moving things into it. Where would be the logical place for this
to go if ARM wasn't so special it needed its own top-level package?
/
Leif
> Cc: Leif Lin
On Mon, Nov 01, 2021 at 12:56:43 -0700, brbar...@microsoft.com wrote:
> From: Sean Brogan
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651
Some description please.
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sean Brogan
> Signed-off-by: Bret Bark
pos.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3650
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Bob Feng
> Cc: Liming Gao
> Cc: Yuwei Chen
> Cc: Sean Brogan
> Signed-off-by: Bret Barkelew
No objections to this for any of my use-cases, but I'd like for one
On Mon, Nov 01, 2021 at 12:56:37 -0700, brbar...@microsoft.com wrote:
> From: Bret Barkelew
>
> This aligns better with Mu's philosophy around dependency structuring
> and is one of the steps to enable Basecore to have zero CI dependencies
> on other Mu repos.
>
> REF: https://bugzilla.tianocore
On Mon, Nov 01, 2021 at 12:56:36 -0700, brbar...@microsoft.com wrote:
> From: Bret Barkelew
>
> This extra interface is redundant and unnecessary. Dropping it is
> more EDK2-ish.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647
>
> Cc: Leif Lindholm
&g
On Tue, Nov 02, 2021 at 09:34:27 +, Leif Lindholm wrote:
> On Mon, Nov 01, 2021 at 12:56:34 -0700, brbar...@microsoft.com wrote:
> > From: Bret Barkelew
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647
>
> The reference is good, but please still h
On Mon, Nov 01, 2021 at 12:56:34 -0700, brbar...@microsoft.com wrote:
> From: Bret Barkelew
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647
The reference is good, but please still have a summary in the commit
message.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
bug.cgi?id=3647
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sean Brogan
> Signed-off-by: Bret Barkelew
Reviewed-by: Leif Lindholm
> ---
> ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/A
On Mon, Nov 01, 2021 at 12:56:39 -0700, brbar...@microsoft.com wrote:
> From: Bret Barkelew
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Zhiguang Liu
> Cc: Sean Brogan
> Signed-off-by: Bret Barkelew
> ---
core functionality or build tooling that makes sense for it."
>
> Cheers,
> Ryan
>
> ____
> From: devel@edk2.groups.io on behalf of Leif Lindholm
> via groups.io
> Sent: 02 November 2021 08:43
> To: brbar...@microsoft.com
> Cc: deve
Not sure what all module types this HAS been validated against, but it
> doesn't work with STANDALONE_MM or STANDALONE_MM_CORE.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sean Brogan
> Signed-off-by:
On Mon, Nov 01, 2021 at 11:29:38 -0700, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
>
> Use DEBUG_LINE_NUMBER instead of __LINE__.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Michael Kubacki
> Signed-off-by: Michael D Ki
On Mon, Nov 01, 2021 at 11:29:37 -0700, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
>
> * Add DEBUG_LINE_NUMBER define to DebugLib.h that is
> by default mapped to __LINE__. A build can pre-define
> DEBUG_LINE_NUMBER to use a fixed value.
> * Add DEBUG_E
On Mon, Nov 01, 2021 at 18:54:57 +0100, Marcin Juszkiewicz wrote:
> From: Shashi Mallela
>
> Setting the Always-on Capability bit in GTDT table for
> system PE timers in sbsa platform.This is also required
> for ACS sbsa level 3 test compliancy.
>
> Cc: Leif Lindholm
>
quired
> for ACS sbsa level 3 test compliancy.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Graeme Gregory
> Signed-off-by: Shashi Mallela
> ---
> Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
On Thu, Oct 28, 2021 at 09:53:34 +0900, Masami Hiramatsu wrote:
> Hi Leif,
>
> Thank you for your reply!
>
> 2021年10月27日(水) 20:21 Leif Lindholm :
> >
> > Hi Masami,
> >
> > Apologies for delay.
> >
> > Thank you, this set looks good.
> &g
tuations like this, maybe " Co-authored-by" can be used?
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Leif
> > Lindholm via groups.io
> > Sent: Wednesday, October 27, 2021 7:22 AM
> > To: Masami Hiramatsu
> > Cc: Ard
Hi Masami,
Apologies for delay.
Thank you, this set looks good.
However, you cannot make legal statements on behalf of Sakamoto-san,
only yourself. If you are happy with that, I could drop their
Signed-off-by: statements before I push. They would retain the
authorship.
Best Regards,
Leif
On We
to enable an upstream CI
> for edk2-platforms, adding edk2 as a submodule is a convenient
> way to advertise this dependency.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3509
>
> Change-Id: I215789d26e0e835a7350aa9b82798b926816231d
> Cc: Ard Biesheuvel
> Cc:
Hi Pierre,
This patchset is an unambiguous improvement on the current state, and
improves the state of Platform/ARM substantially.
For the series:
Acked-by: Leif Lindholm
/
Leif
On Tue, Oct 26, 2021 at 15:06:28 +0100, Pierre Gondois wrote:
> Hi Leif,
>
> This patch-set
https://github.com/AmpereComputing/edk2-non-osi/tree/add-PciePhyLib
>
> Cc: Ard Biesheuvel
> Cc: Chuong Tran
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Nate DeSimone
> Cc: Phong Vo
> Cc: Thang Nguyen
>
> Signed-off-by: Vu Nguyen
For this series:
Review
Pham
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
> Cc: Nate DeSimone
>
> Signed-off-by: Nhi Pham
>
> Changes since v3:
> We had mainly restructured the PCIe libraries and upda
401 - 500 of 1977 matches
Mail list logo
