Re: [edk2-devel] Patch List for 202008 stable tag

2020-08-20 Thread Liming Gao
Abner: I plan to wait 1~2 days and collect the feedback about delay 202008 stable tag. If no objection, I will help merge this change. Thanks Liming From: devel@edk2.groups.io On Behalf Of Abner Chang Sent: 2020年8月21日 11:22 To: Gao, Liming ; Leif Lindholm ; Laszlo Ersek ; af...@apple.com;

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable

2020-08-20 Thread Liming Gao
Tested-by: Liming Gao -Original Message- From: Dong, Eric Sent: 2020年8月21日 8:39 To: devel@edk2.groups.io; thomas.lenda...@amd.com Cc: Gao, Liming ; Ni, Ray ; Laszlo Ersek ; Kumar, Rahul1 Subject: RE: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement

[edk2-devel] Patch List for 202008 stable tag

2020-08-20 Thread Liming Gao
Hi Stewards and all: I collect current patch lists in devel mail list. Those patch contributors request to add them for 202008 stable tag. Because we have enter into Soft Feature Freeze, I want to collect your feedback for them. If any patches are missing, please reply this mail to add them.

Re: [edk2-devel] [PATCH v5 2/3] MdePkg: PciExpressLib support variable size MMCONF

2020-08-20 Thread Liming Gao
Thanks for your updates. This version is good to me. Reviewed-by: Liming Gao -Original Message- From: Marcello Sylvester Bauer Sent: 2020年8月18日 16:24 To: devel@edk2.groups.io Cc: Patrick Rudolph ; Christian Walter ; Kinney, Michael D ; Gao, Liming Subject: [PATCH v5 2/3] MdePkg

Re: [edk2-devel] [edk2-announce] Re: Soft Feature Freeze starts now for edk2-stable202008

2020-08-19 Thread Liming Gao
> -Original Message- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Wednesday, August 19, 2020 10:59 PM > To: Laszlo Ersek ; Leif Lindholm > Cc: devel@edk2.groups.io; Gao, Liming ; > annou...@edk2.groups.io; af...@apple.com; Kinney, Michael D > > Subject: RE: [edk2-announce]

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable

2020-08-19 Thread Liming Gao
Laszlo: > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Wednesday, August 19, 2020 5:24 PM > To: Tom Lendacky ; devel@edk2.groups.io > Cc: Gao, Liming ; Dong, Eric ; Ni, > Ray ; Kumar, Rahul1 > > Subject: Re: [edk2-devel] [PATCH 1/1]

Re: [edk2-devel] [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg

2020-08-19 Thread Liming Gao
Merged a048af3c9073e4b8108e6cf920bbb35574059639..5a6d764e1d073d28e8f398289ccb5592bf9a72ba Thanks Liming -Original Message- From: devel@edk2.groups.io On Behalf Of Leif Lindholm Sent: 2020年8月18日 19:34 To: Gao, Liming Cc: Sami Mujawar ; devel@edk2.groups.io; bret.barke...@microsoft.com;

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable

2020-08-19 Thread Liming Gao
Tested-by: Liming Gao Reviewed-by: Liming Gao -Original Message- From: Tom Lendacky Sent: 2020年8月18日 21:10 To: devel@edk2.groups.io Cc: Gao, Liming ; Dong, Eric ; Ni, Ray ; Laszlo Ersek ; Kumar, Rahul1 Subject: [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement

Re: [edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 08/11/2020 6:30pm-7:30pm #cal-reminder

2020-08-18 Thread Liming Gao
Below issues will be discussed this week. Welcome the submitter to attend the meeting and provide the detail background. 2903 EDK2 Pla Placehol unassig...@tianocore.org UNCO Platform\ARM\VExpressPkg\DeviceTree: some files still use BSD

[edk2-devel] [edk2-platforms] Platform/Intel: Remove unnecessary comments in file header

2020-08-17 Thread Liming Gao
Signed-off-by: Liming Gao Cc: Zailiang Sun Cc: Yi Qian Cc: Chasel Chiu Cc: Nate DeSimone Cc: Eric Dong --- .../PlatformDxe/Observable/Observable.c | 12 .../SecBoardInitLibNull/Ia32/SecBoardInit.nasm | 6 -- .../PlatformInitPei/PlatformEarlyInit.h

Re: [edk2-devel] [PATCH v15 00/46] SEV-ES guest support

2020-08-17 Thread Liming Gao
t; > On 08/17/20 06:09, Gao, Liming wrote: > >> This patch set have been merged edk2 > 7f7f511c5a74676523ed48435350f6e35282b62b..7f0b28415cb464832155d5b3ff6eb63612f58645 > > > > Thank you! > > Laszlo > > > >> -Original Message- > >>

Re: [edk2-devel] [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg

2020-08-17 Thread Liming Gao
Sami: I think this change is OK. And, Shenglei and Alexei gave reviewed-by before soft feature freeze. Mike, Leif, Andrew and Laszlo: Have you any comments to merge this patch to edk2-stable202008 stable tag. Thanks Liming -Original Message- From: Sami Mujawar Sent: 2020年8月14日

Re: [edk2-devel] [PATCH v10 02/16] .pytool/Plugin: Add a plugin EccCheck

2020-08-16 Thread Liming Gao
This patch set have been merged 7f0b28415cb464832155d5b3ff6eb63612f58645..98946ef352238ac233dbf8df34510fc4e30d9e02. Thanks Liming -Original Message- From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: 2020年8月14日 16:12 To: Zhang, Shenglei ; devel@edk2.groups.io Cc: Sean Brogan

Re: [edk2-devel] [PATCH v15 00/46] SEV-ES guest support

2020-08-16 Thread Liming Gao
This patch set have been merged edk2 7f7f511c5a74676523ed48435350f6e35282b62b..7f0b28415cb464832155d5b3ff6eb63612f58645 Thanks Liming -Original Message- From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: 2020年8月14日 9:20 To: Laszlo Ersek ; Tom Lendacky ; devel@edk2.groups.io Cc

[edk2-devel] Soft Feature Freeze starts now for edk2-stable202008

2020-08-14 Thread Liming Gao
Hi, all We will enter into Soft Feature Freeze phase. In this phase, the feature under review will not be allowed to be pushed. The feature passed review can still be merged. Now, two features have passed code review. If no other comments, I will merge them into this stable tag. They are:

Re: [edk2-devel] [PATCH v10 02/16] .pytool/Plugin: Add a plugin EccCheck

2020-08-14 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: Zhang, Shenglei Sent: 2020年8月14日 15:44 To: devel@edk2.groups.io Cc: Sean Brogan ; Bret Barkelew ; Kinney, Michael D ; Gao, Liming Subject: [PATCH v10 02/16] .pytool/Plugin: Add a plugin EccCheck REF: https://bugzilla.tianocore.org

Re: [edk2-devel] [edk2-wiki][PATCH v3] Update the Boot Guard TOCTOU wiki page.

2020-08-13 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: Jiang, Guomin Sent: 2020年8月12日 15:21 To: devel@edk2.groups.io Cc: Wang, Jian J ; Gao, Liming Subject: [edk2-wiki][PATCH v3] Update the Boot Guard TOCTOU wiki page. The Boot Guard TOCTOU have been migrated into edk2/master. Update

Re: [edk2-devel] [PATCH 0/2] Remove code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES

2020-08-13 Thread Liming Gao
Shenglei: Thanks for your update. The change is good. Reviewed-by: Liming Gao Per Leif change, this patch will be merged after stable tag 202008 is created. Thanks Liming -Original Message- From: Zhang, Shenglei Sent: 2020年8月5日 14:08 To: devel@edk2.groups.io Cc: Wang, Jian J

Re: [edk2-devel] [PATCH v15 00/46] SEV-ES guest support

2020-08-13 Thread Liming Gao
-v24 > > Cc: Andrew Fish > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Benjamin You > Cc: Dandan Bi > Cc: Eric Dong > Cc: Guo Dong > Cc: Hao A Wu > Cc: Jian J Wang > Cc: Jordan Justen > Cc: Julien Grall > Cc: Laszlo Ersek > Cc: Leif Lindh

Re: [edk2-devel] [Patch] BaseTools: Move CreateAsBuiltInf into AutoGenWorker for parallel

2020-08-13 Thread Liming Gao
A little better is also OK. Reviewed-by: Liming Gao -Original Message- From: Feng, Bob C Sent: 2020年8月13日 17:01 To: Gao, Liming ; devel@edk2.groups.io Cc: Chen, Christine Subject: RE: [Patch] BaseTools: Move CreateAsBuiltInf into AutoGenWorker for parallel Liming, I did the test

Re: [edk2-devel] [PATCH v6 2/5] MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe

2020-08-13 Thread Liming Gao
: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Cc: Ard Biesheuvel Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Matthew Carlson --- MdePkg/Library/BaseRngLibDxe/RngDxeLib.c | 200 MdePkg/Library

[edk2-devel] [Patch] BaseTools: Fix the issue in VS2017/VS2019 setting

2020-08-13 Thread Liming Gao
edksetup.bat VS2017 should set VS2017 only. But now, it will set VS2017/VS2019 both. This patch corrects it. Signed-off-by: Liming Gao Cc: Bob Feng Cc: Yuwei Chen --- This patch bases on the change https://edk2.groups.io/g/devel/message/64138 BaseTools/set_vsprefix_envs.bat | 4 1 file

[edk2-devel] [Patch 2/2] BaseTools: Fix the issue in VS prefix setting for VS2017/VS2019

2020-08-13 Thread Liming Gao
. Signed-off-by: Liming Gao Cc: Bob Feng Cc: Yuwei Chen --- BaseTools/set_vsprefix_envs.bat | 6 ++ 1 file changed, 6 insertions(+) diff --git a/BaseTools/set_vsprefix_envs.bat b/BaseTools/set_vsprefix_envs.bat index 38fb0eb260..2627587ba3 100644 --- a/BaseTools/set_vsprefix_envs.bat +++ b

[edk2-devel] [Patch 1/2] BaseTools: Move VS2019 env setting after VS2017 env setting

2020-08-13 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2896 Keep the latest VS version as the last one Signed-off-by: Liming Gao Cc: Bob Feng Cc: Yuwei Chen --- BaseTools/set_vsprefix_envs.bat | 46 - 1 file changed, 23 insertions(+), 23 deletions(-) diff --git

[edk2-devel] [Patch 0/2] Fix the issue to set VS2017 and VS2019 prefix env

2020-08-13 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2896 Cc: Bob Feng Cc: Yuwei Chen Liming Gao (2): BaseTools: Move VS2019 env setting after VS2017 env setting BaseTools: Fix the issue in VS prefix setting for VS2017/VS2019 BaseTools/set_vsprefix_envs.bat | 52

Re: [edk2-devel] [PATCH v14 00/46] SEV-ES guest support

2020-08-12 Thread Liming Gao
t;>>>>> In order to allow a hypervisor to perform functions on behalf of a > >>>>>> guest, there is architectural support for notifying a guest's > >>>>>> operating system when certain types of VMEXITs are about to occur. > >>&

Re: [edk2-devel] [PATCH v14 00/46] SEV-ES guest support

2020-08-12 Thread Liming Gao
ocument [2] > >>>> talks about how SMP booting under SEV-ES is performed. > >>>> > >>>> Since the GHCB page must be a shared (unencrypted) page, the > >>>> processor must be running in long mode in order for the guest and > >>>> hy

Re: [edk2-devel] [Patch] BaseTools: Move CreateAsBuiltInf into AutoGenWorker for parallel

2020-08-12 Thread Liming Gao
into AutoGenWorker for > parallel > > AsBuiltInf can be created during AutoGen phase. Move CreateAsBuiltInf > into AutoGenWorker to make this step run in parallel. > > Signed-off-by: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > --- > BaseTools/Source/Python/AutoGen/Au

Re: [edk2-devel] [PATCH v14 00/46] SEV-ES guest support

2020-08-12 Thread Liming Gao
at the split. >>> >>> [1] >>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww >>> w.amd.com%2Fsystem%2Ffiles%2FTechDocs%2F24593.pdfdata=02%7C01%7 >>> Cthomas.lendacky%40amd.com%7C9c0fb2b16af248090fdb08d83e05c821%7C3dd8 >>&

Re: [edk2-devel] [PATCH v1 1/1] FmpDevicePkg/FmpDxe: Fix Clang build error

2020-08-11 Thread Liming Gao
Tested-by: Liming Gao Reviewed-by: Liming Gao -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: 2020年8月12日 8:24 To: devel@edk2.groups.io Cc: Gao, Liming ; Kinney, Michael D ; Jiang, Guomin ; Xu, Wei6 Subject: [edk2-devel] [PATCH v1 1/1] FmpDevicePkg

Re: [edk2-devel] [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci

2020-08-11 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: Zhang, Shenglei Sent: 2020年8月11日 15:02 To: devel@edk2.groups.io Cc: Feng, Bob C ; Bret Barkelew ; Kinney, Michael D ; Gao, Liming ; Sean Brogan Subject: [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci REF: https

Re: [edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 08/11/2020 6:30pm-7:30pm #cal-reminder

2020-08-10 Thread Liming Gao
Below issues are submitted recently. They will be reviewed in this week meeting. Welcome the reporter join the meeting to introduce the more background and detail. 2886 EDK2 Code unassig...@tianocore.org UNCO --- EmbeddedPkg PrePiHobLib

Re: [edk2-devel] [PATCH v2 9/9] SecurityPkg/Tcg2: handle PRE HASH and LOG ONLY

2020-08-10 Thread Liming Gao
Qi: EccPlugin will be enabled in open CI. Then, ECC result can be checked in open CI result. Now, I use the standalone EccCheck.py from https://github.com/shenglei10/edk2/tree/ecc_script to check the patch set. Thanks Liming -Original Message- From: Zhang, Qi1 Sent: 2020年8月11日 8:54

Re: [edk2-devel] [PATCH v14 00/46] SEV-ES guest support

2020-08-10 Thread Liming Gao
; These patches are based on commit: > 9565ab67c209 ("ShellPkg: smbiosview - Change some type 17 field values > format") > > A version of the tree can be found at: > https://github.com/AMDESE/ovmf/tree/sev-es-v22 > > Cc: Andrew Fish > Cc: Anthony Perard >

Re: [edk2-devel] TianoCore Community Meeting Minutes - August

2020-08-10 Thread Liming Gao
Soumya: I add my comments. Thanks Liming From: devel@edk2.groups.io On Behalf Of Soumya Guptha Sent: 2020年8月7日 11:42 To: annou...@edk2.groups.io; devel@edk2.groups.io Subject: [edk2-devel] TianoCore Community Meeting Minutes - August TianoCore Community Meeting Minutes August 6, 2020

Re: [edk2-devel] [PATCH v2 9/9] SecurityPkg/Tcg2: handle PRE HASH and LOG ONLY

2020-08-10 Thread Liming Gao
Qi: I run ECC plugin (https://edk2.groups.io/g/devel/message/63271) for this patch set. It reports below issues. Can you help update the patches to fix them? EFI coding style error *Error code: 3002 *Non-Boolean comparisons should use a compare operator (==, !=, >, < >=, <=) *file:

Re: [edk2-devel] [PATCH 1/1] Platform/Intel: Add VmgExitLib to required DSC files

2020-08-10 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: Tom Lendacky Sent: 2020年8月10日 21:22 To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Dong, Eric ; Gao, Liming ; Kinney, Michael D ; Agyeman, Prince ; Qian, Yi ; Steele, Kelly ; Sun, Zailiang ; Laszlo Ersek

Re: [edk2-devel] [PATCH v13 00/46] SEV-ES guest support

2020-08-09 Thread Liming Gao
-Original Message- From: Laszlo Ersek Sent: 2020年8月6日 23:39 To: Tom Lendacky ; devel@edk2.groups.io Cc: Brijesh Singh ; Ard Biesheuvel ; Dong, Eric ; Justen, Jordan L ; Gao, Liming ; Kinney, Michael D ; Ni, Ray ; Andrew Fish ; Anthony Perard ; You, Benjamin ; Bi, Dandan ; Dong,

Re: [edk2-devel] 你好我来寻求帮助 Hello, I'm here for help

2020-08-09 Thread Liming Gao
The problem may be in the source directory "edk2-2020.05". Please don't use '.' in the directory name. You can try the directory name with "edk2_202005". Thanks Liming -Original Message- From: devel@edk2.groups.io On Behalf Of Andrew Fish via groups.io Sent: 2020年8月8日 1:30 To:

Re: [edk2-devel] question about MSFT compiler/link option

2020-08-04 Thread Liming Gao
If this global variable is used by code, it will be linked into the final EFI image. You can check whether the generate map file includes it. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Tiger > Liu(BJ-RD) > Sent: Tuesday, August 4, 2020 5:34 PM > To:

Re: [edk2-devel] [Patch] BaseTools: Improve the method of checking queue empty

2020-08-04 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: 2020年8月3日 10:04 To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine ; Lucy Yan Subject: [edk2-devel] [Patch] BaseTools: Improve the method of checking queue empty

Re: [edk2-devel] [PATCH v3 0/3] Use RngLib instead of TimerLib for OpensslLib

2020-08-03 Thread Liming Gao
Hi Matt: With this change, which library instance should be used for the platform? BaseRngLibTimerLib? And, this patch introduces the dependency for RngLib. Then, NetworkPkg and FmpDevicePkg package level build will break. Will you update them? Thanks Liming -Original Message-

Re: [edk2-devel] [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-02 Thread Liming Gao
gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must be set to TRUE. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2860 Signed-off-by: Vladimir Olovyannikov CC: Samer El-Haj-Mahmoud CC: Laszlo Ersek Cc: Zhichao Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Ray Ni Cc: Liming Gao Cc: Nd --- CryptoPkg/Library/OpensslLib

Re: [edk2-devel] [PATCH v13 07/46] MdePkg/BaseLib: Add support for the VMGEXIT instruction

2020-08-02 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: devel@edk2.groups.io On Behalf Of Lendacky, Thomas Sent: 2020年7月31日 2:43 To: devel@edk2.groups.io Cc: Brijesh Singh ; Ard Biesheuvel ; Dong, Eric ; Justen, Jordan L ; Laszlo Ersek ; Gao, Liming ; Kinney, Michael D ; Ni, Ray Subject

Re: [edk2-devel] [PATCH v13 06/46] MdePkg/BaseLib: Add support for the XGETBV instruction

2020-08-02 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: Tom Lendacky Sent: 2020年7月31日 2:43 To: devel@edk2.groups.io Cc: Brijesh Singh ; Ard Biesheuvel ; Dong, Eric ; Justen, Jordan L ; Laszlo Ersek ; Gao, Liming ; Kinney, Michael D ; Ni, Ray Subject: [PATCH v13 06/46] MdePkg/BaseLib: Add

Re: [edk2-devel] [Patch 1/6] EmulatorPkg: Fix spelling mistake for occurred

2020-08-02 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: devel@edk2.groups.io On Behalf Of Michael D Kinney Sent: 2020年8月1日 9:05 To: devel@edk2.groups.io Cc: Justen, Jordan L ; Andrew Fish ; Ni, Ray Subject: [edk2-devel] [Patch 1/6] EmulatorPkg: Fix spelling mistake for occurred REF: https

Re: [edk2-devel] [Patch] BaseTools/GenSec: Fix spelling mistake

2020-08-02 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: devel@edk2.groups.io On Behalf Of Michael D Kinney Sent: 2020年8月1日 9:25 To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [edk2-devel] [Patch] BaseTools/GenSec: Fix spelling mistake REF: https://bugzilla.tianocore.org

Re: [edk2-devel] [Patch 3/6] MdePkg: Fix spelling mistake for occurred

2020-08-02 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: devel@edk2.groups.io On Behalf Of Michael D Kinney Sent: 2020年8月1日 9:05 To: devel@edk2.groups.io Cc: Gao, Liming ; Liu, Zhiguang Subject: [edk2-devel] [Patch 3/6] MdePkg: Fix spelling mistake for occurred REF: https

Re: [edk2-devel] [edk2-platforms] [PATCH] IntelSiliconPkg: IOMMU generic bug fix

2020-07-31 Thread Liming Gao
Lorena: Thanks for your update. Can you correct name style as Star Zeng for below message? Suggested-by: Star Zeng star.z...@intel.com Signed-off-by: lorena.r.de.leon.vazq...@intel.com Thanks Liming From: De Leon

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: Add reviewer for FmpDevicePkg.

2020-07-31 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: Xu, Wei6 Sent: 2020年7月31日 15:29 To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming Subject: [edk2-devel] [PATCH 1/1] Maintainers.txt: Add reviewer for FmpDevicePkg. Add "Wei6 Xu" as reviewer for FmpDevicePkg. Cc:

Re: [edk2-devel] [PATCH v4 2/3] MdePkg/BasePciExpressLib: Support variable size MMCONF

2020-07-30 Thread Liming Gao
ments.com>> Cc: Christian Walter mailto:christian.wal...@9elements.com>> Cc: Michael D Kinney mailto:michael.d.kin...@intel.com>> Cc: Liming Gao mailto:liming@intel.com>> --- MdePkg/MdePkg.dec | 4 + MdePkg/Library/BasePciExp

Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci

2020-07-30 Thread Liming Gao
Rebecca: I have merged all changes of LicenseCheck. You can continue your work. If you meet with any issue, please let me know. Thanks Liming -Original Message- From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: 2020年7月27日 10:35 To: Rebecca Cran ; devel@edk2.groups.io; Zhang

Re: [edk2-devel] [PATCH v2 01/15] .pytool/Plugin: Add a plugin LicenseCheck

2020-07-30 Thread Liming Gao
Merged at e848b58d7c85293cd4121287abcea2d22a4f0620..7f79b736b0a57da71d87c987357db0227cd16ac6 Thanks Liming -Original Message- From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: 2020年7月30日 11:15 To: Zhang, Shenglei ; devel@edk2.groups.io Cc: Sean Brogan ; Bret Barkelew ; Kinney

Re: [edk2-devel] [PATCH 1/2] Revert "BaseTools/PatchCheck.py: Add LicenseCheck"

2020-07-30 Thread Liming Gao
Merged at 137c2c6eff67f4750d77e8e40af6683c412d3ed0 -Original Message- From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: 2020年7月31日 11:14 To: Leif Lindholm Cc: devel@edk2.groups.io; ler...@redhat.com; Andrew Fish ; Kinney, Michael D ; Zhang, Shenglei ; Chen, Christine Subject

Re: [edk2-devel] [PATCH 1/2] Revert "BaseTools/PatchCheck.py: Add LicenseCheck"

2020-07-30 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: Leif Lindholm Sent: 2020年7月14日 19:25 To: Gao, Liming Cc: devel@edk2.groups.io; ler...@redhat.com; Andrew Fish ; Kinney, Michael D ; Zhang, Shenglei ; Chen, Yuwei Subject: Re: [edk2-devel] [PATCH 1/2] Revert "BaseTools/PatchChe

Re: [edk2-devel] [platforms: PATCH 1/1] Marvell/Drivers: MvFvbDxe: Switch to PcdSet64S

2020-07-30 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: devel@edk2.groups.io On Behalf Of Marcin Wojtas Sent: 2020年7月31日 0:06 To: devel@edk2.groups.io Cc: l...@nuviainc.com; ard.biesheu...@arm.com; m...@semihalf.com; j...@semihalf.com; nad...@marvell.com; kos...@marvell.com Subject: [edk2

Re: [edk2-devel] [PATCH v2 01/15] .pytool/Plugin: Add a plugin LicenseCheck

2020-07-29 Thread Liming Gao
With this update, Reviewed-by: Liming Gao If no other comment, I will merge this patch set tomorrow. Thanks Liming -Original Message- From: Zhang, Shenglei Sent: 2020年7月30日 11:08 To: Gao, Liming ; devel@edk2.groups.io Cc: Sean Brogan ; Bret Barkelew ; Kinney, Michael D Subject: RE

Re: [EXTERNAL] [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

2020-07-29 Thread Liming Gao
whitepapers and discussion are relevant). Cc: Jiewen Yao mailto:jiewen@intel.com>> Cc: Chao Zhang mailto:chao.b.zh...@intel.com>> Cc: Jian J Wang mailto:jian.j.w...@intel.com>> Cc: Hao A Wu mailto:hao.a...@intel.com>> Cc: Liming Gao mailto:liming@intel.com>> Cc

Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci

2020-07-29 Thread Liming Gao
-Original Message- From: devel@edk2.groups.io On Behalf Of Andrew Fish via groups.io Sent: 2020年7月29日 23:22 To: edk2-devel-groups-io ; Laszlo Ersek Cc: Kinney, Michael D ; Gao, Liming ; Zhang, Shenglei ; Sean Brogan ; Bret Barkelew ; Dong, Eric ; Gao, Zhichao ; Yao, Jiewen ;

Re: [edk2-devel] [PATCH v2 01/15] .pytool/Plugin: Add a plugin LicenseCheck

2020-07-29 Thread Liming Gao
BSD-2-Clause-Patent. files which are now contributed under BSD-2-Clause-Patent. ==> files which are not contributed under BSD-2-Clause-Patent. Thanks Liming > > Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Michael D Kinney > Cc: Liming Gao > Signed-off-by: Shenglei Zhan

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: Add "Guomin Jiang" as reviewer for Crypto and Capsule

2020-07-29 Thread Liming Gao
Reviewed-by: Liming Gao for FmpDevicePkg and MdeModulePkg. > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, July 29, 2020 5:10 PM > To: Jiang, Guomin ; devel@edk2.groups.io > Cc: Andrew Fish ; Leif Lindholm ; Kinney, > Michael D ; Yao, > Jiewen

Re: [edk2-devel] [PATCH] MdePkg: Remove code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES

2020-07-29 Thread Liming Gao
Include Leif and Ard. This change may impact ARM platform. Thanks Liming -Original Message- From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: 2020年6月9日 21:08 To: Zhang, Shenglei ; devel@edk2.groups.io Cc: Kinney, Michael D Subject: Re: [edk2-devel] [PATCH] MdePkg: Remove code

Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci

2020-07-29 Thread Liming Gao
nto open ci so that license issues can > still be checked > > after the checker is disabled in PatchCheck.py. > > 1/15 is the plugin implementation. > > 2/15 ~ 15/15 introduce sections "IgnoreFiles" to allow > developers to > > skip license check for some files

Re: [edk2-devel] [PATCH 01/15] .pytool/Plugin: Add a plugin LicenseCheck

2020-07-29 Thread Liming Gao
ps://bugzilla.tianocore.org/show_bug.cgi?id=2833 > > Add a plugin to check license conflict for new added files in a > > patch. It will report out errors when meeting files which are now > > contributed under BSD-2-Clause- Patent or BSD-3-Clause-Patent. > > > > Cc: Sea

Re: [edk2-devel] [PATCH] BaseTools/PeCoffLoaderEx: Remove the unused local variable

2020-07-28 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: devel@edk2.groups.io On Behalf Of Abner Chang Sent: 2020年7月25日 10:35 To: devel@edk2.groups.io Cc: abner.ch...@hpe.com; Feng, Bob C ; Gao, Liming ; Daniel Schaefer Subject: [edk2-devel] [PATCH] BaseTools/PeCoffLoaderEx: Remove the unused

Re: [edk2-devel] [PATCH v12 07/46] MdePkg/BaseLib: Add support for the VMGEXIT instruction

2020-07-28 Thread Liming Gao
Laszlo: Yes. This solution makes sense. Thanks Liming -Original Message- From: Laszlo Ersek Sent: 2020年7月28日 23:19 To: Tom Lendacky ; Gao, Liming ; devel@edk2.groups.io Cc: Brijesh Singh ; Ard Biesheuvel ; Dong, Eric ; Justen, Jordan L ; Kinney, Michael D ; Ni, Ray Subject: Re:

Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci

2020-07-28 Thread Liming Gao
d files. > > Only BSD-2-Clause-Patent and BSD-3-Clause-Patent can pass this > checker. > > Cc: Michael D Kinney > Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Eric Dong > Cc: Laszlo Ersek > Cc: Zhichao Gao > Cc: Jiewen Yao > Cc: Chao Zhang > Cc: Jo

Re: [edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 07/28/2020 6:30pm-7:30pm #cal-reminder

2020-07-28 Thread Liming Gao
The following Bug will be reviewed this week. Welcome the reporter join the meeting to introduce the more background and detail. Thanks Liming

Re: [edk2-devel] [PATCH v12 07/46] MdePkg/BaseLib: Add support for the VMGEXIT instruction

2020-07-28 Thread Liming Gao
; >> -Original Message- > >> From: Tom Lendacky > >> Sent: 2020t727å 23:26 > >> To: devel@edk2.groups.io > >> Cc: Brijesh Singh ; Ard Biesheuvel > >> ; Dong, Eric ; Justen, > >> Jordan L ; Laszlo Ersek > >> ; Gao, Liming

Re: [edk2-devel] [PATCH v12 07/46] MdePkg/BaseLib: Add support for the VMGEXIT instruction

2020-07-28 Thread Liming Gao
ccur, resulting in a #VMEXIT with an exit code value of 0x403. > > Provide the necessary support to execute the VMGEXIT instruction, which is > "rep; vmmcall". > > Cc: Michael D Kinney > Cc: Liming Gao > Signed-off-by: Tom Lendacky > --- > MdePkg/Librar

Re: [edk2-devel] [Patch] MdePkg/Library/UnitTestHostBaseLib: Add missing services

2020-07-28 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: Kinney, Michael D Sent: 2020年7月24日 9:24 To: devel@edk2.groups.io Cc: Gao, Liming ; Sean Brogan ; Bret Barkelew Subject: [Patch] MdePkg/Library/UnitTestHostBaseLib: Add missing services REF: https://bugzilla.tianocore.org/show_bug.cgi

Re: [edk2-devel] [PATCH V4 1/2] MdePkg/Include/IndustryStandard: CXL 1.1 Registers

2020-07-27 Thread Liming Gao
Leif: -Original Message- From: Leif Lindholm Sent: 2020年7月28日 0:14 To: Gao, Liming Cc: devel@edk2.groups.io; Javeed, Ashraf ; Kinney, Michael D Subject: Re: [edk2-devel] [PATCH V4 1/2] MdePkg/Include/IndustryStandard: CXL 1.1 Registers On Mon, Jul 27, 2020 at 14:55:03 +, Gao,

Re: [edk2-devel] [PATCH] Maintainers.txt: Add 'Yuwei Chen' for Tools review

2020-07-27 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: Chen, Christine Sent: 2020年7月24日 16:55 To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH] Maintainers.txt: Add 'Yuwei Chen' for Tools review Add 'Yuwei Chen' as a reviewer for Edk2-platforms\Platform\Intel\Tools

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: Add 'Yuwei Chen' for BaseTools review

2020-07-27 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: Chen, Christine Sent: 2020年7月24日 16:39 To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH 1/1] Maintainers.txt: Add 'Yuwei Chen' for BaseTools review Add 'Yuwei Chen' as a reviewer for Edk2\BaseTools. Cc: Liming

Re: [edk2-devel] [PATCH v4 2/3] MdePkg/BasePciExpressLib: Support variable size MMCONF

2020-07-27 Thread Liming Gao
Cc: Michael D Kinney Cc: Liming Gao --- MdePkg/MdePkg.dec | 4 + MdePkg/Library/BasePciExpressLib/BasePciExpressLib.inf | 6 +- MdePkg/Include/Library/PciExpressLib.h | 5 +- MdePkg/Library/BasePciExpressLib/PciExpressLib.c | 216

Re: [edk2-devel] [PATCH v12 07/46] MdePkg/BaseLib: Add support for the VMGEXIT instruction

2020-07-27 Thread Liming Gao
will cause an automatic exit (AE) to occur, resulting in a #VMEXIT with an exit code value of 0x403. Provide the necessary support to execute the VMGEXIT instruction, which is "rep; vmmcall". Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Tom Lendacky --- MdePkg/Library/BaseLib/B

Re: [edk2-devel] [PATCH v8 0/9] Add new feature that evacuate temporary to permanent memory (CVE-2019-11098)

2020-07-27 Thread Liming Gao
PR https://github.com/tianocore/edk2/pull/830 is created for this patch set. -Original Message- From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: 2020年7月27日 11:55 To: devel@edk2.groups.io; Jiang, Guomin Subject: Re: [edk2-devel] [PATCH v8 0/9] Add new feature that evacuate

Re: [edk2-devel] [PATCH v5 4/5] BaseTools: Compile AML bytecode arrays into .obj file

2020-07-27 Thread Liming Gao
in $(OUTPUT_DIR). Maybe it should be modified to $(DEBUG_DIR) aswell. Regards, Pierre -Original Message- From: devel@edk2.groups.io On Behalf Of Liming Gao via groups.io Sent: Monday, July 27, 2020 3:21 PM To: Leif Lindholm ; devel@edk2.groups.io; Pierre Gondois ; Masahisa Kojima Cc

Re: [edk2-devel] [PATCH v2] MdePkg Base.h: Delete prototype for __builtin_return_address

2020-07-27 Thread Liming Gao
PR https://github.com/tianocore/edk2/pull/829 has been created. -Original Message- From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: 2020年7月27日 10:18 To: Jessica Clarke ; devel@edk2.groups.io Cc: l...@nuviainc.com; Kinney, Michael D Subject: Re: [edk2-devel] [PATCH v2] MdePkg

Re: [edk2-devel] [PATCH V4 1/2] MdePkg/Include/IndustryStandard: CXL 1.1 Registers

2020-07-27 Thread Liming Gao
ion of upgraded Pci.h. > > > > Signed-off-by: Ashraf Javeed > > Cc: Michael D Kinney > > Cc: Liming Gao > > -- > > > > V4: fix code style > > > > V3: Copyright date fix

Re: [edk2-devel] [PATCH v5 4/5] BaseTools: Compile AML bytecode arrays into .obj file

2020-07-27 Thread Liming Gao
Leif: VFR file has the similar case. VFR is converted to xxx.c, then compile it to obj file. Bob: Has BaseTools such detection if VFR and C source file have the same file name? Thanks Liming > -Original Message- > From: Leif Lindholm > Sent: Monday, July 27, 2020 9:58 PM > To:

Re: [edk2-devel] [PATCH v8 0/9] Add new feature that evacuate temporary to permanent memory (CVE-2019-11098)

2020-07-26 Thread Liming Gao
Reviewed-by: Liming Gao for this patch set. -Original Message- From: devel@edk2.groups.io On Behalf Of Guomin Jiang Sent: 2020年7月24日 17:55 To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v8 0/9] Add new feature that evacuate temporary to permanent memory (CVE-2019-11098

Re: [edk2-devel] [PATCH V4 0/2] CXL Specification Registers

2020-07-26 Thread Liming Gao
. Reviewed-by: Liming Gao -Original Message- From: Javeed, Ashraf Sent: 2020年7月25日 2:26 To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming Subject: [PATCH V4 0/2] CXL Specification Registers These 2 patches introduces the Compute Express Link (CXL) Specificition defined registers

Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci

2020-07-26 Thread Liming Gao
Shenglei: I have one comment. Seemly, LicenseCheck_plug_in.yaml copyright may be Intel one. Reviewed-by: Liming Gao for this patch set. Thanks Liming -Original Message- From: Zhang, Shenglei Sent: 2020年7月20日 16:37 To: devel@edk2.groups.io Cc: Kinney, Michael D ; Sean Brogan

Re: [edk2-devel] [PATCH V4 0/2] CXL Specification Registers

2020-07-26 Thread Liming Gao
This version is good to me. Reviewed-by: Liming Gao -Original Message- From: Javeed, Ashraf Sent: 2020年7月25日 2:26 To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming Subject: [PATCH V4 0/2] CXL Specification Registers These 2 patches introduces the Compute Express Link (CXL

Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci

2020-07-26 Thread Liming Gao
Rebecca: I see Shenglei patch. I plan to finish review early of this week, then merge this patch set, and revert the original change in PatchCheck.py. Thanks Liming -Original Message- From: Rebecca Cran Sent: 2020年7月25日 9:38 To: devel@edk2.groups.io; Zhang, Shenglei Cc: Kinney,

Re: [edk2-devel] [PATCH v2] MdePkg Base.h: Delete prototype for __builtin_return_address

2020-07-26 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: Jessica Clarke Sent: 2020年7月27日 9:59 To: devel@edk2.groups.io Cc: Jessica Clarke ; Gao, Liming ; l...@nuviainc.com; Kinney, Michael D Subject: [PATCH v2] MdePkg Base.h: Delete prototype for __builtin_return_address REF: https

Re: [edk2-devel] [PATCH v11 06/46] MdePkg/BaseLib: Add support for the XGETBV instruction

2020-07-23 Thread Liming Gao
gt; >>> BZ: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198d > ata=02%7C01%7Cthomas.lendacky%40amd.com%7C7cbbd5ae7ded4963ad1e08d82ea5ff27%7C3dd8961fe4884e608e11a82d994e183d% > 7C0%7C0%7C637310637778599307sdat

Re: [edk2-devel] [PATCH V3 1/2] MdePkg/Include/IndustryStandard: CXL 1.1 Registers

2020-07-23 Thread Liming Gao
-by: Ashraf Javeed Cc: Michael D Kinney Cc: Liming Gao -- V2: Indentation and double declaration fix, copyright date update V3: Copyright date fix --- MdePkg/Include/IndustryStandard/Cxl11.h | 569

Re: [edk2-devel] [PATCH v3 2/3] MdePkg/BasePciExpressLib: Support variable size MMCONF

2020-07-23 Thread Liming Gao
variable size MMCONF Add support for arbitrary sized MMCONF by introducing a new PCD. Signed-off-by: Patrick Rudolph Signed-off-by: Marcello Sylvester Bauer Cc: Patrick Rudolph Cc: Christian Walter Cc: Michael D Kinney Cc: Liming Gao --- MdePkg/MdePkg.dec

Re: [edk2-devel] [PATCH V3 2/2] MdePkg/Include/IndustryStandard: Main CXL header

2020-07-23 Thread Liming Gao
as the main header file to support all versions of Compute Express Link Specification register definitions. Signed-off-by: Ashraf Javeed Cc: Michael D Kinney Cc: Liming Gao -- V2: Indentation and double declaration fix, copyright date update V3: Copyright date fix --- MdePkg/Include

Re: [edk2-devel] [PATCH v11 03/46] MdePkg: Add the MSR definition for the GHCB register

2020-07-23 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: devel@edk2.groups.io On Behalf Of Lendacky, Thomas Sent: 2020年7月22日 5:19 To: devel@edk2.groups.io Cc: Brijesh Singh ; Ard Biesheuvel ; Dong, Eric ; Justen, Jordan L ; Laszlo Ersek ; Gao, Liming ; Kinney, Michael D ; Ni, Ray Subject

Re: [edk2-devel] [PATCH v11 04/46] MdePkg: Add a structure definition for the GHCB

2020-07-23 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: Tom Lendacky Sent: 2020年7月22日 5:19 To: devel@edk2.groups.io Cc: Brijesh Singh ; Ard Biesheuvel ; Dong, Eric ; Justen, Jordan L ; Laszlo Ersek ; Gao, Liming ; Kinney, Michael D ; Ni, Ray Subject: [PATCH v11 04/46] MdePkg: Add

Re: [edk2-devel] [PATCH v11 06/46] MdePkg/BaseLib: Add support for the XGETBV instruction

2020-07-22 Thread Liming Gao
ruction >> >> From: Tom Lendacky >> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 >> >> Under SEV-ES, a CPUID instruction requires the current value of the >> XCR0 register. In order to retrieve that value, the XGETBV >> instructi

Re: [edk2-devel] [PATCH] MdePkg Base.h: Delete prototype for __builtin_return_address

2020-07-22 Thread Liming Gao
On Behalf Of Liming Gao Sent: 2020年7月21日 10:30 To: Jessica Clarke Cc: devel@edk2.groups.io; l...@nuviainc.com; Kinney, Michael D Subject: Re: [edk2-devel] [PATCH] MdePkg Base.h: Delete prototype for __builtin_return_address Jess: OK. Seemly, there is no impact with this change. Reviewed

Re: [edk2-devel] [PATCH v2 1/1] BaseLib:Fix RISC-V Supervisor mode (S-Mode) trap handler reentry issue.

2020-07-22 Thread Liming Gao
Acked-by: Liming Gao -Original Message- From: Abner Chang Sent: 2020年7月22日 16:54 To: devel@edk2.groups.io Cc: abner.ch...@hpe.com; Daniel Schaefer ; Kinney, Michael D ; Gao, Liming ; Leif Lindholm Subject: [PATCH v2 1/1] BaseLib:Fix RISC-V Supervisor mode (S-Mode) trap handler

Re: [edk2-devel] [PATCH] Maintainers.txt: Add 'Zhiguang Liu' for MdePkg review

2020-07-22 Thread Liming Gao
' for MdePkg review Hi Liming, On 07/20/20 16:30, Liming Gao wrote: > Reviewed-by: Liming Gao can you merge the patch, please? Thanks! Laszlo >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of >> Zhiguang Liu >> Sent: Monday, July 20, 2020 4:53 PM >&g

Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts: Ignore the CRLF check when upgrade submodule.

2020-07-22 Thread Liming Gao
de submodule. > > > > When i upgrade openssl to 1.1.1g, error occurred when run PatchCheck.py. > > The reason is that the submodule will end with LF, but it will check > > based on file rule, it make no sense and need ignore the check. > > > > Signed-off-by

Re: [edk2-devel] [PATCH v6 10/10] MdeModulePkg/Core: Avoid redundant shadow when enable the Migrated PCD (CVE-2019-11098)

2020-07-22 Thread Liming Gao
te more boot time. it is unnecessary, so the only valid > choice is to enable PcdMigrateTemporaryRamFirmwareVolumes and disable > PcdShadowPeimOnBoot. You could add similar clarification in dec where the new PCD is defined. > > Signed-off-by: Guomin Jiang > Cc: Jian J Wang > Cc: Hao A

Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts: Ignore the CRLF check when upgrade submodule.

2020-07-21 Thread Liming Gao
Guomin: OK. Please add this information in the patch for better reading. With this change, Reviewed-by: Liming Gao Thanks Liming -Original Message- From: Jiang, Guomin Sent: 2020年7月21日 18:38 To: Gao, Liming ; devel@edk2.groups.io Cc: Feng, Bob C Subject: RE: [PATCH 1/1] BaseTools

  1   2   3   4   5   6   7   8   9   10   >